[Koha-bugs] [Bug 5801] C4::Circulation::_GetCircControlBranch doesn't work in opac-reserve.pl

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5801

--- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to comment #10)
> (In reply to comment #9)
> > I think this patch is still valid because we shouldn't be using
> > _GetCircControlBranch here anyway, as this is reserves related.
> 
> Does the patch solve a problem with the way holds work? If so, how does one
> reproduce the problem and test the patch?

The problem is that CircControl is meant to return the library code to be used
to determine which circulation policy applies to a transaction, *not* reserves
policy.

So, a library has set CircControl to use the checkout and fines rules of the
library the item is from. 
The library has also set ReservesControlBranch to check the patron's home
library to see if the patron can place a hold on the item.

In this case, the reserves rules used will be those of the item's home library,
not those of the patron's home library. This seems like a fairly serious bug.
Koha is not doing what it says it will do.

-- 
You are receiving this mail because:
You are watching all bug changes.