[Koha-bugs] [Bug 8710] Do not show the images tab in the OPAC if the record has no local cover images

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Nov 8 01:31:45 CET 2012


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8710

Melia Meggs <melia at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #13072|0                           |1
        is obsolete|                            |

--- Comment #2 from Melia Meggs <melia at bywatersolutions.com> ---
Created attachment 13297
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13297&action=edit
[Signed off] Bug 8710 - Don't show the images tab in the OPAC if the record has
no local images

For unknown reasons, having ListImagesForBiblio return undef
when there are no images still results in a variable being passed
to the template which evaluates as true, with a size of 1.

This patch alters ListImagesForBiblio to remove the "return undef"
condition, allowing the template to evaluate images as false
and show no tab.

To test, turn on local cover images and view records in the OPAC
which do and do not have cover images attached. Images should
display as expected when present, and no images tab should appear
on records which have none.

Signed-off-by: Melia Meggs <melia at test.bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list