[Koha-bugs] [Bug 9017] Quote of the day: Table footer not translated

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9017

Chris Nighswonger <cnighswonger at foundations.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #6 from Chris Nighswonger <cnighswonger at foundations.edu> ---
(In reply to comment #5)
> I tried for several hours but I can't make it work with the approach Owen
> suggested. It seems that the table definition is to complex to be merged
> with dataTablesDefaults.

This is true. dataTablesDefaults seemed to impose some restrictions which I was
unable to workaround. And I seem to recall not being able to modify the
extension to render it usable for my purposes.

> 
> My patch would be a workaround to avoid untranslated strings and does not
> break anything, but maybe somebody else (the original author of this
> feature?) is able to put the code in a way that it does not fail QA.

I think this is a good workaround. It uses the same basic approach as the
extension and one which is (iirc) recommended in the DT documentation. It would
be nice to explore the idea of separating the strings from dataTablesDefaults,
allowing perhaps a more benign extension of DT to just include strings.

Changing the status back to "Needs Signoff." I don't have multiple translations
installed atm, so if someone who does could verify and sign-off, that would be
good.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.