[Koha-bugs] [Bug 9002] Remove Problematic Logic from Patron Messaging Preferences Form

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9002

--- Comment #6 from David Cook <dcook at prosentient.com.au> ---
(In reply to comment #5)
> (In reply to comment #2)
> > Is there some other system preference that I need to change that will knock
> > things out of alignment?
> 
> I don't see the problem in my installation either. From the description this
> sounds like a problem we had some time ago and fixed.

Thanks for your comments Melia and Owen.

I should've mentioned that message_transport_type is set in the database, so
you would have to delete the message_transport_type of "sms" from your database
in order to see the layout problem.

I've done some additional research, and I think the message_transport_type of
"sms" was introduced back around version 3.1, so it "shouldn't" be missing from
the database. I'm not sure why it was missing in the case I encountered. I
think 99% of the time, the logic I outlined above wouldn't be a problem.

This patch is for the other 1% and just to remove senseless code. 

To test it...I would suggest applying the patch and then try it with
SMSSendDrive turns on and with it turned off. If it doesn't break anything, I
would say that it's working.

-- 
You are receiving this mail because:
You are watching all bug changes.