[Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not calculate rank of hold

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918

--- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to comment #5)
> Have you checked that it works as expected in all cases ? (just asking, I
> haven't proved there's a problem)

Not in *all* cases because I just can't imagine *all* test cases here, but I
tested different scenario.
I agree that _get_reserve_next_rank should move from C4::ILSDI.
About the syspref ReservesNeedReturns, I'm not sure of what it deserves, but
the sure thing is that rank should not be calculated if ReservesNeedReturns =
0.

I'll send the patch soon.

-- 
You are receiving this mail because:
You are watching all bug changes.