[Koha-bugs] [Bug 9103] overdue_notices.pl should use AutoEmailPrimaryAddress syspref

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Sun Nov 25 18:56:59 CET 2012


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9103

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Fridolyn,

I like the idea to have a new sub that returns the correct email for the
borrower according to the AutoEmailPrimaryAddress system preference.

What bugs me a bit about it is the name of the new sub
"GetPrimaryEmailAddress". I am not sure if you are aware of it, but some time
ago the email and phone number fields in the patron record got renamed. The
first email field in the English templates is now named 'Primary email:' - That
makes it a bit confusing.

Could you maybe choose a better name? Extra bonus points if you include some
unit tests.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list