[Koha-bugs] [Bug 9031] Overdue items crossing DST boundary throw invalid local time exception

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9031

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
   Patch complexity|---                         |Small patch

--- Comment #8 from Chris Cormack <chris at bigballofwax.co.nz> ---
Hi Robson

Thanks for the valid patch, however it is causing the unit tests to fail.

perl t/Calendar.t                        
1..26
ok 1 - use Koha::Calendar;
ok 2 - use C4::Calendar;
ok 3 - Calendar class returned isa Koha::Calendar
ok 4 - Sunday is a closed day
ok 5 - Monday is not a closed day
ok 6 - month/day closed day test
ok 7 - special closed day test
ok 8 - open day test
ok 9 - addDate skips closed Sunday
ok 10 - Negative call to addDate
ok 11 - days_between calculates correctly
ok 12 - is holiday for the next test
not ok 13 - Date should be the same after is_holiday
#   Failed test 'Date should be the same after is_holiday'
#   at t/Calendar.t line 99.
#          got: '2012-09-17T16:30:00'
#     expected: '2012-09-17T17:30:00'
ok 14 - test larger intervals
ok 15 - test positive intervals
ok 16 - test parameter order not relevant
ok 17 - days_between calculates correctly
not ok 18 - holiday correctly recognized
#   Failed test 'holiday correctly recognized'
#   at t/Calendar.t line 119.
#          got: 14
#     expected: 13
not ok 19 - multiple holidays correctly recognized
#   Failed test 'multiple holidays correctly recognized'
#   at t/Calendar.t line 124.
#          got: 14
#     expected: 12
ok 20 - Single day add (Datedue, matches holiday, shift)
ok 21 - Two days add, skips holiday (Datedue)
not ok 22 - Add 7 days (Datedue)
#   Failed test 'Add 7 days (Datedue)'
#   at t/Calendar.t line 145.
#          got: '2012-07-30T10:53:00'
#     expected: '2012-07-30T11:53:00'
ok 23 - Single day add (Calendar)
not ok 24 - Add 7 days (Calendar)
#   Failed test 'Add 7 days (Calendar)'
#   at t/Calendar.t line 162.
#          got: '2012-07-31T10:53:00'
#     expected: '2012-07-31T11:53:00'
ok 25 - Single day add (Days)
not ok 26 - Add 7 days (Days)
#   Failed test 'Add 7 days (Days)'
#   at t/Calendar.t line 179.
#          got: '2012-07-30T10:53:00'
#     expected: '2012-07-30T11:53:00'
# Looks like you failed 6 tests of 26.


Could you have a look at this please.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.