[Koha-bugs] [Bug 7298] export late orders, with # of claims and claim dates

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |paul.poulain at biblibre.com

--- Comment #21 from Paul Poulain <paul.poulain at biblibre.com> ---
QA comment
 1- bug signed-off since more than 1 month, dealing with QA myself
 2- qa.pl script shows some errors, easy to solve (use COALESCE instead of
IFNULL & use spaces for indent)
 3- replaces a SQL query in GetOrder in an unsafe way imo:
   - add many table.* to an already very long query (was
biblio+biblioitems+aqorders, and adds aqbudgets+aqbasket) Would be better not
to use * (including biblioitems, that contains marcxml field !!! was already
here before the patch, but if you can fix it...)
   - does some changes that look strange : why DATE(aqbasket.closedate)  AS
orderdate ? why aqorders.quantity - IFNULL(aqorders.quantityreceived,0) AS
quantity -quantity is a field from aqorders ? 
 4- the form $$order{estimateddeliverydate} must be discarded in favor of
$order->{estimateddeliverydate}

Failing QA for #4, need info (and maybe fix) for #3

-- 
You are receiving this mail because:
You are watching all bug changes.