[Koha-bugs] [Bug 8739] Partial Fine Payments Saving Amount Paid Incorrectly

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Oct 3 18:03:04 CEST 2012


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8739

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |paul.poulain at biblibre.com
            Version|master                      |rel_3_8

--- Comment #5 from Paul Poulain <paul.poulain at biblibre.com> ---
QA comment:
 * the makepayement sub also reverse the amount paid:
         # create new line
        my $payment = 0 - $amount;
        my $ins = 
            $dbh->prepare( 
                "INSERT 
                    INTO accountlines (borrowernumber, accountno, date, amount,
itemnumber, description, accounttype, amountoutstanding, manager_id)
                    VALUES ( ?, ?, now(), ?, ?, 'Payment,thanks', 'Pay', 0, ?)"
            );
   so it's consistent
 * tiny patch (and it's a bugfix !)
 * koha-qa.pl OK (there were 2 perlcritic violations, that were not related to
this patch, and that i've fixed)

passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list