[Koha-bugs] [Bug 8559] conflicting item statuses

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8559

--- Comment #14 from Mason James <mtj at kohaaloha.com> ---
(In reply to comment #13)
> (In reply to comment #12)
> > (In reply to comment #11)
> > > Created attachment 12281 [details]
> > > [SIGNED-OFF] Bug 8559 - conflicting item statuses - Force cancel or revert
> > > Signed-off-by: Owen Leonard <oleonard at myacpl.org>
> > > 
> > > All three cases tested, correct outcome each time
> > 
> > 
> > just a little QA thing...
> > 
> > please fix patch so RevertWaitingStatus takes a scalar
> 
> I don't see a compelling reason to do that, there are plenty of subroutines
> that pass hashes for parameters. 

hmm, no

those 'plently of subroutines' are passing *hashrefs*, not hashes
so, if you want to pass a hash, pass a hashref instead

why? its faster and uses less memory :)


"Use references

If you work with large arrays or hashes and use them as arguments to functions,
use a reference instead of the variable directly. By using a reference, you
tell the function to point to the information. Without a reference, you copy
the entire array or hash onto the function call stack, and then copy it again
in the function. References also save memory (which reduces footprint and
management overheads) and simplify your programming."

http://www.ibm.com/developerworks/library/l-optperl/index.html

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.