[Koha-bugs] [Bug 8804] Quiet errors in the log from Auth.pm

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8804

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA
                 CC|                            |paul.poulain at biblibre.com

--- Comment #4 from Paul Poulain <paul.poulain at biblibre.com> ---
QA comment:
OK, i'm a little bit excessive, but that's what QA is made for ;-)

Unless i'm mistaking, there is a useless ()
+        if ((($opac_search_limit && $opac_search_limit =~ /branch:(\w+)/) &&
$opac_limit_override) || ($in->{'query'}->param('limit') &&
$in->{'query'}->param('limit') =~ /branch:(\w+)/)){

can be written
+        if (($opac_search_limit && $opac_search_limit =~ /branch:(\w+)/ &&
$opac_limit_override) || ($in->{'query'}->param('limit') &&
$in->{'query'}->param('limit') =~ /branch:(\w+)/)){

=> if ((A && B && C) || (D && E))
am I right ? If yes, please fix & resubmit

-- 
You are receiving this mail because:
You are watching all bug changes.