[Koha-bugs] [Bug 7294] status "in order"
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Tue Oct 9 14:52:11 CEST 2012
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294
Paul Poulain <paul.poulain at biblibre.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
CC| |paul.poulain at biblibre.com
--- Comment #43 from Paul Poulain <paul.poulain at biblibre.com> ---
QA comments:
* this patch touches core features, I won't push it for 3.10 (Feature Freeze)
* There are many $$x{Y} that should be written $x->{Y}
* I think/fear that the aqorders.branchcode feature is a bad idea: how will it
work when syspref AcqCreateItem=ordering ? How will you deal, when you don't
have AcqCreadItem=ordering, with creation of items, will this value be used for
defining the branch ? How will you deal with cases where you order 3 items for
different branches ? The items table has some fields that are already related
to acquisition: items.booksellerid, items.price, items.replacementprice.
* I don't see why the "aqorders.uncertainprice" should be ported to MARC, but
maybe there's a use-case I don't see
As a conclusion, what is requested from QA point of view:
* split the patch in 2, to separate branchcode feature from the link2marc
feature, that's 2 different things
* fix $${}
* argue how this feature will integrate smoothly with various acqcreateitem
possibilities
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list