[Koha-bugs] [Bug 8190] Koha does not have a logging module

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190

--- Comment #26 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to comment #21)
> Hi Kyle,
> Thanks for your followup !
> 2 small remarks about your patch:
> * you commited mainpage.pl unfortunately
Fixed!

> * the added block of code in Logger::write is not perltidied
Fixed!

> Else all seems good but we have to pull together on how we will use the
> logger.

I think it would be simple enough to replace all existing warns with the
logger. I can volunteer some time to do this.

> Your idea to add a global var in C4::Context is what I had at the beginning
> of my work. But after thinking, on this way, we canot change the loglevel
> for 1 script ! And it is a regression (indeed currently we can do that,
> changing the DEBUG var).

Would it be possible to add support for the DEBUG variable to the logger? 

> My idea was to add 
>   use C4::Logger qw/$log/;
>   $log = C4::Logger->new({level => C4::Context->preference("LogLevel")});
> on each page. Like that we could change the log level easily.

That would work, but it would be nice to follow the DRY principle. However, if
you think it is not possible to place it in C4::Context, then I will believe
you.

-- 
You are receiving this mail because:
You are watching all bug changes.