[Koha-bugs] [Bug 8872] Encoding issues; corresponding changes to showmarc

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8872

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |minor

--- Comment #1 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
I had some incidental cases where diacritical characters a.o. were wrongly
encoded in Koha. This appeared to originate from the Template output routine.
This routine encodes all variables before sending them out. But merging these
values with other non-encoded variables [somewhere in the template process
call] may occasionally let Perl make a wrong choice when encoding/decoding. The
attached patches are proposed to resolve the situation and make Koha more
consistent.

Patch 1
Adds specific encoding parameter when creating Template object.
Note that the instruction binmode => ':utf8' could have been added also to the 
process method. But since it outputs to a Perl variable, this is not needed.
Finally, instead of the old encoding of all parameters before processing, the 
output of process is encoded to UTF-8 octets. Note that Perl could have handled
this internally, but this would require adding a use open statement, setting IO
layers to UTF-8 in all scripts.

Patch 2
Add UTF-8 encoding to intranet xslt files in output clause.

Patch 3
Add UTF-8 encoding to opac xslt files also.
Does also fix head and body tags in MARC21slim2OPACMARCdetail.xsl.

Patch 4
Simplifies opac-showmarc template (eliminating opac-bottom include).
Makes encoding for card and html view more consistent with approach in 
Templates module.
Rearranges a few lines in script for consistency and performance.

Patch 5
Simplifies showmarc template (eliminating intranet-bottom include).
Makes encoding for card view more consistent with approach in Templates module.
Rearranges a few lines in script for consistency and performance.

All patches should be combined. Finding a test case may be quite hard. Please 
choose some records with special characters. And check in several opac places 
and in staff that they are displayed correctly. Especially check MARC 
view/plain MARC view in opac and MARC/Card view in intranet results. Also check 
normal view in XSLT mode and non-XSLT mode.

-- 
You are receiving this mail because:
You are watching all bug changes.