[Koha-bugs] [Bug 7241] circulation action logs record biblionumber instead of item number

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7241

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #31 from Paul Poulain <paul.poulain at biblibre.com> ---
QA comment:

logaction API is:
sub logaction {
    my ($modulename, $actionname, $objectnumber, $infos)=@_;

the checkin/checkout is registered with:
logaction("CIRCULATION", "ISSUE", $borrower->{'borrowernumber'},
$biblio->{'biblionumber'})
that you change to:
logaction("CIRCULATION", "ISSUE", $borrower->{'borrowernumber'},
$biblio->{'itemnumber'})

So the (previous and wrong) biblionumber and the (new and correct) itemnumber
is the 4th parameter. That is $info
And $info goes to (surprise ;-) ) action_logs.info field
the "object" field is reserved for the borrowernumber

It means that the UPDATE is wrong:
UPDATE action_logs SET object=(SELECT itemnumber FROM items WHERE biblionumber=
action_logs.object LIMIT 1) WHERE module='CIRCULATION' AND action in
('ISSUE','RETURN');

should be
UPDATE action_logs SET info=(SELECT itemnumber FROM items WHERE biblionumber=
action_logs.info LIMIT 1) WHERE module='CIRCULATION' AND action in
('ISSUE','RETURN');

I had proposed the SQL in comment 24 without testing it, just for the general
idea (I should have told it !)

It seems neither Adrien nor Kyle have tested too ...

Please resubmit a working patch ! (once again, my SQL is untested !!!)

(OTOH, +1 for the timestamp update)

-- 
You are receiving this mail because:
You are watching all bug changes.