[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices

Thu Oct 11 15:16:33 CEST 2012

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030

--- Comment #37 from Paul Poulain <paul.poulain at biblibre.com> ---
I don't think this patch is just an ENH, sor RMaint, your choice, but this
patch should be OK in 3.8 imo

Examining possible side effect before pushing:
* The patch contains:
-                my $titles = "";
+                my $titles;
=> I think it's a bad idea. If you have the html parameter, title will be
filled by
 if ($htmlfilename) {
     $titles = "<table id='itemscontent$borrowernumber'>";
but, if you don't have html, it will stay empty, and the line
                        $titles .= join("\t", @item_info) . "\n";
will issue an error

I've reintroduced the = '';

* the patch add:
 $letter->{'content-type'}="text/".($htmlfilename?"html":"plain").";
charset=UTF8";

=> having a content-type is always ++
and it's the correct one I think if we don't have html

* testing the script:
 - I get a bad
DBD::mysql::st execute failed: Unknown column '$date' in 'field list' at
misc/cronjobs/overdue_notices.pl line 505.

I've attached a follow-up

2nd try = I can't get anything in the generated file.
Running the script 
misc/cronjobs/overdue_notices.pl --html=test-html -v

tells me that I've one patron late:
returns 1 rows at misc/cronjobs/overdue_notices.pl line 490.
borrower firstname, TEST (7852) has items triggering level 1. at
misc/cronjobs/overdue_notices.pl line 496.
STH2 PARAMS: borrowernumber = 7852, mindays = 1, maxdays = 90 returns 1 rows at
misc/cronjobs/overdue_notices.pl line 506.

but the generated HTML is empty:
html>
<head>
<style type='text/css'>
pre {page-break-after: always;}
pre {white-space: pre-wrap;}
pre {white-space: -moz-pre-wrap;}
pre {white-space: -o-pre-wrap;}
pre {word-wrap: break-work;}
</style>
</head>
<body>
</body>
</html>

The notice defined for this patron is ODUE, i've checked the "html" on
tools/letters.pl

so... any idea why I can't make it work welcomed.

I also think a squashed patch (with an updated git patch comment) would be more
than welcomed. Those 5 patches are looking poor !

-- 
You are receiving this mail because:
You are watching all bug changes.