[Koha-bugs] [Bug 8782] Close a subscription

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8782

--- Comment #7 from David Cook <dcook at prosentient.com.au> ---
Hi Jonathan:

I just tried applying your patch against master with git bz, but it looks like
it needs a rebase:

Applying: Bug 8782: Close a subscription
error: patch failed: installer/data/mysql/updatedatabase.pl:5795
error: installer/data/mysql/updatedatabase.pl: patch does not apply
error: patch failed:
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt:189
error: koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt:
patch does not apply
error: patch failed:
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt:33
error: koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt: patch
does not apply
Patch failed at 0001 Bug 8782: Close a subscription

Looking forward to testing this one out though!

(In reply to comment #5)
> (In reply to comment #4)
> > I'd like to start testing and signing off on larger patches, but I want to
> > make sure that I'm doing a thorough enough job.
> 
> Hi David!
> The patch is large but there is no complex code. There are a lot of template
> modifications and a new status for serials.
> I think if
> 1/ you agree with this new status
> 2/ you don't find any regression in the serials module pages
> 3/ the feature works as expected
> 4/ you don't have any question
> 
> You can sign off this patch :)

-- 
You are receiving this mail because:
You are watching all bug changes.