[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force"

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion

--- Comment #24 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to comment #23)
> I disagree, implicit typing is wrong, and the real fix is what Srdjan
> outlined on bug 7854.

Hi Chris!

I agree with you, implicit typing is not what we want.

But the Bug 7854 is open for 6 months and no one proposed a patch.

So we have 3 (more?) solutions:
1/ Block this patch and wait for a patch for Bug 7854 (and maybe have side
effect, we don't know).
2/ Keep ImplicitTyping for YesNo and remove it for others types.
3/ Considering that a YesNo admits a boolean value rather than a Choice type,
it is not logical to have Yes, No and a third value (Yes and No should cover
100% of choices, but here we have a third choice)

I think the option 2 is not persuasive. It requires a new layer to parse YAML.

For me it sounds good to have not Yes, No and a third choice. And this patch
could be in master before Bug 7854.

-- 
You are receiving this mail because:
You are watching all bug changes.