[Koha-bugs] [Bug 8846] t/SuggestionEngine_ExplodedTerms.t sneakily uses database

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8846

--- Comment #5 from Jared Camins-Esakov <jcamins at cpbibliography.com> ---
(In reply to comment #4)
> QA comment: wouldn't it be better to put Mocking subs in a specific place
> where they could be reused ? Mocking C4::Languages will probably be very
> useful for other tests
> There is already t/lib/Mocks/Context.pm that mocks (very partially)
> C4::Context
> 
> isn't it a direction we should follow ?

I think we definitely need to make it reusable, and my plan is to build in
t/lib/Mocks, but I think first we need a better sense of what we're mocking
where. Different sysprefs need to be mocked to different values for different
tests, and I'd rather have a working test that requires a little bit of
refactoring than a non-working test (i.e. one that does not actually test what
it is supposed to). This is going to be one of my goals for 3.12.

-- 
You are receiving this mail because:
You are watching all bug changes.