[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Oct 24 18:02:52 CEST 2012


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #17 from Owen Leonard <oleonard at myacpl.org> ---
This seems to work fine, but I would feel more comfortable signing off if the
"Finish" action wasn't so dependent on JavaScript. Instead of using a click
handler on the submit button, I suggest using a submit handler:

    $("#logout_form").submit(function(){
      if(confirm("Would you like to print a receipt?")){
          window.open("/cgi-bin/koha/sco/printslip.pl?borrowernumber=[%
borrowernumber %]&amp;print=qslip");
      }
      return true;
    });

You don't have to rewrite the "action" of the form because whether the user
wants to print a receipt or not they want to log out. Keep the default action
of the form and pop up the window if the user has JavaScript on and chooses to
confirm.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list