[Koha-bugs] [Bug 8665] DOM indexing fails to index some bib records

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8665

--- Comment #10 from Jared Camins-Esakov <jcamins at cpbibliography.com> ---
(In reply to comment #8)
> QA comment:
> 
>  * are the following lines related to this fix ?:
> -  <xslo:template mode="index_heading_conditional"
> match="marc:datafield[@tag='450']">
> +  <xslo:template mode="index_heading_conditional">'

A line was missing in the transformer. I fixed that in the follow-up.

> +  <xslo:template match="text()" mode="index_heading_conditional"/>
> ...
> +      <xslo:apply-templates mode="index_heading_conditional"/>

These others are no-ops, caused by the fact that I didn't retransform the bib
stylesheets after adding index_heading_conditional.

>  * OK for
> -    <target_index>materials-specified :w</target_index>
> +    <target_index>materials-specified:w</target_index>
> 
>  * not sure I understand what does:
> -    <xslo:variable name="controlField001"
> select="normalize-space(marc:controlfield[@tag='001'])"/>
> +    <xslo:variable name="idfield"
> select="normalize-space(marc:controlfield[@tag='001'])"/>
>      <z:record type="update">
>        <xslo:attribute name="z:id">
> -        <xslo:value-of select="$controlField001"/>
> +        <xslo:value-of select="$idfield"/>
> 
> (in authority-zebra-indexdefs) : it does "nothing" except changing the
> variable to be consistent with biblio-zebra-indexdefs, right ?

Exactly. That's the point of the fix.

> (for biblio, the change is in the variable name AND in what it is filled
> with:
> -    <xslo:variable name="controlField001"
> select="normalize-space(marc:controlfield[@tag='001'])"/>
> +    <xslo:variable name="idfield"
> select="normalize-space(marc:datafield[@tag='999']/marc:
> subfield[@code='c'])"/>
> )

Remember that the *-zebra-indexdefs.xsl files are all automatically generated.
Any time the transformer is changed in a way that could cause side effects, all
the *-zebra-indexdefs.xsl files must be regenerated.

-- 
You are receiving this mail because:
You are watching all bug changes.