[Koha-bugs] [Bug 8942] Translation process breaks javascript in calendar.inc

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Oct 31 19:00:09 CET 2012


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8942

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #12939|0                           |1
        is obsolete|                            |

--- Comment #13 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 13151
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13151&action=edit
[SIGNED-OFF] Bug 8942 Fix translation of JS strings containing simple/double
quote

With this patch, translated strings containing simple or double quotes
are escaped. This prevent breaking JavaScript strings.

For example:

  Today, translated in French is Aujourd'hui. And so this JS line:

    var m = _('Today');

  become in French:

    var m = _('Aujourd'hui');

  It breaks the whole JS code. With this patch:

    var m = _('Ajourd\'hui');

Same issue with ", and JS strings like "foo".

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

Confirmed that the example above is handled correctly after
applying the patch and generating a fresh set of French
templates.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.


More information about the Koha-bugs mailing list