[Koha-bugs] [Bug 9002] New: Remove Problematic Logic from Patron Messaging Preferences Form

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Oct 31 22:16:56 CET 2012


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9002

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 9002
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
          Assignee: koha-bugs at lists.koha-community.org
           Summary: Remove Problematic Logic from Patron Messaging
                    Preferences Form
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: dcook at prosentient.com.au
          Hardware: All
            Status: NEW
           Version: master
         Component: Patrons
           Product: Koha

If you do not have SMSSendDriver set and you do not have a
message_transport_type of "sms", you will get an extra table column filled with
a hyphen "-" and no corresponding table heading in the Patron Messaging
Preferences table.  

This pushes the table out of alignment so the email checkbox goes under
"Digests Only?", the digests checkbox goes under "Do not notify", and the Do
not notify checkbox is pushed to the side with no heading.

---

While this doesn't affect new installs, it might affect upgrades, unless the
upgrade scripts insert message_transport_type preferences.

---

In any case, it's a couple lines of useless code. It makes more sense to use
the same logic as TalkingTechItivaPhone.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.


More information about the Koha-bugs mailing list