[Koha-bugs] [Bug 9002] Remove Problematic Logic from Patron Messaging Preferences Form

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9002

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au
                   |ity.org                     |

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
Created attachment 13159
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13159&action=edit
Bug 9002 - Remove Problematic Logic from Patron Messaging Preferences Form

It's a super basic code removal. In most cases, its presence would probably not
cause a problem. 

Currently, if SMSSendDriver isn't set, then there is no SMS column and no SMS
checkbox. However, the logic says that if there is a message_transport_type,
there should be a checkbox, and if there is not, there should be a hyphen.
Since there is no heading, this could cause layout issues for people without
the right message_transport_types.

It makes sense to use SMSSendDriver as the condition rather than the
message_transport_type...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.