From bugzilla-daemon at bugs.koha-community.org Sat Sep 1 03:40:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Sep 2012 01:40:15 +0000 Subject: [Koha-bugs] [Bug 7189] preference to control if returning lost items gives refund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7189 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 1 04:50:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Sep 2012 02:50:35 +0000 Subject: [Koha-bugs] [Bug 8588] Duplicate field IDs cause problems with SQL report parameter entry In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8588 --- Comment #5 from Chris Cormack --- Does not apply to 3.8.x, please submit a patch for 3.8.x if you think it should be pushed there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 1 04:55:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Sep 2012 02:55:06 +0000 Subject: [Koha-bugs] [Bug 8637] Lack of control on mandatory in orderreveive.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8637 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #19 from Chris Cormack --- Pushed to 3.8.x, will be in 3.8.5. I agree with Paul this could be improved, but it is a good start already. Kaizen! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 1 04:56:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Sep 2012 02:56:49 +0000 Subject: [Koha-bugs] [Bug 8520] Authorities display incorrectly in staff results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8520 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #25 from Chris Cormack --- Pushed to 3.8.x, will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 1 05:03:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Sep 2012 03:03:34 +0000 Subject: [Koha-bugs] [Bug 8293] Software error when clicking on first or last result of each page on OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8293 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #14 from Chris Cormack --- Pushed to 3.8.x, will be in 3.8.5 I also pushed a follow up to update the POD so people won't read that and be confused. I will attach that patch here for sign off and inclusion in master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 1 05:04:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Sep 2012 03:04:13 +0000 Subject: [Koha-bugs] [Bug 8293] Software error when clicking on first or last result of each page on OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8293 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 1 05:04:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Sep 2012 03:04:48 +0000 Subject: [Koha-bugs] [Bug 8293] Software error when clicking on first or last result of each page on OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8293 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11787|0 |1 is obsolete| | --- Comment #15 from Chris Cormack --- Created attachment 11934 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11934&action=edit Bug 8293 : Fixing POD to match actuality. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 1 05:05:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Sep 2012 03:05:05 +0000 Subject: [Koha-bugs] [Bug 8293] Software error when clicking on first or last result of each page on OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8293 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 1 07:47:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Sep 2012 05:47:49 +0000 Subject: [Koha-bugs] [Bug 7513] MARC Import Hangs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7513 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- Looking at the patch - wonder if it should go into 3.8.x too? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 1 09:14:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Sep 2012 07:14:09 +0000 Subject: [Koha-bugs] [Bug 7513] MARC Import Hangs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7513 --- Comment #7 from Chris Cormack --- It already is, it was pushed to master before 3.8.0 was released -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 1 09:41:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Sep 2012 07:41:31 +0000 Subject: [Koha-bugs] [Bug 8413] Space in barcode breaks GET request in benchmark_staff.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8413 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Chris Cormack --- In 3.8.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 1 09:46:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Sep 2012 07:46:45 +0000 Subject: [Koha-bugs] [Bug 8533] Non-numeric cardnumbers screw up autoMemberNum In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8533 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #9 from Chris Cormack --- Pushed to 3.8.x will be in 3.8.5 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 1 09:49:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Sep 2012 07:49:03 +0000 Subject: [Koha-bugs] [Bug 8550] Z39.50 searches for ISBN/ISSN problematic In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8550 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 1 09:50:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Sep 2012 07:50:51 +0000 Subject: [Koha-bugs] [Bug 8556] "Mark seen and continue" not translatable in inventory.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8556 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 1 09:54:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Sep 2012 07:54:20 +0000 Subject: [Koha-bugs] [Bug 8498] can't specify an hour when specifying due date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8498 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #16 from Chris Cormack --- Does not apply to 3.8.x please submit a patch for 3.8.x if one is needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 1 09:55:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Sep 2012 07:55:45 +0000 Subject: [Koha-bugs] [Bug 8573] Translation difficult in picture-upload.tt due to nested sentence in if/foreach/if/elsif - construction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8573 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 1 09:58:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Sep 2012 07:58:21 +0000 Subject: [Koha-bugs] [Bug 8646] Certain search terms cause browser "script taking too long" error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8646 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #6 from Chris Cormack --- Pushed to 3.8.x will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 1 10:02:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Sep 2012 08:02:12 +0000 Subject: [Koha-bugs] [Bug 8593] Add unique IDs to pending approval markup on staff client home page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8593 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable Version|rel_3_10 |rel_3_8 Severity|enhancement |minor --- Comment #16 from Chris Cormack --- With the css, this drops back to a bug fix. Adding ids allows people to style the page with no risk of any harm. Pushed to 3.8.x, will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 1 10:06:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Sep 2012 08:06:10 +0000 Subject: [Koha-bugs] [Bug 8712] New: We should use WAI-ARIA guidelines to help with accessibility -OMNIBUS bug Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8712 Priority: P5 - low Change sponsored?: --- Bug ID: 8712 Assignee: oleonard at myacpl.org Summary: We should use WAI-ARIA guidelines to help with accessibility -OMNIBUS bug Severity: enhancement Classification: Unclassified OS: All Reporter: chris at bigballofwax.co.nz Hardware: All Status: NEW Version: master Component: OPAC Product: Koha http://www.w3.org/TR/wai-aria-practices/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 1 10:15:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Sep 2012 08:15:21 +0000 Subject: [Koha-bugs] [Bug 8709] Subfield 0 does not show in MARC detail in intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8709 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11917|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 11935 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11935&action=edit Bug 8709: Subfield 0 does not show in MARC detail in intranet Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 1 10:15:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Sep 2012 08:15:58 +0000 Subject: [Koha-bugs] [Bug 8709] Subfield 0 does not show in MARC detail in intranet In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8709 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 1 15:08:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Sep 2012 13:08:15 +0000 Subject: [Koha-bugs] [Bug 8017] Remove unnecessary processing on return of GetAllIssues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8017 --- Comment #9 from Colin Campbell --- I'll take a look at Paul's suggestions The main performance hit was the unnecessary repetitions of loops and in production the patch as is does enough to fix large sites that were having problems displaying circ history. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 1 15:16:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Sep 2012 13:16:22 +0000 Subject: [Koha-bugs] [Bug 8514] Display of patron results changed display order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8514 --- Comment #7 from Colin Campbell --- I think a single consistent format everywhere is not desirable. In the real world our names appear in different formats depending on the context. In lists (e.g. a phonebook) inverted is the norm in singular uses (e.g. addressing a letter, introductions) uninverted form. Forcing all formats to follow one or the other is seen by users as unnatural and disrupting to the work flow. The removal of inverted form from search result lists seriously disrupts the usefulness of those lists for large institutions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 1 18:51:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 01 Sep 2012 16:51:46 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 wajasu changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #31 from wajasu --- did a fresh standard install. - can't add instructors (tried placing barcode number, and borrowoer id in both add and edit course forms). I'm suggesting you make this a button with popup form allowing selection from the list of "teachers". Maybe you can leverage patron search. (is that a template yet?) (if you clear you dev database course tables, maybe this would show up. or am i missing something?) - the "Course Reserves" column in the OPAC does show at the end of the holdings tab row (Nice!). But, not in the staff client holdings. For staff holdings, it might need to be near the column showing status (Not for Loan), so you can see if its already checked out and highlight in red if its a course reserve and "On Loan" conflict. If its course reserved, should we disallow loaning it? Note: If the course is made inactive, it should allow it to be for loan. (in item table) - Are you integrating with the "holdings" subsystem? If an item is "course reserved" what does that mean? Is the On Loan flag set in the biblo item? etc - the "Course reserves" column inthe OPAC, shows even when the course is InActive. Your logic to decide to show the column should check the course active flag as well. - mod_course.pl has template_name => "about.tmpl" (is this what you want?) - when adding an item for "course resserve", you have "LEAVE UNCHANGED" and show "Unchanged" in the course_details page, for "Item Type", "Collection", "Location", "Library". Can you add the current data underneath the italicized "Unchanged" for easier usability. You already have the code t show it. - I checked out an item that was a "course reserve" is that allowed? Should a staff get a popup warning it is a course reserve at checkout time? Also, in OPAC item view I see the status as checked out, when I click on the "cousre reserve item link" I get the course-details which show the item is available, so maybe you need to supply the model with those fields in that item-status.inc. Note; Hopefully in the future, each column would have its own tt template, and one would compose a row (for holdings, etc). The logic to determine sophisticated "Availability" might be moved to the service/manager (ie. ItemManager.GetStatus.GetAvailabilityDescription or such) wajasu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 2 11:40:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Sep 2012 09:40:16 +0000 Subject: [Koha-bugs] [Bug 8175] Check for something in materials field fails in catalogue/details.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8175 --- Comment #11 from M. Tompsett --- Okay, I finally have time to get back to this. I first found this because my materials fields were all NULL. mysql -u {kohauser} -p > use {koha database}; > select distinct materials from items; +-----------+ | materials | +-----------+ | NULL | +-----------+ 1 row in set (0.17 sec) So, I fixed the bug, and then Ian piped up about 0. So, I decided to break it back to normal and test BEFORE the patch, and AFTER the patch. TESTING ====== 1) Log into Staff Client 2) Do a search to find an item 3) Click an item, and we should be at the detail.pl page for a biblionumber (eg. 19158). CASE NULL ========= 4) Go back to mysql and: update items SET materials=NULL where biblionumber=19158; 5) Go back to browser and refresh: There is no "Materials Specified" column displayed. 6) Check koha-error_log [Sun Sep 02 16:08:38 2012] [error] [client 192.168.100.2] [Sun Sep 2 16:08:38 2012] detail.pl: Use of uninitialized value in string ne at /usr/share/koha/intranet/cgi-bin/catalogue/detail.pl line 255., referer: https://.../cgi-bin/koha/catalogue/search.pl?q=the CASE 0 ====== 7) Go back to mysql and: update items SET materials='0' where biblionumber=19158; 8) Go back to browser and refresh: There is a "Materials Specified" column with 0 displayed in it. 9) Check error log again. Nothing new. CASE '' ======= 10) Go back to mysql and: update items SET materials='' where biblionumber=19158; 11) Go back to browser and refresh: There is no "Materials Specified" column displayed. 12) Check error log again. Nothing new. CASE ' ' ======== 13) Go back to mysql and: update items SET materials='0' where biblionumber=19158; 14) Go back to browser and refresh: There is a "Materials Specified" column with nothing visible in it. 15) Check error log again. Nothing new. CASE 'blah' ====== 7) Go back to mysql and: update items SET materials='blah' where biblionumber=19158; 8) Go back to browser and refresh: There is a "Materials Specified" column with blah displayed in it. 9) Check error log again. Nothing new. There are two things wrong: 1) the generated error, which caused me to find this bug, and 2) showing a column for no apparent reason. | CASE | Defined | =~ /\S/ | $var | ne '' | Should Display? | Display? | +========+=========+=========+======+=======+=================+==========+ | NULL | 0 | Error | 0 | Error | 0 | 0 | | '' | 1 | 0 | 0 | 0 | 0 | 0 | | '0' | 1 | 1 | 0 | 1 | 1 | 1 | | ' ' | 1 | 0 | 1 | 1 | 0 | 1 | | 'blah' | 1 | 1 | 1 | 1 | 1 | 1 | +========+=========+=========+======+=======+=================+==========+ The above table shows 1/0 values for potential replacement code or existing code options, and whether or not it displays correctly. Patch and repeat the test cases. Once you are finished, you may wish to set your materials value back to what it was. Seeing as materials is a 'text' type, the 0 vs. '0' difference is irrelevant. But I hope this table and test plan explains what I was thinking when I wrote those comments. I'll have patches up shortly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 2 11:42:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Sep 2012 09:42:18 +0000 Subject: [Koha-bugs] [Bug 8175] Checking the materials field generates error or displays output incorrectly in catalogue/details.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8175 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Check for something in |Checking the materials |materials field fails in |field generates error or |catalogue/details.pl |displays output incorrectly | |in catalogue/details.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 2 13:21:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Sep 2012 11:21:09 +0000 Subject: [Koha-bugs] [Bug 8175] items.materials check logs error or displays incorrectly in details.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8175 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Checking the materials |items.materials check logs |field generates error or |error or displays |displays output incorrectly |incorrectly in details.pl |in catalogue/details.pl | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 2 14:03:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Sep 2012 12:03:24 +0000 Subject: [Koha-bugs] [Bug 8550] Z39.50 searches for ISBN/ISSN problematic In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8550 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 2 14:03:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Sep 2012 12:03:26 +0000 Subject: [Koha-bugs] [Bug 8550] Z39.50 searches for ISBN/ISSN problematic In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8550 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11304|0 |1 is obsolete| | --- Comment #8 from Jared Camins-Esakov --- Created attachment 11936 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11936&action=edit Bug 8550: restore ISSN field to Z39.50 search Sometime in 2009 or so, the ISSN field was removed from the Z39.50 search page, and the ISBN field replaced with a combined ISBN/ISSN field. Since this breaks ISBN search for most Z39.50 targets (due to the differing treatment of ISBN vs. ISSN), this is a bug not a feature. A future enhancement would be to use Business::ISBN to search for both ISBN10 and ISBN13. To test: 1) Apply patch. 2) Do a search for an ISBN using the ISBN field. 3) Do a search for an ISSN using the ISSN field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 2 14:04:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Sep 2012 12:04:35 +0000 Subject: [Koha-bugs] [Bug 8550] Z39.50 searches for ISBN/ISSN problematic In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8550 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #9 from Jared Camins-Esakov --- Paul, What you were missing was the second patch for this bug, which I failed to attach. I have now done so. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 2 14:37:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Sep 2012 12:37:24 +0000 Subject: [Koha-bugs] [Bug 7430] ModZebra should not be in C4::Biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7430 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |RESOLVED Resolution|--- |WONTFIX --- Comment #24 from Jared Camins-Esakov --- Since I will not be rebasing this again, I am closing this bug. The problem still exists, of course. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 2 15:21:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Sep 2012 13:21:33 +0000 Subject: [Koha-bugs] [Bug 8175] items.materials check logs error or displays incorrectly in details.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8175 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11496|0 |1 is obsolete| | --- Comment #12 from M. Tompsett --- Created attachment 11937 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11937&action=edit items.materials=NULL triggers error, =' ' displays empty column The patches for 3.6.x, 3.8.x, and master seem identical with some line shifts. So if it fails to apply to one of them let me know. This was generated off master. I tested the change on our 3.6.3 system. I have put a detailed discussion with test cases in a previous comment. Sorry this took so long to get back to. I hope everything is much clearer. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 2 15:21:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Sep 2012 13:21:57 +0000 Subject: [Koha-bugs] [Bug 8175] items.materials check logs error or displays incorrectly in details.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8175 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 2 19:23:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Sep 2012 17:23:14 +0000 Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title with borrower's age without using categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11550|0 |1 is obsolete| | --- Comment #60 from Marc V?ron --- Created attachment 11938 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11938&action=edit BUG 7621 [ENH] Circulation: Match age restriction of title with borrower's age without using categories Signed-off-by: Chris Cormack New version implementing Paul's advice. See Wiki http://wiki.koha-community.org/wiki/Age_restriction Signed-off-by: Jonathan Druart fix updatedatabase.pl New fix updatedatabase.pl to apply to current master by Marc Veron veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 2 19:41:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 02 Sep 2012 17:41:38 +0000 Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title with borrower's age without using categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11938|0 |1 is obsolete| | --- Comment #61 from Marc V?ron --- Created attachment 11939 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11939&action=edit BUG 7621 [ENH] Circulation: Match age restriction of title with borrower's age without using categories Signed-off-by: Chris Cormack New version implementing Paul's advice. See Wiki http://wiki.koha-community.org/wiki/Age_restrictiotion Signed-off-by: Jonathan Druart fix updatedatabase.pl New fix updatedatabase.pl to apply to current master by Marc Veron veron at veron.ch ...and fixed missing curly bracket after merging updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 02:27:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 00:27:32 +0000 Subject: [Koha-bugs] [Bug 8550] Z39.50 searches for ISBN/ISSN problematic In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8550 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #10 from Chris Cormack --- Simple patch, provides the last of the clean up needed to undo a regression. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 02:28:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 00:28:00 +0000 Subject: [Koha-bugs] [Bug 8550] Z39.50 searches for ISBN/ISSN problematic In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8550 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11936|0 |1 is obsolete| | --- Comment #11 from Chris Cormack --- Created attachment 11940 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11940&action=edit Bug 8550: restore ISSN field to Z39.50 search Sometime in 2009 or so, the ISSN field was removed from the Z39.50 search page, and the ISBN field replaced with a combined ISBN/ISSN field. Since this breaks ISBN search for most Z39.50 targets (due to the differing treatment of ISBN vs. ISSN), this is a bug not a feature. A future enhancement would be to use Business::ISBN to search for both ISBN10 and ISBN13. To test: 1) Apply patch. 2) Do a search for an ISBN using the ISBN field. 3) Do a search for an ISSN using the ISSN field. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 04:42:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 02:42:09 +0000 Subject: [Koha-bugs] [Bug 7562] KohaDates plugin not found for 3.6.3 running off packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7562 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #1 from Chris Cormack --- Is this still a problem Magnus? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 04:42:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 02:42:58 +0000 Subject: [Koha-bugs] [Bug 5999] Biblibre : Performance enhancements for 3.4 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5999 Bug 5999 depends on bug 6000, which changed state. Bug 6000 Summary: Performance enhancements for C4::Context and C4::Languages http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6000 What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 04:42:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 02:42:58 +0000 Subject: [Koha-bugs] [Bug 6000] Performance enhancements for C4::Context and C4::Languages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6000 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 04:42:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 02:42:58 +0000 Subject: [Koha-bugs] [Bug 6193] Use memcached cache koha-conf.xml configuration variables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6193 Bug 6193 depends on bug 6000, which changed state. Bug 6000 Summary: Performance enhancements for C4::Context and C4::Languages http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6000 What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 04:42:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 02:42:59 +0000 Subject: [Koha-bugs] [Bug 7119] Code cleaning & improvements omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7119 Bug 7119 depends on bug 6000, which changed state. Bug 6000 Summary: Performance enhancements for C4::Context and C4::Languages http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6000 What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 04:58:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 02:58:15 +0000 Subject: [Koha-bugs] [Bug 8713] New: Warning message triggered by clicking keyword to marc mapping. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8713 Priority: P5 - low Change sponsored?: --- Bug ID: 8713 CC: gmcharlt at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: Warning message triggered by clicking keyword to marc mapping. Severity: trivial Classification: Unclassified OS: All Reporter: mtompset at hotmail.com Hardware: All Status: NEW Version: unspecified Component: System Administration Product: Koha To reproduce the warning: 1) Log in to staff client 2) Click 'Koha administration' 3) Click 'Keywords to MARC mapping' 4) Check koha-error_log [Mon Sep 03 09:51:45 2012] [error] [client 192.168.100.2] [Mon Sep 3 09:51:45 2012] fieldmapping.pl: Use of uninitialized value $op in string eq at /usr/share/koha/intranet/cgi-bin/admin/fieldmapping.pl line 65., referer: https://.../cgi-bin/koha/admin/admin-home.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 05:11:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 03:11:28 +0000 Subject: [Koha-bugs] [Bug 8713] Warning message triggered by clicking keyword to marc mapping. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8713 --- Comment #1 from M. Tompsett --- Created attachment 11941 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11941&action=edit Warning message triggered by clicking "Keywords to MARC mapping" To reproduce the warning: 1) Log in to staff client 2) Click 'Koha administration' 3) Click 'Keywords to MARC mapping' 4) Check koha-error_log [Mon Sep 03 09:51:45 2012] [error] [client 192.168.100.2] [Mon Sep 3 09:51:45 2012] fieldmapping.pl: Use of uninitialized value $op in string eq at /usr/share/koha/intranet/cgi-bin/admin/fieldmapping.pl line 65., referer: https://.../cgi-bin/koha/admin/admin-home.pl Apply patch. No warning triggered. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 05:12:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 03:12:17 +0000 Subject: [Koha-bugs] [Bug 8713] Warning message triggered by clicking keyword to marc mapping. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8713 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 05:13:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 03:13:14 +0000 Subject: [Koha-bugs] [Bug 8713] Warning message triggered by clicking keyword to marc mapping. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8713 --- Comment #2 from M. Tompsett --- Tested in 3.6.3, but same patch should apply to 3.6.x, 3.8.x, and master. The attached patch is against master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 06:21:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 04:21:26 +0000 Subject: [Koha-bugs] [Bug 8714] New: Poorly ordered and triggers warning in marctagstructure.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8714 Priority: P5 - low Change sponsored?: --- Bug ID: 8714 CC: gmcharlt at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: Poorly ordered and triggers warning in marctagstructure.pl Severity: trivial Classification: Unclassified OS: All Reporter: mtompset at hotmail.com Hardware: All Status: NEW Version: unspecified Component: System Administration Product: Koha Found this in 3.6.3, but it applies to 3.6.x, 3.8.x, and master. 1) Log in to staff client 2) Click 'Koha administration' 3) Click 'MARC Bibliographic framework' 4) Choose a framework and click 'MARC structure' 5) Check 'Display only used Tags/Subfields' 6) Check koha error log [Mon Sep 03 12:06:06 2012] [error] [client 192.168.100.2] [Mon Sep 3 12:06:06 2012] marctagstructure.pl: Use of uninitialized value in numeric eq (==) at /usr/share/koha/intranet/cgi-bin/admin/marctagstructure.pl line 284., referer: https://.../cgi-bin/koha/admin/marctagstructure.pl 284 is the bottom of the loop, but the top of the loop had "and boundary check" logic instead of "boundary check and" logic. Correcting this ordering problem fixed the bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 06:35:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 04:35:11 +0000 Subject: [Koha-bugs] [Bug 8714] Poorly ordered and triggers warning in marctagstructure.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8714 --- Comment #1 from M. Tompsett --- Created attachment 11942 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11942&action=edit Changed and statement to have boundary check first. This is one of those strange bugs where the line number for the error number is not where the error is. Fixing the condition in the while loop fixes the warning generated by the test plan already posted on this bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 06:35:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 04:35:22 +0000 Subject: [Koha-bugs] [Bug 8714] Poorly ordered and triggers warning in marctagstructure.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8714 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 07:05:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 05:05:50 +0000 Subject: [Koha-bugs] [Bug 7243] Do not take rentals as fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7127|0 |1 is obsolete| | --- Comment #12 from Srdjan Jankovic --- Created attachment 11943 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11943&action=edit bug_7243: Be selective when summing up charges for blocking issues Added RentalsInNoissueCharges and ManInvlsInNoissueCharges sys prefs Created C4::Members::cwGetMemberAccountBallance() * A wrapper for GetMemberAccountRecords that gives info on non-issue and other charges * Other charges are: 'Res' 'Rent' if RentalsInNoissueCharges is Mo authorised_values MANUAL_INV if ManInvlsInNoissueCharges is No C4::Members::GetMemberAccountRecords() changes: * Dropped input param $date, it is not used Use split charges in C4::Circulation::CanBookBeIssued() and C4::Members::patronflags(). That way only fines decide whether an item can be issued, and not other non-fine charges -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 07:07:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 05:07:23 +0000 Subject: [Koha-bugs] [Bug 7243] Do not take rentals as fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #13 from Srdjan Jankovic --- A slightly changed approach. Should be very backward compatible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 10:04:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 08:04:22 +0000 Subject: [Koha-bugs] [Bug 8525] Highlight matches on details page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8525 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_10 --- Comment #7 from Paul Poulain --- Patch pushed. Note that this feature has the same problem than the list one : it's diacritic sensible. It means that, if you search "j?an", you'll get result containing "jean" (as expected), but they won't be highlighted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 10:06:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 08:06:58 +0000 Subject: [Koha-bugs] [Bug 8496] show local cover images on lists view in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8496 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |paul.poulain at biblibre.com --- Comment #4 from Paul Poulain --- Patch does not apply anymore, probably because of bug 8679. (Not a big deal to fix though) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 10:13:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 08:13:06 +0000 Subject: [Koha-bugs] [Bug 8705] Software error on help of main page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8705 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11924|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 11944 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11944&action=edit Bug 8705: Software error on help of main page Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 10:13:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 08:13:54 +0000 Subject: [Koha-bugs] [Bug 8705] Software error on help of main page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8705 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #10 from Jonathan Druart --- It's ok for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 11:38:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 09:38:23 +0000 Subject: [Koha-bugs] [Bug 7613] OCLC Connexion Gateway, including extension svc/import_bib In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7613 --- Comment #40 from Paul Poulain --- Ruth : I think only the follow-up patch is to apply. Could you confirm by obsoleting what can be obsoleted ? (ie: the 2 first patches I think) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 11:42:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 09:42:41 +0000 Subject: [Koha-bugs] [Bug 8715] New: Receiving all serials for a year Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8715 Priority: P5 - low Change sponsored?: --- Bug ID: 8715 CC: colin.campbell at ptfs-europe.com Assignee: koha-bugs at lists.koha-community.org Summary: Receiving all serials for a year Severity: enhancement Classification: Unclassified OS: All Reporter: jonathan.druart at biblibre.com Hardware: All Status: NEW Version: unspecified Component: Serials Product: Koha It would be possible to receive all serials for a year. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 11:42:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 09:42:50 +0000 Subject: [Koha-bugs] [Bug 8715] Receiving all serials for a year In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8715 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 11:45:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 09:45:39 +0000 Subject: [Koha-bugs] [Bug 8715] Receiving all serials for a year In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8715 --- Comment #1 from Jonathan Druart --- Created attachment 11945 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11945&action=edit Bug 8715: Receive all serials for a year. This patch adds - 2 links in the table header (select all and clear all). - Datatable on these tables Test plan: Try to select all serials for a year and receive them. Test there is no regression (ergonomic) on this page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 11:46:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 09:46:02 +0000 Subject: [Koha-bugs] [Bug 8715] Receiving all serials for a year In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8715 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 11:46:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 09:46:18 +0000 Subject: [Koha-bugs] [Bug 8251] Patrons are systematically debarred at checkin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8251 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no --- Comment #36 from Magnus Enger --- Sorry, but I'm still seeing this behaviour on both 3.8.4 (running off the official packages) and current master (3.09.00.032, dev-install): 1. Check out then return = OK 2. Add a circ rule that includes "Suspension in days" = 7 3. Check out then return = Patron is debarred until 18/03/2013 (March 18th next year, which seems like a very long and somewhat arbitrary period of time) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 11:58:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 09:58:28 +0000 Subject: [Koha-bugs] [Bug 8492] Restrict OpacSuppression to IP adresses outside of an IP range In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8492 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_10 --- Comment #14 from Paul Poulain --- Patch pushed, but a tiny question: isn't "Restrict the suppression to IP adresses outside of the IP range" a little bit complex to understand. Wouldn't it be more understandable as "Don't suppress items in this IP range" ? (note that I just tested my search is not broken, I haven't suppress index on my test computer) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 12:14:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 10:14:27 +0000 Subject: [Koha-bugs] [Bug 8492] Restrict OpacSuppression to IP adresses outside of an IP range In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8492 --- Comment #15 from Mirko Tietgen --- You are right, the wording is bad. I think it evolved from "restrict OpacSuppression to IP range" (which is technically wrong) to the monster "restrict to IP addresses outside of an IP range" which is quite hard to parse. I will try to avoid things like that in the future. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 12:29:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 10:29:47 +0000 Subject: [Koha-bugs] [Bug 8492] Restrict OpacSuppression to IP adresses outside of an IP range In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8492 --- Comment #16 from Paul Poulain --- (In reply to comment #15) > You are right, the wording is bad. I think it evolved from "restrict > OpacSuppression to IP range" (which is technically wrong) to the monster > "restrict to IP addresses outside of an IP range" which is quite hard to > parse. I will try to avoid things like that in the future. Feel free to add a follow-up to this one ;-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 12:43:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 10:43:24 +0000 Subject: [Koha-bugs] [Bug 8207] Modify authority type frameworks to allow see also fields to link to thesauri In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8207 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #17 from Paul Poulain --- Follow-up pushed, 2 comments: * the follow-up is pushed on master branch, as it can't be merged properly on new/bug_8207 (the conflict is trivial, bug the merge to master is silly, due to other updatedatabases) * there is a risk, if someone has his own PERSO_CODE authtype, that this DB update break something. Fortunately, this is highly un-probable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 12:52:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 10:52:42 +0000 Subject: [Koha-bugs] [Bug 8332] Add relationships to auth_finder for authority links In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8332 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_10 --- Comment #8 from Paul Poulain --- * patch does not apply with git bz: Switched to a new branch 'new/bug_8332' Already on 'new/bug_8332' Bug 8332 - Add relationships to auth_finder for authority links Bug 8332: Add relationships to auth_finder for authority links Apply? [yn] y fatal: cannot convert from UTF-8UTF-8 to UTF-8 Patch left in /tmp/Bug-8332-Add-relationships-to-authfinder-for-autho-xKVGYt.patch I've modified the /tmp/....patch to remove the 2nd "UTF-8" line in the header. Patch pushed. I've tested under UNIMARC, and could not find anything broken. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 12:53:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 10:53:03 +0000 Subject: [Koha-bugs] [Bug 8486] Critical error in Koha::Calendar::days_between calculation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8486 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr --- Comment #15 from Koha Team Lyon 3 --- May be I missed something (I was away for a long time) but at first sight, I suspect that this patch leaves bug 8251 unsolved ("Patrons systematically debarred at checkin") : in days_between subroutine, delta_days function returns always a positive number (see Description of bug 8251). If so so it would be necessary to add the following condition : if(DateTime->compare( $start_dt, $end_dt ) > -1){ $days = $duration->inverse; } else { for (my $dt = $start_dt->clone(); $dt <= $end_dt; $dt->add(days => 1) ) { if ($self->is_holiday($dt)) { $days--; } } } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 12:57:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 10:57:38 +0000 Subject: [Koha-bugs] [Bug 8486] Critical error in Koha::Calendar::days_between calculation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8486 --- Comment #16 from Koha Team Lyon 3 --- Sorry ! you should have to read this : if(DateTime->compare( $start_dt, $end_dt ) > -1){ $days = $days->inverse; } else { for (my $dt = $start_dt->clone(); $dt <= $end_dt; $dt->add(days => 1) ) { if ($self->is_holiday($dt)) { $days--; } } } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 12:57:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 10:57:42 +0000 Subject: [Koha-bugs] [Bug 7973] Allow for new type of LDAP authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7973 evandro at ipb.pt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |evandro at ipb.pt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 12:58:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 10:58:03 +0000 Subject: [Koha-bugs] [Bug 6979] LDAP authentication fails during password comparison In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979 evandro at ipb.pt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |evandro at ipb.pt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 13:31:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 11:31:55 +0000 Subject: [Koha-bugs] [Bug 7562] KohaDates plugin not found for 3.6.3 running off packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7562 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #2 from Magnus Enger --- Doesn't look like this is a problem in 3.8.4 and since no one else seems to be bothered by it I'm closing this bug. Thanks for the reminder, Chris. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 13:43:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 11:43:03 +0000 Subject: [Koha-bugs] [Bug 8550] Z39.50 searches for ISBN/ISSN problematic In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8550 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Pushed for QA --- Comment #12 from Mason James --- (In reply to comment #11) > Created attachment 11940 [details] > Bug 8550: restore ISSN field to Z39.50 search > > Sometime in 2009 or so, the ISSN field was removed from the Z39.50 search > page, and the ISBN field replaced with a combined ISBN/ISSN field. Since > this breaks ISBN search for most Z39.50 targets (due to the > differing treatment of ISBN vs. ISSN), this is a bug not a feature. > > A future enhancement would be to use Business::ISBN to search for both > ISBN10 and ISBN13. > > To test: > 1) Apply patch. > 2) Do a search for an ISBN using the ISBN field. > 3) Do a search for an ISSN using the ISSN field. > > Signed-off-by: Chris Cormack looks good, passing QA... $ koha-qa.pl testing 1 commit(s) (applied to commit ec365ff) * 301dd72 Bug 8550: restore ISSN field to Z39.50 search koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK - t/00-valid-xml.t tests... OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 13:43:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 11:43:17 +0000 Subject: [Koha-bugs] [Bug 8550] Z39.50 searches for ISBN/ISSN problematic In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8550 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 13:46:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 11:46:48 +0000 Subject: [Koha-bugs] [Bug 8293] Software error when clicking on first or last result of each page on OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8293 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11934|0 |1 is obsolete| | --- Comment #16 from Fridolyn SOMERS --- Created attachment 11946 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11946&action=edit Bug 8293 Fixing POD to match actuality Signed off (Just a comment change) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 13:47:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 11:47:18 +0000 Subject: [Koha-bugs] [Bug 8293] Software error when clicking on first or last result of each page on OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8293 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 14:38:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 12:38:48 +0000 Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title with borrower's age without using categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #62 from Mason James --- (In reply to comment #61) > Created attachment 11939 [details] > BUG 7621 [ENH] Circulation: Match age restriction of title with borrower's > age without using categories > > Signed-off-by: Chris Cormack > Signed-off-by: Jonathan Druart looks good, passing QA... $ koha-qa.pl testing 1 commit(s) (applied to commit 52973fc) * b67201f BUG 7621 [ENH] Circulation: Match age restriction of title with borrower's age without using categories C4/Biblio.pm C4/Circulation.pm installer/data/mysql/kohastructure.sql installer/data/mysql/sysprefs.sql installer/data/mysql/updatedatabase.pl koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK - t/00-valid-xml.t tests... OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 15:20:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 13:20:06 +0000 Subject: [Koha-bugs] [Bug 8012] defaultSortOrder and OPACdefaultSortOrder are set to "ascending" on install In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8012 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 --- Comment #6 from Paul Poulain --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 15:21:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 13:21:28 +0000 Subject: [Koha-bugs] [Bug 8586] Small bug in die if no mapping in framework for biblioitems.biblioitemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8586 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable CC| |paul.poulain at biblibre.com Version|master |rel_3_8 Assignee|gmcharlt at gmail.com |fridolyn.somers at biblibre.co | |m --- Comment #6 from Paul Poulain --- Patch pushed to master. Already in stable, setting status accordingly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 15:27:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 13:27:39 +0000 Subject: [Koha-bugs] [Bug 3374] Display patron attributes in the same format as other patron data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3374 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_10 --- Comment #6 from Paul Poulain --- Patch pushed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 15:33:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 13:33:59 +0000 Subject: [Koha-bugs] [Bug 8293] Software error when clicking on first or last result of each page on OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8293 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #17 from Jonathan Druart --- Last patch passes QA (FIX POD) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 15:43:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 13:43:19 +0000 Subject: [Koha-bugs] [Bug 8391] Cannot view reading record through staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8391 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com --- Comment #8 from Paul Poulain --- Patch pushed to master Note that it could solve some errors in other places as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 15:43:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 13:43:28 +0000 Subject: [Koha-bugs] [Bug 8391] Cannot view reading record through staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8391 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 15:48:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 13:48:06 +0000 Subject: [Koha-bugs] [Bug 4064] Uninitialized variable errors in opac-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4064 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 --- Comment #4 from Paul Poulain --- Question: why do you write "already fixed in master." in your commit comment ? the patch applies to master, and it should be pushed so... patch pushed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 15:50:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 13:50:23 +0000 Subject: [Koha-bugs] [Bug 8569] Paying for a lost item overwrites nonpublic notes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8569 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|unspecified |rel_3_8 Severity|enhancement |minor --- Comment #5 from Paul Poulain --- Patch pushed. The use case is not very common, but I think it's more a bugfix than an ENH. chris_c, your final decision for 3.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 15:57:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 13:57:43 +0000 Subject: [Koha-bugs] [Bug 7805] Exposing the new list permissions in opac and staff In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7805 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Paul Poulain --- Follow-up pushed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 15:58:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 13:58:10 +0000 Subject: [Koha-bugs] [Bug 8550] Z39.50 searches for ISBN/ISSN problematic In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8550 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed for QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 16:25:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 14:25:45 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #39 from Paul Poulain --- Question: I'm trying to find some things specific to UNIMARC, but can't. Does it mean it's MARC agnostic (/me doubt) ? shouldn't this patch be tested/signoff-ed with UNIMARC also ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 16:26:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 14:26:30 +0000 Subject: [Koha-bugs] [Bug 8716] New: Reordering of routing list entries doesn't work Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8716 Priority: P5 - low Change sponsored?: --- Bug ID: 8716 CC: colin.campbell at ptfs-europe.com Assignee: koha-bugs at lists.koha-community.org Summary: Reordering of routing list entries doesn't work Severity: enhancement Classification: Unclassified OS: All Reporter: robin at catalyst.net.nz Hardware: All Status: NEW Version: master Component: Serials Product: Koha When you attempt to reorder borrowers in a routing list, a javascript error is raised: 'this.option is undefined'. This stops the reordering from working. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 16:26:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 14:26:45 +0000 Subject: [Koha-bugs] [Bug 8716] Reordering of routing list entries doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8716 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P4 Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 16:27:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 14:27:35 +0000 Subject: [Koha-bugs] [Bug 8716] Reordering of routing list entries doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8716 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 16:30:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 14:30:46 +0000 Subject: [Koha-bugs] [Bug 6494] opacmysummaryhtml on reading history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6494 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_10 --- Comment #4 from Paul Poulain --- Patch pushed For my enlightenment = could someone share a use case for this syspref (I understand & tested what the patch does. I just need a real-life use case, to see if it can be useful for some of our libraries) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 16:30:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 14:30:56 +0000 Subject: [Koha-bugs] [Bug 4064] Uninitialized variable errors in opac-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4064 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_8 |unspecified --- Comment #5 from M. Tompsett --- When I said fixed in master, I meant there were warning messages generated in the error log file for 3.6.3, but that the ugly logic which was there solved the problem. I merely attempted to wade through the ugly logic to find a more elegant solution. Pushing it is perfectly fine with me, but it also applies to 3.6.x and 3.8.x too, which is why I have changed the version to unspecified. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 16:31:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 14:31:39 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 --- Comment #40 from Jared Camins-Esakov --- (In reply to comment #39) > Question: I'm trying to find some things specific to UNIMARC, but can't. > Does it mean it's MARC agnostic (/me doubt) ? shouldn't this patch be > tested/signoff-ed with UNIMARC also ? It is MARC agnostic. I did not change the UNIMARC XSLT because as far as I could tell, the added headings don't show up with UNIMARC. The MARC21 and NORMARC stylesheets did not handle the data correctly, so I had to change them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 16:41:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 14:41:43 +0000 Subject: [Koha-bugs] [Bug 8672] es-ES translation problem In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8672 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Katrin Fischer --- Seems to be correct in Pootle for current translation - closing bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 16:42:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 14:42:35 +0000 Subject: [Koha-bugs] [Bug 7922] Fixing typos and improving translations in German sample data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7922 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 17:24:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 15:24:09 +0000 Subject: [Koha-bugs] [Bug 7412] Pre-filling items in cataloguing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 --- Comment #33 from Paul Poulain --- (In reply to comment #25) > Why do you need two new prefs? > > -> Maybe one would have been enough. On the other hand, with two sysprefs, > you can enable/disable the feature and keep your settings. Well, I agree with Marcel that one syspref would have been enough = if you want to disable the feature for a short time, just copy/paste it somewhere. However, I won't reject your patch for that, because it is 9 months old, it would not be fair. > Since we also have default values in framework, we have Add & Duplicate, > what exacly make this feature so needed? > > -> This feature keeps track of what to prefill from one session to another > (both in time and user: if the user disconnects and reconnects, the values > are still prefilled. If a user disconnects and another user logs in, the > values are still prefilled.). Add & Duplicate does not. During my tests, I discovered that the cookie last only for the session. Is it one of my specific FF setup ? The cookie is created using: + my $itemcookie = $input->cookie( + -name => 'LastCreatedItem', + # We uri_escape the whole freezed structure so we're sure we won't have any encoding problems + -value => uri_escape_utf8( freeze( $record ) ), + -expires => '' + ); isn't it meaning "session" ? However, I'm OK with a duration of a browser session (I even think I prefer that to a forever lasting prefill), so ... ... patch pushed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 17:27:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 15:27:09 +0000 Subject: [Koha-bugs] [Bug 7241] circulation action logs record biblionumber instead of item number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7241 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 17:40:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 15:40:01 +0000 Subject: [Koha-bugs] [Bug 7241] circulation action logs record biblionumber instead of item number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7241 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED --- Comment #24 from Paul Poulain --- Well, Thinking of it a little bit more, I've reverted the patch. Having history badly broken for existing instances is really bad, because we will never be able to fix the problem properly once action_logs contains mixed informations (biblio & items) And I've an easy proposal to fix what can be fixed: The following SQL: UPDATE action_logs SET object=(SELECT itemnumber FROM items WHERE biblionumber= action_logs.object LIMIT 1) WHERE module='CIRCULATION' AND action in ('ISSUE','RETURN'); Set the 1st item number (as we can't know which item was circulated once things have been anonymised). It's better than nothing. I propose that you submit a new patch including an updatedatabase with this SQL Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 17:40:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 15:40:12 +0000 Subject: [Koha-bugs] [Bug 7241] circulation action logs record biblionumber instead of item number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7241 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 17:40:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 15:40:20 +0000 Subject: [Koha-bugs] [Bug 7241] circulation action logs record biblionumber instead of item number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7241 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 17:46:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 15:46:10 +0000 Subject: [Koha-bugs] [Bug 8412] add color icon set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8412 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #10 from Paul Poulain --- mmm... do we really need this patch ? There is an option to provide a complete/external URL. Shouldn't your library just have their own "ccode-that-are-colors" on their own location and setup ccode accordingly ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 17:48:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 15:48:03 +0000 Subject: [Koha-bugs] [Bug 8412] add color icon set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8412 --- Comment #11 from Paul Poulain --- (In reply to comment #10) > mmm... do we really need this patch ? There is an option to provide a > complete/external URL. Shouldn't your library just have their own > "ccode-that-are-colors" on their own location and setup ccode accordingly ? I just discover that the option exist for itemtypes.pl, but not for authorised_values. I don't see why (and it should probably be fixed) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 17:51:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 15:51:04 +0000 Subject: [Koha-bugs] [Bug 7168] Search orders by basket group name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7168 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_10 --- Comment #4 from Paul Poulain --- The patch add a "LIKE %$var%" to the history search. Will badly hit performances, but it's OK in history search. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 17:52:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 15:52:47 +0000 Subject: [Koha-bugs] [Bug 8440] Dates does not appear in suggestions management In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8440 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable --- Comment #12 from Paul Poulain --- Follow-up pushed to master. Already on stable, setting status accordingly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 17:54:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 15:54:22 +0000 Subject: [Koha-bugs] [Bug 7368] General staff client typo omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11761|0 |1 is obsolete| | --- Comment #55 from Paul Poulain --- Comment on attachment 11761 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11761 [SIGNED-OFF] Bug 7368: fixed subsribe typo This patch has been pushed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 17:54:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 15:54:38 +0000 Subject: [Koha-bugs] [Bug 7368] General staff client typo omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 18:43:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 16:43:14 +0000 Subject: [Koha-bugs] [Bug 5356] Shipping billing address improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #23 from Paul Poulain --- QA comment: Testing this patch, there is something important missing = if you print the basketgroup PDF, you won't get the basket shipping/billing. Libraries using that will say it's a bug, no doubts. It should not be too hard to add those columns in the tables presenting the baskets on layout2pages and layout3pages (.pm and .pdf) Entering & exporting those new columns is OK though -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 18:49:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 16:49:04 +0000 Subject: [Koha-bugs] [Bug 7351] ability to edit a range of holidays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #45 from Paul Poulain --- mmm... trying to add a range of holiday, I get nothing. I can choose a range of dates, select "Holidays on a range", can click OK, but the holiday is not saved :((( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 20:05:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 18:05:16 +0000 Subject: [Koha-bugs] [Bug 8520] Authorities display incorrectly in staff results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8520 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11423|0 |1 is obsolete| | --- Comment #26 from Tom?s Cohen Arazi --- Created attachment 11947 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11947&action=edit Bug 8520 - Authorities summary incorrect on posible duplicate notice We didn't notice this one with jcamins when we fixed this bug. Sponsored-by: Universidad Nacional de C?rdoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 20:05:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 18:05:47 +0000 Subject: [Koha-bugs] [Bug 8520] Authorities display incorrectly in staff results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8520 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_8 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 20:06:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 18:06:02 +0000 Subject: [Koha-bugs] [Bug 8520] Authorities display incorrectly in staff results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8520 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 20:06:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 18:06:10 +0000 Subject: [Koha-bugs] [Bug 8520] Authorities display incorrectly in staff results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8520 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 22:31:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 20:31:21 +0000 Subject: [Koha-bugs] [Bug 8514] Display of patron results changed display order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8514 --- Comment #8 from Chris Cormack --- I think I agree with Colin here, you do often want things displayed in different ways depending on context. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 22:46:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 20:46:58 +0000 Subject: [Koha-bugs] [Bug 8012] defaultSortOrder and OPACdefaultSortOrder are set to "ascending" on install In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8012 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Chris Cormack --- Pushed to 3.8.x, will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 22:48:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 20:48:46 +0000 Subject: [Koha-bugs] [Bug 8391] Cannot view reading record through staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8391 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 22:54:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 20:54:39 +0000 Subject: [Koha-bugs] [Bug 4064] Uninitialized variable errors in opac-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4064 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #6 from Chris Cormack --- Patch does not apply cleanly to 3.8.x. Please submit a patch formatted against 3.8.x if you want it in there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 3 23:01:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 21:01:46 +0000 Subject: [Koha-bugs] [Bug 8569] Paying for a lost item overwrites nonpublic notes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8569 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #6 from Chris Cormack --- Pushed to 3.8.x will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 01:01:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 23:01:42 +0000 Subject: [Koha-bugs] [Bug 8486] Critical error in Koha::Calendar::days_between calculation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8486 --- Comment #17 from Colin Campbell --- with respect to 8251 the bug is in the routine in C4::Circulation the advertised interface for days_between is to return a positive value. The calling sub should not even call it unless the issue is overdue yet it is doing so. Not sure about the status of the patches on that call but I'll try and review them when I'm back in the office and, sign off/submit a new one as required -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 01:09:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 23:09:33 +0000 Subject: [Koha-bugs] [Bug 8486] Critical error in Koha::Calendar::days_between calculation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8486 --- Comment #18 from Chris Cormack --- (In reply to comment #17) > with respect to 8251 the bug is in the routine in C4::Circulation the > advertised interface for days_between is to return a positive value. The > calling sub should not even call it unless the issue is overdue yet it is > doing so. Not sure about the status of the patches on that call but I'll try > and review them when I'm back in the office and, sign off/submit a new one > as required Thanks Colin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 01:32:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 03 Sep 2012 23:32:45 +0000 Subject: [Koha-bugs] [Bug 6448] EAN-13 barcode support In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6448 --- Comment #30 from Chris Cormack --- This still needs to be fixed (the test that is) or it is going to continue to fail. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 02:37:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 00:37:34 +0000 Subject: [Koha-bugs] [Bug 4064] Uninitialized variable errors in opac-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4064 --- Comment #7 from M. Tompsett --- Created attachment 11948 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11948&action=edit Optimized two if statements (3.8.x) Thanks for letting me know, Chris. Someone added a comment which seems to have thrown the first patch off. Here is a patch which applies to 3.8.x, and hopefully 3.6.x too. If there are problems, please let me know. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 03:21:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 01:21:55 +0000 Subject: [Koha-bugs] [Bug 4064] Uninitialized variable errors in opac-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4064 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Chris Cormack --- The 3.8.x patch applies fine, pushed, will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 04:16:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 02:16:04 +0000 Subject: [Koha-bugs] [Bug 8717] New: Wrong subscription notes are showing in catalogue detail view of serials in staff client Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8717 Priority: P5 - low Change sponsored?: --- Bug ID: 8717 Assignee: oleonard at myacpl.org Summary: Wrong subscription notes are showing in catalogue detail view of serials in staff client Severity: minor Classification: Unclassified OS: All Reporter: dcook at prosentient.com.au Hardware: All Status: NEW Version: master Component: Templates Product: Koha The detail.pl file is pushing "notes" when it should be pushing "internalnotes". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 04:27:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 02:27:16 +0000 Subject: [Koha-bugs] [Bug 8717] Wrong subscription notes are showing in catalogue detail view of serials in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8717 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard at myacpl.org |dcook at prosentient.com.au --- Comment #1 from David Cook --- Created attachment 11949 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11949&action=edit Bug 8717 - Wrong subscription notes are showing in catalogue detail view of serials in staff client -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 04:38:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 02:38:30 +0000 Subject: [Koha-bugs] [Bug 8718] New: Normal catalogue detail view in staff client doesn't show missing serials or subscription history note Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8718 Priority: P5 - low Change sponsored?: --- Bug ID: 8718 Assignee: oleonard at myacpl.org Summary: Normal catalogue detail view in staff client doesn't show missing serials or subscription history note Severity: enhancement Classification: Unclassified OS: All Reporter: dcook at prosentient.com.au Hardware: All Status: NEW Version: master Component: Templates Product: Koha Since the "normal" catalogue detail view in the staff client doesn't show much info about subscriptions at all, this can probably be considered an enhancement more than a bug... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 04:52:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 02:52:52 +0000 Subject: [Koha-bugs] [Bug 8718] Normal catalogue detail view in staff client doesn't show missing serials or subscription history note In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8718 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard at myacpl.org |dcook at prosentient.com.au --- Comment #1 from David Cook --- Created attachment 11950 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11950&action=edit Bug 8718 - Normal catalogue detail view in staff client doesn't show missing serials or subscription history note Actually, the lack of "librariannote" (which is the staff note for the subscription history) is certainly a bug, since this information isn't displayed anywhere at all in the staff client that I can see. The list of missing issues (missinglist) might be seen as an enhancement rather than a bug, but this is valuable information that shouldn't require further exploration via the "Subscription Details" link, so I'm actually going to consider it a bug as well. If people disagree about this latter point, I will split this bug in two, but I figure that this saves sign-off and QA time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 05:42:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 03:42:47 +0000 Subject: [Koha-bugs] [Bug 8718] Normal catalogue detail view in staff client doesn't show missing serials or subscription history note In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8718 --- Comment #2 from David Cook --- Bug 8717 should be pushed and then this patch should be rebased...because otherwise the two will just conflict. I probably should've just wrapped them both together into one commit, since they are localized to the same area... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 08:55:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 06:55:43 +0000 Subject: [Koha-bugs] [Bug 8175] items.materials check logs error or displays incorrectly in details.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8175 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 09:06:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 07:06:20 +0000 Subject: [Koha-bugs] [Bug 8713] Warning message triggered by clicking keyword to marc mapping. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8713 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |mtompset at hotmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 09:06:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 07:06:48 +0000 Subject: [Koha-bugs] [Bug 8714] Poorly ordered and triggers warning in marctagstructure.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8714 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |mtompset at hotmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 09:17:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 07:17:06 +0000 Subject: [Koha-bugs] [Bug 8339] div id="login" should be id="login_controls" in header.inc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8339 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10575|0 |1 is obsolete| | --- Comment #4 from M. Tompsett --- Created attachment 11951 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11951&action=edit Changed login to login_controls in header.inc and patched staff-global.css This should not cause any strange repositioning of the control set in the header div on the right. It may not be pixel identical, but generally should not look vastly different. Tested on my git dev master using Firefox 15 and IE 9. Sorry, I'm not installing Chrome too, jcamins. ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 09:19:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 07:19:22 +0000 Subject: [Koha-bugs] [Bug 8514] Display of patron results changed display order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8514 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 09:21:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 07:21:21 +0000 Subject: [Koha-bugs] [Bug 8339] div id="login" should be id="login_controls" in header.inc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8339 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 09:34:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 07:34:45 +0000 Subject: [Koha-bugs] [Bug 8714] Poorly ordered and triggers warning in marctagstructure.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8714 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |mtompset at hotmail.com |ity.org | QA Contact|mtompset at hotmail.com | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 10:05:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 08:05:47 +0000 Subject: [Koha-bugs] [Bug 5356] Shipping billing address improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 --- Comment #24 from Jonathan Druart --- Created attachment 11952 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11952&action=edit Bug 5356: Followup: Add basket billing and delivery place on export pdf (layout3pages) Hi Paul, This patch adds the basket billing place and delivery place in the generated pdf. But only for the layout3pages. Indeed, there are no space to add these information. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 10:05:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 08:05:56 +0000 Subject: [Koha-bugs] [Bug 5356] Shipping billing address improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 10:16:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 08:16:34 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #41 from Fr?d?ric Demians --- Jared, this is a great and welcome initiative! Like Johnathan, I would have preferred another OO framework (Moose), but well... too early. In _processrecord, I can see you populate biblio record with see also forms, and you add 'z' as field first indicator, in order to distinguish, I suppose, authorized form and see also forms. Is it you own convention, or is it a norm? Are you sure nothing must be modified in UNIMARC XSL? You've edited MARC21 XSL in order to avoid displaying see also forms for authors, for example: Doesn't it mean that for UNIMARC, see also author forms will be displayed alongside with authorized form? And what about subjects? Are subjects see also forms displayed after authorized forms? It may be the case for 650 fields. Some libraries will want that, others won't. Otherwise, do you have any plan/idea to add other forms than see also? rejected forms, broader terms, narrower terms? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 11:02:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 09:02:18 +0000 Subject: [Koha-bugs] [Bug 8714] Poorly ordered and triggers warning in marctagstructure.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8714 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11942|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 11953 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11953&action=edit Bug 8714 - Poorly ordered and triggers warning in marctagstructure.pl An array boundary check was after a comparison using the array. By changing the logic which had " and ( $j < $cnt)" to be at the beginning "( $j < $cnt ) and ", the warning is no longer shown in the error log. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 11:02:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 09:02:31 +0000 Subject: [Koha-bugs] [Bug 8714] Poorly ordered and triggers warning in marctagstructure.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8714 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 11:04:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 09:04:50 +0000 Subject: [Koha-bugs] [Bug 8713] Warning message triggered by clicking keyword to marc mapping. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8713 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11941|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 11954 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11954&action=edit Bug 8713 - Warning message triggered by clicking Keywords to MARC mapping In the Koha Administration screen, clicking Keywords to MARC mapping triggered an uninitialized $op warning in the koha error logs. Added a "|| q{}" to ensure it is set. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 11:05:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 09:05:03 +0000 Subject: [Koha-bugs] [Bug 8713] Warning message triggered by clicking keyword to marc mapping. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8713 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 11:07:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 09:07:01 +0000 Subject: [Koha-bugs] [Bug 8520] Authorities display incorrectly in staff results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8520 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11947|0 |1 is obsolete| | --- Comment #27 from Chris Cormack --- Created attachment 11955 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11955&action=edit Bug 8520 - Authorities summary incorrect on posible duplicate notice We didn't notice this one with jcamins when we fixed this bug. Sponsored-by: Universidad Nacional de C?rdoba Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 11:07:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 09:07:40 +0000 Subject: [Koha-bugs] [Bug 8520] Authorities display incorrectly in staff results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8520 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 11:07:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 09:07:42 +0000 Subject: [Koha-bugs] [Bug 8175] items.materials check logs error or displays incorrectly in details.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8175 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11937|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart --- Created attachment 11956 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11956&action=edit Bug 8175 - check logs error or displays incorrectly in details.pl Changed "$item->{'materials'} ne ''" to "defined($item->{'materials'}) && $item->{'materials'} =~ /\S/" in if condition to prevent error when it is NULL, and to properly capture the intent of printing if there is something visible. Cases tested include NULL, '0', '', ' ', and 'blah' by using UPDATE items SET materials=NULL where biblionumber=19158; where the biblionumber was chosen randomly, because only NULL was in the items.materials field. The NULL case triggers an error, but it does display correctly. The ' ' case displays an apparently empty column, which does not seem to be the intent of the flag that is being set. This is why a simple $var check is not sufficient. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 11:08:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 09:08:19 +0000 Subject: [Koha-bugs] [Bug 8175] items.materials check logs error or displays incorrectly in details.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8175 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 11:16:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 09:16:48 +0000 Subject: [Koha-bugs] [Bug 8717] Wrong subscription notes are showing in catalogue detail view of serials in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8717 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #2 from Jonathan Druart --- Hi David, The header column is "Public notes" then I suppose we want to display the public note rather than the internalnotes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 11:37:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 09:37:02 +0000 Subject: [Koha-bugs] [Bug 7784] Improve clarity of batch modification operations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7784 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- QA Comment: Just one question: what is the utility of the last line of your patch: + Else nothing to say, works as expected, no regression. Marked as Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 11:42:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 09:42:07 +0000 Subject: [Koha-bugs] [Bug 7784] Improve clarity of batch modification operations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7784 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha.sekjal at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 11:54:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 09:54:05 +0000 Subject: [Koha-bugs] [Bug 2930] Put other name on checkout screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2930 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #4 from Jonathan Druart --- This patch introduces a side-effect in the member results page. Links are not displayed. Marked as failed qa -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 12:25:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 10:25:33 +0000 Subject: [Koha-bugs] [Bug 8719] New: Private lists always sorted by title (even when author or date is selected) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8719 Priority: P5 - low Change sponsored?: --- Bug ID: 8719 CC: m.de.rooy at rijksmuseum.nl Assignee: adrien.saurat at biblibre.com Summary: Private lists always sorted by title (even when author or date is selected) Severity: normal Classification: Unclassified OS: All Reporter: adrien.saurat at biblibre.com Hardware: All Status: ASSIGNED Version: master Component: Virtual Shelves Product: Koha When you private list is edited, you can select how it will be sorted : by title, author or copyrightdate. But when displaying the list, it's always sorted by title. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 12:52:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 10:52:03 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 --- Comment #42 from Jared Camins-Esakov --- (In reply to comment #41) > Jared, this is a great and welcome initiative! Like Johnathan, I would > have preferred another OO framework (Moose), but well... too early. My thought is once we agree on Moo or Mouse, it'll be easy to rewrite this. > In _processrecord, I can see you populate biblio record with see also > forms, and you add 'z' as field first indicator, in order to > distinguish, I suppose, authorized form and see also forms. Is it you > own convention, or is it a norm? I made up the ind1=z convention. Any letter would work, since the point is just to make sure that particular tag is invalid in all MARC flavours, and letters are not allowed in indicators by the ISO standard. > Are you sure nothing must be modified in UNIMARC XSL? You've edited > MARC21 XSL in order to avoid displaying see also forms for authors, for > example: > > > > Doesn't it mean that for UNIMARC, see also author forms will be > displayed alongside with authorized form? I am not 100% sure that the UNIMARC XSLT does not need to be modified. However, when I tested it, I didn't see the see-from headings. If they're showing up for you, I'm happy to do a follow-up modifying the UNIMARC XSLT. > And what about subjects? Are subjects see also forms displayed after > authorized forms? It may be the case for 650 fields. Some libraries will > want that, others won't. Subjects are not displayed in the results, so this is a non-issue. > Otherwise, do you have any plan/idea to add other forms than see also? > rejected forms, broader terms, narrower terms? It would be easy to do by adding additional filters. This patch, of course, adds rejected forms rather than see also forms to the record. I am currently working on a suggestion plugin for broader/narrower/related terms, the patch for which I will attach to bug 8211. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 13:48:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 11:48:37 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #32 from Kyle M Hall --- > - can't add instructors (tried placing barcode number, and borrowoer id in > both add and edit course forms). I'm suggesting you make this a button with > popup form allowing selection from the list of "teachers". Maybe you can > leverage patron search. (is that a template yet?) > (if you clear you dev database course tables, maybe this would show up. or > am i missing something?) This was an ajax based search, but it seems to have broken at some point. I think I will replace it with a more traditional popup search box. > - the "Course Reserves" column in the OPAC does show at the end of the > holdings tab row (Nice!). But, not in the staff client holdings. For > staff holdings, it might need to be near the column showing status (Not for > Loan), so you can see if its already checked out and highlight in red if its > a course reserve and "On Loan" conflict. If its course reserved, should we > disallow loaning it? I'll have to add that. > Note: If the course is made inactive, it should allow it to be for loan. (in > item table) That is actually something you can choose by defining the 'standard' item type an item has, and the new item type it has while on reserve! > - Are you integrating with the "holdings" subsystem? If an item is "course > reserved" what does that mean? Is the On Loan flag set in the biblo item? > etc When an item is on "course reserve" it means that the the item how has the new holding branch, category code, > - the "Course reserves" column inthe OPAC, shows even when the course is > InActive. Your logic to decide to show the column should check the course > active flag as well. The course reserves column should only appear when one or more items on the record have course reserves. I'll have to check on this. > - mod_course.pl has template_name => "about.tmpl" (is this what you > want?) Yes, it doesn't use a template, but it needs to call get_template in order to check permissions. It seems to be standard practice to use about.tmpl in these cases. > - when adding an item for "course resserve", you have "LEAVE UNCHANGED" and > show "Unchanged" in the course_details page, for "Item Type", "Collection", > "Location", "Library". Can you add the current data underneath the > italicized "Unchanged" for easier usability. You already have the code t > show it. I removed it for readability, but I can re-add it. > - I checked out an item that was a "course reserve" is that allowed? > Should a staff get a popup warning it is a course reserve at checkout time? > Also, in OPAC item view I see the status as checked out, when I click on the > "cousre reserve item link" I get the course-details which show the item is > available, so maybe you need to supply the model with those fields in that > item-status.inc. It is allowed if you've defined the item type to allow it. The system is designed for flexibility. Putting an item on course reserve does not in itself change the behavior of an item. The behavior as altered by setting new item types, holding branches, etc. > Note; Hopefully in the future, each column would have its own tt template, > and one would compose a row (for holdings, etc). The logic to determine > sophisticated "Availability" might be moved to the service/manager (ie. > ItemManager.GetStatus.GetAvailabilityDescription or such) This is an interesting notion! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 14:01:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 12:01:42 +0000 Subject: [Koha-bugs] [Bug 8719] Private lists always sorted by title (even when author or date is selected) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8719 --- Comment #1 from Adrien SAURAT --- Created attachment 11957 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11957&action=edit proposed patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 14:02:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 12:02:21 +0000 Subject: [Koha-bugs] [Bug 8719] Private lists always sorted by title (even when author or date is selected) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8719 Adrien SAURAT changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 14:21:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 12:21:29 +0000 Subject: [Koha-bugs] [Bug 8706] Private lists can be accessed by anyone In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8706 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #6 from Jonathan Druart --- The patch seems good but I can't reproduce the issue without the patch :) I log in with user1, show his lists and click on one. log out, relog with user2 I refresh the previous page (opac-shelves.pl?viewshelf=18) and I get an error : "ERROR: You do not have adequate permission for that action on list 18." What I missed ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 14:24:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 12:24:08 +0000 Subject: [Koha-bugs] [Bug 8704] Typo in etc/koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8704 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #4 from Jonathan Druart --- FIX type in koha-conf.xml Marked as Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 14:24:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 12:24:24 +0000 Subject: [Koha-bugs] [Bug 8704] Typo in etc/koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8704 --- Comment #5 from Jonathan Druart --- s/type/typo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 14:37:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 12:37:04 +0000 Subject: [Koha-bugs] [Bug 8706] Private lists can be accessed by anyone In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8706 --- Comment #7 from Owen Leonard --- To observe the bug, you must not be logged in to the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 15:00:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 13:00:56 +0000 Subject: [Koha-bugs] [Bug 8261] Cannot search system preferences from Local Use tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8261 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #5 from Jonathan Druart --- Maybe I have make a mistake but apparently there are 2 pages for manage syspref: admin/systempreferences.pl and admin/preferences.pl. This last one is used. And the corresponding tt files. Let me know if I forgot something, but I am under the impression we can remove the following files: admin/systempreferences.pl koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt koha-tmpl/intranet-tmpl/prog/en/includes/sysprefs-admin-search.inc And we just replace the l.11 koha-tmpl/intranet-tmpl/prog/en/includes/prefs-menu.inc [% IF ( local_use ) %]
  • [% ELSE %]
  • [% END %]Local use
  • -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 15:07:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 13:07:38 +0000 Subject: [Koha-bugs] [Bug 8261] Cannot search system preferences from Local Use tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8261 --- Comment #6 from Owen Leonard --- Don't we need systempreferences.pl/.tt for Local use preferences? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 15:09:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 13:09:35 +0000 Subject: [Koha-bugs] [Bug 8706] Private lists can be accessed by anyone In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8706 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Jonathan Druart --- (In reply to comment #7) > To observe the bug, you must not be logged in to the OPAC. Ho ok ! :) Thanks Owen. Marked as Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 15:15:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 13:15:54 +0000 Subject: [Koha-bugs] [Bug 8706] Private lists can be accessed by anyone In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8706 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 15:23:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 13:23:39 +0000 Subject: [Koha-bugs] [Bug 8261] Cannot search system preferences from Local Use tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8261 --- Comment #7 from Jonathan Druart --- (In reply to comment #6) > Don't we need systempreferences.pl/.tt for Local use preferences? Yes :-/ But a big part of systempreferences.pl seems useless. I will open a new Bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 15:26:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 13:26:09 +0000 Subject: [Koha-bugs] [Bug 8720] New: A big part of systempreferences.pl/.tt is useless Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8720 Priority: P5 - low Change sponsored?: --- Bug ID: 8720 CC: gmcharlt at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: A big part of systempreferences.pl/.tt is useless Severity: enhancement Classification: Unclassified OS: All Reporter: jonathan.druart at biblibre.com Hardware: All Status: NEW Version: unspecified Component: System Administration Product: Koha A big part of systempreferences.pl and .tt files seems useless. Indeed, they are only used for the "Local use" sysprefs. A better way would be to put the specific code for "Local use" into preferences.pl/.tt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 15:26:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 13:26:30 +0000 Subject: [Koha-bugs] [Bug 8261] Cannot search system preferences from Local Use tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8261 --- Comment #8 from Jonathan Druart --- see Bug 8720 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 15:26:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 13:26:51 +0000 Subject: [Koha-bugs] [Bug 8261] Cannot search system preferences from Local Use tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8261 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Jonathan Druart --- This one passes QA :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 15:27:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 13:27:00 +0000 Subject: [Koha-bugs] [Bug 8261] Cannot search system preferences from Local Use tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8261 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 15:52:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 13:52:37 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10230|0 |1 is obsolete| | --- Comment #4 from Koha Team Lyon 3 --- Created attachment 11958 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11958&action=edit Block renewal if any checked out book is late I corrected the error that caused the renewal was not blocked clicking the renew buttons. This patch doesn't really correct a bug but propose a new feature. It is independant from OverduesBlockCirc syspref. The logic is that a patron can't renew whatever of his checked out books if any of them is late or if he's restricted. The renewal remains nevertheless possible for the librarian checking the Override renewal limit case. Plan test : Set the OverduesBlockCirc syspref to "Ask for confirmation" Go to a patron account and checkout a book Force a second checkout specifying an outdated due date to make it late You'll see that every checked out books are marked as Not Renewable (Overdue) in the Renew column. As suggested by Nicole C. Engard, I suppose that this should be rather tight to a syspref. I will try to make it within a few days if I can find the time and understand the proper way to do it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 16:00:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 14:00:18 +0000 Subject: [Koha-bugs] [Bug 6494] opacmysummaryhtml on reading history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6494 --- Comment #5 from Nicole C. Engard --- Paul, We use it to put social share buttons on the reading history and checkout list. So if you look here: http://manual.koha-community.org/3.8/en/administration.html#OPACMySummaryHTML you'll see an example of how we use it. Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 16:02:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 14:02:38 +0000 Subject: [Koha-bugs] [Bug 8412] add color icon set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8412 --- Comment #12 from Nicole C. Engard --- Not all libraries have a place to host their own images, or know how to host their own images, so adding these makes it easy for those types of people. And once again, it's just a few small images, it's not a big drain on the system so I'm not sure why we wouldn't add them. As for why it's not showing in authorized values ... does anyone know why that would happen? I put the images where I always do. Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 16:03:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 14:03:31 +0000 Subject: [Koha-bugs] [Bug 7613] OCLC Connexion Gateway, including extension svc/import_bib In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7613 --- Comment #41 from D Ruth Bavousett --- "Obsolete" is probably incorrect--all three patches are necessary for the thing to work..but the first two *have* already been pushed, so all you need to push is the third one. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 16:41:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 14:41:24 +0000 Subject: [Koha-bugs] [Bug 8696] Tools menu says export bibs still In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8696 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m QA Contact| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- Simple string modification in template. Marked as Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 16:54:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 14:54:30 +0000 Subject: [Koha-bugs] [Bug 8716] Reordering of routing list entries doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8716 --- Comment #1 from Robin Sheat --- Created attachment 11959 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11959&action=edit Bug 8716 - make the routing list reordering function work -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 16:55:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 14:55:25 +0000 Subject: [Koha-bugs] [Bug 8716] Reordering of routing list entries doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8716 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 16:58:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 14:58:06 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #15 from Kyle M Hall --- Created attachment 11960 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11960&action=edit Bug 7067 - OPAC Borrower Self Registration -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 16:58:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 14:58:21 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 16:59:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 14:59:35 +0000 Subject: [Koha-bugs] [Bug 8412] add color icon set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8412 --- Comment #13 from Nicole C. Engard --- Paul, I reapplied the patch to my system and I see the colors tab when editing authorized values, so can you explain what problem you're seeing? Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 17:04:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 15:04:53 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #16 from Kyle M Hall --- Test Plan: 1) Enable PatronSelfRegistration 2) Set PatronSelfRegistrationExpireTemporaryAccountsDelay to a number of days 3) Create a self-registered borrower category 4) Set PatronSelfRegistrationUseTemporaryStatus 5) Set PatronSelfRegistrationVerifyByEmail to "Don't require" 6) Go to OPAC, log out if logged in. 7) You should see the "Register here" link below the login box 8) Attempt to register yourself 9) Verify you can log in with your temporary password. 10) Set PatronSelfRegistrationVerifyByEmail to "Require" 11) Attempt another self-registration 12) Check the messages table, you should see a new message with a verification link. 13) Copy and paste the link into a web browser to verify the registration 14) Log in with the given credentials to verify the account was created. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 17:09:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 15:09:16 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11960|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall --- Created attachment 11961 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11961&action=edit Bug 7067 - OPAC Borrower Self Registration -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 17:14:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 15:14:09 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #18 from Kyle M Hall --- Test Plan - Part 2 - Borrower Modifications 1) Log in to OPAC, go to "my personal details" tab. 2) Make some modifications to your details. 3) Repeat steps 1 and 2 for two more borrowers. 4) Log in to Koha intranet with a user that can modify borrowers. 5) At the bottom of mainpage.pl, you should see: Patrons requesting modifications: 3 6) Click the link 7) Approve one change, deny a different one, and ignore the third, then submit. 8) Check the records, you should see the changes take affect on the approved one, and no changes to the other two. You should also see "Patrons requesting modifications: 1" at the bottom of mainpage.pl now. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 17:21:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 15:21:23 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11961|0 |1 is obsolete| | --- Comment #19 from Kyle M Hall --- Created attachment 11962 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11962&action=edit Bug 7067 - OPAC Borrower Self Registration -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 17:22:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 15:22:09 +0000 Subject: [Koha-bugs] [Bug 8721] New: typo in AllowItemsOnHoldCheckout Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8721 Priority: P5 - low Change sponsored?: --- Bug ID: 8721 Assignee: nengard at gmail.com Summary: typo in AllowItemsOnHoldCheckout Severity: minor Classification: Unclassified OS: All Reporter: nengard at gmail.com Hardware: All Status: ASSIGNED Version: master Component: Templates Product: Koha The preference repeats the word 'items'. Patch coming to fix this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 17:22:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 15:22:52 +0000 Subject: [Koha-bugs] [Bug 8721] typo in AllowItemsOnHoldCheckout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8721 --- Comment #1 from Nicole C. Engard --- Created attachment 11963 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11963&action=edit Bug 8721: Fixes minor typo in AllowItemsOnHoldCheckout Small string fix to remove repeated word. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 17:23:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 15:23:01 +0000 Subject: [Koha-bugs] [Bug 8721] typo in AllowItemsOnHoldCheckout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8721 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 17:36:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 15:36:35 +0000 Subject: [Koha-bugs] [Bug 8431] Increase the borrower attribute field size from 64 characters to 255 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8431 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |paul.poulain at biblibre.com --- Comment #15 from Paul Poulain --- A small problem that require a follow-up before I push the patch: * enter an attribute on 2 (or more lines) * save the patron * the attribute is displayed on 1 line (CR not replaced by
    ) MArking failed QA. switch back to passed QA once you've added a fix (should just require a |html in the template) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 17:45:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 15:45:38 +0000 Subject: [Koha-bugs] [Bug 8722] New: C4::Circulation needs unit test Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8722 Priority: P5 - low Change sponsored?: --- Bug ID: 8722 Assignee: gmcharlt at gmail.com Summary: C4::Circulation needs unit test Severity: enhancement Classification: Unclassified OS: All Reporter: elliott at bywatersolutions.com Hardware: All Status: NEW Version: master Component: Test Suite Product: Koha Write unit tests for all of C4::Circulation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 17:49:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 15:49:21 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #20 from Kyle M Hall --- I forgot to add, the system pref OPACBaseURL will need to be filled out if you are using the email verification. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 17:56:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 15:56:13 +0000 Subject: [Koha-bugs] [Bug 6617] table of contents not printing right if entered right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6617 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |paul.poulain at biblibre.com --- Comment #31 from Paul Poulain --- Patch does not apply anymore because of opac.css Probably very trivial fix, but vi says: <<<<<<< HEAD ======= */ .contents { width: 75%; } .contentblock { position: relative; margin-left: 2em; } .contents .t:first-child:before { content: "? "; } .contents .t:before { content: "\A? "; white-space: pre; } .contents .t { font-weight: bold; display: inline; } >>>>>>> Bug 6617: Improve MARC21 enhanced contents display the */ seems suspicious, so I let you provide an updated fix -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 17:59:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 15:59:30 +0000 Subject: [Koha-bugs] [Bug 8550] Z39.50 searches for ISBN/ISSN problematic In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8550 Joseph Alway changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_8 |master --- Comment #13 from Joseph Alway --- All of the same problems exist in the file /usr/share/koha/intranet/cgi-bin/acqui/z3950_search.pl as noted in bug 8680. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 18:01:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 16:01:33 +0000 Subject: [Koha-bugs] [Bug 5911] Transport Cost Matrix of transporting an item between branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5911 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #54 from Paul Poulain --- Sorry, but patch does not apply anymore: CONFLICT (content): Merge conflict in misc/cronjobs/holds/build_holds_queue.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl The build_holds_queue.pl seems easy to do, but I don't want to do something wrong. Please provide a rebased fix (and back to passed QA) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 18:04:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 16:04:38 +0000 Subject: [Koha-bugs] [Bug 8666] Prevent to create baskets for inactive suppliers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8666 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 Severity|enhancement |minor --- Comment #7 from Paul Poulain --- PAtch pushed. It's more a minor bugfix than an ENH. (Lyon 3 team signoff added when pushing, see comment 5) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 18:18:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 16:18:07 +0000 Subject: [Koha-bugs] [Bug 6617] table of contents not printing right if entered right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6617 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 18:18:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 16:18:09 +0000 Subject: [Koha-bugs] [Bug 6617] table of contents not printing right if entered right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6617 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11614|0 |1 is obsolete| | Attachment #11615|0 |1 is obsolete| | Attachment #11796|0 |1 is obsolete| | --- Comment #32 from Jared Camins-Esakov --- Created attachment 11964 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11964&action=edit Bug 6617 - Wrong first indicator value in test Testing the first indicator value=2 should be used for labeling 'Partial content'. Sponsored-by: Universidad Nacional de C?rdoba Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 18:19:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 16:19:55 +0000 Subject: [Koha-bugs] [Bug 6617] table of contents not printing right if entered right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6617 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #33 from Jared Camins-Esakov --- I obsoleted the patches for 3.8.x. The other patches apply without any conflicts. I also signed off on the third patch, which corrects a related bug. It's a one-line patch so should be pretty quick to QA, but the first two patches have already passed QA. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 18:20:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 16:20:26 +0000 Subject: [Koha-bugs] [Bug 8687] Improvements in overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |paul.poulain at biblibre.com --- Comment #6 from Paul Poulain --- QA comment: sorry, but this patch introduces a perlcritic error: I/O layer ":utf8" used at line 367, column 5. Use ":encoding(UTF-8)" to get strict validation. (Severity: 5) (before your patch there is also: "require" statement with library name as string at line 29, column 12. Use a bareword instead. (Severity: 5) which is still here after the patch, not a problem -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 18:21:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 16:21:45 +0000 Subject: [Koha-bugs] [Bug 6716] Database Documentation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6716 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11823|0 |1 is obsolete| | --- Comment #129 from Paul Poulain --- Comment on attachment 11823 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11823 [SIGNED-OFF] update 'onloan' in items and deleteditems This patch has been pushed on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 18:21:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 16:21:55 +0000 Subject: [Koha-bugs] [Bug 6716] Database Documentation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6716 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 18:23:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 16:23:25 +0000 Subject: [Koha-bugs] [Bug 8675] Renewing item to specified date creates a due date with HH:MM set to 00:00 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8675 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|unspecified |rel_3_8 Severity|enhancement |normal --- Comment #4 from Paul Poulain --- Not an ENH, but more a bugfix -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 18:29:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 16:29:50 +0000 Subject: [Koha-bugs] [Bug 2553] alphabetize dropdown menus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2553 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 Severity|enhancement |minor --- Comment #5 from Paul Poulain --- Patch pushed to master. More a small bugfix than an ENH imo -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 18:33:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 16:33:13 +0000 Subject: [Koha-bugs] [Bug 8549] DataTables upgrade broke display of next/previous buttons in table controls In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8549 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 --- Comment #7 from Paul Poulain --- Patch pushed to master. (Not sure the commit e77461a3cfb18a851668b99d9d6d323b9fefceb4 that introduced the problem is in 3.8, so maybe not for 3.8) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 18:36:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 16:36:04 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11962|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall --- Created attachment 11965 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11965&action=edit Bug 7067 - OPAC Borrower Self Registration -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 18:36:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 16:36:51 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #22 from Owen Leonard --- I'm still thinking it through, but I think maybe it would be good to have a separate preference for defining what fields are required for self-registration. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 18:38:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 16:38:47 +0000 Subject: [Koha-bugs] [Bug 7500] Use CSS Sprites for faster page loading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 --- Comment #28 from Paul Poulain --- QA comment: if i'm not wrong owen, you replaced /opac-tmpl/prog/images/socnet/facebook16.png by a social sprite, but facebook16.png is not removed. Shouldn't it be removed ? (same thing for other social network links) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 18:40:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 16:40:41 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11965|0 |1 is obsolete| | --- Comment #23 from Kyle M Hall --- Created attachment 11966 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11966&action=edit Bug 7067 - OPAC Borrower Self Registration -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 18:43:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 16:43:35 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11966|0 |1 is obsolete| | --- Comment #24 from Kyle M Hall --- Created attachment 11967 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11967&action=edit Bug 7067 - OPAC Borrower Self Registration -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 18:47:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 16:47:09 +0000 Subject: [Koha-bugs] [Bug 8089] Use Koha::Cache everywhere In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #15 from Paul Poulain --- (In reply to comment #14) > QA Comment: > Code looks good to me. > Just thinking: Instead of hardcoding cache times here and there in some > variety, could we intelligently configure them in a pref or so ? :) > > Passed QA I agree it could be configured manually. But I think we need more than one caching time. Some informations have a long duration (like branches, that almost never change) Some informations should have a shorter duration. And anyway, I think we will quickly need a way to clear all cachings. We have 2 options for that: * reload cache everywhere we have cache, when a value is updated * provide a "clear cache" in admin-home.pl, where the syslibrarian can reload everything when there is a value changed The 1st option is better, the 2nd is easier. For sysprefs caching = chris_c said (and he's right) that caching is not a matter of speed but of load. Caching sysprefs just one by one is maybe more expensive than not caching (will do some tests to get number). I think we'd better load *all* the sysprefs in the cache at once -in just one cache object-. It may be a little bit costly for the 1st page, but faster for the next ones. What do you guys think of this idea ? (delaying push of this patch a little bit, I want to test it deeply. Will push other more easier-to-test patches before) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 18:52:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 16:52:53 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11967|0 |1 is obsolete| | --- Comment #25 from Kyle M Hall --- Created attachment 11968 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11968&action=edit Bug 7067 - OPAC Borrower Self Registration -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 19:01:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 17:01:50 +0000 Subject: [Koha-bugs] [Bug 8723] New: holds don't transfer when moving items Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8723 Priority: P5 - low Change sponsored?: --- Bug ID: 8723 CC: gmcharlt at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: holds don't transfer when moving items Severity: critical Classification: Unclassified OS: All Reporter: nengard at gmail.com Hardware: All Status: NEW Version: master Component: Hold requests Product: Koha When using the attach item feature, if the item being moved/attached has an item specific hold on it, the hold does not transfer. It remains on the patron's record but is still linked to the original bib record making it impossible to find/delete/confirm. Nicole -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 19:33:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 17:33:14 +0000 Subject: [Koha-bugs] [Bug 8724] New: Upgrade from NoZebra installs is broken Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8724 Priority: P5 - low Change sponsored?: --- Bug ID: 8724 Assignee: gmcharlt at gmail.com Summary: Upgrade from NoZebra installs is broken Severity: enhancement Classification: Unclassified OS: All Reporter: tomascohen at gmail.com Hardware: All Status: NEW Version: master Component: Installation and upgrade (command-line installer) Product: Koha If the NoZebra syspref is set Koha gets busted after an upgrade, which doesnt warn the user about that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 19:45:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 17:45:06 +0000 Subject: [Koha-bugs] [Bug 8725] New: koha-common_3.8.4-1_all.deb has an opaclanguages option of pnf Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8725 Priority: P5 - low Change sponsored?: --- Bug ID: 8725 CC: robin at catalyst.net.nz Assignee: koha-bugs at lists.koha-community.org Summary: koha-common_3.8.4-1_all.deb has an opaclanguages option of pnf Severity: minor Classification: Unclassified OS: All Reporter: mjr at software.coop Hardware: All Status: NEW Version: rel_3_8 Component: Packaging Product: Koha /usr/share/koha$ dpkg -L koha-common |grep pnf /usr/share/koha/opac/htdocs/opac-tmpl/prog/pnf /usr/share/koha/opac/htdocs/opac-tmpl/prog/pnf/xslt~HEAD /usr/share/koha/opac/htdocs/opac-tmpl/prog/pnf/xslt~HEAD/NORMARCslimUtils.xsl /usr/share/koha/opac/htdocs/opac-tmpl/prog/pnf/xslt~HEAD/MARC21slim2OPACDetail.xsl /usr/share/koha/opac/htdocs/opac-tmpl/prog/pnf/xslt~HEAD/MARC21slim2OPACMARCdetail.xsl /usr/share/koha/opac/htdocs/opac-tmpl/prog/pnf/xslt~HEAD/UNIMARCslim2OPACDetail.xsl /usr/share/koha/opac/htdocs/opac-tmpl/prog/pnf/xslt~HEAD/MARC21slimUtils.xsl /usr/share/koha/opac/htdocs/opac-tmpl/prog/pnf/xslt~HEAD/NORMARCslim2OPACResults.xsl /usr/share/koha/opac/htdocs/opac-tmpl/prog/pnf/xslt~HEAD/UNIMARCslimUtils.xsl /usr/share/koha/opac/htdocs/opac-tmpl/prog/pnf/xslt~HEAD/compact.xsl /usr/share/koha/opac/htdocs/opac-tmpl/prog/pnf/xslt~HEAD/MARC21slim2OPACResults.xsl /usr/share/koha/opac/htdocs/opac-tmpl/prog/pnf/xslt~HEAD/NORMARCslim2OPACDetail.xsl /usr/share/koha/opac/htdocs/opac-tmpl/prog/pnf/xslt~HEAD/UNIMARCslim2OPACResults.xsl This results in a language option called pnf in Adminstration: System Preferences: I18N/L10N I'm not sure how this got in there. I don't see it in git. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 20:07:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 18:07:55 +0000 Subject: [Koha-bugs] [Bug 8724] Upgrade from NoZebra installs is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8724 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 11969 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11969&action=edit Bug 8724 - Upgrade from NoZebra installs is broken Properly set the relevant NoZebra and QueryRemoveStopwords sysprefs to 0 to fix issues on upgrades. Also removes the sysprefs from preferences/searching.pref Regards To+ Sponsored-by: Universidad Nacional de C?rdoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 20:09:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 18:09:05 +0000 Subject: [Koha-bugs] [Bug 8724] Upgrade from NoZebra installs is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8724 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 20:11:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 18:11:41 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11968|0 |1 is obsolete| | --- Comment #26 from Kyle M Hall --- Created attachment 11970 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11970&action=edit Bug 7067 - OPAC Borrower Self Registration -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 20:21:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 18:21:19 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #27 from Kyle M Hall --- You are right. I was planning for that, then I forgot to add the prefs! Kyle (In reply to comment #22) > I'm still thinking it through, but I think maybe it would be good to have a > separate preference for defining what fields are required for > self-registration. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 4 23:15:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 21:15:36 +0000 Subject: [Koha-bugs] [Bug 2060] Ability to import Authorities from Staff Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2060 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m --- Comment #21 from Brendan Gallagher --- (In reply to comment #20) > (In reply to comment #19) > > But you did respond ; ) > Could not resist it > > > I do apologize if my reply came off as yelling. Tone doesn't really come > > through well when it comes to plain text. I was only trying to add emphasis. > > I do stand by what I wrote but I hope there are no hard feelings. > OK > I think we should discuss what QA is/should be on the list. For me it is not > a second signoff. If the queue and time allows, I would be happy to test and > sign off additionally. But that is not always the case. Please send a mail > to the list.. I do agree tone is hard to understand. This is a great discussion to bring to the mailing list. Maybe for future QA(x)'s and RM's - a note on the bug of - "it passes code quality but WE need more (someone) to test the functionality". Marcel this was in no way directed at you (we all need more testing - wish I had the magic wand for that). We all appreciate the hard work that you are volunteering. Marcel++ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 00:02:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 22:02:54 +0000 Subject: [Koha-bugs] [Bug 8726] New: Did you mean? plugin for broader/narrower/related terms Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 Priority: P5 - low Change sponsored?: --- Bug ID: 8726 Assignee: jcamins at cpbibliography.com Summary: Did you mean? plugin for broader/narrower/related terms Severity: enhancement Classification: Unclassified OS: All Reporter: jcamins at cpbibliography.com Hardware: All Status: NEW Version: master Component: Searching Depends on: 8209, 8211 Product: Koha Building on the work in bug 8211, we propose adding a "Did you mean?" plugin which will suggest that users review broader, narrower, and related terms when they do subject searches, thus making the functionality usable to the general public. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 00:02:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 22:02:54 +0000 Subject: [Koha-bugs] [Bug 8209] "Did you mean?" suggestions based on authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8209 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8726 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 00:02:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 04 Sep 2012 22:02:54 +0000 Subject: [Koha-bugs] [Bug 8211] Add "subject (broader), " "subject (narrower), " and "subject (related)" options for search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8211 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8726 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 02:54:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 00:54:46 +0000 Subject: [Koha-bugs] [Bug 5911] Transport Cost Matrix of transporting an item between branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5911 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11777|0 |1 is obsolete| | Attachment #11820|0 |1 is obsolete| | --- Comment #55 from Srdjan Jankovic --- Created attachment 11971 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11971&action=edit bug_5911: Transport Cost Matrix Create transport_cost table, added UseTransportCostMatrix syspref. transport_cost table contains branch to branch transfer costs. These are used for filling inter-branch hold transfers. Moved GetHoldsQueueItems() from .pl to HoldsQueue.pm Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 02:57:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 00:57:22 +0000 Subject: [Koha-bugs] [Bug 5911] Transport Cost Matrix of transporting an item between branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5911 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Pushed for QA See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=4870 --- Comment #56 from Srdjan Jankovic --- The conflict was with bug 4870. It was not too hard to merge, but setting to "Pushed for QA" in case you want to check. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 02:57:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 00:57:22 +0000 Subject: [Koha-bugs] [Bug 4870] Damaged status does not prevent items from being selected for reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4870 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=5911 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 06:25:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 04:25:24 +0000 Subject: [Koha-bugs] [Bug 8725] koha-common_3.8.4-1_all.deb has an opaclanguages option of pnf In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8725 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #1 from Chris Cormack --- Ahh looks to me like Robin built the package in the wrong checkout (or didn't do git clean -d -f first) Should be a simple fix, over to you Robin :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 10:11:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 08:11:19 +0000 Subject: [Koha-bugs] [Bug 7986] Export issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #19 from Paul Poulain --- I'm like others: I don't like "negative" system preferences. What about renaming "DontExportFields" to "ExportRemoveFields" ? (and also rename CsvProfileForExport to ExportWithCsvProfile, so both export related sysprefs are starting with "Export") The "DontExportFields" syspref is used only 3 times in your patches, should be very easy to rename it. So please provide a follow-up to rename the field and I'll push & test everything. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 10:22:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 08:22:54 +0000 Subject: [Koha-bugs] [Bug 8594] A report containing a subquery that has a 'limit' will have that limit stripped out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8594 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Paul Poulain --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 10:35:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 08:35:49 +0000 Subject: [Koha-bugs] [Bug 6886] Single branch mode should disable showing the branch name in front of all callnumbers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com --- Comment #13 from Paul Poulain --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 10:51:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 08:51:18 +0000 Subject: [Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |paul.poulain at biblibre.com --- Comment #18 from Paul Poulain --- QA comment : I like very much the idea of Koha/Template/Plugin/KohaAuthorisedValues.pm ... BUT it has no doc at all. Failing QA for this reason, please provide a follow-up with some doc (it will be trivial, I agree, but it's needed) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 11:03:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 09:03:02 +0000 Subject: [Koha-bugs] [Bug 7986] Export issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 --- Comment #20 from Jonathan Druart --- Created attachment 11972 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11972&action=edit Bug 7986: Followup: Replace DontExportFields and CsvProfileForExport Replace DontExportFieldsi by ExportRemoveFields and CsvProfileForExport by ExportWithCsvProfile -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 11:07:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 09:07:05 +0000 Subject: [Koha-bugs] [Bug 8478] Update Ubuntu related files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8478 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_10 Severity|enhancement |minor --- Comment #21 from Paul Poulain --- (In reply to comment #20) > I think this is why there is the koha-devel mailing list discussion of: > documentation formats, making the wiki match the installation instructions, > and perhaps giving the INSTALL.{OS} files their own git repository for > documentation purposes. At this point in time, those discussions are still > in process. I'd like to see these patches get to 3.8.x and master, so at > least we have a better base installation instruction set. Agreed. Patch pushed to master. (I think it's not an ENH, but a small bugfix) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 12:00:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 10:00:31 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #28 from Jonathan Druart --- Hy Kyle, Here some remarks after a little test: - A new dependency (String::Random) is required and has to be added to the C4/Installer/PerlDependencies.pm file - The page opac-user.pl does not have a register link. - There is no verification on the date of birth entry and could be caused a warning - After sending the form, I get an error in my log DBD::mysql::st execute failed: Column 'user' cannot be null". But I don't know where does it come. - I can't continue after the step "13) Copy and paste the link into a web browser to verify the registration". Indeed, there are a lot of error in the page opac/opac-registration-verify.pl (variables not defined, etc.) + The qa tools say me a lot of failed qa points exist: * misc/cronjobs/delete_expired_opac_registrations.pl FAIL critic FAIL "require" statement with library name as string at line 28, column 12. Use a bareword instead. Code before strictures are enabled at line 23, column 1. See page 429 of PBP. * misc/cronjobs/delete_unverified_opac_registrations.pl FAIL critic FAIL "require" statement with library name as string at line 28, column 12. Use a bareword instead. Code before strictures are enabled at line 23, column 1. See page 429 of PBP. * opac/opac-registration-verify.pl FAIL valid FAIL Global symbol "$borrowernumber" requires explicit package name at opac/opac-registration-verify.pl line 58. Global symbol "$cookie" requires explicit package name at opac/opac-registration-verify.pl line 35. Global symbol "%borrower" requires explicit package name at opac/opac-registration-verify.pl line 52. Global symbol "$borrowernumber" requires explicit package name at opac/opac-registration-verify.pl line 35. Global symbol "$template" requires explicit package name at opac/opac-registration-verify.pl line 59. Global symbol "$cookie" requires explicit package name at opac/opac-registration-verify.pl line 69. opac/opac-registration-verify.pl had compilation errors. Global symbol "$template" requires explicit package name at opac/opac-registration-verify.pl line 44. Bareword "token" not allowed while "strict subs" in use at opac/opac-registration-verify.pl line 47. Global symbol "$template" requires explicit package name at opac/opac-registration-verify.pl line 69. Global symbol "$template" requires explicit package name at opac/opac-registration-verify.pl line 56. Global symbol "$template" requires explicit package name at opac/opac-registration-verify.pl line 35. Global symbol "$borrowernumber" requires explicit package name at opac/opac-registration-verify.pl line 52. Global symbol "$template" requires explicit package name at opac/opac-registration-verify.pl line 57. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 12:02:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 10:02:13 +0000 Subject: [Koha-bugs] [Bug 8622] Koha themes broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8622 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 --- Comment #9 from Paul Poulain --- Patch pushed to master Could not see any difference between before and after the patch, which what we expect when we use prog theme (what most libraries does) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 12:07:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 10:07:54 +0000 Subject: [Koha-bugs] [Bug 8666] Prevent to create baskets for inactive suppliers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8666 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #8 from Chris Cormack --- Pushed to 3.8.x, will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 12:09:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 10:09:25 +0000 Subject: [Koha-bugs] [Bug 8623] Javascript libraries should be outside theme directories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8623 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_10 Assignee|oleonard at myacpl.org |jcamins at cpbibliography.com Severity|normal |enhancement --- Comment #12 from Paul Poulain --- I could not find any difference between display before and after the patch, which is what I was expecting. However, I think it's more an ENH than a bugfix, changing status. But, as usual, chris_c, it's your final decision. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 12:11:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 10:11:49 +0000 Subject: [Koha-bugs] [Bug 8675] Renewing item to specified date creates a due date with HH:MM set to 00:00 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8675 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #5 from Chris Cormack --- Pushed to 3.8.x, will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 12:14:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 10:14:35 +0000 Subject: [Koha-bugs] [Bug 2553] alphabetize dropdown menus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2553 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Chris Cormack --- Pushed to 3.8.x, will be in 3.8.5 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 12:18:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 10:18:32 +0000 Subject: [Koha-bugs] [Bug 8549] DataTables upgrade broke display of next/previous buttons in table controls In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8549 --- Comment #8 from Chris Cormack --- Not needed for 3.8.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 12:30:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 10:30:31 +0000 Subject: [Koha-bugs] [Bug 8251] Patrons are systematically debarred at checkin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8251 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell at ptfs-europe. | |com --- Comment #37 from Colin Campbell --- There is a basic flaw in the logic in that patron's finedays are being calculated on all returns not just overdues. The delta days is a positive element that is the documented interface. Its purpose is not to inform if an issue is overdue that is already indicated in the return from GetItemIssue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 12:36:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 10:36:05 +0000 Subject: [Koha-bugs] [Bug 8251] Patrons are systematically debarred at checkin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8251 --- Comment #38 from Chris Cormack --- (In reply to comment #37) > There is a basic flaw in the logic in that patron's finedays are being > calculated on all returns not just overdues. The delta days is a positive > element that is the documented interface. Its purpose is not to inform if an > issue is overdue that is already indicated in the return from GetItemIssue Ah yes that makes sense. Yeah, that is a flaw, we should only be working out the delta days on things that are overdue, instead of on all items. Now you have explained it, it makes perfect sense. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 13:30:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 11:30:35 +0000 Subject: [Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |paul.poulain at biblibre.com --- Comment #37 from Paul Poulain --- The 6th patch does not apply: Bug 8597: Add system preferences to configure the mobile view. Apply? [yn] y Applying: Bug 8597: Add system preferences to configure the mobile view. fatal: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/ccsr/en/css/opac.css). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 8597: Add system preferences to configure the mobile view. When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Patch left in /tmp/Bug-8597-Add-system-preferences-to-configure-the-m-byW262.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 13:41:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 11:41:32 +0000 Subject: [Koha-bugs] [Bug 8725] koha-common_3.8.4-1_all.deb has an opaclanguages option of pnf In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8725 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Robin Sheat --- Yeah, I think the git clean didn't happen. Should be fixed now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 13:50:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 11:50:44 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11970|0 |1 is obsolete| | --- Comment #29 from Kyle M Hall --- Created attachment 11973 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11973&action=edit Bug 7067 - OPAC Borrower Self Registration -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 13:51:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 11:51:11 +0000 Subject: [Koha-bugs] [Bug 7583] undo receive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7583 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #9 from Jonathan Druart --- QA Comments: All works great and the code is clean. Nothing to say. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 13:53:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 11:53:17 +0000 Subject: [Koha-bugs] [Bug 8382] It is not possible to cancel an order when receiving on a filtered page in parcel.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8382 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 Severity|major |normal --- Comment #12 from Paul Poulain --- Patch pushed to master I've tested it, it's OK, patch pushed. But i'm a little bit uncomfortable with this patch. I can't say why, so I've pushed it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 14:02:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 12:02:44 +0000 Subject: [Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11858|0 |1 is obsolete| | --- Comment #38 from Jared Camins-Esakov --- Created attachment 11974 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11974&action=edit Bug 8597: Add system preferences to configure the mobile view. This patch adds the following system preferences: * OpacMainUserBlockMobile - alternate content for the MainUserBlock for mobile * OPACMobileUserCSS - custom CSS for mobile views only * OpacShowFiltersPulldownMobile - whether or not to show the index dropdown on the mobile view * OpacShowLibrariesPulldownMobile - whether or not to show the library dropdown on the mobile view Signed-off-by: Jared Camins-Esakov Signed-off-by: Chris Cormack Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 14:03:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 12:03:12 +0000 Subject: [Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11859|0 |1 is obsolete| | --- Comment #39 from Jared Camins-Esakov --- Created attachment 11975 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11975&action=edit Bug 8597 follow-up: add missing lib files Signed-off-by: Chris Cormack Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 14:03:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 12:03:48 +0000 Subject: [Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 14:06:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 12:06:45 +0000 Subject: [Koha-bugs] [Bug 7671] add a real primary key "accountlinesid" in accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7671 --- Comment #23 from Paul Poulain --- QA comment: This part of the code is wrong: + my $sthr = $dbh->prepare("SELECT max(accountlines_id) AS lastinsertid FROM accountlines"); + $sthr->execute(); + my $datalastinsertid = $sthr->fetchrow_hashref; + $sthr->finish; + return $datalastinsertid->{'lastinsertid'}; => in case 2 lines are added by 2 librarians almost at the same time, you may get a wrong lastinsertid + this add an unneeded SQL query. Please use $rv = $dbh->last_insert_id($catalog, $schema, $table, $field); instead Also note that your updatedatabase misses a } (it does not compile): $dbh->do("UPDATE systempreferences SET value = 'call_number' WHERE variable = 'OPACdefaultSortField' AND value = 'callnumber'"); print "Upgrade to $DBversion done (Bug 8657 - Default sort by call number does not work. Correcting system preference value.)\n"; SetVersion ($DBversion); + <<<<< SHOULD BE A } HERE + +$DBversion = "XXX"; +if ( C4::Context->preference("Version") < TransformToNum($DBversion) ) { + $dbh->do("ALTER TABLE `accountlines` ADD `accountlines_id` INT NOT NULL AUTO_INCREMENT PRIMARY KEY FIRST;"); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 14:09:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 12:09:23 +0000 Subject: [Koha-bugs] [Bug 8251] Patrons are systematically debarred at checkin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8251 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED Assignee|koha at univ-lyon3.fr |colin.campbell at ptfs-europe. | |com --- Comment #39 from Colin Campbell --- Created attachment 11976 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11976&action=edit Proposed Patch This patch attempts to clarify the logic and the routine is now called only for an overdue return. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 14:10:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 12:10:44 +0000 Subject: [Koha-bugs] [Bug 8251] Patrons are systematically debarred at checkin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8251 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #40 from Colin Campbell --- switch status back to requires signoff for latest patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 14:21:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 12:21:36 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #30 from Jonathan Druart --- Step 9 fails (Verify you can log in with your temporary password.) I got: Username: Password: sHGrskYvtx with an error in my log: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_coderun`.`borrowers`, CONSTRAINT `borrowers_ibfk_1` FOREIGN KEY (`categorycode`) REFERENCES `categories` (`categorycode`)) at /home/koha/C4/SQLHelper.pm line 184., referer: http://opac.koha.localhost/cgi-bin/koha/opac-memberentry.pl [Wed Sep 05 14:17:55 2012] [error] [client 127.0.0.1] [Wed Sep 5 14:17:55 2012] opac-memberentry.pl: DBD::mysql::st execute failed: Column 'user' cannot be null at /home/koha/C4/Log.pm line 79., referer: http://opac.koha.localhost/cgi-bin/koha/opac-memberentry.pl I filled all fields into the form. And - The page opac-user.pl does not have a register link. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 14:33:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 12:33:32 +0000 Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title with borrower's age without using categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 --- Comment #63 from Paul Poulain --- Patch pushed, well done everyone !!! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 14:39:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 12:39:10 +0000 Subject: [Koha-bugs] [Bug 8293] Software error when clicking on first or last result of each page on OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8293 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable --- Comment #18 from Paul Poulain --- Follow-up pushed, everything in master & stable if i'm not mistaking, setting status accordingly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 14:48:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 12:48:22 +0000 Subject: [Koha-bugs] [Bug 8204] Authority viewer in OPAC ugly, unfriendly, and mostly useless In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8204 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #35 from Jonathan Druart --- Last patch removes th OpacNav on the opac authority detail page. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 14:54:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 12:54:22 +0000 Subject: [Koha-bugs] [Bug 7613] OCLC Connexion Gateway, including extension svc/import_bib In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7613 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #42 from Paul Poulain --- Follow-up patch pushed (Ruth, when I say "obsolete", I mean mark patches as obsolet on the bug, because they are already applied. That's how it's usually done) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 15:00:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 13:00:39 +0000 Subject: [Koha-bugs] [Bug 8412] add color icon set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8412 --- Comment #14 from Paul Poulain --- (In reply to comment #13) > Paul, > > I reapplied the patch to my system and I see the colors tab when editing > authorized values, so can you explain what problem you're seeing? The problem is just that i'm not seeing the link for an external image on authorized values, as there is one on itemtypes. It's not related to your patch at all.(In reply to comment #12) > Not all libraries have a place to host their own images, or know how to host > their own images, so adding these makes it easy for those types of people. > And once again, it's just a few small images, it's not a big drain on the > system so I'm not sure why we wouldn't add them. > I put the images where I always do. Until now, images where always showing something that was understandable & useful for most libraries, so it's common interest to have them shipped with Koha. Those "image=color" are completely meaningless for me (& probably most french libraries) Are they related to a color scheme that US libraries usually understand, or are they specific to ONE library ? If they are specific to one library, I think we should not add them If they are meaningfull for many (like : "most libraries use yellow for 1XX dewey, orange for 2XX, red for 3XX, ...") , I'll push the patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 15:00:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 13:00:47 +0000 Subject: [Koha-bugs] [Bug 8678] XSLT stylesheets output XML, but HTML is needed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8678 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #5 from Jonathan Druart --- Seems good for me too. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 15:00:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 13:00:57 +0000 Subject: [Koha-bugs] [Bug 8678] XSLT stylesheets output XML, but HTML is needed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8678 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 15:02:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 13:02:30 +0000 Subject: [Koha-bugs] [Bug 7421] UNIMARC authorities DOM indexing mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7421 --- Comment #8 from Paul Poulain --- bump ! Fr?d?ric, see comment 7, I can't make it work ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 15:03:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 13:03:29 +0000 Subject: [Koha-bugs] [Bug 8727] New: Correct help text in rebuild_zebra_sliced.sh Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8727 Priority: P5 - low Change sponsored?: --- Bug ID: 8727 Assignee: gmcharlt at gmail.com Summary: Correct help text in rebuild_zebra_sliced.sh Severity: trivial Classification: Unclassified OS: All Reporter: colin.campbell at ptfs-europe.com Hardware: All Status: NEW Version: master Component: Architecture, internals, and plumbing Product: Koha The help text for rebuild_zebra_sliced aounds somewhat stilted correct some minor points of grammar and remove the word indexation which means something different from indexing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 15:05:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 13:05:42 +0000 Subject: [Koha-bugs] [Bug 8412] add color icon set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8412 --- Comment #15 from Nicole C. Engard --- Lots of libraries report that patrons come to the desk and say do you know that book about dogs with the yellow cover (or something like that). There have been articles in library journals about cataloging colors to make this kind of searching easier. One library I have found that does this is : http://portia.nesl.edu/screens/well_its_red.html click the color and you get a search for books with that color in the cover. This is a specialized feature, but one that many liked the idea of when I tweeted about it originally and like I said one that many libraries have expressed an interest in in general (not Koha specific libraries only). Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 15:05:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 13:05:55 +0000 Subject: [Koha-bugs] [Bug 8408] Odd OPAC message when OPAC Renewals are disabled and OPACFineNoRenewals is set to blank In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8408 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #14 from Jonathan Druart --- Last patches just change strings. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 15:09:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 13:09:53 +0000 Subject: [Koha-bugs] [Bug 8727] Correct help text in rebuild_zebra_sliced.sh In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8727 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |colin.campbell at ptfs-europe. | |com --- Comment #1 from Colin Campbell --- Created attachment 11977 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11977&action=edit Proposed Patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 15:10:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 13:10:05 +0000 Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 15:14:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 13:14:10 +0000 Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187 --- Comment #6 from Magnus Enger --- One thing we need to decide on is whether the logic that checks multiple sources should be in JavaScript on the client side or Perl on the server side. I'm leaning towards Perl on the server, for two reasons: 1. Displaying an image could be as simple as this: 2. We could cache the results of looking through multiple sources. (Caching might violate the terms of service for e.g. Amazon, but then we could check them last, after we have checked the ones that we can cache.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 15:14:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 13:14:13 +0000 Subject: [Koha-bugs] [Bug 8412] add color icon set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8412 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #16 from Kyle M Hall --- > Are they related to a color scheme that US libraries usually understand, or > are they specific to ONE library ? > If they are specific to one library, I think we should not add them > If they are meaningfull for many (like : "most libraries use yellow for 1XX > dewey, orange for 2XX, red for 3XX, ...") , I'll push the patch I don't think this is only specific and useful to a single library. It seems like something that could be a feature for a large number of libraries ( e.g. law firm libraries ). Other libraries may find uses for this feature that we haven't even thought of! Perhaps a library or two color code sections of shelving, in which case this feature would allow a library to give simple feedback on which area an item would be located in. In the end, it doesn't affect existing functionality, and can be safely ignored by those who are not interested in it, so why take away something that might be useful? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 15:21:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 13:21:13 +0000 Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187 --- Comment #7 from Robin Sheat --- I tend to think that in Perl is a better solution too, however it's worth noting that it'll make firewalling harder. As for the caching, I think if you cached "what was the first service that gave me a meaningful result", that wouldn't violate anything, and is also the best way to do that (short of caching the image, which really is forbidden.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 15:22:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 13:22:59 +0000 Subject: [Koha-bugs] [Bug 8514] Display of patron results changed display order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8514 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 --- Comment #9 from Paul Poulain --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 15:26:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 13:26:14 +0000 Subject: [Koha-bugs] [Bug 7784] Improve clarity of batch modification operations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7784 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_10 --- Comment #4 from Paul Poulain --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 15:27:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 13:27:50 +0000 Subject: [Koha-bugs] [Bug 8704] Typo in etc/koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8704 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 Severity|enhancement |normal --- Comment #6 from Paul Poulain --- Patch pushed to master (status updated, it's a fix, not an ENH) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 15:36:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 13:36:54 +0000 Subject: [Koha-bugs] [Bug 8706] Private lists can be accessed by anyone In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8706 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 --- Comment #9 from Paul Poulain --- mmm... testing this patch (with plack, as usual), I got strange things once, that I can't reproduce: * go to shelves.pl page on staff interface = no list displayed (I have 4 in my database) * Add a new shelf. I got a nasty = ERROR: You do not have adequate permission for that action on list 42488. * kill plack & reload it = everything is OK patch pushed, if someone face strange things, it means there is a problem, not related to some cache/plack/... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 15:39:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 13:39:18 +0000 Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187 --- Comment #8 from Katrin Fischer --- I think some sources allow it (but not Amazon) and we can store covers locally now, so those should be checked first of all. Another plus on doing it server side would be better privacy. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 15:43:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 13:43:13 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11973|0 |1 is obsolete| | --- Comment #31 from Kyle M Hall --- Created attachment 11978 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11978&action=edit Bug 7067 - OPAC Borrower Self Registration -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 15:46:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 13:46:27 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #32 from Kyle M Hall --- > - A new dependency (String::Random) is required and has to be added to the > C4/Installer/PerlDependencies.pm file Fixed. > - The page opac-user.pl does not have a register link. Fixed > - There is no verification on the date of birth entry and could be caused a > warning Good catch. I told myself I would take care of it later and then forgot ; ) > > * misc/cronjobs/delete_expired_opac_registrations.pl > FAIL > critic FAIL > "require" statement with library name as string at line 28, column 12. Use > a bareword instead. > Code before strictures are enabled at line 23, column 1. See page 429 of > PBP. > > * misc/cronjobs/delete_unverified_opac_registrations.pl > FAIL > critic FAIL > "require" statement with library name as string at line 28, column 12. Use > a bareword instead. > Code before strictures are enabled at line 23, column 1. See page 429 of > PBP. These are not valid. I use 'use Modern::Perl' which enables both warnings and strictures. The rest of the errors you saw should be fixed. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 15:48:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 13:48:20 +0000 Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187 --- Comment #9 from Robin Sheat --- A cover source I'd like to add (NZ Nat Lib) also doesn't allow caching of images, so relying on "only the last one doesn't allow caching" is not ideal. Caching images from those that do allow it is worthwhile however. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 15:49:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 13:49:02 +0000 Subject: [Koha-bugs] [Bug 8251] Patrons are systematically debarred at checkin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8251 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11976|0 |1 is obsolete| | --- Comment #41 from Tom?s Cohen Arazi --- Created attachment 11979 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11979&action=edit Bug 8251 Do not try to debar patrons if returns are not overdue If a period of suspension is configured in the issuing rules a calculation to debar the patron was called on all returns It should be limited to overdue returns Renamed _FixFineDaysOnReturn subroutine to _debar_user_on_return which is more descriptive of its purpose Removed some unnecessary or duplicated processing Changed visibility of $today so it didnt need calculating twice Removed declaration of a datedue variable that is never used Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 15:51:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 13:51:46 +0000 Subject: [Koha-bugs] [Bug 8261] Cannot search system preferences from Local Use tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8261 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 --- Comment #10 from Paul Poulain --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 15:52:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 13:52:04 +0000 Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187 --- Comment #10 from Katrin Fischer --- I think maybe the sequence should be user configurable? With an option to use the first that answered? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 15:52:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 13:52:45 +0000 Subject: [Koha-bugs] [Bug 8696] Tools menu says export bibs still In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8696 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 --- Comment #4 from Paul Poulain --- Trivial patch pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 15:53:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 13:53:20 +0000 Subject: [Koha-bugs] [Bug 8034] Enable server print queue selection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8034 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #10 from Jonathan Druart --- QA Comments: It sounds good to me. But the test you added (t/db_dependent/lib/KohaTest/Printer.pm) does not passed the perl -wc : Invalid CODE attribute: Test( 1 ) at t/db_dependent/lib/KohaTest/Printer.pm line 24 BEGIN failed--compilation aborted at t/db_dependent/lib/KohaTest/Printer.pm line 24. Are these tests still used ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 15:54:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 13:54:50 +0000 Subject: [Koha-bugs] [Bug 8550] Z39.50 searches for ISBN/ISSN problematic In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8550 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 --- Comment #14 from Paul Poulain --- Follow-up pushed to master (thx jared) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 15:58:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 13:58:31 +0000 Subject: [Koha-bugs] [Bug 6617] table of contents not printing right if entered right In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6617 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 --- Comment #34 from Paul Poulain --- Patch pushed to master (MARC21, I haven't tested it myself, trusting others) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 16:03:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 14:03:38 +0000 Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187 --- Comment #11 from Magnus Enger --- (In reply to comment #10) > I think maybe the sequence should be user configurable? With an option to > use the first that answered? That's what I'm thinking too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 16:04:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 14:04:11 +0000 Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187 --- Comment #12 from Robin Sheat --- I'd consider that a separate enhancement. If we try to cram too much stuff in for the first go, it'll never get done. Also, I don't think our syspref system allows that kind of configuration. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 16:19:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 14:19:53 +0000 Subject: [Koha-bugs] [Bug 6903] Quantity for odering from suggestion should not default to 0 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6903 BalaSBaharathi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED CC| |jsbbala at gmail.com Resolution|WORKSFORME |--- -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 16:22:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 14:22:56 +0000 Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187 --- Comment #13 from Jared Camins-Esakov --- (In reply to comment #12) > I'd consider that a separate enhancement. If we try to cram too much stuff > in for the first go, it'll never get done. Also, I don't think our syspref > system allows that kind of configuration. I am working on a similar configuration issue on bug 8726. Once that patch is up, perhaps you can adapt^Hborrow^Hshamelessly steal the code for that. Being able to drag things around to order them is pretty cool, and once I figured out how to do it, not hard at all. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 16:26:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 14:26:55 +0000 Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187 --- Comment #14 from Magnus Enger --- See also: http://wiki.koha-community.org/wiki/Covers_from_multiple_sources_RFC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 16:30:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 14:30:21 +0000 Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tajoli at cilea.it --- Comment #15 from Zeno Tajoli --- Hi to all, as I know Open Library, Library Thing and Google allow to cache book'covers. I try to find Amazon license for book covers but I don't find it. As I see in Vufind (an opac written with PHP) they cache also covers from Amazon. They use Amazon strictly only for covers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 16:30:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 14:30:35 +0000 Subject: [Koha-bugs] [Bug 7671] add a real primary key "accountlinesid" in accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7671 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 16:55:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 14:55:52 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #33 from Jonathan Druart --- Thanks for your work ! Some remarks again : 1/ I still have the sql error on submitting form. It seems caused by the action_log constraint: DBD::mysql::st execute failed: Column 'user' cannot be null at /home/koha/C4/Log.pm line 79., referer: http://opac.koha.localhost/cgi-bin/koha/opac-memberentry.pl 2/ > > - There is no verification on the date of birth entry and could be caused a > > warning > > Good catch. I told myself I would take care of it later and then forgot ; ) I don't know if it is configurable (in the jquery plugin) but now it's not possible to select a year < 2002 with just one click :-/ 3/ on opac-user.pl: "If you don't have a library card, stop by your local library to sign up or register here.. " There is 2 dots on the end of the line. 4/ Strange behaviour: modify your personnal details to replace a value with an other. Resubmit a change but replacing a value with an empty string. At intranet, you see an empty table (just with headers) in the 'changes' column. > These are not valid. I use 'use Modern::Perl' which enables both warnings > and strictures. The rest of the errors you saw should be fixed. Your first patch did not have any module use ;) This patch does not allow a librarian to validate or reject a self registration isn't it ? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 16:59:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 14:59:42 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #34 from Jonathan Druart --- Arg, please let me edit my posts! :) (I am sorry about my grammar...) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 17:07:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 15:07:38 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #35 from Jonathan Druart --- (In reply to comment #33) > This patch does not allow a librarian to validate or reject a self > registration isn't it ? Auto answer: In fact yes. In the issuing rules, we can restrict issues for the corresponding patron category. Like that we can simulate a pre-registration. A user is fully registrated when he has a "real" patron category. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 17:37:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 15:37:04 +0000 Subject: [Koha-bugs] [Bug 8251] Patrons are systematically debarred at checkin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8251 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 17:37:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 15:37:40 +0000 Subject: [Koha-bugs] [Bug 5911] Transport Cost Matrix of transporting an item between branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5911 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed for QA |Passed QA --- Comment #57 from Paul Poulain --- I mark passed QA, and will do as extensive tests as possible in the next days, before pushing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 18:20:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 16:20:58 +0000 Subject: [Koha-bugs] [Bug 8496] show local cover images on lists view in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8496 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 18:24:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 16:24:37 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11882|0 |1 is obsolete| | --- Comment #33 from Kyle M Hall --- Created attachment 11980 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11980&action=edit Bug 8215 - Course Reserves Adds a course reserves system for academic libraries. The course reserves system allows libraries to create courses and put items on reserves for those courses. Each item with at least one reserve can have some of its attributes modified while it is on reserve for at least one active course. These attributes include item type, collection code, shelving location, and holding library. If there are no active courses with this item on reserve, it's attributes will revert to the original attributes it had before going on reserve. Testing Scenario: 1) Create new authorised value categories DEPARTMENT and TERM 2) Create a new course, add instructors to that course. 3) Reserve items for that course, verify item attributes have changed. 4) Disable course, verify item attributes have reverted. 5) Enable course again, verify item attributes again. 6) Delete course, verify item attributes again. 7) Create two new courses, add the same item(s) to both courses. 8) Disable one course, verify item attributes have not reverted. 9) Disable both courses, verify item attributes have reverted. 10) Enable one course, verify item attributes are again set to the new values. 11) Edit reserve item attributes, verify. 12) Disable all courses, edit reserve item attributes, verify the item itself still has its original attributes, verify the reserve item attributes have been updated. 13) Verify the ability to remove instructors from a course. 14) Verify new permissions, top level coursereserves, with subpermissions add_reserves and delete_reserves. Bug 8215 - Add Course Reserves - Followup - Fix DB Updater & Makefile Bug 8215 - Add Course Reserves - Followup - Hide disabled course reserves on catalog details page. Bug 8215 - Add Course Reserves - Followup - One Hit Searching Bugfix When searching courses, a search that results in a single hit will automatically forward to the details for that course. If only a single course has been added to the system, Koha will always forward to that course and there will be no way to get to course-reserves.pl to add a second course! Fixed by testing for an actual search, rather than looking only at the number of hits returned. Bug 8215 - Add Course Reserves - Followup - Prevent submitting form on 'enter' When using the instructor search, hitting enter will attempt to submit the form. This is unwanted behavior. Fixed by adding some jquery, such that any form field with the class "noEnterSubmit" will but trigger a form submission. This class can be used on any form in the librarian interface to prevent a field from triggering a form submission via the enter key. Bug 8215 - Course Reserves - Followup - Remove checkEnter() and reimplement with noEnterSubmit class Bug 8215 - Course Reserves - Followup - Fix permissions typos -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 18:24:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 16:24:59 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 18:26:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 16:26:36 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #34 from Kyle M Hall --- Just an fyi, I was able to get the instructor search working again. Between my writing it, and your testing it, the YUI ajax search was replaced with a jQuery based one. It works just like the "checkout" borrower search. It appears that you need to add at least three letters of the persons first or last name before you will see the results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 18:26:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 16:26:44 +0000 Subject: [Koha-bugs] [Bug 8496] show local cover images on lists view in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8496 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11165|0 |1 is obsolete| | --- Comment #5 from Owen Leonard --- Created attachment 11981 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11981&action=edit Bug 8496 - show local cover images on lists view in opac Adding display of local cover images to lists view. Also adding display of OpenLibrary covers since those were also missing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 18:27:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 16:27:08 +0000 Subject: [Koha-bugs] [Bug 8496] show local cover images on lists view in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8496 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 18:31:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 16:31:30 +0000 Subject: [Koha-bugs] [Bug 8728] New: t/db_dependent/Reserve.t test doesn't use resdate and expdate arguments for AddReserve Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8728 Priority: P5 - low Change sponsored?: --- Bug ID: 8728 Assignee: gmcharlt at gmail.com Summary: t/db_dependent/Reserve.t test doesn't use resdate and expdate arguments for AddReserve Severity: enhancement Classification: Unclassified OS: All Reporter: matted-34813 at mypacks.net Hardware: All Status: NEW Version: unspecified Component: Test Suite Product: Koha The AddReserve routine had resdate and expdate added in between arguments (not appended) in 2009/2010ish and http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/Reserves.pm;hb=b7e35a37256054c2a1d07a4fcd965283aa91968e so we need to adjust the t/db_dependent/Reserve.t accordingly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 18:35:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 16:35:09 +0000 Subject: [Koha-bugs] [Bug 8382] It is not possible to cancel an order when receiving on a filtered page in parcel.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8382 --- Comment #13 from Owen Leonard --- Created attachment 11982 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11982&action=edit Bug 8382 [Follow-up] It is not possible to cancel an order when receiving on a filtered page in parcel.pl In order to be valid XHTML ampersands must be encoded ("&"). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 18:48:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 16:48:46 +0000 Subject: [Koha-bugs] [Bug 8728] t/db_dependent/Reserve.t test doesn't use resdate and expdate arguments for AddReserve In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8728 --- Comment #1 from wajasu --- Created attachment 11983 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11983&action=edit adjust-Reserves.t-test-for-resdate-and-expdate-and-t.patch This patch adds the resdate and expdate argument to the AddReserve test. I also adjusted it to create a bilio, and item for that biblio and delete them at the end of the test, so its not dependent on external test data. It gets rid of Illegal metric data warning from misaligned arguments. TestPlan: koha at biblio:~/kohaclone$ prove t/db_dependent/Reserves.t t/db_dependent/Reserves.t .. 1/4 # # Creating biblio instance for testing. # Creating item instance for testing. # Deleting item testing instance. # Deleting biblio testing instance. t/db_dependent/Reserves.t .. ok All tests successful. Files=1, Tests=4, 2 wallclock secs ( 0.03 usr 0.01 sys + 0.59 cusr 0.04 csys = 0.67 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 18:49:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 16:49:20 +0000 Subject: [Koha-bugs] [Bug 8728] t/db_dependent/Reserve.t test doesn't use resdate and expdate arguments for AddReserve In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8728 wajasu changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 18:51:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 16:51:21 +0000 Subject: [Koha-bugs] [Bug 8708] RSS feed for new comments is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8708 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11918|0 |1 is obsolete| | --- Comment #7 from Owen Leonard --- Created attachment 11984 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11984&action=edit Bug 8708 [Revised] RSS feed for new comments is broken Removing white space from the beginning of the file so that XML processing will work correctly. Before the patch, viewing the page (/cgi-bin/koha/opac-showreviews.pl?format=rss) in a browser which supports RSS handling (ex: Firefox) will show you unformatted and broken-looking text. After the patch the page will trigger the browser's built-in RSS-handling format. Revision: Template now includes comment pointing out that the declaration must not have any white space before it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 18:56:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 16:56:45 +0000 Subject: [Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133 Helen Linda changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |helen.linda at goddard.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 19:42:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 17:42:51 +0000 Subject: [Koha-bugs] [Bug 8644] jQueryUI CSS file should not contain customizations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8644 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 20:29:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 18:29:33 +0000 Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #53 from Kyle M Hall --- pplying: bug_5786, bug_5787, bug_5788: Holds rewrite error: patch failed: C4/Auth.pm:412 error: C4/Auth.pm: patch does not apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 20:30:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 18:30:11 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #227 from Chris Cormack --- Created attachment 11985 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11985&action=edit Bug 5327 : Fixing a typo in the test that was causing a false fail -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 20:30:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 18:30:44 +0000 Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #54 from Kyle M Hall --- My bad, the old patch was not deprecated. (In reply to comment #53) > pplying: bug_5786, bug_5787, bug_5788: Holds rewrite > error: patch failed: C4/Auth.pm:412 > error: C4/Auth.pm: patch does not apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 20:30:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 18:30:47 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 20:32:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 18:32:21 +0000 Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11190|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 20:41:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 18:41:13 +0000 Subject: [Koha-bugs] [Bug 8644] jQueryUI CSS file should not contain customizations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8644 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11715|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 11986 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11986&action=edit Bug 8644 [staff client] jQueryUI CSS file should not contain customizations This patch moves jQueryUI customizations into the main CSS file for the staff client. In order to get the corrected default version of jquery-ui.css I have upgraded all core jQueryUI files. Testers should look at examples of each of the various jQueryUI widgets we use in Koha to confirm continued functinality: tabs, autocomplete, datepickers, and slider (in specify due date popup). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 21:15:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 19:15:38 +0000 Subject: [Koha-bugs] [Bug 6716] Database Documentation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6716 --- Comment #130 from Nicole C. Engard --- Created attachment 11987 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11987&action=edit Bug 6716: Update borrowers tables altaddress definiton The comment on the altcontactaddress3 said it was the 3rd address line but in reality it was the city. This fixes the documentation of that field -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 21:16:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 19:16:22 +0000 Subject: [Koha-bugs] [Bug 6716] Database Documentation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6716 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 21:24:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 19:24:52 +0000 Subject: [Koha-bugs] [Bug 8729] New: browse not doing pages Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8729 Priority: P5 - low Change sponsored?: --- Bug ID: 8729 Assignee: oleonard at myacpl.org Summary: browse not doing pages Severity: normal Classification: Unclassified OS: All Reporter: nengard at gmail.com Hardware: All Status: NEW Version: master Component: Templates Product: Koha Created attachment 11988 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11988&action=edit 3 shows 3rd result, not 3rd page When on the detail page, the browse results has numbers across the top that used to go to pages of results, but now it goes to numbers of results and it's confusing to users who are used to search pages having numbers for pages - not numbers of results. See attached. I'm not sure when it changed, but I do remember it being pages originally. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 21:26:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 19:26:10 +0000 Subject: [Koha-bugs] [Bug 8730] New: browse overlaying powered by Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8730 Priority: P5 - low Change sponsored?: --- Bug ID: 8730 Assignee: oleonard at myacpl.org Summary: browse overlaying powered by Severity: minor Classification: Unclassified OS: All Reporter: nengard at gmail.com Hardware: All Status: NEW Version: master Component: Templates Product: Koha Created attachment 11989 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11989&action=edit powered by floats on top When you use the browse results option on the detail page in conjunction with the powered by Koha message it overlays funny - the powered by comes on top of the browse but should probably fall behind. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 21:53:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 19:53:32 +0000 Subject: [Koha-bugs] [Bug 8496] show local cover images on lists view in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8496 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11981|0 |1 is obsolete| | --- Comment #6 from Nicole C. Engard --- Created attachment 11990 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11990&action=edit [SIGNED-OFF] Bug 8496 - show local cover images on lists view in opac Adding display of local cover images to lists view. Also adding display of OpenLibrary covers since those were also missing. Signed-off-by: Nicole C. Engard Tested with local cover images and with other cover images. Lists work as expected with all services. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 21:53:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 19:53:44 +0000 Subject: [Koha-bugs] [Bug 8496] show local cover images on lists view in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8496 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 21:54:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 19:54:58 +0000 Subject: [Koha-bugs] [Bug 8708] RSS feed for new comments is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8708 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11984|0 |1 is obsolete| | --- Comment #8 from Nicole C. Engard --- Created attachment 11991 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11991&action=edit [SIGNED-OFF] Bug 8708 [Revised] RSS feed for new comments is broken Removing white space from the beginning of the file so that XML processing will work correctly. Before the patch, viewing the page (/cgi-bin/koha/opac-showreviews.pl?format=rss) in a browser which supports RSS handling (ex: Firefox) will show you unformatted and broken-looking text. After the patch the page will trigger the browser's built-in RSS-handling format. Revision: Template now includes comment pointing out that the declaration must not have any white space before it. Signed-off-by: Nicole C. Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 22:08:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 20:08:39 +0000 Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11903|0 |1 is obsolete| | --- Comment #55 from Kyle M Hall --- Created attachment 11992 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11992&action=edit bug_5786, bug_5787, bug_5788: Holds rewrite bug_5786: moved AllowOnShelfHolds to issuingrules bug_5787: moved OPACItemHolds to issuingrules bug_5788: Added reservesmaxpickupdelay to issuingrules C4::Reserves: * Added OnShelfHoldsAllowed() to check issuingrules * Added OPACItemHoldsAllowed() to check issuingrules * IsAvailableForItemLevelRequest() changed interface, now takes $item_record,$borrower_record; calls OnShelfHoldsAllowed() opac/opac-reserve.pl and opac/opac-search.pl: * rewrote hold allowed rule to use OPACItemHoldsAllowed() * also use OnShelfHoldsAllowed() through IsAvailableForItemLevelRequest() templates: * Removed AllowOnShelfHolds and OPACItemHolds global flags, they now only have meaning per item type Signed-off-by: Nicole C. Engard I have tested this patch left, right and upside down for the last several months. All tests have passed. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 22:08:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 20:08:55 +0000 Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 5 23:13:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 21:13:35 +0000 Subject: [Koha-bugs] [Bug 5500] shelf browse changing bib record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5500 Melia Meggs changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |melia at bywatersolutions.com --- Comment #3 from Melia Meggs --- This appears to still be an issue in master. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 00:43:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 22:43:07 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11985|0 |1 is obsolete| | --- Comment #228 from Jared Camins-Esakov --- Created attachment 11993 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11993&action=edit [SIGNED OFF] Bug 5327 : Fixing a typo in the test that was causing a false fail Signed-off-by: Jared Camins-Esakov t/db_dependent/Items.t was failing despite valid data before patch, works fine after -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 00:46:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 22:46:16 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 00:47:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 22:47:10 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #229 from Jared Camins-Esakov --- Note that final patch is required in order to fix currently failing tests on Jenkins. Also note that the first 5 patches already passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 01:05:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 23:05:30 +0000 Subject: [Koha-bugs] [Bug 8594] A report containing a subquery that has a 'limit' will have that limit stripped out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8594 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #14 from Chris Cormack --- Pushed to 3.8.x, will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 01:09:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 23:09:40 +0000 Subject: [Koha-bugs] [Bug 8717] Wrong subscription notes are showing in catalogue detail view of serials in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8717 --- Comment #3 from David Cook --- Hi Jonathan: I'm not sure where you are looking, but I don't see a header column on the page to which I'm referring. I'll attach a screenshot. (In reply to comment #2) > Hi David, > The header column is "Public notes" then I suppose we want to display the > public note rather than the internalnotes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 01:12:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 23:12:18 +0000 Subject: [Koha-bugs] [Bug 6886] Single branch mode should disable showing the branch name in front of all callnumbers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6886 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #14 from Chris Cormack --- Pushed to 3.8.x will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 01:14:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 23:14:59 +0000 Subject: [Koha-bugs] [Bug 8717] Wrong subscription notes are showing in catalogue detail view of serials in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8717 --- Comment #4 from David Cook --- Created attachment 11994 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11994&action=edit Screenshot of "subscription notes" This is the patched version. Ordinarily, it would show "subscription public note" . -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 01:32:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 23:32:34 +0000 Subject: [Koha-bugs] [Bug 8478] Update Ubuntu related files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8478 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #22 from Chris Cormack --- Pushed to 3.8.x, will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 01:40:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 23:40:25 +0000 Subject: [Koha-bugs] [Bug 8622] Koha themes broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8622 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_8 |rel_3_10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 01:48:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 23:48:25 +0000 Subject: [Koha-bugs] [Bug 8731] New: Holds Log to track the number of times a hold is overriden Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8731 Priority: P5 - low Change sponsored?: --- Bug ID: 8731 CC: gmcharlt at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: Holds Log to track the number of times a hold is overriden Severity: enhancement Classification: Unclassified OS: All Reporter: melia at bywatersolutions.com Hardware: All Status: NEW Version: unspecified Component: Hold requests Product: Koha There is not currently a way to track the number of times a Hold is overriden (i.e. that the book is checked out to someone other than the patron who currently has a hold on it). I think it would be nice to have a Holds Log that keeps track of this info so I could understand how often this happens and if there is any abuse of this "override". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 01:53:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 23:53:34 +0000 Subject: [Koha-bugs] [Bug 8732] New: Add a systempreference to allow users to choose to display an icon based on the marc control fields, or based on the koha biblio level itemtype Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Priority: P5 - low Change sponsored?: --- Bug ID: 8732 Assignee: oleonard at myacpl.org Summary: Add a systempreference to allow users to choose to display an icon based on the marc control fields, or based on the koha biblio level itemtype Severity: enhancement Classification: Unclassified OS: All Reporter: chris at bigballofwax.co.nz Hardware: All Status: NEW Version: master Component: OPAC Product: Koha Often the icon that is generated in XSLT using the MARC control fields is inaccurate or inadequate. This systempreference would allow libraries to use the itemtype icon they have chosen for the biblio level itemtype (942 in MARC21) This is sponsored by 6 New Zealand Libraries -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 01:53:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 23:53:47 +0000 Subject: [Koha-bugs] [Bug 8732] Add a systempreference to allow users to choose to display an icon based on the marc control fields, or based on the koha biblio level itemtype In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 01:54:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 05 Sep 2012 23:54:24 +0000 Subject: [Koha-bugs] [Bug 8034] Enable server print queue selection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8034 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11557|0 |1 is obsolete| | --- Comment #11 from Srdjan Jankovic --- Created attachment 11995 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11995&action=edit bug_8034: Restored network printer maintenance and selection This patch is just for restoring printer maintenance and selection, not for priting itself. It is just a preparation step. * Added UsePrintQueues syspref. If set to No, no printer info will be displayed/used * Database changes: - printers table PRIMARY KEY is now printqueue. It is more natural. We should really have a synthetic id, but printqueue is good enough - branches.branchprinter is a FOREIGN KEY to printers.printqueue * Created C4::Auth::get_user_printer() function that will return appropriate printer. In order of preference: - session selected - logged in branch branchprinter * Moved printer functions to C4::Printer * Restored printer maint/selection in admin zone UsePrintQueues permitting * Restored printer selection in circ/selectbranchprinter.pl UsePrintQueues permitting Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 02:00:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 00:00:06 +0000 Subject: [Koha-bugs] [Bug 8034] Enable server print queue selection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8034 --- Comment #12 from Srdjan Jankovic --- Patch did not apply, so I rebased. I think I fixed that test. If not, please let me know. Actually, I'm ashamed to admit it, but I don't know how to run those tests. I tried it but getting too many errors that I don't know what to do with. I created that particular test file because I moved two functions from C4::Koha to C4::Printer. I wasn't worried about those test because they do not represent a huge value - just check ic certain subs are present, and UI would have failed anyway. Can you please shed some light on how to run those tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 03:03:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 01:03:29 +0000 Subject: [Koha-bugs] [Bug 8585] Add System Preference to specify Holds to Pull List Start Date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8585 --- Comment #3 from David Cook --- Good point. I don't know much about setting cookies, but I like the idea. That said, it would mean that different staff members would have different results in different browsers rather than one consistent result across the board. In my experience, staff don't tend to think about the date ranges on the side. They either just press the submit button or accept the results that they're given (if the report is automatically generated as in Bug 8454). In terms of policy, it's easier to have staff check a set range of dates that the manager or systems person has set up with the system preference, rather than relying on staff's knowledge of how far back to check for holds. Admittedly, a cookie would solve the problem initially, but it could create a problem where someone narrows the date range and then forgets to put it back...and then staff think that there are no holds to pull, because they don't realize that the range was changed. It seems too variable :/. But that's just my opinion. (In reply to comment #2) > A system preference seems like overkill for this. Could we set a cookie that > stored the offset so that the page would show the same offset later? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 03:19:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 01:19:25 +0000 Subject: [Koha-bugs] [Bug 2060] Ability to import Authorities from Staff Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2060 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 04:20:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 02:20:53 +0000 Subject: [Koha-bugs] [Bug 8731] Holds Log to track the number of times a hold is overriden In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8731 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #1 from Liz Rea --- I think an action log for holds is a GREAT idea - it would be awesome if koha logged the following regarding holds: - logged in user who placed the hold - where it was placed (opac or staff client) - it's position at first creation - any time its position is changed by a user (reordered manually) - who deleted an unfilled hold - how many times a hold has been skipped over for a user (like in the original bug) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 04:30:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 02:30:14 +0000 Subject: [Koha-bugs] [Bug 8728] t/db_dependent/Reserve.t test doesn't use resdate and expdate arguments for AddReserve In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8728 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Blocks| |5327 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 04:30:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 02:30:14 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8728 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 04:36:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 02:36:54 +0000 Subject: [Koha-bugs] [Bug 8733] New: Adding critic reviews to book pages Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8733 Priority: P5 - low Change sponsored?: --- Bug ID: 8733 Assignee: oleonard at myacpl.org Summary: Adding critic reviews to book pages Severity: enhancement Classification: Unclassified OS: All Reporter: rahul at idreambooks.com Hardware: All Status: NEW Version: unspecified Component: OPAC Product: Koha Created attachment 11996 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11996&action=edit PowerPoint Presentation of mockups A proposal to enhance the detail page of a book by adding a section titled "Book reviews by critics" similar to the "Amazon reviews" section. This section would display 5 critic reviews from idreambooks.com as per the guidelines in iDreamBooks' API (idreambooks.com/api). For example, for the book MoonWalking with Einsten, the editorial review snippets from sources like The Guardian, NYTimes, WashingtonPost, etc. would be shown. See example of API output for the book here: http://idreambooks.com/newbooks/api.xml?q=moonwalking+with+einstein+foer&key=example_key In addition to the review snippets, the overall rating of the book would get displayed on the detail page of a book to help users gauge the rating of the book in an instant. The rating on it's own or the entire "Readometer" or both can be displayed. For example, for the book MoonWalking with Einstein, it's rating of 80% would be displayed under the title of the book. Alternatively, the "Readometer" could also be displayed. Please see attached powerpoint presentation for images that give more detail. We (iDreamBooks) are willing to provide development assistance to implement these enhancements. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 05:12:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 03:12:23 +0000 Subject: [Koha-bugs] [Bug 8644] jQueryUI CSS file should not contain customizations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8644 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 05:25:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 03:25:17 +0000 Subject: [Koha-bugs] [Bug 6903] Quantity for odering from suggestion should not default to 0 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6903 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED CC| |chris at bigballofwax.co.nz Resolution|--- |FIXED --- Comment #2 from Chris Cormack --- I there a reason you reopened this with no comment? I can confirm this now works fine in master. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 06:15:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 04:15:55 +0000 Subject: [Koha-bugs] [Bug 8418] Koha::Calendar is_holiday ignores all user data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8418 L. Bare?o changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |leonardobareno at gmail.com --- Comment #24 from L. Bare?o --- 1) Current code in ./Koha/Calendar.pm is ignoring single holidays (those whose special_holidays.isexception == 0) (line numbers and code from master at this message's date) ./Koha/Calendar.pm line 68: - $special->execute( $branch, 1 ); + $special->execute( $branch, 0 ); 2) exception_holidays are not holidays, and (please you people tell me if the following interpretation I'm doing is correct) these must disable any other repeatable or single holiday. lines 141-165 (suggested code): sub is_holiday { my ( $self, $dt ) = @_; if ( $self->{exception_holidays}->contains($dt) ) { return 0; } my $dow = $dt->day_of_week; if ( $dow == 7 ) { $dow = 0; } if ( $self->{weekly_closed_days}->[$dow] == 1 ) { return 1; } $dt->truncate( to => 'day' ); my $day = $dt->day; my $month = $dt->month; if ( exists $self->{day_month_closed_days}->{$month}->{$day} ) { return 1; } if ( $self->{single_holidays}->contains($dt) ) { return 1; } # damn have to go to work after all return 0; } -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 06:35:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 04:35:02 +0000 Subject: [Koha-bugs] [Bug 8033] add print receipt option to Koha self-check In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 --- Comment #14 from David Cook --- (In reply to comment #13) > (In reply to comment #12) > > (In reply to comment #11) > > > The reason I added it to the submit button rather than the finish button was > > > because I feared someone would not click finish and just leave the terminal. > > > > This was a potential problem before this patch, wasn't it? I think it's too > > much of a disruption to the process to pop up a message after each > > transaction. I think it would be better to leave it up to the user to decide > > when to print their receipt. Perhaps another button alongside "finish," > > "Finish and print receipt?" > > I agree with Owen. If someone skips the receipt printing step, that's their > problem. Additionally, you're skipping the server-side validation when you have your script on the submit button. You generate a slip even though the item might not actually be checked out (because it is reference book, currently checked out to someone else, on hold for someone else, a renewal, and so on). While this isn't a crippling deficiency, it is certainly problematic. I also wanted to mention that I agree with Owen as well. I use the self-checkout at my local branch all the time, and you print the receipt by pressing the "Print Receipt" button on the screen. It's a much smoother behaviour. (I've also noticed recently that there is an "Email Receipt" button as an alternative to the paper receipt.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 06:57:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 04:57:27 +0000 Subject: [Koha-bugs] [Bug 8033] add print receipt option to Koha self-check In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 --- Comment #15 from David Cook --- Not to hassle you too much, but it's also worth noting that renewals aren't included in the print out. Just check outs. I haven't looked too much into the guts of this script, but they should probably be included too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 07:02:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 05:02:59 +0000 Subject: [Koha-bugs] [Bug 8382] It is not possible to cancel an order when receiving on a filtered page in parcel.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8382 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #14 from Chris Cormack --- Ill wait until the follow up is pushed before deciding whether to push this to 3.8.x or not -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 07:07:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 05:07:34 +0000 Subject: [Koha-bugs] [Bug 7613] OCLC Connexion Gateway, including extension svc/import_bib In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7613 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #43 from Chris Cormack --- Follow up pushed to 3.8.x will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 07:09:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 05:09:24 +0000 Subject: [Koha-bugs] [Bug 8514] Display of patron results changed display order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8514 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 07:12:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 05:12:47 +0000 Subject: [Koha-bugs] [Bug 8704] Typo in etc/koha-conf.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8704 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #7 from Chris Cormack --- Pushed to 3.8.x will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 07:14:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 05:14:32 +0000 Subject: [Koha-bugs] [Bug 8706] Private lists can be accessed by anyone In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8706 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #10 from Chris Cormack --- Pushed to 3.8.x will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 08:54:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 06:54:26 +0000 Subject: [Koha-bugs] [Bug 8734] New: Acquisitions- Quantity for ordering from suggestion unable to modify Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8734 Priority: P5 - low Change sponsored?: --- Bug ID: 8734 Assignee: koha-bugs at lists.koha-community.org Summary: Acquisitions- Quantity for ordering from suggestion unable to modify Severity: enhancement Classification: Unclassified OS: All Reporter: jsbbala at gmail.com Hardware: All Status: NEW Version: rel_3_6 Component: Acquisitions Product: Koha Created attachment 11997 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11997&action=edit ordering problem In acquisition when we go for new order of a book a field is mandatory ie Quantity of the book. It is default 0(zero) we cannot change the quantity and save -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 09:05:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 07:05:35 +0000 Subject: [Koha-bugs] [Bug 8418] Koha::Calendar is_holiday ignores all user data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8418 --- Comment #25 from Colin Campbell --- The non loading of exception holidays is addressed by the patch on bug 8656 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 09:10:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 07:10:24 +0000 Subject: [Koha-bugs] [Bug 8734] Acquisitions- Quantity for ordering from suggestion unable to modify In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8734 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi, the problem here is that the item form is missing. Can you try and create an ACQ framework like the message on top suggests? Make sure you have field 952 in your ACQ framework. The other option is to set the system preference AcqCreateItem to "receive" or "cataloguing". You will be able to edit the quantity then, because no items have to be added. Which version are you using? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 09:39:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 07:39:09 +0000 Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187 Manos PETRIDIS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #16 from Manos PETRIDIS --- (In reply to comment #6) > One thing we need to decide on is whether the logic that checks multiple > sources should be in JavaScript on the client side or Perl on the server > side. I'm leaning towards Perl on the server, for two reasons: > > 1. Displaying an image could be as simple as this: > > > > 2. We could cache the results of looking through multiple sources. (Caching > might violate the terms of service for e.g. Amazon, but then we could check > them last, after we have checked the ones that we can cache.) Just a comment from an end-user: Could it be that Amazon returns an image, even when no cover image is available in its systems? I'm referring to the "No image available" with a hint of a smile/bent arrow below image. Unless Amazon does provide for an indication that the image it provides is a placeholder for the cover image it does not [yet] have, caching might prove tricky, for it could hinder future [successful] look-ups in Amazon. Furthermore, should Amazon be at the top of the list, successfuly fetching a placeholder image from Amazon would prevent koha from retrieving a correct cover image from some other source down the list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 09:39:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 07:39:12 +0000 Subject: [Koha-bugs] [Bug 8261] Cannot search system preferences from Local Use tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8261 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #11 from Chris Cormack --- Pushed to 3.8.x, will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 09:42:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 07:42:46 +0000 Subject: [Koha-bugs] [Bug 8696] Tools menu says export bibs still In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8696 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Pushed to 3.8.x, will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 09:43:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 07:43:51 +0000 Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187 --- Comment #17 from Magnus Enger --- Good points, Manos! Yeah, I am trying to figure out a way to check if the image returned is a placeholder or not, that is kind of crucial. And caching should not last forever. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 09:45:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 07:45:27 +0000 Subject: [Koha-bugs] [Bug 8708] RSS feed for new comments is broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8708 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Jonathan Druart --- Thank you Owen. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 09:46:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 07:46:41 +0000 Subject: [Koha-bugs] [Bug 8550] Z39.50 searches for ISBN/ISSN problematic In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8550 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #15 from Chris Cormack --- Pushed to 3.8.x, will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 10:42:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 08:42:45 +0000 Subject: [Koha-bugs] [Bug 7986] Export issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11408|0 |1 is obsolete| | Attachment #11409|0 |1 is obsolete| | Attachment #11972|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart --- Created attachment 11998 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11998&action=edit Bug 7986: Export issues for patron In the circulation page, you can now export (as csv or iso2709) a list of items which are currently checked out by a borrower. 3 export types: - iso2709 with items: Export the items list in iso2709 format with item informations. - iso2709 without items: Export the items list in iso2709 format without item informations. - CSV: Export the items list based on a csv profil. 2 new system preferences: - DontExportFields: a list of fields not to be export - CsvProfileForExport: The Csv profile name used for the csv export Test plan: - Fill the CsvProfileForExport syspref - go on the borrower circulation page containing checkouts - Select one or more items and export them to the 3 different formats. - check if the result file is what you expected - Test there is no regression with the export authority - Test there is no regression using tools/export.pl with the command line interface Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 10:43:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 08:43:00 +0000 Subject: [Koha-bugs] [Bug 7986] Export issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 --- Comment #22 from Jonathan Druart --- Created attachment 11999 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11999&action=edit Bug 7986: Followup: FIX display checkboxes for the today checkouts Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 10:43:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 08:43:06 +0000 Subject: [Koha-bugs] [Bug 7986] Export issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 --- Comment #23 from Jonathan Druart --- Created attachment 12000 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12000&action=edit Bug 7986: Followup: Replace DontExportFields and CsvProfileForExport Replace DontExportFields by ExportRemoveFields and CsvProfileForExport by ExportWithCsvProfile -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 10:45:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 08:45:55 +0000 Subject: [Koha-bugs] [Bug 7986] Export issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 --- Comment #24 from Jonathan Druart --- rebased patches. The last one is rewritten. Now all occurrences are replaced. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 10:53:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 08:53:05 +0000 Subject: [Koha-bugs] [Bug 8717] Wrong subscription notes are showing in catalogue detail view of serials in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8717 --- Comment #5 from Jonathan Druart --- (In reply to comment #4) > Created attachment 11994 [details] > Screenshot of "subscription notes" > > This is the patched version. Ordinarily, it would show "subscription public > note" . Yes, sorry, I didn't test at the right place :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 10:53:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 08:53:21 +0000 Subject: [Koha-bugs] [Bug 8717] Wrong subscription notes are showing in catalogue detail view of serials in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8717 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11949|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 12001 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12001&action=edit Bug 8717 - Wrong subscription notes are showing in catalogue detail view of serials in staff client Changes the subscription note from the opac "notes" to the proper staff client "internalnotes" field. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 10:53:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 08:53:34 +0000 Subject: [Koha-bugs] [Bug 8717] Wrong subscription notes are showing in catalogue detail view of serials in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8717 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 11:04:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 09:04:38 +0000 Subject: [Koha-bugs] [Bug 8496] show local cover images on lists view in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8496 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #7 from Jonathan Druart --- Patch already passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 11:04:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 09:04:52 +0000 Subject: [Koha-bugs] [Bug 8496] show local cover images on lists view in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8496 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |koha.sekjal at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 11:54:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 09:54:07 +0000 Subject: [Koha-bugs] [Bug 8716] Reordering of routing list entries doesn't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8716 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored --- Comment #2 from Robin Sheat --- Client notes that this fixes the issue for them. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 11:56:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 09:56:22 +0000 Subject: [Koha-bugs] [Bug 8034] Enable server print queue selection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8034 --- Comment #13 from Jonathan Druart --- (In reply to comment #12) > Can you please shed some light on how to run those tests. Hum... no :) I don't know either ! It seems these tests are not still used currently. from irc : Joubu: Does someone know if unit tests in t/db_dependent/lib/KohaTest are still used ? rangi: no they aren't rangi: but if they could be made to work again, they would be rangi: you can never have too many tests Some feedback about your patch: 1/ The syspref UsePrintQueues already exists and the updatedatabase will raise an error. I think the insert is useless. 2/ A link is missing in the left menu in the administration module (under Additional parameters) 3/ The edit action does not work (in my logs: use of uninitialized value $data[0] in concatenation (.) or string at /home/koha/C4/Printer.pm line 95) 4/ It would be possible to remote one click. Indeed after adding a printer we have to click on a useless 'ok' button. Can we redirect directly on the printer list page ? 5/ When I edit a library, the printer is not selected by default 6/ In header.inc it would be better to hide the '-' caracter if there is no printer defined for the current library. 7/ It would be great to automatically select (on the fly) the printer attached to the library we select (on the selectbranchprinter page) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 12:23:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 10:23:08 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11846|0 |1 is obsolete| | --- Comment #230 from Jonathan Druart --- Created attachment 12002 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12002&action=edit Bug 5327: Unit tests for C4 socialdata Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 12:23:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 10:23:53 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12002|Bug 5327: Unit tests for C4 |[PASSED-QA]Bug 5327: Unit description|socialdata |tests for C4 socialdata -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 12:25:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 10:25:16 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11764|0 |1 is obsolete| | --- Comment #231 from Jonathan Druart --- Created attachment 12003 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12003&action=edit Bug 5327: Testing c4 Images Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 12:25:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 10:25:44 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12003|Bug 5327: Testing c4 Images |[PASSED-QA]Bug 5327: description| |Testing c4 Images -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 12:26:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 10:26:45 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11763|[SIGNED-OFF] Added tests to |[PASSED-QA] Added tests to description|installer_perlmodules |installer_perlmodules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 12:27:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 10:27:48 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #232 from Jonathan Druart --- (In reply to comment #231) (In reply to comment #230) New perltidied patches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 12:28:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 10:28:36 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11993|[SIGNED OFF] Bug 5327 : |[PASSED-QA] Bug 5327 : description|Fixing a typo in the test |Fixing a typo in the test |that was causing a false |that was causing a false |fail |fail -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 12:28:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 10:28:49 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 13:07:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 11:07:39 +0000 Subject: [Koha-bugs] [Bug 8002] Can't add patron attribute type in newer installation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8002 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P2 CC| |frederic at tamil.fr --- Comment #8 from Fr?d?ric Demians --- WARNING: This patch borrower_attribute_types by truncating category_code content. Those lines: `category_code` VARCHAR(1) NULL DEFAULT NULL,-- defines a category for an attribute_type $DBversion = "3.08.00.XXX"; if ( C4::Context->preference("Version") < TransformToNum($DBversion) ) { $dbh->do("ALTER TABLE borrower_attribute_types CHANGE category_code category_code VARCHAR( 1 ) NULL DEFAULT NULL"); print "Upgrade to $DBversion done. (Bug 8002: Update patron attribute types table to allow NULL category_code)\n"; SetVersion($DBversion); } are wrong. category_code length is 10 not 1! It means that after update, attributes by category don't work anymore, and configuration is lost. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 13:30:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 11:30:57 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #36 from Kyle M Hall --- (In reply to comment #35) > (In reply to comment #33) > > This patch does not allow a librarian to validate or reject a self > > registration isn't it ? > > Auto answer: In fact yes. In the issuing rules, we can restrict issues for > the corresponding patron category. > Like that we can simulate a pre-registration. > A user is fully registrated when he has a "real" patron category. That is exactly what I was going for. They idea is to create a TEMP patron category and when the patron comes in to the library, the patron can show whatever proof they need to and a library can change his or her patron category accordingly. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 13:31:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 11:31:25 +0000 Subject: [Koha-bugs] [Bug 8002] Can't add patron attribute type in newer installation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8002 --- Comment #9 from Paul Poulain --- mmm... The patch is: - `category_code` VARCHAR(1) NOT NULL DEFAULT '',-- defines a category for an attribute_type + `category_code` VARCHAR(1) NULL DEFAULT NULL,-- defines a category for an attribute_type so category_code is already set to varchar(1) before this patch. This patch just set NULL instead of NOT NULL Digging kohastructure git history now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 13:36:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 11:36:25 +0000 Subject: [Koha-bugs] [Bug 8002] Can't add patron attribute type in newer installation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8002 --- Comment #10 from Paul Poulain --- The patch introducing this column is: bb35b608282e670e1bb07bf4cea324fc16b6ec90 Auteur: Jonathan Druart 2012-02-10 09:57:35 Bug 7154: Modification in borrower attributes * group some attributes for a more friendly display * allow a link between a borrower category and an attribute to display it only for the specified category * Attr classes filled with AV 'PA_CLASS' category (you have to create AV with a new category 'PA_CLASS' to fill class list) this patch add 2 fields in borrower_attribute_types : category_code class Signed-off-by: Julien Sicot Signed-off-by: Paul Poulain I just tried to add a filtered attribute = DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`lecannetdesmaures`.`borrower_attribute_types`, CONSTRAINT `category_code_fk` FOREIGN KEY (`category_code`) REFERENCES `categories` (`categorycode`)) at /home/paul/koha.dev/koha-community/C4/Members/AttributeTypes.pm line 220. !!! Just spoke with jonathan, and, unfortunately, in his test database, he only has 1 digit categories, so it work fine !!! Patch coming ;-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 14:11:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 12:11:51 +0000 Subject: [Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7690 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 14:11:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 12:11:51 +0000 Subject: [Koha-bugs] [Bug 7690] hidelostitems not working in Normal Display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7690 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8462 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 14:15:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 12:15:01 +0000 Subject: [Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff Assignee|gmcharlt at gmail.com |fridolyn.somers at biblibre.co | |m --- Comment #2 from Fridolyn SOMERS --- Created attachment 12004 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12004&action=edit Proposed patch Very small patch. Just restores previous behavior by not removing any record from search results. Beware that bug 7690 patch modifies the same lines. An other side-effect has been found : when search matches only one record and this record has only hidden items, you get a 404 error page :-/ Please test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 14:28:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 12:28:16 +0000 Subject: [Koha-bugs] [Bug 5912] Hold queue 'jump' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5912 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #2 from Paul Poulain --- Hi Srdjan, This bug entry is 18 months old. Is there some code coming, or is it abandonned ? (we -BibLibre- are listing all pending improvements we could work on -see bug 8362- and try to find dependencies/conflicts) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 14:28:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 12:28:34 +0000 Subject: [Koha-bugs] [Bug 8644] jQueryUI CSS file should not contain customizations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8644 --- Comment #5 from Owen Leonard --- Created attachment 12005 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12005&action=edit Bug 8644 [OPAC] jQueryUI CSS file should not contain customizations This patch moves jQueryUI customizations into the main CSS file for the OPAC. In order to get the corrected default version of jquery-ui.css I have upgraded all core jQueryUI files. Testers should look at examples of each of the various jQueryUI widgets we use in the OPAC to confirm continued functinality: tabs and datepickers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 14:34:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 12:34:10 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11978|0 |1 is obsolete| | --- Comment #37 from Kyle M Hall --- Created attachment 12006 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12006&action=edit Bug 7067 - OPAC Borrower Self Registration -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 14:40:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 12:40:50 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #38 from Kyle M Hall --- > 1/ I still have the sql error on submitting form. It seems caused by the > action_log constraint: > DBD::mysql::st execute failed: Column 'user' cannot be null at > /home/koha/C4/Log.pm line 79., referer: > http://opac.koha.localhost/cgi-bin/koha/opac-memberentry.pl Fixed. It was a minor semantic error in Log.pm. It would get a borrowernumber from env if env was a hash, but wasn't bothering to check if there was actually a borrowernumber stored in env! > 2/ > > > I don't know if it is configurable (in the jquery plugin) but now it's not > possible to select a year < 2002 with just one click :-/ Another good catch! I've fixed it so it displays the last 120 years. That should far enough back for 99.999% of people. > 3/ on opac-user.pl: > "If you don't have a library card, stop by your local library to sign up or > register here.. " > There is 2 dots on the end of the line. Fixed. > 4/ Strange behaviour: > modify your personnal details to replace a value with an other. > Resubmit a change but replacing a value with an empty string. > At intranet, you see an empty table (just with headers) in the 'changes' > column. Also fixed. > > > These are not valid. I use 'use Modern::Perl' which enables both warnings > > and strictures. The rest of the errors you saw should be fixed. > Your first patch did not have any module use ;) Did not realize that! Better late than never! > > This patch does not allow a librarian to validate or reject a self > registration isn't it ? No it doesn't, that is meant to be 'interactive' where the patron comes in to the library with whatever documentation is necessary for membership. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 14:40:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 12:40:52 +0000 Subject: [Koha-bugs] [Bug 8366] Meaning of "All" in issuing rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8366 --- Comment #7 from Paul Poulain --- (In reply to comment #5) > The problem here in the US is that it used to say Default and confused the > librarians here so that's why it was changed to 'All' - so now we're looking > for another word that will make sense to everyone. > > Maybe it needs to be a phrase instead if it's a translation issue. I repeat what I wrote in comment 7: could we replace 'All' by something else? I propose : 'No specific itemtype rule'; 'other itemtype', 'any', 'otherwise', 'any other itemtype' Nicole, any other suggestion ? one of mine sounds good ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 14:41:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 12:41:04 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12006|0 |1 is obsolete| | --- Comment #39 from Kyle M Hall --- Created attachment 12007 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12007&action=edit Bug 7067 - OPAC Borrower Self Registration -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 14:58:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 12:58:37 +0000 Subject: [Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #29 from Marc V?ron --- I had the same error as well and do not know how to resolve it: Applying: Bug 7642 - fix the lost display of tag sizes fatal: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/prog/en/modules/opac-tags.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 15:11:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 13:11:16 +0000 Subject: [Koha-bugs] [Bug 8370] Default checkout, hold and return policy for all library => wrong term In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8370 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nengard at gmail.com |ity.org | --- Comment #1 from Paul Poulain --- Nicole, if you can do something with this bug and suggest a correct term (hoping you'll understand my description !) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 15:13:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 13:13:16 +0000 Subject: [Koha-bugs] [Bug 8726] Did you mean? plugin for broader/narrower/related terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 15:13:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 13:13:22 +0000 Subject: [Koha-bugs] [Bug 8726] Did you mean? plugin for broader/narrower/related terms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 --- Comment #1 from Jared Camins-Esakov --- Created attachment 12008 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12008&action=edit Bug 8726: ExplodedTerms suggestion plugin When working with hierarchical subject headings, it is sometimes helpful to do a search for all records with a specific subject, plus broader/narrower/related subjects. This patch adds a suggestion plugin for these "exploded" subject searches to Koha. Note that this patch depends on both bug 8211 AND bug 8209. To test (NOTE: this test plan covers both 8211 and 8726): 1) Make sure you have a bunch of hierarchical subjects. I created geographical subjects for "Arizona," "United States," and "Phoenix," and linked them together using 551s, and made sure I had a half dozen records linking to each (but not all to all three). 2) Do a search for su-br:Arizona (or choose "Subject and broader terms" on the advanced search screen with "more options" displayed), and check that you get the records with the subject "Arizona" and the records with the subject "United States" 3) Do a search for su-na:Arizona (or choose "Subject and narrower terms" on the advanced search screen with "more options" displayed), and check that you get the records with the subject "Arizona" and the records with the subject "Phoenix" 4) Do a search for su-rl:Arizona (or choose "Subject and related terms" on the advanced search screen with "more options" displayed), and check that you get the records with the subject "Arizona," the records with the subject "United States," and the records with the subject "Phoenix" 5) Ensure that other searches still work (keyword, subject, ccl, whatever) 6) Use "Did you mean?" page in admin section to enable ExplodedTerms plugin 7) Do a keyword search on the OPAC, confirm that searching for exploded terms is suggested. 8) Do a subject search on the OPAC, confirm that searching for exploded terms is suggested. 9) Do a non-keyword, non-subject search on the OPAC, confirm that searching for exploded terms is NOT suggested. 10) Disable ExplodedTerms plugin and enable AuthorityFile plugin. 11) Do search on OPAC, confirm suggestions are made from authority file. 12) Sign off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 15:23:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 13:23:38 +0000 Subject: [Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173 --- Comment #19 from Kyle M Hall --- Created attachment 12009 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12009&action=edit Bug 4173: Followup: Document KohaAuthorisedValues plugin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 15:24:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 13:24:23 +0000 Subject: [Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 15:39:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 13:39:49 +0000 Subject: [Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12009|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall --- Created attachment 12010 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12010&action=edit Bug 4173: Followup: Document KohaAuthorisedValues plugin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 15:43:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 13:43:44 +0000 Subject: [Koha-bugs] [Bug 7678] Statistics wizard: patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7678 MathildeF changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathilde.formery at ville-nime | |s.fr --- Comment #6 from MathildeF --- also tested in a sandbox no white screen for me but: - Filters on authorised_value does not work: I have selected a single value, and the results table displays all the values - I dont see "dateenrolled" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 16:13:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 14:13:07 +0000 Subject: [Koha-bugs] [Bug 8002] Can't add patron attribute type in newer installation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8002 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9311|0 |1 is obsolete| | Attachment #9367|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart --- Created attachment 12011 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12011&action=edit Bug 8002: FIX Change datatype from varchar 1 to 10 for borrower_attribute_types.category_code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 16:13:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 14:13:35 +0000 Subject: [Koha-bugs] [Bug 8002] Can't add patron attribute type in newer installation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8002 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 16:13:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 14:13:41 +0000 Subject: [Koha-bugs] [Bug 8002] Can't add patron attribute type in newer installation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8002 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 16:13:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 14:13:51 +0000 Subject: [Koha-bugs] [Bug 8002] Can't add patron attribute type in newer installation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8002 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 16:23:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 14:23:14 +0000 Subject: [Koha-bugs] [Bug 8002] Can't add patron attribute type in newer installation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8002 --- Comment #12 from Fr?d?ric Demians --- Thanks a lot for fixing it so quickly! I will sign-off the patch. Don't you think a warning, somewhere, must be addressed to Koha sysadmin? I propose: Warning to Koha System Administrators: If you use borrower attributes defined by borrower categories, you have to check your configuration. A bug may have removed your attribute links to borrower categories. Please check, and fix it if necessary. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 16:28:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 14:28:10 +0000 Subject: [Koha-bugs] [Bug 8002] Can't add patron attribute type in newer installation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8002 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12011|0 |1 is obsolete| | --- Comment #13 from Fr?d?ric Demians --- Created attachment 12012 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12012&action=edit [SIGNED-OFF] FIX Change datatype from varchar 1 to 10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 16:28:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 14:28:22 +0000 Subject: [Koha-bugs] [Bug 8002] Can't add patron attribute type in newer installation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8002 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 16:33:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 14:33:09 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12007|0 |1 is obsolete| | --- Comment #40 from Jonathan Druart --- Created attachment 12013 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12013&action=edit Bug 7067 - OPAC Borrower Self Registration Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 16:34:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 14:34:09 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #41 from Owen Leonard --- A point for discussion: I think the registration confirmation messages should come from the email address of the library the user chose as their home library. The counter-argument is that the user may not have chosen the correct library, but I don't see that as much of a problem since either way the reply would be coming from an email address which wasn't their library's. The big issue I'm still seeing: New records are saved with NULL expiration date and NULL registration date. Will the delete_expired_opac_registrations cron job work with a NULL dateenrolled? Some small issues: - I think a note about pending patron modifications should appear on the patrons page (members/members-home.pl) in addition to the staff client home page, just as pending tag/comment/suggestions also show as pending on the Tools page. - Bug 8593 added unique IDs to the other "pending" notes. This patch should include one for the line it adds. - members/members-update.pl needs a descriptive page title and page header. If there are no pending operations it should display a message saying so rather than an empty table. - The table markup on members/members-update.pl is missing a , causing validation errors. - I think the random-character verification field should be styled like other required fields - Since the datepicker widget doesn't make it easy to pick a date far in the past (as are birthdays for some of us), I don't think the field should be read-only. - I think opac-memberentry-update-submitted.tt should include the user sidebar menu. - I see an error in the log when submitting the registration form in the OPAC: substr outside of string at /home/oleonard/kohaclone/opac/opac-memberentry.pl line 239 If PatronSelfRegistrationExpireTemporaryAccountsDelay is set to "0" does that mean never? If so the description should say so. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 16:37:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 14:37:05 +0000 Subject: [Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 --- Comment #30 from Robin Sheat --- Created attachment 12014 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12014&action=edit Bug 7642 - fix the lost display of tag sizes This fixes the display of different sized words for differently popular tags. It is a bit of a refactor of that part of the system, moving logic to more sensible places (and removing an unused method on the way.) Note that it isn't an attempt to reproduce what was there previously, just to do something similar, and in an easier to change fashion. Sponsored-By: New Zealand Educational Institute -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 16:37:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 14:37:55 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #42 from Jonathan Druart --- Ho, collision :) So I don't switch to signed off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 16:41:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 14:41:01 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #43 from Katrin Fischer --- Hm, only a note, but isn't PatronSelfRegistrationExpireTemporaryAccountsDelay a bit montrous for a syspref name? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 16:43:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 14:43:40 +0000 Subject: [Koha-bugs] [Bug 8002] Can't add patron attribute type in newer installation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8002 --- Comment #14 from Jonathan Druart --- (In reply to comment #12) > Don't you think a warning, somewhere, must be addressed to Koha > sysadmin? I think it is not necessary given that informations were not updated (or inserted). Moreover the issue exists only for a new install (not updated install). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 16:48:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 14:48:56 +0000 Subject: [Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #31 from Robin Sheat --- I think the issue was that I'd based it off a branch that you didn't have, and so it couldn't do 3-way merge when it found a conflict. Try this, which is based off current master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 16:49:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 14:49:25 +0000 Subject: [Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10988|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 17:00:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 15:00:53 +0000 Subject: [Koha-bugs] [Bug 8733] Adding critic reviews to book pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8733 --- Comment #1 from Owen Leonard --- Created attachment 12015 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12015&action=edit Slide one: New tab -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 17:01:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 15:01:17 +0000 Subject: [Koha-bugs] [Bug 8002] Can't add patron attribute type in newer installation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8002 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #15 from Fr?d?ric Demians --- > I think it is not necessary given that informations were not updated > (or inserted). Moreover the issue exists only for a new install (not > updated install). In updatedatabase.pl, on HEAD branch, line 5218, an ALTER TABLE truncate category_code field from 10 to 1 character. Same issue, same line in 3.8.x, for 3.08.00.001 version. So we need a patch for the two branches. And a warning message. I confirm that I have a library on 3.8 which has had truncated its attributes by borrower categories. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 17:01:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 15:01:45 +0000 Subject: [Koha-bugs] [Bug 8733] Adding critic reviews to book pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8733 --- Comment #2 from Owen Leonard --- Created attachment 12016 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12016&action=edit Slide 2: Snippets of critics' reviews -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 17:02:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 15:02:12 +0000 Subject: [Koha-bugs] [Bug 8002] Can't add patron attribute type in newer installation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8002 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12012|0 |1 is obsolete| | --- Comment #16 from Fr?d?ric Demians --- Comment on attachment 12012 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12012 [SIGNED-OFF] FIX Change datatype from varchar 1 to 10 updatedatabase.pl must also be fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 17:02:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 15:02:15 +0000 Subject: [Koha-bugs] [Bug 8733] Adding critic reviews to book pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8733 --- Comment #3 from Owen Leonard --- Created attachment 12017 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12017&action=edit Slide 3: Critics' rating -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 17:02:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 15:02:35 +0000 Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187 --- Comment #18 from Robin Sheat --- I've updated the RFC page with my plans for getting something done. This won't be the full solution, but I think a good-enough starting point that can be built on. It's also possible I'll have some sponsorship for this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 17:02:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 15:02:39 +0000 Subject: [Koha-bugs] [Bug 8733] Adding critic reviews to book pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8733 --- Comment #4 from Owen Leonard --- Created attachment 12018 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12018&action=edit Slide 4: Readometer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 17:03:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 15:03:52 +0000 Subject: [Koha-bugs] [Bug 8002] Can't add patron attribute type in newer installation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8002 --- Comment #17 from Jonathan Druart --- Yes I have just seen that ! But why mysql breaks a constraint ?? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 17:04:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 15:04:31 +0000 Subject: [Koha-bugs] [Bug 8733] Adding critic reviews to book pages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8733 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 17:15:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 15:15:06 +0000 Subject: [Koha-bugs] [Bug 8735] New: Expire holds waiting only on days the library is open Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735 Priority: P5 - low Change sponsored?: --- Bug ID: 8735 CC: gmcharlt at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: Expire holds waiting only on days the library is open Severity: enhancement Classification: Unclassified OS: All Reporter: kyle at bywatersolutions.com Hardware: All Status: NEW Version: master Component: Hold requests Product: Koha There is a problem with expiring reserves. Let us say an items has two holds placed on it, and is set to waiting for the first hold. This hold is then canceled for waiting too long, yet it will remain sitting on the holds shelf until a librarian either returns it to the shelf, or sets it too waiting for the next person in line to get it. During the interim, the item will appear to be available for checkout. This is not a problem most of the time, as the holds expire late at night and the librarians will take care of it in the morning, but over a holiday weekend, it is possible that an item will remain in this state for days at a time. We can fix this situation by adding a system preference to decide of waiting holds should be canceled on holidays, or not. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 17:21:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 15:21:34 +0000 Subject: [Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735 --- Comment #1 from Kyle M Hall --- Created attachment 12019 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12019&action=edit Bug 8735 - Expire holds waiting only on days the library is open -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 17:22:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 15:22:39 +0000 Subject: [Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12019|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 12020 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12020&action=edit Bug 8735 - Expire holds waiting only on days the library is open -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 17:22:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 15:22:48 +0000 Subject: [Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 17:22:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 15:22:56 +0000 Subject: [Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 17:43:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 15:43:12 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #44 from Kyle M Hall --- (In reply to comment #43) > Hm, only a note, but isn't > PatronSelfRegistrationExpireTemporaryAccountsDelay a bit montrous for a > syspref name? Yes, yes it is ; ) But it was the shortest version that would describe it correctly. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 17:48:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 15:48:35 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #45 from Kyle M Hall --- (In reply to comment #41) > A point for discussion: I think the registration confirmation messages > should come from the email address of the library the user chose as their > home library. The counter-argument is that the user may not have chosen the > correct library, but I don't see that as much of a problem since either way > the reply would be coming from an email address which wasn't their library's. I suppose a followup for that would not be too much trouble. > The big issue I'm still seeing: New records are saved with NULL expiration > date and NULL registration date. Will the delete_expired_opac_registrations > cron job work with a NULL dateenrolled? This should be fixed in the current version of the patch. > Some small issues: > > - I think a note about pending patron modifications should appear on > the patrons page (members/members-home.pl) in addition to the staff > client home page, just as pending tag/comment/suggestions also show > as pending on the Tools page. I'll take a look and add a followup for that. > > - Bug 8593 added unique IDs to the other "pending" notes. This patch > should include one for the line it adds. I'll have to look into that. > - members/members-update.pl needs a descriptive page title and page > header. If there are no pending operations it should display a message > saying so rather than an empty table. I suppose we can do that, but if there are no pending operations, the link for the page disappears, so it is assumed no one will visit it when there are no pending operations. > - The table markup on members/members-update.pl is missing a , > causing validation errors. I'll look at it. > - I think the random-character verification field should be styled like > other required fields Good idea. > - Since the datepicker widget doesn't make it easy to pick a date far in > the past (as are birthdays for some of us), I don't think the field > should be read-only. I suppose we can do that. I'm a bit iffy about that one though. > - I think opac-memberentry-update-submitted.tt should include the user > sidebar menu. I'll see what I can do about that. > - I see an error in the log when submitting the registration form in > the OPAC: > > substr outside of string at > /home/oleonard/kohaclone/opac/opac-memberentry.pl line 239 I'll take a look at that too. > If PatronSelfRegistrationExpireTemporaryAccountsDelay is set to "0" does > that mean never? If so the description should say so. That is correct. I'll have to add it to the description. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 17:50:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 15:50:27 +0000 Subject: [Koha-bugs] [Bug 8002] Can't add patron attribute type in newer installation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8002 --- Comment #18 from Fr?d?ric Demians --- > Yes I have just seen that ! But why mysql breaks a constraint ?? When category_code is truncated to 1 character, it is no more possible to link borrower attribute types to borrower categories which are still 10 characters length. And if 2 attributes have been linked to 2 distinct borrower categories like ENFANT and ETUDIANT, category_code will contain E after ALTER TABLE for both attributes, and the link won't work anymore. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 18:00:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 16:00:28 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #46 from Owen Leonard --- (In reply to comment #45) > > The big issue I'm still seeing: New records are saved with NULL expiration > > date and NULL registration date. Will the delete_expired_opac_registrations > > cron job work with a NULL dateenrolled? > > This should be fixed in the current version of the patch. I don't find that to be the case. Another issue, which came up on IRC but should be noted here as well: The registration confirmation messages are sent to the message queue, but the message queue might not be processed in a timely manner. Others on IRC said theirs were set to process as infrequently as once an hour. I think a delay as long as one hour is contrary to the expectations many users will have based on other web applications. As a result I think repeated self-registrations are likely as people assume theirs didn't work. I think this is a pretty serious concern. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 18:21:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 16:21:15 +0000 Subject: [Koha-bugs] [Bug 8736] New: Series searching causes script error Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8736 Priority: P5 - low Change sponsored?: --- Bug ID: 8736 Assignee: gmcharlt at gmail.com Summary: Series searching causes script error Severity: normal Classification: Unclassified OS: All Reporter: ago at bywatersolutions.com Hardware: All Status: NEW Version: rel_3_8 Component: Searching Product: Koha I've reproduced this with XP+Firefox 15 (and 12) and Mint+Firefox 11 and each of those in different 3.8 sites Clicking on a serials search causes this pop-up error: A script on this page may be busy, or it may have stopped responding. You can stop the script now, or you can continue to see if the script will complete. Script: http://catalog.cin.bywatersolutions.com/opac-tmpl/prog/en/lib/jquery/plugins/jquery.highlight-3.js:26 Steps to reproduce: http://catalog.cin.bywatersolutions.com/cgi-bin/koha/opac-main.pl search au: sue harrison On left-side bar click on any of the Series links. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 18:28:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 16:28:37 +0000 Subject: [Koha-bugs] [Bug 8736] Series searching causes script error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8736 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |robin at catalyst.net.nz Resolution|--- |DUPLICATE --- Comment #1 from Robin Sheat --- Almost certainly a duplicate, if it's not, feel free to reopen. *** This bug has been marked as a duplicate of bug 8646 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 18:28:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 16:28:37 +0000 Subject: [Koha-bugs] [Bug 8646] Certain search terms cause browser "script taking too long" error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8646 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ago at bywatersolutions.com --- Comment #7 from Robin Sheat --- *** Bug 8736 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 18:29:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 16:29:15 +0000 Subject: [Koha-bugs] [Bug 8736] Series searching causes script error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8736 --- Comment #2 from Robin Sheat --- (and if it's not a duplicate, it'll have a very similar cause) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 18:32:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 16:32:55 +0000 Subject: [Koha-bugs] [Bug 2930] Put other name on checkout screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2930 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11783|0 |1 is obsolete| | --- Comment #5 from Owen Leonard --- Created attachment 12021 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12021&action=edit Bug 2930 [REVISED] Put other name on checkout screen This patch adds other name to the include which is used to display patron names and adds this include in several places where it can be used in place of direct output. The patron-title include has been modified to handle the two possible variable scopes throughout patron-related templates. This is a hack similar to having both circ-menu.tt and circ-menu.inc, but keeping both in the same file. Changes to some scripts were necessary to make the othernames variable available to the include. This patch also corrects some tags and fixes some incorrect capitalization (see Bug 2780). To test, view each of the pages affected by these template changes and confirm that the patron's name displays correctly, including their "other name." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 18:33:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 16:33:09 +0000 Subject: [Koha-bugs] [Bug 2930] Put other name on checkout screen In-Reply-To: <bug-2930-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2930-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2930-70-rvG0R1oAz7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2930 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 18:47:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 16:47:48 +0000 Subject: [Koha-bugs] [Bug 8694] Show accurate subscription renewal warning for expired subscriptions In-Reply-To: <bug-8694-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8694-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8694-70-S9dPbnr8vZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8694 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 20:00:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 18:00:40 +0000 Subject: [Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag In-Reply-To: <bug-7642-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7642-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7642-70-WMQkwmqKYM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12014|0 |1 is obsolete| | --- Comment #32 from Marc V?ron <veron at veron.ch> --- Created attachment 12022 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12022&action=edit [SIGNED-OFF] Bug 7642 - fix the lost display of tag sizes This fixes the display of different sized words for differently popular tags. It is a bit of a refactor of that part of the system, moving logic to more sensible places (and removing an unused method on the way.) Note that it isn't an attempt to reproduce what was there previously, just to do something similar, and in an easier to change fashion. Sponsored-By: New Zealand Educational Institute Signed-off-by: Marc Veron <veron at veron.ch> Works as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 20:01:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 18:01:18 +0000 Subject: [Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag In-Reply-To: <bug-7642-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7642-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7642-70-qcRM1emVZl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 20:06:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 18:06:32 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-YOiMU0eRkY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #47 from Owen Leonard <oleonard at myacpl.org> --- Another issue: The note about Patrons requesting modifications on the staff client home page does not show up if you are not a superlibrarian. The permissions check needs to be added to the conditional which controls the display of all pending operations (line 101 of intranet-main.tt). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 20:10:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 18:10:48 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-LCvOj12Vb9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #48 from Owen Leonard <oleonard at myacpl.org> --- If the "IndependantBranches" preference is turned on it should not be possible for a librarian from Library A to approve changes to the account of a patron with branchcode = Library B. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 20:22:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 18:22:08 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-1SFm6mWDhI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #49 from Owen Leonard <oleonard at myacpl.org> --- (In reply to comment #45) > > If there are no pending operations it should display a message > > saying so rather than an empty table. > > I suppose we can do that, but if there are no pending operations, the link > for the page disappears, so it is assumed no one will visit it when there > are no pending operations. Actually as I work with it more and test leaving some patron modifications to "ignore," it makes sense to me to have this page redirect back to itself rather than the home page. If some lines had been set to "ignore" then they re-display. If all are complete it shows a message that the queue is empty. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 20:29:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 18:29:44 +0000 Subject: [Koha-bugs] [Bug 8732] Add a systempreference to allow users to choose to display an icon based on the marc control fields, or based on the koha biblio level itemtype In-Reply-To: <bug-8732-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8732-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8732-70-13vVdAa2Ti@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard at myacpl.org |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 20:29:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 18:29:52 +0000 Subject: [Koha-bugs] [Bug 5260] It would be nice if Koha's Acquisition module could order by email In-Reply-To: <bug-5260-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5260-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5260-70-Zm2M5xHIbG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 20:38:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 18:38:13 +0000 Subject: [Koha-bugs] [Bug 6762] show orderline numbers in the basket display In-Reply-To: <bug-6762-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6762-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6762-70-xSle27ZCKv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6762 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 20:42:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 18:42:30 +0000 Subject: [Koha-bugs] [Bug 8729] Browse results from OPAC detail page should allow paging through results In-Reply-To: <bug-8729-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8729-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8729-70-DPbha26RZl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8729 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|browse not doing pages |Browse results from OPAC | |detail page should allow | |paging through results Severity|normal |enhancement --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- git checkout 4a2a95cc254f0ed1d5fcd6ea7084a5b08ef04952 to see what the behavior was when this was first added. It looks the same to me. I'm assuming that makes this an enhancement request? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 21:03:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 19:03:19 +0000 Subject: [Koha-bugs] [Bug 8730] browse overlaying powered by In-Reply-To: <bug-8730-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8730-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8730-70-tru5oWOZS6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8730 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 21:08:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 19:08:13 +0000 Subject: [Koha-bugs] [Bug 8730] browse overlaying powered by In-Reply-To: <bug-8730-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8730-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8730-70-z7UP6TrabV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8730 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 12023 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12023&action=edit Bug 8730 - browse overlaying powered by This patch adds a "z-index" property to the CSS for the browse results menu so that it will appear on top of the "Powered by Koha" link. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 21:08:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 19:08:28 +0000 Subject: [Koha-bugs] [Bug 8730] browse overlaying powered by In-Reply-To: <bug-8730-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8730-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8730-70-ORlnTxOlCz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8730 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 21:10:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 19:10:07 +0000 Subject: [Koha-bugs] [Bug 6716] Database Documentation In-Reply-To: <bug-6716-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6716-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6716-70-0KoDS3fyZc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6716 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11987|0 |1 is obsolete| | --- Comment #131 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 12024 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12024&action=edit Bug 6716 - Fix alt contact field documentation The borrowers table has the wrong documentation for the alternate address3 and city fields. This fixes that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 21:23:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 19:23:28 +0000 Subject: [Koha-bugs] [Bug 8711] alternating colors messed up on reports In-Reply-To: <bug-8711-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8711-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8711-70-BtQmSCNV7F@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8711 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 12025 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12025&action=edit Bug 8711 - alternating colors messed up on reports Patch adds the "zebra-striping" option to the table sorter initialization and changes the row color CSS to match the tablesorter's to prevent conflicts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 21:25:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 19:25:08 +0000 Subject: [Koha-bugs] [Bug 8711] alternating colors messed up on reports In-Reply-To: <bug-8711-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8711-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8711-70-QFBazTHDcB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8711 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 21:28:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 19:28:50 +0000 Subject: [Koha-bugs] [Bug 8583] Add a warning if a Z39.50 search is started from the "Edit biblio record" page In-Reply-To: <bug-8583-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8583-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8583-70-BcFJnqYLcd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8583 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11392|0 |1 is obsolete| | --- Comment #3 from Marc V?ron <veron at veron.ch> --- Created attachment 12026 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12026&action=edit [SIGNED-OFF] Add a warning if a Z39.50 search is started from biblio edition page. Warn the user that the current biblio record might be overwritten by this action. http://bugs.koha-community.org/show_bug.cgi?id=8583 Signed-off-by: Marc Veron <veron at veron.ch> Woks as expected. I prefer this solution with an explicit warning, since several times I acidentally changed a record :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 21:29:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 19:29:34 +0000 Subject: [Koha-bugs] [Bug 8583] Add a warning if a Z39.50 search is started from the "Edit biblio record" page In-Reply-To: <bug-8583-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8583-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8583-70-Htvj6MH677@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8583 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 21:37:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 19:37:08 +0000 Subject: [Koha-bugs] [Bug 8686] author search in staff missing checkboxes and menu In-Reply-To: <bug-8686-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8686-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8686-70-zfn0znRMlI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8686 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- I cannot reproduce this bug. I'm wondering if there are some system preferences in play here. I see your screenshot has no cover images, so I turned those off. Is that correct? XSLT display? Custom javascript in use? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 21:48:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 19:48:10 +0000 Subject: [Koha-bugs] [Bug 5250] Various enhancements to web based checkouts In-Reply-To: <bug-5250-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5250-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5250-70-IhjwKF3jL5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5250 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 21:52:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 19:52:56 +0000 Subject: [Koha-bugs] [Bug 8710] Do not show the images tab in the OPAC if the record has no local cover images In-Reply-To: <bug-8710-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8710-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8710-70-92uKP1ylT6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8710 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|no images tab if no images |Do not show the images tab | |in the OPAC if the record | |has no local cover images -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 21:55:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 19:55:53 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-X9hDMp7mvj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 wajasu <matted-34813 at mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #35 from wajasu <matted-34813 at mypacks.net> --- This is working now! Everything seems to work now!!! CRUD - courses, adding instructors(teachers), to courses, adding reserves to sources, fields, and menus hiding when appropriate. Except: Permissions related: - if one wanted to delegate ADD/DEL reserves permissions without also the manage(ADE/EDIT?DEL) courses permission, that can't be done. Without manage courses, course_reserves is not an accessible page, so one can't get to the links to add/del reserves. - Also, while i had permissions to delete reserves, I copied the url of the remove link to the clipboard. then i removed the staff permssion allowing delete reserves. i logged in as staff and saw only the edit link (no remove), BUT I pasted the remove action url from my clipboard and the delete worked. So a check needs to be in the script/controller/security layer to see what is an accepted action. The same probably goes for courses. Ideas to consider - take em or leave em. - I can add multiple courses all with the SAME fields. Maybe a check to dissalow duplicates for (name, term, dept, course_number, section). - Maybe the TERM and DEPARTMENT could be added to the optional data that folks choose to load. The future testers would be helped. - I don't know the repercussion of having no library set. (NULL in columns?), You might want a check and popup to prevent adding rows unless a library is set. - I know after this is signed off, you will get other enhancements. A course_schedule ( Days/Hours) and course_location ( North Campus/Bldg A/Edgars Hall/Room 202) is something the "students" could use. Lots more work for future effort. Otherwise: Greate work!!! A lot to test. wajasu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 22:18:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 20:18:57 +0000 Subject: [Koha-bugs] [Bug 8719] Private lists always sorted by title (even when author or date is selected) In-Reply-To: <bug-8719-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8719-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8719-70-2o6Rt7eewx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8719 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11957|0 |1 is obsolete| | --- Comment #2 from Marc V?ron <veron at veron.ch> --- Created attachment 12027 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12027&action=edit [SIGNED-OFF] Bug 8719: Private lists always sorted by title Virtualshelves: The private lists were sorted by title, even when author or date was selected. This patch corrects this behaviour. Signed-off-by: Marc Veron <veron at veron.ch> With this patch lists sort as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 22:19:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 20:19:20 +0000 Subject: [Koha-bugs] [Bug 8719] Private lists always sorted by title (even when author or date is selected) In-Reply-To: <bug-8719-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8719-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8719-70-ogVMDD6xO6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8719 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 22:27:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 20:27:04 +0000 Subject: [Koha-bugs] [Bug 8721] typo in AllowItemsOnHoldCheckout In-Reply-To: <bug-8721-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8721-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8721-70-Z6JVAxse0P@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8721 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11963|0 |1 is obsolete| | --- Comment #2 from Marc V?ron <veron at veron.ch> --- Created attachment 12028 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12028&action=edit [SIGNED-OFF] Bug 8721: Fixes minor typo in AllowItemsOnHoldCheckout Small string fix to remove repeated word. Signed-off-by: Marc Veron <veron at veron.ch> Tiny typo fix -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 22:27:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 20:27:31 +0000 Subject: [Koha-bugs] [Bug 8721] typo in AllowItemsOnHoldCheckout In-Reply-To: <bug-8721-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8721-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8721-70-YNsVRHo3Xp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8721 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 22:52:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 20:52:38 +0000 Subject: [Koha-bugs] [Bug 5912] Hold queue 'jump' In-Reply-To: <bug-5912-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5912-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5912-70-Dyv3KlARlV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5912 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |chris at bigballofwax.co.nz Resolution|--- |WONTFIX --- Comment #3 from Chris Cormack <chris at bigballofwax.co.nz> --- This is is work that was never funded. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 22:52:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 20:52:39 +0000 Subject: [Koha-bugs] [Bug 5609] Holds Rewrite In-Reply-To: <bug-5609-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5609-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5609-70-qmyAG2GaLb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5609 Bug 5609 depends on bug 5912, which changed state. Bug 5912 Summary: Hold queue 'jump' http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5912 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 23:00:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 21:00:44 +0000 Subject: [Koha-bugs] [Bug 1633] Add ability to take book cover images from local img db In-Reply-To: <bug-1633-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-1633-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-1633-70-Y40W5mTOgZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED --- Comment #86 from Nicole C. Engard <nengard at gmail.com> --- Changing status to see if I can get an answer on my above comments. Is it working for everyone? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 23:06:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 21:06:23 +0000 Subject: [Koha-bugs] [Bug 8730] browse overlaying powered by In-Reply-To: <bug-8730-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8730-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8730-70-WbWWpM2O1N@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8730 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #2 from Marc V?ron <veron at veron.ch> --- The result of the patch is: a.koha_url { display: none; background-color:#F3F3F3; padding-bottom:10px; z-index: 100; } koha_url is related to the "Powered by..." Link (not to the browse results): <a class="koha_url" rel="nofollow" href="http://koha-community.org">Koha</a> ...and a positive z-index will bring it on the top of the other contents, not behind, see: https://developer.mozilla.org/en-US/docs/CSS/Understanding_z-index/Adding_z-index Or did I miss something? :-) Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 23:54:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 21:54:35 +0000 Subject: [Koha-bugs] [Bug 8732] Add a systempreference to allow users to choose to display an icon based on the marc control fields, or based on the koha biblio level itemtype In-Reply-To: <bug-8732-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8732-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8732-70-3CSNjNqu31@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 --- Comment #1 from Chris Cormack <chris at bigballofwax.co.nz> --- How to test: * Switch DisplayOPACiconsXSLT to show * Switch the XSLT templates for the OPAC to default * Test you see the icons generated from the MARC controlfields * Switch OpacResultsItemtypeImage to Information from the Koha biblio level itemtype * You should now see the biblio level itemtype image showing instead -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 23:54:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 21:54:51 +0000 Subject: [Koha-bugs] [Bug 8732] Add a systempreference to allow users to choose to display an icon based on the marc control fields, or based on the koha biblio level itemtype In-Reply-To: <bug-8732-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8732-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8732-70-j362dyAx1Z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 --- Comment #2 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 12029 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12029&action=edit Bug 8732 : Allowing biblio level itemtypes to display instead of MARC ones If you switch OpacResultsItemtypeImage to Koha, you will see the Koha itemtypes, if it is Control you will get the ones generated from the MARC control fields. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 6 23:55:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 21:55:05 +0000 Subject: [Koha-bugs] [Bug 8732] Add a systempreference to allow users to choose to display an icon based on the marc control fields, or based on the koha biblio level itemtype In-Reply-To: <bug-8732-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8732-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8732-70-yz8oxKIL9C@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 00:11:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 22:11:04 +0000 Subject: [Koha-bugs] [Bug 8711] alternating colors messed up on reports In-Reply-To: <bug-8711-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8711-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8711-70-CtdBWiBZ3t@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8711 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12025|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 12030 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12030&action=edit Bug 8711 - alternating colors messed up on reports Patch adds the "zebra-striping" option to the table sorter initialization and changes the row color CSS to match the tablesorter's to prevent conflicts. Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 00:11:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 22:11:17 +0000 Subject: [Koha-bugs] [Bug 8711] alternating colors messed up on reports In-Reply-To: <bug-8711-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8711-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8711-70-LzgOOe7lwK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8711 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 01:00:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 23:00:22 +0000 Subject: [Koha-bugs] [Bug 8728] t/db_dependent/Reserve.t test doesn't use resdate and expdate arguments for AddReserve In-Reply-To: <bug-8728-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8728-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8728-70-XacbuoscBx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8728 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11983|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 12031 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12031&action=edit Bug 8728 : Adjust Reserves.t test for resdate and expdate and test setup/teardown Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> Works better now, creats biblio records, and cleans up after itself as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 01:01:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 23:01:05 +0000 Subject: [Koha-bugs] [Bug 8728] t/db_dependent/Reserve.t test doesn't use resdate and expdate arguments for AddReserve In-Reply-To: <bug-8728-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8728-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8728-70-n6h8uCzwCj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8728 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 01:33:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 06 Sep 2012 23:33:59 +0000 Subject: [Koha-bugs] [Bug 5912] Hold queue 'jump' In-Reply-To: <bug-5912-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5912-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5912-70-63qfjMJZzV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5912 --- Comment #4 from Srdjan Jankovic <srdjan at catalyst.net.nz> --- Yes, it was meant to be a post-5911 enhancement. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 04:00:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 02:00:08 +0000 Subject: [Koha-bugs] [Bug 8034] Enable server print queue selection In-Reply-To: <bug-8034-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8034-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8034-70-rtc3idr7wY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8034 Srdjan Jankovic <srdjan at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #14 from Srdjan Jankovic <srdjan at catalyst.net.nz> --- (In reply to comment #13) > 1/ The syspref UsePrintQueues already exists and the updatedatabase will > raise an error. I think the insert is useless. I could not see that. Can you please point me to the place where that was introduced earlier. > > 2/ A link is missing in the left menu in the administration module (under > Additional parameters) I'm not sure what you mean by that. There's "Network Printers" link in "Additional parameters" > > 3/ The edit action does not work (in my logs: use of uninitialized value > $data[0] in concatenation (.) or string at /home/koha/C4/Printer.pm line 95) That is just a warning. I can get rid of it if you wish. Edit worked nicely for me. What exactly happened? > > 4/ It would be possible to remote one click. Indeed after adding a printer > we have to click on a useless 'ok' button. Can we redirect directly on the > printer list page ? Sounds reasonable. Will do. > > 5/ When I edit a library, the printer is not selected by default I think it was a design decision, and makes sense. There could be a library without a printer. And even if there's a printer, I think it is better to have it blank initially rather than default to the first one. But if community has a different opinion, I can change that. > > 6/ In header.inc it would be better to hide the '-' caracter if there is no > printer defined for the current library. Will do. > > 7/ It would be great to automatically select (on the fly) the printer > attached to the library we select (on the selectbranchprinter page) Makes sense, will do that one too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 06:42:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 04:42:35 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7736-70-OxXfNdSOwe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #11 from Brendan Gallagher <brendan at bywatersolutions.com> --- Thanks Collin - Again no problem installing the code on master. And everything works great for the examples that you gave. I have since worked on creating an new edi_message to test with a US company Baker and Taylor. It's currently only outgoing and I'm waiting on an example incoming from them. Once I have that I will forward it along to include with this - and hopefully some patches too.. My comment. I had to hard code in the Rebus/EDI.pm to be able to successfully create a outgoing .CEP (to a non-ptfs-europe example)... Which I did and I've forward that onto the vendor. I also notice that it's hardcoded for GBP. So I'm wondering - are those changes that we should make to the code? - so it's not so "hard" coded. Or is that part of the scope that you are developing for and we're going to see some more patches? (Just want an idea on where I should send our development team) Anyways - code works. I can sign off on this as is. But I really want to have a discussion with some more developers, before I sign-off - since this would have to be hard coded for anyone to use it with there choice of vendor - and it doesn't take advantage of information that is readily available through koha (currency, etc. or even the EAN/SAN accounts created in the database). Hope that makes sense. -Brendan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 07:06:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 05:06:43 +0000 Subject: [Koha-bugs] [Bug 8251] Patrons are systematically debarred at checkin In-Reply-To: <bug-8251-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8251-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8251-70-Ygchrr7ZjM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8251 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #42 from Mason James <mtj at kohaaloha.com> --- (In reply to comment #40) > switch status back to requires signoff for latest patch > > Signed-off-by: Tomas Cohen Arazi <tomascohen at gmail.com> passing QA... patch looks good and applies clean 3.8.x branch - thanx for the patch Colin $ koha-qa.pl testing 1 commit(s) (applied to commit 4446e9b) * 912bfa8 Bug 8251 Do not try to debar patrons if returns are not overdue C4/Circulation.pm - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK - t/00-valid-xml.t tests... OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 07:32:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 05:32:46 +0000 Subject: [Koha-bugs] [Bug 8737] New: Incorrect icon at login in staff client Message-ID: <bug-8737-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8737 Priority: P5 - low Change sponsored?: --- Bug ID: 8737 Assignee: oleonard at myacpl.org Summary: Incorrect icon at login in staff client Severity: enhancement Classification: Unclassified OS: All Reporter: mtompset at hotmail.com Hardware: All Status: NEW Version: unspecified Component: Templates Product: Koha Problem: despite setting the syspref for IntranetFavicon and doing several refreshes, the default koha icon shows in my firefox tab. Test: 1) Go to koha staff client to log in. The default green box k logo should be in the browsers tab. 2) Log in. 3) If it is still the default: 3-1) click "Koha Administration" 3-2) click "Global system preferences" 3-3) click on the "Staff client" tab near the bottom left of the page 3-4) In the "Appearance" section, modified the "IntranetFavicon" system preference to point a different icon. 3-5) scroll down and click 'Save all staff client preferences' 3-6) log out 3-7) log in 4) It should now be a different icon. 5) log out. It should now be the default icon, not the same one as logged in. Before coming upon what I am going to attach as a solution, I was looking in Template. jcamins commented out a section of code that I was going to add to as a solution, so I figured that wouldn't be a good solution. I then checked to see if it worked for OPAC. It did, so something must have the right code for Opac, but have forgotten the Intranet. Pre-solution hunt: 1) cd kohaclone 2) grep OpacFavicon `find . -name "*.p[lm]"` 3) grep IntranetFavicon `find . -name "*.p[lm]"` 4) Note there are two entries for OpacFavicon in C4/Auth.pm, but only one IntranetFavicon entry So looking at around line 949 which is in the "AUTH rejected" section, I found both OPAC and Intranet variables were being set, but the IntranetFavicon was missing. NOTE: Someone more familiar with expected environment variables should check if anything else is missing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 08:00:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 06:00:37 +0000 Subject: [Koha-bugs] [Bug 8737] Incorrect icon at login in staff client In-Reply-To: <bug-8737-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8737-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8737-70-Irp9PqocMK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8737 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard at myacpl.org |mtompset at hotmail.com --- Comment #1 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 12032 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12032&action=edit Sets missing environment variable so correct icon is displayed. I initially did a tarball install of 3.6.3 and hacked the template files to get it right. This patch against master should be the correct solution to the problem. This problem exists in 3.6.X and I believe 3.8.X as well. I followed the simple steps given in my previous comments to confirm after applying the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 09:28:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 07:28:34 +0000 Subject: [Koha-bugs] [Bug 8002] Can't add patron attribute type in newer installation In-Reply-To: <bug-8002-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8002-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8002-70-sAE8QDK1Cb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8002 --- Comment #19 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 12033 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12033&action=edit Bug 8002: FIX Change datatype from varchar 1 to 10 for borrower_attribute_types.category_code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 09:29:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 07:29:10 +0000 Subject: [Koha-bugs] [Bug 8002] Can't add patron attribute type in newer installation In-Reply-To: <bug-8002-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8002-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8002-70-5UIp1CoXQo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8002 --- Comment #20 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 12034 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12034&action=edit [3.8.X] Bug 8002: FIX Change datatype from varchar 1 to 10 for borrower_attribute_types.category_code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 09:36:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 07:36:19 +0000 Subject: [Koha-bugs] [Bug 8002] Can't add patron attribute type in newer installation In-Reply-To: <bug-8002-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8002-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8002-70-Y4LWPCsuWI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8002 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #21 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to comment #18) > > Yes I have just seen that ! But why mysql breaks a constraint ?? > > When category_code is truncated to 1 character, it is no more possible > to link borrower attribute types to borrower categories which are still > 10 characters length. And if 2 attributes have been linked to 2 > distinct borrower categories like ENFANT and ETUDIANT, category_code > will contain E after ALTER TABLE for both attributes, and the link won't > work anymore. Hi Fr?d?ric, Yes, I has understand. I would said it is strange that MySQL does not keep integrity and raise an error when we want to reduce data. Besides But it is normal MySQL does what we ask him :) I proposed 2 patchs (same as previous). 1 for master, 1 for 3.8.x A warning message is displayed on the updatedatabase page. I hope it is what you wanted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 09:42:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 07:42:44 +0000 Subject: [Koha-bugs] [Bug 8002] Can't add patron attribute type in newer installation In-Reply-To: <bug-8002-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8002-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8002-70-GC03DV5YFN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8002 --- Comment #22 from Paul Poulain <paul.poulain at biblibre.com> --- (In reply to comment #21) > But it is normal MySQL does what we ask him :) Definetly it's not normal, and it's a bug ! When you don't have a constraint and try to add one, if there are data that would not respect the constraint, you get a message, and the constraint is not set. Seel update22to30.pl to see how I handled this case in the past = I throw a clear warning, with the query to run to see which data was wrong, so the library could fix it and put the constraint. I'm expecting from ALTER TABLE that an existing constraint is checked before the table is altered ! Also note that, iirc, you can't put a constraint on 2 columns with different type/size. That could be easily checked by mysql when you ALTER TABLE ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 10:01:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 08:01:24 +0000 Subject: [Koha-bugs] [Bug 7673] New patron permissions In-Reply-To: <bug-7673-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7673-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7673-70-s8Y3vDLi8b@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 delaye <stephane.delaye at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 10:09:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 08:09:34 +0000 Subject: [Koha-bugs] [Bug 8034] Enable server print queue selection In-Reply-To: <bug-8034-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8034-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8034-70-Qo2GYv0XLR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8034 --- Comment #15 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to comment #14) > I could not see that. Can you please point me to the place where that was > introduced earlier. Last time I tested I had the syspref in my database, but now I don't find any occurrence on master. So maybe I already tested this patch :) > I'm not sure what you mean by that. There's "Network Printers" link in > "Additional parameters" In admin module (eg. admin/printers.pl) on the left-side. > That is just a warning. I can get rid of it if you wish. Edit worked nicely > for me. What exactly happened? Just a warning but see C4/Printer l.95: $sth->execute("$data[0]%"); It could caused a problem if it is uninitialized :) To reproduce: - click on the "new printer" button - fill with: "foo name", "foo queue", "foo type" - submit, ok - edit and change "foo queue" with "bar queue" In fact, the issue only exists if I change the queue value. > I think it was a design decision, and makes sense. There could be a library > without a printer. And even if there's a printer, I think it is better to > have it blank initially rather than default to the first one. But if > community has a different opinion, I can change that. Ok but if an user edit a library to change anything else, he erases the previous choice. Maybe someone else could give his/her opinion on this? > Sounds reasonable. Will do. > Will do. > Makes sense, will do that one too. Thanks for your work! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 10:59:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 08:59:40 +0000 Subject: [Koha-bugs] [Bug 7241] circulation action logs record biblionumber instead of item number In-Reply-To: <bug-7241-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7241-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7241-70-cWhft1LNuL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7241 --- Comment #25 from Adrien SAURAT <adrien.saurat at biblibre.com> --- Ok, I made a test with this request and it modified all the timestamps of my updated rows. That's because this field is designed to store the date of each sql update: `timestamp` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP, It seems to me that, for these logs, the important date is the "library action" date and not the "last SQL modification" date. --- I suggest adding also the following line before the UPDATE: ALTER TABLE action_logs CHANGE timestamp timestamp TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP; The timestamp will still be automatically set when creating a row, but updating won't change the original date/time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 11:01:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 09:01:37 +0000 Subject: [Koha-bugs] [Bug 8381] Paging broken in OPAC search results In-Reply-To: <bug-8381-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8381-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8381-70-FSvC7SufRy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8381 claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez at biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 13:45:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 11:45:36 +0000 Subject: [Koha-bugs] [Bug 8336] SIP Server does not process renewal transaction correctly In-Reply-To: <bug-8336-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8336-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8336-70-HKP5ilwCw5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8336 Colin Campbell <colin.campbell at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10567|0 |1 is obsolete| | --- Comment #3 from Colin Campbell <colin.campbell at ptfs-europe.com> --- Created attachment 12035 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12035&action=edit Revised Patch Cleaned up the code. Handle some cases better - rebased against current master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 13:50:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 11:50:57 +0000 Subject: [Koha-bugs] [Bug 8336] SIP Server does not process renewal transaction correctly In-Reply-To: <bug-8336-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8336-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8336-70-CbCYsCGKlC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8336 Colin Campbell <colin.campbell at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high Severity|enhancement |major --- Comment #4 from Colin Campbell <colin.campbell at ptfs-europe.com> --- Changed status to bug as without this patch the SIPServer crashes when faced with a RenewAll transaction. Also the current sip server reports to the client that it supports Renew and Renewall transactions but it does not and in ways that cause the client and/or server to fail. Tested by Staffordshire University with Talking Tech telephone renewals -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 14:16:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 12:16:32 +0000 Subject: [Koha-bugs] [Bug 7684] inventory : datatable fix actions etc. In-Reply-To: <bug-7684-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7684-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7684-70-6mu826Fl4J@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 delaye <stephane.delaye at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 14:19:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 12:19:19 +0000 Subject: [Koha-bugs] [Bug 6835] Ability to specify types of email address in overdue_notices.pl In-Reply-To: <bug-6835-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6835-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6835-70-5RFrL7zdga@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10069|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 12036 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12036&action=edit Bug 6835 - Ability to specify types of email address in overdue_notices.pl Adds the -email option to overdue_notices.pl, which is repeatable -email value can be: - 'email' - 'emailpro' or - 'B_email' - perltidy done - in production for a BibLibre customer - validated by the customer Signed-off-by: Claire Hernandez <claire.hernandez at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 14:19:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 12:19:37 +0000 Subject: [Koha-bugs] [Bug 6835] Ability to specify types of email address in overdue_notices.pl In-Reply-To: <bug-6835-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6835-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6835-70-uLBfezb9tc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #24 from Jonathan Druart <jonathan.druart at biblibre.com> --- Last patch is just a rebased patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 14:22:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 12:22:58 +0000 Subject: [Koha-bugs] [Bug 7993] saved report with hierarchies In-Reply-To: <bug-7993-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7993-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7993-70-C2C0hp1ged@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7993 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #16 from Jonathan Druart <jonathan.druart at biblibre.com> --- Patch does not apply CONFLICT (content): Merge conflict in reports/guided_reports.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 14:27:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 12:27:04 +0000 Subject: [Koha-bugs] [Bug 7583] undo receive In-Reply-To: <bug-7583-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7583-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7583-70-AVYWPQZrj3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7583 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11547|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 12037 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12037&action=edit Bug 7583: Cancel a receipt In acqui/parcel.pl, there is now the possibility to cancel a receipt. In "Already received" table, just click on "Cancel receipt" and the order line will go back to pending orders. If it was a partial receipt, order line is merged to its 'parent' line. Attached items are modified so that they become attached to the merged order line. If AcqCreateItem is 'receiving', attached items are deleted. If an order line was first partially received, and then completed. You must cancel the 'parent' order line before cancelling the 'child'. Signed-off-by: Marc Veron <veron at veron.ch> The patch behaves like expected, and the feature is really helpfull. Just a tiny remark about the following message: ------------- Cannot cancel receipt. Possible reasons : You are trying to cancel the receipt of an order line whose parent order line is already received. Cancel this parent order line and retry. ------------- Maybe it would be good - to explain a little bit more why it happend and re-word the message for non technical people (not everybody understands 'parent' the same way) - prevent the situation to happen (e.g. forbid order lines to be deleted if they are already received) - but that would be in the scope of an other bug, I think. I think such things could be fixed in the future during the ongoing work for Acquisitions module. Signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 14:27:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 12:27:11 +0000 Subject: [Koha-bugs] [Bug 7583] undo receive In-Reply-To: <bug-7583-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7583-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7583-70-maNneeFesX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7583 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11590|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 12038 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12038&action=edit Bug 7583 follow-up: Prevent users to cancel receipt if they can't Disable the link for cancelling instead of displaying an error message after the click. This is only valid if parent order line is received, not if it's deleted. When the user gets his mouse over the disabled link, he gets a message telling him which order (ordernumber) blocks him so he knows immediately which receipt to cancel. Also improve error messages for non technical people Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 14:27:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 12:27:34 +0000 Subject: [Koha-bugs] [Bug 7583] undo receive In-Reply-To: <bug-7583-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7583-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7583-70-Vxkw3m03vi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7583 --- Comment #12 from Jonathan Druart <jonathan.druart at biblibre.com> --- Rebased patches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 14:27:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 12:27:59 +0000 Subject: [Koha-bugs] [Bug 7583] undo receive In-Reply-To: <bug-7583-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7583-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7583-70-AbLP9OW4ez@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7583 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha.sekjal at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 14:28:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 12:28:40 +0000 Subject: [Koha-bugs] [Bug 8730] browse overlaying powered by In-Reply-To: <bug-8730-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8730-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8730-70-kfIKe4i0Js@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8730 --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- The result of applying the patch should be this (starting at line 2219): a.koha_url { text-decoration:none; } /* pagination */ .pagination { position: absolute; top:32px; left: -1px; width: 100%; height:auto; border: 1px solid #D0D0D0; display: none; background-color:#F3F3F3; padding-bottom:10px; + z-index: 100; } Are you sure you're applying the patch on master? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 14:35:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 12:35:43 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-5B31ImC1W2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11980|0 |1 is obsolete| | --- Comment #36 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12039 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12039&action=edit Bug 8215 - Course Reserves Adds a course reserves system for academic libraries. The course reserves system allows libraries to create courses and put items on reserves for those courses. Each item with at least one reserve can have some of its attributes modified while it is on reserve for at least one active course. These attributes include item type, collection code, shelving location, and holding library. If there are no active courses with this item on reserve, it's attributes will revert to the original attributes it had before going on reserve. Testing Scenario: 1) Create new authorised value categories DEPARTMENT and TERM 2) Create a new course, add instructors to that course. 3) Reserve items for that course, verify item attributes have changed. 4) Disable course, verify item attributes have reverted. 5) Enable course again, verify item attributes again. 6) Delete course, verify item attributes again. 7) Create two new courses, add the same item(s) to both courses. 8) Disable one course, verify item attributes have not reverted. 9) Disable both courses, verify item attributes have reverted. 10) Enable one course, verify item attributes are again set to the new values. 11) Edit reserve item attributes, verify. 12) Disable all courses, edit reserve item attributes, verify the item itself still has its original attributes, verify the reserve item attributes have been updated. 13) Verify the ability to remove instructors from a course. 14) Verify new permissions, top level coursereserves, with subpermissions add_reserves and delete_reserves. Bug 8215 - Add Course Reserves - Followup - Fix DB Updater & Makefile Bug 8215 - Add Course Reserves - Followup - Hide disabled course reserves on catalog details page. Bug 8215 - Add Course Reserves - Followup - One Hit Searching Bugfix When searching courses, a search that results in a single hit will automatically forward to the details for that course. If only a single course has been added to the system, Koha will always forward to that course and there will be no way to get to course-reserves.pl to add a second course! Fixed by testing for an actual search, rather than looking only at the number of hits returned. Bug 8215 - Add Course Reserves - Followup - Prevent submitting form on 'enter' When using the instructor search, hitting enter will attempt to submit the form. This is unwanted behavior. Fixed by adding some jquery, such that any form field with the class "noEnterSubmit" will but trigger a form submission. This class can be used on any form in the librarian interface to prevent a field from triggering a form submission via the enter key. Bug 8215 - Course Reserves - Followup - Remove checkEnter() and reimplement with noEnterSubmit class Bug 8215 - Course Reserves - Followup - Fix permissions typos -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 14:35:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 12:35:56 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-7ULqU4djjR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 14:41:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 12:41:04 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-oPCiZsqs6C@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #37 from Kyle M Hall <kyle at bywatersolutions.com> --- > Permissions related: > - if one wanted to delegate ADD/DEL reserves permissions without also the > manage(ADE/EDIT?DEL) courses permission, that can't be done. Without manage > courses, course_reserves is not an accessible page, so one can't get to the > links to add/del reserves. This should be fixed in this new patch. > - Also, while i had permissions to delete reserves, I copied the url of the > remove link to the clipboard. then i removed the staff permssion allowing > delete reserves. i logged in as staff and saw only the edit link (no > remove), BUT I pasted the remove action url from my clipboard and the delete > worked. So a check needs to be in the script/controller/security layer to > see what is an accepted action. The same probably goes for courses. Also fixed in the new patch. > - Maybe the TERM and DEPARTMENT could be added to the optional data that > folks choose to load. The future testers would be helped. We could definitely do this, but the values for TERM and DEPARTMENT are so library-specific that any data we add would certainly not be usable out of the box. I think it is just as good if not better to just document them as part of the setup process in the manual. > - I don't know the repercussion of having no library set. (NULL in columns?), > You might want a check and popup to prevent adding rows unless a library is > set. There are no repercussions for not having a library set. None of the code for this feature uses the logged in user's set branch for anything, so no worries there! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 14:43:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 12:43:19 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: <bug-5327-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5327-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5327-70-XCVKCDgyEK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11470|0 |1 is obsolete| | --- Comment #233 from Paul Poulain <paul.poulain at biblibre.com> --- Comment on attachment 11470 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11470 [PASSED-QA] Bug 5327 follow-up: add DBD::Mock dependency This patch has been pushed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 14:43:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 12:43:34 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: <bug-5327-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5327-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5327-70-kcwJ57mHxN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11500|0 |1 is obsolete| | --- Comment #234 from Paul Poulain <paul.poulain at biblibre.com> --- Comment on attachment 11500 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11500 [PASSED-QA]Bug 5327 : Added a few more lines of code to the ItemType.t unit test This patch has been pushed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 14:43:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 12:43:49 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: <bug-5327-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5327-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5327-70-LZvvAbVj52@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11503|0 |1 is obsolete| | --- Comment #235 from Paul Poulain <paul.poulain at biblibre.com> --- Comment on attachment 11503 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11503 [PASSED-QA]Bug 5327 Tests for C4::Matcher This patch has been pushed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 14:44:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 12:44:04 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: <bug-5327-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5327-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5327-70-VMMLPneTiC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11505|0 |1 is obsolete| | --- Comment #236 from Paul Poulain <paul.poulain at biblibre.com> --- Comment on attachment 11505 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11505 [PASSED-QA]Added and tested a mock-db tested a couple of features This patch has been pushed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 14:44:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 12:44:19 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: <bug-5327-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5327-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5327-70-0ktRJZwbkb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11506|0 |1 is obsolete| | --- Comment #237 from Paul Poulain <paul.poulain at biblibre.com> --- Comment on attachment 11506 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11506 [PASSED-QA]Added a mock-db table and tested a line This patch has been pushed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 14:44:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 12:44:34 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: <bug-5327-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5327-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5327-70-KvddVamGje@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11763|0 |1 is obsolete| | --- Comment #238 from Paul Poulain <paul.poulain at biblibre.com> --- Comment on attachment 11763 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11763 [PASSED-QA] Added tests to installer_perlmodules This patch has been pushed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 14:44:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 12:44:48 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: <bug-5327-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5327-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5327-70-UIB23vRLxe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11993|0 |1 is obsolete| | --- Comment #239 from Paul Poulain <paul.poulain at biblibre.com> --- Comment on attachment 11993 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11993 [PASSED-QA] Bug 5327 : Fixing a typo in the test that was causing a false fail This patch has been pushed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 14:45:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 12:45:02 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: <bug-5327-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5327-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5327-70-RNhakch48Q@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12002|0 |1 is obsolete| | --- Comment #240 from Paul Poulain <paul.poulain at biblibre.com> --- Comment on attachment 12002 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12002 [PASSED-QA]Bug 5327: Unit tests for C4 socialdata This patch has been pushed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 14:45:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 12:45:17 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: <bug-5327-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5327-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5327-70-R89YEvxs0u@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12003|0 |1 is obsolete| | --- Comment #241 from Paul Poulain <paul.poulain at biblibre.com> --- Comment on attachment 12003 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12003 [PASSED-QA]Bug 5327: Testing c4 Images This patch has been pushed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 14:45:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 12:45:36 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: <bug-5327-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5327-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5327-70-5XrEzdDbt8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 15:13:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 13:13:57 +0000 Subject: [Koha-bugs] [Bug 7678] Statistics wizard: patrons In-Reply-To: <bug-7678-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7678-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7678-70-N838cYljvA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7678 claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #7 from claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> --- I change the patch status for review. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 15:20:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 13:20:05 +0000 Subject: [Koha-bugs] [Bug 8644] jQueryUI CSS file should not contain customizations In-Reply-To: <bug-8644-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8644-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8644-70-bJQNVdJxv8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8644 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11986|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12040 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12040&action=edit Bug 8644 [staff client] jQueryUI CSS file should not contain customizations This patch moves jQueryUI customizations into the main CSS file for the staff client. In order to get the corrected default version of jquery-ui.css I have upgraded all core jQueryUI files. Testers should look at examples of each of the various jQueryUI widgets we use in Koha to confirm continued functinality: tabs, autocomplete, datepickers, and slider (in specify due date popup). Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 15:20:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 13:20:17 +0000 Subject: [Koha-bugs] [Bug 8644] jQueryUI CSS file should not contain customizations In-Reply-To: <bug-8644-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8644-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8644-70-y4u7OlblKU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8644 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12005|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12041 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12041&action=edit Bug 8644 [OPAC] jQueryUI CSS file should not contain customizations This patch moves jQueryUI customizations into the main CSS file for the OPAC. In order to get the corrected default version of jquery-ui.css I have upgraded all core jQueryUI files. Testers should look at examples of each of the various jQueryUI widgets we use in the OPAC to confirm continued functinality: tabs and datepickers. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 15:21:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 13:21:06 +0000 Subject: [Koha-bugs] [Bug 8644] jQueryUI CSS file should not contain customizations In-Reply-To: <bug-8644-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8644-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8644-70-CjZicRbcK5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8644 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle at bywatersolutions.com --- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> --- I checked out all the different jQuery widgets I could find. Everything looks good to me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 15:23:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 13:23:43 +0000 Subject: [Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off In-Reply-To: <bug-8462-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8462-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8462-70-qtkEul4fi0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12004|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12042 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12042&action=edit Bug 8462: OpacHiddenItems and hidelostitems hide items, but query result count is off Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 15:23:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 13:23:57 +0000 Subject: [Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off In-Reply-To: <bug-8462-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8462-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8462-70-P4a50M8QkQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 15:24:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 13:24:21 +0000 Subject: [Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open In-Reply-To: <bug-8735-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8735-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8735-70-VMGsyQCi4Y@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 15:26:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 13:26:05 +0000 Subject: [Koha-bugs] [Bug 7241] circulation action logs record biblionumber instead of item number In-Reply-To: <bug-7241-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7241-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7241-70-UrXRXUN3FX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7241 Adrien SAURAT <adrien.saurat at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11415|0 |1 is obsolete| | --- Comment #26 from Adrien SAURAT <adrien.saurat at biblibre.com> --- Created attachment 12043 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12043&action=edit proposed patch #3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 15:26:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 13:26:16 +0000 Subject: [Koha-bugs] [Bug 7241] circulation action logs record biblionumber instead of item number In-Reply-To: <bug-7241-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7241-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7241-70-sIEWfAHAvj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7241 Adrien SAURAT <adrien.saurat at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 15:27:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 13:27:48 +0000 Subject: [Koha-bugs] [Bug 8730] browse overlaying powered by In-Reply-To: <bug-8730-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8730-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8730-70-ZuVQAiHbc9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8730 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12023|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12044 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12044&action=edit Bug 8730 - browse overlaying powered by This patch adds a "z-index" property to the CSS for the browse results menu so that it will appear on top of the "Powered by Koha" link. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 15:28:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 13:28:15 +0000 Subject: [Koha-bugs] [Bug 8730] browse overlaying powered by In-Reply-To: <bug-8730-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8730-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8730-70-1STAakUFov@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8730 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 15:29:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 13:29:36 +0000 Subject: [Koha-bugs] [Bug 8206] Add additional search options to authority browser in OPAC In-Reply-To: <bug-8206-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8206-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8206-70-CNrPDe0dRZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8206 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_10 --- Comment #26 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master Agreed the new behaviour is OK. (our idea when updating opac- was to get rid of those terms that students/patrons don't understand. You reintroduce some terms, but it's *much* smoother than the initial version, and a few CSS can always hide that) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 15:30:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 13:30:10 +0000 Subject: [Koha-bugs] [Bug 8727] Correct help text in rebuild_zebra_sliced.sh In-Reply-To: <bug-8727-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8727-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8727-70-N2m00sezpT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8727 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11977|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12045 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12045&action=edit Bug 8727 Minor stylistic change to help text indexing not indexation some minor grammatical changes Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 15:31:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 13:31:00 +0000 Subject: [Koha-bugs] [Bug 3462] Link see alsos in authorities In-Reply-To: <bug-3462-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3462-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3462-70-3PmoiYPMZM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3462 --- Comment #16 from Paul Poulain <paul.poulain at biblibre.com> --- Jared, ping on my comment 15 = I need some explanations. Should I see differences in UNIMARC ? (I think yes, but can't see them) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 15:31:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 13:31:37 +0000 Subject: [Koha-bugs] [Bug 8727] Correct help text in rebuild_zebra_sliced.sh In-Reply-To: <bug-8727-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8727-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8727-70-pCojGV0uyW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8727 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle at bywatersolutions.com --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> --- Looks good to me, definitely an improvement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 15:31:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 13:31:46 +0000 Subject: [Koha-bugs] [Bug 8028] Make table collapsing on parcel.pl sticky In-Reply-To: <bug-8028-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8028-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8028-70-gyeeYY86m7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8028 --- Comment #13 from Paul Poulain <paul.poulain at biblibre.com> --- Kyle, ping on my comment 12. I need to test that before pushing ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 15:33:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 13:33:15 +0000 Subject: [Koha-bugs] [Bug 8737] Incorrect icon at login in staff client In-Reply-To: <bug-8737-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8737-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8737-70-wdMbqC7Ncs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8737 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12032|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12046 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12046&action=edit Bug 8737 - Incorrect icon at login in staff client Added the following missing code to ensure the correct icon is used when logged out: IntranetFavicon => C4::Context->preference('IntranetFavicon') This was added into an existing $template->param() call. Not to be confused with the koha logo on the login page, the icon is a 16x16 pixel graphic in the browser tab. The default is found at .../intranet-tmpl/prog/en/includes/favicon.ico. If the "IntranetFavicon" system preference is set, it should be used by the staff client regardless of login state. It was not being used in the "AUTH rejected" section of Auth.pm, but the OpacFavicon variable was being set. This explains why the "OpacFavicon" system preference works for the OPAC client, but not the staff client upon logout. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 15:33:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 13:33:24 +0000 Subject: [Koha-bugs] [Bug 8737] Incorrect icon at login in staff client In-Reply-To: <bug-8737-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8737-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8737-70-U9vc4OZxMI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8737 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 15:36:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 13:36:19 +0000 Subject: [Koha-bugs] [Bug 8017] Remove unnecessary processing on return of GetAllIssues In-Reply-To: <bug-8017-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8017-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8017-70-GCbuRWcO5i@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8017 --- Comment #10 from Paul Poulain <paul.poulain at biblibre.com> --- Colin = pinging my comment 8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 15:36:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 13:36:32 +0000 Subject: [Koha-bugs] [Bug 8732] Add a systempreference to allow users to choose to display an icon based on the marc control fields, or based on the koha biblio level itemtype In-Reply-To: <bug-8732-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8732-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8732-70-nsCeUa30cq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12029|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12047 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12047&action=edit Bug 8732 : Allowing biblio level itemtypes to display instead of MARC ones If you switch OpacResultsItemtypeImage to Koha, you will see the Koha itemtypes, if it is Control you will get the ones generated from the MARC control fields. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 15:36:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 13:36:52 +0000 Subject: [Koha-bugs] [Bug 8732] Add a systempreference to allow users to choose to display an icon based on the marc control fields, or based on the koha biblio level itemtype In-Reply-To: <bug-8732-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8732-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8732-70-bwcVHRhfyS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle at bywatersolutions.com --- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> --- Followed the test plan. Everything works as advertised. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 15:39:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 13:39:47 +0000 Subject: [Koha-bugs] [Bug 8730] browse overlaying powered by In-Reply-To: <bug-8730-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8730-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8730-70-AvZ6jhxipx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8730 --- Comment #5 from Marc V?ron <veron at veron.ch> --- Owen, Sorry for the confusion. Maybe it was a cache problem. Just tested again and it worked fine. While I was testing Kyle signed off :-) Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 15:44:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 13:44:11 +0000 Subject: [Koha-bugs] [Bug 8724] Upgrade from NoZebra installs is broken In-Reply-To: <bug-8724-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8724-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8724-70-M7esJNB8jI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8724 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11969|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12048 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12048&action=edit Bug 8724 - Upgrade from NoZebra installs is broken Properly set the relevant NoZebra and QueryRemoveStopwords sysprefs to 0 to fix issues on upgrades. Also removes the sysprefs from preferences/searching.pref Regards To+ Sponsored-by: Universidad Nacional de C?rdoba Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 16:13:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 14:13:37 +0000 Subject: [Koha-bugs] [Bug 8738] New: DateTime object being compared to a date string in circulation Message-ID: <bug-8738-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8738 Priority: P5 - low Change sponsored?: Sponsored Bug ID: 8738 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: DateTime object being compared to a date string in circulation Severity: enhancement Classification: Unclassified OS: All Reporter: mjr at software.coop URL: http://intranet/cgi-bin/koha/circ/circulation.pl Hardware: All Status: NEW Version: rel_3_8 Component: Circulation Product: Koha A DateTime object can only be compared to another DateTime object (DateTime=HASH(0x54110d8), 0). at /home/coop/koha/unstable/src/circ/circulation.pl line 346 at /usr/lib/perl5/DateTime.pm line 1801 DateTime::_compare('DateTime=HASH(0x54110d8)', 0, 0) called at /usr/lib/perl5/DateTime.pm line 1780 DateTime::compare('DateTime=HASH(0x54110d8)', 0) called at /usr/lib/perl5/DateTime.pm line 1762 DateTime::_compare_overload('DateTime=HASH(0x54110d8)', 0, '') called at /home/coop/koha/unstable/src/circ/circulation.pl line 346 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 16:14:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 14:14:16 +0000 Subject: [Koha-bugs] [Bug 8738] DateTime object being compared to a date string in circulation In-Reply-To: <bug-8738-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8738-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8738-70-eAgau19YsZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8738 MJ Ray (software.coop) <mjr at software.coop> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Severity|enhancement |major --- Comment #1 from MJ Ray (software.coop) <mjr at software.coop> --- This is happening when I try to circulate a book. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 16:18:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 14:18:47 +0000 Subject: [Koha-bugs] [Bug 8738] DateTime object being compared to a date string in circulation In-Reply-To: <bug-8738-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8738-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8738-70-irEwoENRqO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8738 --- Comment #2 from MJ Ray (software.coop) <mjr at software.coop> --- Created attachment 12049 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12049&action=edit circ/circulation.pl: force issuedate to a string to fix bug 8738 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 16:21:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 14:21:24 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: <bug-7417-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7417-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7417-70-1RCZTfnvpW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 --- Comment #43 from Paul Poulain <paul.poulain at biblibre.com> --- UNIMARC QA comment: If I'm not mistaking, http://archive.ifla.org/VI/3/p1996-1/uniafull.htm#4-- says that 4xx are for "see references", it's the same as in marc21 (http://www.loc.gov/marc/authority/ad4xx.html) The 2nd digit is not always the same: UNIMARC = 420 See Reference Tracing - Family Name MARC21 = 420 does not exits The code says # for each field + foreach my $field ( $record->fields() ) { # if there is a link to authorities + my $authid = $field->subfield('9'); # retrieve the authority + my $authority = Koha::Authority->get_from_authid($authid); # if there are seefrom fields + my @seefrom = $auth_marc->field('4..'); # add them in the biblio record # find the biblio record tag + my $tag = substr($field->tag(), 0, 1) . substr($authfield->tag(), 1, 2); # create a new one, where you'll put datas coming from authorities + my $newfield = MARC::Field->new($tag, + 'z', + $authfield->indicator(2) || ' ', + '9' => '1'); # copy each subfield + foreach my $sub ($authfield->subfields()) { + my ($code,$val) = @$sub; + $newfield->add_subfields( $code => $val ); + } What I don't understand is the '9' => '1' You're connecting all biblios to the #1 authority ? why ? Another question = why do you set 1st indicator to 'z' ? Other question = do you have checked performances ? I think that it will be a *big* overhead for rebuild_zebra.pl -b -r (ie= rebuilding all the database) time rebuild_zebra.pl will give us numbers, that we need to have, at least to warn librarians ! Last question = do you also have checked/tested solr ? I see that you write + if ($record_type eq 'biblio' && C4::Context->preference('IncludeSeeFromInSearches')) { + my $normalizer = Koha::RecordProcessor->new( { filters => 'EmbedSeeFromHeadings' } ); + $record = $normalizer->process($record); + } in Koha/SearchEngine/Solr/Index.pm (asking Claire in // to get her feedback on this) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 16:24:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 14:24:48 +0000 Subject: [Koha-bugs] [Bug 8017] Remove unnecessary processing on return of GetAllIssues In-Reply-To: <bug-8017-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8017-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8017-70-YNBNIT7wkY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8017 --- Comment #11 from Colin Campbell <colin.campbell at ptfs-europe.com> --- Paul, Id be happy to see this pushed as is. I think I'll look at what can be done to improve the query as a separate piece of work -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 16:26:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 14:26:04 +0000 Subject: [Koha-bugs] [Bug 3462] Link see alsos in authorities In-Reply-To: <bug-3462-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3462-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3462-70-q6NUfzaeLb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3462 --- Comment #17 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Paul, (In reply to comment #16) > Jared, ping on my comment 15 = I need some explanations. Should I see > differences in UNIMARC ? (I think yes, but can't see them) I just spent a while trying to figure out why this wasn't working in UNIMARC before I realized that in a properly-configured UNIMARC system, it shouldn't. UNIMARC uses a user-specified summary format in auth_types.summary. MARC21 does not have that. This patch keeps the existing behavior, since presumably it matches what you would want. A follow-up patch could remove the auth_types.summary bit, if you wanted. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 16:31:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 14:31:08 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: <bug-7417-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7417-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7417-70-rLy5RmmgZA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 --- Comment #44 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- (In reply to comment #43) > UNIMARC QA comment: > If I'm not mistaking, http://archive.ifla.org/VI/3/p1996-1/uniafull.htm#4-- > says that 4xx are for "see references", it's the same as in marc21 > (http://www.loc.gov/marc/authority/ad4xx.html) > > The 2nd digit is not always the same: > UNIMARC = 420 See Reference Tracing - Family Name > MARC21 = 420 does not exits As I understand it (I asked Francois a while ago), ALL 4xx fields work like this, so it doesn't matter what the second digit is. > The code says > # for each field > + foreach my $field ( $record->fields() ) { > > # if there is a link to authorities > + my $authid = $field->subfield('9'); > > # retrieve the authority > + my $authority = Koha::Authority->get_from_authid($authid); > > # if there are seefrom fields > + my @seefrom = $auth_marc->field('4..'); > > # add them in the biblio record > > # find the biblio record tag > + my $tag = substr($field->tag(), 0, 1) . > substr($authfield->tag(), 1, 2); > # create a new one, where you'll put datas coming from authorities > + my $newfield = MARC::Field->new($tag, > + 'z', > + $authfield->indicator(2) || ' ', > + '9' => '1'); > # copy each subfield > + foreach my $sub ($authfield->subfields()) { > + my ($code,$val) = @$sub; > + $newfield->add_subfields( $code => $val ); > + } > > > What I don't understand is the '9' => '1' > You're connecting all biblios to the #1 authority ? why ? This is a workaround for a peculiarity in MARC::Record. If you look a bit further down, you'll see I delete the subfield $9, once I've populated the other subfields. > > Another question = why do you set 1st indicator to 'z' ? I needed some way to CLEARLY identify the field as not being a real part of the record. Since ind1=z is not valid in MARC, that seemed like a good way. > > Other question = do you have checked performances ? I think that it will be > a *big* overhead for rebuild_zebra.pl -b -r (ie= rebuilding all the database) > time rebuild_zebra.pl will give us numbers, that we need to have, at least > to warn librarians ! I have. That's a good point. The syspref should note it takes twice as long to rebuild Zebra with this enabled. > Last question = do you also have checked/tested solr ? I see that you write > + if ($record_type eq 'biblio' && > C4::Context->preference('IncludeSeeFromInSearches')) { > + my $normalizer = Koha::RecordProcessor->new( { filters => > 'EmbedSeeFromHeadings' } ); > + $record = $normalizer->process($record); > + } > in Koha/SearchEngine/Solr/Index.pm (asking Claire in // to get her feedback > on this) I have not been able to test it. The Solr dependencies do not compile on Debian (nor, I think, would Solr run on my little laptop). I thought about not including the Solr bit, since Solr is still experimental, but decided I would provide it so that the RM could make that decision. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 16:39:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 14:39:41 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: <bug-7417-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7417-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7417-70-QnGaDp1DfG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 --- Comment #45 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Note that performance could be greatly improved by using Koha::Cache with an in-memory cache. This depends on the new CHI caching. I did not implement it yet because I prefer a more gradual approach to larger developments. It reduces the likelihood of bugs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 17:04:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 15:04:11 +0000 Subject: [Koha-bugs] [Bug 8447] can't save new records / indicator error In-Reply-To: <bug-8447-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8447-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8447-70-TnJNSxEQbk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8447 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 17:04:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 15:04:13 +0000 Subject: [Koha-bugs] [Bug 8447] can't save new records / indicator error In-Reply-To: <bug-8447-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8447-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8447-70-lCKpYrLsJF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8447 --- Comment #13 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12050 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12050&action=edit Bug 8447: Make sure we have enough subfields for broader_headings Thanks to wajasu for providing the debugging information, as I cannot seem to duplicate the problem, even seeing where it could come from. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 17:05:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 15:05:26 +0000 Subject: [Koha-bugs] [Bug 7671] add a real primary key "accountlinesid" in accountlines In-Reply-To: <bug-7671-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7671-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7671-70-px1eItEqlM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7671 --- Comment #24 from stephane.delaune at biblibre.com --- Created attachment 12051 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12051&action=edit followup followup : delete return of makepayment because unused, fix updatedatabase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 17:05:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 15:05:42 +0000 Subject: [Koha-bugs] [Bug 7671] add a real primary key "accountlinesid" in accountlines In-Reply-To: <bug-7671-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7671-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7671-70-48kuZELkqP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7671 stephane.delaune at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 17:07:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 15:07:36 +0000 Subject: [Koha-bugs] [Bug 8738] DateTime object being compared to a date string in circulation In-Reply-To: <bug-8738-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8738-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8738-70-tLquyHRnoE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8738 MJ Ray (software.coop) <mjr at software.coop> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #3 from MJ Ray (software.coop) <mjr at software.coop> --- Tested as working on local development installation. I can now circulate books again. I apologise for the incorrect line number in the earlier backtrace. It seems I had some development code (analytic item types, bug 7716) in the tree at the time. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 17:15:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 15:15:52 +0000 Subject: [Koha-bugs] [Bug 8724] Upgrade from NoZebra installs is broken In-Reply-To: <bug-8724-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8724-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8724-70-ghfYdYQR2C@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8724 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 17:22:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 15:22:26 +0000 Subject: [Koha-bugs] [Bug 8585] Add System Preference to specify Holds to Pull List Start Date In-Reply-To: <bug-8585-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8585-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8585-70-s7CBAcntST@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8585 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11516|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12052 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12052&action=edit Bug 8585 : Add System Preference to specify Holds to Pull List Start Date Currently, Koha creates a default value of 2 days ago (-2) for the start date of the Holds to pull List. This system preference allows users to specify their own default start date for this list, since users might not want to have to manually change the date all the time when they already know the set date period they want to view. The system preference value is specified as a positive integer, which is then passed as a negative integer in the handler script. This saves users from having to include a qualifer to the sys pref value. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 17:24:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 15:24:06 +0000 Subject: [Koha-bugs] [Bug 8585] Add System Preference to specify Holds to Pull List Start Date In-Reply-To: <bug-8585-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8585-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8585-70-zPXSm7wuOG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8585 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> --- Works as advertised. I also am for the system preference. A cookie means the librarian will have to set it every session. We could possibly have the combination of both, but I think the syspref alone is better than a cookie alone. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 17:24:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 15:24:25 +0000 Subject: [Koha-bugs] [Bug 8585] Add System Preference to specify Holds to Pull List Start Date In-Reply-To: <bug-8585-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8585-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8585-70-DkdKN49qEB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8585 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 17:24:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 15:24:49 +0000 Subject: [Koha-bugs] [Bug 8484] Add ability to choose if lost items are removed from a borrowers record. In-Reply-To: <bug-8484-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8484-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8484-70-HJjoJ2yYyM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8484 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 17:25:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 15:25:27 +0000 Subject: [Koha-bugs] [Bug 8677] table overlapping to the right on holds waiting In-Reply-To: <bug-8677-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8677-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8677-70-otq71CzcUU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8677 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 12053 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12053&action=edit Bug 8677 - table overlapping to the right on holds waiting Converting layout to 100% flexible width to allow table to expand as needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 17:25:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 15:25:39 +0000 Subject: [Koha-bugs] [Bug 8677] table overlapping to the right on holds waiting In-Reply-To: <bug-8677-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8677-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8677-70-8jVS1WY8Dn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8677 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 17:27:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 15:27:32 +0000 Subject: [Koha-bugs] [Bug 8365] Renewal duration in issuingules In-Reply-To: <bug-8365-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8365-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8365-70-564oAWw4Ct@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 12054 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12054&action=edit Bug 8365: Add a renewal duration in the issuing rules Renew an issue for a number of days (filled in the issuing rules). Test if rules work for any i[item]types and if there is no regression. - new column issuingrules.renewalperiod - remove all occurrences of an already removed syspref (globalDueDate) - remove an unused routine (Overdues::GetIssuingRules) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 17:33:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 15:33:19 +0000 Subject: [Koha-bugs] [Bug 7671] add a real primary key "accountlinesid" in accountlines In-Reply-To: <bug-7671-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7671-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7671-70-OA319SytJa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7671 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11922|0 |1 is obsolete| | --- Comment #25 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12055 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12055&action=edit Bug 7671 : add a real primary key accountlines_id in accountlines Signed-off-by: St?phane Delaune <stephane.delaune at biblibre.com> Signed-off-by: Marc Veron <veron at veron.ch> NOTE: After applying the patch I got following errors in members/pay.pl: Global symbol "$writeoff_sth" requires explicit package name Global symbol "$add_writeoff_sth" requires explicit package name Added to lines at the begin of members/pay.pl: our $writeoff_sth; our $add_writeoff_sth; Now the patch worked as expected. However I am not quite sure if signing off is OK in this situation. Marc Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 17:33:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 15:33:31 +0000 Subject: [Koha-bugs] [Bug 7671] add a real primary key "accountlinesid" in accountlines In-Reply-To: <bug-7671-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7671-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7671-70-k71uE3kRgO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7671 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12051|0 |1 is obsolete| | --- Comment #26 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12056 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12056&action=edit Bug 7671 : followup : delete return of makepayment because unused, fix updatedatabase Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 17:33:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 15:33:43 +0000 Subject: [Koha-bugs] [Bug 7671] add a real primary key "accountlinesid" in accountlines In-Reply-To: <bug-7671-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7671-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7671-70-i993DWGZlM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7671 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 17:34:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 15:34:25 +0000 Subject: [Koha-bugs] [Bug 8089] Use Koha::Cache everywhere In-Reply-To: <bug-8089-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8089-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8089-70-qfd8mweRa3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #16 from Paul Poulain <paul.poulain at biblibre.com> --- Performances tests: I tried to run the staff_benchmark on this patch, (with memcached) and so no noticeable performance improvement Bug 8089 With patch and with cache Benchmarking with 20 occurences of each operation and 30 concurrent sessions Step 1: staff client main page 5955ms 3.358 pages/sec Step 2: catalog detail page 13270ms 1.507 biblios/sec Step 3: catalogue search 23628ms 0.846 biblios/sec Step 4: patron detail page 11629ms 1.719 borrowers/sec Step 5: patron search page 20355ms 1.965 borrowers/sec Step 6a circulation (checkouts) 15775ms 1.267 checkouts/sec Step 6b circulation (checkins) 15134ms 1.321 checkins/sec all transactions at once 112801ms 1.595 operations/sec Without patch and with cache Step 1: staff client main page 5980ms 3.344 pages/sec Step 2: catalog detail page 13828ms 1.446 biblios/sec Step 3: catalogue search 21114ms 0.947 biblios/sec Step 4: patron detail page 11378ms 1.757 borrowers/sec Step 5: patron search page 20316ms 1.968 borrowers/sec Step 6a circulation (checkouts) 16162ms 1.237 checkouts/sec Step 6b circulation (checkins) 16916ms 1.182 checkins/sec all transactions at once 109549ms 1.643 operations/sec With patch and without caching Step 1: staff client main page 5914ms 3.381 pages/sec Step 2: catalog detail page 13543ms 1.476 biblios/sec Step 3: catalogue search 20992ms 0.952 biblios/sec Step 4: patron detail page 11993ms 1.667 borrowers/sec Step 5: patron search page 20293ms 1.971 borrowers/sec Step 6a circulation (checkouts) 15181ms 1.317 checkouts/sec Step 6b circulation (checkins) 16692ms 1.198 checkins/sec all transactions at once 109429ms 1.644 operations/sec checked with perl -MCache::Memcached -MData::Dumper=Dumper -le 'print Dumper(Cache::Memcached->new(servers => ["localhost:11211"])->stats);' that memcache was running & accessed: 'get_hits' => '1284', 'cmd_get' => '1302', Could not find any problem, so ... patch pushed (but I still think we [c|sh]ould store all sysprefs in a single cache entry) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 17:42:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 15:42:42 +0000 Subject: [Koha-bugs] [Bug 8676] show vendor name in source of acquisition In-Reply-To: <bug-8676-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8676-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8676-70-cWHom37mJF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8676 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Nicole can you please add a screenshot? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 17:43:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 15:43:41 +0000 Subject: [Koha-bugs] [Bug 8739] New: Partial Fine Payments Saving Amount Paid Incorrectly Message-ID: <bug-8739-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8739 Priority: P5 - low Change sponsored?: --- Bug ID: 8739 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: Partial Fine Payments Saving Amount Paid Incorrectly Severity: enhancement Classification: Unclassified OS: All Reporter: kyle at bywatersolutions.com Hardware: All Status: NEW Version: master Component: Circulation Product: Koha When making payments, the amount paid is meant to be stored as a negative number. C4::Accounts::makepayment does this correctly. However C4::Accounts::makepartialpayment saves the amount as a positive number. This means the payment shows up as a fine with no balance outstanding on the borrowers record. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 17:43:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 15:43:52 +0000 Subject: [Koha-bugs] [Bug 8739] Partial Fine Payments Saving Amount Paid Incorrectly In-Reply-To: <bug-8739-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8739-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8739-70-K8cnq1aovO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8739 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 17:44:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 15:44:17 +0000 Subject: [Koha-bugs] [Bug 8395] order receive not sorting right In-Reply-To: <bug-8395-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8395-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8395-70-wdT5a4pGkt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8395 Colin Campbell <colin.campbell at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell at ptfs-europe. | |com --- Comment #8 from Colin Campbell <colin.campbell at ptfs-europe.com> --- I dont think this fixes the problem. At a typical academic/public site receipting against a major supplier some 500+ orders may appear. But the sorting by summary only affects the page of results displayed move forward and sort order reverts to basket order. As there may be multiple orders for one title locating all of them is difficult. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 17:44:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 15:44:46 +0000 Subject: [Koha-bugs] [Bug 8739] Partial Fine Payments Saving Amount Paid Incorrectly In-Reply-To: <bug-8739-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8739-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8739-70-3SQstEZqby@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8739 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12057 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12057&action=edit Bug 8739 - Partial Fine Payments Saving Amount Paid Incorrectly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 17:45:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 15:45:09 +0000 Subject: [Koha-bugs] [Bug 8739] Partial Fine Payments Saving Amount Paid Incorrectly In-Reply-To: <bug-8739-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8739-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8739-70-SYBHTcgJ34@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8739 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Component|Circulation |Patrons -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 17:45:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 15:45:16 +0000 Subject: [Koha-bugs] [Bug 8739] Partial Fine Payments Saving Amount Paid Incorrectly In-Reply-To: <bug-8739-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8739-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8739-70-bGRcM1lzYV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8739 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 18:13:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 16:13:06 +0000 Subject: [Koha-bugs] [Bug 8598] No patron image or home library on Files & Statistics tabs In-Reply-To: <bug-8598-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8598-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8598-70-aVnle3HxMt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8598 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|borrower image and home |No patron image or home |library disappear on Files |library on Files & |& Statistics tabs |Statistics tabs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 18:13:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 16:13:14 +0000 Subject: [Koha-bugs] [Bug 8598] No patron image or home library on Files & Statistics tabs In-Reply-To: <bug-8598-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8598-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8598-70-Y4dvuDy61k@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8598 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 18:15:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 16:15:37 +0000 Subject: [Koha-bugs] [Bug 8598] No patron image or home library on Files & Statistics tabs In-Reply-To: <bug-8598-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8598-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8598-70-48og5ZqAUJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8598 --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 12058 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12058&action=edit Bug 8598 - No patron image or home library on Files & Statistics tabs Adding the necessary code for patron image, patron home library, patron category description, and patron extended attributes to show in the left-hand sidebar. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 18:16:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 16:16:18 +0000 Subject: [Koha-bugs] [Bug 8598] No patron image or home library on Files & Statistics tabs In-Reply-To: <bug-8598-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8598-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8598-70-FgsaHuSUAa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8598 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 18:17:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 16:17:44 +0000 Subject: [Koha-bugs] [Bug 8028] Make table collapsing on parcel.pl sticky In-Reply-To: <bug-8028-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8028-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8028-70-PJ582bNDzw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8028 --- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12059 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12059&action=edit Bug 8028 - Followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 18:18:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 16:18:27 +0000 Subject: [Koha-bugs] [Bug 8028] Make table collapsing on parcel.pl sticky In-Reply-To: <bug-8028-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8028-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8028-70-A347kCFYQB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8028 --- Comment #15 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to comment #12) > mmm... I made a basket with 6 lines, and had another one with 2 lines > pending. When I reach the parcel.pl page, I see the 8 pending lines > directly, and no link to collapse/expand. > Am I missing something ? > > (I recieved 4 of them, and saw no change) Good catch. I've attach a small followup to fix the issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 18:22:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 16:22:16 +0000 Subject: [Koha-bugs] [Bug 8089] Use Koha::Cache everywhere In-Reply-To: <bug-8089-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8089-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8089-70-1Zr1Yft7if@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089 --- Comment #17 from Paul Poulain <paul.poulain at biblibre.com> --- OK, I had some errors in my setup, so caching was not running in fact. I've fixed and made my perf tests again: Step 1: staff client main page 8722ms 2.293 pages/sec Step 2: catalog detail page 13303ms 1.503 biblios/sec Step 3: catalogue search 19606ms 1.02 biblios/sec Step 4: patron detail page 11635ms 1.718 borrowers/sec Step 5: patron search page 18413ms 2.172 borrowers/sec Step 6a circulation (checkouts) 17861ms 1.119 checkouts/sec Step 6b circulation (checkins) 15223ms 1.313 checkins/sec => no noticeable improvements again. Jared pointed that it could be because CHI uses Moose if it's available, it is on my setup. And Moose is heavy to load :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 18:23:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 16:23:40 +0000 Subject: [Koha-bugs] [Bug 7068] autobarcode not working when duplicating patrons In-Reply-To: <bug-7068-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7068-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7068-70-Qep0KK1dAt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7068 MJ Ray (software.coop) <mjr at software.coop> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mjr at software.coop Assignee|kyle.m.hall at gmail.com |mjr at software.coop --- Comment #1 from MJ Ray (software.coop) <mjr at software.coop> --- I confirm this bug. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 18:25:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 16:25:03 +0000 Subject: [Koha-bugs] [Bug 8089] Use Koha::Cache everywhere In-Reply-To: <bug-8089-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8089-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8089-70-b65nkgzI6b@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 18:32:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 16:32:11 +0000 Subject: [Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view In-Reply-To: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8597-70-2kY1xbY1FF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #40 from Paul Poulain <paul.poulain at biblibre.com> --- I still can't apply patch #6 Bug 8597: Add system preferences to configure the mobile view. Apply? [yn] y Applying: Bug 8597: Add system preferences to configure the mobile view. fatal: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/ccsr/en/css/opac.css). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 8597: Add system preferences to configure the mobile view. When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Patch left in /tmp/Bug-8597-Add-system-preferences-to-configure-the-m-IzlCyk.patch (Also note that there is a trivial conflict on patch #1) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 18:34:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 16:34:23 +0000 Subject: [Koha-bugs] [Bug 8204] Authority viewer in OPAC ugly, unfriendly, and mostly useless In-Reply-To: <bug-8204-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8204-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8204-70-ArZqrcpBp9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8204 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #36 from Paul Poulain <paul.poulain at biblibre.com> --- Follow-up pushed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 18:35:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 16:35:58 +0000 Subject: [Koha-bugs] [Bug 8678] XSLT stylesheets output XML, but HTML is needed In-Reply-To: <bug-8678-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8678-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8678-70-IKJCa3qAvk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8678 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 --- Comment #6 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 18:40:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 16:40:44 +0000 Subject: [Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view In-Reply-To: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8597-70-oTmKfm4KMC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11853|0 |1 is obsolete| | Attachment #11854|0 |1 is obsolete| | Attachment #11855|0 |1 is obsolete| | Attachment #11856|0 |1 is obsolete| | Attachment #11857|0 |1 is obsolete| | Attachment #11974|0 |1 is obsolete| | Attachment #11975|0 |1 is obsolete| | --- Comment #41 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12060 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12060&action=edit Bug 8597: Improve template markup to prepare for mobile The templates were missing classes on a number of elements that will need classes in order for a mobile view to function. Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 18:41:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 16:41:01 +0000 Subject: [Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view In-Reply-To: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8597-70-xTDBQArwhP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597 --- Comment #42 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12061 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12061&action=edit Bug 8597: Create new CCSR theme Creates a new theme for the OPAC called "ccsr." The new theme has a much cleaner, more modern look than the prog theme, and is designed from the ground up to work on mobile devices using media queries. A later patch will include the mobile view. In order to activate the theme, change the opacthemes syspref to 'ccsr' and make sure that your opaccolorstylesheet is set to 'colors.css.' Sponsored-by: Centre coll?gial des services regroup?s (CCSR) Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com> All work was originally done by Frederick, but I converted his modifications to the prog template into a new template called ccsr. Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 18:41:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 16:41:06 +0000 Subject: [Koha-bugs] [Bug 7068] autobarcode not working when duplicating patrons In-Reply-To: <bug-7068-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7068-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7068-70-VKW9GAX5pq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7068 --- Comment #2 from MJ Ray (software.coop) <mjr at software.coop> --- Created attachment 12062 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12062&action=edit fix bug 7068 - autobarcode not working when duplicating patrons - by blanking cardnumber in the code and showing it in the template, instead of just not showing it in the template -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 18:41:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 16:41:13 +0000 Subject: [Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view In-Reply-To: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8597-70-ngWiWKQ1gY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597 --- Comment #43 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12063 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12063&action=edit Bug 8597: Add mobile functionality to ccsr theme This patch adds the promised media query-based mobile view to the ccsr theme. You can try the mobile view by resizing your browser window until it is phone-sized. Sponsored-by: Centre coll?gial des services regroup?s (CCSR) Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com> All work was originally done by Frederick, but I converted his modifications to the prog template into a new template called ccsr. Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 18:41:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 16:41:23 +0000 Subject: [Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view In-Reply-To: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8597-70-wNQXPRz8DU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597 --- Comment #44 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12064 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12064&action=edit Bug 8597: fix hardcoded references to prog in ccsr There were a few hardcoded references to the prog theme in the new ccsr theme's files. Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 18:41:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 16:41:41 +0000 Subject: [Koha-bugs] [Bug 7068] autobarcode not working when duplicating patrons In-Reply-To: <bug-7068-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7068-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7068-70-uqNMAheLEl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7068 MJ Ray (software.coop) <mjr at software.coop> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 18:41:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 16:41:51 +0000 Subject: [Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view In-Reply-To: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8597-70-dC73OOILas@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597 --- Comment #45 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12065 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12065&action=edit Bug 8597: Add CSS, JS, and images to ccsr theme In order for themes to work, they must include all CSS, Javascript, and image assets that they use. This patch adds all CSS, Javascript, and images from the prog theme to ccsr, EXCEPT for the famfamfam image set, which needs to be moved outside of the theme directories, per bug 8624. Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 18:42:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 16:42:02 +0000 Subject: [Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view In-Reply-To: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8597-70-a8OIhs88Y9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597 --- Comment #46 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12066 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12066&action=edit Bug 8597: Add system preferences to configure the mobile view. This patch adds the following system preferences: * OpacMainUserBlockMobile - alternate content for the MainUserBlock for mobile * OPACMobileUserCSS - custom CSS for mobile views only * OpacShowFiltersPulldownMobile - whether or not to show the index dropdown on the mobile view * OpacShowLibrariesPulldownMobile - whether or not to show the library dropdown on the mobile view Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com> Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 18:42:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 16:42:16 +0000 Subject: [Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view In-Reply-To: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8597-70-9Sdr37R8m9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 18:42:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 16:42:26 +0000 Subject: [Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view In-Reply-To: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8597-70-qWqcp4v7MY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597 --- Comment #47 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12067 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12067&action=edit Bug 8597 follow-up: add missing lib files Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 18:42:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 16:42:27 +0000 Subject: [Koha-bugs] [Bug 8408] Odd OPAC message when OPAC Renewals are disabled and OPACFineNoRenewals is set to blank In-Reply-To: <bug-8408-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8408-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8408-70-mhmunTPP7u@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8408 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #15 from Paul Poulain <paul.poulain at biblibre.com> --- Follow-up pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 18:47:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 16:47:21 +0000 Subject: [Koha-bugs] [Bug 2060] Ability to import Authorities from Staff Client In-Reply-To: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2060-70-tmKrpE72R6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2060 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #22 from Paul Poulain <paul.poulain at biblibre.com> --- (In reply to comment #16) > How can you possibly pass QA if you HAVEN'T TESTED IT!!!! Jumping in the discution = Kyle, the QA team does not test the feature, it investigates code to detect something not respecting coding guidelines, coding practices. Sometimes, the QAer also find some possible side effect. Something that is not in the test plan, but could break another thing. In this case, there are 2 possibilities: * the QAer test itself * the QAer ask for more tests & switch back to "need signoff" * the QAer passes QA, warning the RM, that has the final cut anyway (yes, that's 3 and not 2, but it's friday, so it's permitted) ;-) Time to leave for me now, i'll test this patch lated & deeply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 19:15:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 17:15:22 +0000 Subject: [Koha-bugs] [Bug 8740] New: Serials Claims should be exportable all at once Message-ID: <bug-8740-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8740 Priority: P5 - low Change sponsored?: Sponsored Bug ID: 8740 CC: colin.campbell at ptfs-europe.com Assignee: koha-bugs at lists.koha-community.org Summary: Serials Claims should be exportable all at once Severity: enhancement Classification: Unclassified OS: All Reporter: mjr at software.coop URL: http://intranet/cgi-bin/koha/serials/claims.pl Hardware: All Status: NEW Version: master Component: Serials Product: Koha At the moment, you have to step through vendors one at a time. It should be possible to see all overdues at once, if chosen explicitly because the list may be large. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 19:37:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 17:37:08 +0000 Subject: [Koha-bugs] [Bug 8740] Serials Claims should be exportable all at once In-Reply-To: <bug-8740-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8740-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8740-70-GQiv20Hm9J@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8740 --- Comment #1 from MJ Ray (software.coop) <mjr at software.coop> --- Created attachment 12068 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12068&action=edit enh bug 8740 Serials Claims should be exportable all at once -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 19:37:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 17:37:53 +0000 Subject: [Koha-bugs] [Bug 8740] Serials Claims should be exportable all at once In-Reply-To: <bug-8740-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8740-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8740-70-aLKeS5OsFS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8740 MJ Ray (software.coop) <mjr at software.coop> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |mjr at software.coop |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 19:52:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 17:52:09 +0000 Subject: [Koha-bugs] [Bug 8661] break out additional authors in opac like in staff In-Reply-To: <bug-8661-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8661-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8661-70-XeQgjYyIPI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8661 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 19:52:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 17:52:14 +0000 Subject: [Koha-bugs] [Bug 8661] break out additional authors in opac like in staff In-Reply-To: <bug-8661-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8661-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8661-70-Z0slcgDjJL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8661 --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 12069 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12069&action=edit Bug 8661 - break out additional authors in opac like in staff This patch takes the simple route of copying over the markup for displaying authors from the staff client XSL to the OPAC. Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 19:52:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 17:52:53 +0000 Subject: [Koha-bugs] [Bug 8661] break out additional authors in opac like in staff In-Reply-To: <bug-8661-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8661-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8661-70-FjBLGtLRJe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8661 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Version|rel_3_8 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 19:59:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 17:59:57 +0000 Subject: [Koha-bugs] [Bug 8447] can't save new records / indicator error In-Reply-To: <bug-8447-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8447-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8447-70-MrbNxzmJCV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8447 --- Comment #14 from Brendan Gallagher <brendan at bywatersolutions.com> --- Created attachment 12070 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12070&action=edit Bug 8447: Make sure we have enough subfields for broader_headings Thanks to wajasu for providing the debugging information, as I cannot seem to duplicate the problem, even seeing where it could come from. Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 20:00:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 18:00:33 +0000 Subject: [Koha-bugs] [Bug 8447] can't save new records / indicator error In-Reply-To: <bug-8447-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8447-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8447-70-hr243guU0Y@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8447 Brendan Gallagher <brendan at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |brendan at bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 20:09:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 18:09:49 +0000 Subject: [Koha-bugs] [Bug 8741] New: crontab.example missing username, fails in some systems Message-ID: <bug-8741-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8741 Priority: P5 - low Change sponsored?: --- Bug ID: 8741 Assignee: gmcharlt at gmail.com Summary: crontab.example missing username, fails in some systems Severity: enhancement Classification: Unclassified OS: All Reporter: tomascohen at gmail.com Hardware: All Status: NEW Version: master Component: Command-line Utilities Product: Koha The default Ubuntu cron daemon needs the user that will be used to run the command defined for each line. It is a standard nowadays and will not break other OS's, but will address issues from some users. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 20:21:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 18:21:10 +0000 Subject: [Koha-bugs] [Bug 5705] search 4XX fields in authorities and link to 1XX In-Reply-To: <bug-5705-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5705-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5705-70-TdkwHulJfs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5705 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 20:23:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 18:23:34 +0000 Subject: [Koha-bugs] [Bug 8741] crontab.example missing username, fails in some systems In-Reply-To: <bug-8741-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8741-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8741-70-QYuTUlySPU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8741 --- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 12071 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12071&action=edit Bug 8741 - crontab.example missing username, fails in some systems Simple addition of the koha user to the sample cron file. Might help non-tech users to get things like incremental indexing to work. Sponsored-by: Universidad Nacional de C?rdoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 20:27:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 18:27:21 +0000 Subject: [Koha-bugs] [Bug 6566] Checking if DB records are properly indexed In-Reply-To: <bug-6566-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6566-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6566-70-D9otlPtKRf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6566 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 20:29:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 18:29:04 +0000 Subject: [Koha-bugs] [Bug 8741] crontab.example missing username, fails in some systems In-Reply-To: <bug-8741-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8741-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8741-70-Ce3JQbyL3N@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8741 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 20:29:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 18:29:18 +0000 Subject: [Koha-bugs] [Bug 8741] crontab.example missing username, fails in some systems In-Reply-To: <bug-8741-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8741-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8741-70-3PGMNsQFkX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8741 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 21:46:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 19:46:29 +0000 Subject: [Koha-bugs] [Bug 8677] table overlapping to the right on holds waiting In-Reply-To: <bug-8677-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8677-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8677-70-MgK1Tczgwe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8677 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12053|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 12072 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12072&action=edit [SIGNED-OFF] Bug 8677 - table overlapping to the right on holds waiting Converting layout to 100% flexible width to allow table to expand as needed. Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 21:46:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 19:46:50 +0000 Subject: [Koha-bugs] [Bug 8677] table overlapping to the right on holds waiting In-Reply-To: <bug-8677-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8677-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8677-70-u1YCz9lzmg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8677 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 21:51:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 19:51:59 +0000 Subject: [Koha-bugs] [Bug 8661] break out additional authors in opac like in staff In-Reply-To: <bug-8661-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8661-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8661-70-iQkLoJwM7A@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8661 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12069|0 |1 is obsolete| | --- Comment #3 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 12073 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12073&action=edit [SIGNED-OFF] Bug 8661 - break out additional authors in opac like in staff This patch takes the simple route of copying over the markup for displaying authors from the staff client XSL to the OPAC. Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 7 21:52:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 19:52:24 +0000 Subject: [Koha-bugs] [Bug 8661] break out additional authors in opac like in staff In-Reply-To: <bug-8661-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8661-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8661-70-w42KXkQuaF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8661 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 8 01:42:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 23:42:25 +0000 Subject: [Koha-bugs] [Bug 8447] can't save new records / indicator error In-Reply-To: <bug-8447-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8447-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8447-70-ABfaP3mDjN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8447 --- Comment #15 from wajasu <matted-34813 at mypacks.net> --- Here is a user case that caused the problem (for historical reference and testing for QA) In admin set sysprefs AutoCreateAuthorities - generate BiblioAddsAuthorities - allow dontmerge don't LinkerModule Default LinkerOptions broader_headings Catalogueing -> Z3950 search Subject [Bible.] Library of Congress[x] Import the one with: 1 Corinthians : 2005 080282577X (cloth:alkpaper) 2005052170 Edit koha itemtype books 942c, and 003 Save ( and get software error mentioning indicators) BEFORE jcamins 1st 8447 patch for corrected "map" translation: 630 ? - SUBJECT ADDED ENTRY--UNIFORM TITLE a Uniform title Bible. p 1 Corinthians p blah blah v Form subdivision blah blah Apply 8447 patch and Save ( now SAVE WORKS ) AFTER jcamins 8447 patch for corrected "map" translation: 630 ? - SUBJECT ADDED ENTRY--UNIFORM TITLE a Uniform title Bible. 6 9 (RLIN) 137 l Language of a work t Title of a work v Form subdivision x General subdivision y Chronological subdivision z Geographic subdivision wajasu Note: I recall that thre might be other bugs that this fix applies to. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 8 01:46:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 23:46:58 +0000 Subject: [Koha-bugs] [Bug 8447] can't save new records / indicator error In-Reply-To: <bug-8447-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8447-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8447-70-aIxC7e19J8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8447 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12050|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 8 01:47:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 23:47:39 +0000 Subject: [Koha-bugs] [Bug 8447] can't save new records / indicator error In-Reply-To: <bug-8447-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8447-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8447-70-urBaxXxjKu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8447 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12070|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 8 01:52:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 23:52:13 +0000 Subject: [Koha-bugs] [Bug 8447] can't save new records / indicator error In-Reply-To: <bug-8447-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8447-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8447-70-52MpSdBATS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8447 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 8 01:52:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 07 Sep 2012 23:52:15 +0000 Subject: [Koha-bugs] [Bug 8447] can't save new records / indicator error In-Reply-To: <bug-8447-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8447-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8447-70-KjDz60AjJD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8447 --- Comment #16 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12074 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12074&action=edit Bug 8447: Make sure we have enough subfields for broader_headings Thanks to wajasu for providing the debugging information, as I cannot seem to duplicate the problem, even seeing where it could come from. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 8 06:58:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Sep 2012 04:58:15 +0000 Subject: [Koha-bugs] [Bug 8447] can't save new records / indicator error In-Reply-To: <bug-8447-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8447-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8447-70-3PT9lqWC2O@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8447 wajasu <matted-34813 at mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12074|0 |1 is obsolete| | --- Comment #17 from wajasu <matted-34813 at mypacks.net> --- Created attachment 12075 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12075&action=edit SIGNED-OFF-Bug-8447-enough-subfield broader headings/ error indicators Here is a user case that caused the problem (for historical reference and testing for QA) In admin set sysprefs AutoCreateAuthorities - generate BiblioAddsAuthorities - allow dontmerge don't LinkerModule Default LinkerOptions broader_headings Catalogueing -> Z3950 search Subject [Bible.] Library of Congress[x] Import the one with: 1 Corinthians : 2005 080282577X (cloth:alkpaper) 2005052170 Edit koha itemtype books 942c, and 003 Inspect 630 before the save. Save BEFORE patch, we get softeare error (indicators...) AFTER patch (It SAVED!!!) If you inspect 630, the fields that were there before you saved are still therem but with an added link in subtag 9. Note: Code in Linkers other that Default doesn't use the map transform so i didn't attempt to test their behavior. wajasu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 8 06:59:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Sep 2012 04:59:59 +0000 Subject: [Koha-bugs] [Bug 8447] can't save new records / indicator error In-Reply-To: <bug-8447-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8447-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8447-70-0uktSowulB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8447 wajasu <matted-34813 at mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #18 from wajasu <matted-34813 at mypacks.net> --- bag - jacamins an I found some other broken behavior, which he fixed, and I tested. Signed Off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 8 07:05:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Sep 2012 05:05:12 +0000 Subject: [Koha-bugs] [Bug 8447] can't save new records / indicator error In-Reply-To: <bug-8447-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8447-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8447-70-zbnDevJWnv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8447 --- Comment #19 from wajasu <matted-34813 at mypacks.net> --- Created attachment 12076 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12076&action=edit bug8447autolinkauthorityfix.png correctly saved 630 field For reference, bug8447autolinkauthorityfix.png shows the finally save 630 field, with all the original fields preserved, and the link added (subtag 9). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 8 07:09:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Sep 2012 05:09:18 +0000 Subject: [Koha-bugs] [Bug 8447] can't save new records / indicator error In-Reply-To: <bug-8447-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8447-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8447-70-Gm6OrIcv0j@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8447 --- Comment #20 from Brendan Gallagher <brendan at bywatersolutions.com> --- (In reply to comment #18) > bag - jacamins an I found some other broken behavior, which he fixed, and I > tested. > > Signed Off. Great - I tested this with the original bug reporters data - so I'm glad that you found outlying issues. Great! and glad to see a new signed off test. I'll retest on the original data and provide a second signoff if it works. -Brendan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 8 07:34:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Sep 2012 05:34:24 +0000 Subject: [Koha-bugs] [Bug 8447] can't save new records / indicator error In-Reply-To: <bug-8447-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8447-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8447-70-mOqsYrGNfl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8447 --- Comment #21 from wajasu <matted-34813 at mypacks.net> --- I suspect this fix will fix bug 8552 as well. Since, it was subject headings like fields being broken. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 8 07:37:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Sep 2012 05:37:57 +0000 Subject: [Koha-bugs] [Bug 8552] BiblioAddsAuthorities set to Allow causes Software Error on Z3950 import In-Reply-To: <bug-8552-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8552-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8552-70-TT9zELXUfm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8552 wajasu <matted-34813 at mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matted-34813 at mypacks.net --- Comment #3 from wajasu <matted-34813 at mypacks.net> --- I suspect the 8447 patch to fix this as well, so it might be a dupe. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 8 11:16:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Sep 2012 09:16:27 +0000 Subject: [Koha-bugs] [Bug 8204] Authority viewer in OPAC ugly, unfriendly, and mostly useless In-Reply-To: <bug-8204-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8204-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8204-70-2NZv5on8wF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8204 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #37 from Chris Cormack <chris at bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 8 11:16:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Sep 2012 09:16:30 +0000 Subject: [Koha-bugs] [Bug 8678] XSLT stylesheets output XML, but HTML is needed In-Reply-To: <bug-8678-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8678-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8678-70-XnSvlwlgDi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8678 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris at bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 8 11:33:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Sep 2012 09:33:09 +0000 Subject: [Koha-bugs] [Bug 8089] Use Koha::Cache everywhere In-Reply-To: <bug-8089-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8089-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8089-70-dZyG5NI2kn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089 --- Comment #18 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 12077 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12077&action=edit Bug 8089 : Follow up fixing an error scalar = grep returns the number of hits array = grep returns the matches We had changed the behaviour so could no longer find any primary keys -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 8 11:33:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Sep 2012 09:33:29 +0000 Subject: [Koha-bugs] [Bug 8089] Use Koha::Cache everywhere In-Reply-To: <bug-8089-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8089-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8089-70-GpJmKyCJeC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 8 11:35:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Sep 2012 09:35:02 +0000 Subject: [Koha-bugs] [Bug 8089] Use Koha::Cache everywhere In-Reply-To: <bug-8089-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8089-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8089-70-ZCkIPYAzwQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #19 from Chris Cormack <chris at bigballofwax.co.nz> --- Last patch needs to be tested and pushed, Master is currently broken (anything that uses UpdateInTables in C4::SQLHelper does not work) Like ModMember Once again the tests save us from releasing drastically broken code. Now we just have to get it so we run the tests before we push. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 8 16:39:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Sep 2012 14:39:01 +0000 Subject: [Koha-bugs] [Bug 8089] Use Koha::Cache everywhere In-Reply-To: <bug-8089-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8089-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8089-70-IN1RIbAt5z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 8 16:39:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Sep 2012 14:39:03 +0000 Subject: [Koha-bugs] [Bug 8089] Use Koha::Cache everywhere In-Reply-To: <bug-8089-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8089-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8089-70-HfiXMLFfNS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11400|0 |1 is obsolete| | Attachment #11401|0 |1 is obsolete| | Attachment #11402|0 |1 is obsolete| | Attachment #12077|0 |1 is obsolete| | --- Comment #20 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12078 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12078&action=edit Bug 8089 : Follow up fixing an error scalar = grep returns the number of hits array = grep returns the matches We had changed the behaviour so could no longer find any primary keys Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com> Tests pass following patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 8 21:26:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Sep 2012 19:26:44 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-ISLf1T378z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 wajasu <matted-34813 at mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #38 from wajasu <matted-34813 at mypacks.net> --- Everything worked, permissions etc. Except one behavior: -When I've added the permissions to add courses to a new staff patron, the autosearch javascript for adding an instructor doesn't work. It works for the koha sysadmin, but my staff user only had catalog and manage courses set for permissions. If you figure out why that call doesn't get through security or such, then I think things will be signed off. wajasu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 8 21:38:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Sep 2012 19:38:29 +0000 Subject: [Koha-bugs] [Bug 8552] BiblioAddsAuthorities set to Allow causes Software Error on Z3950 import In-Reply-To: <bug-8552-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8552-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8552-70-L7d3hmKxfU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8552 wajasu <matted-34813 at mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from wajasu <matted-34813 at mypacks.net> --- I was doing more Z3950 search and saves and got similiar errors for 100 fields. I applied the 8447 patch, and things worked fine. *** This bug has been marked as a duplicate of bug 8447 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 8 21:38:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Sep 2012 19:38:29 +0000 Subject: [Koha-bugs] [Bug 8447] can't save new records / indicator error In-Reply-To: <bug-8447-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8447-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8447-70-y1JD4fSPw8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8447 wajasu <matted-34813 at mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com --- Comment #22 from wajasu <matted-34813 at mypacks.net> --- *** Bug 8552 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 8 22:20:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 08 Sep 2012 20:20:09 +0000 Subject: [Koha-bugs] [Bug 8686] author search in staff missing checkboxes and menu In-Reply-To: <bug-8686-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8686-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8686-70-70XXh2aP0m@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8686 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Nicole C. Engard <nengard at gmail.com> --- It's not happening anymore .. not sure what it was, but it wasn't custom xslt cause I don't have that :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 9 02:52:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Sep 2012 00:52:28 +0000 Subject: [Koha-bugs] [Bug 8211] Add "subject (broader), " "subject (narrower), " and "subject (related)" options for search In-Reply-To: <bug-8211-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8211-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8211-70-32TepxRpsJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8211 --- Comment #2 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Example authority records: Record 1: =001 1 =151 ##$aArizona. =551 ##$aUnited States$wg$92 =551 ##$aPhoenix$wh$93 Record 2: =001 2 =151 ##$aUnited States. =551 ##$aArizona$wh$91 Record 3: =001 3 =151 ##$aPhoenix. =551 ##$aArizona$wg$91 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 9 09:11:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Sep 2012 07:11:27 +0000 Subject: [Koha-bugs] [Bug 8742] New: Example uses perl 5.8 in Makefile.PL Message-ID: <bug-8742-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8742 Priority: P5 - low Change sponsored?: --- Bug ID: 8742 Assignee: gmcharlt at gmail.com Summary: Example uses perl 5.8 in Makefile.PL Severity: trivial Classification: Unclassified OS: All Reporter: mtompset at hotmail.com Hardware: All Status: NEW Version: unspecified Component: Installation and upgrade (command-line installer) Product: Koha When running a tarball or git install, the following is printed at the end of the process: --- BEGIN SNIPPET --- To change any configuration setting, please run perl Makefile.PL again. To override one of the target directories, you can do so on the command line like this: perl Makefile.PL PERL_MODULE_DIR=/usr/share/perl/5.8 You can also set different default values for parameters or override directory locations by using environment variables. --- END SNIPPET --- Seeing as 5.10 is the minimum version for Perl as of 3.6.x, this should be reflected. Test -------- $ perl Makefile.PL # hold down the enter key to accept all the defaults # scroll back up, if necessary, to see it does say 5.8 as above. Apply patch retest. The results should reflect an appropriate version. If there is /usr/share/perl/ in @INC, the first match is used. Otherwise, /usr/share/perl/5.10 is used (since the text does say LIKE this, and not EXACTLY this). Patch to follow shortly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 9 10:36:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Sep 2012 08:36:07 +0000 Subject: [Koha-bugs] [Bug 8742] Example uses perl 5.8 in Makefile.PL In-Reply-To: <bug-8742-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8742-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8742-70-EhiBdCr3Hl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8742 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |mtompset at hotmail.com --- Comment #1 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 12079 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12079&action=edit Changed hardcoded path for a programmatic one. Changed hardcoded /usr/share/perl/5.8 message to be based on: my @version = grep /\/usr\/share\/perl\//, @INC; By doing a push @version, ('/usr/share/perl/5.10') if !$version[0]; If inexplicably the grep fails or @INC is empty, then there is a reasonable default value. print "\nperl Makefile.PL PERL_MODULE_DIR=$version[0]\n\n"; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 9 14:10:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Sep 2012 12:10:14 +0000 Subject: [Koha-bugs] [Bug 8743] New: ZOOM error when merging authority change to biblios Message-ID: <bug-8743-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8743 Priority: P3 Change sponsored?: --- Bug ID: 8743 Assignee: jcamins at cpbibliography.com Summary: ZOOM error when merging authority change to biblios Severity: critical Classification: Unclassified OS: All Reporter: jcamins at cpbibliography.com Hardware: All Status: NEW Version: master Component: MARC Authority data support Product: Koha The symptoms of the problem are as follows: In the log file, we get the following errors: [Sun Sep 02 23:38:10 2012] [error] [client 75.149.175.233] ZOOM error 25 "Specified element set name not valid for specified database" (addinfo: "F") from diag-set 'Bib-1', referer: http://****/cgi-bin/koha/authorities/authorities.pl?authid=3010 [Sun Sep 02 23:38:11 2012] [error] [client 75.149.175.233] Premature end of script headers: authorities.pl, referer: http://****/cgi-bin/koha/authorities/authorities.pl?authid=3010 The actual authority record was updated (here I added a bogus 'J'). =LDR 00372nz a2200133o 4500 =001 3010 =003 UkLoVW =005 20120902233810.0 =008 120816|||a||||||\\\\\\\\\\\|\|||\\\\\d =040 \\$aUkLoVW$cUkLoVW =100 1\$aBearman, C. JJ. =667 \\$aMachine generated authority record. =670 \\$aWork cat.: (UkLoVW): Stealens, Yvette 3009, Hampshire folk map :, 2010. =942 \\$aPERSO_NAME A search in Authorities for 'Bearman" returns this (the old contents), but following details gets updated record: Authority search results Results 1 to 1 of 1 Summary Used in Delete Bearman, C. J. Details 3 biblio(s) Biblios are likewise not update with the new text. Running 'rebuild_zebra.pl -a -r -v' fixed the Authority search results, but not the biblios, in particular the 700 field where Bearman is listed as a secondary author. Same issue if I modify the primary author Authority on a biblio, the biblios are not updated with the changed content. The cause for this seems to be the use of the xml syntax in the merge function. git bisect failed me, but sometime before 3.8.0 (possibly last November), our Zebra config changed and the xml syntax stopped working. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 9 14:20:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Sep 2012 12:20:25 +0000 Subject: [Koha-bugs] [Bug 8743] ZOOM error when merging authority change to biblios In-Reply-To: <bug-8743-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8743-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8743-70-FoZBIp0np1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8743 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 9 14:20:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Sep 2012 12:20:27 +0000 Subject: [Koha-bugs] [Bug 8743] ZOOM error when merging authority change to biblios In-Reply-To: <bug-8743-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8743-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8743-70-BEfy2fKTnC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8743 --- Comment #1 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12080 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12080&action=edit Bug 8743: ZOOM error when merging authority change to biblios The merge fails and the following errors appear in the log: [Sun Sep 02 23:38:10 2012] [error] [client 75.149.175.233] ZOOM error 25 "Specified element set name not valid for specified database" (addinfo: "F") from diag-set 'Bib-1', referer: http://****/cgi-bin/koha/authorities/authorities.pl?authid=3010 [Sun Sep 02 23:38:11 2012] [error] [client 75.149.175.233] Premature end of script headers: authorities.pl, referer: http://****/cgi-bin/koha/authorities/authorities.pl?authid=3010 Test plan: 1) Set dontmerge to "Do" 2) Find an authority that is linked to a bib record. 3) Edit the main entry of the authority. 4) Save the authority record. 5) Notice that you got a nasty error and the bib record was not updated. 6) Apply patch. 7) Edit the main entry of the authority again (you can just set it back to what it was to start with). 8) Save authority record. 9) Notice that there was no error, and the bib record was updated. 10) Sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 9 14:25:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Sep 2012 12:25:29 +0000 Subject: [Koha-bugs] [Bug 8304] composed authorities Rameau management In-Reply-To: <bug-8304-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8304-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8304-70-RUz6bjy9dv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 9 14:25:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Sep 2012 12:25:31 +0000 Subject: [Koha-bugs] [Bug 8304] composed authorities Rameau management In-Reply-To: <bug-8304-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8304-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8304-70-n2oe8iNYpO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11046|0 |1 is obsolete| | --- Comment #4 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12081 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12081&action=edit Bug 8304 : composed authorities Rameau management Bug 5635: bulkmarcimport new parameters & features This patch is designed to manage the composed authorities the Way Rameau is coping with them in France. This enables libraries to merge composed authorities and only change the heading field. It supposes that the previous data is sent to merge function so that process deletes previous heading entries. Say you have in a biblio record : - 606 $9 1214 $3 123 $a Europe $9 1215 $3 456 $y France $9 1210 $3 199 $x Politiciens $9 1216 $3 789 $z 1801-1860 And you change authority 1210 -250 $a Politiciens into -250 $a Politique You should get : - 606 $9 1214 $3 123 $a Europe $9 1215 $3 456 $y France $9 1210 $3 199 $x Politique $9 1216 $3 789 $z 1801-1860 In an other record : - 606 $9 1210 $3 199 $a Politiciens You should get : - 606 $9 1210 $3 199 $a Politique This patch changes the merge function. And adds three internal functions. merge function has been prettyfied And documentation from GuessAuthTypeCode has been updated (had not been) Rebased patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 9 14:30:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Sep 2012 12:30:39 +0000 Subject: [Koha-bugs] [Bug 8304] composed authorities Rameau management In-Reply-To: <bug-8304-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8304-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8304-70-vxQxzFooAA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 --- Comment #5 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- While this feature is very promising, it does not cope well with multiple subfield authorities. If I change an authority with the following main entry: =150 ##$aActors$zUnited States$vBiography to =150 ##$aActors$zUnited States$vBiographies the bib records end up with the heading: =650 ##$zUnited States$aActors$zUnited States$vBiographies Notice the extra $z at the front. Also, I noticed if your single-subfield heading is out of sync on the bib record, sometimes you end up with two identical subfields in the bib record. I'm not entirely sure what causes that, though, as it doesn't seem to happen 100% of the time. Also note that in order to test this you must first apply the fix for bug 8743. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 9 14:49:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Sep 2012 12:49:28 +0000 Subject: [Koha-bugs] [Bug 8304] composed authorities Rameau management In-Reply-To: <bug-8304-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8304-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8304-70-jzqiTTW9yN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 --- Comment #6 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- If you added a syspref so that libraries using precomposed headings could disable the automatic composition, that would probably be enough for MARC21/NORMARC authority merging to resume working. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 9 14:52:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Sep 2012 12:52:16 +0000 Subject: [Koha-bugs] [Bug 8744] New: Thesaurus in authorities should not lock fields Message-ID: <bug-8744-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8744 Priority: P5 - low Change sponsored?: --- Bug ID: 8744 Assignee: jcamins at cpbibliography.com Summary: Thesaurus in authorities should not lock fields Severity: normal Classification: Unclassified OS: All Reporter: jcamins at cpbibliography.com Hardware: All Status: NEW Version: master Component: MARC Authority data support Product: Koha Although fields in the authority editor should support thesaurus control, they should never be locked, as authority records commonly refer to other records that may not be in use locally (and therefore might not be in the authority file). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 9 14:54:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Sep 2012 12:54:59 +0000 Subject: [Koha-bugs] [Bug 8744] Thesaurus in authorities should not lock fields In-Reply-To: <bug-8744-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8744-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8744-70-wa29h2TGLR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8744 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 9 14:55:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Sep 2012 12:55:00 +0000 Subject: [Koha-bugs] [Bug 8744] Thesaurus in authorities should not lock fields In-Reply-To: <bug-8744-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8744-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8744-70-aHOlBmdJzJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8744 --- Comment #1 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12082 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12082&action=edit Bug 8744: Thesaurus in authorities should not lock fields Although fields in the authority editor should support thesaurus control, they should never be locked, as authority records commonly refer to other records that may not be in use locally (and therefore might not be in the authority file). Test plan: 1) Make sure a 5xx field in one of your authority frameworks is thesaurus-controlled. 2) Note that you cannot edit the field directly. 3) Apply patch. 4) Note that you can now edit the field directly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 9 18:19:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Sep 2012 16:19:14 +0000 Subject: [Koha-bugs] [Bug 8523] Authority hierarchies only support UNIMARC In-Reply-To: <bug-8523-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8523-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8523-70-GTfvYIPB6e@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 --- Comment #7 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12083 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12083&action=edit Bug 8523 follow-up: support NORMARC, too Thanks to Katrin for pointing out that the original patch left NORMARC a second-class citizen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 9 19:03:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Sep 2012 17:03:54 +0000 Subject: [Koha-bugs] [Bug 8523] Authority hierarchies only support UNIMARC In-Reply-To: <bug-8523-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8523-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8523-70-qQA9xDrHzz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 --- Comment #8 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12084 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12084&action=edit Bug 8523: fix translatability The translator script was unable to handle arrayrefs in TT, so this patch modifies the way the hierarchy generator recurses to avoid the need for them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 9 20:41:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Sep 2012 18:41:22 +0000 Subject: [Koha-bugs] [Bug 8386] Error in duplicate detection message for authorities In-Reply-To: <bug-8386-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8386-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8386-70-TxczVT1Z0m@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8386 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 9 20:41:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Sep 2012 18:41:41 +0000 Subject: [Koha-bugs] [Bug 8386] Error in duplicate detection message for authorities In-Reply-To: <bug-8386-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8386-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8386-70-41xeZsf1Vr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8386 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 9 20:41:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Sep 2012 18:41:43 +0000 Subject: [Koha-bugs] [Bug 8386] Error in duplicate detection message for authorities In-Reply-To: <bug-8386-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8386-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8386-70-3h1CS3Qzac@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8386 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10726|0 |1 is obsolete| | --- Comment #7 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12085 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12085&action=edit Bug 8386: Error in duplicate detection message for authorities If you create a new authority record and the name already exists in your database, you get a duplicate warning. This is good, but there is a small error in the message: Duplicate record suspected Is this a duplicate of HASH(0x47fa670)? This patch corrects a reoccurence the error message to show the title. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 9 21:03:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Sep 2012 19:03:53 +0000 Subject: [Koha-bugs] [Bug 8523] Authority hierarchies only support UNIMARC In-Reply-To: <bug-8523-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8523-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8523-70-VqiLsyFa4o@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 --- Comment #9 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12086 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12086&action=edit Bug 8523 follow-up: always regenerate non-UNIMARC hierarchies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 9 21:48:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Sep 2012 19:48:40 +0000 Subject: [Koha-bugs] [Bug 8744] Thesaurus in authorities should not lock fields In-Reply-To: <bug-8744-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8744-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8744-70-OatD8GKlFu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8744 --- Comment #2 from wajasu <matted-34813 at mypacks.net> --- Created attachment 12087 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12087&action=edit SIGNED-OFF-Bug-8744-Thesaurus-in-authorities-shouldd not lock fields Before this patch, I wasn't able to edit the Geographical name in authority 551 field. Now I can. It is necessary to be able to create -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 9 21:52:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Sep 2012 19:52:35 +0000 Subject: [Koha-bugs] [Bug 8744] Thesaurus in authorities should not lock fields In-Reply-To: <bug-8744-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8744-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8744-70-FWGvZj0TSO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8744 wajasu <matted-34813 at mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12082|0 |1 is obsolete| | Attachment #12087|0 |1 is obsolete| | --- Comment #3 from wajasu <matted-34813 at mypacks.net> --- Created attachment 12088 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12088&action=edit SIGNED-OFF-Bug-8744-Thesaurus-in-authorities-should-not-lock-fields Now one can create heirarchies of geographical names inthe authority 551 $a field for example. This was needed to support bug 8211 for expanded search functionaility. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 9 21:58:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Sep 2012 19:58:11 +0000 Subject: [Koha-bugs] [Bug 8744] Thesaurus in authorities should not lock fields In-Reply-To: <bug-8744-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8744-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8744-70-pUXJB4Ky57@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8744 wajasu <matted-34813 at mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |matted-34813 at mypacks.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 9 22:03:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Sep 2012 20:03:56 +0000 Subject: [Koha-bugs] [Bug 8523] Authority hierarchies only support UNIMARC In-Reply-To: <bug-8523-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8523-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8523-70-4dMej9TSlw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 --- Comment #10 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12089 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12089&action=edit Bug 8523 follow-up: sanitize HTML in template -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 9 23:23:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Sep 2012 21:23:11 +0000 Subject: [Koha-bugs] [Bug 8211] Add "subject (broader), " "subject (narrower), " and "subject (related)" options for search In-Reply-To: <bug-8211-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8211-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8211-70-TZZAuANMTD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8211 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11851|0 |1 is obsolete| | --- Comment #3 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12090 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12090&action=edit Bug 8211: Add exploded search options When working with hierarchical subject headings, it is sometimes helpful to do a search for all records with a specific subject, plus broader/narrower/related subjects. This patch adds support for these "exploded" subject searches to Koha. To test: 1) Make sure you have a bunch of hierarchical subjects. I created geographical subjects for "Arizona," "United States," and "Phoenix," and linked them together using 551s, and made sure I had a half dozen records linking to each (but not all to all three). 2) Do a search for su-br:Arizona (or choose "Subject and broader terms" on the advanced search screen with "more options" displayed), and check that you get the records with the subject "Arizona" and the records with the subject "United States" 3) Do a search for su-na:Arizona (or choose "Subject and narrower terms" on the advanced search screen with "more options" displayed), and check that you get the records with the subject "Arizona" and the records with the subject "Phoenix" 4) Do a search for su-rl:Arizona (or choose "Subject and related terms" on the advanced search screen with "more options" displayed), and check that you get the records with the subject "Arizona," the records with the subject "United States," and the records with the subject "Phoenix" 5) Ensure that other searches still work (keyword, subject, ccl, whatever) 6) Sign off Technical details: This patch adds a shim in front of C4::Search::buildQuery in order to preprocess the query and call the _handle_exploding_search callback. This shim will allow us to gradually offload query parsing to a new query parser module. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 9 23:26:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Sep 2012 21:26:21 +0000 Subject: [Koha-bugs] [Bug 8726] Did you mean? plugin for broader/narrower/related terms In-Reply-To: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8726-70-Q5OeyIIghl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12008|0 |1 is obsolete| | --- Comment #2 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12091 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12091&action=edit Bug 8726: ExplodedTerms suggestion plugin When working with hierarchical subject headings, it is sometimes helpful to do a search for all records with a specific subject, plus broader/narrower/related subjects. This patch adds a suggestion plugin for these "exploded" subject searches to Koha. Note that this patch depends on both bug 8211 AND bug 8209. To test (NOTE: this test plan covers both 8211 and 8726): 1) Make sure you have a bunch of hierarchical subjects. I created geographical subjects for "Arizona," "United States," and "Phoenix," and linked them together using 551s, and made sure I had a half dozen records linking to each (but not all to all three). 2) Do a search for su-br:Arizona (or choose "Subject and broader terms" on the advanced search screen with "more options" displayed), and check that you get the records with the subject "Arizona" and the records with the subject "United States" 3) Do a search for su-na:Arizona (or choose "Subject and narrower terms" on the advanced search screen with "more options" displayed), and check that you get the records with the subject "Arizona" and the records with the subject "Phoenix" 4) Do a search for su-rl:Arizona (or choose "Subject and related terms" on the advanced search screen with "more options" displayed), and check that you get the records with the subject "Arizona," the records with the subject "United States," and the records with the subject "Phoenix" 5) Ensure that other searches still work (keyword, subject, ccl, whatever) 6) Use "Did you mean?" page in admin section to enable ExplodedTerms plugin 7) Do a keyword search on the OPAC, confirm that searching for exploded terms is suggested. 8) Do a subject search on the OPAC, confirm that searching for exploded terms is suggested. 9) Do a non-keyword, non-subject search on the OPAC, confirm that searching for exploded terms is NOT suggested. 10) Disable ExplodedTerms plugin and enable AuthorityFile plugin. 11) Do search on OPAC, confirm suggestions are made from authority file. 12) Sign off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 9 23:39:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Sep 2012 21:39:43 +0000 Subject: [Koha-bugs] [Bug 8211] Add "subject (broader), " "subject (narrower), " and "subject (related)" options for search In-Reply-To: <bug-8211-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8211-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8211-70-Lq9mWKB4J3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8211 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8649 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 9 23:39:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Sep 2012 21:39:43 +0000 Subject: [Koha-bugs] [Bug 8649] C4::Search needs a unit test In-Reply-To: <bug-8649-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8649-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8649-70-GtqQhMqO0m@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8649 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8211 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 9 23:42:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Sep 2012 21:42:13 +0000 Subject: [Koha-bugs] [Bug 8211] Add "subject (broader), " "subject (narrower), " and "subject (related)" options for search In-Reply-To: <bug-8211-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8211-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8211-70-y1WeSl0UPO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8211 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8744 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 9 23:42:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Sep 2012 21:42:13 +0000 Subject: [Koha-bugs] [Bug 8744] Thesaurus in authorities should not lock fields In-Reply-To: <bug-8744-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8744-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8744-70-xwKWBXvdzU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8744 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8211 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 00:10:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Sep 2012 22:10:55 +0000 Subject: [Koha-bugs] [Bug 8523] Authority hierarchies only support UNIMARC In-Reply-To: <bug-8523-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8523-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8523-70-poLnxAP6q4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 --- Comment #11 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12092 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12092&action=edit Bug 8523 follow-up: correctly handle leaves -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 00:19:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 09 Sep 2012 22:19:15 +0000 Subject: [Koha-bugs] [Bug 8211] Add "subject (broader), " "subject (narrower), " and "subject (related)" options for search In-Reply-To: <bug-8211-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8211-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8211-70-DBkRAwmv3C@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8211 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12090|0 |1 is obsolete| | --- Comment #4 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12093 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12093&action=edit Bug 8211: Add exploded search options When working with hierarchical subject headings, it is sometimes helpful to do a search for all records with a specific subject, plus broader/narrower/related subjects. This patch adds support for these "exploded" subject searches to Koha. To test: 1) Make sure you have a bunch of hierarchical subjects. I created geographical subjects for "Arizona," "United States," and "Phoenix," and linked them together using 551s, and made sure I had a half dozen records linking to each (but not all to all three). 2) Do a search for su-br:Arizona (or choose "Subject and broader terms" on the advanced search screen with "more options" displayed), and check that you get the records with the subject "Arizona" and the records with the subject "United States" 3) Do a search for su-na:Arizona (or choose "Subject and narrower terms" on the advanced search screen with "more options" displayed), and check that you get the records with the subject "Arizona" and the records with the subject "Phoenix" 4) Do a search for su-rl:Arizona (or choose "Subject and related terms" on the advanced search screen with "more options" displayed), and check that you get the records with the subject "Arizona," the records with the subject "United States," and the records with the subject "Phoenix" 5) Ensure that other searches still work (keyword, subject, ccl, whatever) 6) Sign off Technical details: This patch adds a shim in front of C4::Search::buildQuery in order to preprocess the query and call the _handle_exploding_search callback. This shim will allow us to gradually offload query parsing to a new query parser module. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 02:20:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 00:20:34 +0000 Subject: [Koha-bugs] [Bug 8211] Add "subject (broader), " "subject (narrower), " and "subject (related)" options for search In-Reply-To: <bug-8211-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8211-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8211-70-1On5Fhcl0u@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8211 wajasu <matted-34813 at mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12093|0 |1 is obsolete| | --- Comment #5 from wajasu <matted-34813 at mypacks.net> --- Created attachment 12094 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12094&action=edit SIGNED-OFF-Bug-8211-Add-exploded-search-options.patch After pulling master i applied these: 0001-Bug-8744-Thesaurus-in-authorities-should-not-lock-fi.patch 0002-Bug-8649-Add-unit-test-for-C4-Search.patch 0003-bug-8649-make-sure-C4-Context-is-fully-mocked-up-bef.patch 0004-bug-8649-make-sure-we-can-exit-if-a-test-fails.patch 0005-bug-8649-create-a-temp-directory-for-Zebra-for-C4-Se.patch 0006-bug-8649-quiet-a-variable-use-warning.patch 0007-Bug-8211-Add-exploded-search-options.patch You need 8744 to be able to edit Geographical names in 551 (unlock them) 8649 has Search.t tests 1) I had created the authority heirarchy as comment#2 described. 2) I used z3950 to search LOC specifiying "United States" in subject heading, and chose "1000 things to love about America" and added an item. I navigated to its 651 Geographic name heading and clicked the editor icon for the 'a' subtag, and used the authority search plugin ( $a = United States ) and found the record that was created in step #1). choose it. I finished out the biblio and added an item. 3) I did the same thing as step 2) but for "Arizona" and "Phoenix" subject headingg, linking with the authority plugin as well. Pick a book for Arizona accordingly. 4) I ran rebuild-zebra and did my searches as described in comment #3) in the OPAC search. su-br:Arizona su-na:Arizona and su-rl:Arizona Each returned results. For me: I also had Phoenix in the su-br-Arizona search, and jcamins said there must be a subject heading in my chosen biblio for Phoenix. There was, so I edited my biblio, to remove the Restaurant -- Arizona TOPICAL TERM SUBJECT HEADING. After that I requeried su-br: Arizona, and the Phoenix item did not show up as we wanted. So there is an added restriction to be sure other subject heading don't interfere with results. Cool beans!!! wajasu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 02:21:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 00:21:47 +0000 Subject: [Koha-bugs] [Bug 8211] Add "subject (broader), " "subject (narrower), " and "subject (related)" options for search In-Reply-To: <bug-8211-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8211-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8211-70-TXJNx29AlH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8211 wajasu <matted-34813 at mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |matted-34813 at mypacks.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 03:21:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 01:21:20 +0000 Subject: [Koha-bugs] [Bug 7993] saved report with hierarchies In-Reply-To: <bug-7993-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7993-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7993-70-XwX0GAcpkK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7993 Srdjan Jankovic <srdjan at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11656|0 |1 is obsolete| | Attachment #11775|0 |1 is obsolete| | Attachment #11809|0 |1 is obsolete| | --- Comment #17 from Srdjan Jankovic <srdjan at catalyst.net.nz> --- Created attachment 12095 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12095&action=edit Bug 7993: Save reports with Group/Subgroup hierarchy Patch was signed off. Rebase conflict was in reports/guided_reports.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 03:21:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 01:21:33 +0000 Subject: [Koha-bugs] [Bug 7993] saved report with hierarchies In-Reply-To: <bug-7993-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7993-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7993-70-NOgymSg5W3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7993 Srdjan Jankovic <srdjan at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 03:56:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 01:56:00 +0000 Subject: [Koha-bugs] [Bug 8034] Enable server print queue selection In-Reply-To: <bug-8034-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8034-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8034-70-9EvJzimH6M@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8034 Srdjan Jankovic <srdjan at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11995|0 |1 is obsolete| | --- Comment #16 from Srdjan Jankovic <srdjan at catalyst.net.nz> --- Created attachment 12096 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12096&action=edit bug_8034: Restored network printer maintenance and selection This patch is just for restoring printer maintenance and selection, not for priting itself. It is just a preparation step. * Added UsePrintQueues syspref. If set to No, no printer info will be displayed/used * Database changes: - printers table PRIMARY KEY is now printqueue. It is more natural. We should really have a synthetic id, but printqueue is good enough - branches.branchprinter is a FOREIGN KEY to printers.printqueue * Created C4::Auth::get_user_printer() function that will return appropriate printer. In order of preference: - session selected - logged in branch branchprinter * Moved printer functions to C4::Printer * Restored printer maint/selection in admin zone UsePrintQueues permitting * Restored printer selection in circ/selectbranchprinter.pl UsePrintQueues permitting Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 03:58:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 01:58:09 +0000 Subject: [Koha-bugs] [Bug 8034] Enable server print queue selection In-Reply-To: <bug-8034-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8034-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8034-70-rxHhfqAykK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8034 Srdjan Jankovic <srdjan at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #17 from Srdjan Jankovic <srdjan at catalyst.net.nz> --- I think I've sorted it out now. Changes are reasonably minor, so I'll leave it in Signed Off, but you can flip it to Needs Signoff if you wish. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 06:49:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 04:49:42 +0000 Subject: [Koha-bugs] [Bug 8523] Authority hierarchies only support UNIMARC In-Reply-To: <bug-8523-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8523-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8523-70-IrPXgXjPwY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Jared, this works almost perfectly now - one small issue: should the tree show me the authority I am currently looking at? For me the tree always shows the highest level when I open an authority from the result list 'details' link and after a refresh of the page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 06:52:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 04:52:56 +0000 Subject: [Koha-bugs] [Bug 8523] Authority hierarchies only support UNIMARC In-Reply-To: <bug-8523-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8523-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8523-70-12xfOebfnw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 --- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 12097 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12097&action=edit screenshot For better illustration on how this works and looks like, I am adding a screenshot. It looks nice! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 06:57:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 04:57:02 +0000 Subject: [Koha-bugs] [Bug 8523] Authority hierarchies only support UNIMARC In-Reply-To: <bug-8523-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8523-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8523-70-hCukGuQfeo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 --- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Frederic and Paul: I am testing this feature and I have created a UNIMARC installation using the sample database from the sandboxes. If you can give me some hints about how to catalogue the authorities correctly, I can try repeating my tests for UNIMARC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 07:19:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 05:19:37 +0000 Subject: [Koha-bugs] [Bug 8745] New: disallow rebuild_zebra.pl from executing, when run by root user Message-ID: <bug-8745-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8745 Priority: P5 - low Change sponsored?: --- Bug ID: 8745 Assignee: gmcharlt at gmail.com Summary: disallow rebuild_zebra.pl from executing, when run by root user Severity: normal Classification: Unclassified OS: All Reporter: mtj at kohaaloha.com Hardware: All Status: NEW Version: master Component: Tools Product: Koha many people run rebuild_zebra.pl as root, this often causes zebra reindexing to fail, (sometimes silently) the Koha mailing-list has many people experiencing problems causes by this patching rebuild_zebra.pl to quit (with a warning) when run from root user, would stop this perhaps --force arg could be passed to rebuild_zebra.pl, to allow it to run as root -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 07:38:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 05:38:37 +0000 Subject: [Koha-bugs] [Bug 8644] jQueryUI CSS file should not contain customizations In-Reply-To: <bug-8644-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8644-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8644-70-HeJQgnfcSq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8644 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Pushed for QA CC| |mtj at kohaaloha.com QA Contact| |mtj at kohaaloha.com --- Comment #9 from Mason James <mtj at kohaaloha.com> --- (In reply to comment #8) > I checked out all the different jQuery widgets I could find. Everything > looks good to me. looks good to me too, nice patch Owen passing QA... mason at xen1:~/g/head$ koha-qa.pl -c 2 testing 2 commit(s) (applied to commit c8ef17e) * 5f72a63 Bug 8644 [OPAC] jQueryUI CSS file should not contain customizations koha-tmpl/opac-tmpl/prog/en/css/opac.css koha-tmpl/opac-tmpl/prog/en/lib/jquery/jquery-ui.css koha-tmpl/opac-tmpl/prog/en/lib/jquery/jquery-ui.js * ccf406f Bug 8644 [staff client] jQueryUI CSS file should not contain customizations koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css koha-tmpl/intranet-tmpl/prog/en/lib/jquery/jquery-ui.css koha-tmpl/intranet-tmpl/prog/en/lib/jquery/jquery-ui.js - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK - t/00-valid-xml.t tests... OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 07:45:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 05:45:20 +0000 Subject: [Koha-bugs] [Bug 8644] jQueryUI CSS file should not contain customizations In-Reply-To: <bug-8644-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8644-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8644-70-O97IACcpne@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8644 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed for QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 09:53:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 07:53:27 +0000 Subject: [Koha-bugs] [Bug 8209] "Did you mean?" suggestions based on authorities In-Reply-To: <bug-8209-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8209-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8209-70-pgCwxz7O6t@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8209 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11321|0 |1 is obsolete| | --- Comment #10 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12098 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12098&action=edit Bug 8209: "Did you mean?" from authorities One of the ideas behind authority records is that users who search for one term should have related terms (according to the authority file) suggested to them. At the moment, Koha doesn't do that. Adding an authority searching step to regular searches and displaying any suggestions in a "Did you mean" bar at the top of the results would be very useful. This commit adds a Koha::SuggestionEngine class which is in charge of getting suggestions from individual suggestion engine plugins, which much be in the Koha::SuggestionEngine::Plugin::* namespace, and extend Koha::SuggestionEngine::Base. Suggestions are loaded asynchronously using AJAX, and a link to a page with suggestions is provided for users with Javascript turned off. The AuthorityFile suggestion engine plugin looks up the specified search terms in the authority file and then suggests searches for records using matching authorities. Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com> Rebased 2 August 2012 and incorporated QA feedback Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Test plan: - Verified database update added system preference correctly, pref defaults to OFF - Verified search results and detail pages in OPAC and staff still worked the same as before * for no results * with results - Activated system preference and tested various searches * Searches from simple search * Searches from advanced search * Search links in records - Deactivated Javascript - verified fallback works correctly Notes: - Suggested terms can include autorities with no linked records. - When combining more than one search option using advanced search this results in "no suggestions" more often. Feature works best from simple search. Overall great feature making use of authorities in a user friendly way! Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com> Rebased on latest master 2012-09-10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 09:55:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 07:55:21 +0000 Subject: [Koha-bugs] [Bug 8726] Did you mean? plugin for broader/narrower/related terms In-Reply-To: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8726-70-ZmX0Prk1bB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12091|0 |1 is obsolete| | --- Comment #3 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12099 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12099&action=edit Bug 8726: ExplodedTerms suggestion plugin When working with hierarchical subject headings, it is sometimes helpful to do a search for all records with a specific subject, plus broader/narrower/related subjects. This patch adds a suggestion plugin for these "exploded" subject searches to Koha. Note that this patch depends on both bug 8211 AND bug 8209. To test (NOTE: this test plan covers both 8211 and 8726): 1) Make sure you have a bunch of hierarchical subjects. I created geographical subjects for "Arizona," "United States," and "Phoenix," and linked them together using 551s, and made sure I had a half dozen records linking to each (but not all to all three). 2) Do a search for su-br:Arizona (or choose "Subject and broader terms" on the advanced search screen with "more options" displayed), and check that you get the records with the subject "Arizona" and the records with the subject "United States" 3) Do a search for su-na:Arizona (or choose "Subject and narrower terms" on the advanced search screen with "more options" displayed), and check that you get the records with the subject "Arizona" and the records with the subject "Phoenix" 4) Do a search for su-rl:Arizona (or choose "Subject and related terms" on the advanced search screen with "more options" displayed), and check that you get the records with the subject "Arizona," the records with the subject "United States," and the records with the subject "Phoenix" 5) Ensure that other searches still work (keyword, subject, ccl, whatever) 6) Use "Did you mean?" page in admin section to enable ExplodedTerms plugin 7) Do a keyword search on the OPAC, confirm that searching for exploded terms is suggested. 8) Do a subject search on the OPAC, confirm that searching for exploded terms is suggested. 9) Do a non-keyword, non-subject search on the OPAC, confirm that searching for exploded terms is NOT suggested. 10) Disable ExplodedTerms plugin and enable AuthorityFile plugin. 11) Do search on OPAC, confirm suggestions are made from authority file. 12) Sign off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 10:05:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 08:05:21 +0000 Subject: [Koha-bugs] [Bug 8523] Authority hierarchies only support UNIMARC In-Reply-To: <bug-8523-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8523-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8523-70-lEWr3W7uBJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 --- Comment #15 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12100 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12100&action=edit Bug 8523 follow-up: quiet warning -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 10:05:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 08:05:49 +0000 Subject: [Koha-bugs] [Bug 8395] order receive not sorting right In-Reply-To: <bug-8395-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8395-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8395-70-RrxkPLyB7J@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8395 --- Comment #9 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to comment #8) > I dont think this fixes the problem. At a typical academic/public site > receipting against a major supplier some 500+ orders may appear. But the > sorting by summary only affects the page of results displayed move forward > and sort order reverts to basket order. As there may be multiple orders for > one title locating all of them is difficult. Hi Colin, Yes you are right. But this patch fixes a problem and allows to have the same behaviour (without regression) as we have before datatable. Maybe we want to hide pagination on this table to be more consistent. To have a sort on all results, we have to implement datatable with a server-side processing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 10:08:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 08:08:58 +0000 Subject: [Koha-bugs] [Bug 8523] Authority hierarchies only support UNIMARC In-Reply-To: <bug-8523-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8523-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8523-70-vPDa3lESjl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 --- Comment #16 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- (In reply to comment #12) > Jared, this works almost perfectly now - one small issue: should the tree > show me the authority I am currently looking at? For me the tree always > shows the highest level when I open an authority from the result list > 'details' link and after a refresh of the page. Could you take a screenshot of what you see right when you refresh? When I refresh, the hierarchy is automatically open to the current node. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 10:14:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 08:14:33 +0000 Subject: [Koha-bugs] [Bug 8523] Authority hierarchies only support UNIMARC In-Reply-To: <bug-8523-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8523-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8523-70-FyI1sModj6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 --- Comment #17 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- (In reply to comment #16) > Could you take a screenshot of what you see right when you refresh? When I > refresh, the hierarchy is automatically open to the current node. Never mind. Additional information over IRC has clarified the problem. Patch forthcoming. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 10:17:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 08:17:30 +0000 Subject: [Koha-bugs] [Bug 7673] New patron permissions In-Reply-To: <bug-7673-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7673-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7673-70-0xiAHICiJe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 --- Comment #10 from delaye <stephane.delaye at biblibre.com> --- i have this message when i want apply this patch in a sandbox Applying: Bug 7673 : New patron permissions Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging cataloguing/additem.pl CONFLICT (content): Merge conflict in cataloguing/additem.pl Auto-merging installer/data/mysql/en/mandatory/userpermissions.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt Failed to merge in the changes. Patch failed at 0001 Bug 7673 : New patron permissions When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Bug 7673 - New patron permissions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 10:36:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 08:36:12 +0000 Subject: [Koha-bugs] [Bug 8523] Authority hierarchies only support UNIMARC In-Reply-To: <bug-8523-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8523-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8523-70-D8bjtJLeuf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 --- Comment #18 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12101 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12101&action=edit Bug 8523 follow-up: always open tree to current node -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 10:36:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 08:36:40 +0000 Subject: [Koha-bugs] [Bug 7673] New patron permissions In-Reply-To: <bug-7673-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7673-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7673-70-5r0MXX5XXI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9857|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 12102 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12102&action=edit Bug 7673 : New patron permissions This patch adds the following permissions: - editcatalogue.limited_item_edition: Limit item modification to barcode, status and note - editcatalogue.delete_all_items: Delete all items at once - tools.items_limited_batchmod: Limit batch item modification to item status -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 10:37:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 08:37:38 +0000 Subject: [Koha-bugs] [Bug 8089] Use Koha::Cache everywhere In-Reply-To: <bug-8089-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8089-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8089-70-sD0xa5X9l1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089 --- Comment #21 from Paul Poulain <paul.poulain at biblibre.com> --- mmm... testing the follow-up, i've the same problem with and without it: modifications to patrons are not saved. the logs says: DBD::mysql::st execute failed: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '=NULL' at line 3 at /home/paul/koha.dev/koha-community/C4/SQLHelper.pm line 197. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 10:45:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 08:45:22 +0000 Subject: [Koha-bugs] [Bug 8089] Use Koha::Cache everywhere In-Reply-To: <bug-8089-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8089-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8089-70-jYkOgecZ80@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089 --- Comment #22 from Chris Cormack <chris at bigballofwax.co.nz> --- (In reply to comment #21) > mmm... testing the follow-up, i've the same problem with and without it: > modifications to patrons are not saved. > > the logs says: > DBD::mysql::st execute failed: You have an error in your SQL syntax; check > the manual that corresponds to your MySQL server version for the right > syntax to use near '=NULL' at line 3 at > /home/paul/koha.dev/koha-community/C4/SQLHelper.pm line 197. That error is unrelated to this I think. Running the tests before the patch fail, and the borrower in the db is not modified, running the tests after the tests pass and the borrower is modified. You might want to make sure you have flushed memcached if you have it running. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 11:24:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 09:24:17 +0000 Subject: [Koha-bugs] [Bug 6779] Don't allow patron renewal x days before expiry In-Reply-To: <bug-6779-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6779-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6779-70-tJCKX7vYVF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6779 Meenakshi <meenakshi.r at osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |meenakshi.r at osslabs.biz Assignee|sagar.br at osslabs.biz |meenakshi.r at osslabs.biz -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 12:32:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 10:32:16 +0000 Subject: [Koha-bugs] [Bug 8300] Koha should have mechanized testing suite In-Reply-To: <bug-8300-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8300-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8300-70-1YKholakkX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8300 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10445|0 |1 is obsolete| | --- Comment #4 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12103 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12103&action=edit Bug 8300: Add mechanized unit test for batch import This new unit test confirms that importing records via the Stage MARC import tool still works by connecting to a Koha instance and importing a record then reverting the import, checking at each step of the way that everything is as it should be. To test: 1. Install Test::WWW::Mechanize > sudo apt-get install libtest-www-mechanize-perl 2. Set environment variables to reflect your Koha instance: > export KOHA_USER=kohaadmin > export KOHA_PASS=katikoan > export KOHA_INTRANET_URL=http://localhost:8080 > export KOHA_OPAC_URL=http://localhost 3. Run the test: > prove t/db_dependent/www/batch.t This updated patch now handles both MARC21 and UNIMARC installations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 13:39:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 11:39:18 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-EekvAuoR2j@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #39 from Kyle M Hall <kyle at bywatersolutions.com> --- The ajax borrower search requires that the logged in librarian have full circulation permissions. I don't think this would be considered a bug. Kyle (In reply to comment #38) > Everything worked, permissions etc. > > Except one behavior: > -When I've added the permissions to add courses to a new staff patron, the > autosearch javascript for adding an instructor doesn't work. It works for > the koha sysadmin, but my staff user only had catalog and manage courses set > for permissions. > > If you figure out why that call doesn't get through security or such, then I > think things will be signed off. > > wajasu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 13:51:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 11:51:31 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-SJIsAOrncs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #50 from Kyle M Hall <kyle at bywatersolutions.com> --- That makes a lot of sense. I'll add a followup for that. Kyle (In reply to comment #49) > (In reply to comment #45) > > > If there are no pending operations it should display a message > > > saying so rather than an empty table. > > > > I suppose we can do that, but if there are no pending operations, the link > > for the page disappears, so it is assumed no one will visit it when there > > are no pending operations. > > Actually as I work with it more and test leaving some patron modifications > to "ignore," it makes sense to me to have this page redirect back to itself > rather than the home page. If some lines had been set to "ignore" then they > re-display. If all are complete it shows a message that the queue is empty. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 14:06:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 12:06:53 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-a3xefmuL6E@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #51 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12104 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12104&action=edit Bug 7067 - OPAC Borrower Self Registration - Followup - Change redirect from mainpage.pl to members-update.pl -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 14:56:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 12:56:49 +0000 Subject: [Koha-bugs] [Bug 8034] Enable server print queue selection In-Reply-To: <bug-8034-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8034-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8034-70-odGkuARIlw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8034 --- Comment #18 from Jonathan Druart <jonathan.druart at biblibre.com> --- Hi Srdjan, With your last patch I still can't update the queue value for an existing printer. (following my previous test plan) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 15:03:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 13:03:39 +0000 Subject: [Koha-bugs] [Bug 8676] show vendor name in source of acquisition In-Reply-To: <bug-8676-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8676-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8676-70-GWQ2BwFWhB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8676 --- Comment #2 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 12105 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12105&action=edit source of acquisition in item form If you look at the item info on the Items tab instead you do see the name, but the vendor ID is all that shows in the edit items screen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 15:15:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 13:15:37 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-7JrMPKkeBC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #52 from Owen Leonard <oleonard at myacpl.org> --- Another major bug: If I have PatronSelfRegistration turned off, clicking the "my personal details" page redirects to the OPAC home page. There needs to be several working combinations: - PatronSelfRegistration is ON, OPACPatronDetails is ON: New patrons can sign up on the OPAC, existing patrons can edit their details via the entry form. - PatronSelfRegistration is ON, OPACPatronDetails is OFF: New patrons can sign up on the OPAC but existing patrons can't edit their details via the entry form. [This option may not make much logical sense but since we can't link two preferences...] - PatronSelfRegistration is OFF, OPACPatronDetails is ON: New patrons can't sign up on the OPAC but existing patrons can edit their details via the entry form. - PatronSelfRegistration is OFF, OPACPatronDetails is OFF: Patrons can only view their details on the OPAC. Jonathan I hope you don't mind I'm removing the "signed off" status. I think there are too many issues with this for it to move forward just yet. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 15:16:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 13:16:08 +0000 Subject: [Koha-bugs] [Bug 8431] Increase the borrower attribute field size from 64 characters to 255 In-Reply-To: <bug-8431-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8431-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8431-70-nSFNuNAohz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8431 --- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12106 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12106&action=edit Bug 8431 - Followup - Use TT filter html_line_break on extended attributes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 15:16:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 13:16:53 +0000 Subject: [Koha-bugs] [Bug 8431] Increase the borrower attribute field size from 64 characters to 255 In-Reply-To: <bug-8431-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8431-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8431-70-5cMctNS8db@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8431 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 15:26:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 13:26:27 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-xLz2bKP57r@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #53 from Jonathan Druart <jonathan.druart at biblibre.com> --- (En r?ponse au commentaire 52) > Jonathan I hope you don't mind I'm removing the "signed off" status. I think > there are too many issues with this for it to move forward just yet. No problem Owen :) If there are problems with this patch, it is normal to passed it as failed qa. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 15:30:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 13:30:27 +0000 Subject: [Koha-bugs] [Bug 8365] Renewal duration in issuingules In-Reply-To: <bug-8365-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8365-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8365-70-OVOpUpaXWn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 15:30:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 13:30:32 +0000 Subject: [Koha-bugs] [Bug 8365] Renewal duration in issuingules In-Reply-To: <bug-8365-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8365-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8365-70-BkZBSiHPaf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 15:38:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 13:38:19 +0000 Subject: [Koha-bugs] [Bug 8746] New: rebuild_zebra_sliced.sh don't work where Record length of 106041 is larger than the MARC spec allows Message-ID: <bug-8746-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8746 Priority: P5 - low Change sponsored?: --- Bug ID: 8746 Assignee: gmcharlt at gmail.com Summary: rebuild_zebra_sliced.sh don't work where Record length of 106041 is larger than the MARC spec allows Severity: major Classification: Unclassified OS: All Reporter: stephane.delaune at biblibre.com Hardware: All Status: NEW Version: rel_3_10 Component: Searching Product: Koha rebuild_zebra_sliced.sh don't work where Record length of 106041 is larger than the MARC spec allows -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 15:39:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 13:39:13 +0000 Subject: [Koha-bugs] [Bug 8746] rebuild_zebra_sliced.sh don't work where Record length of 106041 is larger than the MARC spec allows In-Reply-To: <bug-8746-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8746-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8746-70-bMuG3NtGO0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8746 stephane.delaune at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 16:10:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 14:10:39 +0000 Subject: [Koha-bugs] [Bug 8747] New: clicking "repeat this tag" causes cursor to jump to top of page Message-ID: <bug-8747-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8747 Priority: P5 - low Change sponsored?: --- Bug ID: 8747 CC: m.de.rooy at rijksmuseum.nl Assignee: gmcharlt at gmail.com Summary: clicking "repeat this tag" causes cursor to jump to top of page Severity: minor Classification: Unclassified OS: All Reporter: ago at bywatersolutions.com Hardware: All Status: NEW Version: rel_3_8 Component: Cataloging Product: Koha When editing a record, clicking on 'repeat this tag' for the 650 causes the cursor to jump to the top of the page. This does not always happen, but I have seen it on multiples sites in 3.6 and 3.8. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 16:38:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 14:38:27 +0000 Subject: [Koha-bugs] [Bug 2720] Fines that debar automatically, should undebar automatically when paid. In-Reply-To: <bug-2720-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2720-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2720-70-OOKv4WMHI4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- (In reply to comment #2) > Since there are numerous reasons for debarment, not just fines, but overdues, > or a manual debarment Automatic debarment happens only through overdue triggers. Fines may block certain actions, but those checks are made based on the fine amount and fine-related system preferences ( OPACFineNoRenewals, maxoutstanding, noissuescharge). Unless I'm missing something? > If a borrower has a least one row in this table, they will be debarred. Will this affect the suspension in days feature? Will the debarred column in the borrowers table stop being used, and all checks for patron debarment be referred to this new table? Is this going to significantly affect performance? > This would require modifying all code that involves debarring, in particular > C4::Overdues::CheckBorrowerDebarred, the borrower editing page, and the > circulation pages. If we keep borrowers.debarred, I suppose checkout performance doesn't have to be affected. I am concerned that this is going to slow down check-in. Upon each check-in Koha will have to query the borrower_debarment table to see if the patron should have the restriction removed? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 16:43:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 14:43:26 +0000 Subject: [Koha-bugs] [Bug 8745] disallow rebuild_zebra.pl from executing, when run by root user In-Reply-To: <bug-8745-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8745-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8745-70-pVU8BEYeF6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8745 --- Comment #1 from Barry Cannon <barry at oslo.ie> --- Created attachment 12107 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12107&action=edit Addition of "executed by user" check to warn if execute by root user. This patch will check the uid of user who executed the script. If it is the root user a warning will be issued and die. A user can force "execute as root" by using the -runas-root switch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 16:58:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 14:58:40 +0000 Subject: [Koha-bugs] [Bug 8716] Reordering of routing list entries doesn't work In-Reply-To: <bug-8716-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8716-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8716-70-cIl19CRKHS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8716 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11959|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 12108 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12108&action=edit [SIGNED-OFF] Bug 8716 - make the routing list reordering function work Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 17:00:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 15:00:10 +0000 Subject: [Koha-bugs] [Bug 8716] Reordering of routing list entries doesn't work In-Reply-To: <bug-8716-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8716-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8716-70-C5TmWSMCyu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8716 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 17:11:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 15:11:44 +0000 Subject: [Koha-bugs] [Bug 8748] New: Bib # Default Matching Rule Message-ID: <bug-8748-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8748 Priority: P5 - low Change sponsored?: --- Bug ID: 8748 CC: m.de.rooy at rijksmuseum.nl Assignee: gmcharlt at gmail.com Summary: Bib # Default Matching Rule Severity: enhancement Classification: Unclassified OS: All Reporter: nengard at gmail.com Hardware: All Status: NEW Version: master Component: Cataloging Product: Koha I think that we should have bib number as a default matching rule in new installs. This is one of those rules that I add all of the time and since the bib number is a Koha field, it just makes sense to have that rule in the system by default. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 17:46:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 15:46:27 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-Bhe26gPbJP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12104|0 |1 is obsolete| | --- Comment #54 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12109 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12109&action=edit Bug 7067 - OPAC Borrower Self Registration - Followup -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 17:48:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 15:48:12 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-wcdUDdCiok@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 17:56:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 15:56:04 +0000 Subject: [Koha-bugs] [Bug 8370] Default checkout, hold and return policy for all library => wrong term In-Reply-To: <bug-8370-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8370-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8370-70-n2oDwZz8gm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8370 --- Comment #2 from Nicole C. Engard <nengard at gmail.com> --- I think for "Default checkout, hold and return policy for all library" we can just remove the "for all libraries" part ... default to me implies a fall back. And then maybe change "Checkout limit by patron category for all libraries" to be "Default checkout limit by patron category" But I would think we might want to add something at the top of the ALL LIBRARIES rules to explain that if you only set those then they are applied to 'all libraries' but if you set specifics those are used instead - or something to make it clearer. Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 18:11:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 16:11:25 +0000 Subject: [Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices In-Reply-To: <bug-6030-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6030-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6030-70-Qc88lKjORV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 --- Comment #15 from Sophie MEYNIEUX <sophie.meynieux at biblibre.com> --- Created attachment 12110 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12110&action=edit Bug 6030 follow-up Fixing problem detected previously: * add column_def retrieval, to have header displaying the "explained" row name, not the table name. (the name is not expanded for CSV exports) * removed some warnings. * fixed some problems with csvfilename being defined/empty. Now, csvfilename is always defined, and set to '' by default. Some tests have been updated accordingly * added the charset=UTF8 on mail headers. This patch also adds some missing columns to columns.def Signed-off-by: Sophie Meynieux <sophie.meynieux at biblibre.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 18:11:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 16:11:33 +0000 Subject: [Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices In-Reply-To: <bug-6030-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6030-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6030-70-p7bFYVaZrx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 --- Comment #16 from Sophie MEYNIEUX <sophie.meynieux at biblibre.com> --- Created attachment 12111 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12111&action=edit Bug 6030 followup : add a condition to use getlanguage in bath mode -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 18:11:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 16:11:46 +0000 Subject: [Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices In-Reply-To: <bug-6030-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6030-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6030-70-SR5LThONep@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 --- Comment #17 from Sophie MEYNIEUX <sophie.meynieux at biblibre.com> --- Created attachment 12112 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12112&action=edit Bug 6030 followup : Specify "biblio.title" as a column name to differentiate from borrowers.title -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 18:14:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 16:14:27 +0000 Subject: [Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices In-Reply-To: <bug-6030-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6030-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6030-70-8JwNNjNyJY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Sophie MEYNIEUX <sophie.meynieux at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5241|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 18:15:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 16:15:07 +0000 Subject: [Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices In-Reply-To: <bug-6030-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6030-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6030-70-iv9qgd83uO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Sophie MEYNIEUX <sophie.meynieux at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6251|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 18:15:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 16:15:19 +0000 Subject: [Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices In-Reply-To: <bug-6030-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6030-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6030-70-D5m5qXUUcS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Sophie MEYNIEUX <sophie.meynieux at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6252|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 18:15:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 16:15:55 +0000 Subject: [Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices In-Reply-To: <bug-6030-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6030-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6030-70-i5r4L9N8Ss@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Sophie MEYNIEUX <sophie.meynieux at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off CC| |sophie.meynieux at biblibre.co | |m -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 18:22:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 16:22:03 +0000 Subject: [Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices In-Reply-To: <bug-6030-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6030-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6030-70-hnZIh77yB8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 --- Comment #18 from Sophie MEYNIEUX <sophie.meynieux at biblibre.com> --- Created attachment 12113 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12113&action=edit Bug 6030 Allow html content in letters Squashed commit of the following: commit 8368e5de723ec7607402be341975014c8b7b0ea9 Author: Henri-Damien LAURENT <henridamien.laurent at biblibre.com> Date: Tue Sep 21 14:41:07 2010 +0200 Bug 6030 : overdue_notices :Removing warning Two extra warnings were issued when using html commit 5984fc92772af68c51f7f5b5450fd5b27d5b6d37 Author: Henri-Damien LAURENT <henridamien.laurent at biblibre.com> Date: Tue Sep 21 12:27:29 2010 +0200 Bug 6030 : Letters can be html in overdu_notices.pl Signed-off-by: Sophie Meynieux <sophie.meynieux at biblibre.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 18:22:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 16:22:50 +0000 Subject: [Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices In-Reply-To: <bug-6030-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6030-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6030-70-2Jlu24viKL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Sophie MEYNIEUX <sophie.meynieux at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5240|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 18:27:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 16:27:47 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-worTNfQTaS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12109|0 |1 is obsolete| | --- Comment #55 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12114 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12114&action=edit Bug 7067 - OPAC Borrower Self Registration - Followup -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 18:28:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 16:28:09 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-zJptsnOXyM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #56 from Kyle M Hall <kyle at bywatersolutions.com> --- This new followup should address all the issues that Owen has brought up. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 18:30:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 16:30:28 +0000 Subject: [Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices In-Reply-To: <bug-6030-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6030-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6030-70-JQhwuMMADe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 --- Comment #19 from Sophie MEYNIEUX <sophie.meynieux at biblibre.com> --- I have signed off the first 2 patches and added 2 small follow-up : * the first one is need because when $query is not defined, themelanguage returns an error * the seconf one because in french we need to differentiate borrowers.title and biblio.title (it's not the same translation) I don't know why the main path is the fourth file sended : in consequence, to test, you should apply 4th patch first and then 1, 2 and 3 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 18:47:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 16:47:52 +0000 Subject: [Koha-bugs] [Bug 8749] New: Missing Ubuntu library files in ubuntu.packages and ubuntu.12.04.packages Message-ID: <bug-8749-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8749 Priority: P5 - low Change sponsored?: --- Bug ID: 8749 Assignee: gmcharlt at gmail.com Summary: Missing Ubuntu library files in ubuntu.packages and ubuntu.12.04.packages Severity: trivial Classification: Unclassified OS: All Reporter: mtompset at hotmail.com Hardware: All Status: NEW Version: unspecified Component: Installation and upgrade (command-line installer) Product: Koha Test ---- 1) Clone fresh Ubuntu install 2) sudo apt-get install git git-email 3) git clone git://git.koha-community.org/koha.git kohaclone 4) cd kohaclone 5) sudo apt-get install dselect 6) sudo dpkg --set-selections < install_misc/ubuntu.packages 7) sudo dselect 8) I,C,R,Q 9) ./koha_perl_deps.pl -m -u Installed Required Module is Module Name Version Version Required -------------------------------------------------------------------------------------------- Template::Plugin::HtmlToText 0 * 0.03 Yes Test::Strict 0 * 0.14 No -------------------------------------------------------------------------------------------- 10) grep template install_misc/ubuntu.packages 11) The file (libtemplate-plugin-htmltotext-perl) is not listed 12) apply patch 13) repeat 6-9 14) should be a blank list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 19:04:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 17:04:51 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-7lcA4MV2zr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #57 from Owen Leonard <oleonard at myacpl.org> --- After the latest patch I find that if PatronSelfRegistration is ON and OPACPatronDetails is OFF I can submit a new registration. The check for OPACPatronDetails on the entry form disables the form. Turning OPACPatronDetails ON, I find that submitting changes to an existing patron record and approving them in the staff client results in NO changes to the patron record. Now when I submit a new patron registration it appears to work but the username field isn't pre-filled in the login form. In the log I see errors: - opac-memberentry.pl: Use of uninitialized value in pattern match (m//) at /home/oleonard/kohaclone/C4/SQLHelper.pm line 418., referer: http://localhost:88 - opac-memberentry.pl: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha`.`borrowers`, CONSTRAINT `borrowers_ibfk_1` FOREIGN KEY (`categorycode`) REFERENCES `categories` (`categorycode`)) at /home/oleonard/kohaclone/C4/SQLHelper.pm line 168., referer: http://localhost:88/cgi-bin/koha/opac-memberentry.pl Other issues which still need to be addressed: > - The table markup on members/members-update.pl is missing a </tr>, > causing validation errors. > - I think the random-character verification field should be styled like > other required fields > - Since the datepicker widget doesn't make it easy to pick a date far in > the past (as are birthdays for some of us), I don't think the field > should be read-only. > - I see an error in the log when submitting the registration form in > the OPAC: > > substr outside of string at > /home/oleonard/kohaclone/opac/opac-memberentry.pl line 239 Also: Any thoughts on the message queue issue? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 19:48:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 17:48:08 +0000 Subject: [Koha-bugs] [Bug 8209] "Did you mean?" suggestions based on authorities In-Reply-To: <bug-8209-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8209-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8209-70-Q1eqWuDjkj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8209 wajasu <matted-34813 at mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12098|0 |1 is obsolete| | --- Comment #11 from wajasu <matted-34813 at mypacks.net> --- Created attachment 12115 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12115&action=edit SIGNED-OFF-Bug-8209-Did-you-mean-from-authorities. After jcamins rebase for me to apply patch. I needed to retest for 8276. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 19:49:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 17:49:06 +0000 Subject: [Koha-bugs] [Bug 8089] Use Koha::Cache everywhere In-Reply-To: <bug-8089-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8089-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8089-70-VpHlckHcRk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #23 from Kyle M Hall <kyle at bywatersolutions.com> --- FYI, C4::SQLHelper::GetPrimaryKeys seems to be broken now. It returns 1 instead of the primary keys. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 20:00:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 18:00:55 +0000 Subject: [Koha-bugs] [Bug 8089] Use Koha::Cache everywhere In-Reply-To: <bug-8089-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8089-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8089-70-zbal52iXcJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089 --- Comment #24 from Chris Cormack <chris at bigballofwax.co.nz> --- (In reply to comment #23) > FYI, C4::SQLHelper::GetPrimaryKeys seems to be broken now. It returns 1 > instead of the primary keys. Kyle that is precisely what this follow up patch fixes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 20:07:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 18:07:35 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-QhYAw4JRkR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12114|0 |1 is obsolete| | --- Comment #58 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12116 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12116&action=edit Bug 7067 - OPAC Borrower Self Registration - Followup -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 20:10:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 18:10:05 +0000 Subject: [Koha-bugs] [Bug 8726] Did you mean? plugin for broader/narrower/related terms In-Reply-To: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8726-70-hXeuWj5LbW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 wajasu <matted-34813 at mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12099|0 |1 is obsolete| | --- Comment #4 from wajasu <matted-34813 at mypacks.net> --- Created attachment 12117 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12117&action=edit SIGNED-OFF-Bug-8726-ExplodedTerms-suggestion-plugin. I applied: 0001-Bug-8744-Thesaurus-in-authorities-should-not-lock-fi.patch 0002-Bug-8649-Add-unit-test-for-C4-Search.patch 0003-bug-8649-make-sure-C4-Context-is-fully-mocked-up-bef.patch 0004-bug-8649-make-sure-we-can-exit-if-a-test-fails.patch 0005-bug-8649-create-a-temp-directory-for-Zebra-for-C4-Se.patch 0006-bug-8649-quiet-a-variable-use-warning.patch 0007-Bug-8211-Add-exploded-search-options.patch 0008-SIGNED-OFF-Bug-8209-Did-you-mean-from-authorities.patch 0009-Bug-8726-ExplodedTerms-suggestion-plugin.patch As mentioned, the work done in 8211 testing is duplicated here, so I leveraged the authority linked geographical names i had in my db. I applied the updatedatabase.pl I configured the syspref DidYouMean... to Suggest. AND on the main Administration web page, in the bottom right corner, there is a new link "Did you mean?" to configure the suggestion plugins, of which I checked (Exploded Terms, Auhtority file, Both) and did my searches. Suggestion links showed up in the results page, to offer alternate searches, (su-br, su-na, su-rl accordingly) and I got the same results as 8211 provided. The authority file link would show up using my search term as a link, and I had to pull down some biblios for "Smith, John" and use the authority search plugin to link the authority to the biblio item. wajasu Note: You can change the order of the suggestion plugins by using drag n drop of the control in the DidyYouMean configuration page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 20:10:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 18:10:24 +0000 Subject: [Koha-bugs] [Bug 8726] Did you mean? plugin for broader/narrower/related terms In-Reply-To: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8726-70-RxSEy2rByr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 wajasu <matted-34813 at mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |matted-34813 at mypacks.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 20:11:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 18:11:21 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-I6yr2zjaWe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #59 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to comment #57) > After the latest patch I find that if PatronSelfRegistration is ON and > OPACPatronDetails is OFF I can submit a new registration. The check for > OPACPatronDetails on the entry form disables the form. Doh! Fixed. > Turning OPACPatronDetails ON, I find that submitting changes to an existing > patron record and approving them in the staff client results in NO changes > to the patron record. Caused by a bug in master. Fixed. > Now when I submit a new patron registration it appears to work but the > username field isn't pre-filled in the login form. In the log I see errors: > > - opac-memberentry.pl: Use of uninitialized value in pattern match (m//) at > /home/oleonard/kohaclone/C4/SQLHelper.pm line 418., referer: > http://localhost:88 > > - opac-memberentry.pl: DBD::mysql::st execute failed: Cannot add or update a > child row: a foreign key constraint fails (`koha`.`borrowers`, CONSTRAINT > `borrowers_ibfk_1` FOREIGN KEY (`categorycode`) REFERENCES `categories` > (`categorycode`)) at /home/oleonard/kohaclone/C4/SQLHelper.pm line 168., > referer: http://localhost:88/cgi-bin/koha/opac-memberentry.pl I'm not getting this error. Please retest with the new followup. Either I fixed it incidentally, or it's a different in configuration perhaps? > > Other issues which still need to be addressed: > I know I had fixed these, the followup must have gone awol! > > - The table markup on members/members-update.pl is missing a </tr>, > > causing validation errors. Fixed > > - I think the random-character verification field should be styled like > > other required fields Fixed > > - Since the datepicker widget doesn't make it easy to pick a date far in > > the past (as are birthdays for some of us), I don't think the field > > should be read-only. Fixed > > - I see an error in the log when submitting the registration form in > > the OPAC: > > > > substr outside of string at > > /home/oleonard/kohaclone/opac/opac-memberentry.pl line 239 Fixed > Also: Any thoughts on the message queue issue? Is there any good reason the process_message_queue cron can't be run every minute? We need a "send it now" function, but we cannot until the email configuration is pulled out of the cron script parameters and put into Koha system preferences. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 20:23:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 18:23:39 +0000 Subject: [Koha-bugs] [Bug 8750] New: Chronological terms authorities not correctly indexed Message-ID: <bug-8750-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8750 Priority: P5 - low Change sponsored?: --- Bug ID: 8750 Assignee: gmcharlt at gmail.com Summary: Chronological terms authorities not correctly indexed Severity: enhancement Classification: Unclassified OS: All Reporter: tomascohen at gmail.com Hardware: All Status: NEW Version: master Component: MARC Authority data support Product: Koha There's no entry in authority's record.abs for indexing chronological terms. They cannot be searched and (obviously) linked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 20:29:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 18:29:40 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-sbJXmkvueK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #60 from Galen Charlton <gmcharlt at gmail.com> --- (In reply to comment #59) > Is there any good reason the process_message_queue cron can't be run every > minute? We need a "send it now" function, but we cannot until the email > configuration is pulled out of the cron script parameters and put into Koha > system preferences. There's no reason not to have the cronjob run once a minute, but if we start recommending that configuration, it will need to be patched to use a lockfile so that it doesn't allow simultaneous jobs to run if it takes longer than a minute to clear the message queue. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 20:30:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 18:30:21 +0000 Subject: [Koha-bugs] [Bug 8750] Chronological terms authorities not correctly indexed In-Reply-To: <bug-8750-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8750-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8750-70-QhDxuebobT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8750 --- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 12118 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12118&action=edit Bug 8750 - Chronological terms authorities not correctly indexed There was no entry in authority's record.abs for indexing chronological terms. They ccouldn't be searched and (obviously) linked. I've added those entries using the index names defined in authorities/etc/bib1.att Regards To+ Sponsored-by: Universidad Nacional de C?rdoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 20:32:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 18:32:01 +0000 Subject: [Koha-bugs] [Bug 8750] Chronological terms authorities not correctly indexed In-Reply-To: <bug-8750-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8750-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8750-70-efZUKfDqEG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8750 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 20:32:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 18:32:03 +0000 Subject: [Koha-bugs] [Bug 2720] Fines that debar automatically, should undebar automatically when paid. In-Reply-To: <bug-2720-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2720-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2720-70-ngBKQAnegJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> --- > Automatic debarment happens only through overdue triggers. Fines may block > certain actions, but those checks are made based on the fine amount and > fine-related system preferences ( OPACFineNoRenewals, maxoutstanding, > noissuescharge). Unless I'm missing something? > > Will this affect the suspension in days feature? Will the debarred column in > the borrowers table stop being used, and all checks for patron debarment be > referred to this new table? Is this going to significantly affect > performance? > > If we keep borrowers.debarred, I suppose checkout performance doesn't have > to be affected. I am concerned that this is going to slow down check-in. > Upon each check-in Koha will have to query the borrower_debarment table to > see if the patron should have the restriction removed? I would say we keep borrowers.debarred, but convert it to a boolean value. We can then have that value updated each time the debarments table is altered. I believe we will then need a nightly cronjob to remove expired debarments and update borrowers.debarred. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 20:39:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 18:39:17 +0000 Subject: [Koha-bugs] [Bug 7985] In Checkout, list of items checked out should show Charge from table accountlines In-Reply-To: <bug-7985-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7985-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7985-70-4cK9CgU7XL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7985 --- Comment #1 from Marc V?ron <veron at veron.ch> --- Still blocked by 7671 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 20:41:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 18:41:12 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-v3pQ74fuzU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #61 from Owen Leonard <oleonard at myacpl.org> --- (In reply to comment #59) > > - opac-memberentry.pl: Use of uninitialized value in pattern match (m//) at > > /home/oleonard/kohaclone/C4/SQLHelper.pm line 418., referer: > > http://localhost:88 > > > > - opac-memberentry.pl: DBD::mysql::st execute failed: Cannot add or update a > > child row: a foreign key constraint fails (`koha`.`borrowers`, CONSTRAINT > > `borrowers_ibfk_1` FOREIGN KEY (`categorycode`) REFERENCES `categories` > > (`categorycode`)) at /home/oleonard/kohaclone/C4/SQLHelper.pm line 168., > > referer: http://localhost:88/cgi-bin/koha/opac-memberentry.pl I figured it out: I cleared the PatronSelfRegistration preferences for testing and didn't put in a patron category for PatronSelfRegistrationUseTemporaryStatus. How might we deal with this possible omission? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 20:44:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 18:44:06 +0000 Subject: [Koha-bugs] [Bug 8750] Chronological terms authorities not correctly indexed In-Reply-To: <bug-8750-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8750-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8750-70-vlrLVzSz2d@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8750 --- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Note: this is not an issue if using DOM for authorities. To test, 1- Add a Chronological term in your authorities. 2- Reindex them or wait for your cron/daemon to do it. 3- Search for your chronologicla term (wont find it). 4- Apply this patch. 5- Restart your zebrasrv. 6- Reindex & search for your chronological term. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 20:48:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 18:48:02 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-cR6TM6XQ7U@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #62 from Owen Leonard <oleonard at myacpl.org> --- New issue: Submitting a change to an existing patron's home library works in that approving the change will correctly update the record, but the line doesn't show up in the list of fields which will be updated on members/members-update.pl. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 20:54:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 18:54:26 +0000 Subject: [Koha-bugs] [Bug 8743] ZOOM error when merging authority change to biblios In-Reply-To: <bug-8743-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8743-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8743-70-v8lOcGeYa5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8743 --- Comment #2 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12119 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12119&action=edit Bug 8743: ZOOM error when merging authority change to biblios The merge fails and the following errors appear in the log: [Sun Sep 02 23:38:10 2012] [error] [client 75.149.175.233] ZOOM error 25 "Specified element set name not valid for specified database" (addinfo: "F") from diag-set 'Bib-1', referer: http://****/cgi-bin/koha/authorities/authorities.pl?authid=3010 [Sun Sep 02 23:38:11 2012] [error] [client 75.149.175.233] Premature end of script headers: authorities.pl, referer: http://****/cgi-bin/koha/authorities/authorities.pl?authid=3010 Test plan: 1) Set dontmerge to "Do" 2) Find an authority that is linked to a bib record. 3) Edit the main entry of the authority. 4) Save the authority record. 5) Notice that you got a nasty error and the bib record was not updated. 6) Apply patch. 7) Edit the main entry of the authority again (you can just set it back to what it was to start with). 8) Save authority record. 9) Notice that there was no error, and the bib record was updated. 10) Sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 21:00:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 19:00:07 +0000 Subject: [Koha-bugs] [Bug 2720] Fines that debar automatically, should undebar automatically when paid. In-Reply-To: <bug-2720-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2720-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2720-70-QG3oYtdkwH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 --- Comment #5 from Owen Leonard <oleonard at myacpl.org> --- (In reply to comment #4) > I would say we keep borrowers.debarred, but convert it to a boolean value. Convert it *back* to a boolean value! And move the date information into borrower_debarment? > We can then have that value updated each time the debarments table is > altered. Which is when? Is there a line in borrower_debarment for each overdue item which is past the limit? And the table is reviewed each time an item is renewed or checked in?+ > I believe we will then need a nightly cronjob to remove expired > debarments and update borrowers.debarred. I don't understand. Are we talking about a cron job or is this something which updates each time something is checked in or renewed? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 21:02:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 19:02:56 +0000 Subject: [Koha-bugs] [Bug 8386] Error in duplicate detection message for authorities In-Reply-To: <bug-8386-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8386-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8386-70-vEuqcx7xLJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8386 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE --- Comment #8 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Tomas already fixed this, and the patch is signed off, I just missed it when I was looking yesterday. *** This bug has been marked as a duplicate of bug 8520 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 21:02:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 19:02:56 +0000 Subject: [Koha-bugs] [Bug 8520] Authorities display incorrectly in staff results In-Reply-To: <bug-8520-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8520-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8520-70-825WmcNhh5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8520 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #28 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- *** Bug 8386 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 21:12:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 19:12:59 +0000 Subject: [Koha-bugs] [Bug 8339] div id="login" should be id="login_controls" in header.inc In-Reply-To: <bug-8339-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8339-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8339-70-vSNzR4UoPt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8339 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Owen Leonard <oleonard at myacpl.org> --- (In reply to comment #4) > This should not cause any strange repositioning of the control set in the > header div on the right. It may not be pixel identical, but generally should > not look vastly different. It doesn't have to look different at all! Instead of adding a new definition for #login_controls, change the ID of the original declaration for #login at line 161: #login { position : absolute; right : .5em; } Change #login to #login_controls. The Koha login form will be unaffected because there is a separate stylesheet which defines #login for that page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 21:18:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 19:18:41 +0000 Subject: [Koha-bugs] [Bug 5705] search 4XX fields in authorities and link to 1XX In-Reply-To: <bug-5705-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5705-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5705-70-rLtAShrMTR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5705 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- *** This bug has been marked as a duplicate of bug 8209 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 21:18:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 19:18:41 +0000 Subject: [Koha-bugs] [Bug 8209] "Did you mean?" suggestions based on authorities In-Reply-To: <bug-8209-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8209-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8209-70-tpD3jLFXJJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8209 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eb at efdss.org --- Comment #12 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- *** Bug 5705 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 21:20:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 19:20:41 +0000 Subject: [Koha-bugs] [Bug 8751] New: printable version of holds queue printing different pages Message-ID: <bug-8751-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8751 Priority: P5 - low Change sponsored?: --- Bug ID: 8751 Assignee: oleonard at myacpl.org Summary: printable version of holds queue printing different pages Severity: normal Classification: Unclassified OS: All Reporter: nengard at gmail.com Hardware: All Status: NEW Version: master Component: Templates Product: Koha When printing the holds queue it's giving different numbers of results based on how you have the data sorted. Using the example I have: Initial Holds Queue: 122 items Unsorted, then print preview: 13 pages Sorted by Call #, then print preview: 4 pages Sorted by Title, then print preview: 12 pages Sorted by date, then print preview: 8 pages My guess is that the CSS that controls the printable version doesn't take in to account the sorting and that's screwing with things. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 21:24:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 19:24:12 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8236-70-Tmdw1SACCC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Owen Leonard <oleonard at myacpl.org> --- This appears to work as described in comment 4, but adding this to master without a system preference to turn it on and off would be an unwanted revision of circulation procedures for a lot of libraries (mine included). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 21:24:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 19:24:20 +0000 Subject: [Koha-bugs] [Bug 8339] div id="login" should be id="login_controls" in header.inc In-Reply-To: <bug-8339-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8339-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8339-70-HeeNJ6FekL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8339 --- Comment #6 from M. Tompsett <mtompset at hotmail.com> --- The problem is the way cascading works. Renaming in place won't work. It needs to be below the ".clearfix" class. I was struggling for hours when I renamed in place, all because of the .clearfix class. I could put it in front of the #login_controls at the top if I wanted it in place, but it made more sense to be located with the other class that shares the header div. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 21:28:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 19:28:23 +0000 Subject: [Koha-bugs] [Bug 8339] div id="login" should be id="login_controls" in header.inc In-Reply-To: <bug-8339-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8339-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8339-70-xBvXLIaofl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8339 --- Comment #7 from M. Tompsett <mtompset at hotmail.com> --- And to follow up... because it is before the .clearfix class definition. The current #login unpatched does nothing, as far as I can tell. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 23:28:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 21:28:56 +0000 Subject: [Koha-bugs] [Bug 6542] Degree symbol causes error in cataloging in IE In-Reply-To: <bug-6542-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6542-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6542-70-cbQAdHVZKb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6542 wajasu <matted-34813 at mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matted-34813 at mypacks.net --- Comment #3 from wajasu <matted-34813 at mypacks.net> --- I did the same as Owen and no problems saving. Maybe some NFC work done after 2012-06-29 has fixed it. I Used IE 8 on Win7. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 23:30:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 21:30:24 +0000 Subject: [Koha-bugs] [Bug 8508] Holds to Pull : Library dropdown options are erroneously concatenated by br tags In-Reply-To: <bug-8508-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8508-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8508-70-ePw0h55XA7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8508 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Holds to Pull : jQuery |Holds to Pull : Library |datatable dropdown not |dropdown options are |displaying correctly when |erroneously concatenated by |an item can be pulled from |br tags |multiple libraries | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 23:31:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 21:31:39 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8236-70-B1SJtvshla@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris at bigballofwax.co.nz> --- (In reply to comment #5) > This appears to work as described in comment 4, but adding this to master > without a system preference to turn it on and off would be an unwanted > revision of circulation procedures for a lot of libraries (mine included). http://www.quickmeme.com/meme/3qgz25/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 23:55:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 21:55:05 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-VAdpzmcFpW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 wajasu <matted-34813 at mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12039|0 |1 is obsolete| | --- Comment #40 from wajasu <matted-34813 at mypacks.net> --- Created attachment 12120 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12120&action=edit SIGNED-OFF-Bug-8215-Course-Reserves This patch adds a new feature enabling course reserves. - courses - course-reserves (items reserved for courses) - course-instructors (Teacher patron type) - visibility in holdings views Alot of work. Congratulations khall on your persistence. wajasu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 23:56:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 21:56:20 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-a98Z25MkLW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 wajasu <matted-34813 at mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 23:58:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 21:58:08 +0000 Subject: [Koha-bugs] [Bug 7068] autobarcode not working when duplicating patrons In-Reply-To: <bug-7068-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7068-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7068-70-LuRNQC0OUY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7068 Melia Meggs <melia at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12062|0 |1 is obsolete| | --- Comment #3 from Melia Meggs <melia at bywatersolutions.com> --- Created attachment 12121 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12121&action=edit Signed off patch Works as advertised. The autobarcode is filling in when duplicating a patron. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 10 23:58:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 21:58:23 +0000 Subject: [Koha-bugs] [Bug 7068] autobarcode not working when duplicating patrons In-Reply-To: <bug-7068-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7068-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7068-70-yI4U8Cjnks@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7068 Melia Meggs <melia at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |melia at bywatersolutions.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 00:00:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 22:00:43 +0000 Subject: [Koha-bugs] [Bug 8508] Holds to Pull : Library dropdown options are erroneously concatenated by br tags In-Reply-To: <bug-8508-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8508-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8508-70-ACnceqCZ43@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8508 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au |ity.org | --- Comment #1 from David Cook <dcook at prosentient.com.au> --- Created attachment 12122 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12122&action=edit Bug 8508 - Holds to Pull : Library dropdown options are erroneously concatenated by br tags While the new function I made works perfectly well, there might be a more efficient way of achieving the same outcome. I'm open to input, but it gets the job done. To Test Before Patching: 1) Create two items under the same bib record but with different home library locations. 2) Place a hold on the next available item (or two separate holds on the two separate items) *You'll notice the names of the two libraries in the field to the right of the hold's title. There is one library on each line, because they're "separated" by a linebreak <br> tag. *If you look at the drop-down menu at the bottom of the column, you will notice that the names of the two libraries have been concatenated together. If you look at the source, you will notice that there is a <br> tag that "glues" them together. 3) Apply the patch 4) Refresh your page and now you will see that the drop-down menu has separated those options, that there are no duplication of options, and that they have been sorted in alphabetical order. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 00:41:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 22:41:42 +0000 Subject: [Koha-bugs] [Bug 3456] Serials receipt note In-Reply-To: <bug-3456-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3456-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3456-70-ENE5DmJi5O@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3456 Melia Meggs <melia at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11738|0 |1 is obsolete| | --- Comment #5 from Melia Meggs <melia at bywatersolutions.com> --- Created attachment 12123 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12123&action=edit [Signed off] Bug-3456-Show-internalnotes-when-receiving-serials.patch I followed the test plan and can see the non-public note on the serials receipt screen. When I deleted the non-public note, it disappeared. Looks good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 00:42:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 22:42:00 +0000 Subject: [Koha-bugs] [Bug 3456] Serials receipt note In-Reply-To: <bug-3456-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3456-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3456-70-Ky5K6KNqS4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3456 Melia Meggs <melia at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |melia at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 00:55:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 22:55:15 +0000 Subject: [Koha-bugs] [Bug 8598] No patron image or home library on Files & Statistics tabs In-Reply-To: <bug-8598-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8598-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8598-70-EW3fXoogLw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8598 Melia Meggs <melia at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12058|0 |1 is obsolete| | --- Comment #4 from Melia Meggs <melia at bywatersolutions.com> --- Created attachment 12124 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12124&action=edit [Signed off] Bug-8598-No-patron-image-or-home-library-on-Files-St.patch I tested this by going to the statistics tab on the patron record and to http://staff-melia.test.bywatersolutions.com/cgi-bin/koha/members/files.pl?borrowernumber=21, and I can see the patron image in both places. Signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 00:55:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 22:55:26 +0000 Subject: [Koha-bugs] [Bug 8598] No patron image or home library on Files & Statistics tabs In-Reply-To: <bug-8598-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8598-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8598-70-fmvZc58a9C@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8598 Melia Meggs <melia at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |melia at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 01:02:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 23:02:09 +0000 Subject: [Koha-bugs] [Bug 8733] Adding critic reviews to book pages In-Reply-To: <bug-8733-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8733-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8733-70-sBRHwz3KDe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8733 --- Comment #5 from idb <rahul at idreambooks.com> --- We have added a way to retrieve the "Readometer" based on ISBN number. See http://www.idreambooks.com/remotereadometer/9780143120537.html for example. Also, we would need help from the community for implementation as we are a bit thin on resources. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 01:24:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 10 Sep 2012 23:24:04 +0000 Subject: [Koha-bugs] [Bug 8034] Enable server print queue selection In-Reply-To: <bug-8034-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8034-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8034-70-FZSzCO7JXB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8034 --- Comment #19 from Srdjan Jankovic <srdjan at catalyst.net.nz> --- Printer queue value is the primary key for the table, and cannot be updated if the printer is assigned to a branch. mysql does not support ON UPDATE CASCADE I believe. It should leave a trail in the log files. It should eirher be documented, or printers should be given synthetic ids if that is a problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 05:39:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 03:39:34 +0000 Subject: [Koha-bugs] [Bug 8649] C4::Search needs a unit test In-Reply-To: <bug-8649-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8649-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8649-70-LwYlkK5Fff@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8649 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com --- Comment #16 from Mason James <mtj at kohaaloha.com> --- (In reply to comment #15) > Created attachment 11932 [details] > [SIGNED-OFF] bug 8649: quiet a variable use warning > > Signed-off-by: Galen Charlton <gmc at esilibrary.com> > Signed-off-by: wajasu <matted-34813 at mypacks.net> > Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> passing QA on this.. very nice work! $ koha-qa.pl -c 5 testing 5 commit(s) (applied to commit c8ef17e) * b085f62 bug 8649: quiet a variable use warning t/db_dependent/Search.t * b733df4 bug 8649: create a temp directory for Zebra for C4::Search tests t/db_dependent/Search.t t/db_dependent/data/var/lib/zebradb/authorities/key/README t/db_dependent/data/var/lib/zebradb/authorities/register/README t/db_dependent/data/var/lib/zebradb/authorities/shadow/README t/db_dependent/data/var/lib/zebradb/authorities/tmp/README t/db_dependent/data/var/lib/zebradb/biblios/key/README t/db_dependent/data/var/lib/zebradb/biblios/register/README t/db_dependent/data/var/lib/zebradb/biblios/shadow/README t/db_dependent/data/var/lib/zebradb/biblios/tmp/README t/db_dependent/data/var/lock/zebradb/authorities/README t/db_dependent/data/var/lock/zebradb/biblios/README t/db_dependent/data/var/log/README t/db_dependent/data/var/run/zebradb/README t/db_dependent/zebra_config.pl * bbfd59a bug 8649: make sure we can exit if a test fails t/db_dependent/Search.t * 2c46ed7 bug 8649: make sure C4::Context is fully mocked-up before tests t/db_dependent/Search.t * 3568a1f Bug 8649: Add unit test for C4::Search C4/Installer/PerlDependencies.pm t/db_dependent/Search.t t/db_dependent/data/var/lib/zebradb/authorities/key/README t/db_dependent/data/var/lib/zebradb/authorities/register/README t/db_dependent/data/var/lib/zebradb/authorities/shadow/README t/db_dependent/data/var/lib/zebradb/authorities/tmp/README t/db_dependent/data/var/lib/zebradb/biblios/key/README t/db_dependent/data/var/lib/zebradb/biblios/register/README t/db_dependent/data/var/lib/zebradb/biblios/shadow/README t/db_dependent/data/var/lib/zebradb/biblios/tmp/README t/db_dependent/data/var/lock/zebradb/authorities/README t/db_dependent/data/var/lock/zebradb/biblios/README t/db_dependent/data/var/log/README t/db_dependent/data/var/run/zebradb/README t/db_dependent/data/zebraexport/authority/exported_records t/db_dependent/data/zebraexport/biblio/exported_records t/db_dependent/zebra_config.pl * t/db_dependent/Search.t OK * t/db_dependent/zebra_config.pl OK * C4/Installer/PerlDependencies.pm OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 05:42:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 03:42:33 +0000 Subject: [Koha-bugs] [Bug 8649] C4::Search needs a unit test In-Reply-To: <bug-8649-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8649-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8649-70-q6ESbDYV6w@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8649 --- Comment #17 from Mason James <mtj at kohaaloha.com> --- > > passing QA on this.. very nice work! test completes with PASS, as expected... ;) $ prove t/db_dependent/Search.t t/db_dependent/Search.t .. ok All tests successful. Files=1, Tests=57, 4 wallclock secs ( 0.02 usr 0.01 sys + 2.20 cusr 0.63 csys = 2.86 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 06:05:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 04:05:07 +0000 Subject: [Koha-bugs] [Bug 8752] New: Log circulation renewal Message-ID: <bug-8752-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8752 Priority: P5 - low Change sponsored?: --- Bug ID: 8752 Assignee: koha-bugs at lists.koha-community.org Summary: Log circulation renewal Severity: enhancement Classification: Unclassified OS: All Reporter: amit.gupta at osslabs.biz Hardware: All Status: NEW Version: rel_3_10 Component: Transaction logs Product: Koha Renewal log is not capturing in action_logs table after renewal the books. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 06:05:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 04:05:37 +0000 Subject: [Koha-bugs] [Bug 8752] Log circulation renewal In-Reply-To: <bug-8752-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8752-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8752-70-1smi8E0KVT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8752 Amit Gupta <amit.gupta at osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |savitra.sirohi at osslabs.biz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 06:06:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 04:06:12 +0000 Subject: [Koha-bugs] [Bug 8752] Log circulation renewal In-Reply-To: <bug-8752-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8752-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8752-70-XlA26GjwKO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8752 Amit Gupta <amit.gupta at osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |amit.gupta at osslabs.biz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 06:12:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 04:12:07 +0000 Subject: [Koha-bugs] [Bug 8753] New: Add forgot password link to OPAC Message-ID: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Priority: P5 - low Change sponsored?: --- Bug ID: 8753 Assignee: oleonard at myacpl.org Summary: Add forgot password link to OPAC Severity: enhancement Classification: Unclassified OS: All Reporter: amit.gupta at osslabs.biz Hardware: All Status: NEW Version: rel_3_10 Component: OPAC Product: Koha If user forgot there password once click on add forgot password link to opac then system generate a new password and send to patron email address. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 06:12:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 04:12:42 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8753-70-VL9cw3eOtV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Amit Gupta <amit.gupta at osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |savitra.sirohi at osslabs.biz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 06:13:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 04:13:08 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8753-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8753-70-MPL4toz0It@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Amit Gupta <amit.gupta at osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |amit.gupta at osslabs.biz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 06:18:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 04:18:22 +0000 Subject: [Koha-bugs] [Bug 8754] New: Cardnumber/accession number range when creating print batches in tools Message-ID: <bug-8754-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8754 Priority: P5 - low Change sponsored?: --- Bug ID: 8754 Assignee: gmcharlt at gmail.com Summary: Cardnumber/accession number range when creating print batches in tools Severity: enhancement Classification: Unclassified OS: All Reporter: amit.gupta at osslabs.biz Hardware: All Status: NEW Version: rel_3_10 Component: Tools Product: Koha Give ability to generate print batches on the basis of barcode range. for example barcode range: 100001-100099 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 06:49:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 04:49:29 +0000 Subject: [Koha-bugs] [Bug 8754] Cardnumber/accession number range when creating print batches in tools In-Reply-To: <bug-8754-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8754-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8754-70-0mMNZEgOwV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8754 Amit Gupta <amit.gupta at osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |savitra.sirohi at osslabs.biz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 06:49:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 04:49:46 +0000 Subject: [Koha-bugs] [Bug 8754] Cardnumber/accession number range when creating print batches in tools In-Reply-To: <bug-8754-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8754-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8754-70-iYdFTdyfT4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8754 Amit Gupta <amit.gupta at osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |amit.gupta at osslabs.biz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 07:07:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 05:07:26 +0000 Subject: [Koha-bugs] [Bug 8755] New: Need provision to see the history of currency conversion rate Message-ID: <bug-8755-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8755 Priority: P5 - low Change sponsored?: --- Bug ID: 8755 Assignee: koha-bugs at lists.koha-community.org Summary: Need provision to see the history of currency conversion rate Severity: enhancement Classification: Unclassified OS: All Reporter: vimal0212 at gmail.com Hardware: All Status: NEW Version: rel_3_10 Component: Acquisitions Product: Koha In Administration > Currency need provision to see the previous conversion rate entered. Display it as previous currency rate entries. This is essential for librarians to check currency conversion rate history. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 07:11:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 05:11:36 +0000 Subject: [Koha-bugs] [Bug 8756] New: Vendor details and price should carry over to item information. Message-ID: <bug-8756-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8756 Priority: P5 - low Change sponsored?: --- Bug ID: 8756 Assignee: koha-bugs at lists.koha-community.org Summary: Vendor details and price should carry over to item information. Severity: enhancement Classification: Unclassified OS: All Reporter: vimal0212 at gmail.com Hardware: All Status: NEW Version: rel_3_10 Component: Acquisitions Product: Koha When receiving a book in Acquisition module, details like price, vendor name, invoice name etc. should carry over to item information as bibliographic details. Otherwise librarian has to enter these information manually when cataloging items. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 07:24:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 05:24:31 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-vWWeVYRfjj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #41 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Kyle, sorry to reset this to 'failed qa', but I spotted a translation problem. You only add the new permissoins to the English files, which means they will not be available for anyone using not the English sample files. Could you add them to the other languages as well please? You don't have to translate the descriptions - translators will take care of it. But this way functionality is there and it's easier to fix a missing translation than to figure out a missing permission. I found some other minor things, but wanted to note them: Another request I have would be to add some documentation to your new tables - I am sure Nicole would get to it sometime, but I think it would much easier for you to do. Some of the templates don't follow the capitalization rules (example: Course Reserves) I am wondering about some changes that don't seem to belong to the course reserves module: Example: maninvoice.tt: //<![CDATA[ $(document).ready(function(){ - $("fieldset.rows input").keydown(function(e){ return checkEnter(e); }); + $("fieldset.rows input").addClass("noEnterSubmit"); Can you explain why the change? Maybe this should be a separate bug as it seems to change a general pattern that is used in different files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 07:38:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 05:38:42 +0000 Subject: [Koha-bugs] [Bug 8756] Vendor details and price should carry over to item information. In-Reply-To: <bug-8756-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8756-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8756-70-9SaihsrXIr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8756 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|rel_3_10 |master --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi vimal, I am not sure, but I think at least a part of that functionality is already available. Have you checked current master for the behaviour there? I don't think the bibliographic record is the right place to store this information, as you will order the same book from different vendors to different prices over time - but I am also not sure that's what you meant. We have some better linking between acquisition and item information now, most of it is placed on the 'items' tab when you look at a detail page in the staff interface. So not sure all the information has to be in the item - maybe it's enough if it's pulled together for display. I am also resetting this to 'master' - because new enhancements should always be filed against master, the version it will be in is set by the RM and RMaints. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 07:42:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 05:42:47 +0000 Subject: [Koha-bugs] [Bug 8755] Need provision to see the history of currency conversion rate In-Reply-To: <bug-8755-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8755-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8755-70-E8syLwiBAe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8755 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|rel_3_10 |master --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Vimal, how is this related bug 7571? Is it a duplicate or adding to the functionality intended there? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 07:50:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 05:50:35 +0000 Subject: [Koha-bugs] [Bug 8523] Authority hierarchies only support UNIMARC In-Reply-To: <bug-8523-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8523-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8523-70-C6ZGg4aHUi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11885|0 |1 is obsolete| | Attachment #12083|0 |1 is obsolete| | Attachment #12084|0 |1 is obsolete| | Attachment #12086|0 |1 is obsolete| | Attachment #12089|0 |1 is obsolete| | Attachment #12092|0 |1 is obsolete| | Attachment #12100|0 |1 is obsolete| | Attachment #12101|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 12125 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12125&action=edit [SIGNED-OFF] Bug 8523: Display auth hierarchies w/all marcflavours This commit adds support for displaying authority hierarchies for all flavours of MARC, not just UNIMARC. Display now uses the jQuery jstree plugin, selected with the help of Owen Leonard, resulting in a much faster experience for users. Be aware that the jstree file uses tabs rather than 4-space indentation, which I left as-is so as to make it easier to integrate upstream releases in the future. To test: 1) Enable the AuthDisplayHierarchy syspref 2) Create authority records with a hierarchy of see also fields (in MARC21/NORMARC, you'll be using 5xx fields for this, with a subfield $w=g for broader terms and subfield $w=h for narrower terms) 3) View the authorities in the OPAC, noting the hierarchical view at the top of the page. This initial patch does not create bidirection linkages from unidirectional links in MARC21 authorities. This means that when moving up the authority hierarchy, lower levels will disappear. This is intentional, as the first patch is intended merely to ensure that AuthDisplayHierarchy functions the same for all marcflavours. A future patch will add a cron job to generate the bidirectional linkages, once we are sure that the hierarchy functionality for UNIMARC and MARC21/NORMARC coexists peaceably. Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Resolved conflicts in updatedatabase.pl, sysprefs.sql and in one of the CSS files. Test plan: 1) Run t/AuthoritiesMarc.t New tests complete without any errors. 2) Make sure updatedatabase works correctly. Update works nicely, new system preference is also added to syspref.sql 3) Make sure new terms are translatable. Created new po files for de-DE and checked for new terms. All translations appear correctly. 4) Make sure everything works with AuthDisplayHieararchy OFF - Add authority - Edit authority - Delete authority 5) Test feature with AuthDisplayHieararchy ON - Add authority - Edit authority - Delete authority 6) Add a couple of hierarchically linked authorities Note: links have to be created in both directions Example: 151 $aGermany 551 $a Baden-W?rttemberg $w h 151 $aBaden-W?rttemberg 551 $a Konstanz $w h 551 $a Germany $w g 151 $aKonstanz 551 $a Baden-W?rttemberg $w g 551 $a F?rstenberg $w h 551 $a Paradies $w h 151 $a F?rstenberg 551 $a Konstanz $w g 151 $a Paradies 551 $a Konstanz $w g Tree shows up nicely above the authority record - in staff - in OPAC - on the normal view tab - on the MARC view tab 7) Checking the logs for warnings - no Javascript errors or warnings - no warnings or errors in log files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 07:51:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 05:51:07 +0000 Subject: [Koha-bugs] [Bug 8523] Authority hierarchies only support UNIMARC In-Reply-To: <bug-8523-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8523-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8523-70-IDD8QexGDe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 09:37:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 07:37:11 +0000 Subject: [Koha-bugs] [Bug 8757] New: Longer size text for authorised values "lib" Message-ID: <bug-8757-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8757 Priority: P5 - low Change sponsored?: --- Bug ID: 8757 Assignee: adrien.saurat at biblibre.com Summary: Longer size text for authorised values "lib" Severity: enhancement Classification: Unclassified OS: All Reporter: adrien.saurat at biblibre.com Hardware: All Status: ASSIGNED Version: master Component: Database Product: Koha Authorised Values have many uses, and, among others things, store in SUGGEST the potential "reasons" (then stored in the "suggestions" table) for which a suggestion can be refused. To give better informations to borrowers, some librairies would like to see longer "lib_opac" fields (the "lib" field should follow the movement, of course). Knowing the many uses of AV, and the fact that some languages may need more words than others ton convey a message, the length of these lib fields could be made longer (maybe 200 or 250 chars). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 09:44:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 07:44:30 +0000 Subject: [Koha-bugs] [Bug 8034] Enable server print queue selection In-Reply-To: <bug-8034-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8034-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8034-70-luVfmugKIe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8034 --- Comment #20 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to comment #19) > Printer queue value is the primary key for the table, and cannot be updated > if the printer is assigned to a branch. mysql does not support ON UPDATE > CASCADE I believe. It seems it does: http://dev.mysql.com/doc/refman/5.5/en/innodb-foreign-key-constraints.html "CASCADE: Delete or update the row from the parent table, and automatically delete or update the matching rows in the child table. Both ON DELETE CASCADE and ON UPDATE CASCADE are supported" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 10:10:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 08:10:13 +0000 Subject: [Koha-bugs] [Bug 7993] saved report with hierarchies In-Reply-To: <bug-7993-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7993-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7993-70-o8bs6L35pa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7993 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.poulain at biblibre.com --- Comment #18 from Paul Poulain <paul.poulain at biblibre.com> --- Patch tested with a sandbox, by Delaye Stephane <stephane.delaye at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 10:10:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 08:10:29 +0000 Subject: [Koha-bugs] [Bug 7993] saved report with hierarchies In-Reply-To: <bug-7993-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7993-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7993-70-TJYAO9sVZi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7993 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12095|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 10:10:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 08:10:35 +0000 Subject: [Koha-bugs] [Bug 7993] saved report with hierarchies In-Reply-To: <bug-7993-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7993-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7993-70-qFnqrWuXIR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7993 --- Comment #19 from Paul Poulain <paul.poulain at biblibre.com> --- Created attachment 12126 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12126&action=edit Bug 7993: Save reports with Group/Subgroup hierarchy This should make saved reports more manageable. Group/Subgroup hierarchy is stored in authorised_values, categories REPORT_GROUP and REPORT_SUBGROUP, connected by REPORT_SUBGROUP.lib_opac -> REPORT_GROUP.authorised_value Database changes: * authorised_values: expanded category to 16 chars * created default set of REPORT_GROUP authorised values to match hardcoded report areas * reports_dictionary: replaced area int with report_area text, converted values * saved_sql: added report_area, report_group and report_subgroup; report_area is not currently used, saved for the record C4/Reports/Guided.pm: * Replaced Area numeric values with the mnemonic codes * get_report_areas(): returns hardcoded areas list * created get_report_areas(): returns full hierarchy (groups with belonging subgroups) * save_report(): changed iterface, accepts fields hashref as input * update_sql(): changed iterface, accepts id and fields hashref as input * get_saved_reports():] - join to authorised_values to pick group and subgroup name - accept group and subgroup filter params * get_saved_report(): - changed iterface, return record hashref - join to authorised_values to pick group and subgroup name * build_authorised_value_list(): new sub, moved code from reports/guided_reports.pl * Updated interfaces in: cronjobs/runreport.pl, svc/report, opac/svc/report: get_saved_report() reports/dictionary.pl: get_report_areas() reports/guided_reports.pl reports/guided_reports_start.tt: * Reports list: - added group/subgroup filter - display area/group/subgroup for the reports * Create report wizard: - carry area to the end - select group and subgroup when saving the report; group defaults to area, useful when report groups match areas * Update report and Create from SQL: added group/subgroup * Amended reports/guided_reports.pl accordingly Conflicts: C4/Reports/Guided.pm admin/authorised_values.pl installer/data/mysql/kohastructure.sql installer/data/mysql/updatedatabase.pl koha-tmpl/intranet-tmpl/prog/en/modules/reports/dictionary.tmpl koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tmpl misc/cronjobs/runreport.pl reports/dictionary.pl reports/guided_reports.pl Signed-off-by: Delaye Stephane <stephane.delaye at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 11:18:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 09:18:46 +0000 Subject: [Koha-bugs] [Bug 8757] Longer size text for authorised values "lib" In-Reply-To: <bug-8757-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8757-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8757-70-vupdMgX4qA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8757 --- Comment #1 from Adrien SAURAT <adrien.saurat at biblibre.com> --- Created attachment 12127 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12127&action=edit proposed patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 11:32:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 09:32:05 +0000 Subject: [Koha-bugs] [Bug 8755] Need provision to see the history of currency conversion rate In-Reply-To: <bug-8755-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8755-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8755-70-7OJBv7Z1g1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8755 --- Comment #2 from vimal kumar <vimal0212 at gmail.com> --- Yes, Now i knew that this is a duplicate entry. Pls remove it. Regards, Vimal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 11:32:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 09:32:30 +0000 Subject: [Koha-bugs] [Bug 8755] Need provision to see the history of currency conversion rate In-Reply-To: <bug-8755-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8755-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8755-70-9TaDyTjDQ9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8755 vimal kumar <vimal0212 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 11:39:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 09:39:22 +0000 Subject: [Koha-bugs] [Bug 7571] Maintain exchange rate history In-Reply-To: <bug-7571-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7571-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7571-70-ezWkd9PLOo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7571 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vimal0212 at gmail.com --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 8755 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 11:39:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 09:39:21 +0000 Subject: [Koha-bugs] [Bug 8755] Need provision to see the history of currency conversion rate In-Reply-To: <bug-8755-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8755-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8755-70-jJZ8trkYAS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8755 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** This bug has been marked as a duplicate of bug 7571 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 13:24:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 11:24:37 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-anwRQOCEL3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #42 from Kyle M Hall <kyle at bywatersolutions.com> --- > You only add the new permissoins to the English files, which means they will > not be available for anyone using not the English sample files. Could you > add them to the other languages as well please? You don't have to translate > the descriptions - translators will take care of it. But this way > functionality is there and it's easier to fix a missing translation than to > figure out a missing permission. Will do. > I found some other minor things, but wanted to note them: > > Another request I have would be to add some documentation to your new tables > - I am sure Nicole would get to it sometime, but I think it would much > easier for you to do. Will do. I'll just add the documentation to the body of my followup patch. > Some of the templates don't follow the capitalization rules (example: Course > Reserves) Will do. > I am wondering about some changes that don't seem to belong to the course > reserves module: > > Example: maninvoice.tt: > //<![CDATA[ > $(document).ready(function(){ > - $("fieldset.rows input").keydown(function(e){ return checkEnter(e); }); > + $("fieldset.rows input").addClass("noEnterSubmit"); > > Can you explain why the change? Maybe this should be a separate bug as it > seems to change a general pattern that is used in different files. Please look at comments 24 and 25. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 13:50:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 11:50:30 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-8b6vuE1Tn3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #43 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12128 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12128&action=edit Bug 8215 - Add Course Reserves - Followup This follow adds the following: * New flags and permissions for each language * Fixes capitalization issues * Document new tables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 13:50:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 11:50:43 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-jACUszM16d@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 13:55:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 11:55:09 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-EsYvDkh15J@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #44 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- (In reply to comment #42) > > You only add the new permissoins to the English files, which means they will > > not be available for anyone using not the English sample files. Could you > > add them to the other languages as well please? You don't have to translate > > the descriptions - translators will take care of it. But this way > > functionality is there and it's easier to fix a missing translation than to > > figure out a missing permission. > > Will do. For future reference, there is a unit test that will catch this- xt/permissions.t. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 13:57:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 11:57:23 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-CRdvzuXtTU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #63 from Kyle M Hall <kyle at bywatersolutions.com> --- What we really need is a 'system preference validator' in Koha. I recall there are other preference dependencies, so it would not only be useful for this. We could just add a warning to mainpage.pl for these things instead. So if PatronSelfRegistration is enabled, but PatronSelfRegistrationUseTemporaryStatus is empty, a warning will be written out on mainpage.pl. At the moment, these issues are only covered by documentation. Kyle (In reply to comment #61) > (In reply to comment #59) > > > - opac-memberentry.pl: Use of uninitialized value in pattern match (m//) at > > > /home/oleonard/kohaclone/C4/SQLHelper.pm line 418., referer: > > > http://localhost:88 > > > > > > - opac-memberentry.pl: DBD::mysql::st execute failed: Cannot add or update a > > > child row: a foreign key constraint fails (`koha`.`borrowers`, CONSTRAINT > > > `borrowers_ibfk_1` FOREIGN KEY (`categorycode`) REFERENCES `categories` > > > (`categorycode`)) at /home/oleonard/kohaclone/C4/SQLHelper.pm line 168., > > > referer: http://localhost:88/cgi-bin/koha/opac-memberentry.pl > > > I figured it out: I cleared the PatronSelfRegistration preferences for > testing and didn't put in a patron category for > PatronSelfRegistrationUseTemporaryStatus. How might we deal with this > possible omission? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 13:58:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 11:58:35 +0000 Subject: [Koha-bugs] [Bug 8757] Longer size text for authorised values "lib" In-Reply-To: <bug-8757-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8757-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8757-70-0sMnR0nZFt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8757 Adrien SAURAT <adrien.saurat at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 14:13:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 12:13:10 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-t829GkdT2U@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12116|0 |1 is obsolete| | --- Comment #64 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12129 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12129&action=edit Bug 7067 - OPAC Borrower Self Registration - Followup -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 14:13:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 12:13:36 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-CcPfnTm7wZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 14:25:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 12:25:07 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-BsjDhP2Tbn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #65 from Kyle M Hall <kyle at bywatersolutions.com> --- This should be fixed in my new followup. (In reply to comment #62) > New issue: Submitting a change to an existing patron's home library works in > that approving the change will correctly update the record, but the line > doesn't show up in the list of fields which will be updated on > members/members-update.pl. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 14:26:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 12:26:19 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8236-70-C6dm7UJjMU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 --- Comment #7 from Owen Leonard <oleonard at myacpl.org> --- (In reply to comment #6) > http://www.quickmeme.com/meme/3qgz25/ Adding a system preference for every little detail gets tiresome, but what alternative do we have when a proposed change to software equals a proposed change to library circulation policy? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 14:55:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 12:55:29 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: <bug-8367-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8367-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8367-70-zRVhJBEuqQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 --- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 12130 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12130&action=edit Bug 8367: Add more granular level for ReservesMaxPickUpDelay This patch adds: - a new column in the issuing rules - a new field issuingrules.holdspickupdelay You can now specify a pickup delay for an hold function of a patron category and/or a item type and/or a library. To test: Check there is no regression with a normal reserve workflow. Add one or more issuingrules. In 4 templates, you can see the max pickup delay for an hold (circ/circulation.tt, circ/waitingreserves.tt, members/moremember.tt, opac-user.tt). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 15:04:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 13:04:21 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: <bug-8367-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8367-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8367-70-esI4I62yXS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |jonathan.druart at biblibre.co | |m Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 15:05:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 13:05:53 +0000 Subject: [Koha-bugs] [Bug 8758] New: Code seems useless in circ/returns.pl Message-ID: <bug-8758-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8758 Priority: P5 - low Change sponsored?: --- Bug ID: 8758 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: Code seems useless in circ/returns.pl Severity: enhancement Classification: Unclassified OS: All Reporter: jonathan.druart at biblibre.com Hardware: All Status: NEW Version: unspecified Component: Circulation Product: Koha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 15:07:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 13:07:38 +0000 Subject: [Koha-bugs] [Bug 8758] Code seems useless in circ/returns.pl In-Reply-To: <bug-8758-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8758-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8758-70-qCzxny9jqw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8758 --- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 12131 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12131&action=edit Bug 8758: Remove useless code in circ/returns.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 15:08:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 13:08:41 +0000 Subject: [Koha-bugs] [Bug 8758] Code seems useless in circ/returns.pl In-Reply-To: <bug-8758-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8758-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8758-70-L0M75ntLD8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8758 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m --- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> --- Could someone confirm this code is unused ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 15:15:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 13:15:59 +0000 Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title with borrower's age without using categories In-Reply-To: <bug-7621-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7621-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7621-70-cldJ5ZbItO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11939|0 |1 is obsolete| | --- Comment #64 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 12132 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12132&action=edit Bug 7621: Followup: FIX warnings "Scalar value @values[$take] better written as $values[$take]" The previous patch introduces some perl warnings in log -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 15:16:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 13:16:24 +0000 Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title with borrower's age without using categories In-Reply-To: <bug-7621-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7621-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7621-70-NKG3clXRGS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 15:16:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 13:16:31 +0000 Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title with borrower's age without using categories In-Reply-To: <bug-7621-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7621-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7621-70-laNCG8USHT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 15:30:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 13:30:43 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-Y92gKu90bD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #66 from Owen Leonard <oleonard at myacpl.org> --- (In reply to comment #63) > We could just add a warning to mainpage.pl for these things instead. So if > PatronSelfRegistration is enabled, but > PatronSelfRegistrationUseTemporaryStatus is empty, a warning will be written > out on mainpage.pl. Maybe we could make display of the "register" link in the OPAC dependent on PatronSelfRegistrationUseTemporaryStatus being defined? And now that I think about it, shouldn't this preference be "PatronSelfRegistrationDefaultCategory" ? It's required, so it's not as if we're saying "use this temporary category if you want to." -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 15:59:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 13:59:55 +0000 Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title with borrower's age without using categories In-Reply-To: <bug-7621-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7621-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7621-70-h3iH9yyvbN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12132|0 |1 is obsolete| | --- Comment #65 from Marc V?ron <veron at veron.ch> --- Created attachment 12133 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12133&action=edit [SIGNED-OFF] Bug 7621: Followup: FIX warnings "Scalar value @values[$take] better written as $values[$take]" The previous patch introduces some perl warnings in log Signed-off-by: Marc Veron <veron at veron.ch> Tested with age restriction scenarios I used for development. Still works as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 15:59:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 13:59:57 +0000 Subject: [Koha-bugs] [Bug 5155] Question marks cause problems for BiblioAddsAuthorities In-Reply-To: <bug-5155-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5155-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5155-70-geQOnfvpPA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5155 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |fridolyn.somers at biblibre.co | |m Resolution|--- |DUPLICATE --- Comment #1 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> --- *** This bug has been marked as a duplicate of bug 5410 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 15:59:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 13:59:57 +0000 Subject: [Koha-bugs] [Bug 5410] "Right truncation not supported" error when running link_bibs_to_authorities.pl In-Reply-To: <bug-5410-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5410-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5410-70-FbTZsHO8LO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5410 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |camins at numismatics.org --- Comment #5 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> --- *** Bug 5155 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 16:01:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 14:01:37 +0000 Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title with borrower's age without using categories In-Reply-To: <bug-7621-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7621-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7621-70-ycY7JDjamu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #66 from Marc V?ron <veron at veron.ch> --- Thanks for the follow up, Jonathan. Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 16:23:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 14:23:18 +0000 Subject: [Koha-bugs] [Bug 8759] New: Add labels for library and sorting on opac advanced search Message-ID: <bug-8759-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8759 Priority: P5 - low Change sponsored?: --- Bug ID: 8759 Assignee: oleonard at myacpl.org Summary: Add labels for library and sorting on opac advanced search Severity: enhancement Classification: Unclassified OS: All Reporter: kyle at bywatersolutions.com Hardware: All Status: NEW Version: master Component: OPAC Product: Koha We've had reports of patrons being confused by the lack of labels directly attached to the library and sorting pulldowns on the OPAC advanced search. It would be helpful if these pulldowns had explicit labels. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 16:23:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 14:23:43 +0000 Subject: [Koha-bugs] [Bug 8759] Add labels for library and sorting on opac advanced search In-Reply-To: <bug-8759-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8759-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8759-70-8dWjrnLOK3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8759 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12134 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12134&action=edit Bug 8759 - Add labels for library and sorting on opac advanced search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 16:24:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 14:24:09 +0000 Subject: [Koha-bugs] [Bug 8759] Add labels for library and sorting on opac advanced search In-Reply-To: <bug-8759-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8759-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8759-70-bcbR77Ryhu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8759 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 16:28:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 14:28:54 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-uEicWzEAEd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #67 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to comment #66) > (In reply to comment #63) > > > We could just add a warning to mainpage.pl for these things instead. So if > > PatronSelfRegistration is enabled, but > > PatronSelfRegistrationUseTemporaryStatus is empty, a warning will be written > > out on mainpage.pl. > > Maybe we could make display of the "register" link in the OPAC dependent on > PatronSelfRegistrationUseTemporaryStatus being defined? > > And now that I think about it, shouldn't this preference be > "PatronSelfRegistrationDefaultCategory" ? It's required, so it's not as if > we're saying "use this temporary category if you want to." That is a good idea, and a good rename as well. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 16:43:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 14:43:10 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-MPaWvrxlQY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #68 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12135 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12135&action=edit Bug 7067 - OPAC Borrower Self Registration - Followup - Rename PatronSelfRegistrationUseTemporaryStatus to PatronSelfRegistrationDefaultCategory -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 16:51:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 14:51:40 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-MsUPuHfZLW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #69 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12136 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12136&action=edit Bug 7067 - allow patron self registration via the opac - Followup - Hide register link unless PatronSelfRegistrationDefaultCategory is set. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 16:56:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 14:56:47 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-AcJXyBGMM2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #70 from Owen Leonard <oleonard at myacpl.org> --- If you submit a new registration via the OPAC and then reload the confirmation page (whether you're asked for email confirmation or not), you get duplicate patron records. The patron who required email confirmation gets duplicate fully-valid activation links. The patron who didn't require email confirmation gets newly-generated passwords on each reload but it doesn't appear that reloaded ones are valid. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 17:27:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 15:27:32 +0000 Subject: [Koha-bugs] [Bug 7068] autobarcode not working when duplicating patrons In-Reply-To: <bug-7068-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7068-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7068-70-ySRjZ0XlFn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7068 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12121|0 |1 is obsolete| | --- Comment #4 from Galen Charlton <gmcharlt at gmail.com> --- Created attachment 12137 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12137&action=edit patch with second signoff Patch with second signoff -- also reformatted the commit message. I've also confirmed that the patch applies cleanly and works in 3.8.x, and request that the RMaint consider cherry-picking this once it's applied to master. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 17:43:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 15:43:43 +0000 Subject: [Koha-bugs] [Bug 8652] There is no default value for the late orders In-Reply-To: <bug-8652-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8652-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8652-70-tCRZHHfluO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8652 MathildeF <mathilde.formery at ville-nimes.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathilde.formery at ville-nime | |s.fr --- Comment #3 from MathildeF <mathilde.formery at ville-nimes.fr> --- tested in a sandbox When I add a date in the field "Date from", I have an error message: Software error: Can not call method "strftime" without a package or object reference at / home / koha / src / Koha / DateUtils.pm line 119. " -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 18:02:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 16:02:10 +0000 Subject: [Koha-bugs] [Bug 8652] There is no default value for the late orders In-Reply-To: <bug-8652-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8652-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8652-70-iCIwu5YA2t@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8652 Colin Campbell <colin.campbell at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell at ptfs-europe. | |com --- Comment #4 from Colin Campbell <colin.campbell at ptfs-europe.com> --- The date handling is wrong. dt_from_string returns a DateTime object. there is no need for the xxx_iso variables. if you need the date as a string in iso format you can retrieve that using DateTime's methods -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 18:24:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 16:24:52 +0000 Subject: [Koha-bugs] [Bug 7241] circulation action logs record biblionumber instead of item number In-Reply-To: <bug-7241-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7241-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7241-70-e9qYYP7SPV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7241 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #27 from Galen Charlton <gmcharlt at gmail.com> --- (In reply to comment #24) > Well, Thinking of it a little bit more, I've reverted the patch. > > Having history badly broken for existing instances is really bad, because we > will never be able to fix the problem properly once action_logs contains > mixed informations (biblio & items) > > And I've an easy proposal to fix what can be fixed: > The following SQL: > UPDATE action_logs SET object=(SELECT itemnumber FROM items WHERE > biblionumber= action_logs.object LIMIT 1) WHERE module='CIRCULATION' AND > action in ('ISSUE','RETURN'); > > Set the 1st item number (as we can't know which item was circulated once > things have been anonymised). It's better than nothing. > > I propose that you submit a new patch including an updatedatabase with this > SQL As a possible supplement, how about tagging the object column with an indication of whether it's an old-style log of a biblionumber. E.g., UPDATE action_logs SET object = 'biblio ' || object WHERE module = 'CIRCULATION' AND action IN ('ISSUE', 'RETURN'); Then viewlog.pl could assume that if the value is tagged with a 'biblio ' prefix that it contains an bib number; if it isn't, it contains an item number. Doing it this way would mean that the logs are as accurate as possible. Another, farther-reaching option would be to add biblionumber and itemnumber columns to action_logs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 18:28:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 16:28:11 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-eegFDuVS4R@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #71 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12138 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12138&action=edit Bug 7067 - allow patron self registration via the opac - Followup - Add invalid token page -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 18:28:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 16:28:56 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-TQuEBDEzKd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #72 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to comment #70) > If you submit a new registration via the OPAC and then reload the > confirmation page (whether you're asked for email confirmation or not), you > get duplicate patron records. The patron who required email confirmation > gets duplicate fully-valid activation links. The patron who didn't require > email confirmation gets newly-generated passwords on each reload but it > doesn't appear that reloaded ones are valid. With email registration on, I'm not getting duplicate patrons. I just get the "Registration Complete" page with an empty username and password if I reload the page. That is safe, but it would be better to redirect to an 'invalid token' page instead. When not requiring email verification, I *do* get duplicate borrowers. I'm not sure if this situation has a solution. It's no different than the user hitting back and submitting the same data again. We could redirect to a new page, rather than loading the Registration Complete page directly from opac-memberentry.pl, but that just shifts the problem. Instead of reloading creating a duplicate patron, hitting back will. If anyone has any suggestions, please let me know. But as far as I can tell this is more of a HTTP problem than a Koha problem. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 18:30:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 16:30:34 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8236-70-GmeTQq8is8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 --- Comment #8 from Nicole C. Engard <nengard at gmail.com> --- I agree with Owen - sys prefs are the strength of Koha! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 18:45:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 16:45:40 +0000 Subject: [Koha-bugs] [Bug 8760] New: Phone number Field tags are reversed in patron record Message-ID: <bug-8760-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8760 Priority: P5 - low Change sponsored?: --- Bug ID: 8760 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: Phone number Field tags are reversed in patron record Severity: normal Classification: Unclassified OS: All Reporter: jesse at bywatersolutions.com Hardware: All Status: NEW Version: rel_3_8 Component: Patrons Product: Koha Created attachment 12139 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12139&action=edit Screen Shoot Phone number Field tags are reversed in patron record. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 18:46:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 16:46:50 +0000 Subject: [Koha-bugs] [Bug 8760] Phone number Field tags are reversed in patron record In-Reply-To: <bug-8760-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8760-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8760-70-t7Rcwm1Gyw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8760 --- Comment #1 from Jesse Maseto <jesse at bywatersolutions.com> --- Created attachment 12140 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12140&action=edit Screen Shoot 2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 19:07:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 17:07:32 +0000 Subject: [Koha-bugs] [Bug 8339] div id="login" should be id="login_controls" in header.inc In-Reply-To: <bug-8339-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8339-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8339-70-qmaIzXAdUM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8339 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11951|0 |1 is obsolete| | --- Comment #8 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 12141 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12141&action=edit Renamed login to login_controls in header.inc and staff-global.css Caching of CSS files is a testing nightmare! Test ---- Before: 1) login 2) firebug the top right section div, it should be "login". 3) logout After patch: 1) login 2) firebug the top right section div, it should be "login_controls". WARNING: Make sure to trigger a reload of the CSS, otherwise a stale cache will have to screaming for hours. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 19:08:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 17:08:33 +0000 Subject: [Koha-bugs] [Bug 5500] shelf browse changing bib record In-Reply-To: <bug-5500-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5500-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5500-70-X438QPcfAH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5500 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|pianohacker at gmail.com |oleonard at myacpl.org --- Comment #4 from Nicole C. Engard <nengard at gmail.com> --- Reassigning to default assignee since this hasn't been touched in 2 years and is still an issue. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 19:09:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 17:09:05 +0000 Subject: [Koha-bugs] [Bug 8339] div id="login" should be id="login_controls" in header.inc In-Reply-To: <bug-8339-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8339-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8339-70-6MwJxfy8a3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8339 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 19:27:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 17:27:03 +0000 Subject: [Koha-bugs] [Bug 8652] There is no default value for the late orders In-Reply-To: <bug-8652-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8652-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8652-70-w0lzbADoRi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8652 Colin Campbell <colin.campbell at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11640|0 |1 is obsolete| | --- Comment #5 from Colin Campbell <colin.campbell at ptfs-europe.com> --- Created attachment 12142 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12142&action=edit Proposed Amended Patch I took the liberty of amending the Koha::DateUtils calls. I'm sure the logic could be further cleaned up. Requires testing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 19:37:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 17:37:35 +0000 Subject: [Koha-bugs] [Bug 8742] Example uses perl 5.8 in Makefile.PL In-Reply-To: <bug-8742-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8742-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8742-70-My6rCU0Jl6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8742 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12079|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 12143 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12143&action=edit Changed hardcoded path for a programmatic one. Accidentally uploaded wrong version of the patch. Previous version didn't work in the case that /usr/share/perl/ wasn't in the @INC. This one does. Test case (before patch): /usr/share/perl/5.8 is printed. Test case (normally): /usr/share/perl/ should be in @INC, that version should print. Just hold down the enter key on 'perl Makefile.PL' Test case (bizarre): I purposefully inserted a @version=(); to force the push to execute. Because the only case where perl wouldn't have /usr/share/perl/ in the @INC is some strange OS with a non-standard perl configuration (like Windows ;) ). I then removed @version=(); after. Printing /usr/share/perl/5.10 is no worse than /usr/share/perl/5.8 in that context. It's just the 5.10 is more accurate version wise. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 19:49:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 17:49:46 +0000 Subject: [Koha-bugs] [Bug 8761] New: Correct compile time warnings in C4::Circulation Message-ID: <bug-8761-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8761 Priority: P5 - low Change sponsored?: --- Bug ID: 8761 Assignee: gmcharlt at gmail.com Summary: Correct compile time warnings in C4::Circulation Severity: minor Classification: Unclassified OS: All Reporter: colin.campbell at ptfs-europe.com Hardware: All Status: NEW Version: master Component: Architecture, internals, and plumbing Product: Koha A recent enhancement to C4::Circulation has introduced some ambiguous constructs which on current perls give compile time warnings with perl 5.16.0 or 5.16.1 (I've not tested with older) if you check compilation with perl -wc C4/Circulation.pm you get the following warnings Scalar value @values[$take] better written as $values[$take] at Circulation.pm line 985. Scalar value @alloweddate[0] better written as $alloweddate[0] at Circulation.pm line 991. Scalar value @alloweddate[1] better written as $alloweddate[1] at Circulation.pm line 993. Scalar value @alloweddate[2] better written as $alloweddate[2] at Circulation.pm line 993. Scalar value @alloweddate[2] better written as $alloweddate[2] at Circulation.pm line 994. Heres the doc from perlwarn (W syntax) You've used an array slice (indicated by @) to select a single element of an array. Generally it's better to ask for a scalar value (indicated by $). The difference is that $foo[&bar] always behaves like a scalar, both when assigning to it and when evaluating its argument, while @foo[&bar] behaves like a list when you assign to it, and provides a list context to its subscript, which can do weird things if you're expecting only one subscript. On the other hand, if you were actually hoping to treat the array element as a list, you need to look into how references work, because Perl will not magically convert between scalars and lists for you. See perlref. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 19:59:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 17:59:15 +0000 Subject: [Koha-bugs] [Bug 8761] Correct compile time warnings in C4::Circulation In-Reply-To: <bug-8761-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8761-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8761-70-bTc1Mh9ESs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8761 Colin Campbell <colin.campbell at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |colin.campbell at ptfs-europe. | |com --- Comment #1 from Colin Campbell <colin.campbell at ptfs-europe.com> --- Created attachment 12144 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12144&action=edit Proposed Patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 20:00:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 18:00:37 +0000 Subject: [Koha-bugs] [Bug 8761] Correct compile time warnings in C4::Circulation In-Reply-To: <bug-8761-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8761-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8761-70-7Y0Zhk7O1x@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8761 --- Comment #2 from Colin Campbell <colin.campbell at ptfs-europe.com> --- Doc is perldiag not perlwarn -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 20:09:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 18:09:10 +0000 Subject: [Koha-bugs] [Bug 8759] Add labels for library and sorting on opac advanced search In-Reply-To: <bug-8759-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8759-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8759-70-gwQTql8MLw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8759 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12134|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 12145 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12145&action=edit [SIGNED-OFF] Bug 8759 - Add labels for library and sorting on opac advanced search Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 20:09:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 18:09:47 +0000 Subject: [Koha-bugs] [Bug 8759] Add labels for library and sorting on opac advanced search In-Reply-To: <bug-8759-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8759-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8759-70-HOPJtpvlmm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8759 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 20:12:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 18:12:42 +0000 Subject: [Koha-bugs] [Bug 8339] div id="login" should be id="login_controls" in header.inc In-Reply-To: <bug-8339-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8339-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8339-70-bAozuTCQ0L@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8339 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12141|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 12146 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12146&action=edit [SIGNED-OFF] Bug 8339 - div id="login" should be id="login_controls" in header.inc After experiencing what I believe was stale CSS, I have implemented oleonard's suggested fix which does work. That is: header.inc change login to login_controls, and in staff-global.css change the #login to #login_controls. Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 20:13:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 18:13:13 +0000 Subject: [Koha-bugs] [Bug 8339] div id="login" should be id="login_controls" in header.inc In-Reply-To: <bug-8339-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8339-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8339-70-8JbxZVwhM7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8339 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 20:31:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 18:31:27 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8236-70-RMgqMSew2W@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 --- Comment #9 from Chris Cormack <chris at bigballofwax.co.nz> --- (In reply to comment #7) > (In reply to comment #6) > > http://www.quickmeme.com/meme/3qgz25/ > > Adding a system preference for every little detail gets tiresome, but what > alternative do we have when a proposed change to software equals a proposed > change to library circulation policy? That's precisely what I was saying. I find aversion to sysprefs a comical thing. Personally I contravene find it tiresome, it's dead easy to do. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 20:32:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 18:32:21 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8236-70-cJfWvObAF4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 --- Comment #10 from Chris Cormack <chris at bigballofwax.co.nz> --- Hehe auto correct turns don't even into contravene. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 20:56:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 18:56:03 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: <bug-7417-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7417-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7417-70-gdtRLQ6dKV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11366|0 |1 is obsolete| | --- Comment #46 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12147 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12147&action=edit Bug 7417: Include see from references in bibliographic searches This patch adds the Koha::Indexer::RecordNormalizer and Koha::Indexer::MARC::RecordNormalizer::EmbedSeeFromHeadings packages to enable the inclusion of alternate forms of headings in bibliographic searches. When the new syspref IncludeSeeFromInSearches is turned on (default is off) rebuild_zebra.pl will insert see from headings from authority records into bibliographic records when indexing, so that a search on an obsolete term will turn up relevant records. To test: 1) Enable IncludeSeeFromInSearches 2) Add a heading that has an alternate form to a record (for example, "Cooking" has the alternate form "Cookery," if you have authority records from LC) 3) Index the zebraqueue (or reindex if you haven't indexed your system yet) 4) Confirm that if you search for "Cookery" you get the record you just modified Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com> Rebased on master 5 August 2012 Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com> Rebased on master 11 September 2012 Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Also checked: - Verified database update works correctly - Checked system preference and its description - Checked staff/opac detail pages with feature on/off - Checked staff/opac search facets - Downloaded and tested records in various formats - Tried different searches for 'see from' entries of authorities - Ran all unit tests No problems found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 20:56:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 18:56:19 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: <bug-7417-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7417-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7417-70-g8Yv5WqfP1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11465|0 |1 is obsolete| | --- Comment #47 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12148 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12148&action=edit Bug 7417 follow-up: incorporate QA comments This patch incorporates the following QA comments: * Renames Koha::Authority to Koha::DataObject::Authority * Uses Modern::Perl instead of 'use strict; use warnings;' * perltidied all new files again * wrote an intelligent constructor for Koha::DataObject::Authority which takes a hash with the construction criteria * added rudimentary error handling in C4::AuthoritiesMarc::GetAuthority * added missing t/AuthoritiesMarc.t This patch also improves test coverage, and eliminates the need for a database to test the EmbedSeeFromHeadings RecordProcessor plugin. In order to make the Koha codebase more consistent, this patch switches the RecordProcessor and Koha::DataObject::Authority code to use the Moose-like syntax supported by Class::Accessor. Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Follow up passes test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 20:59:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 18:59:44 +0000 Subject: [Koha-bugs] [Bug 3462] Link see alsos in authorities In-Reply-To: <bug-3462-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3462-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3462-70-yWJh8rUaGO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3462 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11390|0 |1 is obsolete| | --- Comment #18 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12149 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12149&action=edit Bug 3462: Links in authorities should be hyperlinks Make see also links in both the OPAC and authority module search results into hyperlinks and not just textual strings. To test: 1. Do a search for an authority that will bring up a heading with a see also reference in the staff client and the OPAC. 2. Confirm that the see also references listed in the search results are now hyperlinks, which work. Also quiets an unnecessary warning about an uninitialized value. Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com> Rebased 26 July 2012 Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com> Rebased on master 1 August 2012 Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com> Rebased on master 6 August 2012 Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com> Rebased on master 11 September 2012 Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Patch works nicely and is a great improvement. Tests: - Checked links for existing and non existing "see alsos" give correct search results - Verified links show up for all "see alsos" in a result list - Verified links are properly linked with the correct names - Checked logs don't show errors -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 21:02:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 19:02:45 +0000 Subject: [Koha-bugs] [Bug 2060] Ability to import Authorities from Staff Client In-Reply-To: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2060-70-N2XeYsWdpD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2060 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11258|0 |1 is obsolete| | --- Comment #23 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12150 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12150&action=edit Bug 7475: Update configuration In order to make matching rules more useful for MARC21 authorities, this patch adds special indexes on previous see-from headings and LCCN. This patch does not change UNIMARC authority configuration in any way. Also modifies the Koha schema in preparation for adding authority import and matching to the Staging tools. To install: 1. Run installer/data/mysql/atomicupdate/importauthorities.pl 2. Update the following four files in your koha-dev: etc/zebradb/authorities/etc/bib1.att etc/zebradb/marc_defs/marc21/authorities/authority-koha-indexdefs.xml etc/zebradb/marc_defs/marc21/authorities/authority-zebra-indexdefs.xsl etc/zebradb/xsl/koha-indexdefs-to-zebra.xsl 3. Reindex your authorities: misc/migration_tools/rebuild_zebra.pl -a -r -v NOTE TO RM: this patch adds an atomicupdate file that needs to be incorporated into updatedatabase.pl if bug 7167 is not pushed. http://bugs.koha-community.org/show_bug.cgi?id=2060 Signed-off-by: Elliott Davis <elliott at bywatersolutions.com> Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com> Rebased on master 1 August 2012 Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com> Rebased on master 11 September 2012 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 21:02:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 19:02:58 +0000 Subject: [Koha-bugs] [Bug 2060] Ability to import Authorities from Staff Client In-Reply-To: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2060-70-gEfyptTwFX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2060 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11259|0 |1 is obsolete| | --- Comment #24 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12151 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12151&action=edit Bug 7475: Teach matching rules to handle authorities * Add the code necessary to handle authorities with matching rules and import batches. * Update all the scripts that use the matcher and import batch code to use the new API. * Add authority records to the matching rules interface in the staff client. http://bugs.koha-community.org/show_bug.cgi?id=2060 Signed-off-by: Elliott Davis <elliott at bywatersolutions.com> Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com> Rebased on latest master 11 September 2012 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 21:03:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 19:03:14 +0000 Subject: [Koha-bugs] [Bug 2060] Ability to import Authorities from Staff Client In-Reply-To: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2060-70-wt5IdhEKlB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2060 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11260|0 |1 is obsolete| | --- Comment #25 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12152 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12152&action=edit Bug 2060: Update command line MARC import scripts Expose authority import functionality to the command line import scripts, and rename them from commit_biblios_file.pl and stage_biblios_file.pl to commit_file.pl and stage_file.pl. To test (note that these instructions assume you have a MARC21 installation and are using the provided sample file): 1. Find a file of authorities (a sample file with MARC21 authorities is attached to bug 7475) and download it to your server 2. Stage the file using the following command (replace <filename> with the name of the file you saved in step 1): > misc/stage_file.pl --file <filename> --authorities 3. Note the batch number the script assigns to your batch 4. Commit the records using the following command (replace <batchnumber> with the batch number you made note of in step 3): > misc/commit_file.pl --batch-number <batchnumber> 5. Index the authorities Zebraqueue (or wait) 6. Confirm that the new authorities appear. 7. Create a matching rule with the following settings: Code: AUTHTEST Description: Personal name main entry Match threshold: 999 Record type: Authority record Search index: Heading-main Score: 1000 Tag: 100 Subfields: a Offset: 0 Length: 0 (note the ID of this matching rule) 8. Stage the authority file again, this time using the following command: > misc/stage_file.pl --file <filename> --authorities \ --match <matchingrule> 7. Revert the import with the following command: > misc/commit_file.pl --batch-number <batchnumber> --revert 8. Index the authorities Zebraqueue (or wait) 9. Confirm that the records have been removed 10. Import an authority record with the Stage MARC/Manage staged MARC tools in exactly the way you would for a bibliographic record, but choose "Authority" instead of "Bibliographic" for the record type. Signed-off-by: Elliott Davis <elliott at bywatersolutions.com> Testing plan delivers as it should. Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com> Rebased on latest master 11 September 2012 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 21:30:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 19:30:22 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-HKoNiwQcPF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #45 from Kyle M Hall <kyle at bywatersolutions.com> --- I'm going to set this to signed off for now, as the followup does not affect the functionality in any way. It's just changing the name of one system pref, and changing the capitalization of some words. If anyone feels this needs it's own sign-off, please reset the status. Thanks go to wajasu for the extensive and stringent testing this patch has gone through! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 21:37:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 19:37:04 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-w02415SjJP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12129|0 |1 is obsolete| | Attachment #12135|0 |1 is obsolete| | Attachment #12136|0 |1 is obsolete| | Attachment #12138|0 |1 is obsolete| | --- Comment #73 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12153 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12153&action=edit Bug 7067 - OPAC Borrower Self Registration - Followup * Rename PatronSelfRegistrationUseTemporaryStatus to PatronSelfRegistrationDefaultCategory * Allow patron self registration via the opac - Followup - Hide register link unless PatronSelfRegistrationDefaultCategory is set. * Allow patron self registration via the opac - Followup - Add invalid token page -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 21:38:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 19:38:08 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-8holiR54Na@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12153|0 |1 is obsolete| | --- Comment #74 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12154 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12154&action=edit Bug 7067 - OPAC Borrower Self Registration - Followup * Rename PatronSelfRegistrationUseTemporaryStatus to PatronSelfRegistrationDefaultCategory * Hide register link unless PatronSelfRegistrationDefaultCategory is set. * Add invalid token page -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 22:30:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 20:30:35 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8236-70-C6g5Jw3ebC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 --- Comment #11 from Nicole C. Engard <nengard at gmail.com> --- I was so confused until I read that it was an autocorrect error! :) I'm with you - I have no idea why people want fewer of them - the librarians love the control and it's why one system can be used around the world :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 22:43:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 20:43:18 +0000 Subject: [Koha-bugs] [Bug 8740] Serials Claims should be exportable all at once In-Reply-To: <bug-8740-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8740-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8740-70-f9zr2t7UAs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8740 --- Comment #2 from Joy Nelson <joy at bywatersolutions.com> --- Created attachment 12155 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12155&action=edit [SIGNED OFF]enh bug 8740 Serials Claims should be exportable all at once Signed-off-by: Joy Nelson <joy at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 22:46:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 20:46:42 +0000 Subject: [Koha-bugs] [Bug 8740] Serials Claims should be exportable all at once In-Reply-To: <bug-8740-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8740-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8740-70-q08bk3RJsR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8740 Joy Nelson <joy at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |joy at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 22:46:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 20:46:48 +0000 Subject: [Koha-bugs] [Bug 8740] Serials Claims should be exportable all at once In-Reply-To: <bug-8740-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8740-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8740-70-tBLsFmKClQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8740 Brendan Gallagher <brendan at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12068|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 23:38:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 21:38:23 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7143-70-y1gv8EHVrx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #52 from Melia Meggs <melia at bywatersolutions.com> --- Created attachment 12156 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12156&action=edit Bug 7143: Adding Kathryn Tyree to the history and About page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 23:38:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 21:38:45 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7143-70-hdANPSCpDb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Melia Meggs <melia at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff CC| |melia at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 11 23:44:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 21:44:49 +0000 Subject: [Koha-bugs] [Bug 8750] Chronological terms authorities not correctly indexed In-Reply-To: <bug-8750-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8750-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8750-70-daF3pGm2Ky@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8750 Joy Nelson <joy at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com --- Comment #3 from Joy Nelson <joy at bywatersolutions.com> --- I attempted to sign off on this patch. I first tried searching for authority records on master and was unable to retrieve any authority records. (I can search for authority records on 3.8.4) More testing required on this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 01:29:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 11 Sep 2012 23:29:23 +0000 Subject: [Koha-bugs] [Bug 7619] 3M self checkout don't work in France In-Reply-To: <bug-7619-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7619-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7619-70-BEXCi3gMfH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7619 --- Comment #23 from Chris Cormack <chris at bigballofwax.co.nz> --- I can confirm this, however it can be fixed by just switching the variable. Having it in the SIPconfig.xml is still the best idea. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 03:14:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 01:14:11 +0000 Subject: [Koha-bugs] [Bug 5534] koha does not ignore punctuation when searching In-Reply-To: <bug-5534-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5534-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5534-70-rR3fwQgZRs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5534 wajasu <matted-34813 at mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matted-34813 at mypacks.net --- Comment #3 from wajasu <matted-34813 at mypacks.net> --- Not sure if this applies. I was doing search testing even with fuzzy search. I tried "1000 things i love about" with no results, though the title was "1,000 things i love". I t only found "1,000 things i love". So comma's or other locale specific formatting in words that are all digits might be a similiar use case. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 03:20:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 01:20:39 +0000 Subject: [Koha-bugs] [Bug 8034] Enable server print queue selection In-Reply-To: <bug-8034-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8034-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8034-70-MHYbrOa6Hn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8034 Srdjan Jankovic <srdjan at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12096|0 |1 is obsolete| | --- Comment #21 from Srdjan Jankovic <srdjan at catalyst.net.nz> --- Created attachment 12157 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12157&action=edit bug_8034: Restored network printer maintenance and selection This patch is just for restoring printer maintenance and selection, not for priting itself. It is just a preparation step. * Added UsePrintQueues syspref. If set to No, no printer info will be displayed/used * Database changes: - printers table PRIMARY KEY is now printqueue. It is more natural. We should really have a synthetic id, but printqueue is good enough - branches.branchprinter is a FOREIGN KEY to printers.printqueue * Created C4::Auth::get_user_printer() function that will return appropriate printer. In order of preference: - session selected - logged in branch branchprinter * Moved printer functions to C4::Printer * Restored printer maint/selection in admin zone UsePrintQueues permitting * Restored printer selection in circ/selectbranchprinter.pl UsePrintQueues permitting Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 03:22:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 01:22:19 +0000 Subject: [Koha-bugs] [Bug 8034] Enable server print queue selection In-Reply-To: <bug-8034-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8034-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8034-70-R0RgYRNZzr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8034 --- Comment #22 from Srdjan Jankovic <srdjan at catalyst.net.nz> --- Ok, I stand corrected there. Queue value can be updated now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 03:56:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 01:56:44 +0000 Subject: [Koha-bugs] [Bug 8743] ZOOM error when merging authority change to biblios In-Reply-To: <bug-8743-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8743-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8743-70-naGNUeSALu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8743 --- Comment #3 from Doug Kingston <dpk at randomnotes.org> --- Comment on attachment 12119 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12119 Bug 8743: ZOOM error when merging authority change to biblios I can confirm that this patch has fixed our failure to update biblios cited at the beginning of this bug. Thanks for the patch Jared! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 03:57:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 01:57:18 +0000 Subject: [Koha-bugs] [Bug 8743] ZOOM error when merging authority change to biblios In-Reply-To: <bug-8743-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8743-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8743-70-63WeC7mb8T@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8743 Doug Kingston <dpk at randomnotes.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpk at randomnotes.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 04:09:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 02:09:35 +0000 Subject: [Koha-bugs] [Bug 8743] ZOOM error when merging authority change to biblios In-Reply-To: <bug-8743-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8743-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8743-70-GIccsSC05t@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8743 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #4 from Chris Cormack <chris at bigballofwax.co.nz> --- Do you want to sign off on it Doug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 09:27:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 07:27:30 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7143-70-LJLyIccDzg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12156|0 |1 is obsolete| | --- Comment #53 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 12158 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12158&action=edit Bug 7143: Adding Kathryn Tyree to the history and About page. Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 09:27:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 07:27:45 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7143-70-tIPuGf1rxs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 09:34:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 07:34:50 +0000 Subject: [Koha-bugs] [Bug 8761] Correct compile time warnings in C4::Circulation In-Reply-To: <bug-8761-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8761-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8761-70-AUsagu4Em3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8761 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #3 from Chris Cormack <chris at bigballofwax.co.nz> --- The warns are the same with 5.14 too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 09:42:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 07:42:44 +0000 Subject: [Koha-bugs] [Bug 8761] Correct compile time warnings in C4::Circulation In-Reply-To: <bug-8761-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8761-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8761-70-wR1ON02QrC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8761 --- Comment #4 from Chris Cormack <chris at bigballofwax.co.nz> --- I can confirm the patch makes the error goes away, and circ still works fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 09:43:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 07:43:09 +0000 Subject: [Koha-bugs] [Bug 8761] Correct compile time warnings in C4::Circulation In-Reply-To: <bug-8761-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8761-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8761-70-Lc7ks9bd5K@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8761 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12144|0 |1 is obsolete| | --- Comment #5 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 12159 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12159&action=edit Bug 8761 Dont inadvertantly use slices Assignment to a single element slice is better written as a scalar - This generates a compile time warning as it can lead to odd behaviour see perldiag for details This corrects some cases which were added in a recent commit Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 09:43:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 07:43:49 +0000 Subject: [Koha-bugs] [Bug 8761] Correct compile time warnings in C4::Circulation In-Reply-To: <bug-8761-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8761-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8761-70-Uh55CNDJpV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8761 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 09:47:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 07:47:16 +0000 Subject: [Koha-bugs] [Bug 7241] circulation action logs record biblionumber instead of item number In-Reply-To: <bug-7241-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7241-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7241-70-U1YGHpPPKo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7241 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #28 from Chris Cormack <chris at bigballofwax.co.nz> --- (In reply to comment #27) > (In reply to comment #24) > > Well, Thinking of it a little bit more, I've reverted the patch. > > > > Having history badly broken for existing instances is really bad, because we > > will never be able to fix the problem properly once action_logs contains > > mixed informations (biblio & items) > > > > And I've an easy proposal to fix what can be fixed: > > The following SQL: > > UPDATE action_logs SET object=(SELECT itemnumber FROM items WHERE > > biblionumber= action_logs.object LIMIT 1) WHERE module='CIRCULATION' AND > > action in ('ISSUE','RETURN'); > > > > Set the 1st item number (as we can't know which item was circulated once > > things have been anonymised). It's better than nothing. > > > > I propose that you submit a new patch including an updatedatabase with this > > SQL > > As a possible supplement, how about tagging the object column with an > indication of whether it's an old-style log of a biblionumber. E.g., > > UPDATE action_logs SET object = 'biblio ' || object WHERE module = > 'CIRCULATION' AND action IN ('ISSUE', 'RETURN'); > > Then viewlog.pl could assume that if the value is tagged with a 'biblio ' > prefix that it contains an bib number; if it isn't, it contains an item > number. > > Doing it this way would mean that the logs are as accurate as possible. > > Another, farther-reaching option would be to add biblionumber and itemnumber > columns to action_logs. +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 10:13:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 08:13:04 +0000 Subject: [Koha-bugs] [Bug 8652] There is no default value for the late orders In-Reply-To: <bug-8652-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8652-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8652-70-i66cKuG5co@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8652 --- Comment #6 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 12160 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12160&action=edit Bug 8652: Followup: add a default value for date_from (In reply to comment #5) > I took the liberty of amending the Koha::DateUtils calls. I'm sure the logic > could be further cleaned up. Requires testing Thanks Colin. This followup adds a parameter for the output_pref routine and reintroduces the default value for date_from if no other one is present. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 10:21:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 08:21:56 +0000 Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next In-Reply-To: <bug-7187-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7187-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7187-70-ju3gS33ZaJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187 --- Comment #19 from Manos PETRIDIS <egpetridis at yahoo.com> --- (In reply to comment #6) > One thing we need to decide on is whether the logic that checks multiple > sources should be in JavaScript on the client side or Perl on the server > side. I'm leaning towards Perl on the server, for two reasons: > > 1. Displaying an image could be as simple as this: > > <img src="opac-ver.pl?biblionumber=x" /> > > 2. We could cache the results of looking through multiple sources. (Caching > might violate the terms of service for e.g. Amazon, but then we could check > them last, after we have checked the ones that we can cache.) I know it is quite late, but it just came to me that using server-side code might simplify using/intergrating local images with the ones provided by external sources, and allow for displaying the same images at the OPAC and the administrative calatogs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 10:25:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 08:25:12 +0000 Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next In-Reply-To: <bug-7187-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7187-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7187-70-AvOwUbGPiR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187 --- Comment #20 from Robin Sheat <robin at catalyst.net.nz> --- While not explicitly discussed, this is covered in my plan. There will be a set of "plugins" to handle each image source, and this'll include local ones. I've sent the details to the library, I'm just waiting for them to get back to me about whether they'll be keen to go for it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 10:30:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 08:30:35 +0000 Subject: [Koha-bugs] [Bug 8034] Enable server print queue selection In-Reply-To: <bug-8034-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8034-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8034-70-DVVGHUNqvN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8034 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12157|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 12161 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12161&action=edit bug_8034: Restored network printer maintenance and selection This patch is just for restoring printer maintenance and selection, not for priting itself. It is just a preparation step. * Added UsePrintQueues syspref. If set to No, no printer info will be displayed/used * Database changes: - printers table PRIMARY KEY is now printqueue. It is more natural. We should really have a synthetic id, but printqueue is good enough - branches.branchprinter is a FOREIGN KEY to printers.printqueue * Created C4::Auth::get_user_printer() function that will return appropriate printer. In order of preference: - session selected - logged in branch branchprinter * Moved printer functions to C4::Printer * Restored printer maint/selection in admin zone UsePrintQueues permitting * Restored printer selection in circ/selectbranchprinter.pl UsePrintQueues permitting Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com> Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 10:32:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 08:32:20 +0000 Subject: [Koha-bugs] [Bug 8034] Enable server print queue selection In-Reply-To: <bug-8034-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8034-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8034-70-TkAR77A85X@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8034 --- Comment #24 from Jonathan Druart <jonathan.druart at biblibre.com> --- I prefer someone else makes QA on this patch so I don't passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 11:57:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 09:57:53 +0000 Subject: [Koha-bugs] [Bug 8757] Longer size text for authorised values "lib" In-Reply-To: <bug-8757-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8757-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8757-70-N9ftT2Hkhw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8757 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12127|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 12162 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12162&action=edit Bug 8757: longer descriptions for authorised values In the "suggestions" table, the "lib" and "lib_opac" sizes has been raised from 80 chars to 200. The GUI allowing the authorised values creation/update has been changed accordingly. Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 11:58:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 09:58:23 +0000 Subject: [Koha-bugs] [Bug 8757] Longer size text for authorised values "lib" In-Reply-To: <bug-8757-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8757-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8757-70-ti7CFWkJSg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8757 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 12:35:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 10:35:13 +0000 Subject: [Koha-bugs] [Bug 8302] Add accesssion number to the drop down list in OPAC Search. In-Reply-To: <bug-8302-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8302-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8302-70-Lu9zPK88pQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8302 --- Comment #4 from Meenakshi <meenakshi.r at osslabs.biz> --- Created attachment 12163 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12163&action=edit Attaching the latest patch. Attaching the latest patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 12:35:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 10:35:35 +0000 Subject: [Koha-bugs] [Bug 8302] Add accesssion number to the drop down list in OPAC Search. In-Reply-To: <bug-8302-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8302-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8302-70-Wo0tjprhI7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8302 Meenakshi <meenakshi.r at osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 14:09:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 12:09:29 +0000 Subject: [Koha-bugs] [Bug 5544] All Notices from Branch Email Address In-Reply-To: <bug-5544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5544-70-9eDJHyf654@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5544 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9491|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12164 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12164&action=edit Bug 5544 - All Notices from Branch Email Address Right now overdues from from the branch, but the others come from the admin email address - this is a problem in multi-branch systems because they have to come up with one email address that all branches have access to. C4::Letters::_send_message_by_email currently sets the from address in the following order: 1) Address specified in message 2) Koha admin email address The order will now be: 1) Address specified in message 2) Borrowers home library email address 3) Koha admin email address -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 14:10:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 12:10:35 +0000 Subject: [Koha-bugs] [Bug 5544] All Notices from Branch Email Address In-Reply-To: <bug-5544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5544-70-IAaWpfIJRb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5544 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> --- This new patch implements the suggestions made by Jonathan Druart in Comment 2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 14:15:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 12:15:27 +0000 Subject: [Koha-bugs] [Bug 8089] Use Koha::Cache everywhere In-Reply-To: <bug-8089-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8089-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8089-70-OcSeZPZVZI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED Version|rel_3_10 |master --- Comment #25 from Paul Poulain <paul.poulain at biblibre.com> --- The follow-up does not fix the problem for me. After discussion with Jared on IRC, the initial patches have been reverted. Dobrica said he will work on another patch for caching. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 14:16:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 12:16:18 +0000 Subject: [Koha-bugs] [Bug 5544] All Notices from Branch Email Address In-Reply-To: <bug-5544-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5544-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5544-70-go3U0he4GB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5544 --- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to comment #3) > I tested this and it worked as expected when processing item checkout > notices. I'm not sure how to test case 1) Address specified in message. > Where does that arise? I checked the code, and as far as I can tell, there is no code in Koha the currently uses case 1. _send_message_by_email is only called by SendQueuedMessages, which is only used in misc/cronjobs/process_message_queue.pl I'm guessing that it is vestigial. We could remove but, but it does provide some flexibility that may be useful in the future. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 14:18:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 12:18:41 +0000 Subject: [Koha-bugs] [Bug 8497] Strange behavior when modifying the 'timeout' system preference. In-Reply-To: <bug-8497-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8497-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8497-70-bLcBcge8sc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8497 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 14:21:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 12:21:24 +0000 Subject: [Koha-bugs] [Bug 7500] Use CSS Sprites for faster page loading In-Reply-To: <bug-7500-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7500-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7500-70-lwhv4XQYWo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 --- Comment #29 from Paul Poulain <paul.poulain at biblibre.com> --- (In reply to comment #28) > QA comment: if i'm not wrong owen, you replaced > /opac-tmpl/prog/images/socnet/facebook16.png by a social sprite, but > facebook16.png is not removed. > > Shouldn't it be removed ? (same thing for other social network links) Owen = ping -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 14:21:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 12:21:43 +0000 Subject: [Koha-bugs] [Bug 8089] Use Koha::Cache everywhere In-Reply-To: <bug-8089-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8089-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8089-70-F4u6OebKXO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089 --- Comment #26 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to comment #25) > The follow-up does not fix the problem for me. > After discussion with Jared on IRC, the initial patches have been reverted. > Dobrica said he will work on another patch for caching. I have a fix for it integrated into my followup patch for Bug 7067. Someone could just steal that code out and post if up as a patch here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 14:33:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 12:33:15 +0000 Subject: [Koha-bugs] [Bug 8089] Use Koha::Cache everywhere In-Reply-To: <bug-8089-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8089-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8089-70-PxIcZsdu15@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089 --- Comment #27 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Your change is line-for-line identical (other than one indentation change) to the follow-up that did not work for Paul. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 14:34:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 12:34:26 +0000 Subject: [Koha-bugs] [Bug 7421] UNIMARC authorities DOM indexing mode In-Reply-To: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7421-70-2ZjPmbh22q@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7421 --- Comment #9 from Paul Poulain <paul.poulain at biblibre.com> --- (In reply to comment #8) > bump ! Fr?d?ric, see comment 7, I can't make it work ! Fr?d?ric, bump again ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 14:38:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 12:38:05 +0000 Subject: [Koha-bugs] [Bug 8750] Chronological terms authorities not correctly indexed In-Reply-To: <bug-8750-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8750-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8750-70-u89AMnLgbV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8750 --- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- (In reply to comment #3) > I attempted to sign off on this patch. I first tried searching for > authority records on master and was unable to retrieve any authority > records. (I can search for authority records on 3.8.4) Are you sure the zebra daemon started properly? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 14:40:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 12:40:10 +0000 Subject: [Koha-bugs] [Bug 8412] add color icon set In-Reply-To: <bug-8412-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8412-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8412-70-38yo4WyK2S@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8412 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 --- Comment #17 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master Final comment: definitely, I'm not a big fan of this patch. I feel it could have been written another way. However, it's highly not intrusive, so easy to remove if another option for picking a color is written. So I've pushed the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 14:40:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 12:40:33 +0000 Subject: [Koha-bugs] [Bug 8089] Use Koha::Cache everywhere In-Reply-To: <bug-8089-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8089-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8089-70-rY63eeNdMX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089 --- Comment #28 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to comment #27) > Your change is line-for-line identical (other than one indentation change) > to the follow-up that did not work for Paul. That's both funny and odd. It definitely works for me. Kyle -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 14:41:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 12:41:41 +0000 Subject: [Koha-bugs] [Bug 8089] Use Koha::Cache everywhere In-Reply-To: <bug-8089-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8089-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8089-70-9HDBQJ0vtY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089 --- Comment #29 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- (In reply to comment #28) > (In reply to comment #27) > > Your change is line-for-line identical (other than one indentation change) > > to the follow-up that did not work for Paul. > > That's both funny and odd. It definitely works for me. For both Chris and me, too. It seems to be an interaction of the patch with data on Paul's system. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 14:42:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 12:42:19 +0000 Subject: [Koha-bugs] [Bug 8750] Chronological terms authorities not correctly indexed In-Reply-To: <bug-8750-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8750-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8750-70-AmqpzMfDMj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8750 --- Comment #5 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- I can't test this at the moment, but it is worth noting that there are several implied steps for testing this patch: 1) apply patch 2) rerun Makefile.PL to choose GRS-1 indexing for authorities 3) update Zebra configuration files by running make && make install 4) reindex zebra using rebuild_zebra.pl -a -r 5) search for chronological term -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 14:45:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 12:45:53 +0000 Subject: [Koha-bugs] [Bug 7500] Use CSS Sprites for faster page loading In-Reply-To: <bug-7500-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7500-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7500-70-QY8mBR5064@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9680|0 |1 is obsolete| | --- Comment #30 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 12165 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12165&action=edit Bug 7500 [FOLLOW-UP, revised][Social networks] Use CSS Sprites for faster page loading This patch adds a new sprite image for social network links. The page markup has been modified to accommodate the image- replacement technique used to display the images. When testing be sure to clear your cache to load the new CSS. Revision: Rebased, and unused social network images removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 14:52:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 12:52:00 +0000 Subject: [Koha-bugs] [Bug 8089] Use Koha::Cache everywhere In-Reply-To: <bug-8089-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8089-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8089-70-DUUkiUciwr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089 --- Comment #30 from Paul Poulain <paul.poulain at biblibre.com> --- (In reply to comment #29) > (In reply to comment #28) > > (In reply to comment #27) > > > Your change is line-for-line identical (other than one indentation change) > > > to the follow-up that did not work for Paul. > > > > That's both funny and odd. It definitely works for me. > > For both Chris and me, too. It seems to be an interaction of the patch with > data on Paul's system. my investigations shows that the PrimaryKey is not found, resulting in a SQL that is: UPDATE borrowers SET ... WHERE =? which is, obviously, wrong :\ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 14:52:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 12:52:33 +0000 Subject: [Koha-bugs] [Bug 8089] Use Koha::Cache everywhere In-Reply-To: <bug-8089-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8089-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8089-70-bQN2BPmIa8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089 --- Comment #31 from Paul Poulain <paul.poulain at biblibre.com> --- (In reply to comment #30) > (In reply to comment #29) > > (In reply to comment #28) > > > (In reply to comment #27) > > > > Your change is line-for-line identical (other than one indentation change) > > > > to the follow-up that did not work for Paul. > > > > > > That's both funny and odd. It definitely works for me. > > > > For both Chris and me, too. It seems to be an interaction of the patch with > > data on Paul's system. > > my investigations shows that the PrimaryKey is not found, resulting in a SQL > that is: > UPDATE borrowers SET ... WHERE =? > which is, obviously, wrong :\ I've tested with and without cache and with and without Plack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 14:52:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 12:52:49 +0000 Subject: [Koha-bugs] [Bug 2720] Fines that debar automatically, should undebar automatically when paid. In-Reply-To: <bug-2720-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2720-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2720-70-ARJc1L0y1F@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 --- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to comment #5) > (In reply to comment #4) > > I would say we keep borrowers.debarred, but convert it to a boolean value. > > Convert it *back* to a boolean value! And move the date information into > borrower_debarment? Yes. It will just be a quick check to know if the borrower is currently debarred without checking the debarments table. > > We can then have that value updated each time the debarments table is > > altered. > > Which is when? Is there a line in borrower_debarment for each overdue item > which is past the limit? And the table is reviewed each time an item is > renewed or checked in?+ Each time a debarment is added to the borrower_debarments table, or a debarment is removed from the borrower_debarments table, a check will then be performed to determine if the borrower is currently debarred or not, and borrowers.debarred will be updated accordingly. > > I believe we will then need a nightly cronjob to remove expired > > debarments and update borrowers.debarred. > > I don't understand. Are we talking about a cron job or is this something > which updates each time something is checked in or renewed? Right now, Koha checks the debarment field as a date to see if it is still valid. This will no longer be effective, as we will be able to have multiple debarments with different expiration dates. We can have a cronjob that runs nightly to remove any expired debarments, and reset the borrowers.debarment field to 0 if the borrower no longer has any active debarments. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 15:00:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 13:00:38 +0000 Subject: [Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned In-Reply-To: <bug-2720-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2720-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2720-70-0xGMGCXnSM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fines that debar |Overdues which debar |automatically, should |automatically should |undebar automatically when |undebar automatically when |paid. |returned -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 15:14:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 13:14:42 +0000 Subject: [Koha-bugs] [Bug 8369] default_branch_circ_rule and default_circ_rules tables useless In-Reply-To: <bug-8369-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8369-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8369-70-7F5yLHnEJJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8369 --- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 12166 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12166&action=edit Bug 8369: Merge tables for circulation rules. This patch adds 3 new tables: - circ_rules - borrower_circ_rules - item_circ_rules It removes 6 tables: - default_borrower_circ_rules - default_branch_circ_rules - default_branch_item_rules - default_circ_rules - branch_borrower_circ_rules - branch_item_rules The goal is to merge circulations rules into 3 tables instead of 6 without add or remove features. Previous behaviours do not change. The wildcard '*' character is a rule for the default values. Then it is possible to merge 2 tables into one if we consider that the default value is the value with a branchcode eq '*'. I removed the foreign key constraint with branchcode and added 3 queries in the C4::Branch::DelBranch routine in order to remove records about a deleted branch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 15:14:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 13:14:47 +0000 Subject: [Koha-bugs] [Bug 8369] default_branch_circ_rule and default_circ_rules tables useless In-Reply-To: <bug-8369-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8369-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8369-70-ZPk2fbaFG0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8369 --- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 12167 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12167&action=edit Bug 8369: Followup: indent sql queries in admin/smart-rules.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 15:15:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 13:15:29 +0000 Subject: [Koha-bugs] [Bug 8369] default_branch_circ_rule and default_circ_rules tables useless In-Reply-To: <bug-8369-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8369-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8369-70-nensX5SVkq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8369 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |jonathan.druart at biblibre.co | |m Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 15:30:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 13:30:56 +0000 Subject: [Koha-bugs] [Bug 5911] Transport Cost Matrix of transporting an item between branches In-Reply-To: <bug-5911-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5911-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5911-70-vYHfWvM6Lp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5911 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 --- Comment #58 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master I tried to find things that could have been broken by this feature (testing with syspref=off, without hold_queue at all), and could not find anything wrong. I can edit the admin/transport-matrix.pl correctly. I haven't tested the rest of the feature work perfectly, but no regression => patch pushed ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 15:31:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 13:31:59 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7143-70-EptTriHx1E@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #54 from Jonathan Druart <jonathan.druart at biblibre.com> --- passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 15:32:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 13:32:27 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7143-70-k2MfgNKlAA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12158|Bug 7143: Adding Kathryn |[PASSED-QA]Bug 7143: Adding description|Tyree to the history and |Kathryn Tyree to the |About page. |history and About page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 15:32:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 13:32:32 +0000 Subject: [Koha-bugs] [Bug 8708] RSS feed for new comments is broken In-Reply-To: <bug-8708-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8708-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8708-70-d5lSd6Qk1u@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8708 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 --- Comment #10 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master (Not sure this patch applies or is relevant for 3.8) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 15:32:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 13:32:39 +0000 Subject: [Koha-bugs] [Bug 8750] Chronological terms authorities not correctly indexed In-Reply-To: <bug-8750-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8750-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8750-70-oWposgQUc0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8750 --- Comment #6 from Joy Nelson <joy at bywatersolutions.com> --- Valid point! I'm testing on my local install and assumed it was running, I will double check and retest. Thanks! > Are you sure the zebra daemon started properly? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 15:34:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 13:34:06 +0000 Subject: [Koha-bugs] [Bug 8761] Correct compile time warnings in C4::Circulation In-Reply-To: <bug-8761-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8761-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8761-70-2Z9SGA8T3b@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8761 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m QA Contact| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 15:35:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 13:35:14 +0000 Subject: [Koha-bugs] [Bug 8761] Correct compile time warnings in C4::Circulation In-Reply-To: <bug-8761-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8761-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8761-70-nNsdoKkikn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8761 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Jonathan Druart <jonathan.druart at biblibre.com> --- I proposed exactly the same patch in Bug 7621 (which introduces these warnings). So I mark it as Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 15:35:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 13:35:48 +0000 Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title with borrower's age without using categories In-Reply-To: <bug-7621-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7621-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7621-70-iQUyOwJ23K@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12133|0 |1 is obsolete| | --- Comment #67 from Jonathan Druart <jonathan.druart at biblibre.com> --- Comment on attachment 12133 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12133 [SIGNED-OFF] Bug 7621: Followup: FIX warnings "Scalar value @values[$take] better written as $values[$take]" Fix with Bug 8761 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 15:36:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 13:36:26 +0000 Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title with borrower's age without using categories In-Reply-To: <bug-7621-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7621-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7621-70-e4T02BW9ds@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 15:36:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 13:36:40 +0000 Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title with borrower's age without using categories In-Reply-To: <bug-7621-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7621-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7621-70-kQizV1I1nj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #68 from Jonathan Druart <jonathan.druart at biblibre.com> --- adapting status -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 15:38:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 13:38:59 +0000 Subject: [Koha-bugs] [Bug 7986] Export issues In-Reply-To: <bug-7986-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7986-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7986-70-cGnCjQP2XW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #25 from Paul Poulain <paul.poulain at biblibre.com> --- The last patch does not apply Applying: Bug 7986: Followup: Replace DontExportFields and CsvProfileForExport fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 7986: Followup: Replace DontExportFields and CsvProfileForExport When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Patch left in /tmp/Bug-7986-Followup-Replace-DontExportFields-and-Csv-kNu3V9.patch Jonathan, note that you can also squash the 3 patches in one, that will be easier to solve updatedatabase conflict ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 15:45:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 13:45:04 +0000 Subject: [Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned In-Reply-To: <bug-2720-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2720-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2720-70-qAd9KPFz7B@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 --- Comment #7 from Owen Leonard <oleonard at myacpl.org> --- (In reply to comment #6) > We can have a cronjob that runs > nightly to remove any expired debarments, and reset the borrowers.debarment > field to 0 if the borrower no longer has any active debarments. If we're relying on a cron job to remove debarments, then I wonder why we bother with the extra table? Why not run a cron job which checks for borrowers with no overdues for whom borrowers.debarred = '9999-12-31' ? This would exclude patrons which were restricted under a suspension in days rule. If we're trying to exclude patrons for whom borrowers.debarred was set manually, maybe we need to instead create a new flag for manual restriction? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 15:46:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 13:46:12 +0000 Subject: [Koha-bugs] [Bug 7986] Export issues In-Reply-To: <bug-7986-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7986-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7986-70-30DzQni5aE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11998|0 |1 is obsolete| | Attachment #11999|0 |1 is obsolete| | Attachment #12000|0 |1 is obsolete| | --- Comment #26 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 12168 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12168&action=edit Bug 7986: Export issues for patron Rebased and squashed patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 15:46:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 13:46:20 +0000 Subject: [Koha-bugs] [Bug 7986] Export issues In-Reply-To: <bug-7986-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7986-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7986-70-Q46BgZrK52@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 15:47:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 13:47:29 +0000 Subject: [Koha-bugs] [Bug 8496] show local cover images on lists view in opac In-Reply-To: <bug-8496-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8496-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8496-70-7BnDIqwIGo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8496 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 --- Comment #8 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master (Nice enhancement !) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 15:51:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 13:51:34 +0000 Subject: [Koha-bugs] [Bug 8382] It is not possible to cancel an order when receiving on a filtered page in parcel.pl In-Reply-To: <bug-8382-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8382-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8382-70-Q5rZfEVAmD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8382 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 15:51:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 13:51:44 +0000 Subject: [Koha-bugs] [Bug 8382] It is not possible to cancel an order when receiving on a filtered page in parcel.pl In-Reply-To: <bug-8382-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8382-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8382-70-5UYxUyNtUC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8382 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 15:57:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 13:57:49 +0000 Subject: [Koha-bugs] [Bug 8740] Serials Claims should be exportable all at once In-Reply-To: <bug-8740-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8740-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8740-70-3gX3e3A4xX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8740 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> --- QA comments: This patch allows $supplierid to be a string or an integer. We have some warnings in logs: Argument "all" isn't numeric in numeric eq (==) Maybe a better option would be to set the "all suppliers" value with -1. Marked as Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 16:02:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 14:02:35 +0000 Subject: [Koha-bugs] [Bug 8339] div id="login" should be id="login_controls" in header.inc In-Reply-To: <bug-8339-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8339-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8339-70-wJ3kiECZGB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8339 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #10 from Jonathan Druart <jonathan.druart at biblibre.com> --- The template file modules/auth.tt still use the login id for a div element. Please clarify if it is normal. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 16:11:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 14:11:51 +0000 Subject: [Koha-bugs] [Bug 7068] autobarcode not working when duplicating patrons In-Reply-To: <bug-7068-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7068-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7068-70-3nCWRWg3Gy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7068 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> --- QA Comments: works as expected, nothing to say. Marked as Passed QA. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 16:16:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 14:16:10 +0000 Subject: [Koha-bugs] [Bug 8598] No patron image or home library on Files & Statistics tabs In-Reply-To: <bug-8598-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8598-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8598-70-B6HmEaPv2B@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8598 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m QA Contact| |jonathan.druart at biblibre.co | |m --- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> --- QA Comments: This patch duplicates code but it is like this in so many members/* files Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 16:17:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 14:17:15 +0000 Subject: [Koha-bugs] [Bug 7068] autobarcode not working when duplicating patrons In-Reply-To: <bug-7068-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7068-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7068-70-DnNiHLIAMa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7068 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 16:22:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 14:22:25 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-7ljtvNd3mM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #75 from Owen Leonard <oleonard at myacpl.org> --- (In reply to comment #74) > * Add invalid token page This works great, thanks, As for the potential duplicate patrons when not requiring email notification, I guess the upside is that delete_unverified_opac_registrations.pl job will deal with them. However, that assumes that the patron is coming in to the library to confirm their identity (or whatever procedure changes them from a temp category to a permanent one), and that the library is running that cron job. It remains a potential problem for libraries which allow patrons to register for full-fledged accounts without confirmation (however unlikely that scenario seems to me). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 16:23:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 14:23:48 +0000 Subject: [Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned In-Reply-To: <bug-2720-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2720-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2720-70-Kf5WdUzN5m@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 --- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to comment #7) > (In reply to comment #6) > > We can have a cronjob that runs > > nightly to remove any expired debarments, and reset the borrowers.debarment > > field to 0 if the borrower no longer has any active debarments. > > If we're relying on a cron job to remove debarments, then I wonder why we > bother with the extra table? Why not run a cron job which checks for > borrowers with no overdues for whom borrowers.debarred = '9999-12-31' ? This > would exclude patrons which were restricted under a suspension in days rule. > > If we're trying to exclude patrons for whom borrowers.debarred was set > manually, maybe we need to instead create a new flag for manual restriction? I guess my idea is to have a more flexible and extensible system. Having multiple debarment fields in the borrowers table seems kludgy to me. What if a borrower is debarred for different reasons at different branches? With my proposed design, we could allow patrons to be debarred at only specific libraries if we add a branch code to the debarments table. I guess I'm just making the case that it would be better to in the long run to develop a separate table rather than keep adding more fields to the borrowers table. If plack ever becomes the primary way to run Koha, we wouldn't even need a 'quick' flag in the borrowers table, as the result could be cached. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 16:24:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 14:24:37 +0000 Subject: [Koha-bugs] [Bug 3456] Serials receipt note In-Reply-To: <bug-3456-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3456-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3456-70-yvok6HcqbI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3456 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #6 from Jonathan Druart <jonathan.druart at biblibre.com> --- QA comments: Display a new information (internalnotes) on the receipt page. Simple patch. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 16:25:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 14:25:43 +0000 Subject: [Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned In-Reply-To: <bug-2720-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2720-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2720-70-PiCf7EjN2c@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 --- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> --- I should also note that if don't use a quick flag in the borrowers table, we wouldn't need a cronjob either. We could remove expired debarments when checking if the patron is currently debarred. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 16:29:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 14:29:12 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-3cLFgW9gdg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #76 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to comment #75) > (In reply to comment #74) > > * Add invalid token page > > This works great, thanks, > > As for the potential duplicate patrons when not requiring email > notification, I guess the upside is that > delete_unverified_opac_registrations.pl job will deal with them. However, > that assumes that the patron is coming in to the library to confirm their > identity (or whatever procedure changes them from a temp category to a > permanent one), and that the library is running that cron job. It remains a > potential problem for libraries which allow patrons to register for > full-fledged accounts without confirmation (however unlikely that scenario > seems to me). Agreed. Perhaps just adding a caveat in the manual should suffice. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 16:31:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 14:31:15 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-aEmEOF0uFX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #77 from Owen Leonard <oleonard at myacpl.org> --- Hm, but delete_unverified_opac_registrations.pl doesn't do that does it? It deletes from borrower_modifications. But that's just for pending updates to existing patrons isn't it? Is that how it's supposed to work? Either way, that script needs help added to it, and should not run without setting an explicit flag to proceed with deletions. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 16:31:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 14:31:30 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-thucnkOGcs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 16:32:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 14:32:01 +0000 Subject: [Koha-bugs] [Bug 8716] Reordering of routing list entries doesn't work In-Reply-To: <bug-8716-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8716-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8716-70-15mZry4CK4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8716 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m Assignee|koha-bugs at lists.koha-commun |robin at catalyst.net.nz |ity.org | QA Contact| |jonathan.druart at biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> --- QA comments: works as expected, simple fix. Marked as Passed QA. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 16:36:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 14:36:21 +0000 Subject: [Koha-bugs] [Bug 8339] div id="login" should be id="login_controls" in header.inc In-Reply-To: <bug-8339-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8339-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8339-70-72be8vwhqV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8339 --- Comment #11 from Owen Leonard <oleonard at myacpl.org> --- That's exactly the point. It removes the ambiguity between what <div id="login"> refers to. The <div> on auth.tt will now be identified differently than the <div> in the staff client header. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 16:41:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 14:41:25 +0000 Subject: [Koha-bugs] [Bug 8677] table overlapping to the right on holds waiting In-Reply-To: <bug-8677-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8677-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8677-70-vQlHmMfxRM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8677 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> --- Simple template modification patch. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 16:41:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 14:41:41 +0000 Subject: [Koha-bugs] [Bug 8677] table overlapping to the right on holds waiting In-Reply-To: <bug-8677-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8677-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8677-70-PBaZIqf7ph@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8677 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 16:45:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 14:45:15 +0000 Subject: [Koha-bugs] [Bug 8251] Patrons are systematically debarred at checkin In-Reply-To: <bug-8251-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8251-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8251-70-S7w9rR7hE9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8251 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #43 from Paul Poulain <paul.poulain at biblibre.com> --- "Do not try to debar patrons if returns are not overdue" follow-up pushed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 16:50:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 14:50:17 +0000 Subject: [Koha-bugs] [Bug 7583] undo receive In-Reply-To: <bug-7583-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7583-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7583-70-l8pMWpNNST@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7583 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |paul.poulain at biblibre.com --- Comment #13 from Paul Poulain <paul.poulain at biblibre.com> --- (In reply to comment #12) > Rebased patches Epic fail: syntax error at acqui/parcel.pl line 84, near ");" Global symbol "$datereceived" requires explicit package name at acqui/parcel.pl line 85. Global symbol "$datereceived" requires explicit package name at acqui/parcel.pl line 85. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 16:54:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 14:54:50 +0000 Subject: [Koha-bugs] [Bug 7583] undo receive In-Reply-To: <bug-7583-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7583-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7583-70-JoVhd0QERE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7583 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12037|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 12169 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12169&action=edit Bug 7583: Cancel a receipt In acqui/parcel.pl, there is now the possibility to cancel a receipt. In "Already received" table, just click on "Cancel receipt" and the order line will go back to pending orders. If it was a partial receipt, order line is merged to its 'parent' line. Attached items are modified so that they become attached to the merged order line. If AcqCreateItem is 'receiving', attached items are deleted. If an order line was first partially received, and then completed. You must cancel the 'parent' order line before cancelling the 'child'. Signed-off-by: Marc Veron <veron at veron.ch> The patch behaves like expected, and the feature is really helpfull. Just a tiny remark about the following message: ------------- Cannot cancel receipt. Possible reasons : You are trying to cancel the receipt of an order line whose parent order line is already received. Cancel this parent order line and retry. ------------- Maybe it would be good - to explain a little bit more why it happend and re-word the message for non technical people (not everybody understands 'parent' the same way) - prevent the situation to happen (e.g. forbid order lines to be deleted if they are already received) - but that would be in the scope of an other bug, I think. I think such things could be fixed in the future during the ongoing work for Acquisitions module. Signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 16:54:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 14:54:59 +0000 Subject: [Koha-bugs] [Bug 7583] undo receive In-Reply-To: <bug-7583-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7583-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7583-70-YlU9P7VCpb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7583 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12038|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 12170 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12170&action=edit Bug 7583 follow-up: Prevent users to cancel receipt if they can't Disable the link for cancelling instead of displaying an error message after the click. This is only valid if parent order line is received, not if it's deleted. When the user gets his mouse over the disabled link, he gets a message telling him which order (ordernumber) blocks him so he knows immediately which receipt to cancel. Also improve error messages for non technical people Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 16:56:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 14:56:25 +0000 Subject: [Koha-bugs] [Bug 7583] undo receive In-Reply-To: <bug-7583-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7583-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7583-70-O6xIZMssNW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7583 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #16 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to comment #13) > Epic fail: > > syntax error at acqui/parcel.pl line 84, near ");" > Global symbol "$datereceived" requires explicit package name at > acqui/parcel.pl line 85. > Global symbol "$datereceived" requires explicit package name at > acqui/parcel.pl line 85. Outch sorry ! A parenthesis was missing after the conflict, I solved it like: -my $datereceived = ($op eq ('new' or 'search' ) +my $datereceived = ( $op eq ('new' or 'search' ) ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 16:58:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 14:58:14 +0000 Subject: [Koha-bugs] [Bug 8339] div id="login" should be id="login_controls" in header.inc In-Reply-To: <bug-8339-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8339-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8339-70-8qB1CUoqbN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8339 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #12 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to comment #11) > That's exactly the point. It removes the ambiguity between what <div > id="login"> refers to. The <div> on auth.tt will now be identified > differently than the <div> in the staff client header. Ok thank you Owen. So I marked it as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 17:01:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 15:01:27 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-aGcRJeKVFO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #78 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to comment #77) > Hm, but delete_unverified_opac_registrations.pl doesn't do that does it? It > deletes from borrower_modifications. But that's just for pending updates to > existing patrons isn't it? Is that how it's supposed to work? > > Either way, that script needs help added to it, and should not run without > setting an explicit flag to proceed with deletions. It doesn't touch modifications to existing borrowers. If someone submits a registration from the opac, but never clicks the verification link, that row will just sit in the borrower_modifications table forever. This script deletes rows that have been sitting in the table for more than 24 hours. I'll add some help to it, and while I'm at it, I can make the hours part configurable. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 17:01:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 15:01:51 +0000 Subject: [Koha-bugs] [Bug 8017] Remove unnecessary processing on return of GetAllIssues In-Reply-To: <bug-8017-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8017-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8017-70-b8wgm4aDvJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8017 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #12 from Paul Poulain <paul.poulain at biblibre.com> --- Sorry, but the patch does not apply anymore, because of bug 6494. Could you rebase & resubmit (conflict not trivial to solve: I feel most of it is tidying code, but to avoid any mistake, I let you do) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 17:11:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 15:11:34 +0000 Subject: [Koha-bugs] [Bug 2060] Ability to import Authorities from Staff Client In-Reply-To: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2060-70-g2ITAnRym4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2060 SJeffery <steven_jeffery at fmi.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |steven_jeffery at fmi.com --- Comment #26 from SJeffery <steven_jeffery at fmi.com> --- Is this going to make it into 3.10? We have some major projects in our library that would make extensive use of this functionality. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 17:15:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 15:15:50 +0000 Subject: [Koha-bugs] [Bug 2060] Ability to import Authorities from Staff Client In-Reply-To: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2060-70-XQHQLxyqDb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2060 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #27 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi SJeffery, you could help getting this in by testing it very well and then giving it another sign-off! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 17:16:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 15:16:11 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-duSV10Nb3u@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #79 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to comment #77) > Hm, but delete_unverified_opac_registrations.pl doesn't do that does it? It > deletes from borrower_modifications. But that's just for pending updates to > existing patrons isn't it? Is that how it's supposed to work? > > Either way, that script needs help added to it, and should not run without > setting an explicit flag to proceed with deletions. I think the script you are thinking of is misc/cronjobs/delete_expired_opac_registrations.pl That script will delete patrons with the category set in PatronSelfRegistrationDefaultCategory after the specified delay. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 17:16:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 15:16:38 +0000 Subject: [Koha-bugs] [Bug 2060] Ability to import Authorities from Staff Client In-Reply-To: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2060-70-QG9HyBZzOW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2060 --- Comment #28 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Really, it would be a great addition - and more sign-offs are always helpful. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 17:20:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 15:20:49 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-cAChCWfDYX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12154|0 |1 is obsolete| | --- Comment #80 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12171 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12171&action=edit Bug 7067 - OPAC Borrower Self Registration - Followup * Rename PatronSelfRegistrationUseTemporaryStatus to PatronSelfRegistrationDefaultCategory * Hide register link unless PatronSelfRegistrationDefaultCategory is set. * Add invalid token page * Add documentation and switches to cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 17:21:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 15:21:43 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-YXZphf71lx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 17:23:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 15:23:18 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-fc6X0UvXvO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #81 from Kyle M Hall <kyle at bywatersolutions.com> --- I guess I should note that no cron script deletes modification to existing borrowers. Those changes will sit in the borrower_modifications table until a librarian either approves or denies the changes, no matter how long that will take. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 17:25:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 15:25:11 +0000 Subject: [Koha-bugs] [Bug 8370] Default checkout, hold and return policy for all library => wrong term In-Reply-To: <bug-8370-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8370-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8370-70-uFTt2C7oA9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8370 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> --- That sounds like a good plan to me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 17:35:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 15:35:18 +0000 Subject: [Koha-bugs] [Bug 8028] Make table collapsing on parcel.pl sticky In-Reply-To: <bug-8028-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8028-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8028-70-6rGik0QO3X@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8028 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 --- Comment #16 from Paul Poulain <paul.poulain at biblibre.com> --- This time it's OK, patch pushed to master ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 17:44:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 15:44:46 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-YFBSyfLKDB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #82 from Owen Leonard <oleonard at myacpl.org> --- Thanks for the clarifications Kyle. Unfortunately I have to ask you to rebase this again since we got a new database revision and changes to SQLHelper.pm -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 17:51:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 15:51:02 +0000 Subject: [Koha-bugs] [Bug 7189] preference to control if returning lost items gives refund In-Reply-To: <bug-7189-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7189-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7189-70-sj6WZGY4CE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7189 --- Comment #20 from Kyle M Hall <kyle at bywatersolutions.com> --- > > When I open > > catalogue/moredetail.pl?biblionumber=21668&itemnumber=23170#item23170 > > I see the "LOST list". If I choose one of them, the book is automatically > > checked-in, that's OK, but the price is not charged to the patron. > > What did I miss ? > > > > (marking passed QA, it's probably me, but I won't push until I could test) I just retested the patch, and everything appears to be working correctly for me. I'm not sure why you are not seeing the replacement price getting charged to the patron when you mark it lost. This patch does not touch that part of the codebase, and there does not appear to be any way to configure Koha to not charge a lost fee when an item is marked as lost from moredetail.pl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 17:52:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 15:52:35 +0000 Subject: [Koha-bugs] [Bug 7189] preference to control if returning lost items gives refund In-Reply-To: <bug-7189-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7189-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7189-70-z4ESSl5y4c@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7189 --- Comment #21 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to comment #20) > > > When I open > > > catalogue/moredetail.pl?biblionumber=21668&itemnumber=23170#item23170 > > > I see the "LOST list". If I choose one of them, the book is automatically > > > checked-in, that's OK, but the price is not charged to the patron. > > > What did I miss ? > > > > > > (marking passed QA, it's probably me, but I won't push until I could test) If you mark a checked out item as lost when on master, does it charge a fee to the borrower? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 18:02:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 16:02:16 +0000 Subject: [Koha-bugs] [Bug 4118] Add Collection Code to Statistics Table In-Reply-To: <bug-4118-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4118-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4118-70-8IjMdGZAeB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4118 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10603|0 |1 is obsolete| | Attachment #10604|0 |1 is obsolete| | Attachment #10887|0 |1 is obsolete| | Attachment #11322|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12172 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12172&action=edit Bug 4118 - Add Collection Code to Statistics Table Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 18:03:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 16:03:31 +0000 Subject: [Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view In-Reply-To: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8597-70-83PTEe2reU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #48 from Paul Poulain <paul.poulain at biblibre.com> --- I have some problems making it work. What I did: * apply all patches * updated opacthemes syspref to ccsr * checked that other css-related sysprefs are empty * cleared all FF cache The display changes when I reduce windows size, but it is ugly (reduced or large) (I also checked with chrome, freshly launched) source code says: <link rel="stylesheet" type="text/css" href="/opac-tmpl/ccsr/en/lib/jquery/jquery-ui.css" /> <link rel="stylesheet" type="text/css" href="/opac-tmpl/ccsr/en/css/opac.css" /> <link rel="stylesheet" type="text/css" media="print" href="/opac-tmpl/ccsr/en/css/print.css" /> <meta name="viewport" content="width=device-width,initial-scale=1.0,maximum-scale=1.0,minimum-scale=1.0,user-scalable=no"> <link rel="stylesheet" type="text/css" media="screen and (max-width:700px)" href="/opac-tmpl/ccsr/en/css/mobile.css" /> which seems OK to me Any hint about something I could have missed welcomed... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 18:11:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 16:11:30 +0000 Subject: [Koha-bugs] [Bug 4118] Add Collection Code to Statistics Table In-Reply-To: <bug-4118-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4118-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4118-70-eKtI7l4A7K@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4118 --- Comment #17 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12173 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12173&action=edit Bug 4118 - Add Collection Code to Statistics Table - Followup -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 18:13:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 16:13:48 +0000 Subject: [Koha-bugs] [Bug 4118] Add Collection Code to Statistics Table In-Reply-To: <bug-4118-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4118-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4118-70-MSgReJAL7x@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4118 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #18 from Kyle M Hall <kyle at bywatersolutions.com> --- > So, 2 options: > * populate ccode in Accounts.pm, when there is an item > * UPDATE by discarding statistics.type='payment' or 'writeoff' (maybe > there are other values, not 100% sure) > > Please choose and resubmit. I suggest you squash the 4 current patches, and > add a follow-up for this QA question Since a payment may be for multiple items, I don't think we should add a ccode for payments, so I have chosen the latter option. I have also squashed the earlier patches per your suggestion. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 18:15:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 16:15:35 +0000 Subject: [Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view In-Reply-To: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8597-70-pOsVSUDrZM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597 --- Comment #49 from Paul Poulain <paul.poulain at biblibre.com> --- OK, it's much better when you add opac.css to opacusercss sypref, but still not perfect (screenshot coming) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 18:16:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 16:16:12 +0000 Subject: [Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view In-Reply-To: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8597-70-5UMla7SDUo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597 --- Comment #50 from Paul Poulain <paul.poulain at biblibre.com> --- Created attachment 12174 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12174&action=edit Qote Of The day Breaking display -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 18:23:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 16:23:14 +0000 Subject: [Koha-bugs] [Bug 8508] Holds to Pull : Library dropdown options are erroneously concatenated by br tags In-Reply-To: <bug-8508-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8508-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8508-70-LA43vdvciR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8508 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12122|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 12175 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12175&action=edit [SIGNED-OFF] Bug 8508 - Holds to Pull : Library dropdown options are erroneously concatenated by br tags This patch introduces a new javascript function that breaks apart option strings that are erroneously concatenated by br tags. The split strings are then checked against non-concatenated option strings, and pushed into the option array if there is no duplication. This function is nestled into the JQuery datatable function for populating the drop-down menu. Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 18:23:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 16:23:38 +0000 Subject: [Koha-bugs] [Bug 8508] Holds to Pull : Library dropdown options are erroneously concatenated by br tags In-Reply-To: <bug-8508-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8508-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8508-70-8ZVWbgjPvh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8508 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Version|rel_3_8 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 18:52:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 16:52:27 +0000 Subject: [Koha-bugs] [Bug 8762] New: Authority links (6xx $9) should not be exported by default Message-ID: <bug-8762-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8762 Priority: P5 - low Change sponsored?: --- Bug ID: 8762 Assignee: gmcharlt at gmail.com Summary: Authority links (6xx $9) should not be exported by default Severity: normal Classification: Unclassified OS: All Reporter: jcamins at cpbibliography.com Hardware: All Status: NEW Version: master Component: Tools Product: Koha Similar to the "Export standard MARC only" option added by bug 7345, the export data tool should at the very least have the option to not export non-standard fields (in particular, authority links). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 18:55:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 16:55:44 +0000 Subject: [Koha-bugs] [Bug 8715] Receiving all serials for a year In-Reply-To: <bug-8715-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8715-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8715-70-SDCNai4fnu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8715 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11945|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 12176 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12176&action=edit [SIGNED-OFF] Bug 8715: Receive all serials for a year. This patch adds - 2 links in the table header (select all and clear all). - Datatable on these tables Test plan: Try to select all serials for a year and receive them. Test there is no regression (ergonomic) on this page Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 19:06:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 17:06:15 +0000 Subject: [Koha-bugs] [Bug 8715] Receiving all serials for a year In-Reply-To: <bug-8715-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8715-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8715-70-sLlE3vEKEs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8715 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 19:23:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 17:23:35 +0000 Subject: [Koha-bugs] [Bug 5911] Transport Cost Matrix of transporting an item between branches In-Reply-To: <bug-5911-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5911-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5911-70-JDDEW0cWlq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5911 --- Comment #59 from Chris Cormack <chris at bigballofwax.co.nz> --- DBD::mysql::db do failed: Can't create table 'koha.transport_cost' (errno: 150) at ./installer/data/mysql/updatedatabase.pl line 5703. (150 is foreign key constraints) This might be specific to the jenkins machine, but just noting why it didnt update properly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 19:58:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 17:58:30 +0000 Subject: [Koha-bugs] [Bug 8017] Remove unnecessary processing on return of GetAllIssues In-Reply-To: <bug-8017-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8017-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8017-70-fZvszAFkiw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8017 Colin Campbell <colin.campbell at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11330|0 |1 is obsolete| | --- Comment #13 from Colin Campbell <colin.campbell at ptfs-europe.com> --- Created attachment 12177 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12177&action=edit Patch rebased against current head Rebased to incorporate changes introduced by the opachtmlsummary code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 20:11:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 18:11:15 +0000 Subject: [Koha-bugs] [Bug 8715] Receiving all serials for a year In-Reply-To: <bug-8715-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8715-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8715-70-AkPjTey3TX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8715 --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 12178 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12178&action=edit Follow-up: Markup changes to improve consistency with other interfaces Follow-up: For consistency, I would prefer to have the column of checkboxes at the beginning of the table and the select/clear links above. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 20:54:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 18:54:25 +0000 Subject: [Koha-bugs] [Bug 8473] Different favicon in the staff client only shows in the english templates In-Reply-To: <bug-8473-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8473-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8473-70-UgE8UU7tJ8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8473 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- I still can't reproduce this. If you're still having this problem and can provide more details, please re-open. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 21:17:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 19:17:12 +0000 Subject: [Koha-bugs] [Bug 8763] New: default messaging not saving if you pick digests Message-ID: <bug-8763-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8763 Priority: P5 - low Change sponsored?: --- Bug ID: 8763 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: default messaging not saving if you pick digests Severity: normal Classification: Unclassified OS: All Reporter: nengard at gmail.com URL: cgi-bin/koha/admin/categorie.pl Hardware: All Status: NEW Version: master Component: Patrons Product: Koha when setting default messaging for patron categories it doesn't save if you choose digest, you have to choose email and digest, but there is no error to tell you that's what's happening. also i think if you select email and digest you get 2 messages instead of just the digest, but that might be another bug. Either way we need to make it clear why the messaging preference wasn't saved or add a note that both email and digest have to be checked for it to save. See: http://screencast.com/t/gA9v3qmYas -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 21:19:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 19:19:02 +0000 Subject: [Koha-bugs] [Bug 8763] default messaging not saving if you pick digests In-Reply-To: <bug-8763-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8763-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8763-70-SvFrD5JZwL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8763 --- Comment #1 from Nicole C. Engard <nengard at gmail.com> --- Btw this happens in 3.8.3 and master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 22:28:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 20:28:54 +0000 Subject: [Koha-bugs] [Bug 8764] New: Template change "Authors" to "Additional authors" in OPAC Message-ID: <bug-8764-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8764 Priority: P5 - low Change sponsored?: --- Bug ID: 8764 Assignee: oleonard at myacpl.org Summary: Template change "Authors" to "Additional authors" in OPAC Severity: trivial Classification: Unclassified OS: All Reporter: dcook at prosentient.com.au Hardware: All Status: NEW Version: master Component: Templates Product: Koha The OPAC is incorrectly labelling Additional authors as Authors. By changing this label to "Additional authors", the OPAC will match the Intranet and order will be restored to the force. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 22:35:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 20:35:40 +0000 Subject: [Koha-bugs] [Bug 8708] RSS feed for new comments is broken In-Reply-To: <bug-8708-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8708-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8708-70-Z4R99WfQyE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8708 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #11 from Chris Cormack <chris at bigballofwax.co.nz> --- Pushed to 3.8.x will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 22:37:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 20:37:14 +0000 Subject: [Koha-bugs] [Bug 8764] Template change "Authors" to "Additional authors" in OPAC In-Reply-To: <bug-8764-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8764-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8764-70-bwBrt111fx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8764 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard at myacpl.org |dcook at prosentient.com.au --- Comment #1 from David Cook <dcook at prosentient.com.au> --- Created attachment 12179 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12179&action=edit Bug 8764 - Template change "Authors" to "Additional authors" in OPAC Super simple template change -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 22:58:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 20:58:26 +0000 Subject: [Koha-bugs] [Bug 8765] New: Add series title to intranet search results Message-ID: <bug-8765-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8765 Priority: P5 - low Change sponsored?: --- Bug ID: 8765 Assignee: oleonard at myacpl.org Summary: Add series title to intranet search results Severity: minor Classification: Unclassified OS: All Reporter: dcook at prosentient.com.au Hardware: All Status: NEW Version: master Component: Templates Product: Koha Currently, the series volume is shown in the intranet search results completely on its own without the series title. It's also prefaced with a comma that currently creates 2 commas in a row and will provide double punctuation when series title is included (provided that people are including their punctuation when they catalogue as they should). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 23:04:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 21:04:53 +0000 Subject: [Koha-bugs] [Bug 8765] Add series title to intranet search results In-Reply-To: <bug-8765-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8765-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8765-70-qDqQLeJhFV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8765 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard at myacpl.org |dcook at prosentient.com.au --- Comment #1 from David Cook <dcook at prosentient.com.au> --- Created attachment 12180 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12180&action=edit Bug 8765 - Add series title to intranet search results I suppose this could be referred to as an enhancement, but it seems more like a bug to have the series volume but not the series title. If we don't want to include the series title in the intranet search results (after all, it's not included in the opac search results), I would propose removing the series volume from the intranet search results, as it is essentially meaningless without the context of the series title. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 23:19:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 21:19:39 +0000 Subject: [Koha-bugs] [Bug 8251] Patrons are systematically debarred at checkin In-Reply-To: <bug-8251-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8251-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8251-70-Sfsf214CJi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8251 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #44 from Chris Cormack <chris at bigballofwax.co.nz> --- Pushed to 3.8.x will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 23:33:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 21:33:22 +0000 Subject: [Koha-bugs] [Bug 8454] Holds to Pull : Show pull list on load. Otherwise, it looks like the pull list is empty. In-Reply-To: <bug-8454-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8454-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8454-70-BJAbxsJgya@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8454 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11499|0 |1 is obsolete| | --- Comment #7 from David Cook <dcook at prosentient.com.au> --- Created attachment 12181 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12181&action=edit Bug 8454 - Show pull list on load. Otherwise, it looks like the pull list is empty - Amended Ahh, I see your logic now. Here's an amended patch that uses your idea. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 12 23:36:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 21:36:02 +0000 Subject: [Koha-bugs] [Bug 8454] Holds to Pull : Show pull list on load. Otherwise, it looks like the pull list is empty. In-Reply-To: <bug-8454-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8454-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8454-70-X5fpWaKGee@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8454 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 00:45:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 22:45:38 +0000 Subject: [Koha-bugs] [Bug 8766] New: OPACBaseURL still called as OPACBaseurl in many files Message-ID: <bug-8766-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8766 Priority: P5 - low Change sponsored?: --- Bug ID: 8766 Assignee: oleonard at myacpl.org Summary: OPACBaseURL still called as OPACBaseurl in many files Severity: minor Classification: Unclassified OS: All Reporter: dcook at prosentient.com.au Hardware: All Status: NEW Version: master Component: Templates Product: Koha OPACBaseurl is still being used in opac-results.tt and opac-opensearch.tt It also shows up in many Poodle files. Note: opac-results.tt doesn't currently get passed OPACBaseURL anyway, but it's still probably a good idea to have it spelled correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 00:45:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 22:45:59 +0000 Subject: [Koha-bugs] [Bug 8766] OPACBaseURL still called as OPACBaseurl in many files In-Reply-To: <bug-8766-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8766-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8766-70-EeXYWhlNcb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8766 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6975 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 00:45:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 22:45:59 +0000 Subject: [Koha-bugs] [Bug 6975] OPACBaseURL called as OPACBaseurl in many templates In-Reply-To: <bug-6975-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6975-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6975-70-ASUREKfVUq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6975 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8766 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 01:05:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 12 Sep 2012 23:05:16 +0000 Subject: [Koha-bugs] [Bug 8766] OPACBaseURL still called as OPACBaseurl in many files In-Reply-To: <bug-8766-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8766-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8766-70-uZE4FmgRno@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8766 --- Comment #1 from David Cook <dcook at prosentient.com.au> --- (In reply to comment #0) > OPACBaseurl is still being used in opac-results.tt and opac-opensearch.tt > > It also shows up in many Poodle files. > > Note: opac-results.tt doesn't currently get passed OPACBaseURL anyway, but > it's still probably a good idea to have it spelled correctly. Pootle :P -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 04:18:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 02:18:03 +0000 Subject: [Koha-bugs] [Bug 8743] ZOOM error when merging authority change to biblios In-Reply-To: <bug-8743-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8743-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8743-70-Ul3dijQCuU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8743 Doug Kingston <dpk at randomnotes.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Doug Kingston <dpk at randomnotes.org> --- I have tested this and completely fixes the problem described. Tested on a 3.08.4 system. Patch applied cleanly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 06:49:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 04:49:53 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: <bug-8375-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8375-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8375-70-LZaPbE1SQC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #16 from wajasu <matted-34813 at mypacks.net> --- Here is an article that helps one see how perl has things internally encoded. Just for future reference. http://blog.twoshortplanks.com/2009/12/02/under-the-hood/ But I'm sure you experts know about this sort of stuff. I think its worth investigating the truetype option. Although I agree that some web font css label solution or such may be the worth pursuing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 09:26:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 07:26:28 +0000 Subject: [Koha-bugs] [Bug 8017] Remove unnecessary processing on return of GetAllIssues In-Reply-To: <bug-8017-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8017-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8017-70-axZq0WddMl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8017 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #14 from Jonathan Druart <jonathan.druart at biblibre.com> --- switching back to passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 09:47:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 07:47:56 +0000 Subject: [Koha-bugs] [Bug 8454] Holds to Pull : Show pull list on load. Otherwise, it looks like the pull list is empty. In-Reply-To: <bug-8454-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8454-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8454-70-Cf6Wjo8sNI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8454 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12181|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 12182 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12182&action=edit Bug 8454 - Holds to Pull : Show pull list on load. Otherwise, it looks like the pull list is empty. Currently, when you click "Holds to pull" from the Circulation menu, the only thing that you see is a white screen and a side navigation bar that says "Refine Results". Since there appear to be no results to refine, the holds to pull list appears completely empty. Staff have to know to click "Submit" on the "Refine Results" form to get anything. I propose that we have the "run_report" flag set to ON for the initial load. The report uses the default 2 days mentioned in the "Refine Results" form, so there is continuity across the board. Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 09:48:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 07:48:18 +0000 Subject: [Koha-bugs] [Bug 8454] Holds to Pull : Show pull list on load. Otherwise, it looks like the pull list is empty. In-Reply-To: <bug-8454-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8454-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8454-70-j0ikzEIlvp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8454 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 09:53:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 07:53:18 +0000 Subject: [Koha-bugs] [Bug 8767] New: Failed to import patrons details from CSV file Message-ID: <bug-8767-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8767 Priority: P5 - low Change sponsored?: --- Bug ID: 8767 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: Failed to import patrons details from CSV file Severity: enhancement Classification: Unclassified OS: All Reporter: vimal0212 at gmail.com Hardware: All Status: NEW Version: rel_3_8 Component: Patrons Product: Koha I got the following error when I tried to import patron details from csv file using the option, Tools > Import Patrons "Gateway Time-out The gateway did not receive a timely response from the upstream server or application." A small amount of patron details imported and process broken and showed the above message. CSV file contained 10000 patrons details. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 09:53:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 07:53:29 +0000 Subject: [Koha-bugs] [Bug 8715] Receiving all serials for a year In-Reply-To: <bug-8715-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8715-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8715-70-9EdY40lAwZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8715 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12178|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 12183 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12183&action=edit [SIGNED-OFF] Bug 8715 [Follow-up] Receiving all serials for a year (In reply to comment #3) > Follow-up: For consistency, I would prefer to have the column of checkboxes > at the beginning of the table and the select/clear links above. Hello owen, Yes you are right, it is more consistent like this. Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 09:53:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 07:53:49 +0000 Subject: [Koha-bugs] [Bug 8767] Failed to import patrons details from CSV file In-Reply-To: <bug-8767-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8767-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8767-70-E0ntu4vVyf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8767 vimal kumar <vimal0212 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 10:21:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 08:21:47 +0000 Subject: [Koha-bugs] [Bug 8508] Holds to Pull : Library dropdown options are erroneously concatenated by br tags In-Reply-To: <bug-8508-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8508-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8508-70-YnTAhQD29v@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8508 --- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 12184 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12184&action=edit Bug 8508: Followup: Simplify the separateData js function I think this patch does the same job as previously. + It replaces tabulation characters with 4 spaces -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 10:23:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 08:23:41 +0000 Subject: [Koha-bugs] [Bug 8508] Holds to Pull : Library dropdown options are erroneously concatenated by br tags In-Reply-To: <bug-8508-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8508-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8508-70-R2LcbR9lE7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8508 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |jonathan.druart at biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> --- Hi Owen and David, Could you confirmed that my proposed patch does the same job as previously ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 10:43:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 08:43:30 +0000 Subject: [Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view In-Reply-To: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8597-70-9hkvpQalG6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597 --- Comment #51 from Paul Poulain <paul.poulain at biblibre.com> --- Even if I discard the QOTD thing, that is minor, there's something that is annoying me with this patch, I'll try to share what. My main question = why does it add a new template, and not just the mobile stuff ? Activating the mobile support means activating ccsr template AND updating opaccolorstylesheet sysprefs. wouldn't the 1st patch + +<meta name="viewport" content="width=device-width,initial-scale=1.0,maximum-scale=1.0,minimum-scale=1.0,user-scalable=no"> +<link rel="stylesheet" type="text/css" media="screen and (max-width:700px)" href="[% themelang %]/css/mobile.css" /> + a prog/css/mobile.css (+ a few other markup changes probably) have achieved the same result ? I think we're doing 2 things in the same patch, and it wrong. I made a little bit test that worked quite well: * applied all patches * set opacthemes=prog * nothing in opaccolorstylesheet * added the 2 previous lines to koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc * copied the mobile.css into prog/ directory => it works well ! (except a few glitches that could be improved later. As conclusion: * the 2 previous lines must be added to this patch to enable mobile support for prog templates, with mobile.css, and tweaking it to solve minor problems. * adding the cssr theme itself is debatable, but i'm not sure it's a good idea to add it = it has been proven over time that maintaining 2 sets of templates is *very* hard. If cssr want to use it's own set, I'm fine with it. But maintaining both sets on official Koha should be a community decision, not something we introduce without warning. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 10:51:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 08:51:12 +0000 Subject: [Koha-bugs] [Bug 8641] Add information warning about log-in as root user to About->System information In-Reply-To: <bug-8641-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8641-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8641-70-RKcZXxu9Uo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8641 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> --- Interesting information to display. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 10:51:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 08:51:23 +0000 Subject: [Koha-bugs] [Bug 8641] Add information warning about log-in as root user to About->System information In-Reply-To: <bug-8641-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8641-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8641-70-l5z2ID2g5M@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8641 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 10:53:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 08:53:29 +0000 Subject: [Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view In-Reply-To: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8597-70-U9gHSx2mCN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #52 from Chris Cormack <chris at bigballofwax.co.nz> --- > > As conclusion: > * the 2 previous lines must be added to this patch to enable mobile support > for prog templates, with mobile.css, and tweaking it to solve minor problems. > * adding the cssr theme itself is debatable, but i'm not sure it's a good > idea to add it = it has been proven over time that maintaining 2 sets of > templates is *very* hard. If cssr want to use it's own set, I'm fine with > it. But maintaining both sets on official Koha should be a community > decision, not something we introduce without warning. Surely people just don't switch to the cssr theme if they don't want it? I really don't see any problem adding another theme. If it isn't maintained we just take it back out. The important thing is that the theme stuff is fixed so we can actually switch themes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 11:02:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 09:02:44 +0000 Subject: [Koha-bugs] [Bug 8644] jQueryUI CSS file should not contain customizations In-Reply-To: <bug-8644-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8644-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8644-70-MzLX4scAd9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8644 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_10 --- Comment #10 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master, could not find anything wrong (except, maybe the fact that staff-global.css is now 2459 lines long, and would take a lot of benefit from being cleaned. But that's another topic ;-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 11:10:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 09:10:30 +0000 Subject: [Koha-bugs] [Bug 8730] browse overlaying powered by In-Reply-To: <bug-8730-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8730-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8730-70-vOEW1vT76c@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8730 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #6 from Jonathan Druart <jonathan.druart at biblibre.com> --- works as expected, simple patch, nothing to say. Marked as Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 11:10:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 09:10:46 +0000 Subject: [Koha-bugs] [Bug 8730] browse overlaying powered by In-Reply-To: <bug-8730-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8730-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8730-70-iVZCjN7PL4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8730 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 11:15:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 09:15:54 +0000 Subject: [Koha-bugs] [Bug 8721] typo in AllowItemsOnHoldCheckout In-Reply-To: <bug-8721-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8721-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8721-70-PtBW3fqLSI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8721 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> --- Typo fix, marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 11:16:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 09:16:15 +0000 Subject: [Koha-bugs] [Bug 8721] typo in AllowItemsOnHoldCheckout In-Reply-To: <bug-8721-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8721-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8721-70-PdcxJRDRXP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8721 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 11:21:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 09:21:28 +0000 Subject: [Koha-bugs] [Bug 8431] Increase the borrower attribute field size from 64 characters to 255 In-Reply-To: <bug-8431-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8431-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8431-70-7CPlvas40L@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8431 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 --- Comment #17 from Paul Poulain <paul.poulain at biblibre.com> --- (In reply to comment #16) > Created attachment 12106 [details] > Bug 8431 - Followup - Use TT filter html_line_break on extended attributes. Thx for the follow-up, but you missed that is is also neede in moremember.tt and opac-userupdate.pl I've updated the 2 templates in a follow-up Patch pushed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 11:27:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 09:27:41 +0000 Subject: [Koha-bugs] [Bug 8719] Private lists always sorted by title (even when author or date is selected) In-Reply-To: <bug-8719-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8719-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8719-70-wcoaxEgyGN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8719 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> --- Short and effective. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 11:27:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 09:27:51 +0000 Subject: [Koha-bugs] [Bug 8719] Private lists always sorted by title (even when author or date is selected) In-Reply-To: <bug-8719-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8719-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8719-70-HhFEtjqoYK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8719 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 11:36:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 09:36:42 +0000 Subject: [Koha-bugs] [Bug 8726] Did you mean? plugin for broader/narrower/related terms In-Reply-To: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8726-70-7mZuTLTfXv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |jonathan.druart at biblibre.co | |m --- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> --- Hi Jared, The patch does not apply anymore, please could you provide a new patch ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 11:37:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 09:37:09 +0000 Subject: [Koha-bugs] [Bug 8768] New: t/ItemType.t fails because DBD::Mock has no empty result set Message-ID: <bug-8768-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8768 Priority: P5 - low Change sponsored?: --- Bug ID: 8768 Assignee: gmcharlt at gmail.com Summary: t/ItemType.t fails because DBD::Mock has no empty result set Severity: enhancement Classification: Unclassified OS: All Reporter: colin.campbell at ptfs-europe.com Hardware: All Status: NEW Version: unspecified Component: Test Suite Product: Koha ItemType.t fails because the second test attempts to retrieve a non existent result set causing an error in DBI The intention of the test is that all returns 0 on an empty table so DBD::Mock should be populated with an empty result set otherwise the test suite fails -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 11:48:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 09:48:20 +0000 Subject: [Koha-bugs] [Bug 8209] "Did you mean?" suggestions based on authorities In-Reply-To: <bug-8209-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8209-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8209-70-j2ZdIUft8o@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8209 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_10 --- Comment #13 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master. 1- I love this feature (and it worked out of the box with UNIMARC) 2- I love the way it's coded, with svc,... ++ for adding webservices 3- will require some work to make it work with Solr... (I feel Koha::SuggestionEngine will have to be moved to Koha::SearchEngine::Zebra::Suggestions or something like that, but that will be for later) 4- you continue introducing OOP with Class::Accessor. I'm a little bit uncomfortable having different OOP methods in Koha. We should debate of this later I think (that will be with you as RM, wont start this discussion now ;-) ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 11:53:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 09:53:02 +0000 Subject: [Koha-bugs] [Bug 8768] t/ItemType.t fails because DBD::Mock has no empty result set In-Reply-To: <bug-8768-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8768-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8768-70-E8tFJBrYt8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8768 Colin Campbell <colin.campbell at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |colin.campbell at ptfs-europe. | |com --- Comment #1 from Colin Campbell <colin.campbell at ptfs-europe.com> --- Created attachment 12185 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12185&action=edit Proposed patch To test with this patch prove t/ItemType.t should run all tests and test two should return ok, running prove -v t/ItemType.t should show 'test 2 - Testing all itemtypes is empty' to have passed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 12:00:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 10:00:57 +0000 Subject: [Koha-bugs] [Bug 8649] C4::Search needs a unit test In-Reply-To: <bug-8649-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8649-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8649-70-XCcxqhGVXF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8649 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_10 --- Comment #18 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master great job ! question = are those tests really db_dependent ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 12:15:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 10:15:58 +0000 Subject: [Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view In-Reply-To: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8597-70-k6NC3lgzwQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597 --- Comment #53 from Mason James <mtj at kohaaloha.com> --- (In reply to comment #52) > > > > As conclusion: > > * the 2 previous lines must be added to this patch to enable mobile support > > for prog templates, with mobile.css, and tweaking it to solve minor problems. > > * adding the cssr theme itself is debatable, but i'm not sure it's a good > > idea to add it = it has been proven over time that maintaining 2 sets of > > templates is *very* hard. If cssr want to use it's own set, I'm fine with > > it. But maintaining both sets on official Koha should be a community > > decision, not something we introduce without warning. > Surely people just don't switch to the cssr theme if they don't want it? I > really don't see any problem adding another theme. If it isn't maintained we > just take it back out. The important thing is that the theme stuff is fixed > so we can actually switch themes. +1 i strongly agree with Chris here adding the 'CCSR' theme will not break any functionality with the current 'Prog' theme maintaining difference sets of templates will become easier, not harder, as we continue to improve Koha Paul, please give us the opportunity to do that -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 13:13:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 11:13:50 +0000 Subject: [Koha-bugs] [Bug 8649] C4::Search needs a unit test In-Reply-To: <bug-8649-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8649-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8649-70-JaZoKfQ6zI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8649 --- Comment #19 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- (In reply to comment #18) > Patch pushed to master > > great job ! > > question = are those tests really db_dependent ? Unfortunately, yes. You don't need any data in your database, but you do have to have a database. One of the BEGIN blocks in one of the modules that C4::Search includes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 13:18:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 11:18:20 +0000 Subject: [Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view In-Reply-To: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8597-70-6xYRPlnqzR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597 --- Comment #54 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- (In reply to comment #51) > Even if I discard the QOTD thing, that is minor, there's something that is > annoying me with this patch, I'll try to share what. > My main question = why does it add a new template, and not just the mobile > stuff ? Activating the mobile support means activating ccsr template AND > updating opaccolorstylesheet sysprefs. > > wouldn't the 1st patch + > +<meta name="viewport" > content="width=device-width,initial-scale=1.0,maximum-scale=1.0,minimum- > scale=1.0,user-scalable=no"> > +<link rel="stylesheet" type="text/css" media="screen and (max-width:700px)" > href="[% themelang %]/css/mobile.css" /> > + a prog/css/mobile.css (+ a few other markup changes probably) > have achieved the same result ? Not without changing the prog display greatly. Personally, I like the ccsr theme a lot better than prog, but it does change things rather a lot. The initial patch changed prog, and I was not comfortable with it because it *forced* everyone to change their layout, breaking any and all custom CSS, and probably a lot of jQuery. Anyone who doesn't like the ccsr theme can just keep using prog. With the changes introduced in this and other patches, maintaining multiple sets of templates will not be too difficult. +1 for pushing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 13:30:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 11:30:51 +0000 Subject: [Koha-bugs] [Bug 8726] Did you mean? plugin for broader/narrower/related terms In-Reply-To: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8726-70-0rI5daoto3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 13:30:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 11:30:54 +0000 Subject: [Koha-bugs] [Bug 8726] Did you mean? plugin for broader/narrower/related terms In-Reply-To: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8726-70-OSNYSUkBt2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12117|0 |1 is obsolete| | --- Comment #6 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12186 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12186&action=edit Bug 8726: ExplodedTerms suggestion plugin When working with hierarchical subject headings, it is sometimes helpful to do a search for all records with a specific subject, plus broader/narrower/related subjects. This patch adds a suggestion plugin for these "exploded" subject searches to Koha. Note that this patch depends on both bug 8211 AND bug 8209. To test (NOTE: this test plan covers both 8211 and 8726): 1) Make sure you have a bunch of hierarchical subjects. I created geographical subjects for "Arizona," "United States," and "Phoenix," and linked them together using 551s, and made sure I had a half dozen records linking to each (but not all to all three). 2) Do a search for su-br:Arizona (or choose "Subject and broader terms" on the advanced search screen with "more options" displayed), and check that you get the records with the subject "Arizona" and the records with the subject "United States" 3) Do a search for su-na:Arizona (or choose "Subject and narrower terms" on the advanced search screen with "more options" displayed), and check that you get the records with the subject "Arizona" and the records with the subject "Phoenix" 4) Do a search for su-rl:Arizona (or choose "Subject and related terms" on the advanced search screen with "more options" displayed), and check that you get the records with the subject "Arizona," the records with the subject "United States," and the records with the subject "Phoenix" 5) Ensure that other searches still work (keyword, subject, ccl, whatever) 6) Use "Did you mean?" page in admin section to enable ExplodedTerms plugin 7) Do a keyword search on the OPAC, confirm that searching for exploded terms is suggested. 8) Do a subject search on the OPAC, confirm that searching for exploded terms is suggested. 9) Do a non-keyword, non-subject search on the OPAC, confirm that searching for exploded terms is NOT suggested. 10) Disable ExplodedTerms plugin and enable AuthorityFile plugin. 11) Do search on OPAC, confirm suggestions are made from authority file. 12) Sign off Signed-off-by: wajasu <matted-34813 at mypacks.net> Note that you will need to shift-refresh in order to get the new Javascript after the latest update to jQueryUI. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 13:40:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 11:40:13 +0000 Subject: [Koha-bugs] [Bug 8209] "Did you mean?" suggestions based on authorities In-Reply-To: <bug-8209-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8209-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8209-70-797QuoM4lc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8209 --- Comment #14 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12187 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12187&action=edit Bug 8209 follow-up: fix failing test in AuthorityFile suggestion plugin The BuildSummary output changed slightly, resulting in labels not showing up and a test failing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 13:40:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 11:40:40 +0000 Subject: [Koha-bugs] [Bug 8209] "Did you mean?" suggestions based on authorities In-Reply-To: <bug-8209-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8209-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8209-70-taMbavkJto@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8209 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12115|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 13:40:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 11:40:57 +0000 Subject: [Koha-bugs] [Bug 8209] "Did you mean?" suggestions based on authorities In-Reply-To: <bug-8209-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8209-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8209-70-hYKHaD8vE1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8209 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 13:41:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 11:41:12 +0000 Subject: [Koha-bugs] [Bug 8209] "Did you mean?" suggestions based on authorities In-Reply-To: <bug-8209-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8209-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8209-70-XuUihfglDR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8209 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 13:53:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 11:53:11 +0000 Subject: [Koha-bugs] [Bug 8366] Meaning of "All" in issuing rules In-Reply-To: <bug-8366-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8366-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8366-70-P6xxn7gzh6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8366 --- Comment #8 from Nicole C. Engard <nengard at gmail.com> --- Sorry for the delay, I was doing some research. Librarians seem to like the idea of going back to 'Default' instead of 'All'. But we might want to ask why it was changed to all originally - who was confused by 'All'? Nicole -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 13:55:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 11:55:46 +0000 Subject: [Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view In-Reply-To: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8597-70-p8JC8ESW5s@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597 --- Comment #55 from Paul Poulain <paul.poulain at biblibre.com> --- (In reply to comment #53) > Paul, please give us the opportunity to do that Just to be clear. I was wondering if it's a good idea. I'm still not sure: > Surely people just don't switch to the cssr theme if they don't want it? mmm... either I've missed something, or we can't keep prog AND get mobile support atm. So, there are 2 options: * keep prog templates & custom css, don't get mobile view. * switch to cssr, get mobile stuff, but completely change the OPAC display, which can (will !) break custom css, html, and things like that. I would much prefer a 3rd option : * keep prog template & custom css AND get mobile view. > I > really don't see any problem adding another theme. If it isn't maintained we > just take it back out. The important thing is that the theme stuff is fixed > so we can actually switch themes. Well, if something is provided in a released version, then we must have a reasonable expectation that it will be maintained. > > wouldn't the 1st patch + > > +<meta name="viewport" > > content="width=device-width,initial-scale=1.0,maximum-scale=1.0,minimum- > > scale=1.0,user-scalable=no"> > > +<link rel="stylesheet" type="text/css" media="screen and (max-width:700px)" > > href="[% themelang %]/css/mobile.css" /> > > + a prog/css/mobile.css (+ a few other markup changes probably) > > have achieved the same result ? > > Not without changing the prog display greatly. Really ? Jared, could you give more details ? I tried and things seems to work quite correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 14:00:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 12:00:05 +0000 Subject: [Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view In-Reply-To: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8597-70-kihXC9RZrp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597 --- Comment #56 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- (In reply to comment #55) > (In reply to comment #53) > > Paul, please give us the opportunity to do that > > Just to be clear. I was wondering if it's a good idea. I'm still not sure: > > Surely people just don't switch to the cssr theme if they don't want it? > mmm... either I've missed something, or we can't keep prog AND get mobile > support atm. > So, there are 2 options: > * keep prog templates & custom css, don't get mobile view. > * switch to cssr, get mobile stuff, but completely change the OPAC display, > which can (will !) break custom css, html, and things like that. That is correct. > I would much prefer a 3rd option : > * keep prog template & custom css AND get mobile view. > > I > > really don't see any problem adding another theme. If it isn't maintained we > > just take it back out. The important thing is that the theme stuff is fixed > > so we can actually switch themes. > Well, if something is provided in a released version, then we must have a > reasonable expectation that it will be maintained. I will be using ccsr instead of prog, so I will certainly be maintaining it for the next several versions at least. When I said "if it isn't maintained" I had in mind people getting bored of it in a few years, not for 3.12 or 3.14. Also, the ccsr theme involves very few files, really. > > > wouldn't the 1st patch + > > > +<meta name="viewport" > > > content="width=device-width,initial-scale=1.0,maximum-scale=1.0,minimum- > > > scale=1.0,user-scalable=no"> > > > +<link rel="stylesheet" type="text/css" media="screen and (max-width:700px)" > > > href="[% themelang %]/css/mobile.css" /> > > > + a prog/css/mobile.css (+ a few other markup changes probably) > > > have achieved the same result ? > > > > Not without changing the prog display greatly. > Really ? Jared, could you give more details ? I tried and things seems to > work quite correctly. I don't have screenshots, nor time to test, but it made a mess of the masthead area, and conflicted with custom CSS to do that. Also, prog is hideous. I think the ccsr theme would be worthwhile even without mobile support. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 14:15:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 12:15:33 +0000 Subject: [Koha-bugs] [Bug 8209] "Did you mean?" suggestions based on authorities In-Reply-To: <bug-8209-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8209-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8209-70-rg8pHs5vr1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8209 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #15 from Paul Poulain <paul.poulain at biblibre.com> --- follow-up fixes the test errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 14:15:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 12:15:51 +0000 Subject: [Koha-bugs] [Bug 8209] "Did you mean?" suggestions based on authorities In-Reply-To: <bug-8209-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8209-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8209-70-113bqtM5z5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8209 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 14:15:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 12:15:59 +0000 Subject: [Koha-bugs] [Bug 8209] "Did you mean?" suggestions based on authorities In-Reply-To: <bug-8209-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8209-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8209-70-K7nfxzJhtb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8209 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 14:30:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 12:30:08 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: <bug-7417-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7417-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7417-70-d7xk4eA0xc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 --- Comment #48 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 14:36:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 12:36:34 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-9KSTvfGZkb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #46 from Jonathan Druart <jonathan.druart at biblibre.com> --- QA Comments: Great patch :) Code clean and easy to read. Some remarks: Blocker: * perlcritic does not pass on course_reserves/add_items.pl: Variable declared in conditional statement at line 60, column 5. Declare variables outside of the condition. (Severity: 5) easy to solve. * It would be good to have an information (close to "Department" and "Term" on the create course page) to explain how to add departments and terms. not blocker: - There is a "dot" before the li element of the instructor result list (overflow). - the edit is on the course.pl and redirects to mod_course.pl, it is ambiguous but the code is short and clean so I understand this choice. - add_items-step1.tt and add_items-step2.tt could be merged into 1 template - It would be easier to use DataTable for the course reserves list. Thus the search form would have become useless -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 14:36:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 12:36:45 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-v2qq05FYzP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 15:32:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 13:32:16 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-U80IvrTROh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #47 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12188 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12188&action=edit Bug 8215 - Add Course Reserves - QA Followup * Fix perlcritic error. * Add warnings if DEPT and TERM authorised values are not defined. * Enable datatables on courses table, hide old search. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 15:32:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 13:32:38 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-ezJbZhsWAE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 16:05:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 14:05:23 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-kAzlPPTNQY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #48 from Jonathan Druart <jonathan.druart at biblibre.com> --- The VA is DEPARTMENT, not DEPT :) (the patch displays "No DEPT authorised values found!") -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 16:07:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 14:07:02 +0000 Subject: [Koha-bugs] [Bug 8274] count of suggestions on main page wrong In-Reply-To: <bug-8274-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8274-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8274-70-S0nJelTWxD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8274 Robin Sheat <robin at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7300 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 16:07:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 14:07:02 +0000 Subject: [Koha-bugs] [Bug 7300] display suggestions from librarian library only by default In-Reply-To: <bug-7300-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7300-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7300-70-cCGMJ9mIv2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7300 Robin Sheat <robin at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8274 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 16:22:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 14:22:06 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-rGx9TKJFeD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12188|0 |1 is obsolete| | --- Comment #49 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12189 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12189&action=edit Bug 8215 - Add Course Reserves - QA Followup * Fix perlcritic error. * Add warnings if DEPARTMENT or TERM authorised values are not defined. * Enable datatables on courses table, hide old search. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 16:23:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 14:23:22 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-PdYGdGBv8S@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #50 from Kyle M Hall <kyle at bywatersolutions.com> --- Fixed. Good catch! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 16:28:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 14:28:39 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-Jen5vtvBbD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12013|0 |1 is obsolete| | --- Comment #83 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12190 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12190&action=edit Bug 7067 - OPAC Borrower Self Registration Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 16:28:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 14:28:57 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-ZcH8YOb1Ki@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12171|0 |1 is obsolete| | --- Comment #84 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12191 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12191&action=edit Bug 7067 - OPAC Borrower Self Registration - Followup * Rename PatronSelfRegistrationUseTemporaryStatus to PatronSelfRegistrationDefaultCategory * Hide register link unless PatronSelfRegistrationDefaultCategory is set. * Add invalid token page * Add documentation and switches to cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 16:29:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 14:29:53 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-I9XOsqrRLq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 16:31:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 14:31:04 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-GDXr9sRJ5g@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12189|0 |1 is obsolete| | --- Comment #51 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 12192 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12192&action=edit Bug 8215 - Add Course Reserves - QA Followup * Fix perlcritic error. * Add warnings if DEPARTMENT or TERM authorised values are not defined. * Enable datatables on courses table, hide old search. Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 16:47:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 14:47:47 +0000 Subject: [Koha-bugs] [Bug 2060] Ability to import Authorities from Staff Client In-Reply-To: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2060-70-YS28qxRMCl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2060 --- Comment #29 from SJeffery <steven_jeffery at fmi.com> --- I tested this and have the following comments: 1. Possible future enhancement: I can see many libraries requiring the script link_bibs_to_authorities.pl to be running in order for this to function properly. As a librarian, I would never know that there is a separate script that needs to be run in order to get my imported authorities to actually work. This script may need to be integrated into Koha a bit better. 2. Possible future enhancement: There does not seem to be a good way to match author (and possibly other types of) authority records at time of import. That said, this patch works and I am signing off on it. Please note that I am working remotely so can not sign off in the code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 16:55:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 14:55:58 +0000 Subject: [Koha-bugs] [Bug 3462] Link see alsos in authorities In-Reply-To: <bug-3462-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3462-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3462-70-m8jXlMMe22@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3462 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 --- Comment #19 from Paul Poulain <paul.poulain at biblibre.com> --- (In reply to comment #17) > A follow-up patch > could remove the auth_types.summary bit, if you wanted. I think it would be useful to have a consistent behaviour for UNIMARC and MARC21, so yes, a follow-up patch would be good. does the "if you wanted" imply you will write it, or is it a "do it yourself if you want it" ? (in the 2nd option, it will wait until i'm no more RM I think ;-) Plus I don't know the MARC21 behaviour at all for now :\ ) Other than this: patch pushed (I haven't tested it, because in UNIMARC there's no difference. trusting kf for testing well) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 16:59:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 14:59:33 +0000 Subject: [Koha-bugs] [Bug 3462] Link see alsos in authorities In-Reply-To: <bug-3462-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3462-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3462-70-Z6dGATn6tu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3462 --- Comment #20 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- (In reply to comment #19) > (In reply to comment #17) > > A follow-up patch > > could remove the auth_types.summary bit, if you wanted. > > I think it would be useful to have a consistent behaviour for UNIMARC and > MARC21, so yes, a follow-up patch would be good. > does the "if you wanted" imply you will write it, or is it a "do it yourself > if you want it" ? > (in the 2nd option, it will wait until i'm no more RM I think ;-) Plus I > don't know the MARC21 behaviour at all for now :\ ) I would write it, but only if you wanted me to. :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 17:04:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 15:04:32 +0000 Subject: [Koha-bugs] [Bug 8769] New: Allow SIP2 return backdating Message-ID: <bug-8769-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 Priority: P5 - low Change sponsored?: --- Bug ID: 8769 CC: colin.campbell at ptfs-europe.com Assignee: koha-bugs at lists.koha-community.org Summary: Allow SIP2 return backdating Severity: enhancement Classification: Unclassified OS: All Reporter: kyle at bywatersolutions.com Hardware: All Status: NEW Version: master Component: SIP2 Product: Koha Currently Koha's SIP server ignores the return date part of an 09 ( aka CHECKIN ) message. Koha should backdate a return, and remove fine accordingly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 17:05:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 15:05:20 +0000 Subject: [Koha-bugs] [Bug 8769] Allow SIP2 return backdating In-Reply-To: <bug-8769-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8769-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8769-70-KjXp2coiua@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8769 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12193 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12193&action=edit Bug 8769 - WIP - Allow SIP2 return backdating -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 17:15:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 15:15:39 +0000 Subject: [Koha-bugs] [Bug 3462] Link see alsos in authorities In-Reply-To: <bug-3462-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3462-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3462-70-hxlH53aKzb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3462 --- Comment #21 from Paul Poulain <paul.poulain at biblibre.com> --- (In reply to comment #20) > I would write it, but only if you wanted me to. :) /me throw a coin ... jared face appear. OK, you win, if you know & agree to write it, you'll be thanked for centuries -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 17:36:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 15:36:28 +0000 Subject: [Koha-bugs] [Bug 8209] "Did you mean?" suggestions based on authorities In-Reply-To: <bug-8209-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8209-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8209-70-gW1tT76SlI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8209 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 17:36:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 15:36:31 +0000 Subject: [Koha-bugs] [Bug 8209] "Did you mean?" suggestions based on authorities In-Reply-To: <bug-8209-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8209-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8209-70-81YNbxWWJF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8209 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12187|0 |1 is obsolete| | --- Comment #16 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12194 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12194&action=edit Bug 8209 follow-up: another correction for BuildSummary API -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 17:45:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 15:45:42 +0000 Subject: [Koha-bugs] [Bug 2060] Ability to import Authorities from Staff Client In-Reply-To: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2060-70-eRwF1KcVfw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2060 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #30 from Paul Poulain <paul.poulain at biblibre.com> --- I'm trying to test this patch. Test plan: * search an authority, and export it in iso2709 unicode * go to stage-marc-import.pl and upload it, specifying it's an authority * go to manage-marc-import.pl, check it's an authority (Type: Authority records is displayed => OK) the manage-marc-import.pl says: Add new bibliographic records into this framework: <list of biblio frameworks> There's also: Item processing: <Always add items> I think it's wrong. Just behind, the citation is empty Hitting "Import this batch into the catalogue" fails = the job progress stays to 0% forever Side question = is it supposed to work well in UNIMARC ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 17:46:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 15:46:10 +0000 Subject: [Koha-bugs] [Bug 2060] Ability to import Authorities from Staff Client In-Reply-To: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2060-70-YLNePHlUs3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2060 --- Comment #31 from Paul Poulain <paul.poulain at biblibre.com> --- Created attachment 12195 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12195&action=edit screenshot for my previous comment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 17:48:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 15:48:27 +0000 Subject: [Koha-bugs] [Bug 8209] "Did you mean?" suggestions based on authorities In-Reply-To: <bug-8209-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8209-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8209-70-n5Stfqprdz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8209 --- Comment #17 from Paul Poulain <paul.poulain at biblibre.com> --- (In reply to comment #16) > Created attachment 12194 [details] > Bug 8209 follow-up: another correction for BuildSummary API Status set to "in discussion" ? shouldn't it be "need signoff" ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 17:50:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 15:50:08 +0000 Subject: [Koha-bugs] [Bug 2060] Ability to import Authorities from Staff Client In-Reply-To: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2060-70-TMSTN3nxUb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2060 --- Comment #32 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Did you run the database update? That's what it looks like when you don't. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 17:50:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 15:50:39 +0000 Subject: [Koha-bugs] [Bug 8209] "Did you mean?" suggestions based on authorities In-Reply-To: <bug-8209-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8209-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8209-70-s3E1b9FSaR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8209 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #18 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Yes, sorry. I got only halfway through the status changing dance. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 17:54:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 15:54:19 +0000 Subject: [Koha-bugs] [Bug 7500] Use CSS Sprites for faster page loading In-Reply-To: <bug-7500-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7500-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7500-70-dIBvEV8UKe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #31 from Paul Poulain <paul.poulain at biblibre.com> --- The 3 follow-up have been pushed to master: Bug 7500 [FOLLOW-UP][Star ratings] Use CSS Sprites for faster page loading Bug 7500 [FOLLOW-UP][Missing images] Use CSS Sprites for faster page loading Bug 7500 [FOLLOW-UP, revised][Social networks] Use CSS Sprites for faster page loading (does not apply to new/Bug_7500, that is old, so pushed directly to master) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 17:56:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 15:56:00 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7143-70-CCnpVuMwSV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12158|0 |1 is obsolete| | --- Comment #55 from Paul Poulain <paul.poulain at biblibre.com> --- Comment on attachment 12158 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12158 [PASSED-QA]Bug 7143: Adding Kathryn Tyree to the history and About page. Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 17:56:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 15:56:13 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-Xuw2inoWn5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #85 from Owen Leonard <oleonard at myacpl.org> --- Sorry: Applying: Bug 7067 - OPAC Borrower Self Registration error: patch failed: installer/data/mysql/sysprefs.sql:372 error: installer/data/mysql/sysprefs.sql: patch does not apply Patch failed at 0001 Bug 7067 - OPAC Borrower Self Registration -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 17:57:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 15:57:47 +0000 Subject: [Koha-bugs] [Bug 8761] Correct compile time warnings in C4::Circulation In-Reply-To: <bug-8761-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8761-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8761-70-KeNv93zETt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8761 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 --- Comment #7 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master +1 to karma colin ;-) Chris_c = not sure this is needed or applying on 3.8 though -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 18:08:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 16:08:41 +0000 Subject: [Koha-bugs] [Bug 5790] Deleting a biblio should alert/fail if there are existent subscriptions and holds In-Reply-To: <bug-5790-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5790-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5790-70-4fke3Y6yKv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5790 Gaetan Boisson <gaetan.boisson at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gaetan.boisson at biblibre.com --- Comment #9 from Gaetan Boisson <gaetan.boisson at biblibre.com> --- This is still an issue it seems. Also i think if what we do now is to delete the subscription silently, it's not so bad : what should happen in my opinion is that the user whould be warned that his action will also affect X subscirptions. But if that is what they want to do then it's a lot more simple to just delete the biblio than to go through all the subsriptions first, and then back to the biblio. So i would say, on the subscription side, just add a warning. On the holds side, well that's a bit more complicated ;) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 18:09:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 16:09:16 +0000 Subject: [Koha-bugs] [Bug 5781] Cannot delete order if attached biblio does no longer exist In-Reply-To: <bug-5781-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5781-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5781-70-xkQ256SIkr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5781 Gaetan Boisson <gaetan.boisson at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gaetan.boisson at biblibre.com --- Comment #1 from Gaetan Boisson <gaetan.boisson at biblibre.com> --- This bug is still current in master. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 18:10:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 16:10:49 +0000 Subject: [Koha-bugs] [Bug 7986] Export issues In-Reply-To: <bug-7986-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7986-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7986-70-slEpgAiycY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 --- Comment #27 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master with 2 tiny string changes to fix English & a better translatability Note that I'm not a fan of adding a new information to the circulation screen. I had preferred something less visible. I've no counter-proposal, so I've pushed, but some ergonomic improvement would be cool. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 18:13:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 16:13:01 +0000 Subject: [Koha-bugs] [Bug 8598] No patron image or home library on Files & Statistics tabs In-Reply-To: <bug-8598-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8598-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8598-70-tHcm7DWyt2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8598 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 --- Comment #6 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 18:16:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 16:16:12 +0000 Subject: [Koha-bugs] [Bug 5781] Cannot delete order if attached biblio does no longer exist In-Reply-To: <bug-5781-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5781-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5781-70-4WtRhJelM7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5781 --- Comment #2 from Gaetan Boisson <gaetan.boisson at biblibre.com> --- Ideally i think the order should be deleted as well when deleting the biblio, with a specific warning about the user is about to do, and a permission check : the user should not be allowed to delete the biblio if he has no permissions on acquisitions. Alternatively, the alert could just say "there is an order on this biblio and it cannot be deleted" and link directly to the order. From there the user could delete both order and biblio. There is no screen to manage just a biblio though, so the user should be redirected on the basket page as long as the basket wasn't closed and on the reception page if the basket was closed. Biblios in basket that have been closed but in a basket group that is still open, or in no basket group, drift in limbo somewhere in between. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 18:19:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 16:19:56 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-4hDwEwujwJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12190|0 |1 is obsolete| | --- Comment #86 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12196 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12196&action=edit Bug 7067 - OPAC Borrower Self Registration Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 18:20:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 16:20:12 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-NzZI8gUL2L@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12191|0 |1 is obsolete| | --- Comment #87 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12197 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12197&action=edit Bug 7067 - OPAC Borrower Self Registration - Followup * Rename PatronSelfRegistrationUseTemporaryStatus to PatronSelfRegistrationDefaultCategory * Hide register link unless PatronSelfRegistrationDefaultCategory is set. * Add invalid token page * Add documentation and switches to cron scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 18:23:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 16:23:55 +0000 Subject: [Koha-bugs] [Bug 7068] autobarcode not working when duplicating patrons In-Reply-To: <bug-7068-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7068-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7068-70-O3vrKQpQ6J@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7068 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 --- Comment #6 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 18:25:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 16:25:15 +0000 Subject: [Koha-bugs] [Bug 3456] Serials receipt note In-Reply-To: <bug-3456-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3456-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3456-70-Xs0Bsugb82@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3456 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 Severity|enhancement |minor --- Comment #7 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master I think it can be considered as a minor bugfix, this information is lacking when you recieve a serial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 18:26:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 16:26:19 +0000 Subject: [Koha-bugs] [Bug 8716] Reordering of routing list entries doesn't work In-Reply-To: <bug-8716-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8716-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8716-70-zokaghuOOg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8716 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 --- Comment #5 from Paul Poulain <paul.poulain at biblibre.com> --- patch pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 18:27:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 16:27:22 +0000 Subject: [Koha-bugs] [Bug 8677] table overlapping to the right on holds waiting In-Reply-To: <bug-8677-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8677-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8677-70-fX4j1Qh9oA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8677 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 --- Comment #4 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 18:33:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 16:33:59 +0000 Subject: [Koha-bugs] [Bug 7583] undo receive In-Reply-To: <bug-7583-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7583-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7583-70-CHgii1Rxob@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7583 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 --- Comment #17 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master I've pushed the patch, but ask for a small follow-up = asking for a confirmation when you click on "cancel receipt". One would say that you can recieve again if you want. That's true. But you could inadvertently delete an existing item if AcqCreateItem is 'receiving' ! So a confirmation would be more safe. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 18:36:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 16:36:16 +0000 Subject: [Koha-bugs] [Bug 8339] div id="login" should be id="login_controls" in header.inc In-Reply-To: <bug-8339-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8339-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8339-70-pWzAWoGcwx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8339 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 --- Comment #13 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 18:47:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 16:47:06 +0000 Subject: [Koha-bugs] [Bug 2060] Ability to import Authorities from Staff Client In-Reply-To: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2060-70-7NCG0FDdDb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2060 --- Comment #33 from Paul Poulain <paul.poulain at biblibre.com> --- Created attachment 12198 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12198&action=edit unimarc authority used for testing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 18:50:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 16:50:36 +0000 Subject: [Koha-bugs] [Bug 4118] Add Collection Code to Statistics Table In-Reply-To: <bug-4118-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4118-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4118-70-vANeiJPk1G@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4118 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|unspecified |rel_3_10 --- Comment #19 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master My database does not contain ccode, so I could not check that the updatedatabase really worked properly (at least the column is created) A nice follow-up could be to have the line "collection" not visible on reports/issues_stats.pl is there is nothing in the list. But it's not worth failing QA for that ;-) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 18:55:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 16:55:29 +0000 Subject: [Koha-bugs] [Bug 8017] Remove unnecessary processing on return of GetAllIssues In-Reply-To: <bug-8017-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8017-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8017-70-uKwiKFHiGm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8017 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 Severity|enhancement |minor --- Comment #15 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master. Could be ported to 3.8 imo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 18:58:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 16:58:07 +0000 Subject: [Koha-bugs] [Bug 8641] Add information warning about log-in as root user to About->System information In-Reply-To: <bug-8641-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8641-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8641-70-bChGW8TmUA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8641 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_10 --- Comment #4 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master. I would not object having this warning more prominent, like: * appearing on mainpage.pl * appearing in red on about.pl & on the 1st tab displayed As it is now, I feel it won't be seen by a lot of ppl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 19:02:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 17:02:24 +0000 Subject: [Koha-bugs] [Bug 2060] Ability to import Authorities from Staff Client In-Reply-To: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2060-70-mhhOtSk6tU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2060 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #34 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Marking back to Passed QA, as it would seem the UNIMARC authority in question was entirely garbled by the Koha export. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 19:04:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 17:04:50 +0000 Subject: [Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view In-Reply-To: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8597-70-kqsBC2eBm6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #57 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think it's great that the themes are working again and as I understand it you don't have to create a whole set, you can also use it and only change a view files. Also I think this is a great chance to introduce something new in a very safe way - if people like it, we will have to discuss how to move on with themes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 19:38:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 17:38:29 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: <bug-7417-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7417-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7417-70-50u5u52xM0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 19:38:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 17:38:36 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: <bug-7417-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7417-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7417-70-OaE6vNddYF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12147|0 |1 is obsolete| | Attachment #12148|0 |1 is obsolete| | --- Comment #49 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12199 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12199&action=edit Bug 7417 follow-up: fix a perlcritic violation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 19:39:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 17:39:41 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: <bug-7417-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7417-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7417-70-Dn6uQ7SULg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 19:44:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 17:44:46 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: <bug-7417-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7417-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7417-70-j48DBIrGQ6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12199|0 |1 is obsolete| | --- Comment #50 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12200 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12200&action=edit Bug 7417 follow-up: fix a perlcritic violation Forgot to add one file to the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 20:13:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 18:13:06 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-QbslwLBBy5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #88 from Owen Leonard <oleonard at myacpl.org> --- I'm ready to sign off on this, but I'm wondering if this issue is something which can be left to a follow-up or if it will fail QA without it: (In reply to comment #60) > There's no reason not to have the cronjob run once a minute, but if we start > recommending that configuration, it will need to be patched to use a > lockfile so that it doesn't allow simultaneous jobs to run if it takes > longer than a minute to clear the message queue. I have some template-related fixups but I'd like to get these patches signed off first. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 20:35:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 18:35:47 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-08wKMPBPsr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #89 from Owen Leonard <oleonard at myacpl.org> --- Oops, new small glitch: If PatronSelfRegistrationVerifyByEmail is set to "require," the Primary email field in the patron record update form in the OPAC becomes mandatory even if it's not listed in PatronSelfRegistrationBorrowerMandatoryField. If it's not listed in PatronSelfRegistrationBorrowerMandatoryField and the patron is doing an update, not a new registration, the field should not be required. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 21:04:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 19:04:54 +0000 Subject: [Koha-bugs] [Bug 8770] New: amount does not equal amountoutstanding on a fine with no payments or credits Message-ID: <bug-8770-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8770 Priority: P5 - low Change sponsored?: --- Bug ID: 8770 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: amount does not equal amountoutstanding on a fine with no payments or credits Severity: blocker Classification: Unclassified OS: All Reporter: melia at bywatersolutions.com Hardware: All Status: NEW Version: rel_3_8 Component: Circulation Product: Koha Fine amount is being correctly calculated. The amountoutstanding does not agree with the amount, even when no payments or credits have been made. This seems to affect lost items in particular. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 21:11:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 19:11:29 +0000 Subject: [Koha-bugs] [Bug 8770] amount does not equal amountoutstanding on a fine with no payments or credits In-Reply-To: <bug-8770-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8770-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8770-70-jtZuQ9GI73@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8770 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #1 from Chris Cormack <chris at bigballofwax.co.nz> --- This is definitely a regression. Since this has worked for the 12 years up to now. Whomever fixes it, (should be able to track it down with git bisect) should make sure to write tests for this behaviour -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 22:59:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 20:59:59 +0000 Subject: [Koha-bugs] [Bug 8524] Add barcode plugin that does not autofill In-Reply-To: <bug-8524-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8524-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8524-70-nkJeyYaROq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8524 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz Version|rel_3_10 |master --- Comment #19 from Chris Cormack <chris at bigballofwax.co.nz> --- After no objections, this was pushed to 3.8.x and will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 23:02:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 21:02:34 +0000 Subject: [Koha-bugs] [Bug 8770] amount does not equal amountoutstanding on a fine with no payments or credits In-Reply-To: <bug-8770-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8770-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8770-70-qvtV3CUUKj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8770 --- Comment #2 from Melia Meggs <melia at bywatersolutions.com> --- Created attachment 12201 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12201&action=edit amount =! amountoutstanding screenshot1 Here are some screenshots, if it helps. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 23:03:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 21:03:10 +0000 Subject: [Koha-bugs] [Bug 8770] amount does not equal amountoutstanding on a fine with no payments or credits In-Reply-To: <bug-8770-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8770-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8770-70-IUdeNM4vtm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8770 --- Comment #3 from Melia Meggs <melia at bywatersolutions.com> --- Created attachment 12202 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12202&action=edit amount != amountoutstanding screenshot2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 23:04:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 21:04:01 +0000 Subject: [Koha-bugs] [Bug 8770] amount does not equal amountoutstanding on a fine with no payments or credits In-Reply-To: <bug-8770-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8770-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8770-70-cVHKstCis0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8770 --- Comment #4 from Melia Meggs <melia at bywatersolutions.com> --- Created attachment 12203 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12203&action=edit amount != amountoutstanding screenshot3 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 23:04:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 21:04:46 +0000 Subject: [Koha-bugs] [Bug 8770] amount does not equal amountoutstanding on a fine with no payments or credits In-Reply-To: <bug-8770-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8770-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8770-70-rWVKAzdr4a@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8770 --- Comment #5 from Chris Cormack <chris at bigballofwax.co.nz> --- Can you check the database, check the accountlines table, what type are those ones that don't match, 'F' ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 13 23:09:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 21:09:14 +0000 Subject: [Koha-bugs] [Bug 8770] amount does not equal amountoutstanding on a fine with no payments or credits In-Reply-To: <bug-8770-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8770-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8770-70-EJ0wbhTlf0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8770 --- Comment #6 from Melia Meggs <melia at bywatersolutions.com> --- I can't check that particular one because I can't make their silly VPN work, but I have another example from a different library of the same thing. This one is also related to a lost item that was later returned (I think?). The one with the wrong amountoutstanding is accounttype F. It looks like this: mysql> SELECT * FROM accountlines WHERE borrowernumber = 323737\G; *************************** 1. row *************************** borrowernumber: 323737 accountno: 2 itemnumber: 700451 date: 2012-08-22 amount: 3.950000 description: Froggy goes to Hawaii / 05/22/2012 23:59 dispute: NULL accounttype: F amountoutstanding: 2.950000 lastincrement: 0.050000 timestamp: 2012-08-22 16:42:19 notify_id: 0 notify_level: 0 note: NULL manager_id: NULL *************************** 2. row *************************** borrowernumber: 323737 accountno: 3 itemnumber: 700451 date: 2012-07-30 amount: 15.990000 description: Lost Item Froggy goes to Hawaii / 31319001350302 dispute: NULL accounttype: LR amountoutstanding: 0.000000 lastincrement: NULL timestamp: 2012-08-22 16:42:19 notify_id: 0 notify_level: 0 note: NULL manager_id: NULL *************************** 3. row *************************** borrowernumber: 323737 accountno: 4 itemnumber: NULL date: 2012-08-22 amount: -15.990000 description: Item Returned 31319001350302 dispute: NULL accounttype: CR amountoutstanding: 0.000000 lastincrement: NULL timestamp: 2012-08-22 16:42:19 notify_id: 0 notify_level: 0 note: NULL manager_id: NULL 3 rows in set (0.00 sec) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 00:23:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 22:23:08 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7143-70-aTkHXXnTDc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 00:30:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 22:30:45 +0000 Subject: [Koha-bugs] [Bug 8598] No patron image or home library on Files & Statistics tabs In-Reply-To: <bug-8598-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8598-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8598-70-QserpZW0d2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8598 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Version|rel_3_8 |rel_3_10 --- Comment #7 from Chris Cormack <chris at bigballofwax.co.nz> --- These files do not exist in 3.8.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 00:33:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 22:33:32 +0000 Subject: [Koha-bugs] [Bug 7068] autobarcode not working when duplicating patrons In-Reply-To: <bug-7068-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7068-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7068-70-L0QRqOtFke@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7068 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris at bigballofwax.co.nz> --- Applies and works, pushed to 3.8.x, will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 00:43:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 22:43:56 +0000 Subject: [Koha-bugs] [Bug 3456] Serials receipt note In-Reply-To: <bug-3456-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3456-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3456-70-af19lmAI6c@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3456 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Chris Cormack <chris at bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 01:01:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 23:01:45 +0000 Subject: [Koha-bugs] [Bug 8716] Reordering of routing list entries doesn't work In-Reply-To: <bug-8716-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8716-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8716-70-ugJ99oKO9p@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8716 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris at bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 01:05:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 23:05:49 +0000 Subject: [Koha-bugs] [Bug 8677] table overlapping to the right on holds waiting In-Reply-To: <bug-8677-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8677-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8677-70-t0bWMbqWgg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8677 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris at bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 01:08:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 23:08:46 +0000 Subject: [Koha-bugs] [Bug 8677] table overlapping to the right on holds waiting In-Reply-To: <bug-8677-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8677-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8677-70-tay737GjbH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8677 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 01:35:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 13 Sep 2012 23:35:29 +0000 Subject: [Koha-bugs] [Bug 8339] div id="login" should be id="login_controls" in header.inc In-Reply-To: <bug-8339-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8339-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8339-70-Bq9JQMSa6f@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8339 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #14 from Chris Cormack <chris at bigballofwax.co.nz> --- Pushed to 3.8.x will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 02:53:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 00:53:51 +0000 Subject: [Koha-bugs] [Bug 7986] Export issues In-Reply-To: <bug-7986-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7986-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7986-70-duXi4VZ7VU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 --- Comment #28 from Owen Leonard <oleonard at myacpl.org> --- (In reply to comment #27) > Note that I'm not a fan of adding a new information to the circulation > screen. I had preferred something less visible. I agree, and I'm sorry I didn't see this until now. I would definitely like to come up with an alternative solution. We already have an "export checkins" option under the "More" menu (at least on some pages--it hasn't been added to all the necessary includes for it to be consistent), and now we have a new export option in a different place. What if we put both export options into a new tab on the "Circulation history" page? Both are directly related to circulation history. Are they operations which happen so frequently that putting them onto another page would cause problems? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 03:40:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 01:40:49 +0000 Subject: [Koha-bugs] [Bug 8017] Remove unnecessary processing on return of GetAllIssues In-Reply-To: <bug-8017-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8017-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8017-70-iNHKedkM7n@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8017 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #16 from Chris Cormack <chris at bigballofwax.co.nz> --- I would like this in 3.8.x but unfortunately does not apply cleanly # Changes to be committed: # # modified: C4/Members.pm # modified: koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt # modified: members/readingrec.pl # # Unmerged paths: # (use "git add/rm <file>..." as appropriate to mark resolution) # # both modified: koha-tmpl/opac-tmpl/prog/en/modules/opac-readingrecord.tt # both modified: opac/opac-readingrecord.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 04:05:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 02:05:06 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: <bug-7417-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7417-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7417-70-PbC2aJ6i4A@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12200|0 |1 is obsolete| | --- Comment #51 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 12204 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12204&action=edit Bug 7417 follow-up: fix a perlcritic violation Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 04:07:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 02:07:56 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: <bug-7417-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7417-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7417-70-iRcRHIV9yz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #52 from Chris Cormack <chris at bigballofwax.co.nz> --- No longer fails perlcritic tests, signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 04:32:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 02:32:23 +0000 Subject: [Koha-bugs] [Bug 8768] t/ItemType.t fails because DBD::Mock has no empty result set In-Reply-To: <bug-8768-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8768-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8768-70-ryTyQaNnDK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8768 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris at bigballofwax.co.nz --- Comment #2 from Chris Cormack <chris at bigballofwax.co.nz> --- Hmm I dont see the fail before the patch prove t/ItemType.t 2012-09-14 14:28:40 chrisc pts/1 t/ItemType.t .. ok All tests successful. Files=1, Tests=15, 1 wallclock secs ( 0.05 usr 0.01 sys + 0.12 cusr 0.03 csys = 0.21 CPU) Result: PASS And still all 15 pass afterwards. But it is more correct to declare an empty set, so will sign off. (Note this was passing fine on jenkins too) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 04:33:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 02:33:00 +0000 Subject: [Koha-bugs] [Bug 8768] t/ItemType.t fails because DBD::Mock has no empty result set In-Reply-To: <bug-8768-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8768-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8768-70-OG0zght0FI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8768 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12185|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 12205 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12205&action=edit bug 8768 correct an error in ItemType.t The second test in ItemType.t tests that an empty table returns no rows however as Mock::DBD has no resultset it fails with an error in DBI It requires that an empty resultset is defined in Mock::DBD first This patch adds that mocked empty table Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 05:12:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 03:12:51 +0000 Subject: [Koha-bugs] [Bug 8002] Can't add patron attribute type in newer installation In-Reply-To: <bug-8002-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8002-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8002-70-0JWgmJWiY0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8002 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12033|0 |1 is obsolete| | --- Comment #23 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 12206 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12206&action=edit Bug 8002: FIX Change datatype from varchar 1 to 10 for borrower_attribute_types.category_code Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 05:13:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 03:13:03 +0000 Subject: [Koha-bugs] [Bug 8002] Can't add patron attribute type in newer installation In-Reply-To: <bug-8002-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8002-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8002-70-vcqCGSdnac@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8002 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 07:01:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 05:01:50 +0000 Subject: [Koha-bugs] [Bug 8071] link beween bib and authorities with the authid In-Reply-To: <bug-8071-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8071-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8071-70-EHOsY81NLx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8071 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com Version|rel_3_8 |master QA Contact| |mtj at kohaaloha.com --- Comment #8 from Mason James <mtj at kohaaloha.com> --- patch looks good, applied to MASTER, passing QA... $ koha-qa.pl testing 1 commit(s) (applied to commit 60790d0) * 955eee1 Bug 8071: link between bib and authorities with the authid C4/AuthoritiesMarc.pm C4/Biblio.pm authorities/blinddetail-biblio-search.pl koha-tmpl/intranet-tmpl/prog/en/modules/authorities/blinddetail-biblio-search.tt * C4/AuthoritiesMarc.pm OK * C4/Biblio.pm OK * authorities/blinddetail-biblio-search.pl OK * koha-tmpl/intranet-tmpl/prog/en/modules/authorities/blinddetail-biblio-seOK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 07:12:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 05:12:55 +0000 Subject: [Koha-bugs] [Bug 8656] Koha::Calendar not loading both sets of special dates In-Reply-To: <bug-8656-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8656-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8656-70-AUCrYzewvF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8656 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com QA Contact| |mtj at kohaaloha.com Severity|enhancement |major --- Comment #3 from Mason James <mtj at kohaaloha.com> --- > Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> Colin, i upgraded the priority patch looks good, passing QA... $ koha-qa.pl testing 1 commit(s) (applied to commit 60790d0) * d40a73c Bug 8656 Calendar needs to load both exception and nonexception d Koha/Calendar.pm * Koha/Calendar.pm OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 07:17:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 05:17:09 +0000 Subject: [Koha-bugs] [Bug 8418] Koha::Calendar is_holiday ignores all user data In-Reply-To: <bug-8418-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8418-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8418-70-mhlY7OMSdm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8418 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com QA Contact| |mtj at kohaaloha.com --- Comment #26 from Mason James <mtj at kohaaloha.com> --- > Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> patch looks good, passing QA... $ koha-qa.pl testing 1 commit(s) (applied to commit 60790d0) * 1230d06 Bug 8418: load repeating holidays hash correctly Koha/Calendar.pm * Koha/Calendar.pm OK -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 07:18:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 05:18:03 +0000 Subject: [Koha-bugs] [Bug 8418] Koha::Calendar is_holiday ignores all user data In-Reply-To: <bug-8418-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8418-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8418-70-p5UT8YveID@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8418 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 08:14:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 06:14:14 +0000 Subject: [Koha-bugs] [Bug 8110] Add tests for Calendar modules In-Reply-To: <bug-8110-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8110-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8110-70-TPJj03Gd5V@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact| |mtj at kohaaloha.com --- Comment #45 from Mason James <mtj at kohaaloha.com> --- t/db_dependent/Holidays.t(In reply to comment #39) > QA comments: > > One test does not pass: > # Failed test 'Christmas is a closed day' > # at t/db_dependent/Holidays.t line 44. > # got: '0' > # expected: '1' > > Marked as Failed QA ok, i think this one is looking good now... all tests pass, after applying 8418 and 8486 everyone.. marking this one as 'paseed QA' $ perl t/db_dependent/Holidays.t 1..8 ok 1 - use Koha::Calendar; ok 2 - use C4::Calendar; ok 3 - Koha::Calendar class returned isa Koha::Calendar ok 4 - C4::Calendar class returned isa C4::Calendar ok 5 - Sunday is a closed day ok 6 - Monday is not a closed day ok 7 - Christmas is a closed day ok 8 - New Years day is a closed day ---------------------------------------------- $ koha-qa.pl -c 3 testing 3 commit(s) (applied to commit 15cf307) * 47deb47 Bug 8656 Calendar needs to load both exception and nonexception d Koha/Calendar.pm * 51efc88 Bug 8110 - add 'sample_holidays.sql' files for all languages installer/data/mysql/de-DE/optional/sample_holidays.sql installer/data/mysql/es-ES/optional/sample_holidays.sql installer/data/mysql/fr-FR/2-Optionel/sample_holidays.sql installer/data/mysql/it-IT/optional/sample_holidays.sql installer/data/mysql/nb-NO/2-Valgfritt/sample_holidays.sql installer/data/mysql/pl-PL/optional/sample_holidays.sql installer/data/mysql/ru-RU/optional/sample_holidays.sql installer/data/mysql/uk-UA/optional/sample_holidays.sql * ed34abb Holidays Test Plan - DB Dependent t/db_dependent/Holidays.t * Koha/Calendar.pm OK * t/db_dependent/Holidays.t OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 08:31:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 06:31:46 +0000 Subject: [Koha-bugs] [Bug 8447] can't save new records / indicator error In-Reply-To: <bug-8447-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8447-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8447-70-41mhJhGVjA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8447 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com QA Contact| |mtj at kohaaloha.com --- Comment #23 from Mason James <mtj at kohaaloha.com> --- (In reply to comment #20) > (In reply to comment #18) > > bag - jacamins an I found some other broken behavior, which he fixed, and I > > tested. > > > > Signed Off. passing QA, nice work people! $ koha-qa.pl testing 1 commit(s) (applied to commit 60790d0) * 1decc86 Bug 8447: Make sure we have enough subfields for broader_headings C4/Linker/Default.pm * C4/Linker/Default.pm OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 08:37:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 06:37:06 +0000 Subject: [Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC In-Reply-To: <bug-6976-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6976-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6976-70-dvjLpQJs56@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com QA Contact|koha-bugs at lists.koha-commun |mtj at kohaaloha.com |ity.org | --- Comment #26 from Mason James <mtj at kohaaloha.com> --- > Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> patch looks good, passing QA... $ koha-qa.pl testing 1 commit(s) (applied to commit 60790d0) * 3ebd669 Bug 6976 Close loophole allowing borrowers extra holds via opac opac/opac-reserve.pl * opac/opac-reserve.pl OK -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 08:48:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 06:48:48 +0000 Subject: [Koha-bugs] [Bug 4045] No check for maximum number of allowed holds. In-Reply-To: <bug-4045-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4045-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4045-70-EVTF3iM445@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion CC| |mtj at kohaaloha.com QA Contact|koha-bugs at lists.koha-commun |mtj at kohaaloha.com |ity.org | --- Comment #42 from Mason James <mtj at kohaaloha.com> --- (In reply to comment #41) > I was able to apply this patch (a merge conflict with updatedatabase.pl to > resolve first) > > In testing, the maxreserves value was set to 9. > > I was not able to place holds for over 9 items. > I was not able to place holds for exactly 9 items. > I could place holds for 8 items. > > I attempted to place a hold on one more item and received two messages on > one screen: > > message1: > Sorry, you cannot place holds on all these items. You can only place 1 more > hold(s). Please choose the items you wish to be held. > > message2: > Sorry, none of these items can be placed on hold. ok, so the messages combination is glitchy :/ if 'none of these items can be placed on hold.' there should be no message to 'choose the items you wish to be held.' everyone, changing status from 'failed qa' to 'in discussion' -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 08:57:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 06:57:41 +0000 Subject: [Koha-bugs] [Bug 8300] Koha should have mechanized testing suite In-Reply-To: <bug-8300-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8300-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8300-70-rbmUIeZz1E@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8300 Magnus Enger <magnus at enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |magnus at enger.priv.no --- Comment #5 from Magnus Enger <magnus at enger.priv.no> --- After applying the patch I get this: $ prove -v t/db_dependent/www/batch.t t/db_dependent/www/batch.t .. 1..20 ok 1 - connect to intranet ok 2 - login to staff client ok 3 - load main page Link not found at t/db_dependent/www/batch.t line 63. # Looks like you planned 20 tests but ran 3. # Looks like your test exited with 255 just after 3. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 17/20 subtests Test Summary Report ------------------- t/db_dependent/www/batch.t (Wstat: 65280 Tests: 3 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 20 tests but ran 3. Files=1, Tests=3, 4 wallclock secs ( 0.04 usr 0.00 sys + 0.38 cusr 0.04 csys = 0.46 CPU) Result: FAIL I think the problem is that after the new look of the staff client was introduced, the link to tools no longer contains the text "Tools". Changing line 63 of t/db_dependent/www/batch.t to this: $agent->follow_link_ok( { url_regex => qr/tools-home/i }, 'open tools module' ); makes the test succeed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 09:00:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 07:00:06 +0000 Subject: [Koha-bugs] [Bug 8002] Can't add patron attribute type in newer installation In-Reply-To: <bug-8002-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8002-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8002-70-VB6RMWdsvg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8002 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com --- Comment #24 from Mason James <mtj at kohaaloha.com> --- (In reply to comment #23) > Created attachment 12206 [details] > Bug 8002: FIX Change datatype from varchar 1 to 10 for > borrower_attribute_types.category_code > > Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> passing QA on patch against master $ koha-qa.pl testing 1 commit(s) (applied to commit 60790d0) * 5599413 Bug 8002: FIX Change datatype from varchar 1 to 10 for borrower_a installer/data/mysql/kohastructure.sql installer/data/mysql/updatedatabase.pl * installer/data/mysql/updatedatabase.pl OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 09:03:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 07:03:51 +0000 Subject: [Koha-bugs] [Bug 8743] ZOOM error when merging authority change to biblios In-Reply-To: <bug-8743-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8743-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8743-70-950a5TdSgq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8743 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12080|0 |1 is obsolete| | --- Comment #6 from Mason James <mtj at kohaaloha.com> --- Comment on attachment 12080 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12080 Bug 8743: ZOOM error when merging authority change to biblios obsoleting patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 09:05:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 07:05:40 +0000 Subject: [Koha-bugs] [Bug 8743] ZOOM error when merging authority change to biblios In-Reply-To: <bug-8743-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8743-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8743-70-yLu5rxxNUA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8743 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com QA Contact| |mtj at kohaaloha.com --- Comment #7 from Mason James <mtj at kohaaloha.com> --- (In reply to comment #5) > I have tested this and completely fixes the problem described. Tested on a > 3.08.4 system. Patch applied cleanly. patch signed off, passing QA... $ koha-qa.pl testing 1 commit(s) (applied to commit 60790d0) * 797e722 Bug 8743: ZOOM error when merging authority change to biblios C4/AuthoritiesMarc.pm * C4/AuthoritiesMarc.pm OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 09:07:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 07:07:16 +0000 Subject: [Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off In-Reply-To: <bug-8462-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8462-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8462-70-9PDkx0FTXq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com QA Contact| |mtj at kohaaloha.com --- Comment #4 from Mason James <mtj at kohaaloha.com> --- (In reply to comment #3) > Created attachment 12042 [details] > Bug 8462: OpacHiddenItems and hidelostitems hide items, but query result > count is off > > Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> patch looks good, passing QA... $ koha-qa.pl testing 1 commit(s) (applied to commit 60790d0) * 82c74b0 Bug 8462: OpacHiddenItems and hidelostitems hide items, but query C4/Search.pm * C4/Search.pm OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 10:00:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 08:00:24 +0000 Subject: [Koha-bugs] [Bug 7986] Export issues In-Reply-To: <bug-7986-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7986-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7986-70-j9WRpPzMts@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 --- Comment #29 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Maybe we could also hide the tab/the feature when both system preferences are empty? I think this is not a feature that is interesting for all libraries, so hiding it would make sense to me. I also like the idea of a separate tab. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 10:00:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 08:00:33 +0000 Subject: [Koha-bugs] [Bug 7986] Export issues In-Reply-To: <bug-7986-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7986-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7986-70-QEgQVUO6Cw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 --- Comment #30 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to comment #28) > I agree, and I'm sorry I didn't see this until now. I would definitely like > to come up with an alternative solution. We already have an "export > checkins" option under the "More" menu (at least on some pages--it hasn't > been added to all the necessary includes for it to be consistent), and now > we have a new export option in a different place. > > What if we put both export options into a new tab on the "Circulation > history" page? Both are directly related to circulation history. Are they > operations which happen so frequently that putting them onto another page > would cause problems? The export link in the "More" menu only exports barcodes of the exports of the day. The "export checkouts" link generates a csv or a iso2709 file with the checkout you have checked. It is not the same feature at all. So to add a new tab, a new table with checkouts will have to be added. Theses information already exist (under different format) in the "Check out", "Details" and "Circulation history" tabs. I don't know if we want to add them a fourth times. Don't you agree with this ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 10:15:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 08:15:28 +0000 Subject: [Koha-bugs] [Bug 8300] Koha should have mechanized testing suite In-Reply-To: <bug-8300-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8300-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8300-70-sktR6m6MjU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8300 --- Comment #6 from Magnus Enger <magnus at enger.priv.no> --- The environment variables that need to be set should probably be documented somewhere too? Not sure where though. A README in t/db_dependent/www/ perhaps? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 10:22:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 08:22:23 +0000 Subject: [Koha-bugs] [Bug 8771] New: Something wrong with databse update 3.09.00.044 Message-ID: <bug-8771-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8771 Priority: P5 - low Change sponsored?: --- Bug ID: 8771 Assignee: gmcharlt at gmail.com Summary: Something wrong with databse update 3.09.00.044 Severity: normal Classification: Unclassified OS: All Reporter: katrin.fischer at bsz-bw.de Hardware: All Status: NEW Version: master Component: Database Product: Koha On a train today, so want to note this before I get disconnected or forget: Output is missing the version number: Upgrade done ( Added Collection Code to Statistics table. ) And there is a SQL error. I updated from .37 to .44: [Fri Sep 14 09:55:19 2012] updatedatabase.pl: DBD::mysql::db do failed: Duplicate column name 'ccode' at /home/katrin/kohaclone/installer/data/mysql/updatedatabase.pl line 5774. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 10:26:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 08:26:06 +0000 Subject: [Koha-bugs] [Bug 7986] Export issues In-Reply-To: <bug-7986-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7986-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7986-70-kqU79ajxQk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 --- Comment #31 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hm, I think you are right about the duplicated information. Maybe we could have a checkbox or option that would make the checkboxes for exporting and other things show up? Similar to how you have to activate the option for overriding renewals first. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 10:30:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 08:30:19 +0000 Subject: [Koha-bugs] [Bug 8771] Something wrong with databse update 3.09.00.044 In-Reply-To: <bug-8771-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8771-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8771-70-lWkvAeYW11@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8771 Magnus Enger <magnus at enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no --- Comment #1 from Magnus Enger <magnus at enger.priv.no> --- I did an upgrade from .33 to .44 through the web installer earlier today and did not see this error: Upgrade to 3.09.00.033 done (Add OpacSuppressionByIPRange syspref) Upgrade to 3.09.00.034 done (Bug 8207: correct typo in authority types) Upgrade to 3.09.00.035 done (Adding PrefillItem and SubfieldsToUseWhenPrefill sysprefs) Upgrade to 3.09.00.036 done (Add colum agerestriction to biblioitems and deletedbiblioitems, add system preferences AgeRestrictionMarker and AgeRestrictionOverride) Upgrade to 3.09.00.037 done (creating `transport_cost` table; adding UseTransportCostMatrix systempref, in circulation) Upgrade to 3.09.00.038 done (Increase the maximum size of a borrower attribute value) Upgrade to 3.09.00.039 done (Add system preference DidYouMeanFromAuthorities) Upgrade to 3.09.00.040 done (Add IncludeSeeFromInSearches system preference) Upgrade to 3.09.00.041 done (Add system preference ExportRemoveFields) Upgrade to 3.09.00.042 done (Adds New System preference ExportWithCsvProfile) Upgrade to 3.09.00.043 done (Adding parent_ordernumber in aqorders) Upgrade done ( Added Collection Code to Statistics table. ) Everything went OK, update done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 10:31:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 08:31:50 +0000 Subject: [Koha-bugs] [Bug 8017] Remove unnecessary processing on return of GetAllIssues In-Reply-To: <bug-8017-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8017-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8017-70-uKCcY68xVy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8017 --- Comment #17 from Colin Campbell <colin.campbell at ptfs-europe.com> --- Created attachment 12207 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12207&action=edit Patch - Version for 3.8 This is a version of patch that should apply to 3.8 - The last rebase was to account for some new functionality in master. This omits updating that non existent code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 10:38:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 08:38:03 +0000 Subject: [Koha-bugs] [Bug 8420] tool statisticfines.pl(bz 6858) and hourly loan(bz5549) In-Reply-To: <bug-8420-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8420-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8420-70-wJQPkmaLJU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8420 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com Version|rel_3_8 |master QA Contact| |mtj at kohaaloha.com --- Comment #4 from Mason James <mtj at kohaaloha.com> --- > Signed-off-by: Delaye Stephane <stephane.delaye at biblibre.com> looks good, passing QA... i've changed version from 3.8 to master $ koha-qa.pl testing 1 commit(s) (applied to commit 60790d0) * e0debe5 Bug 8420: tool statisticfines.pl and hourly loan misc/cronjobs/staticfines.pl * misc/cronjobs/staticfines.pl OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 10:48:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 08:48:39 +0000 Subject: [Koha-bugs] [Bug 6151] IndependantBranches and HomeOrHoldingBranchReturn can prevent items from being checked in In-Reply-To: <bug-6151-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6151-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6151-70-ut68lTQCtj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6151 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11294|0 |1 is obsolete| | Attachment #11410|0 |1 is obsolete| | --- Comment #15 from Mason James <mtj at kohaaloha.com> --- Created attachment 12208 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12208&action=edit Bug 6151: Add AllowReturnToBranch system preference In order to solve the issue of IndependantBranches being incompatible with HomeOrHoldingBranchReturn, this patch changes the mechanism by which the question "can I return this material here?" is answered. Before, the conditions were "if IndependantBranches is on, and this branch isn't HomeOrHoldingBranchReturn for the item, then no, otherwise yes". Now, the question is answered by consulting CanBookBeReturned (new subroutine) New system preference: AllowReturnToBranch Possible values: - anywhere (default for new installs, and for existing systems with IndependantBranches turned off) - homebranch - holdingbranch (which is also the issuing branch in all normal circumstances) - homeorholdingbranch (default for existing systems with IndependantBranches turned on) New subroutine: CanBookBeReturned Input: $item hash (from GetItems), and $branchcode Output: 0 or 1 to indicate "allowed" or not, and an optional message if not allowed. Message is the 'correct' branchcode to return the material to To Test: 1. Install patch and new syspref 2. Check that default value of the preference: - if IndependantBranches was OFF at install time, should be 'anywhere' - if IndependantBranches was ON at install time, should be 'homeorholdingbranch' Case: 'anywhere' 1. Checkout a Library A book at Library A. Return at Library A should be successful 2. Repeat step 1, returning to Library B. Return should be successful 3. Checkout a Library A book at Library B. Return to A should be successful 4. Repeat step 3 with Library B and Library C Case: 'homebranch' 1. Checkout a Library A book at Library A. Return at Library A should be successful 2. Repeat step 1, returning to Library B. Return should FAIL (returning message to return at A) 3. Checkout a Library A book at Library B. Return to Library A should be successful 4. Repeat step 3 with Library B and Library C. Both should FAIL (returning message to return at A) Case: 'holdingbranch' 1. Checkout a Library A book at Library A. Return at Library A should be successful 2. Repeat step 1, returning to Library B. Return should FAIL (returning message to return at A) 3. Checkout a Library A book at Library B. Return to A should FAIL (returning message to return at B) 4. Repeat step 3 with Library B. Return should be successful 5. Repeat step 3 with Library C. Return should FAIL (returning message to return at B) Case: 'homeorholdingbranch' 1. Checkout a Library A book at Library A. Return at Library A should be successful 2. Repeat step 1, returning to Library B. Return should FAIL (returning message to return at A) 3. Checkout a Library A book at Library B. Return to A should be successful 4. Repeat step 3 with Library B. Return should be successful 5. Repeat step 3 with Library C. Return should FAIL (returning message to return at A) Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 10:53:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 08:53:35 +0000 Subject: [Koha-bugs] [Bug 8300] Koha should have mechanized testing suite In-Reply-To: <bug-8300-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8300-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8300-70-2ifchscRDe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8300 --- Comment #7 from Magnus Enger <magnus at enger.priv.no> --- This would be more of an enhancement request, but I imagine lots of tests could require lots of different env variables, to point the scripts to users, records etc that could be used for testing. I can also imagine wanting to run the tests against a number of different installations, both on and off localhost. Would it make sense to have these tests read config files that contain all the different settings required to test a given installation, and then point the tests to the right config with a single env var? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 10:53:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 08:53:48 +0000 Subject: [Koha-bugs] [Bug 6151] IndependantBranches and HomeOrHoldingBranchReturn can prevent items from being checked in In-Reply-To: <bug-6151-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6151-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6151-70-uhgDqjgxDr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6151 --- Comment #16 from Mason James <mtj at kohaaloha.com> --- Created attachment 12209 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12209&action=edit Bug 6151 - Followup - Display message for failed returns on circulation.pl when returning via issues table. Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 10:57:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 08:57:12 +0000 Subject: [Koha-bugs] [Bug 6151] IndependantBranches and HomeOrHoldingBranchReturn can prevent items from being checked in In-Reply-To: <bug-6151-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6151-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6151-70-vMvQivy3vR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6151 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11595|0 |1 is obsolete| | --- Comment #17 from Mason James <mtj at kohaaloha.com> --- Created attachment 12210 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12210&action=edit Bug 6151 - Followup - Change 'itemnumber' to 'barcode' Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 11:04:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 09:04:19 +0000 Subject: [Koha-bugs] [Bug 6151] IndependantBranches and HomeOrHoldingBranchReturn can prevent items from being checked in In-Reply-To: <bug-6151-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6151-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6151-70-n4dUKl0UFc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6151 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com QA Contact|koha-bugs at lists.koha-commun |mtj at kohaaloha.com |ity.org | --- Comment #18 from Mason James <mtj at kohaaloha.com> --- (In reply to comment #17) > Created attachment 12210 [details] > Bug 6151 - Followup - Change 'itemnumber' to 'barcode' > > Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> rebased 3 patches against master '60790d0' all patches apply clean, passing QA... $ koha-qa.pl -c 3 testing 3 commit(s) (applied to commit 60790d0) * 41e46a0 Bug 6151 - Followup - Change 'itemnumber' to 'barcode' circ/circulation.pl * 0b479be Bug 6151 - Followup - Display message for failed returns on circu circ/circulation.pl koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt * 32c3ceb Bug 6151: Add AllowReturnToBranch system preference C4/Circulation.pm admin/systempreferences.pl installer/data/mysql/sysprefs.sql installer/data/mysql/updatedatabase.pl koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref * circ/circulation.pl OK * C4/Circulation.pm OK * admin/systempreferences.pl OK * installer/data/mysql/updatedatabase.pl OK * koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt OK * koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt OK -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 11:15:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 09:15:39 +0000 Subject: [Koha-bugs] [Bug 7986] Export issues In-Reply-To: <bug-7986-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7986-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7986-70-c94PQJs1Ll@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 --- Comment #32 from Paul Poulain <paul.poulain at biblibre.com> --- (In reply to comment #29) > Maybe we could also hide the tab/the feature when both system preferences > are empty? Great idea = if the syspref is empty, then it probably mean the library will never use this feature (and, if the librarian tries, there will be an error message) I think it is also easy to code ! > I think this is not a feature that is interesting for all > libraries, so hiding it would make sense to me. I also like the idea of a > separate tab. The problem is that libraries interested are using this feature all the day, so it must be as easy as possible to access. A (french) Use case = we have regional-wide libraries (100 all over France) that issues books to small libraries, in small villages. The local library comes, pick-up 100+ books. They are checked-out, and, once they're done, the regional-wide library gives them the list in iso2709 on a USB key, so they can put them in a few seconds in their local ILS (which is not always Koha, unfortunately ;-) ) Some libraries even don't have an ILS, in this case they just get a CSV file for import into their spreadsheat. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 11:22:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 09:22:23 +0000 Subject: [Koha-bugs] [Bug 8730] browse overlaying powered by In-Reply-To: <bug-8730-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8730-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8730-70-691EQRf376@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8730 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 --- Comment #7 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 11:22:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 09:22:52 +0000 Subject: [Koha-bugs] [Bug 8764] Template change "Authors" to "Additional authors" in OPAC In-Reply-To: <bug-8764-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8764-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8764-70-Zu0lMLgbxw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8764 Magnus Enger <magnus at enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12179|0 |1 is obsolete| | --- Comment #2 from Magnus Enger <magnus at enger.priv.no> --- Created attachment 12211 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12211&action=edit Bug 8764 - Template change "Authors" to "Additional authors" in OPAC This patch simply changes "Authors" to "Additional authors" in the OPAC. This label describes authors that are added via the MARC 700 fields, which are added or additional authors. Signed-off-by: Magnus Enger <magnus at enger.priv.no> Works as advertised, and seems to make sense. Only affects the display when XSLT is not enabled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 11:23:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 09:23:39 +0000 Subject: [Koha-bugs] [Bug 8764] Template change "Authors" to "Additional authors" in OPAC In-Reply-To: <bug-8764-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8764-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8764-70-dsMi5KmC04@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8764 Magnus Enger <magnus at enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |magnus at enger.priv.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 11:30:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 09:30:09 +0000 Subject: [Koha-bugs] [Bug 8721] typo in AllowItemsOnHoldCheckout In-Reply-To: <bug-8721-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8721-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8721-70-M9FcEsoupA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8721 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_10 --- Comment #4 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 11:31:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 09:31:02 +0000 Subject: [Koha-bugs] [Bug 8719] Private lists always sorted by title (even when author or date is selected) In-Reply-To: <bug-8719-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8719-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8719-70-A1r3WIaYBR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8719 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 --- Comment #4 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 11:31:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 09:31:15 +0000 Subject: [Koha-bugs] [Bug 8721] typo in AllowItemsOnHoldCheckout In-Reply-To: <bug-8721-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8721-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8721-70-eK6E730JpQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8721 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_10 |rel_3_8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 11:40:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 09:40:46 +0000 Subject: [Koha-bugs] [Bug 7986] Export issues In-Reply-To: <bug-7986-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7986-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7986-70-RI6Y9jAQf3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12168|0 |1 is obsolete| | --- Comment #33 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 12212 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12212&action=edit Bug 7986: Followup: Hide the export link unless sysprefs are set If at least one of both sysprefs (ExportRemoveFields and ExportWithCsvProfile) is filled, the export link is displayed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 11:46:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 09:46:35 +0000 Subject: [Koha-bugs] [Bug 7986] Export issues In-Reply-To: <bug-7986-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7986-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7986-70-akJa31Znnn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 --- Comment #34 from Owen Leonard <oleonard at myacpl.org> --- Thanks for the explanation Paul. I'm going to test an interface idea which I think will be a good solution for all. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 12:08:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 10:08:11 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-tWQ4tFpsRX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |paul.poulain at biblibre.com --- Comment #52 from Paul Poulain <paul.poulain at biblibre.com> --- QA comments: To begin, I'm really sorry to fail QA this large patch, with a great feature, but I think it's needed * I don't like at all the introduction of +sub GetItemTypesFlat { + my $dbh = C4::Context->dbh; + my $query = "SELECT * FROM itemtypes ORDER BY description"; + my $sth = $dbh->prepare($query); + $sth->execute; + + return $sth->fetchall_arrayref({}); +} That's another way to access itemtype. We need consistency, not more and more various way to access the same information That would have been a wonderful time to introduce Koha::Service::Itemtype.pm ! Can you find a way to avoid introducing this function ? * The introduction of Koha/CourseReserves.pm is wrong: - it must follow the structure we've defined at the hackfest and updated after some tests I made (see mail on koha-devel, june 25th, Re: [Koha-devel] http://wiki.koha-community.org/wiki/Koha_Namespace_RFC, moving ahead - it must be OOP, as everything that enters Koha:: - parameters must be passed by hashes (this one is OK) I let you 2 options here : * you rewrite CourseReserves.pm in Koha:: namespace to respect the rule * you move it to C4/ as it's an 'old style' stuff (I bet you'll follow the 2nd patch, that is *much* easier, but that would have been a great occasion to start filling Koha:: :\ ) * mod_course.pl says: +#script to modify reserves/requests +#written 2/1/00 by chris at katipo.oc.nz +#last update 27/1/2000 by chris at katipo.co.nz +# Copyright 2000-2002 Katipo Communications are you sure this code is 12 years old ? ;-) * There are no foreign keys, we can have some (not sure this list is complete): - instructors.borrowernumbers => borrowers.borrowernumber - instructors.course_id => courses.course_id - course_items.itemnumber => items.itemnumber - course_items.holdingbranch => branches.branchcode - course_reserves.course_id => courses.course_id Not failing QA for that but: * scripts names sounds a little bit long/duplicated : course_reserves/course-details.pl => could be course/detail, don't you think ? - do we really need course_reserve as directory ? - do we need to repeas course in course-detail.pl * the course_reserve table has an index with a probable typo in the name: + UNIQUE KEY `psuedo_key` (`course_id`,`ci_id`), => PSEUDO, not PSUEDO ? QUESTIONS: * what are the changes to .../prog/en/modules/members/mancredit.tt | 2 +- .../prog/en/modules/members/maninvoice.tt | 2 +- .../prog/en/modules/members/memberentrygen.tt | 2 +- done for ? Why is it in this patch ? PS : if you decide to go to Koha::Service::Itemtype.pm, don't do it with DBIx::Class, just with standard SQL. Introducing DBIx::Class is a huge thing, that must be done separately -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 12:10:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 10:10:30 +0000 Subject: [Koha-bugs] [Bug 8211] Add "subject (broader), " "subject (narrower), " and "subject (related)" options for search In-Reply-To: <bug-8211-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8211-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8211-70-f0DSKcWRr9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8211 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #6 from Jonathan Druart <jonathan.druart at biblibre.com> --- QA Comments: Looks good to me. Code clean, UT++ Just one thing: maybe it would be better to pass a hashref to parseQuery instead of 7 arguments. But it is possible to have some disagreements about that. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 12:10:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 10:10:42 +0000 Subject: [Koha-bugs] [Bug 8211] Add "subject (broader), " "subject (narrower), " and "subject (related)" options for search In-Reply-To: <bug-8211-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8211-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8211-70-joqA76HIq3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8211 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 12:24:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 10:24:42 +0000 Subject: [Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC In-Reply-To: <bug-4173-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4173-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4173-70-hQO8B3ogDg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com --- Comment #21 from Mason James <mtj at kohaaloha.com> --- (In reply to comment #18) > QA comment : I like very much the idea of > Koha/Template/Plugin/KohaAuthorisedValues.pm > ... BUT it has no doc at all. > > Failing QA for this reason, please provide a follow-up with some doc (it > will be trivial, I agree, but it's needed) Kyle has added the needed POD, passing QA on this... $ koha-qa.pl -c 3 testing 3 commit(s) (applied to commit 60790d0) * 8c7b14c Bug 4173: Followup: Document KohaAuthorisedValues plugin Koha/Template/Plugin/KohaAuthorisedValues.pm * b43f0b9 Bug 4173: Followup: put the lib into a variable koha-tmpl/opac-tmpl/prog/en/includes/item-status.inc * 1308299 Bug 4173 - Statuses not appearing in the OPAC C4/Koha.pm Koha/Template/Plugin/KohaAuthorisedValues.pm koha-tmpl/opac-tmpl/prog/en/includes/item-status.inc * Koha/Template/Plugin/KohaAuthorisedValues.pm OK * C4/Koha.pm OK * koha-tmpl/opac-tmpl/prog/en/includes/item-status.inc OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 12:30:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 10:30:22 +0000 Subject: [Koha-bugs] [Bug 8629] update of statistics fields on fund selection in order creation/edition In-Reply-To: <bug-8629-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8629-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8629-70-gl2UTJnSAp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8629 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com QA Contact| |mtj at kohaaloha.com --- Comment #3 from Mason James <mtj at kohaaloha.com> --- (In reply to comment #2) > Created attachment 11602 [details] > [SIGNED-OFF] Bug 8629: update of statistics fields on fund selection in > order creation/edition > > Signed-off-by: Marc Veron <veron at veron.ch> > > Followed test plan in comment #1 > Behaves as described in the test plan. > Useful feature! patch looks good, passing QA... $ koha-qa.pl -c testing 1 commit(s) (applied to commit 60790d0) * 2ffc88c Bug 8629: update of statistics fields on fund selection in order acqui/addorderiso2709.pl acqui/fetch_sort_dropbox.pl acqui/neworderempty.pl koha-tmpl/intranet-tmpl/prog/en/js/acq.js koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt * acqui/addorderiso2709.pl OK * acqui/fetch_sort_dropbox.pl OK * acqui/neworderempty.pl OK * koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt OK * koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 12:34:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 10:34:18 +0000 Subject: [Koha-bugs] [Bug 2060] Ability to import Authorities from Staff Client In-Reply-To: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2060-70-hpXG0LhAFI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2060 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12198|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 12:34:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 10:34:54 +0000 Subject: [Koha-bugs] [Bug 2060] Ability to import Authorities from Staff Client In-Reply-To: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2060-70-YDr95uNtKs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2060 --- Comment #35 from Paul Poulain <paul.poulain at biblibre.com> --- Created attachment 12213 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12213&action=edit UNIMARC authorities These authorities comes from BNF -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 12:34:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 10:34:55 +0000 Subject: [Koha-bugs] [Bug 8726] Did you mean? plugin for broader/narrower/related terms In-Reply-To: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8726-70-rEL6iuqcDm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 --- Comment #7 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 12214 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12214&action=edit overflow I get an overflow issue on wide screen (24"), see screenshot. Moreover when I click on the Intranet AuthorityFile *label*, the checkbox of Opac AuthorityFile become checked or unchecked :) (same for ExplodedTerms) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 12:38:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 10:38:22 +0000 Subject: [Koha-bugs] [Bug 2060] Ability to import Authorities from Staff Client In-Reply-To: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2060-70-4BdzMBmBiE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2060 --- Comment #36 from Paul Poulain <paul.poulain at biblibre.com> --- Created attachment 12215 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12215&action=edit screenshot of my testing with UNIMARC (and Plack) It's better, but still failing : the job progress is stalled to 0% forever In Plack console, I see: Subroutine redo_matching redefined at /home/paul/koha.dev/koha-community/tools/manage-marc-import.pl line 142. Subroutine create_labelbatch_from_importbatch redefined at /home/paul/koha.dev/koha-community/tools/manage-marc-import.pl line 186. Subroutine import_batches_list redefined at /home/paul/koha.dev/koha-community/tools/manage-marc-import.pl line 206. Subroutine commit_batch redefined at /home/paul/koha.dev/koha-community/tools/manage-marc-import.pl line 234. Subroutine revert_batch redefined at /home/paul/koha.dev/koha-community/tools/manage-marc-import.pl line 263. Variable "$sessionID" is not available at /home/paul/koha.dev/koha-community/tools/manage-marc-import.pl line 296. Subroutine put_in_background redefined at /home/paul/koha.dev/koha-community/tools/manage-marc-import.pl line 292. Subroutine progress_callback redefined at /home/paul/koha.dev/koha-community/tools/manage-marc-import.pl line 327. Subroutine add_results_to_template redefined at /home/paul/koha.dev/koha-community/tools/manage-marc-import.pl line 337. Variable "$sessionID" is not available at /home/paul/koha.dev/koha-community/tools/manage-marc-import.pl line 346. Subroutine add_saved_job_results_to_template redefined at /home/paul/koha.dev/koha-community/tools/manage-marc-import.pl line 343. Subroutine import_records_list redefined at /home/paul/koha.dev/koha-community/tools/manage-marc-import.pl line 351. Subroutine batch_info redefined at /home/paul/koha.dev/koha-community/tools/manage-marc-import.pl line 413. Subroutine add_matcher_list redefined at /home/paul/koha.dev/koha-community/tools/manage-marc-import.pl line 445. Subroutine add_page_numbers redefined at /home/paul/koha.dev/koha-community/tools/manage-marc-import.pl line 458. I also tried without plack, and got the same behaviour = job progress stuck at 0% (and nothing added in the database, i've checked) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 12:38:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 10:38:39 +0000 Subject: [Koha-bugs] [Bug 2060] Ability to import Authorities from Staff Client In-Reply-To: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2060-70-Y3ND4IoylA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2060 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 12:47:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 10:47:00 +0000 Subject: [Koha-bugs] [Bug 8211] Add "subject (broader), " "subject (narrower), " and "subject (related)" options for search In-Reply-To: <bug-8211-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8211-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8211-70-EbpHgsJFsm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8211 --- Comment #7 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- (In reply to comment #6) > QA Comments: > > Looks good to me. > Code clean, UT++ > > Just one thing: maybe it would be better to pass a hashref to parseQuery > instead of 7 arguments. But it is possible to have some disagreements about > that. The reasoning behind using the 7 arguments is that parseQuery is still just a shim, so we want it to look as much like buildQuery as possible. When parseQuery replaces buildQuery, the API will also be changed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 13:13:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 11:13:00 +0000 Subject: [Koha-bugs] [Bug 7751] Decrease loan period on items with a high number of holds In-Reply-To: <bug-7751-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7751-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7751-70-lGVLxUJfed@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com --- Comment #28 from Mason James <mtj at kohaaloha.com> --- > > Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> passing QA... $ koha-qa.pl testing 1 commit(s) (applied to commit 60790d0) * 77d74bb Bug 7751: Decrease Loans for Items in Demand for Holds C4/Circulation.pm C4/SIP/ILS/Transaction/Checkout.pm installer/data/mysql/sysprefs.sql koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt * C4/Circulation.pm OK * C4/SIP/ILS/Transaction/Checkout.pm OK * koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 13:48:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 11:48:52 +0000 Subject: [Koha-bugs] [Bug 7675] New script for changing selinux file labels on perl scripts In-Reply-To: <bug-7675-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7675-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7675-70-A9VGZEJsPE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7675 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com --- Comment #15 from Mason James <mtj at kohaaloha.com> --- > Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> patch applies clean, passing QA... mason at xen1:~/g/head$ koha-qa.pl testing 1 commit(s) (applied to commit 0acebb8) * e254b99 7675 New script for changing selinux file labels on perl scripts misc/bin/set-selinux-labels.sh -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 13:54:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 11:54:21 +0000 Subject: [Koha-bugs] [Bug 8653] With DOM indexing turned on subject authority links are not indexed In-Reply-To: <bug-8653-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8653-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8653-70-jXnROkqCID@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8653 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com QA Contact| |mtj at kohaaloha.com --- Comment #5 from Mason James <mtj at kohaaloha.com> --- > Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> passing QA, nice spotting! $ koha-qa.pl testing 1 commit(s) (applied to commit 0acebb8) * 36f58f1 Bug 8653 remove erroneous whitespace blocking indexing etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl etc/zebradb/marc_defs/marc21/biblios/record.abs etc/zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml etc/zebradb/marc_defs/unimarc/biblios/record.abs * etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml OK * etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl OK * etc/zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 13:56:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 11:56:05 +0000 Subject: [Koha-bugs] [Bug 8071] link beween bib and authorities with the authid In-Reply-To: <bug-8071-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8071-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8071-70-JozTE8IPLO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8071 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_10 --- Comment #9 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 14:04:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 12:04:49 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: <bug-7417-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7417-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7417-70-PNULBz571i@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #53 from Jonathan Druart <jonathan.druart at biblibre.com> --- Last patch passes QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 14:06:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 12:06:12 +0000 Subject: [Koha-bugs] [Bug 7455] Authority subfields are cloned in the wrong field In-Reply-To: <bug-7455-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7455-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7455-70-QvL9Mt9ayw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11908|0 |1 is obsolete| | --- Comment #24 from Mason James <mtj at kohaaloha.com> --- Created attachment 12216 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12216&action=edit Bug 7455: Authority subfields are cloned in the wrong field (follow-up) Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 14:08:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 12:08:30 +0000 Subject: [Koha-bugs] [Bug 8209] "Did you mean?" suggestions based on authorities In-Reply-To: <bug-8209-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8209-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8209-70-BMr5iIsxKd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8209 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12194|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 12217 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12217&action=edit Bug 8209 follow-up: another correction for BuildSummary API Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 14:09:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 12:09:10 +0000 Subject: [Koha-bugs] [Bug 8209] "Did you mean?" suggestions based on authorities In-Reply-To: <bug-8209-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8209-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8209-70-x19ptYiI0V@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8209 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 14:13:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 12:13:38 +0000 Subject: [Koha-bugs] [Bug 7455] Authority subfields are cloned in the wrong field In-Reply-To: <bug-7455-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7455-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7455-70-yQZ1ihB9M8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com --- Comment #25 from Mason James <mtj at kohaaloha.com> --- > Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> fyi: i rebased the 1st patch - it had some conflicts, and a bad UTF header now both(2) patches apply clean, passing QA... awesome work everyone! $ koha-qa.pl -c 2 testing 2 commit(s) (applied to commit 0acebb8) * b3778c4 Bug 7455: Authority subfields are cloned in the wrong field (foll authorities/authorities.pl koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js * 71f0ba4 Bug 7455: Authority subfields are cloned in the wrong field cataloguing/additem.pl koha-tmpl/intranet-tmpl/prog/en/css/addbiblio.css koha-tmpl/intranet-tmpl/prog/en/js/cataloging.js koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt koha-tmpl/intranet-tmpl/prog/en/modules/authorities/blinddetail-biblio-search.tt koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt tools/batchMod.pl * authorities/authorities.pl OK * cataloguing/additem.pl OK * tools/batchMod.pl OK * koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt OK * koha-tmpl/intranet-tmpl/prog/en/modules/authorities/blinddetail-biblio-seOK * koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt OK * koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt OK * koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt OK * koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 14:23:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 12:23:00 +0000 Subject: [Koha-bugs] [Bug 8428] can't save contracts In-Reply-To: <bug-8428-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8428-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8428-70-9qpwtbCpp6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8428 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com QA Contact| |mtj at kohaaloha.com --- Comment #9 from Mason James <mtj at kohaaloha.com> --- (In reply to comment #4) > Created attachment 11800 [details] > [SIGNED-OFF] Bug 8428 - can't save contracts > Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com> > Both tests passed. passing QA... $ koha-qa.pl testing 1 commit(s) (applied to commit 0acebb8) * d4f2940 Bug 8428 - can't save contracts koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqcontract.tt koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt * koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc OK * koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqcontract.tt OK * koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 14:24:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 12:24:54 +0000 Subject: [Koha-bugs] [Bug 8520] Authorities display incorrectly in staff results In-Reply-To: <bug-8520-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8520-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8520-70-sc1peHNm5T@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8520 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #29 from Mason James <mtj at kohaaloha.com> --- > Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> patch looks good, passing QA? $ koha-qa.pl testing 1 commit(s) (applied to commit 0acebb8) * 119fb5f Bug 8520 - Authorities summary incorrect on posible duplicate not authorities/authorities.pl * authorities/authorities.pl OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 14:35:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 12:35:37 +0000 Subject: [Koha-bugs] [Bug 8378] <fine> syntax not working on overdues anymore In-Reply-To: <bug-8378-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8378-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8378-70-VLwamaYdPr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8378 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com QA Contact| |mtj at kohaaloha.com --- Comment #10 from Mason James <mtj at kohaaloha.com> --- > Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> patch looks good, passing QA? $ koha-qa.pl testing 1 commit(s) (applied to commit 0acebb8) * d0c8d9e Bug 8378 - <fine> syntax not working on overdues anymore C4/Letters.pm misc/cronjobs/overdue_notices.pl * C4/Letters.pm OK * misc/cronjobs/overdue_notices.pl OK -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 14:43:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 12:43:10 +0000 Subject: [Koha-bugs] [Bug 7589] tinymce editor broken in .deb packages - in 'en' templates In-Reply-To: <bug-7589-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7589-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7589-70-1FJ3M2g2qB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7589 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high Severity|major |blocker --- Comment #16 from Mason James <mtj at kohaaloha.com> --- > Created attachment 11549 [details] > Signed off patch > > In order for the patch to work, you must *REMOVE* koha-common, and reinstall > from scratch. > > VERY IMPORTANT!!! The tabs in debian/rules are mandatory. Do not replace > them with four spaces. Use -n when committing to skip pre-commit git hook > verifications. VERY IMPORTANT!!! bumping priority to an easy fix/sign-off patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 14:49:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 12:49:17 +0000 Subject: [Koha-bugs] [Bug 2060] Ability to import Authorities from Staff Client In-Reply-To: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2060-70-e9VATYEYdR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2060 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 14:49:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 12:49:20 +0000 Subject: [Koha-bugs] [Bug 2060] Ability to import Authorities from Staff Client In-Reply-To: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2060-70-oW7H4HXPnb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2060 --- Comment #37 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12218 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12218&action=edit Bug 2060 follow-up: add support for UNIMARCAUTH The staged MARC management script was not correctly informing the decoder ring that we had UNIMARC authorities, and the decoder ring was dutifully trying to turn the authority records into a bibliographic box of cereal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 14:49:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 12:49:50 +0000 Subject: [Koha-bugs] [Bug 7671] add a real primary key "accountlinesid" in accountlines In-Reply-To: <bug-7671-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7671-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7671-70-ljfSXBQ6A3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7671 --- Comment #27 from Mason James <mtj at kohaaloha.com> --- Created attachment 12219 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12219&action=edit Bug 7671 : add a real primary key accountlines_id in accountlines Signed-off-by: St?phane Delaune <stephane.delaune at biblibre.com> Signed-off-by: Marc Veron <veron at veron.ch> NOTE: After applying the patch I got following errors in members/pay.pl: Global symbol "$writeoff_sth" requires explicit package name Global symbol "$add_writeoff_sth" requires explicit package name Added to lines at the begin of members/pay.pl: our $writeoff_sth; our $add_writeoff_sth; Now the patch worked as expected. However I am not quite sure if signing off is OK in this situation. Marc Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 14:50:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 12:50:09 +0000 Subject: [Koha-bugs] [Bug 7671] add a real primary key "accountlinesid" in accountlines In-Reply-To: <bug-7671-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7671-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7671-70-8P3nkupde6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7671 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12055|0 |1 is obsolete| | --- Comment #28 from Mason James <mtj at kohaaloha.com> --- Created attachment 12220 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12220&action=edit Bug 7671 : add a real primary key accountlines_id in accountlines Signed-off-by: St?phane Delaune <stephane.delaune at biblibre.com> Signed-off-by: Marc Veron <veron at veron.ch> NOTE: After applying the patch I got following errors in members/pay.pl: Global symbol "$writeoff_sth" requires explicit package name Global symbol "$add_writeoff_sth" requires explicit package name Added to lines at the begin of members/pay.pl: our $writeoff_sth; our $add_writeoff_sth; Now the patch worked as expected. However I am not quite sure if signing off is OK in this situation. Marc Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 14:50:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 12:50:43 +0000 Subject: [Koha-bugs] [Bug 8726] Did you mean? plugin for broader/narrower/related terms In-Reply-To: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8726-70-pHfKgiqkWW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 --- Comment #8 from Jonathan Druart <jonathan.druart at biblibre.com> --- QA comments: * 3 perlcritics errors on Koha/SuggestionEngine/Base.pm: Expression form of "eval" at line 137, column 12. See page 161 of PBP. (Severity: 5) Expression form of "eval" at line 151, column 12. See page 161 of PBP. (Severity: 5) Expression form of "eval" at line 165, column 12. See page 161 of PBP. (Severity: 5) But I don't know how to fix them! * The 2 sysprefs don't appear in a yaml file. I understand why (there is a specific config page) but they appear in the "Local Use" tab :-/ It could be considered as an issue. * It would be great to provide 2 patchs. 1 for the feature and 1 for the jQuery changes. Like that if a problem appears on it, it will be easy to revert the commit. I don't find anything else :) It works great ! I Failed QA for the overflow issue (see previous comment). After that I will be happy to mark it as passed qa. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 14:50:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 12:50:57 +0000 Subject: [Koha-bugs] [Bug 8726] Did you mean? plugin for broader/narrower/related terms In-Reply-To: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8726-70-sa8ZYsIHao@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA QA Contact| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 14:51:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 12:51:17 +0000 Subject: [Koha-bugs] [Bug 7671] add a real primary key "accountlinesid" in accountlines In-Reply-To: <bug-7671-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7671-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7671-70-vgm0m0zLzt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7671 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12220|0 |1 is obsolete| | --- Comment #29 from Mason James <mtj at kohaaloha.com> --- Comment on attachment 12220 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12220 Bug 7671 : add a real primary key accountlines_id in accountlines oops -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 14:52:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 12:52:45 +0000 Subject: [Koha-bugs] [Bug 8656] Koha::Calendar not loading both sets of special dates In-Reply-To: <bug-8656-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8656-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8656-70-1jNFnQ6gjy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8656 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 --- Comment #4 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 14:53:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 12:53:24 +0000 Subject: [Koha-bugs] [Bug 8418] Koha::Calendar is_holiday ignores all user data In-Reply-To: <bug-8418-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8418-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8418-70-p5TAjBLpe3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8418 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 --- Comment #27 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 14:57:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 12:57:34 +0000 Subject: [Koha-bugs] [Bug 8764] Template change "Authors" to "Additional authors" in OPAC In-Reply-To: <bug-8764-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8764-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8764-70-hn8lpQT5SP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8764 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> --- QA Comments: Simple string change in template, marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 14:57:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 12:57:44 +0000 Subject: [Koha-bugs] [Bug 8764] Template change "Authors" to "Additional authors" in OPAC In-Reply-To: <bug-8764-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8764-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8764-70-s541qqQR2u@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8764 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 14:58:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 12:58:18 +0000 Subject: [Koha-bugs] [Bug 7671] add a real primary key "accountlinesid" in accountlines In-Reply-To: <bug-7671-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7671-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7671-70-dPwxT68wB6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7671 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12056|0 |1 is obsolete| | Attachment #12219|0 |1 is obsolete| | --- Comment #30 from Mason James <mtj at kohaaloha.com> --- Created attachment 12221 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12221&action=edit Bug 7671 : add a real primary key accountlines_id in accountlines Signed-off-by: St?phane Delaune <stephane.delaune at biblibre.com> Signed-off-by: Marc Veron <veron at veron.ch> NOTE: After applying the patch I got following errors in members/pay.pl: Global symbol "$writeoff_sth" requires explicit package name Global symbol "$add_writeoff_sth" requires explicit package name Added to lines at the begin of members/pay.pl: our $writeoff_sth; our $add_writeoff_sth; Now the patch worked as expected. However I am not quite sure if signing off is OK in this situation. Marc Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 14:59:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 12:59:09 +0000 Subject: [Koha-bugs] [Bug 8300] Koha should have mechanized testing suite In-Reply-To: <bug-8300-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8300-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8300-70-zzM3K2DwFB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8300 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 14:59:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 12:59:11 +0000 Subject: [Koha-bugs] [Bug 8300] Koha should have mechanized testing suite In-Reply-To: <bug-8300-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8300-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8300-70-aNRgCONQil@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8300 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12103|0 |1 is obsolete| | --- Comment #8 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12222 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12222&action=edit Bug 8300: Add mechanized unit test for batch import This new unit test confirms that importing records via the Stage MARC import tool still works by connecting to a Koha instance and importing a record then reverting the import, checking at each step of the way that everything is as it should be. To test: 1. Install Test::WWW::Mechanize > sudo apt-get install libtest-www-mechanize-perl 2. Set environment variables to reflect your Koha instance: > export KOHA_USER=kohaadmin > export KOHA_PASS=katikoan > export KOHA_INTRANET_URL=http://localhost:8080 > export KOHA_OPAC_URL=http://localhost 3. Run the test: > prove t/db_dependent/www/batch.t This updated patch now handles both MARC21 and UNIMARC installations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 15:01:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 13:01:25 +0000 Subject: [Koha-bugs] [Bug 8768] t/ItemType.t fails because DBD::Mock has no empty result set In-Reply-To: <bug-8768-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8768-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8768-70-FQlNCpshEi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8768 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> --- QA Comments: The patch fixes a failed test. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 15:01:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 13:01:36 +0000 Subject: [Koha-bugs] [Bug 8768] t/ItemType.t fails because DBD::Mock has no empty result set In-Reply-To: <bug-8768-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8768-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8768-70-2YUDiypKH0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8768 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 15:02:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 13:02:27 +0000 Subject: [Koha-bugs] [Bug 8447] can't save new records / indicator error In-Reply-To: <bug-8447-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8447-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8447-70-L8GCzvCCLo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8447 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 --- Comment #24 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master (problem not reproduced by me, though. I just checked nothing was broken) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 15:02:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 13:02:50 +0000 Subject: [Koha-bugs] [Bug 7671] add a real primary key "accountlinesid" in accountlines In-Reply-To: <bug-7671-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7671-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7671-70-zasEuPZ641@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7671 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #31 from Mason James <mtj at kohaaloha.com> --- > Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> > Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> woah, sorry about that, git-bz when a little crazy on me... :/ i rebased these patches as i got a UTF-utf header error patches looks good, passing QA? $ koha-qa.pl -c 2 testing 2 commit(s) (applied to commit 0acebb8) * f38273f Bug 7671 : followup : delete return of makepayment because unused C4/Accounts.pm installer/data/mysql/updatedatabase.pl * c9c2f88 Bug 7671 : add a real primary key accountlines_id in accountlines C4/Accounts.pm C4/Circulation.pm installer/data/mysql/kohastructure.sql installer/data/mysql/updatedatabase.pl koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt members/boraccount.pl members/pay.pl members/paycollect.pl members/printinvoice.pl * C4/Accounts.pm OK * installer/data/mysql/updatedatabase.pl OK * C4/Circulation.pm OK * members/boraccount.pl OK * members/pay.pl OK * members/paycollect.pl OK * members/printinvoice.pl OK * koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt OK * koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt OK * koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 15:03:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 13:03:01 +0000 Subject: [Koha-bugs] [Bug 8726] Did you mean? plugin for broader/narrower/related terms In-Reply-To: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8726-70-RLz7QkLMvR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 --- Comment #9 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- (In reply to comment #8) > QA comments: > > * 3 perlcritics errors on Koha/SuggestionEngine/Base.pm: > Expression form of "eval" at line 137, column 12. See page 161 of PBP. > (Severity: 5) > Expression form of "eval" at line 151, column 12. See page 161 of PBP. > (Severity: 5) > Expression form of "eval" at line 165, column 12. See page 161 of PBP. > (Severity: 5) > But I don't know how to fix them! I'll see if I can figure something out. > * The 2 sysprefs don't appear in a yaml file. I understand why (there is a > specific config page) but they appear in the "Local Use" tab :-/ > It could be considered as an issue. I think this is a feature, because that way it is possible to work around not having javascript. My warning makes it very clear that setting those sysprefs directly is a bad idea, though. > * It would be great to provide 2 patchs. 1 for the feature and 1 for the > jQuery changes. Like that if a problem appears on it, it will be easy to > revert the commit. I will break the existing patch into two, and do a follow-up for the overflow. > I don't find anything else :) > It works great ! > > I Failed QA for the overflow issue (see previous comment). After that I will > be happy to mark it as passed qa. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 15:06:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 13:06:06 +0000 Subject: [Koha-bugs] [Bug 8617] Problem with display of comments waiting for moderation in OPAC In-Reply-To: <bug-8617-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8617-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8617-70-KOW1BwA7Hf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8617 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11647|0 |1 is obsolete| | Attachment #11720|0 |1 is obsolete| | --- Comment #4 from Mason James <mtj at kohaaloha.com> --- Created attachment 12223 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12223&action=edit Bug 8617 - Problem with display of comments waiting for moderation in OPAC This patch addresses on aspect of Bug 8617: The behavior where live previews of edited comments are displaying on opac-detail as a duplicate comment. We must pass the review id back to the script when submitting so that the check for it will evaluate as true when it should. This patch also corrects some JavaScript for translatability. To test, submit a comment on a title and approve it. Return to the title and edit the comment. When you submit your revised comment the comment pop-up window should close and your revised comment should appear on opac-detail as "pending approval." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 15:06:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 13:06:37 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6679-70-7Lo12mDsOA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #158 from Colin Campbell <colin.campbell at ptfs-europe.com> --- Created attachment 12224 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12224&action=edit Proposed patch This patch fixes two instances that cause Jemkins builds to fail -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 15:07:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 13:07:08 +0000 Subject: [Koha-bugs] [Bug 8617] Problem with display of comments waiting for moderation in OPAC In-Reply-To: <bug-8617-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8617-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8617-70-ITczYVp96X@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8617 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11720|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 15:07:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 13:07:37 +0000 Subject: [Koha-bugs] [Bug 8617] Problem with display of comments waiting for moderation in OPAC In-Reply-To: <bug-8617-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8617-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8617-70-g2KXlE1pHQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8617 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12223|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 15:09:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 13:09:10 +0000 Subject: [Koha-bugs] [Bug 8617] Problem with display of comments waiting for moderation in OPAC In-Reply-To: <bug-8617-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8617-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8617-70-9L7uYUHSxY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8617 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com QA Contact| |mtj at kohaaloha.com --- Comment #5 from Mason James <mtj at kohaaloha.com> --- (In reply to comment #3) > Created attachment 11720 [details] > [SIGNED-OFF] Bug 8617 - Problem with display of comments waiting for > moderation in OPAC > > Works as expected. patch looks good, passing QA? $ koha-qa.pl testing 1 commit(s) (applied to commit 0acebb8) * 1834255 Bug 8617 - Problem with display of comments waiting for moderatio koha-tmpl/opac-tmpl/prog/en/modules/opac-review.tt * koha-tmpl/opac-tmpl/prog/en/modules/opac-review.tt OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 15:10:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 13:10:15 +0000 Subject: [Koha-bugs] [Bug 8765] Add series title to intranet search results In-Reply-To: <bug-8765-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8765-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8765-70-7uIXMXncJk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8765 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12180|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 12225 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12225&action=edit [SIGNED-OFF] Bug 8765 - Add series title to intranet search results Patch adds series title to intranet search results, so that the series volume is no longer displayed on its own. It also removes the comma that comes before the series volume as this is unnecessary punctuation that creates duplicate punctuation in search results. Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 15:14:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 13:14:25 +0000 Subject: [Koha-bugs] [Bug 8765] Add series title to intranet search results In-Reply-To: <bug-8765-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8765-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8765-70-Q9LKCWCj74@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8765 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- It's worth noting that this patch is for the "normal" display and enables the display of whatever series title has been put into biblio.seriestitle, and Koha to MARC mapping limits this to a one-to-one relationship. If you've chosen to map 440, you won't see 490. The XSLT results page doesn't appear to have any series handling at all. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 15:17:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 13:17:49 +0000 Subject: [Koha-bugs] [Bug 8750] Chronological terms authorities not correctly indexed In-Reply-To: <bug-8750-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8750-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8750-70-Y2Eaff4lTK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8750 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 15:18:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 13:18:04 +0000 Subject: [Koha-bugs] [Bug 8300] Koha should have mechanized testing suite In-Reply-To: <bug-8300-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8300-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8300-70-f5YatwBPrC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8300 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jcamins at cpbibliography.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 15:18:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 13:18:48 +0000 Subject: [Koha-bugs] [Bug 7967] Z39.50 client should negotiate encoding with server In-Reply-To: <bug-7967-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7967-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7967-70-bXB9eml72v@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7967 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |pongtawat.c at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 15:25:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 13:25:16 +0000 Subject: [Koha-bugs] [Bug 8738] DateTime object being compared to a date string in circulation In-Reply-To: <bug-8738-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8738-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8738-70-GUayzFMPCo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8738 --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- See a lot of errors in the log from circulation.pl, but not this one. Does this only happen with a certain version or under certain circumstances? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 15:27:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 13:27:00 +0000 Subject: [Koha-bugs] [Bug 8300] Koha should have mechanized testing suite In-Reply-To: <bug-8300-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8300-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8300-70-WCF3rvY2NC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8300 Magnus Enger <magnus at enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12222|0 |1 is obsolete| | --- Comment #9 from Magnus Enger <magnus at enger.priv.no> --- Created attachment 12226 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12226&action=edit Bug 8300: Add mechanized unit test for batch import This new unit test confirms that importing records via the Stage MARC import tool still works by connecting to a Koha instance and importing a record then reverting the import, checking at each step of the way that everything is as it should be. To test: 1. Install Test::WWW::Mechanize > sudo apt-get install libtest-www-mechanize-perl 2. Set environment variables to reflect your Koha instance: > export KOHA_USER=kohaadmin > export KOHA_PASS=katikoan > export KOHA_INTRANET_URL=http://localhost:8080 > export KOHA_OPAC_URL=http://localhost 3. Run the test: > prove t/db_dependent/www/batch.t This updated patch now handles both MARC21 and UNIMARC installations. Signed-off-by: Magnus Enger <magnus at enger.priv.no> All tests pass with marcflavour = MARC21 and NORMARC. Test #15 fails when marcflavour = UNIMARC, but from what I can see, that is because I'm testing on a MARC21 setup, missing the UNIMARC frameworks etc. I'm signing off - QA folks, please ask for a proper UNIMARC signoff if you feel it is needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 15:27:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 13:27:45 +0000 Subject: [Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC In-Reply-To: <bug-6976-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6976-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6976-70-NB0QtPSVBC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 --- Comment #27 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master I had some trouble reproducing the behaviour (defining issuingrules correctly is sometimes tricky ;-) ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 15:28:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 13:28:45 +0000 Subject: [Koha-bugs] [Bug 8300] Koha should have mechanized testing suite In-Reply-To: <bug-8300-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8300-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8300-70-DbyoRmXUNc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8300 Magnus Enger <magnus at enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #10 from Magnus Enger <magnus at enger.priv.no> --- Not tested on a UNIMARC setup, but still signing off. It's not as if this will break anything if there really is an error for UNIMARC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 15:30:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 13:30:28 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6679-70-lAvMCZ6NBl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #159 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to comment #158) > Created attachment 12224 [details] > Proposed patch > > This patch fixes two instances that cause Jemkins builds to fail Why don't you just remove the "undef" word ? I think if ($@) { return; } is less readable as return if $@; Don't you think ? I can provide a new patch but I don't want to go against what you want. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 15:43:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 13:43:20 +0000 Subject: [Koha-bugs] [Bug 8002] Can't add patron attribute type in newer installation In-Reply-To: <bug-8002-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8002-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8002-70-oZjG46Lst8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8002 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 --- Comment #25 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master Patch pushed on master branch directly, as the new/bug_8002 is old -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 15:45:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 13:45:12 +0000 Subject: [Koha-bugs] [Bug 8508] Holds to Pull : Library dropdown options are erroneously concatenated by br tags In-Reply-To: <bug-8508-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8508-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8508-70-GfXXboa8Zh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8508 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12184|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 12227 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12227&action=edit [SIGNED-OFF] Bug 8508: Followup: Simplify the separateData js function -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 15:45:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 13:45:26 +0000 Subject: [Koha-bugs] [Bug 8508] Holds to Pull : Library dropdown options are erroneously concatenated by br tags In-Reply-To: <bug-8508-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8508-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8508-70-9Fxqx0aeaT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8508 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 15:47:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 13:47:50 +0000 Subject: [Koha-bugs] [Bug 5079] Make display of shelving location and call number in XSLT results controlled by sysprefs In-Reply-To: <bug-5079-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5079-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5079-70-EJQWjfXzcy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5079 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #43 from Owen Leonard <oleonard at myacpl.org> --- Applying: Bug 5079 - Make display of shelving location and call number in XSLT results controlled by sysprefs error: patch failed: C4/XSLT.pm:187 error: C4/XSLT.pm: patch does not apply error: patch failed: installer/data/mysql/sysprefs.sql:375 error: installer/data/mysql/sysprefs.sql: patch does not apply error: patch failed: installer/data/mysql/updatedatabase.pl:5536 error: installer/data/mysql/updatedatabase.pl: patch does not apply error: patch failed: koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACResults.xsl:27 error: koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACResults.xsl: patch does not apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 15:51:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 13:51:04 +0000 Subject: [Koha-bugs] [Bug 7583] undo receive In-Reply-To: <bug-7583-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7583-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7583-70-LPKl1BA74F@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7583 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #18 from Julian Maurice <julian.maurice at biblibre.com> --- Ok in master. Marked as RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 15:51:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 13:51:05 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5336-70-BgoRhBzMsq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Bug 5336 depends on bug 7583, which changed state. Bug 7583 Summary: undo receive http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7583 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 15:52:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 13:52:42 +0000 Subject: [Koha-bugs] [Bug 7168] Search orders by basket group name In-Reply-To: <bug-7168-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7168-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7168-70-og4ZpeQe6t@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7168 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #5 from Julian Maurice <julian.maurice at biblibre.com> --- Ok in master. Marked as RESOLVED. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 15:52:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 13:52:42 +0000 Subject: [Koha-bugs] [Bug 7163] BibLibre acquisitions omnibus In-Reply-To: <bug-7163-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7163-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7163-70-lzquojpWd8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7163 Bug 7163 depends on bug 7168, which changed state. Bug 7168 Summary: Search orders by basket group name http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7168 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 15:57:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 13:57:11 +0000 Subject: [Koha-bugs] [Bug 8666] Prevent to create baskets for inactive suppliers In-Reply-To: <bug-8666-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8666-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8666-70-6GMdi8vBrn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8666 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #9 from Julian Maurice <julian.maurice at biblibre.com> --- Ok in master and 3.8.x. Marked as RESOLVED. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 15:58:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 13:58:35 +0000 Subject: [Koha-bugs] [Bug 3456] Serials receipt note In-Reply-To: <bug-3456-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3456-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3456-70-kWKmix7WM4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3456 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #9 from Julian Maurice <julian.maurice at biblibre.com> --- Ok in master and 3.8.x. Marked as RESOLVED. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 16:00:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 14:00:18 +0000 Subject: [Koha-bugs] [Bug 8302] Add accesssion number to the drop down list in OPAC Search. In-Reply-To: <bug-8302-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8302-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8302-70-41q12S6Mun@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8302 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10452|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 16:00:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 14:00:33 +0000 Subject: [Koha-bugs] [Bug 8743] ZOOM error when merging authority change to biblios In-Reply-To: <bug-8743-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8743-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8743-70-fMKiik9czf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8743 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 --- Comment #8 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master Bug existing also in 3.8 ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 16:00:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 14:00:43 +0000 Subject: [Koha-bugs] [Bug 8575] Number of items expected is wrong In-Reply-To: <bug-8575-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8575-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8575-70-KUpOUo90ZI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8575 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> --- Ok in master and 3.8.x. Marked as RESOLVED. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 16:03:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 14:03:22 +0000 Subject: [Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off In-Reply-To: <bug-8462-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8462-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8462-70-IByN7K93ay@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED CC| |paul.poulain at biblibre.com --- Comment #5 from Paul Poulain <paul.poulain at biblibre.com> --- i'm not sure i'm happy with this fix. It means you will get results without any items, right ? I'm asking for another signoff or someone opinion by switching back to "need signoff" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 16:03:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 14:03:22 +0000 Subject: [Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries In-Reply-To: <bug-8137-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8137-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8137-70-3mDEgNkyEp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #6 from Jonathan Druart <jonathan.druart at biblibre.com> --- I change the status to in discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 16:03:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 14:03:30 +0000 Subject: [Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off In-Reply-To: <bug-8462-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8462-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8462-70-M9GVtM3EF2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 16:04:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 14:04:02 +0000 Subject: [Koha-bugs] [Bug 8495] Javascript error when creating a new order In-Reply-To: <bug-8495-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8495-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8495-70-2b2FZXJ9um@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8495 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #8 from Julian Maurice <julian.maurice at biblibre.com> --- Ok in master and 3.8.x. Marked as RESOLVED. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 16:04:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 14:04:17 +0000 Subject: [Koha-bugs] [Bug 8739] Partial Fine Payments Saving Amount Paid Incorrectly In-Reply-To: <bug-8739-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8739-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8739-70-V6ajchFs73@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8739 --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Can you please add a test plan for this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 16:04:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 14:04:50 +0000 Subject: [Koha-bugs] [Bug 8700] RESERVESLIP fields not being replaced correctly In-Reply-To: <bug-8700-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8700-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8700-70-QBoVtgojB5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8700 --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Can you please add a test plan for this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 16:09:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 14:09:48 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6874-70-vDRMzHNtkS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #40 from Julian Maurice <julian.maurice at biblibre.com> --- At the end, filenames are just filenames. I think this is needed if you want to access uploaded files 'manually' (not with Koha). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 16:12:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 14:12:05 +0000 Subject: [Koha-bugs] [Bug 8739] Partial Fine Payments Saving Amount Paid Incorrectly In-Reply-To: <bug-8739-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8739-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8739-70-e0iUiY4sbw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8739 --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> --- * Create two fines * Make a partial payment one fine 1, make a full payment on the other * Look at the fines in koha, one payment will be green, the other red. This reflects the positive or negative signed-ness of the payment. * Apply the patch and repeat. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 16:12:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 14:12:44 +0000 Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters) In-Reply-To: <bug-7679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7679-70-UPxWVyo3YX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 16:13:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 14:13:10 +0000 Subject: [Koha-bugs] [Bug 8230] Show the ordered status in catalogue page In-Reply-To: <bug-8230-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8230-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8230-70-6ZUDG8BAj7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- This doesn't apply anymore. I see there's a good test plan in the patch description--please include it in a bug comment when you resubmit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 16:14:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 14:14:24 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: <bug-6813-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6813-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6813-70-ysQHcrddrU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|koha.sekjal at gmail.com |jonathan.druart at biblibre.co | |m --- Comment #16 from Jonathan Druart <jonathan.druart at biblibre.com> --- QA Comments: I already made QA on it. I fixed my QA remarks and the patch I proposed was signoff by Marc V?ron. So I mark it as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 16:19:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 14:19:17 +0000 Subject: [Koha-bugs] [Bug 8420] tool statisticfines.pl(bz 6858) and hourly loan(bz5549) In-Reply-To: <bug-8420-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8420-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8420-70-hpmU1SpirP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8420 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 --- Comment #5 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master Very local fix to a cron job. Even if the patch is written & signed-off by BibLibre, no side-effect risk at all, i've pushed it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 16:22:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 14:22:34 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8296-70-Ejj4GlDqlw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #7 from Julian Maurice <julian.maurice at biblibre.com> --- Hmm I suspect a copy/paste error... Fix is coming. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 16:23:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 14:23:07 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8296-70-e1rKeXSBps@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #8 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 12228 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12228&action=edit Bug 8296: set input maxlength to the same of sql field length -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 16:23:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 14:23:26 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8296-70-QlAXXst04D@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11552|Bug 8296: Add descriptive |[SIGNED-OFF] Bug 8296: Add description|(text) published date field |descriptive (text) |for serials |published date field for | |serials -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 16:23:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 14:23:34 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8296-70-bC8ugtyQnz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 16:28:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 14:28:02 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8296-70-W312QFoyo4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11552|0 |1 is obsolete| | --- Comment #9 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 12229 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12229&action=edit [SIGNED-OFF] Bug 8296: Add descriptive (text) published date field for serials -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 16:28:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 14:28:44 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8296-70-hU5kv7eLUt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12228|0 |1 is obsolete| | --- Comment #10 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 12230 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12230&action=edit Bug 8296: set input maxlength to the same of sql field length -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 16:28:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 14:28:52 +0000 Subject: [Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices In-Reply-To: <bug-6030-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6030-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6030-70-wKEuJbmbZD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12112|0 |1 is obsolete| | --- Comment #20 from Mason James <mtj at kohaaloha.com> --- Created attachment 12231 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12231&action=edit Bug 6030 followup : Specify "biblio.title" as a column name to differentiate from borrowers.title -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 16:28:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 14:28:55 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8296-70-mObT2cDTj4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #11 from Julian Maurice <julian.maurice at biblibre.com> --- Both patch rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 16:30:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 14:30:39 +0000 Subject: [Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices In-Reply-To: <bug-6030-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6030-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6030-70-Lz58OKMpjq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12110|0 |1 is obsolete| | Attachment #12111|0 |1 is obsolete| | Attachment #12113|0 |1 is obsolete| | --- Comment #21 from Mason James <mtj at kohaaloha.com> --- Created attachment 12232 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12232&action=edit Bug 6030 Allow html content in letters Squashed commit of the following: commit 8368e5de723ec7607402be341975014c8b7b0ea9 Author: Henri-Damien LAURENT <henridamien.laurent at biblibre.com> Date: Tue Sep 21 14:41:07 2010 +0200 Bug 6030 : overdue_notices :Removing warning Two extra warnings were issued when using html commit 5984fc92772af68c51f7f5b5450fd5b27d5b6d37 Author: Henri-Damien LAURENT <henridamien.laurent at biblibre.com> Date: Tue Sep 21 12:27:29 2010 +0200 Bug 6030 : Letters can be html in overdu_notices.pl Signed-off-by: Sophie Meynieux <sophie.meynieux at biblibre.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 16:32:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 14:32:23 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: <bug-5349-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5349-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5349-70-QT6GqwDkCM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #31 from Julian Maurice <julian.maurice at biblibre.com> --- (In reply to comment #30) > QA Question: > return unless $ordernumber or $basketno; > > Should this not be an AND ? Yes, this should be AND! I will submit a follow-up -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 16:34:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 14:34:49 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8296-70-N8UbrRhZ6E@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12230|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 12233 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12233&action=edit Bug 8296: set input maxlength to the same of sql field length Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 16:35:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 14:35:17 +0000 Subject: [Koha-bugs] [Bug 6151] IndependantBranches and HomeOrHoldingBranchReturn can prevent items from being checked in In-Reply-To: <bug-6151-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6151-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6151-70-Q5hJWpkbma@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6151 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #19 from Paul Poulain <paul.poulain at biblibre.com> --- Can't this feature be achieved already with branch transfer limits ? I thought that, with this feature activated, one can do much precise return rules than with just a syspref. Looking at the code, I realize I'm wrong: C4/Circulation.pm, sub AddReturn says: if ($hbr ne $branch && C4::Context->preference("IndependantBranches") && !(C4::Context->preference("canreservefromotherbranches"))){ $messages->{'Wrongbranch'} = { Wrongbranch => $branch, Rightbranch => $hbr, }; $doreturn = 0; # bailing out here - in this case, current desired behavior # is to act as if no return ever happened at all. # FIXME - even in an indy branches situation, there should # still be an option for the library to accept the item # and transfer it to its owning library. return ( $doreturn, $messages, $issue, $borrower ); But shouldn't we use the branch_transfer_limit anyway (and not this new syspref) (just throwing asking the question, not rejecting the patch) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 16:35:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 14:35:33 +0000 Subject: [Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices In-Reply-To: <bug-6030-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6030-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6030-70-9uTX7ukRnS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 --- Comment #22 from Mason James <mtj at kohaaloha.com> --- Created attachment 12234 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12234&action=edit Bug 6030 followup : add a condition to use getlanguage in bath mode -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 16:35:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 14:35:58 +0000 Subject: [Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices In-Reply-To: <bug-6030-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6030-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6030-70-qlZJ3yNq6k@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 --- Comment #23 from Mason James <mtj at kohaaloha.com> --- Created attachment 12235 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12235&action=edit Bug 6030 follow-up Fixing problem detected previously: * add column_def retrieval, to have header displaying the "explained" row name, not the table name. (the name is not expanded for CSV exports) * removed some warnings. * fixed some problems with csvfilename being defined/empty. Now, csvfilename is always defined, and set to '' by default. Some tests have been updated accordingly * added the charset=UTF8 on mail headers. This patch also adds some missing columns to columns.def Signed-off-by: Sophie Meynieux <sophie.meynieux at biblibre.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 16:39:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 14:39:26 +0000 Subject: [Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices In-Reply-To: <bug-6030-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6030-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6030-70-tnBqElCRWA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com QA Contact|koha-bugs at lists.koha-commun |mtj at kohaaloha.com |ity.org | --- Comment #24 from Mason James <mtj at kohaaloha.com> --- > Signed-off-by: Sophie Meynieux <sophie.meynieux at biblibre.com> i rebased these 4 patches to apply to master patches looks good, passing QA? nice work Sophie! $ koha-qa.pl -c 4 testing 4 commit(s) (applied to commit 0acebb8) * e34fa8f Bug 6030 followup : add a condition to use getlanguage in bath mo C4/Templates.pm * cb90e51 Bug 6030 follow-up koha-tmpl/intranet-tmpl/prog/en/columns.def misc/cronjobs/overdue_notices.pl * a346838 Bug 6030 followup : Specify "biblio.title" as a column name to di misc/cronjobs/overdue_notices.pl * 8ff05be Bug 6030 Allow html content in letters misc/cronjobs/overdue_notices.pl * C4/Templates.pm OK * misc/cronjobs/overdue_notices.pl OK -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 16:41:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 14:41:15 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: <bug-5349-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5349-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5349-70-9tMsPzeh1z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11117|0 |1 is obsolete| | --- Comment #32 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 12236 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12236&action=edit [SIGNED-OFF] Bug 5349: Order line transfers Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 16:41:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 14:41:45 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: <bug-5349-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5349-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5349-70-CXSRb2wDiE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11386|0 |1 is obsolete| | --- Comment #33 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 12237 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12237&action=edit [SIGNED-OFF] Bug 5349 follow-up: run transferorder.pl in a popup Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 16:42:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 14:42:17 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: <bug-5349-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5349-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5349-70-reJEeBHXsq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #34 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 12238 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12238&action=edit Bug 5349: Fix a logical test in TransferOrder -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 16:42:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 14:42:25 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: <bug-5349-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5349-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5349-70-rzFRshlHWM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 16:45:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 14:45:56 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8296-70-F16twhASiD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #13 from Jonathan Druart <jonathan.druart at biblibre.com> --- QA Comments: * serials/serials-collection.pl FAIL forbidden patterns FAIL The patch introduces a forbidden pattern: tabulation character at line 2 + my $sth = $dbh->prepare("; valid OK critic OK * serials/serials-edit.pl FAIL forbidden patterns OK valid FAIL "my" variable @publisheddates masks earlier declaration in same scope critic OK 1 tabulation character and 1 redefined variable. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 16:47:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 14:47:28 +0000 Subject: [Koha-bugs] [Bug 5339] Parcel closing in acq In-Reply-To: <bug-5339-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5339-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5339-70-E6ORC9ryVc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #74 from Mason James <mtj at kohaaloha.com> --- > > - some unit tests for your invoices routines would be perfect. See Bug 5327, > > using DBD::Mock it is very simple. > > I'm not writing tests with DBD::Mock since I don't know how to use it (see > http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327#c219) hmmm, we are we waiting on a unit-test before this can be QA'ed Jonathon, would you do a Mock test for this, before i QA? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 16:51:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 14:51:15 +0000 Subject: [Koha-bugs] [Bug 8244] Script to find exporter problems In-Reply-To: <bug-8244-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8244-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8244-70-hmt5cymNTv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8244 --- Comment #19 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 12239 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12239&action=edit Bug 8244: Add PPI to the list of Perl dependencies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 16:51:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 14:51:47 +0000 Subject: [Koha-bugs] [Bug 8244] Script to find exporter problems In-Reply-To: <bug-8244-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8244-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8244-70-07nidojxus@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8244 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11346|Bug 8244 follow-up: |[SIGNED-OFF] Bug 8244 description|improvements to |follow-up: improvements to |find-undefined-subroutines |find-undefined-subroutines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 16:51:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 14:51:54 +0000 Subject: [Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC In-Reply-To: <bug-4173-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4173-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4173-70-6UU2o3UGOH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 --- Comment #22 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 16:51:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 14:51:58 +0000 Subject: [Koha-bugs] [Bug 8244] Script to find exporter problems In-Reply-To: <bug-8244-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8244-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8244-70-0B0szUASxN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8244 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 16:52:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 14:52:09 +0000 Subject: [Koha-bugs] [Bug 5339] Parcel closing in acq In-Reply-To: <bug-5339-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5339-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5339-70-xrji11uxXk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #75 from Jonathan Druart <jonathan.druart at biblibre.com> --- Kyle, The patch is waiting for 9 months then I think it can pass qa without UT. But a followup will be required. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 16:54:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 14:54:05 +0000 Subject: [Koha-bugs] [Bug 8667] Add budget and branch columns in histsearch.pl results In-Reply-To: <bug-8667-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8667-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8667-70-8dJV73FQBy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8667 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Julian Maurice <julian.maurice at biblibre.com> --- I reset status to needs signoff, but this bug still depends on bug 7290 so it can't be tested on a sandbox. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 16:59:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 14:59:06 +0000 Subject: [Koha-bugs] [Bug 8629] update of statistics fields on fund selection in order creation/edition In-Reply-To: <bug-8629-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8629-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8629-70-QFGBfUkbxb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8629 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 --- Comment #4 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 17:05:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 15:05:14 +0000 Subject: [Koha-bugs] [Bug 4491] Cleaning some weird code in *search.pl In-Reply-To: <bug-4491-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4491-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4491-70-TyklM1SvkW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4491 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com QA Contact|koha-bugs at lists.koha-commun |mtj at kohaaloha.com |ity.org | --- Comment #13 from Mason James <mtj at kohaaloha.com> --- > > Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com> patches looks good, passing QA? mason at xen1:~/g/head$ koha-qa.pl -c 2 testing 2 commit(s) (applied to commit 0acebb8) * 65911df Bug 4491: FIX buildQuery if called with an empty limit C4/Search.pm * d8b1b52 Bug 4491: fix weird code in search scripts catalogue/search.pl opac/opac-search.pl * C4/Search.pm OK * catalogue/search.pl OK * opac/opac-search.pl OK -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 17:05:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 15:05:17 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8296-70-IQOc1R3612@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 --- Comment #14 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 12240 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12240&action=edit [SIGNED-OFF] Bug 8296: Follow up for QA 1 tab replaced by space 1 redefined variable removed Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 17:05:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 15:05:18 +0000 Subject: [Koha-bugs] [Bug 7401] Shelving Location facet instead of Branch facet when only 1 branch configured In-Reply-To: <bug-7401-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7401-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7401-70-tisrboiH4s@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 --- Comment #29 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 12241 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12241&action=edit Shelving location facet showing "*" link Is it to be expected that one of the facets is "*"--representing items with no shelving location I assume? Or is there a problem with my data? I don't think narrowing a search to items without shelving location is useful to patrons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 17:07:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 15:07:09 +0000 Subject: [Koha-bugs] [Bug 8705] Software error on help of main page In-Reply-To: <bug-8705-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8705-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8705-70-5LhsdyyAGg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8705 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com QA Contact| |mtj at kohaaloha.com --- Comment #11 from Mason James <mtj at kohaaloha.com> --- > Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> patch looks good, passing QA? $ koha-qa.pl testing 1 commit(s) (applied to commit 0acebb8) * 6980862 Bug 8705: Software error on help of main page help.pl * help.pl OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 17:10:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 15:10:14 +0000 Subject: [Koha-bugs] [Bug 8714] Poorly ordered and triggers warning in marctagstructure.pl In-Reply-To: <bug-8714-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8714-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8714-70-czqdHZEo8M@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8714 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com QA Contact| |mtj at kohaaloha.com --- Comment #3 from Mason James <mtj at kohaaloha.com> --- > Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> patch looks good, passing QA? $ koha-qa.pl testing 1 commit(s) (applied to commit 0acebb8) * 146447b Bug 8714 - Poorly ordered and triggers warning in marctagstructur admin/marctagstructure.pl * admin/marctagstructure.pl OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 17:10:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 15:10:39 +0000 Subject: [Koha-bugs] [Bug 7751] Decrease loan period on items with a high number of holds In-Reply-To: <bug-7751-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7751-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7751-70-2D0833KeHK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 --- Comment #29 from Paul Poulain <paul.poulain at biblibre.com> --- I must be dumb but I still not sure to see well how this feature work. Am I right if I say "It reduces the check-out duration of an item by [decreaseLoanHighHolds] days for items that have more than [decreaseLoanHighHoldsValue] holds pending." ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 17:11:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 15:11:12 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6874-70-DU89fTNGs8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #41 from Owen Leonard <oleonard at myacpl.org> --- This does not apply anymore. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 17:11:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 15:11:43 +0000 Subject: [Koha-bugs] [Bug 7690] hidelostitems not working in Normal Display In-Reply-To: <bug-7690-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7690-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7690-70-9gc7cn522A@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7690 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com --- Comment #7 from Mason James <mtj at kohaaloha.com> --- (In reply to comment #6) > Created attachment 11878 [details] > [SIGNED-OFF] Bug 7690: hidelostitems not working in Normal Display > Signed-off-by: Owen Leonard <oleonard at myacpl.org> patch looks good, passing QA? $ koha-qa.pl testing 1 commit(s) (applied to commit 0acebb8) * f14ca82 Bug 7690: hidelostitems not working in Normal Display C4/Search.pm koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt * C4/Search.pm OK * koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 17:13:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 15:13:15 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6874-70-9mKS6YmkPc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #42 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- (In reply to comment #40) > At the end, filenames are just filenames. I think this is needed if you want > to access uploaded files 'manually' (not with Koha). I thought we switched to using SHA1 as identifier to avoid clobbering files with the same name? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 17:14:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 15:14:13 +0000 Subject: [Koha-bugs] [Bug 8727] Correct help text in rebuild_zebra_sliced.sh In-Reply-To: <bug-8727-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8727-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8727-70-UIuEzHH4hd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8727 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com QA Contact| |mtj at kohaaloha.com --- Comment #4 from Mason James <mtj at kohaaloha.com> --- > Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> patch looks good, passing QA? $ koha-qa.pl testing 1 commit(s) (applied to commit 0acebb8) * 3ccdf19 Bug 8727 Minor stylistic change to help text misc/migration_tools/rebuild_zebra_sliced.sh -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 17:15:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 15:15:55 +0000 Subject: [Koha-bugs] [Bug 8713] Warning message triggered by clicking keyword to marc mapping. In-Reply-To: <bug-8713-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8713-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8713-70-rwxZxiWh1r@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8713 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com QA Contact| |mtj at kohaaloha.com --- Comment #4 from Mason James <mtj at kohaaloha.com> --- > Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> patch looks good, passing QA? $ koha-qa.pl testing 1 commit(s) (applied to commit 0acebb8) * 493b9c2 Bug 8713 - Warning message triggered by clicking Keywords to MARC admin/fieldmapping.pl * admin/fieldmapping.pl OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 17:17:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 15:17:15 +0000 Subject: [Koha-bugs] [Bug 7675] New script for changing selinux file labels on perl scripts In-Reply-To: <bug-7675-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7675-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7675-70-aIFQMgzBAa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7675 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_10 --- Comment #16 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master I don't have selinux, so can't test, but no side-effect risk for users without selinux. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 17:20:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 15:20:56 +0000 Subject: [Koha-bugs] [Bug 8653] With DOM indexing turned on subject authority links are not indexed In-Reply-To: <bug-8653-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8653-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8653-70-RZlgHuCJKs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8653 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 --- Comment #6 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 17:22:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 15:22:08 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-WmXj81f6cx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12197|0 |1 is obsolete| | --- Comment #90 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12242 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12242&action=edit Bug 7067 - OPAC Borrower Self Registration - Followup * Rename PatronSelfRegistrationUseTemporaryStatus to PatronSelfRegistrationDefaultCategory * Hide register link unless PatronSelfRegistrationDefaultCategory is set. * Add invalid token page * Add documentation and switches to cron scripts * Add required fields check for editing exiting patrons * Don't force require email address for existing patrons when PatronSelfRegistrationVerifyByEmail is enabled. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 17:22:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 15:22:52 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: <bug-7417-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7417-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7417-70-axlGNymCVd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #54 from Paul Poulain <paul.poulain at biblibre.com> --- follow-up pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 17:23:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 15:23:15 +0000 Subject: [Koha-bugs] [Bug 8624] famfamfam should be outside theme directory In-Reply-To: <bug-8624-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8624-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8624-70-MWVXh0g9Xv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8624 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #10 from Mason James <mtj at kohaaloha.com> --- (In reply to comment #9) > (In reply to comment #8) > > (In reply to comment #7) > > > Now that you suggest it, I think it might be possible. If Owen can't think > > > of any reason not to, I will submit a revised patch to do this. > > > > I see no reason not to from the template management point of view. If it is > > feasible, let's do it. And the same with itemtypeimg? > > Actually, this would not work with standard installs. hmm, unless we had +symlinks enabled in apache, yeah? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 17:26:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 15:26:51 +0000 Subject: [Koha-bugs] [Bug 8624] famfamfam should be outside theme directory In-Reply-To: <bug-8624-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8624-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8624-70-PBFxaXXitR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8624 --- Comment #11 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- > > > > Now that you suggest it, I think it might be possible. If Owen can't think > > > > of any reason not to, I will submit a revised patch to do this. > > > > > > I see no reason not to from the template management point of view. If it is > > > feasible, let's do it. And the same with itemtypeimg? > > > > Actually, this would not work with standard installs. > > hmm, unless we had +symlinks enabled in apache, yeah? Ooh, that's an intriguing idea. I'm not sure how to do that in a way that won't break dev installs, though, since most developers don't update their koha-httpd.conf files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 17:27:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 15:27:54 +0000 Subject: [Koha-bugs] [Bug 8624] famfamfam should be outside theme directory In-Reply-To: <bug-8624-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8624-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8624-70-ewgRDBlECb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8624 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact| |mtj at kohaaloha.com --- Comment #12 from Mason James <mtj at kohaaloha.com> --- > Signed-off-by: Owen Leonard <oleonard at myacpl.org> patch looks GREAT!!!, passing QA? ;) $ koha-qa.pl testing 1 commit(s) (applied to commit 0acebb8) * 052bd3d Bug 8624: Move famfamfam out of theme directory koha-tmpl/opac-tmpl/lib/famfamfam/AR.png ... koha-tmpl/opac-tmpl/lib/famfamfam/BK.png koha-tmpl/opac-tmpl/prog/famfamfam/silk/zoom_in.png koha-tmpl/opac-tmpl/prog/famfamfam/silk/zoom_out.png * koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tt OK * koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl OK * koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACResults.xsl OK * koha-tmpl/opac-tmpl/prog/en/xslt/NORMARCslim2OPACDetail.xsl OK * koha-tmpl/opac-tmpl/prog/en/xslt/NORMARCslim2OPACResults.xsl OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 17:28:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 15:28:56 +0000 Subject: [Koha-bugs] [Bug 7455] Authority subfields are cloned in the wrong field In-Reply-To: <bug-7455-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7455-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7455-70-NV8YsT7Ixe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #26 from Paul Poulain <paul.poulain at biblibre.com> --- mmm... Mason (& others) : am I right if I say that http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11908 should not have been obsoleted, while one of the 2 follow-up should be ? atm, the 2 patches attached: * are too small to be relevant * are the same * does not apply so... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 17:31:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 15:31:47 +0000 Subject: [Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books In-Reply-To: <bug-7560-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7560-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7560-70-oNQ9k5B1KU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact| |mtj at kohaaloha.com --- Comment #7 from Mason James <mtj at kohaaloha.com> --- > Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> patch looks good, passing QA? $ koha-qa.pl testing 1 commit(s) (applied to commit 0acebb8) * 0f3cfcd Bug 7560 - SIP Self Checkout Ignoring Fines Thresholds for Not Be C4/Overdues.pm C4/SIP/ILS/Patron.pm C4/SIP/ILS/Transaction/Renew.pm * C4/Overdues.pm OK * C4/SIP/ILS/Patron.pm OK * C4/SIP/ILS/Transaction/Renew.pm OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 17:32:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 15:32:47 +0000 Subject: [Koha-bugs] [Bug 8428] can't save contracts In-Reply-To: <bug-8428-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8428-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8428-70-Mxxj5h7w0d@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8428 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 Blocks| |8181 --- Comment #10 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 17:32:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 15:32:47 +0000 Subject: [Koha-bugs] [Bug 8181] Replace DynArch calendar widget with jQueryUI version In-Reply-To: <bug-8181-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8181-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8181-70-2oHXcpN4jJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8181 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8428 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 17:37:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 15:37:20 +0000 Subject: [Koha-bugs] [Bug 8765] Add series title to intranet search results In-Reply-To: <bug-8765-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8765-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8765-70-DBu0UKsM1z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8765 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com QA Contact| |mtj at kohaaloha.com --- Comment #4 from Mason James <mtj at kohaaloha.com> --- (In reply to comment #2) > Created attachment 12225 [details] > [SIGNED-OFF] Bug 8765 - Add series title to intranet search results > Signed-off-by: Owen Leonard <oleonard at myacpl.org> patch looks good, passing QA? $ koha-qa.pl testing 1 commit(s) (applied to commit 0acebb8) * d2ac32b Bug 8765 - Add series title to intranet search results koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt * koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 17:37:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 15:37:35 +0000 Subject: [Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off In-Reply-To: <bug-8462-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8462-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8462-70-LaBzW2lbIR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 --- Comment #6 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> --- (In reply to comment #5) > i'm not sure i'm happy with this fix. It means you will get results without > any items, right ? Right. I'm not against this feature. It is just that the way it works by now is very tricky for OPAC users, like explained Ruth Bavousett ; and causes several bugs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 17:39:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 15:39:31 +0000 Subject: [Koha-bugs] [Bug 8520] Authorities display incorrectly in staff results In-Reply-To: <bug-8520-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8520-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8520-70-2QpayCaTCy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8520 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 --- Comment #30 from Paul Poulain <paul.poulain at biblibre.com> --- follow-up "Bug 8520 - Authorities summary incorrect on posible duplicate notice (1.17 KB, patch) " pushed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 17:40:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 15:40:52 +0000 Subject: [Koha-bugs] [Bug 8275] xml parsing error when the webservice GetPatronInfo/show_loans is called In-Reply-To: <bug-8275-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8275-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8275-70-AZUnyOR3St@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8275 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com QA Contact| |mtj at kohaaloha.com --- Comment #3 from Mason James <mtj at kohaaloha.com> --- > Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> patch looks good, passing QA? $ koha-qa.pl testing 1 commit(s) (applied to commit 0acebb8) * 3414757 Bug 8275: xml parsing error when the webservice GetPatronInfo/sho C4/ILSDI/Services.pm * C4/ILSDI/Services.pm OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 17:45:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 15:45:06 +0000 Subject: [Koha-bugs] [Bug 7455] Authority subfields are cloned in the wrong field In-Reply-To: <bug-7455-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7455-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7455-70-NPkgP9LuQU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11908|1 |0 is obsolete| | --- Comment #27 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> --- Comment on attachment 11908 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11908 Bug 7455: Authority subfields are cloned in the wrong field Main patch is not obsolete. It is signed-off and passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 17:45:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 15:45:27 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-m2g1dvJgFY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12196|0 |1 is obsolete| | --- Comment #91 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 12243 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12243&action=edit [SIGNED-OFF] Bug 7067 - OPAC Borrower Self Registration Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 17:47:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 15:47:20 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-qWpgFU3jMG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12242|0 |1 is obsolete| | --- Comment #92 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 12244 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12244&action=edit [SIGNED-OFF] Bug 7067 - OPAC Borrower Self Registration Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 17:48:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 15:48:20 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-KowqpACT9u@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12244|0 |1 is obsolete| | Attachment #12244|[SIGNED-OFF] Bug 7067 - |Whoops, duplicate description|OPAC Borrower Self |attachment. |Registration | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 17:48:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 15:48:58 +0000 Subject: [Koha-bugs] [Bug 7455] Authority subfields are cloned in the wrong field In-Reply-To: <bug-7455-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7455-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7455-70-wGpSPWEo0p@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11909|0 |1 is obsolete| | --- Comment #28 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> --- Comment on attachment 11909 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11909 Bug 7455: Authority subfields are cloned in the wrong field (follow-up) Mason James, you forgot to put the existing follow-up patch on obsolete (u mixed with main patch I guess). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 17:49:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 15:49:53 +0000 Subject: [Koha-bugs] [Bug 7455] Authority subfields are cloned in the wrong field In-Reply-To: <bug-7455-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7455-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7455-70-rbTrmU0bCB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 17:50:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 15:50:32 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-ABK0QDCfGC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #93 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 12245 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12245&action=edit [SIGNED-OFF] Bug 7067 - OPAC Borrower Self Registration - Followup -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 17:50:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 15:50:43 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-7B8ok1ZF7c@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 18:01:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 16:01:41 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-UPy5aVgSJJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #53 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to comment #52) > QA comments: > To begin, I'm really sorry to fail QA this large patch, with a great > feature, but I think it's needed No problem, better a patch be failed 1000 times, than let bad code make it into master! > * I don't like at all the introduction of > +sub GetItemTypesFlat { > + my $dbh = C4::Context->dbh; > + my $query = "SELECT * FROM itemtypes ORDER BY description"; > + my $sth = $dbh->prepare($query); > + $sth->execute; > + > + return $sth->fetchall_arrayref({}); > +} > That's another way to access itemtype. We need consistency, not more and > more various way to access the same information > That would have been a wonderful time to introduce > Koha::Service::Itemtype.pm ! Can you find a way to avoid introducing this > function ? I've fixed this by merging both options into GetItemTypes. I would write something like Koha::Service::Itemtype, but I'm waiting for DBIX::Class for Koha. > * The introduction of Koha/CourseReserves.pm is wrong: > - it must follow the structure we've defined at the hackfest and updated > after some tests I made (see mail on koha-devel, june 25th, Re: [Koha-devel] > http://wiki.koha-community.org/wiki/Koha_Namespace_RFC, moving ahead > - it must be OOP, as everything that enters Koha:: > - parameters must be passed by hashes (this one is OK) > > I let you 2 options here : > * you rewrite CourseReserves.pm in Koha:: namespace to respect the rule > * you move it to C4/ as it's an 'old style' stuff > (I bet you'll follow the 2nd patch, that is *much* easier, but that would > have been a great occasion to start filling Koha:: :\ ) I have opted for the latter option. I'd love to make this module OOP, but it's already taken so long to develop! I think I would just end up breaking it ; ) > * mod_course.pl says: > +#script to modify reserves/requests > +#written 2/1/00 by chris at katipo.oc.nz > +#last update 27/1/2000 by chris at katipo.co.nz > +# Copyright 2000-2002 Katipo Communications > > are you sure this code is 12 years old ? ;-) Good catch! > * There are no foreign keys, we can have some (not sure this list is > complete): > - instructors.borrowernumbers => borrowers.borrowernumber > - instructors.course_id => courses.course_id > - course_items.itemnumber => items.itemnumber > - course_items.holdingbranch => branches.branchcode > - course_reserves.course_id => courses.course_id Will do! > QUESTIONS: > * what are the changes to > .../prog/en/modules/members/mancredit.tt | 2 +- > .../prog/en/modules/members/maninvoice.tt | 2 +- > .../prog/en/modules/members/memberentrygen.tt | 2 +- > done for ? Why is it in this patch ? Please look at comments 24 and 25. It was a request from Owen. > PS : if you decide to go to Koha::Service::Itemtype.pm, don't do it with > DBIx::Class, just with standard SQL. Introducing DBIx::Class is a huge > thing, that must be done separately I'd rather wait for DBIx::Class, than reinvent the wheel! I think the fix I've implemented is fine for now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 18:13:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 16:13:31 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-t14oi14EJ6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #54 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12246 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12246&action=edit Bug 8215 - Add Course Reserves - QA Followup 2 * Remove GetItemTypesFlat * Remove update copywrite info * Add foreign keys * psuedo_key typo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 18:13:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 16:13:58 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-ySIVPcyVWM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 18:14:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 16:14:38 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-wlKydXNa8h@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 18:15:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 16:15:48 +0000 Subject: [Koha-bugs] [Bug 8702] System preferences search does not allow accented letters In-Reply-To: <bug-8702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8702-70-VstfnFFBGB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8702 wajasu <matted-34813 at mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |matted-34813 at mypacks.net --- Comment #5 from wajasu <matted-34813 at mypacks.net> --- I tried to apply the patch. I got: Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/stopwords-admin-search.inc CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/stopwords-admin-search.inc I don't even see stopwords-admin-search.inc mentioned in your patch. So I am too confused to make any assumptions. See: http://paste.koha-community.org/173 Can you rebase and resubmit? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 18:31:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 16:31:04 +0000 Subject: [Koha-bugs] [Bug 5234] Remove unused CSS files In-Reply-To: <bug-5234-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5234-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5234-70-aqdVTXyqX5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5234 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 18:37:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 16:37:09 +0000 Subject: [Koha-bugs] [Bug 6037] Invalid markup, missing breadcrumbs on Keyword to MARC Mapping page In-Reply-To: <bug-6037-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6037-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6037-70-BicVk89yMy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6037 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3605|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 12247 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12247&action=edit Bug 6037 [Follow-up] Invalid markup, missing breadcrumbs on Keyword to MARC Mapping page Extra </div> returned. Killing it again. After applying the patch the validator should only warn of invalid "autocomplete" attribute. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 18:37:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 16:37:46 +0000 Subject: [Koha-bugs] [Bug 6037] Invalid markup, missing breadcrumbs on Keyword to MARC Mapping page In-Reply-To: <bug-6037-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6037-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6037-70-UOL946wED0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6037 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P5 - low Status|Pushed to Master |ASSIGNED Version|rel_3_4 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 18:37:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 16:37:54 +0000 Subject: [Koha-bugs] [Bug 6037] Invalid markup, missing breadcrumbs on Keyword to MARC Mapping page In-Reply-To: <bug-6037-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6037-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6037-70-MWjMim3AqY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6037 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 18:39:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 16:39:52 +0000 Subject: [Koha-bugs] [Bug 6766] Template variable scope errors in holds template In-Reply-To: <bug-6766-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6766-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6766-70-nkhkz9iyXH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6766 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P5 - low Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 18:39:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 16:39:52 +0000 Subject: [Koha-bugs] [Bug 5917] Switch Koha to use Template::Toolkit In-Reply-To: <bug-5917-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5917-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5917-70-XorjWgpOCW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5917 Bug 5917 depends on bug 6766, which changed state. Bug 6766 Summary: Template variable scope errors in holds template http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6766 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 18:41:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 16:41:53 +0000 Subject: [Koha-bugs] [Bug 6573] Library name entry field enforces unnecessary maxlength In-Reply-To: <bug-6573-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6573-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6573-70-SmC0CJdKVV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6573 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P5 - low Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 18:44:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 16:44:41 +0000 Subject: [Koha-bugs] [Bug 7024] Can't delete other library's messages to the patron with AllowAllMessageDeletion on In-Reply-To: <bug-7024-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7024-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7024-70-ZcMkTO6p12@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7024 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 18:58:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 16:58:30 +0000 Subject: [Koha-bugs] [Bug 8559] conflicting item statuses In-Reply-To: <bug-8559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8559-70-loABOCR0NU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8559 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 19:00:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 17:00:10 +0000 Subject: [Koha-bugs] [Bug 8447] can't save new records / indicator error In-Reply-To: <bug-8447-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8447-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8447-70-OTwqqngNbV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8447 --- Comment #25 from Pamela Naylor <pnaylor at cornish.edu> --- I was just able to save my 650 with a subfield of x. So, is everything fine now? Thanks, Pam -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 19:04:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 17:04:28 +0000 Subject: [Koha-bugs] [Bug 8447] can't save new records / indicator error In-Reply-To: <bug-8447-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8447-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8447-70-RqojSLJUUK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8447 --- Comment #26 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- (In reply to comment #25) > I was just able to save my 650 with a subfield of x. So, is everything fine > now? Thanks, You would have to ask your service provider. It is very unlikely that you are running master, as master is intended for development only and not production use. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 19:09:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 17:09:58 +0000 Subject: [Koha-bugs] [Bug 7401] Shelving Location facet instead of Branch facet when only 1 branch configured In-Reply-To: <bug-7401-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7401-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7401-70-ORKvtLsUoo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 --- Comment #30 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to comment #29) > Created attachment 12241 [details] > Shelving location facet showing "*" link > > Is it to be expected that one of the facets is "*"--representing items with > no shelving location I assume? Or is there a problem with my data? I don't > think narrowing a search to items without shelving location is useful to > patrons. Your first assumption is correct. I don't know if we should alter it however, as that is how all the different facets work. If there are items with no value for the given facet, a "*" shows up to represent the 'no value' option. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 19:17:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 17:17:11 +0000 Subject: [Koha-bugs] [Bug 8772] New: Uninitialized variable triggers error log entry in smart_rules.pl Message-ID: <bug-8772-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8772 Priority: P5 - low Change sponsored?: --- Bug ID: 8772 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: Uninitialized variable triggers error log entry in smart_rules.pl Severity: trivial Classification: Unclassified OS: All Reporter: mtompset at hotmail.com Hardware: All Status: NEW Version: unspecified Component: Circulation Product: Koha Test ---- 1) Login 2) Go to administration 3) Circulations and Fines 4) tail /var/log/koha/... There's now several uninitialized $op variables. 5) apply a patch that changes line 47 (where the my $op) is to have "|| q{}" 6) retest no errors. Sorry, it's late. No time for a patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 19:32:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 17:32:50 +0000 Subject: [Koha-bugs] [Bug 6151] IndependantBranches and HomeOrHoldingBranchReturn can prevent items from being checked in In-Reply-To: <bug-6151-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6151-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6151-70-KC1PEGp0yR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6151 --- Comment #20 from Kyle M Hall <kyle at bywatersolutions.com> --- Paul, this is a bug fix, rather than a feature. This patch is to correct a problem that exists in Koha, where using IndependantBranches can result in items not being returnable to a library, even when they should be. This is a problem with returning items, rather than transferring them. Kyle (In reply to comment #19) > Can't this feature be achieved already with branch transfer limits ? > I thought that, with this feature activated, one can do much precise return > rules than with just a syspref. > > Looking at the code, I realize I'm wrong: > C4/Circulation.pm, sub AddReturn says: > > if ($hbr ne $branch && C4::Context->preference("IndependantBranches") && > !(C4::Context->preference("canreservefromotherbranches"))){ > $messages->{'Wrongbranch'} = { > Wrongbranch => $branch, > Rightbranch => $hbr, > }; > $doreturn = 0; > # bailing out here - in this case, current desired behavior > # is to act as if no return ever happened at all. > # FIXME - even in an indy branches situation, there should > # still be an option for the library to accept the item > # and transfer it to its owning library. > return ( $doreturn, $messages, $issue, $borrower ); > > But shouldn't we use the branch_transfer_limit anyway (and not this new > syspref) > > (just throwing asking the question, not rejecting the patch) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 19:48:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 17:48:33 +0000 Subject: [Koha-bugs] [Bug 7401] Shelving Location facet instead of Branch facet when only 1 branch configured In-Reply-To: <bug-7401-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7401-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7401-70-R9vgi8DKaT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 --- Comment #31 from Owen Leonard <oleonard at myacpl.org> --- > If there are items > with no value for the given facet, a "*" shows up to represent the 'no > value' option. In what situation is this the case? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 19:54:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 17:54:17 +0000 Subject: [Koha-bugs] [Bug 5524] Can't delete list from second page of results In-Reply-To: <bug-5524-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5524-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5524-70-S4Nn10lVRF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5524 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 19:54:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 17:54:17 +0000 Subject: [Koha-bugs] [Bug 6792] Lists pagination menu disappears after list deletion In-Reply-To: <bug-6792-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6792-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6792-70-vFdK9wCpJT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6792 Bug 6792 depends on bug 5524, which changed state. Bug 5524 Summary: Can't delete list from second page of results http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5524 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 19:54:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 17:54:51 +0000 Subject: [Koha-bugs] [Bug 6608] Date-pickers broken on guided reports pages In-Reply-To: <bug-6608-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6608-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6608-70-ABvkokDbzq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6608 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 19:57:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 17:57:45 +0000 Subject: [Koha-bugs] [Bug 6884] Improve TinyMCE configuration on Koha News page In-Reply-To: <bug-6884-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6884-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6884-70-dTGW9MaZlR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6884 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 19:58:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 17:58:50 +0000 Subject: [Koha-bugs] [Bug 7401] Shelving Location facet instead of Branch facet when only 1 branch configured In-Reply-To: <bug-7401-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7401-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7401-70-JEzGbwQnQq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 --- Comment #32 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to comment #31) > > If there are items > > with no value for the given facet, a "*" shows up to represent the 'no > > value' option. > > In what situation is this the case? It happens for branches, as well. But those are the only two though. If a branch has no branchname, it get's a "*" instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 20:02:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 18:02:51 +0000 Subject: [Koha-bugs] [Bug 6712] Remove memberofinstitution markup from templates until it can be completed In-Reply-To: <bug-6712-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6712-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6712-70-HHZFHWWL4z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6712 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P5 - low Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 20:02:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 18:02:51 +0000 Subject: [Koha-bugs] [Bug 6697] Empty Organisation(s) field for organisational patrons In-Reply-To: <bug-6697-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6697-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6697-70-lVltcI0a9L@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6697 Bug 6697 depends on bug 6712, which changed state. Bug 6712 Summary: Remove memberofinstitution markup from templates until it can be completed http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6712 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 20:02:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 18:02:52 +0000 Subject: [Koha-bugs] [Bug 6711] 'No more renewals' message has empty pull down In-Reply-To: <bug-6711-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6711-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6711-70-1uRiGCv5xH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6711 Bug 6711 depends on bug 6712, which changed state. Bug 6712 Summary: Remove memberofinstitution markup from templates until it can be completed http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6712 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 20:05:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 18:05:00 +0000 Subject: [Koha-bugs] [Bug 6753] Markup corrections and improvements for label export window In-Reply-To: <bug-6753-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6753-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6753-70-HgrnaLScKR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6753 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 20:21:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 18:21:41 +0000 Subject: [Koha-bugs] [Bug 8773] New: Add per-instance koha-index-daemon in .deb setup Message-ID: <bug-8773-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773 Priority: P5 - low Change sponsored?: --- Bug ID: 8773 Assignee: gmcharlt at gmail.com Summary: Add per-instance koha-index-daemon in .deb setup Severity: enhancement Classification: Unclassified OS: All Reporter: tomascohen at gmail.com Hardware: All Status: NEW Version: master Component: Command-line Utilities Product: Koha In order to avoid the use of cronjobs to trigger the incremental indexing of records (does not scale on busy setups, cannot do sub-minute frecaquency indexing), we can use Koha::Contrib::Tamil's koha-index-daemon to do the job. This should be set automagically by the koha-common package. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 20:34:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 18:34:38 +0000 Subject: [Koha-bugs] [Bug 7401] Shelving Location facet instead of Branch facet when only 1 branch configured In-Reply-To: <bug-7401-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7401-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7401-70-Nu2PCuPU0p@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 --- Comment #33 from Owen Leonard <oleonard at myacpl.org> --- (In reply to comment #32) > It happens for branches, as well. But those are the only two though. If a > branch has no branchname, it get's a "*" instead. By no branchname, do you mean the item has not homebranch or holdingbranch? I can't reproduce that output. Even so, it seems like an awfully slim edge case. When would an item not have a branch name? Even in such a case, is it useful to the OPAC user to be able to refine their results to items which *don't* have a branch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 20:37:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 18:37:00 +0000 Subject: [Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup In-Reply-To: <bug-8773-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8773-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8773-70-VYyT0d8fJj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773 --- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 12248 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12248&action=edit Bug 8773 - Start per-instance koha-index-daemon in .deb setup This bug is the .deb version of 8519 [1]. It is motivated by the fact that using 1-minute (or more) frecquency cronjobs to do the incremental indexing of records does not scale for us, nor is accepted by our librarians. Using an indexing daemon avoids launching a new interpreter each time the cron triggers the indexing, and also allows sub-minute reindexing. Frecquency is hardcoded right now. A follow up could provide a way to set it for each instance. This patch relies on Koha::Contrib::Tamil's koha-index-daemon script [2], but could be easily adjusted to use another if we got a new one (SolR?). I havent got the time to setup my infrastructure to generate my own debs, and thus haven't got the oportunity to test this patch. If anyone with the skills helps me on setting that I could test them and fix possible issues. If there's something I could change to make this patches better just let me know. Regards To+ [1] http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8519 [2] The default cronjob that is set using the debian/koha-common.cron.d file is being disbaled by this patch to avoid collision. Sponsored-by: Universidad Nacional de C?rdoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 20:38:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 18:38:25 +0000 Subject: [Koha-bugs] [Bug 7319] Improve specificity of title and breadcrumbs on acquisitions Z39.50 search pages In-Reply-To: <bug-7319-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7319-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7319-70-WhEJOBrJwE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7319 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 20:38:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 18:38:57 +0000 Subject: [Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup In-Reply-To: <bug-8773-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8773-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8773-70-QzH471uWKu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 20:39:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 18:39:29 +0000 Subject: [Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup In-Reply-To: <bug-8773-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8773-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8773-70-7zHStrCckX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 20:41:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 18:41:12 +0000 Subject: [Koha-bugs] [Bug 6337] Variable scope errors in staff client cart print view In-Reply-To: <bug-6337-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6337-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6337-70-4SqWP8yYQf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6337 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 20:43:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 18:43:19 +0000 Subject: [Koha-bugs] [Bug 6980] Existing extended patron attributes are shown on patron screens even when ExtendedPatronAttributes is disabled In-Reply-To: <bug-6980-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6980-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6980-70-8BG1GVmv7D@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6980 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P5 - low Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 20:44:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 18:44:31 +0000 Subject: [Koha-bugs] [Bug 6622] Remove closing style tag from staff-global.css In-Reply-To: <bug-6622-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6622-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6622-70-3QFs9l328n@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6622 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P5 - low Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 20:44:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 18:44:50 +0000 Subject: [Koha-bugs] [Bug 8559] conflicting item statuses In-Reply-To: <bug-8559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8559-70-LinZvL0DgI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8559 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12249 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12249&action=edit Bug 8559 - conflicting item statuses If you check out a waiting hold to a different patron it gives the item conflicting statuses. It will both be checked out for one patron, and also waiting for a different patron. This patch solves the problem by forcing the librarian to cancel the hold if they inist on checking the item out to a different patron. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 20:45:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 18:45:13 +0000 Subject: [Koha-bugs] [Bug 7259] Show a count of items pending approval on staff client home and tools pages In-Reply-To: <bug-7259-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7259-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7259-70-soJmropqlH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7259 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P5 - low Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 20:45:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 18:45:55 +0000 Subject: [Koha-bugs] [Bug 7616] Remove unused template markup for css_libs, css_module, js_libs, etc. In-Reply-To: <bug-7616-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7616-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7616-70-lspIiB3SQ0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7616 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 20:46:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 18:46:17 +0000 Subject: [Koha-bugs] [Bug 8559] conflicting item statuses In-Reply-To: <bug-8559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8559-70-U1QyTHqiMj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8559 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12249|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12250 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12250&action=edit Bug 8559 - Conflicting item statuses - Force cancel waiting hold If you check out a waiting hold to a different patron it gives the item conflicting statuses. It will both be checked out for one patron, and also waiting for a different patron. This patch solves the problem by forcing the librarian to cancel the hold if they inist on checking the item out to a different patron. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 20:46:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 18:46:28 +0000 Subject: [Koha-bugs] [Bug 8559] conflicting item statuses In-Reply-To: <bug-8559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8559-70-1xd08PoVgm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8559 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 20:47:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 18:47:11 +0000 Subject: [Koha-bugs] [Bug 7227] "Delete all items" action should redirect to the detail view, not the items view In-Reply-To: <bug-7227-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7227-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7227-70-hZtXBZZXzE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7227 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 20:53:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 18:53:05 +0000 Subject: [Koha-bugs] [Bug 6689] Improve styling of table pager In-Reply-To: <bug-6689-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6689-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6689-70-7RWHnuAEUS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6689 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5753|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 12251 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12251&action=edit Bug 6689 [Follow-up] Improve styling of table pager Small correction to add non-vendor-prefixed border radius declaration to make style consistent on newer browsers. To test, view a page with a sorted table and pager controls, like members/readingrec.pl. The pager controls "box" should show rounded corners in Firefox 15+ -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 20:53:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 18:53:26 +0000 Subject: [Koha-bugs] [Bug 6689] Improve styling of table pager In-Reply-To: <bug-6689-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6689-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6689-70-MqCSZC3YYT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6689 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P5 - low Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 20:53:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 18:53:34 +0000 Subject: [Koha-bugs] [Bug 6689] Improve styling of table pager In-Reply-To: <bug-6689-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6689-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6689-70-sZrH0RV7pp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6689 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 20:59:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 18:59:42 +0000 Subject: [Koha-bugs] [Bug 8288] showmarc.tt should not include full doc-head-close.inc In-Reply-To: <bug-8288-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8288-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8288-70-xbaWPtqWFI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8288 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 21:00:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 19:00:36 +0000 Subject: [Koha-bugs] [Bug 6375] Markup and style corrections for overdue report In-Reply-To: <bug-6375-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6375-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6375-70-4tUmzOgwHN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6375 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 21:02:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 19:02:07 +0000 Subject: [Koha-bugs] [Bug 7225] "Delete all items" should be greyed out when a title has no items In-Reply-To: <bug-7225-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7225-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7225-70-J8qGkFfmDM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7225 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P5 - low Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 21:04:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 19:04:17 +0000 Subject: [Koha-bugs] [Bug 8559] conflicting item statuses In-Reply-To: <bug-8559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8559-70-bldut2B0zG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8559 --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12252 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12252&action=edit Bug 8559 - Conflicting item statuses - Make issuing a waiting item impossible. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 21:06:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 19:06:39 +0000 Subject: [Koha-bugs] [Bug 8559] conflicting item statuses In-Reply-To: <bug-8559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8559-70-0F6IRSkEPs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8559 --- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> --- Note, these are two *alternative* patches to solve this problem. The first one solves it be automatically canceling any waiting reserves when force issuing and item. The latter patch simply disallows issuing the item. I'm personally a fan of "Make issuing a waiting item impossible". I imagine patrons will be upset if they find out an item that should have been waiting for them is not. If they need to force the issue, the librarian can modify the waiting hold first, without deleting it completely. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 21:39:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 19:39:05 +0000 Subject: [Koha-bugs] [Bug 5725] Batch modifications for Biblios In-Reply-To: <bug-5725-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5725-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5725-70-G02nZlq3ly@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 Cab Vinton <spl at metrocast.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |spl at metrocast.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 21:39:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 19:39:54 +0000 Subject: [Koha-bugs] [Bug 8239] Z39.50 Search/Import doesn't work with unicode characters from a specific server In-Reply-To: <bug-8239-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8239-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8239-70-RBKAyjaw88@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8239 Cab Vinton <spl at metrocast.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |spl at metrocast.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 21:40:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 19:40:18 +0000 Subject: [Koha-bugs] [Bug 7401] Shelving Location facet instead of Branch facet when only 1 branch configured In-Reply-To: <bug-7401-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7401-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7401-70-VbJLgEDqL7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 --- Comment #34 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to comment #33) > (In reply to comment #32) > > It happens for branches, as well. But those are the only two though. If a > > branch has no branchname, it get's a "*" instead. > > By no branchname, do you mean the item has not homebranch or holdingbranch? > I can't reproduce that output. > > Even so, it seems like an awfully slim edge case. When would an item not > have a branch name? Even in such a case, is it useful to the OPAC user to be > able to refine their results to items which *don't* have a branch? Actually, it appears to mean the branch exists, but doesn't have a name. I agree, it's not very useful. It's code Ian wrote, so I'm not sure if he had a particular reason for doing it that way. I'll post a new patch that should fix this issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 21:40:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 19:40:36 +0000 Subject: [Koha-bugs] [Bug 7401] Shelving Location facet instead of Branch facet when only 1 branch configured In-Reply-To: <bug-7401-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7401-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7401-70-5OCliGv2TQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10877|0 |1 is obsolete| | --- Comment #35 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12253 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12253&action=edit Bug 7401 - Shelving Location facet This patch enables the shelving location facet as an alternative to the branches fact in two situations: A) SingleBranchMode is enabled B) There is only one branch in the branches table Test Plan: 1) Catalog multiple items with different shelving locations. 2) Test enable by enabling SingleBranchMode 3) Test enable by deleting all but one branch Based on initial patch by Ian Walls. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 21:51:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 19:51:59 +0000 Subject: [Koha-bugs] [Bug 8559] conflicting item statuses In-Reply-To: <bug-8559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8559-70-Y07HWKql7j@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8559 --- Comment #5 from Owen Leonard <oleonard at myacpl.org> --- There are two situations I can think of off the top of my head when a librarian would want to check out a waiting item to someone other than the person it is on hold for: 1. Someone else is picking up the item on behalf of that person. We get this all the time with husbands picking up books for their wives. If we want to check the item out to the person who is showing us their card, we have to override the hold and check it out to them. In this case we would want to choose to remove the hold upon checkout. 2. A book which had been made waiting for someone accidentally was put on the shelf and someone brings it up to check out. In this case we would check out the item (because it's our mistake, not the patron's) and keep the hold. In this case the proper thing would be to remove the waiting status but keep the hold at the top of the list. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 22:04:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 20:04:04 +0000 Subject: [Koha-bugs] [Bug 7401] Shelving Location facet instead of Branch facet when only 1 branch configured In-Reply-To: <bug-7401-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7401-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7401-70-HQL03t9LVT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12253|0 |1 is obsolete| | --- Comment #36 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 12254 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12254&action=edit [SIGNED-OFF] Bug 7401 - Shelving Location facet This patch enables the shelving location facet as an alternative to the branches fact in two situations: A) SingleBranchMode is enabled B) There is only one branch in the branches table Test Plan: 1) Catalog multiple items with different shelving locations. 2) Test enable by enabling SingleBranchMode 3) Test enable by deleting all but one branch Based on initial patch by Ian Walls. Signed-off-by: Owen Leonard <oleonard at myacpl.org> Tested cases 2) and 3) successfully in OPAC and staff client -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 22:04:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 20:04:21 +0000 Subject: [Koha-bugs] [Bug 7401] Shelving Location facet instead of Branch facet when only 1 branch configured In-Reply-To: <bug-7401-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7401-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7401-70-mbJxyJinms@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 22:37:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 20:37:39 +0000 Subject: [Koha-bugs] [Bug 8758] Code seems useless in circ/returns.pl In-Reply-To: <bug-8758-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8758-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8758-70-9RV20xI2vb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8758 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12131|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 12255 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12255&action=edit [SINGED-OFF] Bug 8758: Remove useless code in circ/returns.pl Signed-off-by: Owen Leonard <oleonard at myacpl.org> Before applying the patch I removed the [% IF %] from around the markup which is removed by this patch. A table of title and patron information appeared which I don't remember ever seeing before. This tells me it's really unused. After applying the patch I performed some check-ins on both checked out items and items which were on hold. All operations completed normally. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 22:37:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 20:37:59 +0000 Subject: [Koha-bugs] [Bug 8758] Code seems useless in circ/returns.pl In-Reply-To: <bug-8758-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8758-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8758-70-eKCpSRNYTb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8758 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 23:05:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 21:05:58 +0000 Subject: [Koha-bugs] [Bug 8739] Partial Fine Payments Saving Amount Paid Incorrectly In-Reply-To: <bug-8739-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8739-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8739-70-1odx0IZz4u@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8739 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12057|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 12256 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12256&action=edit [SIGNED-OFF] Bug 8739 - Partial Fine Payments Saving Amount Paid Incorrectly Signed-off-by: Owen Leonard <oleonard at myacpl.org> Confirmed using test plan that the display is corrected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 14 23:06:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 14 Sep 2012 21:06:13 +0000 Subject: [Koha-bugs] [Bug 8739] Partial Fine Payments Saving Amount Paid Incorrectly In-Reply-To: <bug-8739-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8739-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8739-70-hk43lN3c3U@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8739 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 15 07:07:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Sep 2012 05:07:50 +0000 Subject: [Koha-bugs] [Bug 8378] <fine> syntax not working on overdues anymore In-Reply-To: <bug-8378-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8378-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8378-70-hZuNQfMTgH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8378 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 --- Comment #11 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 15 07:19:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Sep 2012 05:19:42 +0000 Subject: [Koha-bugs] [Bug 8764] Template change "Authors" to "Additional authors" in OPAC In-Reply-To: <bug-8764-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8764-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8764-70-11DyDra3AZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8764 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 --- Comment #4 from Paul Poulain <paul.poulain at biblibre.com> --- This patch is probably "wrong" for UNIMARC, but patch pushed. Explanation: in UNIMARC, authors are stored in 7xx The 700 field contains the main authors, 701 and 702 additional physical/personal authors. (710, 711, 712 being for collective authors) however, the 200$f field also contain authors, in non authoritative form. That's why the opac-detail.pl displays 200$f as authors, and all 7xx authors in the MARCAUTHOR array (in authority form) So it's wrong to say "additional authors" however, for libraries that think it's a problem, they can always activate XSLT. So patch pushed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 15 07:21:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Sep 2012 05:21:37 +0000 Subject: [Koha-bugs] [Bug 8768] t/ItemType.t fails because DBD::Mock has no empty result set In-Reply-To: <bug-8768-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8768-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8768-70-NMWGEeYWgn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8768 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|unspecified |rel_3_10 --- Comment #5 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 15 07:37:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Sep 2012 05:37:29 +0000 Subject: [Koha-bugs] [Bug 7671] add a real primary key "accountlinesid" in accountlines In-Reply-To: <bug-7671-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7671-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7671-70-4yy9HVESII@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7671 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 Severity|major |enhancement --- Comment #32 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master I've marked this patch as an ENH. I think it's not wise to push it to 3.8, because there can be side effect that could be hard to spot. So proposing to delay this to 3.10 only. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 15 07:39:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Sep 2012 05:39:14 +0000 Subject: [Koha-bugs] [Bug 8617] Problem with display of comments waiting for moderation in OPAC In-Reply-To: <bug-8617-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8617-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8617-70-zpXobFGdyd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8617 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 --- Comment #6 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 15 07:44:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Sep 2012 05:44:45 +0000 Subject: [Koha-bugs] [Bug 8190] Koha does not have a logging module In-Reply-To: <bug-8190-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8190-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8190-70-bAyJolMLUD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10996|0 |1 is obsolete| | --- Comment #7 from Mason James <mtj at kohaaloha.com> --- Created attachment 12257 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12257&action=edit Bug 8190: C4::Logger, Logging module use Koha::Utils::Logger qw/$log/; $log = Koha::Utils::Logger->new; $log->debug("This is a debug message"); $log->info("This is an information"); $log->error("This is an error !"); The Logger constructor can take an hash reference with "file" and "level" to define a filepath or a log level. For a log level >= warning, a call stack is printed. Prerequisite: - set an environment variable LOG in your virtual host: SetEnv LOG /home/koha/var/log/opac.log - set a write flag for www-data on this file Please have a look at t/Logger.t for more details. Signed-off-by: Mason James <mtj at kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 15 07:48:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Sep 2012 05:48:48 +0000 Subject: [Koha-bugs] [Bug 8190] Koha does not have a logging module In-Reply-To: <bug-8190-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8190-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8190-70-ihGY9dPNsi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mtj at kohaaloha.com --- Comment #8 from Mason James <mtj at kohaaloha.com> --- > Signed-off-by: Mason James <mtj at kohaaloha.com> 1/installed loglite package $ sudo apt-get install liblog-loglite-perl 2/ ran test successfully $ LOG="/tmp/t1.log" perl t/Logger.t 1..15 ok 1 - use Koha::Utils::Logger; ok 2 - Check LogLevel syspref ok 3 - Check $log is undef ok 4 - Check $log is not undef ok 5 - check error string with level 3 ok 6 - check normal string with level 3 ok 7 - check error string with level 5 ok 8 - check normal string with level 5 ok 9 - check calledby string with level 5 ok 10 - check WARN string with dump ok 11 - check VAR1 string with dump ok 12 - check values aaaaa string with dump ok 13 - check log level return ok 14 - check error string with level 3 ok 15 - check normal string with level 3 Jonathon. looks good, signing-off... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 15 07:51:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Sep 2012 05:51:59 +0000 Subject: [Koha-bugs] [Bug 8190] Koha does not have a logging module In-Reply-To: <bug-8190-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8190-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8190-70-iivCs77jhc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #9 from Mason James <mtj at kohaaloha.com> --- > Jonathan. looks good, signing-off... but, perlcritic errors... Koha/Utils/Logger.pm FAIL Loop iterator is not lexical at line 168, column 5. See page 108 of PBP. t/Logger.t FAIL Two-argument "open" used at line 56, column 1. See page 207 of PBP. Bareword file handle opened at line 80, column 5. See pages 202,204 of PBP. Bareword file handle opened at line 69, column 5. See pages 202,204 of PBP. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 15 07:52:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Sep 2012 05:52:33 +0000 Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in OPAC and staff client In-Reply-To: <bug-8377-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8377-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8377-70-eETiFVVzaf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |paul.poulain at biblibre.com --- Comment #19 from Paul Poulain <paul.poulain at biblibre.com> --- QA comment: This patch has one problem that must be solved before being pushed : the Koha:: namespace must contain OO code only, the Koha/HTML5Media.pm is not OO I also think that this file (an OO version) should be in a subdirectory, but I've nothing to propose for now. I've checked that the HTML5Media.pm passes perlcritic 2 options to earn passed QA : * rewritte HTML5Media.pm for an OO version * move it to C4/ failing QA for now. note I haven't tested it, and it also not apply cleanly anymore: CONFLICT (content): Merge conflict in opac/opac-detail.pl Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/enhanced_content.pref Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql Auto-merging catalogue/detail.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 15 08:04:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Sep 2012 06:04:24 +0000 Subject: [Koha-bugs] [Bug 7991] Display in a holding summary tab informations about serial record In-Reply-To: <bug-7991-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7991-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7991-70-7c89y5nOC1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7991 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain at biblibre.com --- Comment #6 from Paul Poulain <paul.poulain at biblibre.com> --- QA comment: tiny patch, passes perlcritic & koha-qa.pl MARC21 comment(s): * Jared, what do you mean by: > As this view has never worked with MARC21, I am comfortable signing > off on the fact that the patch does not in any way impact the MARC21 > display. * Looking at the patch, I see something is added, I see: + $row_data{itemcallnumber} = $marcflavour eq 'UNIMARC' + ? $lc_field->subfield('a') # 930$a + : $lc_field->subfield('h') # 852$h + if ($sc_field->subfield('5') eq $lc_field->subfield('5')); In MARC21, there is no $5 field, so I think this code does nothing for MARC21 As Jared says this tab does not work at all, I'm marking passed QA, but I'd like to make this tab working for MARC21 too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 15 08:05:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Sep 2012 06:05:16 +0000 Subject: [Koha-bugs] [Bug 7991] Display in a holding summary tab informations about serial record In-Reply-To: <bug-7991-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7991-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7991-70-RutFAEvopG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7991 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|rel_3_8 |rel_3_10 --- Comment #7 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master I consider this is an enhancement, so for 3.10 only. It's a tiny patch that can be reverted if it appears there's a real problem for MARC21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 15 08:12:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Sep 2012 06:12:19 +0000 Subject: [Koha-bugs] [Bug 8190] Koha does not have a logging module In-Reply-To: <bug-8190-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8190-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8190-70-KV5ER0Ulwh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #10 from Mason James <mtj at kohaaloha.com> --- > Prerequisite: > - set an environment variable LOG in your virtual host: > SetEnv LOG /home/koha/var/log/opac.log > - set a write flag for www-data on this file hmm, just a little suggestion, too... change SetEnv from LOG, to KOHA_LOG? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 15 08:29:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Sep 2012 06:29:41 +0000 Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies In-Reply-To: <bug-7688-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7688-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7688-70-mAYWMfzF9O@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #40 from Paul Poulain <paul.poulain at biblibre.com> --- QA comment * the database changes says: ADD CONSTRAINT subscription_ibfk_1 FOREIGN KEY (periodicity) REFERENCES subscription_frequencies (id) ON DELETE SET NULL ON UPDATE CASCADE, ADD CONSTRAINT subscription_ibfk_2 FOREIGN KEY (numberpattern) REFERENCES subscription_numberpatterns (id) ON DELETE SET NULL ON UPDATE CASCADE ON DELETE SET NULL = I would have preferred ON DELETE RESTRICT, but SET NULL is OK. * koha-qa.pl show many QA (most minor: :utf8 mistakes) problems: - C4/Serials/Frequency.pm FAIL critic FAIL - C4/Serials/Numberpattern.pm FAIL critic FAIL - serials/create-numberpattern.pl FAIL critic FAIL - serials/subscription-frequency.pl FAIL critic FAIL - serials/subscription-numberpattern.pl FAIL critic FAIL QUESTION : why in the FR-fr samples do you have english strings (and not french) : diff --git a/installer/data/mysql/fr-FR/2-Optionel/sample_frequencies.sql b/installer/data/mysql/fr-FR/2-Optionel/sample_frequencies.sql shouldn't : + ('2/day', 'day', 1, 2, 1), + ('1/day', 'day', 1, 1, 2), + ('3/week', 'week', 1, 3, 3), + ('1/week', 'week', 1, 1, 4), + ('1/2 weeks', 'week', 2, 1, 5), + ('1/3 weeks', 'week', 3, 1, 6), be + ('2/jour', 'day', 1, 2, 1), + ('1/jour', 'day', 1, 1, 2), + ('3/semaine', 'week', 1, 3, 3), + ('1/semaine', 'week', 1, 1, 4), + ('1/2 semaines', 'week', 2, 1, 5), + ('1/3 semaines', 'week', 3, 1, 6), (if yes, please confirm -so i can ask koha-translate mailing list for SP, IT, NO,... translations, and provide a french version) marking failed QA for now, I have no other QA comment (spent almost 1H checking the code). (I haven't tested this patch yet, will do once it passes QA) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 15 08:30:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Sep 2012 06:30:31 +0000 Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies In-Reply-To: <bug-7688-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7688-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7688-70-wrsqeG5bUb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #41 from Paul Poulain <paul.poulain at biblibre.com> --- oups wanted to FAIL qa, not pass ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 15 14:27:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Sep 2012 12:27:39 +0000 Subject: [Koha-bugs] [Bug 2060] Ability to import Authorities from Staff Client In-Reply-To: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2060-70-aboCy38Mec@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2060 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 15 14:28:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Sep 2012 12:28:05 +0000 Subject: [Koha-bugs] [Bug 2060] Ability to import Authorities from Staff Client In-Reply-To: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2060-70-vU3an6NjEq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2060 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #38 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Returning to Passed QA so that Paul will see the updated follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 15 21:16:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Sep 2012 19:16:10 +0000 Subject: [Koha-bugs] [Bug 8017] Remove unnecessary processing on return of GetAllIssues In-Reply-To: <bug-8017-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8017-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8017-70-vUtOmMt1d4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8017 --- Comment #18 from Chris Cormack <chris at bigballofwax.co.nz> --- Patch contains no string changes, makes some template changes which I think are safe, pushed to 3.8.x, will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 15 21:25:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Sep 2012 19:25:32 +0000 Subject: [Koha-bugs] [Bug 8730] browse overlaying powered by In-Reply-To: <bug-8730-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8730-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8730-70-PhowpqYwTv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8730 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #8 from Chris Cormack <chris at bigballofwax.co.nz> --- No string changes, pushed to 3.8.x, will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 15 21:25:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Sep 2012 19:25:47 +0000 Subject: [Koha-bugs] [Bug 8017] Remove unnecessary processing on return of GetAllIssues In-Reply-To: <bug-8017-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8017-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8017-70-JdyQbOO53u@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8017 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 15 21:27:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Sep 2012 19:27:21 +0000 Subject: [Koha-bugs] [Bug 8721] typo in AllowItemsOnHoldCheckout In-Reply-To: <bug-8721-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8721-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8721-70-OcngsSQCnl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8721 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris at bigballofwax.co.nz> --- String change, held for 3.8.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 15 21:30:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Sep 2012 19:30:23 +0000 Subject: [Koha-bugs] [Bug 8719] Private lists always sorted by title (even when author or date is selected) In-Reply-To: <bug-8719-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8719-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8719-70-JeCQwDgWDQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8719 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris at bigballofwax.co.nz> --- No string changes, pushed to 3.8.x will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 15 21:43:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Sep 2012 19:43:51 +0000 Subject: [Koha-bugs] [Bug 8071] link beween bib and authorities with the authid In-Reply-To: <bug-8071-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8071-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8071-70-JV1CSG9GvM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8071 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz Version|rel_3_10 |rel_3_8 --- Comment #10 from Chris Cormack <chris at bigballofwax.co.nz> --- Pushed to 3.8.x will be in 3.8.5. Template change but no string changes. But being a blocker I would push anyway. (Blockers trump freezes at least in my book) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 15 21:54:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Sep 2012 19:54:09 +0000 Subject: [Koha-bugs] [Bug 8656] Koha::Calendar not loading both sets of special dates In-Reply-To: <bug-8656-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8656-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8656-70-Thv10rpnQC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8656 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #5 from Chris Cormack <chris at bigballofwax.co.nz> --- Pushed to 3.8.x, will be 3.8.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 15 22:00:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Sep 2012 20:00:05 +0000 Subject: [Koha-bugs] [Bug 8418] Koha::Calendar is_holiday ignores all user data In-Reply-To: <bug-8418-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8418-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8418-70-WybRni6kkU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8418 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #28 from Chris Cormack <chris at bigballofwax.co.nz> --- Pushed to 3.8.x will be in 3.8.5 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 15 22:20:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 15 Sep 2012 20:20:46 +0000 Subject: [Koha-bugs] [Bug 8447] can't save new records / indicator error In-Reply-To: <bug-8447-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8447-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8447-70-EutW4ejbHG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8447 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #27 from Chris Cormack <chris at bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 16 02:52:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 00:52:11 +0000 Subject: [Koha-bugs] [Bug 7440] Vestiges of NoZebra should be removed In-Reply-To: <bug-7440-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7440-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7440-70-39V8VqJTZl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7440 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8724 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 16 02:52:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 00:52:12 +0000 Subject: [Koha-bugs] [Bug 8724] Upgrade from NoZebra installs is broken In-Reply-To: <bug-8724-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8724-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8724-70-N54zr4V0PQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8724 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7440 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 16 09:52:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 07:52:55 +0000 Subject: [Koha-bugs] [Bug 7409] Missing dependencies for Debian package In-Reply-To: <bug-7409-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7409-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7409-70-Wo76ciGMYB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7409 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7601|0 |1 is obsolete| | --- Comment #9 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 12258 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12258&action=edit Bug 7409 : Missing dependency on libtest-mockmodule-perl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 16 09:53:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 07:53:37 +0000 Subject: [Koha-bugs] [Bug 7409] Missing dependencies for Debian package In-Reply-To: <bug-7409-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7409-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7409-70-eDkqDTCuT7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7409 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |ASSIGNED CC| |chris at bigballofwax.co.nz Version|rel_3_6 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 16 09:53:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 07:53:47 +0000 Subject: [Koha-bugs] [Bug 7409] Missing dependencies for Debian package In-Reply-To: <bug-7409-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7409-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7409-70-G17lF7GFgN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7409 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 16 10:01:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 08:01:03 +0000 Subject: [Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC In-Reply-To: <bug-6976-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6976-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6976-70-3m8JFNUlR1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #28 from Chris Cormack <chris at bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 16 10:20:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 08:20:52 +0000 Subject: [Koha-bugs] [Bug 8002] Can't add patron attribute type in newer installation In-Reply-To: <bug-8002-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8002-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8002-70-EtvKUUGtfL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8002 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #26 from Chris Cormack <chris at bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 16 10:27:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 08:27:11 +0000 Subject: [Koha-bugs] [Bug 8743] ZOOM error when merging authority change to biblios In-Reply-To: <bug-8743-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8743-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8743-70-x52CfsEp2X@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8743 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #9 from Chris Cormack <chris at bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 16 10:33:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 08:33:50 +0000 Subject: [Koha-bugs] [Bug 8420] tool statisticfines.pl(bz 6858) and hourly loan(bz5549) In-Reply-To: <bug-8420-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8420-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8420-70-M2oSJ54Dq8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8420 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris at bigballofwax.co.nz> --- Doesn't apply cleanly to 3.8.x, please supply a patch for it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 16 10:37:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 08:37:16 +0000 Subject: [Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC In-Reply-To: <bug-4173-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4173-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4173-70-1KBP4J4uM1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173 --- Comment #23 from Chris Cormack <chris at bigballofwax.co.nz> --- String changes, held until after the string freeze -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 16 10:41:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 08:41:34 +0000 Subject: [Koha-bugs] [Bug 8653] With DOM indexing turned on subject authority links are not indexed In-Reply-To: <bug-8653-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8653-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8653-70-Def1qp71WK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8653 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Chris Cormack <chris at bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 16 10:44:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 08:44:25 +0000 Subject: [Koha-bugs] [Bug 8428] can't save contracts In-Reply-To: <bug-8428-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8428-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8428-70-ZGolTUWm8u@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8428 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #11 from Chris Cormack <chris at bigballofwax.co.nz> --- Doesn't apply on 3.8.x please reformat if needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 16 10:46:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 08:46:07 +0000 Subject: [Koha-bugs] [Bug 8520] Authorities display incorrectly in staff results In-Reply-To: <bug-8520-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8520-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8520-70-Tgf4Nh5NRo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8520 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #31 from Chris Cormack <chris at bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 16 11:00:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 09:00:00 +0000 Subject: [Koha-bugs] [Bug 8378] <fine> syntax not working on overdues anymore In-Reply-To: <bug-8378-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8378-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8378-70-NfT0Nd5pSm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8378 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #12 from Chris Cormack <chris at bigballofwax.co.nz> --- Doesn't apply cleanly to 3.8.x, please send a patch that applies on 3.8.x -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 16 11:55:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 09:55:36 +0000 Subject: [Koha-bugs] [Bug 7409] Missing dependencies for Debian package In-Reply-To: <bug-7409-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7409-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7409-70-fMwYMUUdiw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7409 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12258|0 |1 is obsolete| | --- Comment #10 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 12259 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12259&action=edit Bug 7409 : Adding missing dependency -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 16 12:17:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 10:17:12 +0000 Subject: [Koha-bugs] [Bug 8336] SIP Server does not process renewal transaction correctly In-Reply-To: <bug-8336-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8336-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8336-70-bjBsa9b4Mm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8336 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12035|0 |1 is obsolete| | --- Comment #5 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 12260 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12260&action=edit Bug 8336 Support Sip Renewal Transaction Renewals were being rejected for incorrect reasons Checking was being done against the wrong object Add more informative messages on failure Correctly set due_date for renewal response Avoid crashing the SIPServer because it handles RenewAll incorrectly Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 16 12:17:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 10:17:37 +0000 Subject: [Koha-bugs] [Bug 8336] SIP Server does not process renewal transaction correctly In-Reply-To: <bug-8336-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8336-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8336-70-KQqef9rz8H@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8336 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris at bigballofwax.co.nz Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 16 13:24:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 11:24:24 +0000 Subject: [Koha-bugs] [Bug 7913] Automatically receive serial issues In-Reply-To: <bug-7913-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7913-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7913-70-vrFe3noTbF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7913 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com --- Comment #9 from Mason James <mtj at kohaaloha.com> --- > Signed-off-by: Delaye Stephane <stephane.delaye at biblibre.com> patch looks good, passing QA? $ koha-qa.pl testing 1 commit(s) (applied to commit ce03893) * 551e5b2 Receiving serials in a loop koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt serials/serials-collection.pl * serials/serials-collection.pl OK * koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 16 14:13:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 12:13:44 +0000 Subject: [Koha-bugs] [Bug 5339] Parcel closing in acq In-Reply-To: <bug-5339-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5339-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5339-70-KB9bXFBGpJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #76 from Mason James <mtj at kohaaloha.com> --- (In reply to comment #75) > Kyle, > The patch is waiting for 9 months then I think it can pass qa without UT. > But a followup will be required. Jonathan, hmmm, i an OK with a follow-up patch for unit-test Julian, sorry, i had some small merge conflicts against master (ce03893) :/ if you rebase against master again, i will QA this the same day # both modified: C4/Acquisition.pm # both modified: acqui/finishreceive.pl # both modified: acqui/parcel.pl changing status to 'patch does not apply' (sorry) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 16 14:28:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 12:28:13 +0000 Subject: [Koha-bugs] [Bug 8210] Headings in OPAC bib details should link to authority record In-Reply-To: <bug-8210-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8210-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8210-70-Qv9yIMr2Ff@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8210 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |mtj at kohaaloha.com --- Comment #8 from Mason James <mtj at kohaaloha.com> --- > Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com> > Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> Jared, i get some conflicts applying both patches to master (ce03893) can you rebase, then ping me for QA? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 16 14:31:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 12:31:10 +0000 Subject: [Koha-bugs] [Bug 8627] Fixing pipe values in MARC21 controlfield 008 of authorities In-Reply-To: <bug-8627-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8627-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8627-70-EhPd5NYKHE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8627 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com QA Contact| |mtj at kohaaloha.com --- Comment #6 from Mason James <mtj at kohaaloha.com> --- > Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> patch looks good, passing QA? $ koha-qa.pl testing 1 commit(s) (applied to commit a64c811) * 6dee396 8627 Followup for removing tabs cataloguing/value_builder/marc21_field_008_authorities.pl * cataloguing/value_builder/marc21_field_008_authorities.pl OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 16 14:46:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 12:46:01 +0000 Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix In-Reply-To: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5786-70-Hk6j71pAVF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com --- Comment #56 from Mason James <mtj at kohaaloha.com> --- > Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com> > Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> patch looks good, passing QA - well done everyone :) $ koha-qa.pl testing 1 commit(s) (applied to commit bf79b88) * d24fd5c bug_5786, bug_5787, bug_5788: Holds rewrite C4/Auth.pm C4/ILSDI/Services.pm C4/Items.pm C4/Reserves.pm C4/VirtualShelves/Page.pm admin/smart-rules.pl admin/systempreferences.pl installer/data/mysql/it-IT/necessari/system_preferences.sql installer/data/mysql/kohastructure.sql installer/data/mysql/sysprefs.sql installer/data/mysql/updatedatabase.pl installer/html-template-to-template-toolkit.pl koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt koha-tmpl/opac-tmpl/prog/en/includes/opac-detail-sidebar.inc koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tt koha-tmpl/opac-tmpl/prog/en/modules/opac-results-grouped.tt koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt koha-tmpl/opac-tmpl/prog/en/modules/opac-shelves.tt opac/opac-ISBDdetail.pl opac/opac-MARCdetail.pl opac/opac-detail.pl opac/opac-reserve.pl opac/opac-search.pl reserve/request.pl * C4/Auth.pm OK * C4/ILSDI/Services.pm OK * C4/Items.pm OK * C4/Reserves.pm OK * C4/VirtualShelves/Page.pm OK * admin/smart-rules.pl OK * admin/systempreferences.pl OK * installer/data/mysql/updatedatabase.pl OK * installer/html-template-to-template-toolkit.pl OK * opac/opac-ISBDdetail.pl OK * opac/opac-MARCdetail.pl OK * opac/opac-detail.pl OK * opac/opac-reserve.pl OK * opac/opac-search.pl OK * reserve/request.pl OK * koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt OK * koha-tmpl/opac-tmpl/prog/en/includes/opac-detail-sidebar.inc OK * koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tt OK * koha-tmpl/opac-tmpl/prog/en/modules/opac-results-grouped.tt OK * koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt OK * koha-tmpl/opac-tmpl/prog/en/modules/opac-shelves.tt OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 16 14:52:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 12:52:32 +0000 Subject: [Koha-bugs] [Bug 8757] Longer size text for authorised values "lib" In-Reply-To: <bug-8757-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8757-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8757-70-Sukad7p1OV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8757 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com QA Contact| |mtj at kohaaloha.com --- Comment #3 from Mason James <mtj at kohaaloha.com> --- > Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> patch looks good, passing QA? $ koha-qa.pl testing 1 commit(s) (applied to commit bf79b88) * 292d4c7 Bug 8757: longer descriptions for authorised values installer/data/mysql/kohastructure.sql installer/data/mysql/updatedatabase.pl koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt * installer/data/mysql/updatedatabase.pl OK * koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 16 15:02:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 13:02:10 +0000 Subject: [Koha-bugs] [Bug 6945] Add a link to show a MARC preview in the normal view In-Reply-To: <bug-6945-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6945-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6945-70-kwE7COMXWO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6945 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com QA Contact|koha-bugs at lists.koha-commun |mtj at kohaaloha.com |ity.org | --- Comment #22 from Mason James <mtj at kohaaloha.com> --- > Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com> patches looks good, passing QA? $ koha-qa.pl -c 2 testing 2 commit(s) (applied to commit b592d34) * 86b0a36 Bug 6945 [FOLLOW-UP] Add a link to show a MARC preview in the nor koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt * 1227251 Add a link to show a MARC preview in the normal view of the detai koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt * koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt OK -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 16 15:06:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 13:06:48 +0000 Subject: [Koha-bugs] [Bug 8688] Add a recall button to the biblio record details page. In-Reply-To: <bug-8688-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8688-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8688-70-9b2EUSmvLd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8688 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |mtj at kohaaloha.com --- Comment #9 from Mason James <mtj at kohaaloha.com> --- > Works perfectly *if* you are the superlibrarian. There was an error in the > permissions checking, I've attached a followup to fix it. I also had to add > execution permissions to the file circ/send_recall_notice.pl. > > These are extremely minor fixes, so I'll set it to 'signed off' for now and > assume whoever passes qa on it will be testing it. If you feel this needs a > separate signoff, please set the status back to 'Needs Signoff" and feel > free to yell at me. ok, this follow-up patch still needs testing/sign-off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 16 15:12:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 13:12:33 +0000 Subject: [Koha-bugs] [Bug 8112] Overdues with Fines report, giving duplicates In-Reply-To: <bug-8112-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8112-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8112-70-GgebACnaZo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8112 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Summary|Overdues with Fines giving |Overdues with Fines report, |duplicates |giving duplicates --- Comment #13 from Mason James <mtj at kohaaloha.com> --- (In reply to comment #6) > Created attachment 11813 [details] > 0001-SIGNED-OFF-Bug-8112-Overdues-with-Fines-giving-dupli > > > This patch deals with fixing the overdues with fines report only. > > Handling of reconciling those dups must be addressed somewhere else. > > I only tested the behavior of the report with the above two patches. > > Test: > 1) configured a patron with overdue items with fines. > 2) i ran the overdue with fines report > i saw two rows, one for each patron ( normal scenario) > 3) to emulate a dupe FU fine update in accountlines, I insert the row > refer to attachment above ... > circulation_overdues_report_createdupefine_same_item.png > for mysql work > 4) i ran the overdue with fines report > I saw three rows, but two for the same patron and same item (multiple FU > case) > refer to attachment above ... circulation_overdues_report_dupefine.png > 5) applied 0001 and 0002 patches, and ran report gain > I saw only two rows, even tough dups exist in the database. > refer to circulation_overdues_report_dupefine1_nodupeshowing.png > > This reports behaviour will work wether dups exist or not. But when in > place, > it hides the dups. > > Note: Folks on IRC mentioned this was the result of an upgrade from 3.6.x to > 3.8.x > In leiu of performing an upgrade, I took this route. > > wajasu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 16 15:17:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 13:17:16 +0000 Subject: [Koha-bugs] [Bug 8210] Headings in OPAC bib details should link to authority record In-Reply-To: <bug-8210-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8210-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8210-70-mwFNhpd6CE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8210 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 16 15:17:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 13:17:18 +0000 Subject: [Koha-bugs] [Bug 8210] Headings in OPAC bib details should link to authority record In-Reply-To: <bug-8210-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8210-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8210-70-Kh9vNk7Cz4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8210 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11519|0 |1 is obsolete| | Attachment #11591|0 |1 is obsolete| | --- Comment #9 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12261 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12261&action=edit Bug 8210: add links to authorities to headings in OPAC At the moment, there is no way to get to an authority record from a bib record that uses it other than doing a new search on the authority file. This patch adds a link (a cute little magnifying glass) to linked authority records on the OPAC detail view for MARC21 and NORMARC with XSLT enabled. A follow-up patch will add the link to regular mode. Because UNIMARC handles authorities differently, the link is not added to the XSLT. Test plan: 1) Set OPACXSLTDetailsDisplay to 'default' 2) View a record that has some headings that are linked to authority records in the OPAC (easiest way to find a record like that is to edit a record and add some headings using the thesaurus plugin) 3) Observe the cute little magnifying glass links to the authority. Revised version of the patch adds a space between the heading and the magnifying glass. Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Patch works nicely. If a library does not like to see the magnifying glass/link to the authority, it's easy to disable it by adding the line .authlink {display:none;} to OpacUserCSS. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 16 15:19:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 13:19:06 +0000 Subject: [Koha-bugs] [Bug 8112] Overdues with Fines report, giving duplicates In-Reply-To: <bug-8112-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8112-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8112-70-oFuxKyiTcx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8112 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact| |mtj at kohaaloha.com --- Comment #14 from Mason James <mtj at kohaaloha.com> --- > 0001-SIGNED-OFF-Bug-8112-Overdues-with-Fines-giving-dupli we have a test plan here, and a sign-off i think this is OK to pass-QA on... $ koha-qa.pl -c 2 testing 2 commit(s) (applied to commit ce03893) * 7ba58d0 Bug 8112 - Overdues with Fines dup Followup - Add items.itemnumbe C4/Overdues.pm * 16abfcc Bug 8112 - Overdues with Fines giving duplicates C4/Overdues.pm * C4/Overdues.pm OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 16 15:22:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 13:22:08 +0000 Subject: [Koha-bugs] [Bug 8112] Overdues with Fines report, giving duplicates In-Reply-To: <bug-8112-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8112-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8112-70-Rj8nTv2OMx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8112 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #15 from Mason James <mtj at kohaaloha.com> --- (In reply to comment #12) > Is it normal the followup changes only 1 query ? > I think the problem exists in the 2 cases. But I have not tested ! oops, i missed Jonathans comment Kyle, any response for only the 1 query change, not 2? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 16 15:27:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 13:27:24 +0000 Subject: [Koha-bugs] [Bug 8210] Headings in OPAC bib details should link to authority record In-Reply-To: <bug-8210-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8210-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8210-70-gq4dExEC3J@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8210 --- Comment #10 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12262 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12262&action=edit Bug 8210: add links to authorities in normal mode headings Cherry-picked from BibLibre's work on bug 5888: opac-detail subject/author links improvements Added a link to opac-authoritiesdetail.pl when possible. Only affects 'Normal view'. Does not affect XSLT display. Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com> Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 16 15:42:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 13:42:20 +0000 Subject: [Koha-bugs] [Bug 8774] New: make a deb package of Koha::Contrib::Tamil::IndexerDaemon Message-ID: <bug-8774-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8774 Priority: P5 - low Change sponsored?: --- Bug ID: 8774 CC: robin at catalyst.net.nz Assignee: koha-bugs at lists.koha-community.org Summary: make a deb package of Koha::Contrib::Tamil::IndexerDaemon Severity: major Classification: Unclassified OS: All Reporter: mtj at kohaaloha.com Hardware: All Status: NEW Version: master Component: Packaging Product: Koha we need a deb package of Koha::Contrib::Tamil::IndexerDaemon before patch 8519 can be accepted -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 16 15:44:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 13:44:03 +0000 Subject: [Koha-bugs] [Bug 8519] Make koha-index-daemon run on startup In-Reply-To: <bug-8519-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8519-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8519-70-lYTlWP5rba@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8519 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Depends on| |8774 --- Comment #12 from Mason James <mtj at kohaaloha.com> --- ive added a new bug '8774' as a blocker for this -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 16 15:44:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 13:44:03 +0000 Subject: [Koha-bugs] [Bug 8774] make a deb package of Koha::Contrib::Tamil::IndexerDaemon In-Reply-To: <bug-8774-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8774-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8774-70-XUJJgRZDP3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8774 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8519 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 16 15:46:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 13:46:49 +0000 Subject: [Koha-bugs] [Bug 8693] Sort biblio checkout history by checkout date instead of patron name In-Reply-To: <bug-8693-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8693-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8693-70-PkuMAdpKzM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8693 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com QA Contact| |mtj at kohaaloha.com --- Comment #3 from Mason James <mtj at kohaaloha.com> --- (In reply to comment #2) > Created attachment 11868 [details] > [SIGNED-OFF] Bug 8693 - Sort biblio checkout history by checkout date > instead of patron name > > Adding a default sort on checkout date. > > Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com> patch looks good, passing QA? $ koha-qa.pl testing 1 commit(s) (applied to commit ce03893) * 9394921 Bug 8693 - Sort biblio checkout history by checkout date instead koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt * koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/issuehistory.tt OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 16 15:48:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 13:48:48 +0000 Subject: [Koha-bugs] [Bug 8210] Headings in OPAC bib details should link to authority record In-Reply-To: <bug-8210-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8210-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8210-70-VPz8Z9mNst@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8210 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact| |mtj at kohaaloha.com --- Comment #11 from Mason James <mtj at kohaaloha.com> --- (In reply to comment #8) > > Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com> > > Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> patch looks good, passing QA? $ koha-qa.pl -c 2 testing 2 commit(s) (applied to commit ce03893) * f0af280 Bug 8210: add links to authorities in normal mode headings C4/Biblio.pm koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt * 2a60d49 Bug 8210: add links to authorities to headings in OPAC koha-tmpl/opac-tmpl/prog/en/css/opac.css koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl koha-tmpl/opac-tmpl/prog/en/xslt/NORMARCslim2OPACDetail.xsl * C4/Biblio.pm OK * koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt OK * koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl OK * koha-tmpl/opac-tmpl/prog/en/xslt/NORMARCslim2OPACDetail.xsl OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 16 15:51:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 13:51:13 +0000 Subject: [Koha-bugs] [Bug 4321] C4::Biblio::GetBiblio is badly coded In-Reply-To: <bug-4321-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4321-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4321-70-wvenrU5I3A@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4321 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com QA Contact|koha-bugs at lists.koha-commun |mtj at kohaaloha.com |ity.org | --- Comment #5 from Mason James <mtj at kohaaloha.com> --- (In reply to comment #4) > Created attachment 11849 [details] > Bug 4321: clean C4::Biblio::GetBiblio and uses > > Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> > Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com> nice patch!, passing QA? $ koha-qa.pl testing 1 commit(s) (applied to commit 2a60d49) * fb741a8 Bug 4321: clean C4::Biblio::GetBiblio and uses C4/Biblio.pm C4/ILSDI/Services.pm C4/ImportBatch.pm C4/Serials.pm catalogue/imageviewer.pl catalogue/issuehistory.pl opac/opac-imageviewer.pl * C4/Biblio.pm OK * C4/ILSDI/Services.pm OK * C4/ImportBatch.pm OK * C4/Serials.pm OK * catalogue/imageviewer.pl OK * catalogue/issuehistory.pl OK * opac/opac-imageviewer.pl OK -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 16 15:52:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 13:52:52 +0000 Subject: [Koha-bugs] [Bug 8709] Subfield 0 does not show in MARC detail in intranet In-Reply-To: <bug-8709-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8709-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8709-70-fSe2QUcvwy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8709 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com QA Contact| |mtj at kohaaloha.com --- Comment #3 from Mason James <mtj at kohaaloha.com> --- (In reply to comment #2) > Created attachment 11935 [details] > Bug 8709: Subfield 0 does not show in MARC detail in intranet > > Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> patch looks good, passing QA? $ koha-qa.pl testing 1 commit(s) (applied to commit 2a60d49) * 058b2c6 Bug 8709: Subfield 0 does not show in MARC detail in intranet authorities/detail-biblio-search.pl authorities/detail.pl catalogue/MARCdetail.pl opac/opac-authoritiesdetail.pl * authorities/detail-biblio-search.pl OK * authorities/detail.pl OK * catalogue/MARCdetail.pl OK * opac/opac-authoritiesdetail.pl OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 16 15:55:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 13:55:10 +0000 Subject: [Koha-bugs] [Bug 8429] Unnecessary use of Exporter in SIP/ILS objects In-Reply-To: <bug-8429-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8429-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8429-70-hHU5HwNw7N@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8429 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com QA Contact| |mtj at kohaaloha.com --- Comment #3 from Mason James <mtj at kohaaloha.com> --- > Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> nice patch!, passing QA? $ koha-qa.pl testing 1 commit(s) (applied to commit 2a60d49) * 3e771fc Bug 8429: Remove unnecessary use of Exporter from SIP/ILS C4/SIP/ILS/Item.pm C4/SIP/ILS/Patron.pm C4/SIP/ILS/Transaction/Checkin.pm C4/SIP/ILS/Transaction/Checkout.pm C4/SIP/ILS/Transaction/FeePayment.pm C4/SIP/ILS/Transaction/Hold.pm C4/SIP/ILS/Transaction/Renew.pm C4/SIP/ILS/Transaction/RenewAll.pm * C4/SIP/ILS/Item.pm OK * C4/SIP/ILS/Patron.pm OK * C4/SIP/ILS/Transaction/Checkin.pm OK * C4/SIP/ILS/Transaction/Checkout.pm OK * C4/SIP/ILS/Transaction/FeePayment.pm OK * C4/SIP/ILS/Transaction/Hold.pm OK * C4/SIP/ILS/Transaction/Renew.pm OK * C4/SIP/ILS/Transaction/RenewAll.pm OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 16 15:57:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 13:57:29 +0000 Subject: [Koha-bugs] [Bug 8336] SIP Server does not process renewal transaction correctly In-Reply-To: <bug-8336-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8336-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8336-70-kW0nzSdHxS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8336 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com QA Contact| |mtj at kohaaloha.com --- Comment #6 from Mason James <mtj at kohaaloha.com> --- > Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> $ koha-qa.pl patch looks good, passing QA? testing 1 commit(s) (applied to commit 2a60d49) * 551c673 Bug 8336 Support Sip Renewal Transaction C4/SIP/ILS.pm C4/SIP/ILS/Transaction/Renew.pm C4/SIP/ILS/Transaction/RenewAll.pm C4/SIP/Sip/MsgType.pm * C4/SIP/ILS.pm OK * C4/SIP/ILS/Transaction/Renew.pm OK * C4/SIP/ILS/Transaction/RenewAll.pm OK * C4/SIP/Sip/MsgType.pm OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 16 15:59:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 13:59:05 +0000 Subject: [Koha-bugs] [Bug 8717] Wrong subscription notes are showing in catalogue detail view of serials in staff client In-Reply-To: <bug-8717-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8717-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8717-70-2Md0RlRNCX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8717 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com QA Contact| |mtj at kohaaloha.com --- Comment #7 from Mason James <mtj at kohaaloha.com> --- > Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> patch looks good, passing QA? $ koha-qa.pl testing 1 commit(s) (applied to commit 2a60d49) * 1685fe5 Bug 8717 - Wrong subscription notes are showing in catalogue deta catalogue/detail.pl * catalogue/detail.pl OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 16 15:59:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 13:59:29 +0000 Subject: [Koha-bugs] [Bug 8774] make a deb package of Koha::Contrib::Tamil::IndexerDaemon In-Reply-To: <bug-8774-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8774-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8774-70-HcjCCyStJK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8774 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- And for 8773 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 16 16:02:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 14:02:03 +0000 Subject: [Koha-bugs] [Bug 8774] make a deb package of Koha::Contrib::Tamil::IndexerDaemon In-Reply-To: <bug-8774-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8774-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8774-70-cX0PdVab4x@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8774 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8773 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 16 16:02:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 14:02:03 +0000 Subject: [Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup In-Reply-To: <bug-8773-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8773-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8773-70-E2qbVq1VTd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8774 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 16 16:03:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 14:03:09 +0000 Subject: [Koha-bugs] [Bug 5357] Subscription search and displays In-Reply-To: <bug-5357-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5357-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5357-70-1hhSLBNjOX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5357 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #25 from Mason James <mtj at kohaaloha.com> --- (In reply to comment #24) > (In reply to comment #22) > > I noticed that the new serials-search.tt file is using 2 spaces for > > identation. Maybe we should fix that too? > > Hi Katrin, > I think there is no coding guidelines for that in the wiki page. > For the tt files, if we choose 4 spaces, after the 4 mandatory div (<div > id="doc3" class="yui-t2"><div id="bd"><div id="yui-main"><div > class="yui-b">), we write each line with 12 spaces. After 3 or 4 blocks, we > have a indentation of 24-28 spaces. It's why I prefer to choose only 2 > spaces. yes, i completely agree Jonathan! :) lets remember to discuss this sometime on the koha-lists -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 16 16:14:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 14:14:26 +0000 Subject: [Koha-bugs] [Bug 5357] Subscription search and displays In-Reply-To: <bug-5357-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5357-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5357-70-swhXGPNySA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5357 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|koha-bugs at lists.koha-commun |mtj at kohaaloha.com |ity.org | --- Comment #26 from Mason James <mtj at kohaaloha.com> --- > Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> patches looks good, passing QA? $ koha-qa.pl -c 2 testing 2 commit(s) (applied to commit 2a60d49) * 02e2c00 Bug 5357: Follow-up - layout and EAN search koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt serials/serials-search.pl * 3f31617 Bug 5357: Adds a new page for searching subscriptions C4/Serials.pm koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc koha-tmpl/intranet-tmpl/prog/en/includes/serials-search.inc koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues.tt koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-home.tt koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt serials/serials-home.pl serials/serials-search.pl * serials/serials-search.pl OK * C4/Serials.pm OK * serials/serials-home.pl OK * koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt OK * koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc OK * koha-tmpl/intranet-tmpl/prog/en/includes/serials-search.inc OK * koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues.tt OK * koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-home.tt OK -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 16 16:18:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 14:18:06 +0000 Subject: [Koha-bugs] [Bug 3782] delivered z39.50 targets wrong for NY Public Library and NY University Library In-Reply-To: <bug-3782-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3782-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3782-70-Vr4TnuKjFB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3782 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com QA Contact| |mtj at kohaaloha.com --- Comment #15 from Mason James <mtj at kohaaloha.com> --- (In reply to comment #14) > Created attachment 11758 [details] > Bug 3782: Remove broken z39.50 targets from sample files > > Removes NYPL and NYU from the list of sample z39.50 servers, because > they don't work or only work inconsistently. > > Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> nice patch!, passing QA? $ koha-qa.pl testing 1 commit(s) (applied to commit 3f31617) * 73857bf Bug 3782: Remove broken z39.50 targets from sample files installer/data/mysql/de-DE/optional/sample_z3950_servers.sql installer/data/mysql/en/optional/sample_z3950_servers.sql installer/data/mysql/es-ES/optional/sample_z3950_servers.sql installer/data/mysql/pl-PL/optional/sample_z3950_servers.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 16 16:20:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 14:20:42 +0000 Subject: [Koha-bugs] [Bug 7401] Shelving Location facet instead of Branch facet when only 1 branch configured In-Reply-To: <bug-7401-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7401-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7401-70-fPwo4rELoz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com QA Contact|koha.sekjal at gmail.com |mtj at kohaaloha.com --- Comment #37 from Mason James <mtj at kohaaloha.com> --- (In reply to comment #36) > Created attachment 12254 [details] > [SIGNED-OFF] Bug 7401 - Shelving Location facet > Signed-off-by: Owen Leonard <oleonard at myacpl.org> patch looks good, passing QA? $ koha-qa.pl testing 1 commit(s) (applied to commit 3f31617) * 663f5e5 Bug 7401 - Shelving Location facet C4/Branch.pm C4/Koha.pm C4/Search.pm koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc koha-tmpl/opac-tmpl/prog/en/includes/opac-facets.inc opac/opac-search.pl * C4/Branch.pm OK * C4/Koha.pm OK * C4/Search.pm OK * opac/opac-search.pl OK * koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc OK * koha-tmpl/opac-tmpl/prog/en/includes/opac-facets.inc OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 16 16:31:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 14:31:06 +0000 Subject: [Koha-bugs] [Bug 7993] saved report with hierarchies In-Reply-To: <bug-7993-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7993-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7993-70-lKYQqDe07H@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7993 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com QA Contact|koha.sekjal at gmail.com |mtj at kohaaloha.com --- Comment #20 from Mason James <mtj at kohaaloha.com> --- (In reply to comment #19) > Created attachment 12126 [details] > Bug 7993: Save reports with Group/Subgroup hierarchy > > Signed-off-by: Delaye Stephane <stephane.delaye at biblibre.com> patch looks good, passing QA? $ koha-qa.pl testing 1 commit(s) (applied to commit 3f31617) * 4d90348 Bug 7993: Save reports with Group/Subgroup hierarchy C4/Reports/Guided.pm admin/authorised_values.pl installer/data/mysql/kohastructure.sql installer/data/mysql/updatedatabase.pl koha-tmpl/intranet-tmpl/prog/en/modules/reports/dictionary.tt koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt misc/cronjobs/runreport.pl opac/svc/report reports/dictionary.pl reports/guided_reports.pl svc/report * C4/Reports/Guided.pm OK * admin/authorised_values.pl OK * installer/data/mysql/updatedatabase.pl OK * misc/cronjobs/runreport.pl OK * reports/dictionary.pl OK * reports/guided_reports.pl OK * koha-tmpl/intranet-tmpl/prog/en/modules/reports/dictionary.tt OK * koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 01:35:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 16 Sep 2012 23:35:01 +0000 Subject: [Koha-bugs] [Bug 5339] Parcel closing in acq In-Reply-To: <bug-5339-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5339-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5339-70-YDJPgmIGgy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339 Srdjan Jankovic <srdjan at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|srdjan at catalyst.net.nz | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 05:14:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 03:14:18 +0000 Subject: [Koha-bugs] [Bug 8749] Missing Ubuntu library files in ubuntu.packages and ubuntu.12.04.packages In-Reply-To: <bug-8749-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8749-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8749-70-9cCdoY7Sid@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8749 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from M. Tompsett <mtompset at hotmail.com> --- After looking at the 3.8.x repo, I realized this was only a problem with the 3.8.4 release. It should be corrected in the 3.8.5 release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 09:27:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 07:27:28 +0000 Subject: [Koha-bugs] [Bug 8382] It is not possible to cancel an order when receiving on a filtered page in parcel.pl In-Reply-To: <bug-8382-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8382-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8382-70-Qb08cvkOPP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8382 --- Comment #15 from Jonathan Druart <jonathan.druart at biblibre.com> --- Christophe: A followup is mandatory ! This line does not do what we want: +my $datereceived = ($input->param('op') eq ('new' or "search")) ? C4::Dates->new($input->param('datereceived')) + : C4::Dates->new($input->param('datereceived'), 'iso'); $s eq ('foo' or 'bar') does not return true if $s = 'bar' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 09:35:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 07:35:50 +0000 Subject: [Koha-bugs] [Bug 7409] Missing dependencies for Debian package In-Reply-To: <bug-7409-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7409-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7409-70-B10NGiVtxG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7409 --- Comment #11 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 12263 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12263&action=edit Bug 7409 : Missing dependency on DBD::Mock -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 11:17:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 09:17:54 +0000 Subject: [Koha-bugs] [Bug 8366] Meaning of "All" in issuing rules In-Reply-To: <bug-8366-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8366-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8366-70-h7SEQhsiCP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8366 --- Comment #9 from Paul Poulain <paul.poulain at biblibre.com> --- (In reply to comment #8) > Sorry for the delay, I was doing some research. Librarians seem to like the > idea of going back to 'Default' instead of 'All'. But we might want to ask > why it was changed to all originally - who was confused by 'All'? > > Nicole The main issue here is that the "all" (same word) has different meanings. See the initial description of this bug: * for libraries and patrons, it means "value to use if there is no rule for this library/patron" * for itemtypes it means "otherwise", it's not exactly the same "default" Let me take another example: 3 libraries LA, LB, LC 3 patron categories PA, PB, PC 3 itemtypes IA, IB, IC If you define LA, PA, IA = 5 items LA, PA, IB = 5 items LA, PA, IC = 5 items *, *, * = 10 items it will mean one can issue 10 items from LB *and* 10 items from LC That's not the same behaviour as for itemtypes, where LA, PA, IA = 5 LA, PA, * = 10 means 10 IB *or* IC (= 10 IB, 9 IB+1IC, 8+2, 7+3,...) Different behaviour = different terms should be used ! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 11:29:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 09:29:36 +0000 Subject: [Koha-bugs] [Bug 8190] Koha does not have a logging module In-Reply-To: <bug-8190-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8190-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8190-70-oAymiFUVx5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12257|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 12264 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12264&action=edit Bug 8190: Koha::Utils::Logger, Logging module use Koha::Utils::Logger qw/$log/; $log = Koha::Utils::Logger->new; $log->debug("This is a debug message"); $log->info("This is an information"); $log->error("This is an error !"); The Logger constructor can take an hash reference with "file" and "level" to define a filepath or a log level. For a log level >= warning, a call stack is printed. Prerequisite: - set an environment variable KOHA_LOG in your virtual host: SetEnv KOHA_LOG /home/koha/var/log/opac.log - set a write flag for www-data on this file Please have a look at t/Logger.t for more details. Signed-off-by: Mason James <mtj at kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 11:29:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 09:29:41 +0000 Subject: [Koha-bugs] [Bug 7409] Missing dependencies for Debian package In-Reply-To: <bug-7409-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7409-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7409-70-kqof4SjX3M@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7409 --- Comment #12 from Robin Sheat <robin at catalyst.net.nz> --- Assuming that these deps are recorded in the standard dependencies file, they'll get picked up on their own, and I tend to roll them into a bigger patch, along with changelog updates and such. If not, then this patch will be needed for them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 11:29:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 09:29:46 +0000 Subject: [Koha-bugs] [Bug 8190] Koha does not have a logging module In-Reply-To: <bug-8190-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8190-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8190-70-loDkwa8QZN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #12 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 12265 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12265&action=edit Bug 8190: Followup Logger: FIX perlcritic -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 11:30:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 09:30:55 +0000 Subject: [Koha-bugs] [Bug 8190] Koha does not have a logging module In-Reply-To: <bug-8190-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8190-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8190-70-rUm4RRaVVB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #13 from Jonathan Druart <jonathan.druart at biblibre.com> --- First patch replace LOG with KOHA_LOG Second patch fixes perlcritic errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 11:31:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 09:31:02 +0000 Subject: [Koha-bugs] [Bug 7409] Missing dependencies for Debian package In-Reply-To: <bug-7409-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7409-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7409-70-y8txLN76GR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7409 --- Comment #13 from Chris Cormack <chris at bigballofwax.co.nz> --- They aren't currently, which means that the 3.8.x daily builds are failing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 11:37:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 09:37:23 +0000 Subject: [Koha-bugs] [Bug 5339] Parcel closing in acq In-Reply-To: <bug-5339-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5339-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5339-70-FW7WM5vrBI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11535|0 |1 is obsolete| | --- Comment #77 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 12266 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12266&action=edit [SIGNED-OFF] Bug 5339: Invoices management improvement Patch rebased on master. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 11:38:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 09:38:07 +0000 Subject: [Koha-bugs] [Bug 5339] Parcel closing in acq In-Reply-To: <bug-5339-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5339-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5339-70-JccJzwyszo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11574|0 |1 is obsolete| | --- Comment #78 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 12267 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12267&action=edit Bug 5339: perltidy on added files Patch rebased on master. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 11:38:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 09:38:43 +0000 Subject: [Koha-bugs] [Bug 5339] Parcel closing in acq In-Reply-To: <bug-5339-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5339-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5339-70-45SNQCqfha@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 12:07:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 10:07:48 +0000 Subject: [Koha-bugs] [Bug 7241] circulation action logs record biblionumber instead of item number In-Reply-To: <bug-7241-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7241-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7241-70-gHadgC98bz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7241 --- Comment #29 from Paul Poulain <paul.poulain at biblibre.com> --- (In reply to comment #27) > (In reply to comment #24) > > Well, Thinking of it a little bit more, I've reverted the patch. > > > > Having history badly broken for existing instances is really bad, because we > > will never be able to fix the problem properly once action_logs contains > > mixed informations (biblio & items) > > > > And I've an easy proposal to fix what can be fixed: > > The following SQL: > > UPDATE action_logs SET object=(SELECT itemnumber FROM items WHERE > > biblionumber= action_logs.object LIMIT 1) WHERE module='CIRCULATION' AND > > action in ('ISSUE','RETURN'); > > > > Set the 1st item number (as we can't know which item was circulated once > > things have been anonymised). It's better than nothing. > > > > I propose that you submit a new patch including an updatedatabase with this > > SQL > > As a possible supplement, how about tagging the object column with an > indication of whether it's an old-style log of a biblionumber. E.g., > > UPDATE action_logs SET object = 'biblio ' || object WHERE module = > 'CIRCULATION' AND action IN ('ISSUE', 'RETURN'); > > Then viewlog.pl could assume that if the value is tagged with a 'biblio ' > prefix that it contains an bib number; if it isn't, it contains an item > number. > > Doing it this way would mean that the logs are as accurate as possible. It means Adrien would have to update viewlog.pl to take care of this ? I'm not sure I'm for it. It introduce some specific code to circumvent an error in what is saved. > Another, farther-reaching option would be to add biblionumber and itemnumber > columns to action_logs. mmm... the 'object' term is generic, it can also contain a borrowernumber,... Maybe that was a mistake, and it would be better to have a "biblionumber", "itemnumber", "borrowernumber",... field (one field for each needed kind of information). But that would be for another patch ;-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 12:15:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 10:15:04 +0000 Subject: [Koha-bugs] [Bug 8370] Default checkout, hold and return policy for all library => wrong term In-Reply-To: <bug-8370-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8370-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8370-70-ai1rlb9IDo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8370 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nengard at gmail.com |jonathan.druart at biblibre.co | |m --- Comment #4 from Paul Poulain <paul.poulain at biblibre.com> --- Jonathan, if you could make a patch for fixing those term issues, that would be perfect ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 12:15:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 10:15:12 +0000 Subject: [Koha-bugs] [Bug 8370] Default checkout, hold and return policy for all library => wrong term In-Reply-To: <bug-8370-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8370-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8370-70-ceY2xOaZII@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8370 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 12:39:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 10:39:03 +0000 Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies In-Reply-To: <bug-7688-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7688-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7688-70-FSH8KjZuwY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 --- Comment #42 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 12268 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12268&action=edit Bug 7688 follow-up: Small fixes for QA #2 - "return undef" -> "return" - ":utf8" -> ":encoding(UTF-8)" - TAB -> SPACES -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 12:39:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 10:39:36 +0000 Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies In-Reply-To: <bug-7688-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7688-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7688-70-vImy5wtpyk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 --- Comment #43 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 12269 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12269&action=edit Bug 7688: Translate sample frequencies for french -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 12:40:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 10:40:42 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: <bug-8375-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8375-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8375-70-6iy8vSfmUO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #17 from Paul Poulain <paul.poulain at biblibre.com> --- (In reply to comment #16) > Although I agree that > some web font css label solution or such may be the worth pursuing. I investigated a lot Perl libraries for managing PDF. I feel we will have a better results investigating the CSS way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 12:41:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 10:41:46 +0000 Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies In-Reply-To: <bug-7688-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7688-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7688-70-rn2o01AqPC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #44 from Julian Maurice <julian.maurice at biblibre.com> --- (In reply to comment #40) > QUESTION : why in the FR-fr samples do you have english strings (and not > french) : > diff --git a/installer/data/mysql/fr-FR/2-Optionel/sample_frequencies.sql > b/installer/data/mysql/fr-FR/2-Optionel/sample_frequencies.sql > shouldn't : > + ('2/day', 'day', 1, 2, 1), > + ('1/day', 'day', 1, 1, 2), > + ('3/week', 'week', 1, 3, 3), > + ('1/week', 'week', 1, 1, 4), > + ('1/2 weeks', 'week', 2, 1, 5), > + ('1/3 weeks', 'week', 3, 1, 6), > be > + ('2/jour', 'day', 1, 2, 1), > + ('1/jour', 'day', 1, 1, 2), > + ('3/semaine', 'week', 1, 3, 3), > + ('1/semaine', 'week', 1, 1, 4), > + ('1/2 semaines', 'week', 2, 1, 5), > + ('1/3 semaines', 'week', 3, 1, 6), > > (if yes, please confirm -so i can ask koha-translate mailing list for SP, > IT, NO,... translations, and provide a french version) Yes it should be translated. Note that it can also be done through staff interface. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 12:42:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 10:42:05 +0000 Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies In-Reply-To: <bug-7688-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7688-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7688-70-caZcOmHNLY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11489|Bug 7688: Change |[SIGNED-OFF] Bug 7688: description|subscription numbering |Change subscription |pattern and frequencies |numbering pattern and | |frequencies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 12:42:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 10:42:15 +0000 Subject: [Koha-bugs] [Bug 8190] Koha does not have a logging module In-Reply-To: <bug-8190-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8190-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8190-70-wCNN5SKMoe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12265|0 |1 is obsolete| | --- Comment #14 from Mason James <mtj at kohaaloha.com> --- Created attachment 12270 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12270&action=edit Bug 8190: Followup Logger: FIX perlcritic Signed-off-by: Mason James <mtj at kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 12:42:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 10:42:20 +0000 Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies In-Reply-To: <bug-7688-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7688-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7688-70-6OFufED3jN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11490|Bug 7688 follow-up: Small |[SIGNED-OFF] Bug 7688 description|fixes for QA |follow-up: Small fixes for | |QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 12:43:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 10:43:28 +0000 Subject: [Koha-bugs] [Bug 8190] Koha does not have a logging module In-Reply-To: <bug-8190-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8190-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8190-70-S9k9nh6TOZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #15 from Mason James <mtj at kohaaloha.com> --- (In reply to comment #9) > > Jonathan. looks good, signing-off... > > but, perlcritic errors... errors fixed, signing-off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 13:06:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 11:06:29 +0000 Subject: [Koha-bugs] [Bug 8420] tool statisticfines.pl(bz 6858) and hourly loan(bz5549) In-Reply-To: <bug-8420-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8420-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8420-70-Oftq1eJuog@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8420 --- Comment #7 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> --- Created attachment 12271 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12271&action=edit Proposed patch (for 3.8.X) Rebased patch for 3.8.X version. Only one existing line is different form master version. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 13:51:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 11:51:03 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8296-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8296-70-AuAoeAXGaK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 14:04:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 12:04:29 +0000 Subject: [Koha-bugs] [Bug 8382] It is not possible to cancel an order when receiving on a filtered page in parcel.pl In-Reply-To: <bug-8382-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8382-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8382-70-BX1kNfteDs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8382 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11653|0 |1 is obsolete| | Attachment #11982|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 12272 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12272&action=edit Bug 8382 [Follow-up] It is not possible to cancel an order when receiving on a filtered page in parcel.pl In order to be valid XHTML ampersands must be encoded ("&"). Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 14:04:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 12:04:42 +0000 Subject: [Koha-bugs] [Bug 8382] It is not possible to cancel an order when receiving on a filtered page in parcel.pl In-Reply-To: <bug-8382-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8382-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8382-70-fFmZgECOVj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8382 --- Comment #17 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 12273 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12273&action=edit Bug 8382: Followup: FIX wrong comparaison -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 14:18:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 12:18:17 +0000 Subject: [Koha-bugs] [Bug 8370] Default checkout, hold and return policy for all library => wrong term In-Reply-To: <bug-8370-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8370-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8370-70-5KIG6HUouV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8370 --- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 12274 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12274&action=edit Bug 8370: Change term issues (smart-rules) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 14:18:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 12:18:46 +0000 Subject: [Koha-bugs] [Bug 8370] Default checkout, hold and return policy for all library => wrong term In-Reply-To: <bug-8370-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8370-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8370-70-7iBdUyQ9lm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8370 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 14:19:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 12:19:30 +0000 Subject: [Koha-bugs] [Bug 8370] Default checkout, hold and return policy for all library => wrong term In-Reply-To: <bug-8370-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8370-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8370-70-gBZDXEM5Ln@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8370 --- Comment #6 from Jonathan Druart <jonathan.druart at biblibre.com> --- I also change the "Holds policy by item type" part for more consistency. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 14:24:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 12:24:06 +0000 Subject: [Koha-bugs] [Bug 8775] New: add collection code to lost report Message-ID: <bug-8775-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8775 Priority: P5 - low Change sponsored?: --- Bug ID: 8775 Assignee: gmcharlt at gmail.com Summary: add collection code to lost report Severity: enhancement Classification: Unclassified OS: All Reporter: nengard at gmail.com Hardware: All Status: NEW Version: master Component: Reports Product: Koha The canned lost report shows the shelving location, but not collection code, it should show both if it shows one. Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 14:45:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 12:45:52 +0000 Subject: [Koha-bugs] [Bug 8428] can't save contracts In-Reply-To: <bug-8428-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8428-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8428-70-DMBVJJjLxu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8428 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_8 |rel_3_10 --- Comment #12 from Owen Leonard <oleonard at myacpl.org> --- (In reply to comment #11) > Doesn't apply on 3.8.x please reformat if needed Not needed. The bug is related to the addition of the jQueryUI datepicker which isn't in 3.8.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 15:10:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 13:10:57 +0000 Subject: [Koha-bugs] [Bug 8559] conflicting item statuses In-Reply-To: <bug-8559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8559-70-o9LP4wLKDm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8559 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12250|0 |1 is obsolete| | Attachment #12252|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12275 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12275&action=edit Bug 8559 - conflicting item statuses - Force cancel or revert If a librarian checks out a waiting hold to a different patron it gives the item conflicting statuses. The item will show as both checked out to the different patron, and waiting for the original patron. This patch fixes this by not allowing this situation to occurr. If a librarian attempts to issue an item that is waiting for a different patron, the system will force the librarian to choose to a) not issue the item b) issue the item, and cancel the waiting hold c) issue the item, and revert the waiting hold In this scenario, reverting the waiting hold means to push it back on the reserves queue as a hold with a priority of 1, which will push the priorities of any existing holds back by 1 as well. It will become an item level hold for the given item, as we cannot know if the hold was item-level or bib-level given the data we have about the hold. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 15:11:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 13:11:52 +0000 Subject: [Koha-bugs] [Bug 8559] conflicting item statuses In-Reply-To: <bug-8559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8559-70-6b6XErLWnP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8559 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12275|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12276 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12276&action=edit Bug 8559 - conflicting item statuses - Force cancel or revert If a librarian checks out a waiting hold to a different patron it gives the item conflicting statuses. The item will show as both checked out to the different patron, and waiting for the original patron. This patch fixes this by not allowing this situation to occurr. If a librarian attempts to issue an item that is waiting for a different patron, the system will force the librarian to choose to a) not issue the item b) issue the item, and cancel the waiting hold c) issue the item, and revert the waiting hold In this scenario, reverting the waiting hold means to push it back on the reserves queue as a hold with a priority of 1, which will push the priorities of any existing holds back by 1 as well. It will become an item level hold for the given item, as we cannot know if the hold was item-level or bib-level given the data we have about the hold. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 15:32:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 13:32:53 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: <bug-5327-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5327-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5327-70-zyvJGru7Wy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #242 from Kyle M Hall <kyle at bywatersolutions.com> --- I think there is general agreement that future patches for this issue should be filed as separate bugs and set as depending on this bug. The number of comments on this one is becoming unwieldy. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 15:45:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 13:45:40 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-K04P3sQ22C@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 --- Comment #94 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 12277 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12277&action=edit Bug 7067 [Follow-up: templates] allow patron self registration via the opac - Adding simple style to register link on home page - Adding unique ids to new pages and to blocks containing registration links - Adding better page titles and breadcrumb links to some pages - Correcting bug which meant incorrect message showed on registration page when OPACPatronDetails preferences is turned off - Passing patron details to opac-memberentry.tt so that patron's name can be displayed in breadcrumbs - Improving display in staff client of patron record updates waiting to be approved. - Adding a sort by name to output of pending patron record updates - Adding updated JqueryUI library files to include expanded widget options. The changes in this patch require the addition of the jQueryUI Accordion widget. Other pending patches are seeking to add enough of the other remaining missing widgets that it seems time to go ahead and add the rest. Future submissions which add usage of these widgets will have to be careful to make changes to Koha's CSS where necessary. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 15:59:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 13:59:39 +0000 Subject: [Koha-bugs] [Bug 8776] New: note on why a fine was waived Message-ID: <bug-8776-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8776 Priority: P5 - low Change sponsored?: --- Bug ID: 8776 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: note on why a fine was waived Severity: major Classification: Unclassified OS: All Reporter: nengard at gmail.com Hardware: All Status: NEW Version: master Component: Circulation Product: Koha There used to be a way to add notes to payments and waived fines, but that's not possible anymore. We need a way to record why we're waiving fines for auditors and accounting reasons. This may be related to bug 6413, but I don't know how so I'm not putting it in depends or blocks. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 15:59:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 13:59:49 +0000 Subject: [Koha-bugs] [Bug 8776] note on why a fine was waived In-Reply-To: <bug-8776-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8776-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8776-70-T4gsM685W2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8776 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6413 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 15:59:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 13:59:49 +0000 Subject: [Koha-bugs] [Bug 6413] Notes in Fines doing wonky things In-Reply-To: <bug-6413-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6413-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6413-70-Dlr0kSwPYT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8776 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 16:24:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 14:24:46 +0000 Subject: [Koha-bugs] [Bug 8559] conflicting item statuses In-Reply-To: <bug-8559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8559-70-qXBhwHAeuk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8559 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #8 from Owen Leonard <oleonard at myacpl.org> --- I think this patch represents the best possible solution given the way we handle holds right now. I wish we didn't have to force the hold to be an item-level hold, but it's a limitation of how we store hold information. I would ask for two changes: 1. Make "revert" the default option. That is the less "destructive" of the two. 2. Change the markup of the radio buttons to allow clicking on the text: <p> <label for="cancelreserve">Cancel hold</label> <input type="radio" checked="checked" value="cancel" name="cancelreserve" id="cancelreserve" /><br /> <label for="revertreserve">Revert waiting status</label> <input type="radio" value="revert" name="cancelreserve" id="revertreserve" /> </p> The label must match the id of the input field. Note that the input name and the input id do not have to match. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 16:39:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 14:39:37 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-CyfkSc7LA6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12277|0 |1 is obsolete| | --- Comment #95 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12278 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12278&action=edit [SIGNED-OFF] Bug 7067 [Follow-up: templates] allow patron self registration via the opac - Adding simple style to register link on home page - Adding unique ids to new pages and to blocks containing registration links - Adding better page titles and breadcrumb links to some pages - Correcting bug which meant incorrect message showed on registration page when OPACPatronDetails preferences is turned off - Passing patron details to opac-memberentry.tt so that patron's name can be displayed in breadcrumbs - Improving display in staff client of patron record updates waiting to be approved. - Adding a sort by name to output of pending patron record updates - Adding updated JqueryUI library files to include expanded widget options. The changes in this patch require the addition of the jQueryUI Accordion widget. Other pending patches are seeking to add enough of the other remaining missing widgets that it seems time to go ahead and add the rest. Future submissions which add usage of these widgets will have to be careful to make changes to Koha's CSS where necessary. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 16:44:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 14:44:17 +0000 Subject: [Koha-bugs] [Bug 8559] conflicting item statuses In-Reply-To: <bug-8559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8559-70-im2QFfm72u@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8559 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12276|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12279 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12279&action=edit Bug 8559 - conflicting item statuses - Force cancel or revert If a librarian checks out a waiting hold to a different patron it gives the item conflicting statuses. The item will show as both checked out to the different patron, and waiting for the original patron. This patch fixes this by not allowing this situation to occurr. If a librarian attempts to issue an item that is waiting for a different patron, the system will force the librarian to choose to a) not issue the item b) issue the item, and cancel the waiting hold c) issue the item, and revert the waiting hold In this scenario, reverting the waiting hold means to push it back on the reserves queue as a hold with a priority of 1, which will push the priorities of any existing holds back by 1 as well. It will become an item level hold for the given item, as we cannot know if the hold was item-level or bib-level given the data we have about the hold. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 16:45:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 14:45:03 +0000 Subject: [Koha-bugs] [Bug 8559] conflicting item statuses In-Reply-To: <bug-8559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8559-70-9Q9EYDMBg5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8559 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to comment #8) > I think this patch represents the best possible solution given the way we > handle holds right now. I wish we didn't have to force the hold to be an > item-level hold, but it's a limitation of how we store hold information. > > I would ask for two changes: > > 1. Make "revert" the default option. That is the less "destructive" of the > two. > 2. Change the markup of the radio buttons to allow clicking on the text: > > <p> > <label for="cancelreserve">Cancel hold</label> > <input type="radio" checked="checked" value="cancel" > name="cancelreserve" id="cancelreserve" /><br /> > <label for="revertreserve">Revert waiting status</label> > <input type="radio" value="revert" name="cancelreserve" > id="revertreserve" /> > </p> > > The label must match the id of the input field. Note that the input name and > the input id do not have to match. Good idea, and very nice improvements to the html. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 16:48:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 14:48:20 +0000 Subject: [Koha-bugs] [Bug 7351] ability to edit a range of holidays In-Reply-To: <bug-7351-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7351-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7351-70-moe2HKgAvj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 Christophe Croullebois <christophe.croullebois at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #46 from Christophe Croullebois <christophe.croullebois at biblibre.com> --- hum Paul, this patch just works on the second feature about a range a date, the deletion. The first one I have made allows to create holidays on a range, and it is pushed. This one allows to delete on a range, so I don't understand, you says you can't add holidays on a range ? But it's not the purpose of this patch, anyway, I have just tested again few minutes ago, all is ok, even creating holidays on a range... Could you test again ? I see an other trouble with you there is some time => Christophe Croullebois 2012-06-01 09:45:21 UTC I have seen with Paul, maybe due to his hook git... Tested with two others PC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 16:49:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 14:49:21 +0000 Subject: [Koha-bugs] [Bug 7751] Decrease loan period on items with a high number of holds In-Reply-To: <bug-7751-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7751-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7751-70-CHw20TuJ2J@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 --- Comment #30 from Colin Campbell <colin.campbell at ptfs-europe.com> --- Yes thats it, except DecreaseLoanHighholdsDuration is the value to reduce the loan by. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 17:00:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 15:00:00 +0000 Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8015-70-e9GYzJw40x@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #12 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 12280 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12280&action=edit Bug 8015: Followup: On move, we cant delete existing fields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 17:01:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 15:01:26 +0000 Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8015-70-rDH08gyBaf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #13 from Jonathan Druart <jonathan.druart at biblibre.com> --- *Quick and dirty patch* :-/ But it could fix the issue. Kyle, what do you think about it ? It could introduces some regressions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 17:03:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 15:03:48 +0000 Subject: [Koha-bugs] [Bug 8559] conflicting item statuses In-Reply-To: <bug-8559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8559-70-XG4CUca74v@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8559 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12279|0 |1 is obsolete| | --- Comment #11 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 12281 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12281&action=edit [SIGNED-OFF] Bug 8559 - conflicting item statuses - Force cancel or revert If a librarian checks out a waiting hold to a different patron it gives the item conflicting statuses. The item will show as both checked out to the different patron, and waiting for the original patron. This patch fixes this by not allowing this situation to occurr. If a librarian attempts to issue an item that is waiting for a different patron, the system will force the librarian to choose to a) not issue the item b) issue the item, and cancel the waiting hold c) issue the item, and revert the waiting hold In this scenario, reverting the waiting hold means to push it back on the reserves queue as a hold with a priority of 1, which will push the priorities of any existing holds back by 1 as well. It will become an item level hold for the given item, as we cannot know if the hold was item-level or bib-level given the data we have about the hold. Signed-off-by: Owen Leonard <oleonard at myacpl.org> All three cases tested, correct outcome each time -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 17:05:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 15:05:16 +0000 Subject: [Koha-bugs] [Bug 8559] conflicting item statuses In-Reply-To: <bug-8559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8559-70-B41XascPM4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8559 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 17:09:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 15:09:31 +0000 Subject: [Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view In-Reply-To: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8597-70-hMYNkAa2fM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA --- Comment #58 from Paul Poulain <paul.poulain at biblibre.com> --- will test and think of it again, it's a damn useful enhancement ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 17:28:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 15:28:40 +0000 Subject: [Koha-bugs] [Bug 8777] New: Quiet errors in circulation.pl Message-ID: <bug-8777-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8777 Priority: P5 - low Change sponsored?: --- Bug ID: 8777 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: oleonard at myacpl.org Summary: Quiet errors in circulation.pl Severity: normal Classification: Unclassified OS: All Reporter: oleonard at myacpl.org Hardware: All Status: ASSIGNED Version: master Component: Circulation Product: Koha Reference found where even-sized list expected at /circ/circulation.pl line 97. Use of uninitialized value $print in string eq at /circ/circulation.pl line 161. Use of uninitialized value in string eq at /circ/circulation.pl line 166. Use of uninitialized value $print in string eq at /circ/circulation.pl line 173. Use of uninitialized value in string eq at /circ/circulation.pl line 364. Use of uninitialized value in string ne at /circ/circulation.pl line 382. Use of uninitialized value in string eq at /circ/circulation.pl line 388. Use of uninitialized value in string gt at /circ/circulation.pl line 464. Use of uninitialized value in string eq at /circ/circulation.pl line 461. Use of uninitialized value in hash element at /circ/circulation.pl line 644. Use of uninitialized value in concatenation (.) or string at /circ/circulation.pl line 644. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 17:34:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 15:34:06 +0000 Subject: [Koha-bugs] [Bug 8370] Default checkout, hold and return policy for all library => wrong term In-Reply-To: <bug-8370-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8370-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8370-70-gZA7KqVDEU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8370 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #7 from Marc V?ron <veron at veron.ch> --- As Nicole pointed out in comment #2 the insturctions at the top of the page should be changed as well. Now the points regarding the defaults read as follows: all libraries, same patron type, same item type all libraries, same patron type, all item types all libraries, all patron types, same item type all libraries, all patron types, all item types It would be better to have e.g. default (all libraries), same patron type, same item type default (all libraries), same patron type, all item types default (all libraries), all patron types, same item type default (all libraries), all patron types, all item types Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 17:44:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 15:44:47 +0000 Subject: [Koha-bugs] [Bug 8110] Add tests for Calendar modules In-Reply-To: <bug-8110-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8110-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8110-70-Xq4b9kkJGB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110 --- Comment #46 from Paul Poulain <paul.poulain at biblibre.com> --- QA comment : the 3rd patch adds some localized files: .../mysql/fr-FR/2-Optionel/sample_holidays.sql | 4 ++++ .../data/mysql/it-IT/optional/sample_holidays.sql | 4 ++++ why are they needed ? in fr-FR, there is no branch in the sample 'MPL' afaik PS: is it still a blocker ? I think no, the blocker was bug 8486, and it's pushed now, this one is just the test suite -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 17:55:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 15:55:37 +0000 Subject: [Koha-bugs] [Bug 8190] Koha does not have a logging module In-Reply-To: <bug-8190-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8190-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8190-70-uh2gVgtgbQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12264|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12282 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12282&action=edit Bug 8190: Koha::Utils::Logger, Logging module use Koha::Utils::Logger qw/$log/; $log = Koha::Utils::Logger->new; $log->debug("This is a debug message"); $log->info("This is an information"); $log->error("This is an error !"); The Logger constructor can take an hash reference with "file" and "level" to define a filepath or a log level. For a log level >= warning, a call stack is printed. Prerequisite: - set an environment variable KOHA_LOG in your virtual host: SetEnv KOHA_LOG /home/koha/var/log/opac.log - set a write flag for www-data on this file Please have a look at t/Logger.t for more details. Signed-off-by: Mason James <mtj at kohaaloha.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 17:55:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 15:55:48 +0000 Subject: [Koha-bugs] [Bug 8190] Koha does not have a logging module In-Reply-To: <bug-8190-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8190-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8190-70-48olCOYlSB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12270|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12283 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12283&action=edit Bug 8190: Followup Logger: FIX perlcritic Signed-off-by: Mason James <mtj at kohaaloha.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 17:56:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 15:56:06 +0000 Subject: [Koha-bugs] [Bug 8190] Koha does not have a logging module In-Reply-To: <bug-8190-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8190-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8190-70-con7GtWnIh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #18 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12284 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12284&action=edit Bug 8190 - Followup - Add cached logger, output messages to template * Add C4::Context->logger * Embed logged messageds to a comment in the template html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 17:58:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 15:58:56 +0000 Subject: [Koha-bugs] [Bug 8190] Koha does not have a logging module In-Reply-To: <bug-8190-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8190-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8190-70-2WIIrMGSoR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #19 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to comment #18) > Created attachment 12284 [details] > Bug 8190 - Followup - Add cached logger, output messages to template > > * Add C4::Context->logger > * Embed logged messageds to a comment in the template html I forget to add that I ran perltidy on Logger.pm. I think this followup could be very useful. It may be better to have it controlled by a system preference, rather than always on though. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 18:04:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 16:04:43 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: <bug-6813-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6813-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6813-70-AyxeUqodvH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |paul.poulain at biblibre.com --- Comment #17 from Paul Poulain <paul.poulain at biblibre.com> --- QA comment: * the template does not respect HTML4 coding guidelines = there are UCfirst on every word, please switch to lowercase * have you tested on a large database. MySQL will not optimize SELECT ... FROM biblio WHERE title LIKE '%something%', and performances will be very poor. I think it should be specified on the home "duplicatesearch" page * the name "duplicate search" sounds strange to me. Shouldn't it be something like "multi-source search" or something like that ? (Search for duplicate ?) being not english native, I won't be affirmative, but Nicole, if you could confirm... * when you reach the page, you get a: Duplicate Search No Result that is irrelevant. failing QA (i'll accept this patch after feature freeze, no side effect risk, that's only new code) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 18:11:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 16:11:10 +0000 Subject: [Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup In-Reply-To: <bug-8773-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8773-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8773-70-jO188bErLd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12248|0 |1 is obsolete| | --- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 12285 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12285&action=edit Bug 8773 - Start per-instance koha-index-daemon in .deb setup This bug is the .deb version of 8519 [1]. It is motivated by the fact that using 1-minute (or more) frecquency cronjobs to do the incremental indexing of records does not scale for us, nor is accepted by our librarians. Using an indexing daemon avoids launching a new interpreter each time the cron triggers the indexing, and also allows sub-minute reindexing. Frecquency is hardcoded right now. A follow up could provide a way to set it for each instance. This patch relies on Koha::Contrib::Tamil's koha-index-daemon script [2], but could be easily adjusted to use another if we got a new one (SolR?). I havent got the time to setup my infrastructure to generate my own debs, and thus haven't got the oportunity to test this patch. If anyone with the skills helps me on setting that I could test them and fix possible issues. If there's something I could change to make this patches better just let me know. Regards To+ [1] http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8519 [2] The default cronjob that is set using the debian/koha-common.cron.d file is being disbaled by this patch to avoid collision. Sponsored-by: Universidad Nacional de C?rdoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 18:14:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 16:14:58 +0000 Subject: [Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices In-Reply-To: <bug-6030-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6030-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6030-70-DsFCjdlBsy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #25 from Paul Poulain <paul.poulain at biblibre.com> --- Running the script says: DBD::mysql::st execute failed: Unknown column '$date' in 'field list' at ./overdue_notices.pl line 505. DBD::mysql::st fetchrow_hashref failed: fetch() without execute() at ./overdue_notices.pl line 518. Investigating a little, show that line 505 is running $sth2, that contains: my $sth2 = $dbh->prepare( <<'END_SQL' ); SELECT biblio.title as "biblio.title", biblio.*, items.*, issues.*, biblioitems.itemtype, TO_DAYS($date)-TO_DAYS(date_due) AS days_overdue FROM issues,items,biblio, biblioitems WHERE items.itemnumber=issues.itemnumber AND biblio.biblionumber = items.biblionumber AND biblio.biblionumber = biblioitems.biblionumber AND issues.borrowernumber = ? AND TO_DAYS($date)-TO_DAYS(date_due) BETWEEN ? and ? END_SQL the line: AND TO_DAYS($date)-TO_DAYS(date_due) BETWEEN ? and ? is heavily wrong ! The signoff was probably right when it was made, but time passed, things were updated, and now it's invalid ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 18:20:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 16:20:55 +0000 Subject: [Koha-bugs] [Bug 7986] Export issues In-Reply-To: <bug-7986-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7986-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7986-70-7zWH6FeRNK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 --- Comment #35 from Owen Leonard <oleonard at myacpl.org> --- (In reply to comment #33) > If at least one of both sysprefs (ExportRemoveFields and > ExportWithCsvProfile) is filled, the export link is displayed The column of checkboxes for export should also be shown only if one of the two system preferences is filled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 18:22:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 16:22:25 +0000 Subject: [Koha-bugs] [Bug 4491] Cleaning some weird code in *search.pl In-Reply-To: <bug-4491-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4491-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4491-70-ys9vhrX66Z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4491 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|unspecified |rel_3_10 --- Comment #14 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master I think there's no need to push it to 3.8, (just in case we missed some side effect) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 18:25:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 16:25:02 +0000 Subject: [Koha-bugs] [Bug 8705] Software error on help of main page In-Reply-To: <bug-8705-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8705-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8705-70-WiVLCAJ1xW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8705 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 --- Comment #12 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 18:27:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 16:27:00 +0000 Subject: [Koha-bugs] [Bug 8714] Poorly ordered and triggers warning in marctagstructure.pl In-Reply-To: <bug-8714-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8714-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8714-70-q0iUNxLhba@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8714 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|unspecified |rel_3_8 --- Comment #4 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 18:37:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 16:37:30 +0000 Subject: [Koha-bugs] [Bug 8378] <fine> syntax not working on overdues anymore In-Reply-To: <bug-8378-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8378-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8378-70-jhM6gY9brX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8378 --- Comment #13 from wajasu <matted-34813 at mypacks.net> --- Created attachment 12286 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12286&action=edit Bug-8378-v3.8.x-fine-syntax-not-working-on-overdues-.patch I've attached a patch that applies to origin/3.8.x wajasu -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 18:47:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 16:47:15 +0000 Subject: [Koha-bugs] [Bug 7690] hidelostitems not working in Normal Display In-Reply-To: <bug-7690-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7690-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7690-70-jOPvQ82IXq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7690 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 --- Comment #8 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 18:47:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 16:47:54 +0000 Subject: [Koha-bugs] [Bug 8727] Correct help text in rebuild_zebra_sliced.sh In-Reply-To: <bug-8727-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8727-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8727-70-86U9pyB5gW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8727 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 18:48:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 16:48:50 +0000 Subject: [Koha-bugs] [Bug 8713] Warning message triggered by clicking keyword to marc mapping. In-Reply-To: <bug-8713-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8713-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8713-70-lsMV4IDBd7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8713 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|unspecified |rel_3_8 --- Comment #5 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 18:52:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 16:52:39 +0000 Subject: [Koha-bugs] [Bug 8624] famfamfam should be outside theme directory In-Reply-To: <bug-8624-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8624-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8624-70-w1yAUj9xGR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8624 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #13 from Paul Poulain <paul.poulain at biblibre.com> --- (In reply to comment #11) > > > > > Now that you suggest it, I think it might be possible. If Owen can't think > > > > > of any reason not to, I will submit a revised patch to do this. > > > > > > > > I see no reason not to from the template management point of view. If it is > > > > feasible, let's do it. And the same with itemtypeimg? > > > > > > Actually, this would not work with standard installs. > > > > hmm, unless we had +symlinks enabled in apache, yeah? > > Ooh, that's an intriguing idea. I'm not sure how to do that in a way that > won't break dev installs, though, since most developers don't update their > koha-httpd.conf files. mmm... I'm not sure I should push this patch. Is there still a debate ? why famfam and not itemtypeimg ? Has anyone checked it will it work with standard installs as well as dev ones ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 18:57:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 16:57:18 +0000 Subject: [Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books In-Reply-To: <bug-7560-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7560-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7560-70-ybgQQUZxsx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |paul.poulain at biblibre.com --- Comment #8 from Paul Poulain <paul.poulain at biblibre.com> --- QA comment: shouldn't +=head2 GetTotalFines + + my $total_fines_owed = GetTotalFines( $borrowernumber ); + + Returns the total amount owed by the given borrower. be in C4/Accounts.pm more than in C4/Overdues.pm ? I know there is calcfine and UpdateFine in C4/Overdues.pm, but I think it's a mistake ! If you agree with me and move GetTotalFines to C4/Accounts.pm, you're welcomed to factorize getcharges, getcredits, getrefunds, that are Getting things in accountlines table. Note this is not requested for earning QA, just a suggestion You're also welcomed to name your sub GetFines, as GetSomethings() is already supposed to return a list of something, so the "Total" is useless -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 19:00:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 17:00:58 +0000 Subject: [Koha-bugs] [Bug 8765] Add series title to intranet search results In-Reply-To: <bug-8765-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8765-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8765-70-G3cyeUZ93S@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8765 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 --- Comment #5 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master. Note I replaced tab by 4 spaces before pushing. Please don't use tabs, use 4 spaces instead (see coding guidelines) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 19:03:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 17:03:01 +0000 Subject: [Koha-bugs] [Bug 8275] xml parsing error when the webservice GetPatronInfo/show_loans is called In-Reply-To: <bug-8275-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8275-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8275-70-UnIoRgMZ3g@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8275 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #4 from Paul Poulain <paul.poulain at biblibre.com> --- Koha team Lyon 3, do you agree with the counter fix proposed by Fridolyn ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 19:08:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 17:08:43 +0000 Subject: [Koha-bugs] [Bug 7455] Authority subfields are cloned in the wrong field In-Reply-To: <bug-7455-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7455-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7455-70-C7tB7ybBiv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #29 from Paul Poulain <paul.poulain at biblibre.com> --- The patch does not apply anymore, sorry: CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt Please rebase & resubmit (and switch back to passed QA) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 19:25:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 17:25:41 +0000 Subject: [Koha-bugs] [Bug 6151] IndependantBranches and HomeOrHoldingBranchReturn can prevent items from being checked in In-Reply-To: <bug-6151-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6151-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6151-70-7zndpMu11W@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6151 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 --- Comment #21 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master. I've revised my judgement, it's a very handy feature ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 19:34:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 17:34:25 +0000 Subject: [Koha-bugs] [Bug 7913] Automatically receive serial issues In-Reply-To: <bug-7913-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7913-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7913-70-jc2JOTNj3D@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7913 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #10 from Paul Poulain <paul.poulain at biblibre.com> --- QA comment: * St?phane, in comment 4 you say: > the use of this function is limited to subscriptions without items > records.And the bulk reception start always from the last issue expected > then it would be better to choose which serial number you want to begin > receiving and not always from the last number expected. it seems it's still the case, this is a reason for failing QA : libraries won't know or will make a mistake, for sure ! To earn QA, this patch should hide the link when the subscrition.serialsadditems=1 Optional suggestion (that isn't requested to pass QA) = have the link/feature also available from serials/serials-edit.pl page Other than this, it's a very handy feature ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 19:35:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 17:35:31 +0000 Subject: [Koha-bugs] [Bug 7913] Automatically receive serial issues In-Reply-To: <bug-7913-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7913-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7913-70-wZFg6Aw0RU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7913 --- Comment #11 from Paul Poulain <paul.poulain at biblibre.com> --- Koha team Lyon 3, if you provide a follow-up, please attach the follow-up, and switch back to passed QA, i'll test/check and push if everything is OK with the follow-up I've checked the main patch, works nicely. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 19:40:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 17:40:02 +0000 Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8015-70-FD1NwfWP9r@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to comment #13) > *Quick and dirty patch* :-/ But it could fix the issue. > Kyle, what do you think about it ? It could introduces some regressions. I think that looks good to me. I don't think it will cause any problems. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 19:54:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 17:54:35 +0000 Subject: [Koha-bugs] [Bug 8190] Koha does not have a logging module In-Reply-To: <bug-8190-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8190-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8190-70-RPiK4GqN7m@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12284|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12287 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12287&action=edit Bug 8190 - Followup - Add cached logger, output messages to template * Add C4::Context->logger * Embed logged messageds to a comment in the template html, controlled by the system preference LogToHtmlComments\ * Add both new system preferences to sysprefs.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 19:56:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 17:56:37 +0000 Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8015-70-4BerJvkdJz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12280|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12288 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12288&action=edit Bug 8015: Followup: On move, we cant delete existing fields Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 19:57:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 17:57:33 +0000 Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8015-70-aCqQIjoRmt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12288|Bug 8015: Followup: On |[SIGNED-OFF] Bug 8015: description|move, we cant delete |Followup: On move, we cant |existing fields |delete existing fields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 19:57:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 17:57:45 +0000 Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8015-70-TtyRHQANHv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 20:10:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 18:10:15 +0000 Subject: [Koha-bugs] [Bug 7986] Export issues In-Reply-To: <bug-7986-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7986-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7986-70-ljnH8IFKiS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 20:10:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 18:10:25 +0000 Subject: [Koha-bugs] [Bug 7986] Export issues In-Reply-To: <bug-7986-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7986-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7986-70-LvEx3QxUPT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 20:10:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 18:10:43 +0000 Subject: [Koha-bugs] [Bug 7986] Export issues In-Reply-To: <bug-7986-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7986-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7986-70-a85P6zdyXe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 21:07:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 19:07:32 +0000 Subject: [Koha-bugs] [Bug 8623] Javascript libraries should be outside theme directories In-Reply-To: <bug-8623-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8623-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8623-70-kCQIVdEP2X@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8623 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11581|0 |1 is obsolete| | Attachment #11582|0 |1 is obsolete| | --- Comment #13 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 12289 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12289&action=edit Bug 8623 - Fix YUI path for OPAC in debian/rules After the changes to YUI path the build process is broken. For testing this I had to set the build process to ommit the tests as there are some db_dependent test being called (which failed). To do this I ran the build script like this: sudo DEB_BUILD_OPTIONS=nocheck ./debian/build-git-snapshot -distribution precise -D precise -r ~/ubuntu -v 3.9.0-046~git -d Note: Even when this is fixed, there are still issues with some files missing dh_install: etc/koha/searchengine/solr/config.yaml exists in debian/tmp but is not installed to anywhere dh_install: etc/koha/searchengine/solr/indexes.yaml exists in debian/tmp but is not installed to anywhere dh_install: etc/koha/solr/indexes.yaml exists in debian/tmp but is not installed to anywhere dh_install: missing files, aborting make: *** [binary] Error 2 dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit status 2 Sponsored-by: Universidad Nacional de C?rdoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 21:08:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 19:08:09 +0000 Subject: [Koha-bugs] [Bug 8623] Javascript libraries should be outside theme directories In-Reply-To: <bug-8623-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8623-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8623-70-rK9vcbk7Qe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8623 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 21:08:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 19:08:19 +0000 Subject: [Koha-bugs] [Bug 8623] Javascript libraries should be outside theme directories In-Reply-To: <bug-8623-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8623-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8623-70-laOL3VeMoD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8623 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 21:23:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 19:23:17 +0000 Subject: [Koha-bugs] [Bug 8624] famfamfam should be outside theme directory In-Reply-To: <bug-8624-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8624-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8624-70-7MK25Atl3T@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8624 wajasu <matted-34813 at mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matted-34813 at mypacks.net --- Comment #14 from wajasu <matted-34813 at mypacks.net> --- ok, i did a standard install from the signed off patch. i inspected /usr/share/koha/.../lib/famfamfam and such and it looked fine. i turned on the XSLT Details( with "default" and see the BK.png in my details in opac and staff client. I'm assuming the SIGNED-OFF patch had other places confirmed. wajasu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 21:49:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 19:49:42 +0000 Subject: [Koha-bugs] [Bug 8508] Holds to Pull : Library dropdown options are erroneously concatenated by br tags In-Reply-To: <bug-8508-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8508-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8508-70-cAYBUHp6jG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8508 --- Comment #6 from David Cook <dcook at prosentient.com.au> --- Yep, Jonathan. It looks good. Sorry about the tabs! I've started using two different editors, and I hadn't switched the second from tabs to spaces. That should be remedied now :) (In reply to comment #4) > Hi Owen and David, > > Could you confirmed that my proposed patch does the same job as previously ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 21:53:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 19:53:22 +0000 Subject: [Koha-bugs] [Bug 8765] Add series title to intranet search results In-Reply-To: <bug-8765-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8765-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8765-70-b3rWPzvGhV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8765 --- Comment #6 from David Cook <dcook at prosentient.com.au> --- (In reply to comment #5) > Patch pushed to master. Note I replaced tab by 4 spaces before pushing. > Please don't use tabs, use 4 spaces instead (see coding guidelines) Thanks for the reminder, Paul. I've started using another editor and I thought that I had it switched to spaces, but now I see the error. Future patches should be tab free :). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 21:58:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 19:58:35 +0000 Subject: [Koha-bugs] [Bug 8233] New search engine layer - introduce solr without breaking anything else In-Reply-To: <bug-8233-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8233-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8233-70-Or52ib01rN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11128|0 |1 is obsolete| | --- Comment #37 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 12290 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12290&action=edit Bug 8233 - SolR-related /etc/ files break deb building Remove them using debian/rules when building .deb packages until we figure out what to do with them in a .deb install. To do this I ran the build script like this: sudo DEB_BUILD_OPTIONS=nocheck ./debian/build-git-snapshot -distribution precise -D precise -r ~/ubuntu -v 3.9.0-046~git -d Sponsored-by: Universidad Nacional de C?rdoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 21:59:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 19:59:02 +0000 Subject: [Koha-bugs] [Bug 8233] New search engine layer - introduce solr without breaking anything else In-Reply-To: <bug-8233-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8233-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8233-70-26qjmFEC6B@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 21:59:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 19:59:09 +0000 Subject: [Koha-bugs] [Bug 8233] New search engine layer - introduce solr without breaking anything else In-Reply-To: <bug-8233-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8233-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8233-70-obE99bYic7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 22:08:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 20:08:41 +0000 Subject: [Koha-bugs] [Bug 8778] New: Add "Phrase" Searching to OPAC Search Message-ID: <bug-8778-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8778 Priority: P5 - low Change sponsored?: --- Bug ID: 8778 Assignee: oleonard at myacpl.org Summary: Add "Phrase" Searching to OPAC Search Severity: enhancement Classification: Unclassified OS: All Reporter: dcook at prosentient.com.au Hardware: All Status: NEW Version: master Component: OPAC Product: Koha Add "Keyword phrase", "Title phrase", and "Notes/Comments" to drop-down menu in masthead.inc, which populates top search box in OPAC. Also, edit opac-search.pl so that the correct index appears in the drop-down menu following a search (which doesn't seem possible using JQuery) Finally, add "Keyword phrase" to OPAC Advanced Search, and move "Title phrase" and "Notes/Comments" so that they appear on the default advanced search screen rather than after clicking "More Options". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 22:25:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 20:25:37 +0000 Subject: [Koha-bugs] [Bug 8778] Add "Phrase" Searching to OPAC Search In-Reply-To: <bug-8778-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8778-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8778-70-VUBwXkm6Nn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8778 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard at myacpl.org |dcook at prosentient.com.au --- Comment #1 from David Cook <dcook at prosentient.com.au> --- Created attachment 12291 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12291&action=edit Bug 8778 - Add "Phrase" Searching to OPAC Search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 17 23:11:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 21:11:25 +0000 Subject: [Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup In-Reply-To: <bug-8773-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8773-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8773-70-shqWFf3VGL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12285|0 |1 is obsolete| | --- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 12292 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12292&action=edit Bug 8773 - Start per-instance koha-index-daemon in .deb setup This bug is the .deb version of 8519 [1]. It is motivated by the fact that using 1-minute (or more) frecquency cronjobs to do the incremental indexing of records does not scale for us, nor is accepted by our librarians. Using an indexing daemon avoids launching a new interpreter each time the cron triggers the indexing, and also allows sub-minute reindexing. Frecquency is hardcoded right now. A follow up could provide a way to set it for each instance. This patch relies on Koha::Contrib::Tamil's koha-index-daemon script [2], but could be easily adjusted to use another if we got a new one (SolR?). I havent got the time to setup my infrastructure to generate my own debs, and thus haven't got the oportunity to test this patch. If anyone with the skills helps me on setting that I could test them and fix possible issues. If there's something I could change to make this patches better just let me know. Regards To+ [1] http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8519 [2] The default cronjob that is set using the debian/koha-common.cron.d file is being disbaled by this patch to avoid collision. Sponsored-by: Universidad Nacional de C?rdoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 00:00:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 22:00:27 +0000 Subject: [Koha-bugs] [Bug 7911] Greater flexibility in auto barcode number generation In-Reply-To: <bug-7911-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7911-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7911-70-L8WAKUhUW5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7911 Derryn <derrynj at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |derrynj at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 00:13:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 22:13:22 +0000 Subject: [Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup In-Reply-To: <bug-8773-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8773-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8773-70-OzciIiA3L3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12292|0 |1 is obsolete| | --- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 12293 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12293&action=edit Bug 8773 - Start per-instance koha-index-daemon in .deb setup This bug is the .deb version of 8519 [1]. It is motivated by the fact that using 1-minute (or more) frecquency cronjobs to do the incremental indexing of records does not scale for us, nor is accepted by our librarians. Using an indexing daemon avoids launching a new interpreter each time the cron triggers the indexing, and also allows sub-minute reindexing. Frecquency is hardcoded right now. A follow up could provide a way to set it for each instance. This patch relies on Koha::Contrib::Tamil's koha-index-daemon script [2], but could be easily adjusted to use another if we got a new one (SolR?). I havent got the time to setup my infrastructure to generate my own debs, and thus haven't got the oportunity to test this patch. If anyone with the skills helps me on setting that I could test them and fix possible issues. If there's something I could change to make this patches better just let me know. Regards To+ [1] http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8519 [2] The default cronjob that is set using the debian/koha-common.cron.d file is being disbaled by this patch to avoid collision. Sponsored-by: Universidad Nacional de C?rdoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 00:26:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 22:26:41 +0000 Subject: [Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup In-Reply-To: <bug-8773-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8773-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8773-70-8QzvbVgvaX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773 --- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Until we get Koha::Contrib::Tamil::IndexerDaemon packed as a .deb file (Bug 8774), it needs to be manually installed for testing this patch. As building the packages takes some time depending on your hardware, i've uploaded the .deb files to http://es.koha-community.org/kc_files/ so they can be tested. You need to grab the koha-common*.deb file, install it (using dpkg -i <file>) and probably create a new koha instance (koha-create --create-db instance). It is worth checking if upon upgrade the running instances get their indexer daemon running automagically. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 01:40:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 23:40:05 +0000 Subject: [Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup In-Reply-To: <bug-8773-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8773-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8773-70-dfvdDOGrXP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773 --- Comment #6 from wajasu <matted-34813 at mypacks.net> --- Created attachment 12294 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12294&action=edit initial test run for koha-common .deb (newer one) I got my VM with the current koha-common. I did dpkg -i <yourkoha-commom> and I've attached what I saw. See initial test run for koha-common .deb (newer one) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 01:49:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 17 Sep 2012 23:49:35 +0000 Subject: [Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup In-Reply-To: <bug-8773-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8773-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8773-70-yPb7it0l4O@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773 --- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- (In reply to comment #6) > Created attachment 12294 [details] > initial test run for koha-common .deb (newer one) > > I got my VM with the current koha-common. I did dpkg -i <yourkoha-commom> > and I've attached what I saw. > See initial test run for koha-common .deb (newer one) Looks like you had a 'biblio' instance previously created, with an uninitialized db. I think that is a bug on the installer / upgrader itself. I'd purge Koha-common, delete /etc/Koha/sites and install the .deb. other option would be going through the webinstall process prior To the dpkg upgrade. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 02:32:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 00:32:37 +0000 Subject: [Koha-bugs] [Bug 6689] Improve styling of table pager In-Reply-To: <bug-6689-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6689-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6689-70-5r3eWzcRtX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6689 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12251|0 |1 is obsolete| | --- Comment #6 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 12295 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12295&action=edit [SIGNED-OFF] Bug 6689 [Follow-up] Improve styling of table pager Small correction to add non-vendor-prefixed border radius declaration to make style consistent on newer browsers. To test, view a page with a sorted table and pager controls, like members/readingrec.pl. The pager controls "box" should show rounded corners in Firefox 15+ Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 02:32:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 00:32:49 +0000 Subject: [Koha-bugs] [Bug 6689] Improve styling of table pager In-Reply-To: <bug-6689-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6689-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6689-70-0LswYjJ4aM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6689 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 03:32:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 01:32:09 +0000 Subject: [Koha-bugs] [Bug 7724] Tests requiring Zebra should be skipped if Zebra isn't set up In-Reply-To: <bug-7724-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7724-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7724-70-hn3rbaixLB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7724 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 03:32:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 01:32:14 +0000 Subject: [Koha-bugs] [Bug 7617] Authority search results should optionally be sorted by system order In-Reply-To: <bug-7617-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7617-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7617-70-cL4mGfHG1j@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7617 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 03:33:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 01:33:04 +0000 Subject: [Koha-bugs] [Bug 7702] Test for C4::Heading::MARC21 should only run under MARC21 In-Reply-To: <bug-7702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7702-70-R9q2X2zYW5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7702 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 03:33:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 01:33:14 +0000 Subject: [Koha-bugs] [Bug 8022] Permissions test doesn't check all languages In-Reply-To: <bug-8022-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8022-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8022-70-FhLTEd6L4n@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8022 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 04:52:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 02:52:09 +0000 Subject: [Koha-bugs] [Bug 8478] Update Ubuntu related files In-Reply-To: <bug-8478-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8478-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8478-70-xD4716N4E9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8478 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |herolsen at alumni.upenn.edu --- Comment #23 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- *** Bug 5217 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 04:52:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 02:52:09 +0000 Subject: [Koha-bugs] [Bug 5217] INSTALL.ubuntu Packages/CPAN notes out of date for Ubuntu 10.04 LTS (Lucid) In-Reply-To: <bug-5217-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5217-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5217-70-mQ4RoDBy8O@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5217 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |tomascohen at gmail.com Resolution|--- |DUPLICATE --- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- *** This bug has been marked as a duplicate of bug 8478 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 04:57:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 02:57:57 +0000 Subject: [Koha-bugs] [Bug 8779] New: .deb upgrade fails on incomplete instance setup Message-ID: <bug-8779-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8779 Priority: P5 - low Change sponsored?: --- Bug ID: 8779 Assignee: gmcharlt at gmail.com Summary: .deb upgrade fails on incomplete instance setup Severity: enhancement Classification: Unclassified OS: All Reporter: tomascohen at gmail.com Hardware: All Status: NEW Version: master Component: Installation and upgrade (command-line installer) Product: Koha On a fresh install, doing an upgrade triggers updatedatabase, which fails if the instance was created but the database structure hasn't been initialized (by webinstaller) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 05:18:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 03:18:52 +0000 Subject: [Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view In-Reply-To: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8597-70-nINBeNIgzk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597 --- Comment #59 from Mason James <mtj at kohaaloha.com> --- (In reply to comment #58) > will test and think of it again, it's a damn useful enhancement ! awesome! thanks Paul :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 06:00:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 04:00:23 +0000 Subject: [Koha-bugs] [Bug 5339] Parcel closing in acq In-Reply-To: <bug-5339-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5339-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5339-70-bvxIV2SLOB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #79 from Mason James <mtj at kohaaloha.com> --- > Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> patch looks good, passing QA? $ koha-qa.pl -c 2 testing 2 commit(s) (applied to commit 9acabe4) * 76125f0 Bug 5339: perltidy on added files acqui/invoice.pl acqui/invoices.pl * cc99ecf Bug 5339: Invoices management improvement C4/Acquisition.pm C4/Budgets.pm acqui/addorderiso2709.pl acqui/finishreceive.pl acqui/invoice.pl acqui/invoices.pl acqui/orderreceive.pl acqui/parcel.pl acqui/parcels.pl acqui/spent.pl catalogue/moredetail.pl installer/data/mysql/kohastructure.sql installer/data/mysql/updatedatabase.pl koha-tmpl/intranet-tmpl/prog/en/includes/acquisitions-menu.inc koha-tmpl/intranet-tmpl/prog/en/modules/acqui/histsearch.tt koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt koha-tmpl/intranet-tmpl/prog/en/modules/acqui/spent.tt koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt * acqui/invoice.pl OK * acqui/invoices.pl OK * C4/Acquisition.pm OK * C4/Budgets.pm OK * acqui/addorderiso2709.pl OK * acqui/finishreceive.pl OK * acqui/orderreceive.pl OK * acqui/parcel.pl OK * acqui/parcels.pl OK * acqui/spent.pl OK * catalogue/moredetail.pl OK * installer/data/mysql/updatedatabase.pl OK * koha-tmpl/intranet-tmpl/prog/en/includes/acquisitions-menu.inc OK * koha-tmpl/intranet-tmpl/prog/en/modules/acqui/histsearch.tt OK * koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt OK * koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt OK * koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt OK * koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt OK * koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt OK * koha-tmpl/intranet-tmpl/prog/en/modules/acqui/spent.tt OK * koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt OK -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 06:08:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 04:08:25 +0000 Subject: [Koha-bugs] [Bug 5339] Parcel closing in acq In-Reply-To: <bug-5339-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5339-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5339-70-fIAUWX6CCd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339 --- Comment #80 from Mason James <mtj at kohaaloha.com> --- (In reply to comment #76) > (In reply to comment #75) > > Kyle, > > The patch is waiting for 9 months then I think it can pass qa without UT. > > But a followup will be required. > > Jonathan, hmmm, i an OK with a follow-up patch for unit-test > but we still need a unit-test patch as a follow-up for this patch... -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 06:47:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 04:47:01 +0000 Subject: [Koha-bugs] [Bug 8780] New: Lower dependency version for DateTime::TimeZone Message-ID: <bug-8780-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8780 Priority: P5 - low Change sponsored?: --- Bug ID: 8780 Assignee: gmcharlt at gmail.com Summary: Lower dependency version for DateTime::TimeZone Severity: enhancement Classification: Unclassified OS: All Reporter: mtompset at hotmail.com Hardware: All Status: NEW Version: unspecified Component: Installation and upgrade (command-line installer) Product: Koha A base Debian install of 6.0.5 has a DateTime::TimeZone version 1.20 available (including debian.koha-community.org repositories), but the PerlDependencies.pm says 1.26 After discussions on the IRC channel (http://irc.koha-community.org/irclog/koha/2012-09-17) from 08:50-09:35 and 12:44-13:07, I decided to email Colin Campbell. He replied: "No its a nominal number. Looking through the changes log nearly all changes up to current (1.50) are just updates to reflect data changes in some timezones. We're mainly using it for the timezone names so I think 1.20 will be fine. I think the only reason a number was chosen was because one of the install routines didnt allow us just to say any DateTime::TimeZone Cheers Colin" Given that Colin says it should be okay to lower it to 1.20, and that Wajasu has purposefully tweaked his out since June (almost 3 months), I propose we lower the minimum value to 1.20 from 1.26. This will make git installs under Debian attainable. Test ----- 1) Do a fresh git clone on Debian. 2) cd the clone. 3) sudo apt-get install dselect 4) sudo dpkg --set-selections < install_misc/debian.packages 5) sudo dselect 6) choose I, C, R, and then Q. 7) ./koha_perl_deps.pl -m -u 8) Notice that despite being installed, DateTime::TimeZone is 1.20 vs. the required 1.26 now apply patch 9) ./koha_perl_deps.pl -m -u 10) Notice that DateTime::TimeZone is no longer listed. As for the other items, that can be fixed by running my check_deps.sh script which is in the release-tools repo (I believe), and as such, is another bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 09:38:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 07:38:38 +0000 Subject: [Koha-bugs] [Bug 7986] Export issues In-Reply-To: <bug-7986-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7986-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7986-70-jl5a588EaD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12212|0 |1 is obsolete| | --- Comment #36 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 12296 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12296&action=edit Bug 7986: Followup: Hide the export link unless sysprefs are set If at least one of both sysprefs (ExportRemoveFields and ExportWithCsvProfile) is filled, the export link is displayed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 09:39:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 07:39:07 +0000 Subject: [Koha-bugs] [Bug 7986] Export issues In-Reply-To: <bug-7986-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7986-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7986-70-GgLajovaG2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 10:01:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 08:01:07 +0000 Subject: [Koha-bugs] [Bug 8781] New: Access to Transfer page while "independent branches" is on Message-ID: <bug-8781-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8781 Priority: P5 - low Change sponsored?: --- Bug ID: 8781 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: adrien.saurat at biblibre.com Summary: Access to Transfer page while "independent branches" is on Severity: enhancement Classification: Unclassified OS: All Reporter: adrien.saurat at biblibre.com Hardware: All Status: ASSIGNED Version: master Component: Circulation Product: Koha With the system preference "IndependantBranches" set to On, only a superlibrarian can make transfers. The page is still displayed for others librarians with circulation rights, but they can only chose their own library as a destination, making the page useless for them. The link to this page could be hidden in such cases. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 10:17:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 08:17:21 +0000 Subject: [Koha-bugs] [Bug 8190] Koha does not have a logging module In-Reply-To: <bug-8190-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8190-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8190-70-kgNWVR9T8V@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #21 from Jonathan Druart <jonathan.druart at biblibre.com> --- Hi Kyle, Thanks for your followup ! 2 small remarks about your patch: * you commited mainpage.pl unfortunately * the added block of code in Logger::write is not perltidied Else all seems good but we have to pull together on how we will use the logger. Your idea to add a global var in C4::Context is what I had at the beginning of my work. But after thinking, on this way, we canot change the loglevel for 1 script ! And it is a regression (indeed currently we can do that, changing the DEBUG var). My idea was to add use C4::Logger qw/$log/; $log = C4::Logger->new({level => C4::Context->preference("LogLevel")}); on each page. Like that we could change the log level easily. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 10:24:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 08:24:29 +0000 Subject: [Koha-bugs] [Bug 8370] Default checkout, hold and return policy for all library => wrong term In-Reply-To: <bug-8370-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8370-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8370-70-mAhvTX9iii@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8370 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12274|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 12297 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12297&action=edit Bug 8370: Change term issues (smart-rules) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 10:32:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 08:32:46 +0000 Subject: [Koha-bugs] [Bug 8781] Access to Transfer page while "independent branches" is on In-Reply-To: <bug-8781-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8781-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8781-70-h5I12MYz9O@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8781 --- Comment #1 from Adrien SAURAT <adrien.saurat at biblibre.com> --- Created attachment 12298 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12298&action=edit proposed patch TEST PLAN : It's about testing the display of the "Transfer" link on "circulation-home.pl". The link needs to appear if IndependantBranches is off or if the user is a superlibrarian. 1) IndependantBranches = Off, user is superlibrarian : link appears 2) IndependantBranches = Off, user is not superlibrarian : link appears 3) IndependantBranches = On, user is superlibrarian : link appears 4) IndependantBranches = On, user is not superlibrarian : link does not appear -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 10:33:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 08:33:16 +0000 Subject: [Koha-bugs] [Bug 8781] Access to Transfer page while "independent branches" is on In-Reply-To: <bug-8781-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8781-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8781-70-I2x8EcYYfT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8781 Adrien SAURAT <adrien.saurat at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 10:33:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 08:33:16 +0000 Subject: [Koha-bugs] [Bug 8780] Lower dependency version for DateTime::TimeZone In-Reply-To: <bug-8780-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8780-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8780-70-C9mMD4gDVY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8780 --- Comment #1 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 12299 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12299&action=edit DateTime::TimeZone min_ver=1.20 from 1.26 Test plan as above. This patch applies to 3.8.x and master only. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 10:33:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 08:33:38 +0000 Subject: [Koha-bugs] [Bug 8780] Lower dependency version for DateTime::TimeZone In-Reply-To: <bug-8780-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8780-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8780-70-PRg2kdfa5X@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8780 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 10:51:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 08:51:10 +0000 Subject: [Koha-bugs] [Bug 8275] xml parsing error when the webservice GetPatronInfo/show_loans is called In-Reply-To: <bug-8275-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8275-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8275-70-nnkoHKrCUB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8275 --- Comment #5 from Koha Team Lyon 3 <koha at univ-lyon3.fr> --- (In reply to comment #4) > Koha team Lyon 3, do you agree with the counter fix proposed by Fridolyn ? Seems that makes sense, it's ok for us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 11:26:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 09:26:34 +0000 Subject: [Koha-bugs] [Bug 8336] SIP Server does not process renewal transaction correctly In-Reply-To: <bug-8336-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8336-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8336-70-M0bsodGGRv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8336 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 --- Comment #7 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master (patch untested by me though) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 11:30:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 09:30:07 +0000 Subject: [Koha-bugs] [Bug 8275] xml parsing error when the webservice GetPatronInfo/show_loans is called In-Reply-To: <bug-8275-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8275-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8275-70-aYTTQsWfEL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8275 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 11:34:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 09:34:08 +0000 Subject: [Koha-bugs] [Bug 3782] delivered z39.50 targets wrong for NY Public Library and NY University Library In-Reply-To: <bug-3782-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3782-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3782-70-8T7Eyc2Ila@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3782 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 Assignee|gmcharlt at gmail.com |katrin.fischer at bsz-bw.de --- Comment #16 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master (haven checked visually only that all SQL files are still valid) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 11:35:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 09:35:23 +0000 Subject: [Koha-bugs] [Bug 8717] Wrong subscription notes are showing in catalogue detail view of serials in staff client In-Reply-To: <bug-8717-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8717-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8717-70-fuVxzp7hLu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8717 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 --- Comment #8 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 11:42:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 09:42:55 +0000 Subject: [Koha-bugs] [Bug 8420] tool statisticfines.pl(bz 6858) and hourly loan(bz5549) In-Reply-To: <bug-8420-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8420-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8420-70-b4nP1mJuGj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8420 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Chris Cormack <chris at bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 11:50:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 09:50:55 +0000 Subject: [Koha-bugs] [Bug 8705] Software error on help of main page In-Reply-To: <bug-8705-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8705-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8705-70-9cxtkrYoRE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8705 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #13 from Chris Cormack <chris at bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 12:05:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 10:05:30 +0000 Subject: [Koha-bugs] [Bug 8709] Subfield 0 does not show in MARC detail in intranet In-Reply-To: <bug-8709-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8709-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8709-70-G7LpV1GZgP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8709 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 --- Comment #4 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 12:11:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 10:11:12 +0000 Subject: [Koha-bugs] [Bug 8624] famfamfam should be outside theme directory In-Reply-To: <bug-8624-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8624-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8624-70-1JzxIe2VGS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8624 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #15 from Paul Poulain <paul.poulain at biblibre.com> --- I find some references to prog/famfam using: grep -R "prog/famfamfam" *|more not a big deal = INSTALL.opensuse:cp koha-tmpl/opac-tmpl/prog/famfamfam/silk/error_go.png blib/OPAC_TMPL_DIR/prog/famfamfam/silk/error_go.png INSTALL.opensuse:cp koha-tmpl/opac-tmpl/prog/famfamfam/mini/note.gif blib/OPAC_TMPL_DIR/prog/famfamfam/mini/note.gif much more important: koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslim2intranetDetail.xsl: <xsl:element name="img"><xsl:attribute name="src" >/opac-tmpl/prog/famfamfam/<xsl:value-of select="$materialTypeCode"/>.png</xsl:attribute><xsl:attribute name="alt"></xsl:attr ibute></xsl:element> koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslim2intranetResults.xsl: <xsl:when test="$typeOf008='Mon'"><img s rc="/opac-tmpl/prog/famfamfam/silk/book.png" alt="Bok" title="Bok"/> Bok</xsl:when> koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslim2intranetResults.xsl: <xsl:when test="$typeOf008='Per'"><img s rc="/opac-tmpl/prog/famfamfam/silk/newspaper.png" alt="Periodika" title="Periodika"/> Periodika</xsl:when> koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslim2intranetResults.xsl: <xsl:when test="$typeOf008='Fil'"><img s rc="/opac-tmpl/prog/famfamfam/silk/computer_link.png" alt="Fil" title="Fil"/> Fil</xsl:when> koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslim2intranetResults.xsl: <xsl:when test="$typeOf008='Kar'"><img s rc="/opac-tmpl/prog/famfamfam/silk/map.png" alt="Kart" title="Kart"/> Kart</xsl:when> koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslim2intranetResults.xsl: <xsl:when test="$typeOf008='FV'"><img sr c="/opac-tmpl/prog/famfamfam/silk/film.png" alt="Film og video" title="Film og video"/> Film og video</xsl:when> koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslim2intranetResults.xsl: <xsl:when test="$typeOf008='Mus'"><img s rc="/opac-tmpl/prog/famfamfam/silk/sound.png" alt="Musikktrykk og lydopptak" title="Musikktrykk og lydopptak"/> Musikk</xsl:w hen> Please also fix them to gain "patch pushed" ;-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 12:16:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 10:16:50 +0000 Subject: [Koha-bugs] [Bug 8624] famfamfam should be outside theme directory In-Reply-To: <bug-8624-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8624-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8624-70-UawFxEze5g@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8624 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #16 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- (In reply to comment #15) > I find some references to prog/famfam using: > grep -R "prog/famfamfam" *|more > > not a big deal = > INSTALL.opensuse:cp koha-tmpl/opac-tmpl/prog/famfamfam/silk/error_go.png > blib/OPAC_TMPL_DIR/prog/famfamfam/silk/error_go.png > INSTALL.opensuse:cp koha-tmpl/opac-tmpl/prog/famfamfam/mini/note.gif > blib/OPAC_TMPL_DIR/prog/famfamfam/mini/note.gif > > much more important: > koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslim2intranetDetail.xsl: > <xsl:element name="img"><xsl:attribute name="src" > >/opac-tmpl/prog/famfamfam/<xsl:value-of select="$materialTypeCode"/>.png</xsl:attribute><xsl:attribute name="alt"></xsl:attr > ibute></xsl:element> > koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslim2intranetResults.xsl: > <xsl:when test="$typeOf008='Mon'"><img s > rc="/opac-tmpl/prog/famfamfam/silk/book.png" alt="Bok" title="Bok"/> > Bok</xsl:when> > koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslim2intranetResults.xsl: > <xsl:when test="$typeOf008='Per'"><img s > rc="/opac-tmpl/prog/famfamfam/silk/newspaper.png" alt="Periodika" > title="Periodika"/> Periodika</xsl:when> > koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslim2intranetResults.xsl: > <xsl:when test="$typeOf008='Fil'"><img s > rc="/opac-tmpl/prog/famfamfam/silk/computer_link.png" alt="Fil" > title="Fil"/> Fil</xsl:when> > koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslim2intranetResults.xsl: > <xsl:when test="$typeOf008='Kar'"><img s > rc="/opac-tmpl/prog/famfamfam/silk/map.png" alt="Kart" title="Kart"/> > Kart</xsl:when> > koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslim2intranetResults.xsl: > <xsl:when test="$typeOf008='FV'"><img sr > c="/opac-tmpl/prog/famfamfam/silk/film.png" alt="Film og video" title="Film > og video"/> Film og video</xsl:when> > koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslim2intranetResults.xsl: > <xsl:when test="$typeOf008='Mus'"><img s > rc="/opac-tmpl/prog/famfamfam/silk/sound.png" alt="Musikktrykk og lydopptak" > title="Musikktrykk og lydopptak"/> Musikk</xsl:w > hen> > > Please also fix them to gain "patch pushed" ;-) This patch is OPAC-only. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 12:20:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 10:20:27 +0000 Subject: [Koha-bugs] [Bug 4321] C4::Biblio::GetBiblio is badly coded In-Reply-To: <bug-4321-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4321-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4321-70-TPV1VjKjGY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4321 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_10 Severity|minor |enhancement --- Comment #6 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master (my opinion = not needed to push this to 3.8, it's just code cleaning. we will have time to find any unspotted problem) Thanks for this code cleaning ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 12:21:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 10:21:56 +0000 Subject: [Koha-bugs] [Bug 5409] Call number is not show on Opac search result page. In-Reply-To: <bug-5409-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5409-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5409-70-co846IAEvm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409 --- Comment #13 from Meenakshi <meenakshi.r at osslabs.biz> --- Created attachment 12300 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12300&action=edit Attaching the latest patch. attached the patch. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 12:22:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 10:22:11 +0000 Subject: [Koha-bugs] [Bug 5409] Call number is not show on Opac search result page. In-Reply-To: <bug-5409-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5409-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5409-70-j0TZtI89WW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409 Meenakshi <meenakshi.r at osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 12:24:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 10:24:19 +0000 Subject: [Koha-bugs] [Bug 8757] Longer size text for authorised values "lib" In-Reply-To: <bug-8757-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8757-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8757-70-GjZ9DDkHbQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8757 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 --- Comment #4 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 12:26:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 10:26:31 +0000 Subject: [Koha-bugs] [Bug 8693] Sort biblio checkout history by checkout date instead of patron name In-Reply-To: <bug-8693-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8693-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8693-70-XH1uWJy7Ky@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8693 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_10 --- Comment #4 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master Tiny enhancement that could also be considered as a minor bugfix & ported to 3.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 12:30:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 10:30:21 +0000 Subject: [Koha-bugs] [Bug 8627] Fixing pipe values in MARC21 controlfield 008 of authorities In-Reply-To: <bug-8627-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8627-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8627-70-3TUnmxpe7B@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8627 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_10 --- Comment #7 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master (Could also be considered as a minor bugfix & pushed to 3.8) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 12:38:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 10:38:42 +0000 Subject: [Koha-bugs] [Bug 8714] Poorly ordered and triggers warning in marctagstructure.pl In-Reply-To: <bug-8714-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8714-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8714-70-96ZkitOdiB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8714 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris at bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 12:51:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 10:51:48 +0000 Subject: [Koha-bugs] [Bug 8402] replace 'install_misc/debian.packages' file with 'koha-debian-deps.pl' script In-Reply-To: <bug-8402-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8402-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8402-70-l4AlOWXhtN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8402 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #1 from M. Tompsett <mtompset at hotmail.com> --- What populates C4/Installer/PerlDependencies.pm? The part that isn't in PerlDependencies.pm are the various applications/commands that need installing as well, which I see are in other sections. I agree there needs to be consistency, but what about the bigger picture of the perl dependencies required for a git install? I noticed you did a "sudo aptitude" command-line. Is this preferred over a: sudo dpkg --set-selections < install_misc/{OS}.packages sudo dselect way of doing it? aptitude may not be installed by default, and yes, neither is dselect. Also, notice I said {OS}.packages? The library names may be different between debian-based OSes, and this is why I like "apt-file" for finding a reasonable name. Check out bug 8517 for a script I wrote which uses koha_perl_deps.pl to add missing items to {OS}.packages. I believe a newer incarnation of it is in the release-tools git repo. As long as apt-file is installed and up to date and PerlDependencies is correct. It can be used to determine missing pieces and add them into the .packages file. Does PerlDependencies.pm get updated more accurately than debian/control? Perhaps the solution isn't to delete debian/control which is likely used to build packages where as install_misc/debian.packages is used for a git install, but rather make sure they are both updated from what may be the source: PerlDependencies.pm? Just some related brainstorming. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 13:22:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 11:22:36 +0000 Subject: [Koha-bugs] [Bug 8780] Lower dependency version for DateTime::TimeZone In-Reply-To: <bug-8780-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8780-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8780-70-v7sntvv5Ag@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8780 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 14:10:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 12:10:29 +0000 Subject: [Koha-bugs] [Bug 8782] New: Close a suscription Message-ID: <bug-8782-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8782 Priority: P5 - low Change sponsored?: --- Bug ID: 8782 CC: colin.campbell at ptfs-europe.com Assignee: koha-bugs at lists.koha-community.org Summary: Close a suscription Severity: enhancement Classification: Unclassified OS: All Reporter: jonathan.druart at biblibre.com Hardware: All Status: NEW Version: unspecified Component: Serials Product: Koha In the serial module, we would like to close a subscription. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 14:10:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 12:10:37 +0000 Subject: [Koha-bugs] [Bug 8782] Close a suscription In-Reply-To: <bug-8782-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8782-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8782-70-cWSx0RZcdA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8782 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 14:20:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 12:20:10 +0000 Subject: [Koha-bugs] [Bug 7294] status "in order" In-Reply-To: <bug-7294-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7294-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7294-70-KO8NukLJXk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 --- Comment #37 from Mason James <mtj at kohaaloha.com> --- Created attachment 12301 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12301&action=edit modified: C4/Acquisition.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 14:20:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 12:20:33 +0000 Subject: [Koha-bugs] [Bug 7294] status "in order" In-Reply-To: <bug-7294-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7294-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7294-70-O5D0xXbwnw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11661|0 |1 is obsolete| | --- Comment #38 from Mason James <mtj at kohaaloha.com> --- Created attachment 12302 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12302&action=edit Bug 7294: Adds acquisition informations in marc record "View status 'in order' to the OPAC and staff interface. Specific fields from aqorders can be mapped to marc fields (using ACQ bibliographic framework): aqorders.branchcode aqorders.quantity aqorders.listprice aqorders.uncertainprice aqorders.rrp aqorders.ecost aqorders.notes aqorders.supplierreference aqorders.ordernumber This way, you can keep track on what is currently on order at biblio level until you receive everything. Once all items have been received, the marc field is deleted. Please note that mapping the ordernumber is mandatory for this feature to work Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 14:20:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 12:20:35 +0000 Subject: [Koha-bugs] [Bug 8783] New: Parentheses not escaped properly in queries when using XSLT Message-ID: <bug-8783-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8783 Priority: P5 - low Change sponsored?: --- Bug ID: 8783 Assignee: gmcharlt at gmail.com Summary: Parentheses not escaped properly in queries when using XSLT Severity: normal Classification: Unclassified OS: All Reporter: kyle at bywatersolutions.com Hardware: All Status: NEW Version: master Component: Searching Product: Koha When XSLT is enabled, searching on subjects containing parentheses cause an error. The problem is the parens are not escaped properly, and so are interpreted as part of the query language, rather than the query string. For example, this query fails: (su:{Baggins, Frodo (Fictitious character)}) AND (su:{Fiction}) but this query works: (su:{Baggins, Frodo \(Fictitious character\)}) AND (su:{Fiction}) I think the problem is within the xslt template subfieldSelect. Interestingly, with XSLT off, each subject shows up as an individual link ( so one link for Frogo, and one link for Ficition ) whereas with XSLT on, they subjects are combined with an AND. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 14:22:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 12:22:26 +0000 Subject: [Koha-bugs] [Bug 7294] status "in order" In-Reply-To: <bug-7294-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7294-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7294-70-VZioz59qY6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12301|0 |1 is obsolete| | --- Comment #39 from Mason James <mtj at kohaaloha.com> --- Created attachment 12303 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12303&action=edit perltidy of badly indented ModReceiveOrder() sub -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 14:25:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 12:25:24 +0000 Subject: [Koha-bugs] [Bug 7294] status "in order" In-Reply-To: <bug-7294-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7294-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7294-70-fj8aq8y5ph@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |mtj at kohaaloha.com --- Comment #40 from Mason James <mtj at kohaaloha.com> --- (In reply to comment #38) > Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> QA comment - there is a small error in the neworderempty.tt template causing ./xt/tt_valid.t to fail failing QA on this $ perl ./xt/tt_valid.t 1..2 not ok 1 - TT syntax: not using TT directive within HTML tag # Failed test 'TT syntax: not using TT directive within HTML tag' # at ./xt/tt_valid.t line 55. # Files list: # intranet-tmpl/prog/en/modules/acqui/neworderempty.tt: 341 ok 2 - Token received same as original put on stack # Looks like you failed 1 test of 2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 14:32:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 12:32:28 +0000 Subject: [Koha-bugs] [Bug 1807] search () give odd results In-Reply-To: <bug-1807-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-1807-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-1807-70-ZqUVExuibT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1807 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8783 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 14:32:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 12:32:28 +0000 Subject: [Koha-bugs] [Bug 8783] Parentheses not escaped properly in queries when using XSLT In-Reply-To: <bug-8783-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8783-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8783-70-eKI5KSDPFL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8783 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=1807 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 14:35:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 12:35:20 +0000 Subject: [Koha-bugs] [Bug 8782] Close a suscription In-Reply-To: <bug-8782-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8782-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8782-70-k8paLdEGtn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8782 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |5357 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 14:35:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 12:35:20 +0000 Subject: [Koha-bugs] [Bug 5357] Subscription search and displays In-Reply-To: <bug-5357-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5357-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5357-70-sIwm9IPHfP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5357 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8782 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 14:36:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 12:36:03 +0000 Subject: [Koha-bugs] [Bug 7294] status "in order" In-Reply-To: <bug-7294-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7294-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7294-70-SQq323ejub@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12303|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 14:40:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 12:40:24 +0000 Subject: [Koha-bugs] [Bug 8370] Default checkout, hold and return policy for all library => wrong term In-Reply-To: <bug-8370-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8370-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8370-70-T3f8PZ0dhi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8370 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12297|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12304 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12304&action=edit Bug 8370: Change term issues (smart-rules) Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 14:40:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 12:40:40 +0000 Subject: [Koha-bugs] [Bug 8370] Default checkout, hold and return policy for all library => wrong term In-Reply-To: <bug-8370-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8370-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8370-70-JLwaI9TAi0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8370 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 14:42:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 12:42:51 +0000 Subject: [Koha-bugs] [Bug 8782] Close a suscription In-Reply-To: <bug-8782-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8782-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8782-70-EIiFGOUMcD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8782 --- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 12305 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12305&action=edit Bug 8782: Close a subscription If a subscription is no longer enough published (or we are not waiting for a new periodical) we are allowed to close it. If a subscription is closed, we are not able to receive or generate a new serial. On the serial module, we can now - close a subscriptionn - reopen a closed subscription On serial search 2 tabs is displayed (opened and closed subscriptions). This patch adds: - a new field subscription.closed in DB - a new status for serials (8 = stopped) Test plan: - search subscriptions - close a subscription and check that you cannot receive or generate a new serial - launch another search and check that the closed serial is into the "closed" tab. - You are allowed to reopen a subscription on the subscription detail page and on the subscription result page. A javascript alert ask you if are certain to do this operation. - Check the serial status "stopped" everywhere the status is displayed (catalogue/detail.pl, serials/claims.pl, serials/serial-issues-full.pl, serials/serials-collection.pl, serials/serials-edit.pl, serials/serials-recieve.pl, serials/subscription-detail.pl and opac-full-serial-issues.pl) - The report statistics does not include the closed subscriptions if you don't check the "Include expired subscriptions" checkbox. /!\ This patch is based onto Bug 5357 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 14:43:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 12:43:01 +0000 Subject: [Koha-bugs] [Bug 8782] Close a suscription In-Reply-To: <bug-8782-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8782-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8782-70-8xLXmjiBVQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8782 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 14:52:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 12:52:02 +0000 Subject: [Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view In-Reply-To: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8597-70-t4jm4ZhHhw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #60 from Paul Poulain <paul.poulain at biblibre.com> --- OK, patch pushed ! Here is what I plan to add to the next RM newsletter. This enhancement is very important, and must be announced as widely as possible. ========================== Bug 8597 New theme for OPAC with mobile view This patch is *very* important. Koha is now shipped with a specific stylesheet for mobile devices. It means that your patrons using your catalogue with their smartphone will get a simplified OPAC, with all important features, but adapted to their small screen. To turn this ON : * go to your systempreferences * search "opacthemes" and switch to CCSR * search "opaccolorstylesheet" and enter "colors.css" * reload your opac home page. Don't forget to clear your cache - shift-reload on Firefox - Note that, if you activate this feature: * you'll have to update your own stylesheet if you have one. * there are still some minor glitches (for example, if you use "Quote Of The Day" feature, with a "long" quote), that will be fixed ASAP. Overall, this enhancement is worth the glitches, that's why I've pushed it. =========================== QA comment: I'd like to have a follow-up merging opac.css and colors.css in ccsr template : currently, we're loading 2 very large CSS files, with a lot of properties that could be in only one. Once both files are merged, the opaccolorstylesheet will be freed again for localuses. Plus, what is in colors.css is mandatory, and the systempreference description let librarians think it is not. Also note that if you don't change anything to opacthemes and opaccolorstylesheet, everything still works as previously. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 14:53:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 12:53:24 +0000 Subject: [Koha-bugs] [Bug 7483] A more detailed breadcrumb for authority management In-Reply-To: <bug-7483-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7483-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7483-70-HM3cPLHL6k@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7483 --- Comment #1 from Adrien SAURAT <adrien.saurat at biblibre.com> --- Created attachment 12306 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12306&action=edit proposed patch Test plan : Simply follow all possible links in the Authorities administration module. It should always be possible to use the breadcrumb to access the previous page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 14:53:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 12:53:31 +0000 Subject: [Koha-bugs] [Bug 7483] A more detailed breadcrumb for authority management In-Reply-To: <bug-7483-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7483-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7483-70-GqDDN7sRUi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7483 Adrien SAURAT <adrien.saurat at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 14:58:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 12:58:35 +0000 Subject: [Koha-bugs] [Bug 8784] New: Missing files in debian.packages list Message-ID: <bug-8784-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8784 Priority: P5 - low Change sponsored?: --- Bug ID: 8784 Assignee: gmcharlt at gmail.com Summary: Missing files in debian.packages list Severity: minor Classification: Unclassified OS: All Reporter: mtompset at hotmail.com Hardware: All Status: NEW Version: unspecified Component: Installation and upgrade (command-line installer) Product: Koha Based on the output of koha_perl_deps.pl, several things need updating in install_misc/debian.packages for a simpler git installation. Testing would involve a fresh git install, and doing: sudo apt-get install dselect sudo dpkg --set-selections < install_misc/debian.packages sudo dselect I, C, R, and then Q. ./koha_perl_deps.pl -m -u Noticeable list apply patch sudo dpkg --set-selections < install_misc/debian.packages sudo dselect I, C, R, and then Q. ./koha_perl_deps.pl -m -u All the required items should be installed. DateTime::TimeZone may still be listed, but that's because of a min_ver problem, not a missing problem. This helps people first starting with a git set up to not have to figure out where to get missing required libraries. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 15:04:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 13:04:58 +0000 Subject: [Koha-bugs] [Bug 8784] Missing files in debian.packages list In-Reply-To: <bug-8784-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8784-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8784-70-We8hQI19aN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8784 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |mtompset at hotmail.com --- Comment #1 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 12307 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12307&action=edit Added missing dependencies into debian.packages list This applies to master. 3.8.x I believe already added the libtest-unaccented-perl which may or may not cause this patch to failed for 3.8.x. However, something similar needs to be done for 3.8.x as well, if it doesn't apply to 3.8.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 15:05:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 13:05:34 +0000 Subject: [Koha-bugs] [Bug 8782] Close a suscription In-Reply-To: <bug-8782-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8782-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8782-70-qKn6VBYvn5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8782 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Jonathan, thank you for providing the description. I was wondering about the new status "stopped". I was thinking that closig a subscription would happen on subscription level. In which circumstances would I mark an issue as "stopped"? Or did I misunderstand the new status? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 15:08:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 13:08:49 +0000 Subject: [Koha-bugs] [Bug 5888] opac-detail subject/author links improvements In-Reply-To: <bug-5888-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5888-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5888-70-75CCyuiOl3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5888 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11592|0 |1 is obsolete| | --- Comment #25 from Mason James <mtj at kohaaloha.com> --- Created attachment 12308 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12308&action=edit Bug 5888: opac-detail subject/author links improvements When the user clicks on a subject or an author, the list of subjects (authors) is displayed and the user can choose more than 1 subject (author) to search on. Only affects 'Normal view'. Does not affect XSLT display. Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com> Split out of the original patch for bug 5888. The links to the authority records are added by bug 8210. Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 15:10:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 13:10:20 +0000 Subject: [Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view In-Reply-To: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8597-70-vQGCnRMW82@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 15:19:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 13:19:17 +0000 Subject: [Koha-bugs] [Bug 8429] Unnecessary use of Exporter in SIP/ILS objects In-Reply-To: <bug-8429-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8429-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8429-70-HX5B4hSMrz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8429 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |paul.poulain at biblibre.com --- Comment #4 from Paul Poulain <paul.poulain at biblibre.com> --- Sorry colin, but I just pushed bug 8336 (from you), and this one does not apply anymore. Should not be hard to fix: CONFLICT (content): Merge conflict in C4/SIP/ILS/Transaction/RenewAll.pm Auto-merging C4/SIP/ILS/Transaction/Renew.pm CONFLICT (content): Merge conflict in C4/SIP/ILS/Transaction/Renew.pm Failed to merge in the changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 15:26:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 13:26:28 +0000 Subject: [Koha-bugs] [Bug 8785] New: Basic authentication troubleshootings Message-ID: <bug-8785-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8785 Priority: P5 - low Change sponsored?: --- Bug ID: 8785 CC: dpavlin at rot13.org Assignee: gmcharlt at gmail.com Summary: Basic authentication troubleshootings Severity: normal Classification: Unclassified OS: All Reporter: matthias.meusburger at biblibre.com Hardware: All Status: NEW Version: master Component: Authentication Product: Koha I've ran several tests with basic http authentication in koha, and here's what I found: When using basic http authentication at OPAC, if the loggedin username does not match a valid koha user, that leads to a session with borrowernumber 0. When using basic http authentication at Intranet, if the loggedin username does not match a valid koha user, that also leads to a session with borrowernumber 0. At the top-right of the screen, I can see "insecure" in bold black. However, my "insecure" syspref is set to 0. Is this behavior normal? Steps to reproduce: To use basic http authentication at OPAC, create a .htaccess and a .htpasswd file in the 'opac' directory. To use basic http authentication at Intranet, create a .htaccess and a .htpasswd file at the root of the source directory (don't forget to backup the existing .htaccess) In order to easily generate .htaccess and .htpasswd, you can use the following tools: http://www.htaccesstools.com/htaccess-authentication/ http://www.htaccesstools.com/htpasswd-generator/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 15:32:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 13:32:12 +0000 Subject: [Koha-bugs] [Bug 8112] Overdues with Fines report, giving duplicates In-Reply-To: <bug-8112-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8112-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8112-70-xXo6RHJ7tu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8112 --- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to comment #15) > (In reply to comment #12) > > Is it normal the followup changes only 1 query ? > > I think the problem exists in the 2 cases. But I have not tested ! > > oops, i missed Jonathans comment > > Kyle, any response for only the 1 query change, not 2? Janathan is right. Good catch! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 15:32:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 13:32:25 +0000 Subject: [Koha-bugs] [Bug 8112] Overdues with Fines report, giving duplicates In-Reply-To: <bug-8112-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8112-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8112-70-ATdCQG3p9u@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8112 --- Comment #17 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12309 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12309&action=edit Bug 8112 - Overdues with Fines dup Followup 2 - Add items.itemnumber to GROUP BY when using $location -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 15:32:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 13:32:50 +0000 Subject: [Koha-bugs] [Bug 8112] Overdues with Fines report, giving duplicates In-Reply-To: <bug-8112-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8112-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8112-70-NuDT59kbcS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8112 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 15:33:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 13:33:59 +0000 Subject: [Koha-bugs] [Bug 8688] Add a recall button to the biblio record details page. In-Reply-To: <bug-8688-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8688-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8688-70-ucZxfS5UNM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8688 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11913|Add a recall button to the |[SIGNED-OFF] Add a recall description|biblio record details page. |button to the biblio record | |details page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 15:34:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 13:34:10 +0000 Subject: [Koha-bugs] [Bug 8688] Add a recall button to the biblio record details page. In-Reply-To: <bug-8688-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8688-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8688-70-fozGXx5W3w@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8688 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11914|Add a default RECALL notice |[SIGNED-OFF] Add a default description|to the database |RECALL notice to the | |database -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 15:38:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 13:38:43 +0000 Subject: [Koha-bugs] [Bug 8782] Close a suscription In-Reply-To: <bug-8782-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8782-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8782-70-1ufM1Sr143@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8782 --- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to comment #2) > Hi Jonathan, > > thank you for providing the description. I was wondering about the new > status "stopped". I was thinking that closig a subscription would happen on > subscription level. In which circumstances would I mark an issue as > "stopped"? Or did I misunderstand the new status? An issue could not be marked as 'stopped'. This status is not writable/settable. The only way to have a status=8 (for serials.status) is to close the subscription and to have a serial expected. If the subscription is closed, the serial cannot be expected. I don't know if I'm clear :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 15:38:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 13:38:51 +0000 Subject: [Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly. In-Reply-To: <bug-8220-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8220-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8220-70-6xUilTjOnC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11350|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12310 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12310&action=edit Bug 8220 - Allow koc uploads to go to process queue instead of being applied directly. The primary advantage to the Firefox offline cirulation plugin when compared to the offline circulation desktop application, is the ability to add offline circulation actions to a queue so that multiple machines running offline circ can have their circ actions combined and ordered chronologically before being executed. This commit adds the ability to put actions from uploaded KOC files into this queue. In this way, both the FF plugina and the desktop application can be run side by side with no ill effects. Signed-off-by: Bob Birchall <bob at calyx.net.au> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 15:39:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 13:39:04 +0000 Subject: [Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly. In-Reply-To: <bug-8220-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8220-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8220-70-ruKroGxp9x@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 15:49:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 13:49:18 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: <bug-7167-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7167-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7167-70-NwC1ubGUQP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 Pierre Angot <tredok.pierre at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tredok.pierre at gmail.com --- Comment #155 from Pierre Angot <tredok.pierre at gmail.com> --- @Paul : can I test this patch on Sandbox ? You've said "Start from a clean situation", so I'm wondering ^^ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 16:04:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 14:04:08 +0000 Subject: [Koha-bugs] [Bug 8702] System preferences search does not allow accented letters In-Reply-To: <bug-8702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8702-70-BAEhHqKICo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8702 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11923|0 |1 is obsolete| | --- Comment #6 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> --- Created attachment 12311 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12311&action=edit Proposed patch (rebased master) Rebased patch. Previous patch applying failed because one of the files it modified is deleted now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 16:04:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 14:04:58 +0000 Subject: [Koha-bugs] [Bug 8702] System preferences search does not allow accented letters In-Reply-To: <bug-8702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8702-70-i5CsKo17gQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8702 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 16:14:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 14:14:18 +0000 Subject: [Koha-bugs] [Bug 5888] opac-detail subject/author links improvements In-Reply-To: <bug-5888-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5888-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5888-70-hZNBwicyMJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5888 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com --- Comment #26 from Mason James <mtj at kohaaloha.com> --- > Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> patch looks good, passing QA? $ koha-qa.pl testing 1 commit(s) (applied to commit c74b72b) * e5b58d3 Bug 5888: opac-detail subject/author links improvements koha-tmpl/opac-tmpl/prog/en/css/opac.css koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt * koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 16:15:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 14:15:12 +0000 Subject: [Koha-bugs] [Bug 8652] There is no default value for the late orders In-Reply-To: <bug-8652-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8652-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8652-70-rAASxhEadv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8652 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.poulain at biblibre.com --- Comment #7 from Paul Poulain <paul.poulain at biblibre.com> --- Patch tested with a sandbox, by MathildeF <mathilde.formery at ville-nimes.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 16:15:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 14:15:29 +0000 Subject: [Koha-bugs] [Bug 8652] There is no default value for the late orders In-Reply-To: <bug-8652-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8652-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8652-70-nFHpg7MKNO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8652 --- Comment #8 from Paul Poulain <paul.poulain at biblibre.com> --- Created attachment 12312 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12312&action=edit Bug 8652: Followup: add a default value for date_from This patchis add a third parameter to the output_pref routine. It allows to specify the output string with or without the hours and minutes (%H:%M) Signed-off-by: MathildeF <mathilde.formery at ville-nimes.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 16:24:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 14:24:22 +0000 Subject: [Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view In-Reply-To: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8597-70-JWBDIK35RH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597 --- Comment #61 from Owen Leonard <oleonard at myacpl.org> --- This new template references assets which don't exist in this template directory: "NetworkError: 404 Not Found - http://localhost:88/opac-tmpl/ccsr/en/lib/jquery/jquery-ui.css" "NetworkError: 404 Not Found - http://localhost:88/opac-tmpl/ccsr/en/lib/jquery/plugins/jquery.hoverIntent.minified.js" "NetworkError: 404 Not Found - http://localhost:88/opac-tmpl/ccsr/en/lib/jquery/jquery.js" "NetworkError: 404 Not Found - http://localhost:88/opac-tmpl/ccsr/en/lib/jquery/jquery-ui.js" "NetworkError: 404 Not Found - http://localhost:88/opac-tmpl/ccsr/en/lib/yui/skin.css" "NetworkError: 404 Not Found - http://localhost:88/opac-tmpl/ccsr/en/lib/yui/reset-fonts-grids.css" Was it expected that Koha would fall back on these items in the prog director? Including these errors about missing assets I get 15 errors in Firebug--the rest being caused by the absence of jQuery. masthead.inc has non-English text: <p><a href="/cgi-bin/koha/opac-main.pl" title="Accueil"> Accueil </a> [% IF ( searchdesc ) %]<span class="rsaquo"> › </span><a href="/cgi-bin/koha/opac-search.pl" title="rechercher"> Recherche </a><span class="rsaquo"> › </span> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 16:24:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 14:24:53 +0000 Subject: [Koha-bugs] [Bug 6689] Improve styling of table pager In-Reply-To: <bug-6689-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6689-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6689-70-HuEzfEZZ7x@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6689 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com QA Contact|koha-bugs at lists.koha-commun |mtj at kohaaloha.com |ity.org | --- Comment #7 from Mason James <mtj at kohaaloha.com> --- passing QA, trivial patch... -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 16:29:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 14:29:47 +0000 Subject: [Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view In-Reply-To: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8597-70-Nn4Qo2jznh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597 --- Comment #62 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- (In reply to comment #61) > This new template references assets which don't exist in this template > directory: > > "NetworkError: 404 Not Found - > http://localhost:88/opac-tmpl/ccsr/en/lib/jquery/jquery-ui.css" > "NetworkError: 404 Not Found - > http://localhost:88/opac-tmpl/ccsr/en/lib/jquery/plugins/jquery.hoverIntent. > minified.js" > "NetworkError: 404 Not Found - > http://localhost:88/opac-tmpl/ccsr/en/lib/jquery/jquery.js" > "NetworkError: 404 Not Found - > http://localhost:88/opac-tmpl/ccsr/en/lib/jquery/jquery-ui.js" > "NetworkError: 404 Not Found - > http://localhost:88/opac-tmpl/ccsr/en/lib/yui/skin.css" > "NetworkError: 404 Not Found - > http://localhost:88/opac-tmpl/ccsr/en/lib/yui/reset-fonts-grids.css" > > Was it expected that Koha would fall back on these items in the prog > director? No, those files were added by one of the patches. "Add missing lib files." I will check when I am able whether that patch was included when this bug was pushed to master. > Including these errors about missing assets I get 15 errors in Firebug--the > rest being caused by the absence of jQuery. > > masthead.inc has non-English text: > > <p><a href="/cgi-bin/koha/opac-main.pl" title="Accueil"> Accueil </a> > [% IF ( searchdesc ) %]<span class="rsaquo"> › </span><a > href="/cgi-bin/koha/opac-search.pl" title="rechercher"> Recherche > </a><span class="rsaquo"> › </span> Whoops, that was just an oversite. I fixed a bunch of French-language strings, but apparently missed those two. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 16:31:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 14:31:50 +0000 Subject: [Koha-bugs] [Bug 8700] RESERVESLIP fields not being replaced correctly In-Reply-To: <bug-8700-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8700-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8700-70-2692vMtpIZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8700 --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> --- Test plan: 1) Edit the slip RESERVESLIP, set it to the following: borrowers.title: <<borrowers.title>> <br/> biblio.copyrightdate: <<biblio.copyrightdate>> <br/> items.replacementprice: <<items.replacementprice>> 2) Place a reserve for a borrower. Make sure that borrower has a borrowers.title value in the database ( I prefer "King of the World" ), as well as biblio.copyrightdate, and items.replacementprice 3) Return the item, confirm hold and print slip. The slip will probably show the *item's* title in borrowers.title. It did for me. The other two will probably by blank. 4) Apply the patch, repeat step 2 and 3, the values should now be correct and accurate. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 16:31:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 14:31:55 +0000 Subject: [Koha-bugs] [Bug 7894] Broken detail page for first link on page 2 from search result page in OPAC In-Reply-To: <bug-7894-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7894-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7894-70-oMOk5LjsVh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7894 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |mjr at software.coop -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 16:32:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 14:32:50 +0000 Subject: [Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view In-Reply-To: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8597-70-ZmLFLHmp2x@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597 --- Comment #63 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Paul, It looks like the last patch did not make it into master. Could you please push it when you get a chance so that the ccsr theme will work? Thanks. Jared -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 17:34:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 15:34:21 +0000 Subject: [Koha-bugs] [Bug 8211] Add "subject (broader), " "subject (narrower), " and "subject (related)" options for search In-Reply-To: <bug-8211-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8211-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8211-70-kxOUy1GeNH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8211 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_10 --- Comment #8 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master I had some trouble making this patch work, but, at the end, if your datas are OK and your zebra index uptodate, this patch works like a charm in UNIMARC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 17:36:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 15:36:24 +0000 Subject: [Koha-bugs] [Bug 7455] Authority subfields are cloned in the wrong field In-Reply-To: <bug-7455-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7455-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7455-70-X4cQ9Q4yOd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8332 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 17:36:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 15:36:24 +0000 Subject: [Koha-bugs] [Bug 8332] Add relationships to auth_finder for authority links In-Reply-To: <bug-8332-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8332-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8332-70-wwV9Ss6Ij5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8332 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7455 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 17:38:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 15:38:28 +0000 Subject: [Koha-bugs] [Bug 7455] Authority subfields are cloned in the wrong field In-Reply-To: <bug-7455-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7455-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7455-70-tkvdxWZsWO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11908|0 |1 is obsolete| | --- Comment #30 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> --- Created attachment 12313 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12313&action=edit Proposed patch (rebased master) Main patch rebased master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 17:39:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 15:39:42 +0000 Subject: [Koha-bugs] [Bug 7455] Authority subfields are cloned in the wrong field In-Reply-To: <bug-7455-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7455-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7455-70-TcqyMdItEp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12216|0 |1 is obsolete| | --- Comment #31 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> --- Created attachment 12314 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12314&action=edit Proposed patch (follow-up 1) (rebased master) First follow-up rebased master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 17:44:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 15:44:13 +0000 Subject: [Koha-bugs] [Bug 7455] Authority subfields are cloned in the wrong field In-Reply-To: <bug-7455-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7455-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7455-70-FaVNFxalGO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 --- Comment #32 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> --- Created attachment 12315 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12315&action=edit Proposed patch (follow-up 2) After rebase of main patch, I noticed that bug 8332 has introduced a behavior I had to manage. So here is second follow-up. Note : 8332 introduces a source='auth' parameter in openAuth() js function only when called from authorities.tt. Since I moved this method into cataloguing.js to be mutualized between authorities et bilios edition, I added a source argument in this method. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 17:45:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 15:45:34 +0000 Subject: [Koha-bugs] [Bug 8210] Headings in OPAC bib details should link to authority record In-Reply-To: <bug-8210-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8210-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8210-70-qUVxJvzCKh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8210 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_10 --- Comment #12 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master I don't understand why you say: Because UNIMARC handles authorities differently, the link is not added to the XSLT. In UNIMARC, the $9 also contains the authority. The templates <xsl:template name="tag_7xx"> and <xsl:call-template name="tag_subject"> in UNIMARCslimUtils.xsl could be used for that unless I'm missing something. Your opinion ? (& follow-up welcomed ;-) ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 17:45:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 15:45:44 +0000 Subject: [Koha-bugs] [Bug 8033] add print receipt option to Koha self-check In-Reply-To: <bug-8033-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8033-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8033-70-dvCc8Tjlzi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Elliott Davis <elliott at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10678|0 |1 is obsolete| | Attachment #11112|0 |1 is obsolete| | --- Comment #16 from Elliott Davis <elliott at bywatersolutions.com> --- Created attachment 12316 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12316&action=edit Bug 8033 : This patch adds print slips to self checkout. To Test: Sign in to self checkout. Enter a barcode and click submit. Click the finish button You should be prompted with a message asking if you would like a receipt. If you click OK you should be taken to the page with the receipt. If you click Cancel you should not see the reciept and you should be logged out. http://bugs.koha-community.org/show_bug.cgi?id=8033 Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> Added copyright to print slip for SCO Modified POD and copyright. Also perltidied http://bugs.koha-community.org/show_bug.cgi?id=8033 updated print slip option to show on the click of the finish button instead of the submit button -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 17:51:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 15:51:36 +0000 Subject: [Koha-bugs] [Bug 7455] Authority subfields are cloned in the wrong field In-Reply-To: <bug-7455-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7455-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7455-70-cJEaSSlxZg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #33 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> --- Please signoff follow-up 2 patch. Simply check that the thesaurus popup contains a relationship section only when editing an authority, not when editing a biblio. See Bug 8332. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 17:53:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 15:53:15 +0000 Subject: [Koha-bugs] [Bug 5079] Make display of shelving location and call number in XSLT results controlled by sysprefs In-Reply-To: <bug-5079-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5079-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5079-70-E3XizD9koY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5079 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10929|0 |1 is obsolete| | --- Comment #44 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12317 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12317&action=edit Bug 5079 - Make display of shelving location and call number in XSLT results controlled by sysprefs * Don't show the Location line if there are no copies available, since it will inevitably be blank * Also, don't show locations for Checked Out, Lost, Damaged, Withdrawn, On Hold or In transit items; it doesn't really make sense, since the items aren't actually there, and it results in repetitive listing of the shelving location * Added system preference to display shelving location of an item on opac results. The system preference is called OpacItemLocation. I also moved the call number to a new line called Location along with the shelving location if it is enabled. To Test: 1) Run database update script to add syspref. 2) Set OpacItemLocation to show locations or collection codes on the opac-search page. If it is working you should see the shelving location of the item before the call number. Multiple home branch shelving locations are seperated by a pipe character ( i.e. '|' ). Based on code by Elliot Davis <tdavis at uttyler.edu> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 17:54:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 15:54:13 +0000 Subject: [Koha-bugs] [Bug 5079] Make display of shelving location and call number in XSLT results controlled by sysprefs In-Reply-To: <bug-5079-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5079-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5079-70-VJAZhtvtTZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5079 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 18:16:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 16:16:14 +0000 Subject: [Koha-bugs] [Bug 8772] Uninitialized variable triggers error log entry in smart_rules.pl In-Reply-To: <bug-8772-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8772-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8772-70-ItgTakWK1r@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8772 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |mtompset at hotmail.com |ity.org | --- Comment #1 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 12318 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12318&action=edit Added "|| q{}" into variable declaration/initialization Pretty simple to test. Follow the test plan above. Just clicking a link triggers the error log entries without the patch. This bug applies to 3.6.x, 3.8.x, and master. This patch is against master. Let me know if it doesn't apply back to 3.6.x or 3.8.x, and I'll post up a patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 18:21:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 16:21:24 +0000 Subject: [Koha-bugs] [Bug 7993] saved report with hierarchies In-Reply-To: <bug-7993-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7993-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7993-70-SkIaY0UlaQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7993 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 --- Comment #21 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master However, a few questions/glitches: * the "type" and "Area" columns can't be filled when you edit an SQL directly, and can't be updated anyway. Shouldn't we do something for that ? * Shouldn't group/sub-group be the first columns ? * do we need the ID displayed ? * on my laptop, the "Notes" tab is really small, and would not deserve be larger (we could put subgroup in the same column as group, because it will not be used everyday * why are author column and date not sortable ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 18:26:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 16:26:56 +0000 Subject: [Koha-bugs] [Bug 8780] Lower dependency version for DateTime::TimeZone In-Reply-To: <bug-8780-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8780-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8780-70-hVpGYOneAZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8780 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #2 from Marc V?ron <veron at veron.ch> --- Not fully tested, but with an existing Koha installation (master) I do not longer have a warning regarding DateTime::TimeZone (orange color) on the about page's Perl tab. Not enough to sign off, I'm afraid. Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 18:44:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 16:44:23 +0000 Subject: [Koha-bugs] [Bug 8302] Add accesssion number to the drop down list in OPAC Search. In-Reply-To: <bug-8302-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8302-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8302-70-QTxWBd7XeM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8302 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12163|0 |1 is obsolete| | --- Comment #5 from Marc V?ron <veron at veron.ch> --- Created attachment 12319 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12319&action=edit [SIGNED-OFF] Bug 8302 - Add accesssion number(barcode) to the drop down list in OPAC Search. Files Modified: i)koha-tmpl/opac-tmpl/prog/en/includes/masthead.inc: Test cases: i)select Barcode in drop down list and enter a exist barcode, check the results. ii)select Barcode in drop down list and enter a non-exist barcode, check the results. Signed-off-by: Marc Veron <veron at veron.ch> Works as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 18:44:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 16:44:49 +0000 Subject: [Koha-bugs] [Bug 8302] Add accesssion number to the drop down list in OPAC Search. In-Reply-To: <bug-8302-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8302-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8302-70-jrrZN02EkW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8302 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 18:54:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 16:54:07 +0000 Subject: [Koha-bugs] [Bug 8302] Add accesssion number to the drop down list in OPAC Search. In-Reply-To: <bug-8302-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8302-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8302-70-y7tyYIfJdS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8302 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #6 from Owen Leonard <oleonard at myacpl.org> --- Discussion of this and Bug 8778: http://lists.koha-community.org/pipermail/koha-devel/2012-September/038042.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 18:54:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 16:54:33 +0000 Subject: [Koha-bugs] [Bug 8778] Add "Phrase" Searching to OPAC Search In-Reply-To: <bug-8778-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8778-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8778-70-NnGyYtnexU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8778 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Discussion of this and Bug 8302: http://lists.koha-community.org/pipermail/koha-devel/2012-September/038042.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 20:06:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 18:06:02 +0000 Subject: [Koha-bugs] [Bug 8772] Uninitialized variable triggers error log entry in smart_rules.pl In-Reply-To: <bug-8772-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8772-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8772-70-0AQBs3nm3o@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8772 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12318|0 |1 is obsolete| | --- Comment #2 from Marc V?ron <veron at veron.ch> --- Created attachment 12320 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12320&action=edit [SIGNED-OFF] Bug 8772 - Uninitialized variable triggers error log entry in smart_rules.pl Changed declartion from: my $op = $input->param('op'); to my $op = $input->param('op') || q{}; in order to give an empty string default preventing error logs from filling needlessly. Signed-off-by: Marc Veron <veron at veron.ch> The patch removes warnings like: Use of uninitialized value $op in string eq at... However there is one more warning, but it is not related to $op (addressed by this patch): smart-rules.pl: Use of uninitialized value in string ne at .../admin/smart-rules.pl line 388. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 20:06:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 18:06:32 +0000 Subject: [Koha-bugs] [Bug 8772] Uninitialized variable triggers error log entry in smart_rules.pl In-Reply-To: <bug-8772-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8772-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8772-70-rEfFgLuZwt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8772 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 20:20:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 18:20:05 +0000 Subject: [Koha-bugs] [Bug 2930] Put other name on checkout screen In-Reply-To: <bug-2930-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2930-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2930-70-ZNvzJSad53@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2930 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12021|0 |1 is obsolete| | --- Comment #6 from Marc V?ron <veron at veron.ch> --- Created attachment 12321 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12321&action=edit [SIGNED-OFF] Bug 2930 [REVISED] Put other name on checkout screen This patch adds other name to the include which is used to display patron names and adds this include in several places where it can be used in place of direct output. The patron-title include has been modified to handle the two possible variable scopes throughout patron-related templates. This is a hack similar to having both circ-menu.tt and circ-menu.inc, but keeping both in the same file. Changes to some scripts were necessary to make the othernames variable available to the include. This patch also corrects some <title> tags and fixes some incorrect capitalization (see Bug 2780). To test, view each of the pages affected by these template changes and confirm that the patron's name displays correctly, including their "other name." Signed-off-by: Marc Veron <veron at veron.ch> Followed instructions above, works as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 20:20:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 18:20:33 +0000 Subject: [Koha-bugs] [Bug 2930] Put other name on checkout screen In-Reply-To: <bug-2930-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2930-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2930-70-1eJdaYt2cB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2930 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 21:12:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 19:12:41 +0000 Subject: [Koha-bugs] [Bug 7751] Decrease loan period on items with a high number of holds In-Reply-To: <bug-7751-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7751-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7751-70-9wR2KVCY9F@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 --- Comment #31 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master There was a conflict in C4/Circulation.pm, with bug 6151 (AllowToReturnBranch syspref that added a sub that was at the same place) and 7621 (Age Restriction) I fixed the conflict, tested circulation was working well. I was surprised to see no updatedatabase.pl, when I realised it was not needed : if they are not defined, there is no value, the feature is not enabled. Entering values in preference.pl create them (I've checked) Colin = was it intended or a mistake with a nice effect ? Isn't there a typo in the syspref description: "A loan should be reduced by decreaseLoanHighHoldsDuration when holds have been places (if decreaseLoanHighHolds is enables)" shouldn't it be "have been placed" and "is enabled" ? (as Colin is english native, I feel less authoritative on this as he is ;-) ) (not enought to reject the patch though, so it's pushed ;-) ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 21:43:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 19:43:33 +0000 Subject: [Koha-bugs] [Bug 7751] Decrease loan period on items with a high number of holds In-Reply-To: <bug-7751-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7751-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7751-70-HMWIcHCRmM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 --- Comment #32 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hm, can we maybe get a follow-up with the database update and system preferences? I like it better because it's more consistent, the scripts will pick up the new sys prefs for the release notes, people will see them in the update database and the syspref sql file will be a complete reference too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 21:53:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 19:53:00 +0000 Subject: [Koha-bugs] [Bug 7751] Decrease loan period on items with a high number of holds In-Reply-To: <bug-7751-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7751-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7751-70-rdPYBLWTD2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 --- Comment #33 from Chris Cormack <chris at bigballofwax.co.nz> --- I concur. Having them for release notes and in the message for the update means users know it's there. Saving our time is always secondary to saving the users time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 22:13:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 20:13:44 +0000 Subject: [Koha-bugs] [Bug 8523] Authority hierarchies only support UNIMARC In-Reply-To: <bug-8523-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8523-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8523-70-oI3apLKDau@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 --- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- This is a very cool feature *nudge* -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 22:17:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 20:17:48 +0000 Subject: [Koha-bugs] [Bug 6945] Add a link to show a MARC preview in the normal view In-Reply-To: <bug-6945-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6945-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6945-70-JcFpNypVEj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6945 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #23 from Paul Poulain <paul.poulain at biblibre.com> --- Trying to apply patch & follow-up, I get a git problem with the 2nd patch: Applying: Bug 6945 [FOLLOW-UP] Add a link to show a MARC preview in the normal view fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 22:25:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 20:25:03 +0000 Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix In-Reply-To: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5786-70-NiFmHMExRi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #57 from Paul Poulain <paul.poulain at biblibre.com> --- Sorry srdjan, but the patch does not apply anymore, there's a conflict on CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tt that is not easy to solve. Reminder = the Feature Freeze for 3.10 is in a few days. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 22:34:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 20:34:19 +0000 Subject: [Koha-bugs] [Bug 8786] New: problem with print overdue notices Message-ID: <bug-8786-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8786 Priority: P5 - low Change sponsored?: --- Bug ID: 8786 Assignee: koha-bugs at lists.koha-community.org Summary: problem with print overdue notices Severity: critical Classification: Unclassified OS: All Reporter: melia at bywatersolutions.com Hardware: All Status: NEW Version: rel_3_8 Component: Notices Product: Koha We are seeing some bogus overdue email messages. I have had complaints about the print overdue notices which are sent to the library when a patron does not have an email address. Here is an example of an email sent to the library on 9/16: --------------- Dear PROBLEM, The item below is now 6 weeks overdue. Please return it, or call or email the library if there is a problem. In another 4 weeks, you will receive a bill. "The hobbit" by Tolkien, J. R. R "The girl who played with fire" by Larsson, Stieg "Emily and Einstein" by Lee, Linda Francis Thank you. Staff --------------- The items listed in this email are all overdue, but none of them are 6 weeks overdue and do not warrant receipt of the 2nd overdue notice. The due dates for each item are: 8/31 - "The hobbit" by Tolkien, J. R. R 8/31 - "The girl who played with fire" by Larsson, Stieg 9/15 - "Emily and Einstein" by Lee, Linda Francis The notice triggers say that this 2nd overdue notice should be sent at 42 days, but none of these items are 42 days overdue yet. I also checked the cron job for overdues.pl. It looks like this: # OVERDUE NOTICES 0 7 * * * $KOHA_CRON_PATH/overdue_notices.pl -t -itemscontent title,author,itemcallnumber,barcode,replacementprice The manual says: -t | --triggered This option causes a notice to be generated if and only if an item is overdue by the number of days defined in a notice trigger. I don't think this is working as expected. I am marking this as critical since bogus overdue email messages are being generated. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 22:36:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 20:36:02 +0000 Subject: [Koha-bugs] [Bug 8786] problem with print overdue notices In-Reply-To: <bug-8786-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8786-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8786-70-Mla0yeLOHb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8786 --- Comment #1 from Melia Meggs <melia at bywatersolutions.com> --- Also, the notice is using <item></item> tags and not <<items.content>> (I wouldn't expect that to make any difference, but just noting it here in case it helps!) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 22:39:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 20:39:39 +0000 Subject: [Koha-bugs] [Bug 5357] Subscription search and displays In-Reply-To: <bug-5357-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5357-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5357-70-mJyPGDZeSF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5357 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 --- Comment #27 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 22:48:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 20:48:06 +0000 Subject: [Koha-bugs] [Bug 7572] Add Clubs & Services Feature In-Reply-To: <bug-7572-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7572-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7572-70-obZgirhq5t@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #24 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Kyle, I have read through the code and there are some issues with this patch: 1) Can you please add the new permisson for all languages? English is ok - easier to add a translation than figuring out a missing permission. 2) Some of the perl files have strict, but not warnings, can you add use Modern::Perl? 3) The Templates don't follow the capitalization rules. Examples: Start Date End Date You Are Not Enrolled In Any Clubs Or Services 4) This will not work for other languages, as noted in some of the earlier comments: $sth = $dbh->prepare("SELECT * FROM clubsAndServicesArchetypes WHERE title LIKE 'Bestsellers Club' "); Also: +# This script utilizes the 'New Items E-mail List' archetype +# from the ClubsAndServices.pm module. +# If you do not have this archtype, create an archetype of that name 5) If I read the code correctly, this is another translation problem, adding a hardcoded note to the hold: + my $notes = "Automatic Reserve for Bestsellers Club", 6) I wonder about the error messages - from reading the code I am not totally sure but I think they are also not translatable. + <div>Reason: <strong>[% failureMessage %]</strong></div> 7) Could you add documenation to the database tables? I was wondering about the line: + `casaId` int(11) NOT NULL default '0' COMMENT 'foreign key to clubsAndServicesArchetypes', - not sure if COMMENT is a mysqlism. We had some discussion about following the standard in one of the IRC meetings and agreed on using -- comment in the end. But I don't remember exactly why. 8) Another translation issue is the preset data you add in kohastructure.sql. Also adding data to the tables is normally done by separate sql files, while kohastructure is only creating the table structure without any data. +-- Preset data for ClubsAndServicesArchetypes +-- + +INSERT INTO `clubsAndServicesArchetypes`... 9) There is a conflict marker in updatedatabase.pl and the version should be set to be XXX. +<<<<<<< HEAD $DBversion = "3.09.00.005"; 10) There is some untranslatable JavaScript too. Example: + alert("Title is a required field"); + alert("Description is a required field"); 11) There is a large block of code commented out. Maybe delete it, if it's not needed? +<!-- These messages are uneccessary because you can see if it was deleted or created immediately... Also some typos in there 'Archtype'. 12) It looks like the old calendar is being used? Not sure here. + <img src="/intranet-tmpl/prog/en/lib/calendar/cal.gif" alt="Show Calendar" border="0" id="CalendarStartDate" style="cursor: pointer;" /> 13) Ok, now I found something really big :( The doc states: HTML::Template file mailinglist.tmpl Also: +use HTML::Template::Pro; And then: +++ b/misc/cronjobs/mailinglist/mailinglist.tmpl This needs to be redone to use TT. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 22:57:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 20:57:21 +0000 Subject: [Koha-bugs] [Bug 7919] Display of values depending on the connexion library In-Reply-To: <bug-7919-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7919-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7919-70-QeLhckHVmI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|rel_3_8 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 18 22:59:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 18 Sep 2012 20:59:39 +0000 Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix In-Reply-To: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5786-70-4JAfzVqWtI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 --- Comment #58 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I would love to see this go in, as it will enable a better configuration for libraries with closed stacks. Hoping it will make the deadline. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 02:18:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 00:18:40 +0000 Subject: [Koha-bugs] [Bug 8034] Enable server print queue selection In-Reply-To: <bug-8034-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8034-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8034-70-c8UF2dWaZm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8034 Srdjan Jankovic <srdjan at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12161|0 |1 is obsolete| | --- Comment #25 from Srdjan Jankovic <srdjan at catalyst.net.nz> --- Created attachment 12322 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12322&action=edit bug_5786, bug_5787, bug_5788: Holds rewrite bug_5786: moved AllowOnShelfHolds to issuingrules bug_5787: moved OPACItemHolds to issuingrules bug_5788: Added reservesmaxpickupdelay to issuingrules C4::Reserves: * Added OnShelfHoldsAllowed() to check issuingrules * Added OPACItemHoldsAllowed() to check issuingrules * IsAvailableForItemLevelRequest() changed interface, now takes $item_record,$borrower_record; calls OnShelfHoldsAllowed() opac/opac-reserve.pl and opac/opac-search.pl: * rewrote hold allowed rule to use OPACItemHoldsAllowed() * also use OnShelfHoldsAllowed() through * IsAvailableForItemLevelRequest() templates: * Removed AllowOnShelfHolds and OPACItemHolds global flags, they now only have meaning per item type Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com> I have tested this patch left, right and upside down for the last several months. All tests have passed. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 02:20:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 00:20:21 +0000 Subject: [Koha-bugs] [Bug 8034] Enable server print queue selection In-Reply-To: <bug-8034-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8034-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8034-70-BrD2lozNWr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8034 Srdjan Jankovic <srdjan at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12161|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 02:22:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 00:22:08 +0000 Subject: [Koha-bugs] [Bug 8034] Enable server print queue selection In-Reply-To: <bug-8034-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8034-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8034-70-l7ZdVXh7rR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8034 Srdjan Jankovic <srdjan at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12322|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 02:22:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 00:22:47 +0000 Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix In-Reply-To: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5786-70-H0VzEchJtc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 Srdjan Jankovic <srdjan at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11992|0 |1 is obsolete| | --- Comment #59 from Srdjan Jankovic <srdjan at catalyst.net.nz> --- Created attachment 12323 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12323&action=edit bug_5786, bug_5787, bug_5788: Holds rewrite bug_5786: moved AllowOnShelfHolds to issuingrules bug_5787: moved OPACItemHolds to issuingrules bug_5788: Added reservesmaxpickupdelay to issuingrules C4::Reserves: * Added OnShelfHoldsAllowed() to check issuingrules * Added OPACItemHoldsAllowed() to check issuingrules * IsAvailableForItemLevelRequest() changed interface, now takes $item_record,$borrower_record; calls OnShelfHoldsAllowed() opac/opac-reserve.pl and opac/opac-search.pl: * rewrote hold allowed rule to use OPACItemHoldsAllowed() * also use OnShelfHoldsAllowed() through * IsAvailableForItemLevelRequest() templates: * Removed AllowOnShelfHolds and OPACItemHolds global flags, they now only have meaning per item type Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com> I have tested this patch left, right and upside down for the last several months. All tests have passed. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> http://bugs.koha-community.org/show_bug.cgi?id=8034 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 02:24:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 00:24:36 +0000 Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix In-Reply-To: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5786-70-yAcWYAHFpG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 Srdjan Jankovic <srdjan at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #60 from Srdjan Jankovic <srdjan at catalyst.net.nz> --- I'm making it Signed Off. Functionality should not be changed, there's a small possibility of HTML issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 04:43:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 02:43:49 +0000 Subject: [Koha-bugs] [Bug 7690] hidelostitems not working in Normal Display In-Reply-To: <bug-7690-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7690-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7690-70-5e37559lIw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7690 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #9 from Chris Cormack <chris at bigballofwax.co.nz> --- Template change, but no string changes, pushing to 3.8.x will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 04:45:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 02:45:00 +0000 Subject: [Koha-bugs] [Bug 8727] Correct help text in rebuild_zebra_sliced.sh In-Reply-To: <bug-8727-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8727-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8727-70-tzW8yKCWTp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8727 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris at bigballofwax.co.nz> --- Pushed to 3.8.x will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 04:47:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 02:47:22 +0000 Subject: [Koha-bugs] [Bug 8713] Warning message triggered by clicking keyword to marc mapping. In-Reply-To: <bug-8713-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8713-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8713-70-02Yvk7kRKl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8713 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris at bigballofwax.co.nz> --- Tiny patch to silence some warns, pushed to 3.8.x will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 04:50:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 02:50:57 +0000 Subject: [Koha-bugs] [Bug 8765] Add series title to intranet search results In-Reply-To: <bug-8765-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8765-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8765-70-WinRZ9cgYv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8765 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris at bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 04:55:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 02:55:58 +0000 Subject: [Koha-bugs] [Bug 8336] SIP Server does not process renewal transaction correctly In-Reply-To: <bug-8336-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8336-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8336-70-GHSx7LjCRo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8336 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Chris Cormack <chris at bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 04:59:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 02:59:09 +0000 Subject: [Koha-bugs] [Bug 8275] xml parsing error when the webservice GetPatronInfo/show_loans is called In-Reply-To: <bug-8275-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8275-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8275-70-bMHdomfHeE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8275 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Chris Cormack <chris at bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 05:06:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 03:06:11 +0000 Subject: [Koha-bugs] [Bug 3782] delivered z39.50 targets wrong for NY Public Library and NY University Library In-Reply-To: <bug-3782-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3782-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3782-70-NAWhJ7F6VN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3782 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #17 from Chris Cormack <chris at bigballofwax.co.nz> --- Pushed to 3.8.x will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 05:07:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 03:07:44 +0000 Subject: [Koha-bugs] [Bug 8717] Wrong subscription notes are showing in catalogue detail view of serials in staff client In-Reply-To: <bug-8717-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8717-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8717-70-db6aXLCYiM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8717 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #9 from Chris Cormack <chris at bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 05:13:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 03:13:13 +0000 Subject: [Koha-bugs] [Bug 7751] Decrease loan period on items with a high number of holds In-Reply-To: <bug-7751-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7751-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7751-70-CRcx8m2e8I@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 --- Comment #34 from Chris Cormack <chris at bigballofwax.co.nz> --- Jenkins will also keep complaining (as would the unit tests if run locally) that the sysprefs don't match. So can we please get a follow up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 05:21:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 03:21:13 +0000 Subject: [Koha-bugs] [Bug 8709] Subfield 0 does not show in MARC detail in intranet In-Reply-To: <bug-8709-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8709-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8709-70-LHgRejgEh0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8709 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #5 from Chris Cormack <chris at bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 05:22:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 03:22:07 +0000 Subject: [Koha-bugs] [Bug 8757] Longer size text for authorised values "lib" In-Reply-To: <bug-8757-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8757-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8757-70-pFH4Cs2htn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8757 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_8 |rel_3_10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 06:33:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 04:33:15 +0000 Subject: [Koha-bugs] [Bug 8702] System preferences search does not allow accented letters In-Reply-To: <bug-8702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8702-70-eQgC4uwWLq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8702 wajasu <matted-34813 at mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12311|0 |1 is obsolete| | --- Comment #7 from wajasu <matted-34813 at mypacks.net> --- Created attachment 12324 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12324&action=edit SIGNED-OFF-Bug-8702-System-preferences-search-accented-sysprefs So i wouldn't need to switch to another language, I tested this way: 1) In my kohadev environment I changed: ./koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/tools.pref to have J?rgen at the end of displayed text for the ExportWithCsvProfile syspref. Tools: - - pref: ExportWithCsvProfile - CSV profile for export J?rgen 2) I used the admin syspref search, specifying "J?rgen" Result: not found. Plus I got an info message saying not found with "Jrgen" 3) applied patch 4) did the same search, and now I found the syspref with J?rgen. 5) I also searched for something I should not find ?xxx and I got an info message which showed the ? Great work! wajasu Note: I took a stray "2" typo out of the original patch. Now folks with accents/diacritics in syspref text will match. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 06:33:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 04:33:30 +0000 Subject: [Koha-bugs] [Bug 8702] System preferences search does not allow accented letters In-Reply-To: <bug-8702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8702-70-2hXKaFAlS9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8702 wajasu <matted-34813 at mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 06:57:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 04:57:24 +0000 Subject: [Koha-bugs] [Bug 8780] Lower dependency version for DateTime::TimeZone In-Reply-To: <bug-8780-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8780-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8780-70-WERhTiWPNc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8780 wajasu <matted-34813 at mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12299|0 |1 is obsolete| | --- Comment #3 from wajasu <matted-34813 at mypacks.net> --- Created attachment 12325 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12325&action=edit SIGNED-OFF-Bug-8780-Lower-dependency-version-for-DateTime-TimeZone I've been dropping the version back for squeeze for two months now(Jul/Aug/Sept 2012), or all my dev and standard installs. No significant difference that I've seen. Thanks mtompset! One less diversion or hangup for folks. wajasu Note: It would be nice if it gets on 3.8.x and master for 3.10. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 07:06:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 05:06:04 +0000 Subject: [Koha-bugs] [Bug 8300] Koha should have mechanized testing suite In-Reply-To: <bug-8300-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8300-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8300-70-JgKKOATTgs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8300 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #11 from Mason James <mtj at kohaaloha.com> --- > > To test: > 1. Install Test::WWW::Mechanize > > sudo apt-get install libtest-www-mechanize-perl can we get a follow-up patch to add www-mech as a dependancy package? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 07:19:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 05:19:00 +0000 Subject: [Koha-bugs] [Bug 4420] umlauts or diacritics in subject of notices are deleted In-Reply-To: <bug-4420-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4420-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4420-70-tMHwyupc41@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4420 wajasu <matted-34813 at mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matted-34813 at mypacks.net --- Comment #1 from wajasu <matted-34813 at mypacks.net> --- bug 6130 might have addressed this, maybe even 8378 might have addressed it. when I did bug 8378 for overdue_notices.pl <fine> syntax broken. When I was in the code in Letters.pm, to NFC normalize the body or text, i notices my attachments still showed mojibake in the inline attachemnt being shown in my email client. I found that I needed charset='utf-8' in the header to let the email client know how to decode. I also put charset='utf-8' for the filename attachments themselves with the future possibility that they contain utf8 chars. So just making a note of this here so if someone tests notices that have such chars in the Subject header, 8378 might have addressed it. Next someone is testing notices with email, try putting diacritics in the Message subject: and see if its ok. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 07:27:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 05:27:59 +0000 Subject: [Koha-bugs] [Bug 8780] Lower dependency version for DateTime::TimeZone In-Reply-To: <bug-8780-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8780-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8780-70-GnxdrPA8HX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8780 wajasu <matted-34813 at mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |matted-34813 at mypacks.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 07:36:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 05:36:18 +0000 Subject: [Koha-bugs] [Bug 8415] Link Serial with Acquisition In-Reply-To: <bug-8415-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8415-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8415-70-0U06y5xAN4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8415 --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Update: bug 5357 has been pushed now - retesting this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 08:16:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 06:16:17 +0000 Subject: [Koha-bugs] [Bug 8415] Link Serial with Acquisition In-Reply-To: <bug-8415-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8415-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8415-70-rDqVrXACdr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8415 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11833|0 |1 is obsolete| | Attachment #11834|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 12326 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12326&action=edit [SIGNED-OFF] Bug 8415 - Link Serial with Acquisition To Test: 1) Create a basket. 2) Click on From a Subscription link under Add order to basket section. 3) A filter box appear on the left hand side (Search by ISSN, Title, Publisher, Supplier) 4) Search a subscription and click on order to add the order on the basket. 5) If already subscription add to the basket it shows "only one order per subscription is allowed". Signed-off-by: Amit Gupta <amit.gupta at osslabs.biz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 08:16:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 06:16:29 +0000 Subject: [Koha-bugs] [Bug 8415] Link Serial with Acquisition In-Reply-To: <bug-8415-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8415-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8415-70-tenTAmQXB8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8415 --- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 12327 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12327&action=edit Bug 8415: Follow up - Fixing some smaller issues 1) Changes the updatedatabase to be a bit more precise and always add the new field after claimed_date, like it is in kohastructure.sql. 2) Fixes capitalization rules for the new link to create a serial order. 3) Hides EAN search field when marcflavour is not UNIMARC. 4) Adds documentation for the new column in kohastructure.sql 5) Fixes some terms * Branch to Library * Search for Serial Routing Lists to Search for serial subscriptions 6) Deletes doubled up SearchSubscriptions from Search.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 08:21:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 06:21:11 +0000 Subject: [Koha-bugs] [Bug 8415] Link Serial with Acquisition In-Reply-To: <bug-8415-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8415-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8415-70-6bNv5C9Bti@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8415 --- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- These 2 patches can not stand alone - the functionality on neworderempty is missing to make it possible to create an order without being forced to create items. Looking into this now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 08:42:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 06:42:17 +0000 Subject: [Koha-bugs] [Bug 8456] Capture the invoice number, price, date of a subscription In-Reply-To: <bug-8456-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8456-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8456-70-OMZeXyfjpI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8456 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Patch applies and I started testing it. What irritates me is the fact that it allows to enter a quantity >1. At the moment for each copy of a serial we have to add 1 subscription in the serials module. So to me it seems like an order linked to a subscription should only allow to order 1 copy of the serial. It's not ideal that we have this 1:1 relationship between copies and subscriptions at the moment, but while it's still the case it would probably be better to reflect it in acq? Or is there a workflow I am missing? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 08:43:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 06:43:07 +0000 Subject: [Koha-bugs] [Bug 8456] Capture the invoice number, price, date of a subscription In-Reply-To: <bug-8456-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8456-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8456-70-MgUqwQazeF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8456 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Also it seems that the initial feature from Biblibre solves this differently: http://git.biblibre.com/?p=koha;a=blobdiff;f=koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tmpl;h=e0d802bf0753c71683dda1f595905d11030648b5;hp=8135154960e9e5e2df6eea1c72100462a99941d5;hb=4d3255f90c0845e68904ba835c0bbc3cb289e2ad;hpb=c6d5309fe041567595d3f6144b1c94398135371f -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 09:15:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 07:15:03 +0000 Subject: [Koha-bugs] [Bug 8749] Missing Ubuntu library files in ubuntu.packages and ubuntu.12.04.packages In-Reply-To: <bug-8749-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8749-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8749-70-hznZZlqEED@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8749 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|INVALID |--- --- Comment #2 from M. Tompsett <mtompset at hotmail.com> --- DOH! wrong git branch. Bug exists in master and 3.8.x only. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 09:19:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 07:19:02 +0000 Subject: [Koha-bugs] [Bug 8749] Missing Ubuntu library files in ubuntu.packages and ubuntu.12.04.packages In-Reply-To: <bug-8749-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8749-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8749-70-veVLm5qaDf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8749 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff Assignee|gmcharlt at gmail.com |mtompset at hotmail.com --- Comment #3 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 12328 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12328&action=edit Added missing libtemplate-plugin-htmltotext to ubuntu.*.packages files Adds missing required library. Keeps the installation steps simpler. :) This is for master. Does not apply against 3.8.x, patch to follow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 09:20:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 07:20:47 +0000 Subject: [Koha-bugs] [Bug 8749] Missing Ubuntu library files in ubuntu.packages and ubuntu.12.04.packages In-Reply-To: <bug-8749-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8749-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8749-70-9dOfadEn6f@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8749 --- Comment #4 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 12329 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12329&action=edit Added missing libtemplate-plugin-htmltotext to ubuntu.*.packages files (3.8.x) Added missing libtemplate-plugin-htmltotext-perl library into the ubuntu.*.packages files. This is for 3.8.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 09:34:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 07:34:29 +0000 Subject: [Koha-bugs] [Bug 8787] New: If OpacMaintenance is on the requested page is loaded Message-ID: <bug-8787-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8787 Priority: P5 - low Change sponsored?: --- Bug ID: 8787 CC: dpavlin at rot13.org Assignee: gmcharlt at gmail.com Summary: If OpacMaintenance is on the requested page is loaded Severity: enhancement Classification: Unclassified OS: All Reporter: jonathan.druart at biblibre.com Hardware: All Status: NEW Version: unspecified Component: Authentication Product: Koha If the system preference OpacMaintenance is ON, the user is redirected to the maintenance.pl page but the requested page is executed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 09:34:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 07:34:36 +0000 Subject: [Koha-bugs] [Bug 8787] If OpacMaintenance is on the requested page is loaded In-Reply-To: <bug-8787-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8787-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8787-70-gZMXZSp6fF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8787 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 10:01:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 08:01:19 +0000 Subject: [Koha-bugs] [Bug 8787] If OpacMaintenance is on the requested page is loaded In-Reply-To: <bug-8787-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8787-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8787-70-BQ9k4xda7j@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8787 --- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 12330 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12330&action=edit But 8787: don't load the page if OpacMaintenance is ON If the syspref OpacMaintenance is ON, it is useless to loaded the requested page. To test: - switch on the syspref OpacMaintenace - check in your apache access log, zebra log, etc. the requested page is not loaded (i.e. on the opac-search.pl page) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 10:01:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 08:01:39 +0000 Subject: [Koha-bugs] [Bug 8787] If OpacMaintenance is on the requested page is loaded In-Reply-To: <bug-8787-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8787-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8787-70-6yU8OAQzGG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8787 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 10:13:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 08:13:57 +0000 Subject: [Koha-bugs] [Bug 2930] Put other name on checkout screen In-Reply-To: <bug-2930-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2930-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2930-70-x385Uzq5Fm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2930 --- Comment #7 from Jonathan Druart <jonathan.druart at biblibre.com> --- Hi Owen, Is it normal that your last patch uses the include file in only 1 tt file? I think your first proposed patch was more interesting, it used the include in several places instead of just one. What problem did you encounter? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 10:35:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 08:35:11 +0000 Subject: [Koha-bugs] [Bug 8788] New: Entry of an acquistion from an external source triggers error log entries Message-ID: <bug-8788-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8788 Priority: P5 - low Change sponsored?: --- Bug ID: 8788 Assignee: koha-bugs at lists.koha-community.org Summary: Entry of an acquistion from an external source triggers error log entries Severity: minor Classification: Unclassified OS: All Reporter: mtompset at hotmail.com Hardware: All Status: NEW Version: unspecified Component: Acquisitions Product: Koha [Wed Sep 19 14:38:07 2012] [error] [client 192.168.100.2] [Wed Sep 19 14:38:07 2012] basket.pl: Use of uninitialized value $total_est_gste in sprintf at /usr/share/koha/intranet/cgi-bin/acqui/basket.pl line 370., referer: https://.../cgi-bin/koha/acqui/booksellers.pl [Wed Sep 19 14:38:07 2012] [error] [client 192.168.100.2] [Wed Sep 19 14:38:07 2012] basket.pl: Use of uninitialized value $total_est_gste in sprintf at /usr/share/koha/intranet/cgi-bin/acqui/basket.pl line 370., referer: https://.../cgi-bin/koha/acqui/booksellers.pl [Wed Sep 19 14:38:07 2012] [error] [client 192.168.100.2] [Wed Sep 19 14:38:07 2012] basket.pl: Use of uninitialized value $gist_est in sprintf at /usr/share/koha/intranet/cgi-bin/acqui/basket.pl line 370., referer: https://.../cgi-bin/koha/acqui/booksellers.pl [Wed Sep 19 14:38:07 2012] [error] [client 192.168.100.2] [Wed Sep 19 14:38:07 2012] basket.pl: Use of uninitialized value $gist_est in sprintf at /usr/share/koha/intranet/cgi-bin/acqui/basket.pl line 370., referer: https://.../cgi-bin/koha/acqui/booksellers.pl [Wed Sep 19 14:38:42 2012] [error] [client 192.168.100.2] [Wed Sep 19 14:38:42 2012] basket.pl: Use of uninitialized value $total_est_gste in sprintf at /usr/share/koha/intranet/cgi-bin/acqui/basket.pl line 370., referer: https://.../cgi-bin/koha/acqui/booksellers.pl [Wed Sep 19 14:38:42 2012] [error] [client 192.168.100.2] [Wed Sep 19 14:38:42 2012] basket.pl: Use of uninitialized value $total_est_gste in sprintf at /usr/share/koha/intranet/cgi-bin/acqui/basket.pl line 370., referer: https://.../cgi-bin/koha/acqui/booksellers.pl [Wed Sep 19 14:38:42 2012] [error] [client 192.168.100.2] [Wed Sep 19 14:38:42 2012] basket.pl: Use of uninitialized value $gist_est in sprintf at /usr/share/koha/intranet/cgi-bin/acqui/basket.pl line 370., referer: https://.../cgi-bin/koha/acqui/booksellers.pl [Wed Sep 19 14:38:42 2012] [error] [client 192.168.100.2] [Wed Sep 19 14:38:42 2012] basket.pl: Use of uninitialized value $gist_est in sprintf at /usr/share/koha/intranet/cgi-bin/acqui/basket.pl line 370., referer: https://.../cgi-bin/koha/acqui/booksellers.pl Looking at the template file: total_rrp_gste, total_est_gste, gist_rate, gist_rrp, and gist_est are only used if GST (which is $gist) is set. The solution I took was to move these variables to a separate $template->param() call based on "if $gist;". I found this bug in 3.6.3, it exists in 3.8.4 too. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 10:37:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 08:37:14 +0000 Subject: [Koha-bugs] [Bug 8789] New: Fix wording of framework import dialog Message-ID: <bug-8789-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8789 Priority: P5 - low Change sponsored?: --- Bug ID: 8789 CC: gmcharlt at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: Fix wording of framework import dialog Severity: trivial Classification: Unclassified OS: All Reporter: magnus at enger.priv.no Hardware: All Status: NEW Version: master Component: Staff Client Product: Koha When you import a framework in Home ? Administration ? MARC frameworks, a popup dialog with this text is displayed before you get to do the actual import: "Do you really want to import the framework fields/subfields (will overwrite current configuration, for safety reasons please make before an export to have a backup file)?" This could benefit from some proofreading. :-) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 10:44:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 08:44:10 +0000 Subject: [Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup In-Reply-To: <bug-8773-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8773-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8773-70-uQBCPYAXvC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773 Robin Sheat <robin at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 10:46:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 08:46:29 +0000 Subject: [Koha-bugs] [Bug 8789] Fix wording of framework import dialog In-Reply-To: <bug-8789-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8789-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8789-70-faoIZPgLoK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8789 Magnus Enger <magnus at enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Magnus Enger <magnus at enger.priv.no> --- *** This bug has been marked as a duplicate of bug 8558 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 10:46:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 08:46:29 +0000 Subject: [Koha-bugs] [Bug 8558] Better confirmation message for importing frameworks In-Reply-To: <bug-8558-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8558-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8558-70-csUbV42kcL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8558 Magnus Enger <magnus at enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no --- Comment #1 from Magnus Enger <magnus at enger.priv.no> --- *** Bug 8789 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 10:47:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 08:47:03 +0000 Subject: [Koha-bugs] [Bug 8558] Better confirmation message for importing frameworks In-Reply-To: <bug-8558-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8558-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8558-70-FrcxqWj1do@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8558 --- Comment #2 from Magnus Enger <magnus at enger.priv.no> --- At the moment, the message is: "Do you really want to import the framework fields/subfields (will overwrite current configuration, for safety reasons please make before an export to have a backup file)?" This could probably benefit from some proofreading too. :-) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 10:54:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 08:54:38 +0000 Subject: [Koha-bugs] [Bug 8615] XSLT on OPAC is broken for incomplete 6xx fields In-Reply-To: <bug-8615-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8615-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8615-70-oDL65Xqdve@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8615 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8513 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 10:54:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 08:54:38 +0000 Subject: [Koha-bugs] [Bug 8513] OPAC detail page broken with XSLT In-Reply-To: <bug-8513-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8513-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8513-70-LjaUDV3H8D@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8513 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8615 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 10:58:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 08:58:59 +0000 Subject: [Koha-bugs] [Bug 8615] XSLT on OPAC is broken for incomplete 6xx fields In-Reply-To: <bug-8615-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8615-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8615-70-IKvQ2sKSMQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8615 --- Comment #1 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> --- Is this a duplicate of 8513 ? Or same problem ? Is this for all MARC flavors ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 11:05:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 09:05:07 +0000 Subject: [Koha-bugs] [Bug 8615] XSLT on OPAC is broken for incomplete 6xx fields In-Reply-To: <bug-8615-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8615-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8615-70-NFDTA5gSwo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8615 --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- The problem can occur in other places too. The problem was the empty link text breaking the HTML display. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 11:19:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 09:19:27 +0000 Subject: [Koha-bugs] [Bug 5339] Parcel closing in acq In-Reply-To: <bug-5339-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5339-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5339-70-MbzrhMOOd4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 --- Comment #81 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master The patch has been pushed, but the Unit Tests are expected soon. Another ergonomic follow-up would also be cool: I think librarians will be confused by having a button "Finish Recieve" (at the bottom of the page) and another link (at the top of the page) to reach invoice information and "close it". I suggest that we have only one button "Finish Reciev" at the bottom, that reaches invoices.pl page. On the "invoices.pl" page, it would also be better to be able to enter values and close the invoice in 1 step (2 required now : modify + click save THEN click "close" link just below. You can do like for basketgroup: just before the "save button", add a checkbox [] close invoice -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 11:20:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 09:20:33 +0000 Subject: [Koha-bugs] [Bug 8788] Viewing basket for acquisitions triggers error log entries. In-Reply-To: <bug-8788-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8788-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8788-70-YvXagvOSMn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8788 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Entry of an acquistion from |Viewing basket for |an external source triggers |acquisitions triggers error |error log entries |log entries. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 11:24:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 09:24:19 +0000 Subject: [Koha-bugs] [Bug 8790] New: Search result return "No results found" in both OPAC and Patron sides Message-ID: <bug-8790-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8790 Priority: P5 - low Change sponsored?: --- Bug ID: 8790 Assignee: gmcharlt at gmail.com Summary: Search result return "No results found" in both OPAC and Patron sides Severity: major Classification: Unclassified OS: All Reporter: abdirizaq at gmail.com Hardware: All Status: NEW Version: rel_3_8 Component: Searching Product: Koha Created attachment 12331 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12331&action=edit Search error shown on the lower part of the image and the actual items shown in the upper part of the image. We have been having a problem with the Koha search function for a while and previously it was resolved by a simple restart but now even that has not been able to resolve this. When a search is carried out on both the OPAC and the administration area, it returns "No results found" although the item exists. Also we had issues with the Zebra indexing since it could not automatically rebuild once an item is catalogued but that we have resolved to doing it manually using "sudo /usr/share/koha/bin/migration_tools/rebuild_zebra.pl -b -r -v" This has helped us populate the databases and the items are shown on the Inventory/Stocktaking area since the search is not functional at the moment. I have attached the screenshots of the error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 11:25:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 09:25:17 +0000 Subject: [Koha-bugs] [Bug 8790] Search result return "No results found" in both OPAC and Patron sides In-Reply-To: <bug-8790-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8790-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8790-70-YM7IKwiv4D@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8790 abdi <abdirizaq at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 11:42:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 09:42:35 +0000 Subject: [Koha-bugs] [Bug 7294] status "in order" In-Reply-To: <bug-7294-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7294-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7294-70-Px2qeu0ud2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Matthias Meusburger <matthias.meusburger at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12302|0 |1 is obsolete| | --- Comment #41 from Matthias Meusburger <matthias.meusburger at biblibre.com> --- Created attachment 12332 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12332&action=edit Bug 7294: Adds acquisition informations in marc record "View status 'in order' to the OPAC and staff interface. Specific fields from aqorders can be mapped to marc fields (using ACQ bibliographic framework): aqorders.branchcode aqorders.quantity aqorders.listprice aqorders.uncertainprice aqorders.rrp aqorders.ecost aqorders.notes aqorders.supplierreference aqorders.ordernumber This way, you can keep track on what is currently on order at biblio level until you receive everything. Once all items have been received, the marc field is deleted. Please note that mapping the ordernumber is mandatory for this feature to work Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 11:43:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 09:43:09 +0000 Subject: [Koha-bugs] [Bug 8791] New: OPAC UNIMARC XSLT details : subject with subfield 3 Message-ID: <bug-8791-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8791 Priority: P5 - low Change sponsored?: --- Bug ID: 8791 Assignee: oleonard at myacpl.org Summary: OPAC UNIMARC XSLT details : subject with subfield 3 Severity: normal Classification: Unclassified OS: All Reporter: fridolyn.somers at biblibre.com Hardware: All Status: NEW Version: master Component: OPAC Product: Koha On OPAC details page with XSLT, when a subject field has $3, $9 and other subfields, $9 is displayed instead of other subfields. Example : <datafield tag="606" ind1=" " ind2=" "> <subfield code="9">331978</subfield> <subfield code="3">027214724</subfield> <subfield code="a">Revolution</subfield> </datafield> This comes from UNIMARCslimUtils.xsl tag_onesubject template : Subfields $2 and $3 stops the display variable computing. Without XSLT, subjects are displayed with only non-numerical subfields [a-zA-Z]. So $2 and $3 should just be avoid in display var. Example should be displayed : <a href="/cgi-bin/koha/opac-search.pl?q=an:331978">Revolution</a> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 11:43:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 09:43:15 +0000 Subject: [Koha-bugs] [Bug 7294] status "in order" In-Reply-To: <bug-7294-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7294-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7294-70-vLAfODbYvT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Matthias Meusburger <matthias.meusburger at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #42 from Matthias Meusburger <matthias.meusburger at biblibre.com> --- This new patch fixes TT validation issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 11:45:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 09:45:47 +0000 Subject: [Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view In-Reply-To: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8597-70-4CPfN0AeLh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597 --- Comment #64 from Paul Poulain <paul.poulain at biblibre.com> --- (In reply to comment #63) > Paul, > > It looks like the last patch did not make it into master. Could you please > push it when you get a chance so that the ccsr theme will work? Last patch pushed, I don't know what I made to miss that ! (probably because those patches have duplicate encoding UTF-8 header, so I had to apply them one by one after removing the duplicate line. (In reply to comment #61) > masthead.inc has non-English text: > > <p><a href="/cgi-bin/koha/opac-main.pl" title="Accueil"> Accueil </a> > [% IF ( searchdesc ) %]<span class="rsaquo"> › </span><a > href="/cgi-bin/koha/opac-search.pl" title="rechercher"> Recherche > </a><span class="rsaquo"> › </span> Yikes ! As I speak french, there are some french data (like LibraryName, OpacNav,...) so I didn't spotted those french strings in the middle of english ;-) I've pushed a fix for that too -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 11:46:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 09:46:17 +0000 Subject: [Koha-bugs] [Bug 8429] Unnecessary use of Exporter in SIP/ILS objects In-Reply-To: <bug-8429-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8429-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8429-70-R1Vn2c0qxP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8429 Colin Campbell <colin.campbell at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11685|0 |1 is obsolete| | --- Comment #5 from Colin Campbell <colin.campbell at ptfs-europe.com> --- Created attachment 12333 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12333&action=edit Patch rebased against current head Rebased against current head basically the use parent in two files now replaces the use base added by a patch to the renew functionality. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 11:46:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 09:46:25 +0000 Subject: [Koha-bugs] [Bug 8791] OPAC UNIMARC XSLT details : subject with subfield 3 In-Reply-To: <bug-8791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8791-70-4oNlcXO0T2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8791 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard at myacpl.org |fridolyn.somers at biblibre.co | |m --- Comment #1 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> --- Created attachment 12334 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12334&action=edit Proposed patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 11:46:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 09:46:38 +0000 Subject: [Koha-bugs] [Bug 8429] Unnecessary use of Exporter in SIP/ILS objects In-Reply-To: <bug-8429-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8429-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8429-70-JFHRkkzAve@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8429 Colin Campbell <colin.campbell at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 11:47:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 09:47:26 +0000 Subject: [Koha-bugs] [Bug 8791] OPAC UNIMARC XSLT details : subject with subfield 3 In-Reply-To: <bug-8791-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8791-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8791-70-5TljT9R76X@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8791 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6314 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 11:47:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 09:47:26 +0000 Subject: [Koha-bugs] [Bug 6314] UNIMARC OPAC XSL improvements In-Reply-To: <bug-6314-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6314-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6314-70-MlPNOKcyl4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6314 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8791 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 11:51:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 09:51:38 +0000 Subject: [Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view In-Reply-To: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8597-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8597-70-zdteLZNWAI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597 --- Comment #65 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Wondering if we have to teach the translation scripts about the new theme? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 11:54:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 09:54:12 +0000 Subject: [Koha-bugs] [Bug 8615] XSLT on OPAC is broken for incomplete 6xx fields In-Reply-To: <bug-8615-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8615-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8615-70-Cd2aRuiMUt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8615 --- Comment #3 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> --- What about Bug 8678 ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 12:02:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 10:02:10 +0000 Subject: [Koha-bugs] [Bug 6835] Ability to specify types of email address in overdue_notices.pl In-Reply-To: <bug-6835-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6835-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6835-70-8pGKMMNJ2M@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 Matthias Meusburger <matthias.meusburger at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12036|0 |1 is obsolete| | --- Comment #25 from Matthias Meusburger <matthias.meusburger at biblibre.com> --- Created attachment 12335 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12335&action=edit Bug 6835 - Ability to specify types of email address in overdue_notices.pl Adds the -email option to overdue_notices.pl, which is repeatable -email value can be: - 'email' - 'emailpro' or - 'B_email' - perltidy done - in production for a BibLibre customer - validated by the customer Signed-off-by: Claire Hernandez <claire.hernandez at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 12:03:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 10:03:39 +0000 Subject: [Koha-bugs] [Bug 6835] Ability to specify types of email address in overdue_notices.pl In-Reply-To: <bug-6835-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6835-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6835-70-iJM8rTg2J0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 Matthias Meusburger <matthias.meusburger at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #26 from Matthias Meusburger <matthias.meusburger at biblibre.com> --- This new patch fixes the $nomail issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 12:08:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 10:08:24 +0000 Subject: [Koha-bugs] [Bug 6835] Ability to specify types of email address in overdue_notices.pl In-Reply-To: <bug-6835-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6835-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6835-70-HacnaXumQM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 Matthias Meusburger <matthias.meusburger at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12335|0 |1 is obsolete| | --- Comment #27 from Matthias Meusburger <matthias.meusburger at biblibre.com> --- Created attachment 12336 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12336&action=edit Bug 6835 - Ability to specify types of email address in overdue_notices.pl Adds the -email option to overdue_notices.pl, which is repeatable -email value can be: - 'email' - 'emailpro' or - 'B_email' - perltidy done - in production for a BibLibre customer - validated by the customer Signed-off-by: Claire Hernandez <claire.hernandez at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 12:13:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 10:13:27 +0000 Subject: [Koha-bugs] [Bug 7993] saved report with hierarchies In-Reply-To: <bug-7993-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7993-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7993-70-ah4uay4AUw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7993 --- Comment #22 from Paul Poulain <paul.poulain at biblibre.com> --- Jenkins complain because of an incorrect pod doc. I've pushed a follow-up to fix it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 12:14:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 10:14:13 +0000 Subject: [Koha-bugs] [Bug 7751] Decrease loan period on items with a high number of holds In-Reply-To: <bug-7751-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7751-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7751-70-bHMrgzyYDo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 --- Comment #35 from Paul Poulain <paul.poulain at biblibre.com> --- (In reply to comment #34) > Jenkins will also keep complaining (as would the unit tests if run locally) > that the sysprefs don't match. So can we please get a follow up. Follow-up pushed Note that I thought jenkins was doing a fresh install (from kohastructure.sql & sysprefs.sql). Those sysprefs are in the sysprefs.sql file, so I was not understanding what was happening. Now I understand ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 12:16:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 10:16:45 +0000 Subject: [Koha-bugs] [Bug 8615] XSLT on OPAC is broken for incomplete 6xx fields In-Reply-To: <bug-8615-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8615-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8615-70-F8UUUB9Sj8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8615 --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I am not sure and can't test right now :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 12:43:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 10:43:20 +0000 Subject: [Koha-bugs] [Bug 7751] Decrease loan period on items with a high number of holds In-Reply-To: <bug-7751-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7751-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7751-70-oFvWAjJPBv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 --- Comment #36 from Colin Campbell <colin.campbell at ptfs-europe.com> --- Created attachment 12337 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12337&action=edit Supplementary Patch (db update to add sysprefs) Add the missing db update. Also fixed the text which as Paul spotted was written in nonsense rather than English -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 13:03:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 11:03:58 +0000 Subject: [Koha-bugs] [Bug 8788] Viewing basket for acquisitions triggers error log entries. In-Reply-To: <bug-8788-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8788-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8788-70-XgM4W2gz00@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8788 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |mtompset at hotmail.com |ity.org | --- Comment #1 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 12338 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12338&action=edit Added conditional secondary template param call (3.6.x) Testing -------- Set gist=0 (it's a system preference: home->administration->search for gist preference, it's the one about the default tax rate) Login Acquisitions (already had $100 in available funds) Search for vendor (already had "Book Trends" added) View (already had a "basket" added) *BAM* /var/log/koha/... (the intranet error log file) has errors. apply patch Home Acquisitions Search for vendor (used "Book Trends" again) View (the existing basket of course) Check /var/log/koha/... (intranet error log) and there are no new errors. Set gist>0 retest to make sure both if $gist and if !$gist work. Set gist back to what you want it. :) The 3.6.x seemed to need a different patch than master. applies to 3.6.x, 3.8.x, and master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 13:05:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 11:05:10 +0000 Subject: [Koha-bugs] [Bug 8788] Viewing basket for acquisitions triggers error log entries. In-Reply-To: <bug-8788-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8788-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8788-70-uZSCITURdg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8788 --- Comment #2 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 12339 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12339&action=edit Added conditional secondary template param call This should applied to 3.8.x and master. See testing plan above. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 13:51:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 11:51:58 +0000 Subject: [Koha-bugs] [Bug 7751] Decrease loan period on items with a high number of holds In-Reply-To: <bug-7751-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7751-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7751-70-4rnXwBw1Ah@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 --- Comment #37 from Paul Poulain <paul.poulain at biblibre.com> --- (In reply to comment #36) > Created attachment 12337 [details] > Supplementary Patch (db update to add sysprefs) > > Add the missing db update. Also fixed the text which as Paul spotted was > written in nonsense rather than English Sorry Colin, but I beated you (see comment 35) and already have pushed the updatedatabase one. I haven't fixed the string one. Note that, in your string fix: holds have been placed (if decreaseLoanHighHolds is enables) shouldn't we write "(if decreaseLoanHighHolds is enableD)" ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 14:17:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 12:17:07 +0000 Subject: [Koha-bugs] [Bug 8633] Translate script hardcoded to prog template In-Reply-To: <bug-8633-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8633-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8633-70-FDqwOJI14J@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8633 --- Comment #3 from Fr?d?ric Demians <frederic at tamil.fr> --- > misc/translator/translate is hardcoded to translate only prog, when in > fact it should be translating any themes included in Koha. For each template, we would have to create 2 .po files, one per interface, OPAC or professional. Does it make sense to generate .po files for intranet template other than 'prog'? Why would we want to include a second template for intranet interface? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 14:21:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 12:21:28 +0000 Subject: [Koha-bugs] [Bug 8624] famfamfam should be outside theme directory In-Reply-To: <bug-8624-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8624-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8624-70-5LXRdIhl3P@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8624 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |magnus at enger.priv.no --- Comment #17 from Paul Poulain <paul.poulain at biblibre.com> --- (In reply to comment #16) > This patch is OPAC-only. Right, but, even if we speak of intranet files, they contain opac-tmpl links: > koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslim2intranetResults.xsl: > <xsl:when test="$typeOf008='Mon'"><img s > rc="/opac-tmpl/prog/famfamfam/silk/book.png" alt="Bok" title="Bok"/> > Bok</xsl:when> => /opac-tmpl/prog/famfamfam/silk/book.png link that is now wrong Adding Magnus to this bug ! (and back to failed QA) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 14:25:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 12:25:05 +0000 Subject: [Koha-bugs] [Bug 8633] Translate script hardcoded to prog template In-Reply-To: <bug-8633-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8633-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8633-70-CIymZiODfz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8633 --- Comment #4 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- (In reply to comment #3) > > misc/translator/translate is hardcoded to translate only prog, when in > > fact it should be translating any themes included in Koha. > > For each template, we would have to create 2 .po files, one per > interface, OPAC or professional. Does it make sense to generate .po > files for intranet template other than 'prog'? Why would we want to > include a second template for intranet interface? I can't really think of any reason we would want to, to be honest. The change I made to translate the ccsr theme was to add: + ccsr => { + dir => $context->config('opachtdocs') . '/ccsr', + suffix => '-i-opac-t-ccsr-v-3006000.po', + }, in the $self->{interface} definition in new. I am not sure if that is the best way, which is why I defer to you. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 14:28:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 12:28:34 +0000 Subject: [Koha-bugs] [Bug 7401] Shelving Location facet instead of Branch facet when only 1 branch configured In-Reply-To: <bug-7401-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7401-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7401-70-T2Kv6ERYn2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 --- Comment #38 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 14:29:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 12:29:38 +0000 Subject: [Koha-bugs] [Bug 6689] Improve styling of table pager In-Reply-To: <bug-6689-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6689-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6689-70-TghQICaV4a@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6689 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_10 --- Comment #8 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 14:36:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 12:36:09 +0000 Subject: [Koha-bugs] [Bug 5335] More granular VAT In-Reply-To: <bug-5335-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5335-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5335-70-W8VU09s0xu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11662|0 |1 is obsolete| | Attachment #11668|0 |1 is obsolete| | Attachment #11669|0 |1 is obsolete| | --- Comment #45 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 12340 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12340&action=edit Bug 5335 - More granular VAT Rebased patch (conflicts no easy to solved, please test while making QA) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 15:02:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 13:02:02 +0000 Subject: [Koha-bugs] [Bug 8792] New: Babeltheque Message-ID: <bug-8792-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8792 Priority: P5 - low Change sponsored?: --- Bug ID: 8792 Assignee: oleonard at myacpl.org Summary: Babeltheque Severity: enhancement Classification: Unclassified OS: All Reporter: jonathan.druart at biblibre.com Hardware: All Status: NEW Version: unspecified Component: OPAC Product: Koha The babeltheque tab (in the opac detail page) is not used and should be removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 15:02:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 13:02:13 +0000 Subject: [Koha-bugs] [Bug 8792] Babeltheque tab is useless In-Reply-To: <bug-8792-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8792-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8792-70-SJUQLRaz1E@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8792 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Babeltheque |Babeltheque tab is useless -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 15:02:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 13:02:20 +0000 Subject: [Koha-bugs] [Bug 8792] Babeltheque tab is useless In-Reply-To: <bug-8792-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8792-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8792-70-JCabl2J2bL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8792 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard at myacpl.org |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 15:03:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 13:03:15 +0000 Subject: [Koha-bugs] [Bug 5888] opac-detail subject/author links improvements In-Reply-To: <bug-5888-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5888-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5888-70-a4b2YDvvvp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5888 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #27 from Paul Poulain <paul.poulain at biblibre.com> --- QA comment: There is a bug in Author links: if you have, say, 3 authors, and click "All", then the query built is on and an=NNNN and an=MMMM and an=PPPP The initial "on and" is wrong (and comes from the fact that the query is built using the 'All' checked -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 15:04:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 13:04:06 +0000 Subject: [Koha-bugs] [Bug 8792] Babeltheque tab is useless In-Reply-To: <bug-8792-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8792-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8792-70-3G3R7RQsgk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8792 --- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 12341 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12341&action=edit Babeltheque: Remove the unused tab on the opac detail page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 15:07:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 13:07:09 +0000 Subject: [Koha-bugs] [Bug 8792] Babeltheque tab is useless In-Reply-To: <bug-8792-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8792-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8792-70-TpAZm3jzvV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8792 --- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> --- test plan: Switch on the syspref Babeltheque, go to on a biblio detail page (opac) and click on the "Babeltheque" tab. Nothing appends and a warning is raised (Firebug) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 15:07:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 13:07:15 +0000 Subject: [Koha-bugs] [Bug 8792] Babeltheque tab is useless In-Reply-To: <bug-8792-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8792-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8792-70-z0ElEITUdK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8792 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 15:10:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 13:10:18 +0000 Subject: [Koha-bugs] [Bug 2060] Ability to import Authorities from Staff Client In-Reply-To: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2060-70-UCVchhJHl7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2060 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #39 from Paul Poulain <paul.poulain at biblibre.com> --- Sorry, but patch does not apply anymore, and it's a non trivial conflict (for me at least ;-) ) CONFLICT (content): Merge conflict in C4/ImportBatch.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 15:13:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 13:13:42 +0000 Subject: [Koha-bugs] [Bug 8792] Babeltheque tab is useless In-Reply-To: <bug-8792-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8792-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8792-70-8D2aEeJ7oN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8792 --- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> --- s/appends/happens ... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 15:27:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 13:27:35 +0000 Subject: [Koha-bugs] [Bug 8793] New: Remove references to OPAC icons from NORMARC staff XSLT Message-ID: <bug-8793-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8793 Priority: P5 - low Change sponsored?: --- Bug ID: 8793 CC: gmcharlt at gmail.com Assignee: magnus at enger.priv.no Summary: Remove references to OPAC icons from NORMARC staff XSLT Severity: minor Classification: Unclassified OS: All Reporter: magnus at enger.priv.no Hardware: All Status: ASSIGNED Version: master Component: Staff Client Product: Koha This was first pointed out on Bug 8624. NORMARCslim2intranetDetail.xsl: <xsl:element name="img"><xsl:attribute name="src">/opac-tmpl/prog/famfamfam/<xsl:value-of select="$materialTypeCode"/>.png</xsl:attribute><xsl:attribute name="alt"></xsl:attribute></xsl:element> NORMARCslim2intranetResults.xsl: <xsl:when test="$typeOf008='Mon'"><img src="/opac-tmpl/prog/famfamfam/silk/book.png" alt="Bok" title="Bok"/> Bok</xsl:when> <xsl:when test="$typeOf008='Per'"><img src="/opac-tmpl/prog/famfamfam/silk/newspaper.png" alt="Periodika" title="Periodika"/> Periodika</xsl:when> <xsl:when test="$typeOf008='Fil'"><img src="/opac-tmpl/prog/famfamfam/silk/computer_link.png" alt="Fil" title="Fil"/> Fil</xsl:when> <xsl:when test="$typeOf008='Kar'"><img src="/opac-tmpl/prog/famfamfam/silk/map.png" alt="Kart" title="Kart"/> Kart</xsl:when> <xsl:when test="$typeOf008='FV'"><img src="/opac-tmpl/prog/famfamfam/silk/film.png" alt="Film og video" title="Film og video"/> Film og video</xsl:when> <xsl:when test="$typeOf008='Mus'"><img src="/opac-tmpl/prog/famfamfam/silk/sound.png" alt="Musikktrykk og lydopptak" title="Musikktrykk og lydopptak"/> Musikk</xsl:when> MARC21 does not seem to use images like this, so I'll probably just remove them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 15:28:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 13:28:17 +0000 Subject: [Koha-bugs] [Bug 8624] famfamfam should be outside theme directory In-Reply-To: <bug-8624-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8624-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8624-70-WdqNqRmLdW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8624 --- Comment #18 from Magnus Enger <magnus at enger.priv.no> --- Wow, I messed up nicely! But I think the fix for this should be a separate bug, so I have created Bug 8793 - "Remove references to OPAC icons from NORMARC staff XSLT" and will have a fix for it shortly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 15:37:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 13:37:51 +0000 Subject: [Koha-bugs] [Bug 8633] Translate script hardcoded to prog template In-Reply-To: <bug-8633-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8633-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8633-70-EmwFMeJ9Rp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8633 Fr?d?ric Demians <frederic at tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff Assignee|koha-bugs at lists.koha-commun |frederic at tamil.fr |ity.org | --- Comment #5 from Fr?d?ric Demians <frederic at tamil.fr> --- Created attachment 12342 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12342&action=edit Bug 8633 Manage OPAC alternate templates Modify /misc/translator/translate script in order to manage properly alternate OPAC templates. To test it with new 'ccsr' template: - Create the .po file: ./translate create fr-FR Result: existing .po files are not modified. A new fr-FR-opac-ccsr.po file is available. - Install all templates : ./translate install fr-FR Result: A new koha-tmpl/opac-tmpl/ccsr/fr-FR directory contains translated templates. - Update .po files: ./translate update fr-FR Result: fr-FR .po files are update, include fr-FR-opac-ccsr.po -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 15:38:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 13:38:37 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-8QA3Slf1yK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #55 from Paul Poulain <paul.poulain at biblibre.com> --- OK, it could be OK this time. but as I pushed a lot of things recently, there is a conflict in C4/Koha.pm that I'll let you fix. Plus, the follow-ups on updatedatabase.pl won't apply nicely. So, the best option here is that you: * squash all patches in one * then rebase against master * test everything is OK * git bz attach rebased-squashed patch and i'll be able to test & hopefully push ! Note that this feature is not heavily nested in the rest of Koha. So I could push it after the Feature Freeze, as there is only a side effect. ( But I would also be OK to push before the FF if you rebase quickly ;-) ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 15:40:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 13:40:14 +0000 Subject: [Koha-bugs] [Bug 8164] Replace IFNULL() with COALESCE() in all database calls In-Reply-To: <bug-8164-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8164-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8164-70-otgJ3xaX11@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8164 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 15:40:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 13:40:35 +0000 Subject: [Koha-bugs] [Bug 8624] famfamfam should be outside theme directory In-Reply-To: <bug-8624-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8624-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8624-70-BIaqa2hqjU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8624 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #19 from Paul Poulain <paul.poulain at biblibre.com> --- OK, this one is passing QA then, i'll push it now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 15:40:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 13:40:49 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: <bug-5349-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5349-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5349-70-f9LKdISyfe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #35 from Marc V?ron <veron at veron.ch> --- First patch does not apply. Applying: Bug 5349: Order line transfers /usr/share/kohaclone/.git/rebase-apply/patch:109: new blank line at EOF. + error: patch failed: installer/data/mysql/updatedatabase.pl:5781 error: installer/data/mysql/updatedatabase.pl: patch does not apply error: patch failed: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt:241 error: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt: patch does not apply Patch failed at 0001 Bug 5349: Order line transfers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 15:41:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 13:41:40 +0000 Subject: [Koha-bugs] [Bug 8624] famfamfam should be outside theme directory In-Reply-To: <bug-8624-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8624-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8624-70-qT2R3fgQko@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8624 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 --- Comment #20 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master (suggesting keeping it for 3.10 in case we've missed something) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 15:44:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 13:44:52 +0000 Subject: [Koha-bugs] [Bug 7421] UNIMARC authorities DOM indexing mode In-Reply-To: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7421-70-JBp46CiZtM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7421 --- Comment #10 from Fr?d?ric Demians <frederic at tamil.fr> --- It works for me, but I'm not sure to understand what's wrong with your installation. Is it an update or a new installation? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 15:47:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 13:47:15 +0000 Subject: [Koha-bugs] [Bug 5888] opac-detail subject/author links improvements In-Reply-To: <bug-5888-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5888-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5888-70-X6en8nL6X1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5888 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12308|0 |1 is obsolete| | --- Comment #28 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 12343 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12343&action=edit Bug 5888: opac-detail subject/author links improvements Rebased on master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 15:47:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 13:47:52 +0000 Subject: [Koha-bugs] [Bug 5888] opac-detail subject/author links improvements In-Reply-To: <bug-5888-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5888-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5888-70-3XGvigZDwL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5888 --- Comment #29 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 12344 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12344&action=edit Bug 5888: Fix building of query in authors links 'all' checkbox was taken into account, resulting in the string 'on and' added to beginning of query. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 15:48:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 13:48:18 +0000 Subject: [Koha-bugs] [Bug 5888] opac-detail subject/author links improvements In-Reply-To: <bug-5888-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5888-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5888-70-aAc27NDGU4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5888 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12343|Bug 5888: opac-detail |[SIGNED-OFF] Bug 5888: description|subject/author links |opac-detail subject/author |improvements |links improvements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 15:48:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 13:48:25 +0000 Subject: [Koha-bugs] [Bug 5888] opac-detail subject/author links improvements In-Reply-To: <bug-5888-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5888-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5888-70-L4a3kvRxKv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5888 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 15:54:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 13:54:13 +0000 Subject: [Koha-bugs] [Bug 7751] Decrease loan period on items with a high number of holds In-Reply-To: <bug-7751-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7751-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7751-70-7ExWoNP7Mk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Colin Campbell <colin.campbell at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12337|0 |1 is obsolete| | --- Comment #38 from Colin Campbell <colin.campbell at ptfs-europe.com> --- Created attachment 12345 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12345&action=edit Supplemental tidy-up patch Trivial tidy up of the typos - All credit to Paul's proofreading -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 15:58:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 13:58:28 +0000 Subject: [Koha-bugs] [Bug 8606] Talking Tech broken by user-configurable slips feature In-Reply-To: <bug-8606-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8606-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8606-70-AC7uCMPsTO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8606 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> --- QA Comments: No side effect possible. I don't tested the patch but it seems good. No blocker: * C4/Letters.pm FAIL forbidden patterns FAIL The patch introduces a forbidden pattern: withespace character (156) But I don't understand why do you use the | operator. I think you wanted to use the || operator and wrote $branchcode ||= ''; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 15:59:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 13:59:00 +0000 Subject: [Koha-bugs] [Bug 8185] Plugin for linking records in MARC21 In-Reply-To: <bug-8185-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8185-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8185-70-ORDTlD5Bmn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8185 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain at biblibre.com Version|master |rel_3_10 --- Comment #21 from Paul Poulain <paul.poulain at biblibre.com> --- QA comment: * passes perlcritic & valid-templates * plugin written like all other plugins passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 15:59:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 13:59:25 +0000 Subject: [Koha-bugs] [Bug 8185] Plugin for linking records in MARC21 In-Reply-To: <bug-8185-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8185-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8185-70-BzM1ZQMUpF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8185 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #22 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master (untested, MARC21 specific & no side effect possible) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 16:08:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 14:08:15 +0000 Subject: [Koha-bugs] [Bug 2060] Ability to import Authorities from Staff Client In-Reply-To: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2060-70-TxUYbVw8wt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2060 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12151|0 |1 is obsolete| | Attachment #12152|0 |1 is obsolete| | Attachment #12218|0 |1 is obsolete| | --- Comment #40 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12346 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12346&action=edit Bug 7475: Teach matching rules to handle authorities * Add the code necessary to handle authorities with matching rules and import batches. * Update all the scripts that use the matcher and import batch code to use the new API. * Add authority records to the matching rules interface in the staff client. http://bugs.koha-community.org/show_bug.cgi?id=2060 Signed-off-by: Elliott Davis <elliott at bywatersolutions.com> Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com> Rebased on latest master 11 September 2012 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 16:08:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 14:08:46 +0000 Subject: [Koha-bugs] [Bug 8570] Add pagination to the Z39.50 results page In-Reply-To: <bug-8570-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8570-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8570-70-ygMZAcCuI6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8570 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #6 from Paul Poulain <paul.poulain at biblibre.com> --- QA comment: I'm really annoyed, as Owen is, to see that this patch does not use datatable... It's an improvement expected since a long time OTOH. We have: * Owen = yes * Paul = would prefer no and ask for another patch, that could never be submitted * another one opinion ? PS: "This feature was made a long time ago and got approved for release to the community by our client recently." I think this is a wrong way to do with customers. You should say *before* the contract that everything will be released ASAP. That's how we do at BibLibre, librarians are OK with that. We even put everything on a public git repo before the development is done. If you ask *after*, they will ask their legal advisor, and it will take a long time (but I'm french, maybe it's different in north-america...) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 16:08:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 14:08:52 +0000 Subject: [Koha-bugs] [Bug 2060] Ability to import Authorities from Staff Client In-Reply-To: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2060-70-wR1wEO1xfS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2060 --- Comment #41 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12347 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12347&action=edit Bug 2060: Update command line MARC import scripts Expose authority import functionality to the command line import scripts, and rename them from commit_biblios_file.pl and stage_biblios_file.pl to commit_file.pl and stage_file.pl. To test (note that these instructions assume you have a MARC21 installation and are using the provided sample file): 1. Find a file of authorities (a sample file with MARC21 authorities is attached to bug 7475) and download it to your server 2. Stage the file using the following command (replace <filename> with the name of the file you saved in step 1): > misc/stage_file.pl --file <filename> --authorities 3. Note the batch number the script assigns to your batch 4. Commit the records using the following command (replace <batchnumber> with the batch number you made note of in step 3): > misc/commit_file.pl --batch-number <batchnumber> 5. Index the authorities Zebraqueue (or wait) 6. Confirm that the new authorities appear. 7. Create a matching rule with the following settings: Code: AUTHTEST Description: Personal name main entry Match threshold: 999 Record type: Authority record Search index: Heading-main Score: 1000 Tag: 100 Subfields: a Offset: 0 Length: 0 (note the ID of this matching rule) 8. Stage the authority file again, this time using the following command: > misc/stage_file.pl --file <filename> --authorities \ --match <matchingrule> 7. Revert the import with the following command: > misc/commit_file.pl --batch-number <batchnumber> --revert 8. Index the authorities Zebraqueue (or wait) 9. Confirm that the records have been removed 10. Import an authority record with the Stage MARC/Manage staged MARC tools in exactly the way you would for a bibliographic record, but choose "Authority" instead of "Bibliographic" for the record type. Signed-off-by: Elliott Davis <elliott at bywatersolutions.com> Testing plan delivers as it should. Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com> Rebased on latest master 11 September 2012 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 16:09:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 14:09:08 +0000 Subject: [Koha-bugs] [Bug 2060] Ability to import Authorities from Staff Client In-Reply-To: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2060-70-6QAP616rou@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2060 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 16:09:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 14:09:11 +0000 Subject: [Koha-bugs] [Bug 2060] Ability to import Authorities from Staff Client In-Reply-To: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2060-70-6yQRon79j5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2060 --- Comment #42 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12348 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12348&action=edit Bug 2060 follow-up: add support for UNIMARCAUTH The staged MARC management script was not correctly informing the decoder ring that we had UNIMARC authorities, and the decoder ring was dutifully trying to turn the authority records into a bibliographic box of cereal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 16:11:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 14:11:04 +0000 Subject: [Koha-bugs] [Bug 8692] Authorities search form does not correspond to current search query In-Reply-To: <bug-8692-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8692-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8692-70-tfOfa1yKgh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8692 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> --- CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search.inc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 16:11:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 14:11:48 +0000 Subject: [Koha-bugs] [Bug 8692] Authorities search form does not correspond to current search query In-Reply-To: <bug-8692-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8692-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8692-70-aKQXgD1k4e@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8692 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 16:14:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 14:14:37 +0000 Subject: [Koha-bugs] [Bug 6448] EAN-13 barcode support In-Reply-To: <bug-6448-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6448-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6448-70-JahQ9n69zo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6448 --- Comment #31 from Paul Poulain <paul.poulain at biblibre.com> --- (In reply to comment #27) > Created attachment 11349 [details] > Bug 6448 - carp on invalid barcode > > This is consistent with implementation of other barcode types > which all carp instead of die on invalid barcodes. Hey, it seems no-one (including me) spotted that you've submitted a fix that should please jenkins ! Note = when you submit a follow-up to a pushed patch, please switch back to "need signoff" to let everyone see there's something new. Anyway: I applied the patch, and prove t/db_dependent/Barcodes.t now returns a correct All tests successful. (even if this is a workaround, because the test is not actually testing correctly. It just don't die) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 16:15:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 14:15:30 +0000 Subject: [Koha-bugs] [Bug 7572] Add Clubs & Services Feature In-Reply-To: <bug-7572-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7572-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7572-70-u95VCHq4bd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10169|0 |1 is obsolete| | --- Comment #25 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12349 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12349&action=edit Bug 7572 - Add Clubs & Services Feature This features adds the ability to create clubs and services which patrons may be enrolled in. It is particularly useful for tracking summer reading programs, book clubs and other such clubs. It includes 2 built-in service archetypes: Bestsellers Club : Batch generate a holds list which shuffles the holds queue when new items matching a given title or author are catalogued. New Items Weekly Mailing Lists : Create custom mailing lists to alert subscribers to new items in your library. This code has been in production for a number of years at the Crawford County Federated Library System. Test Plan: 1) Add clubs & services permissions for a librarian account. 2) Create a new archetype 3) Create a new club or service based on the archetype 4) Enroll a borrower in the club or service 5) Cancel the enrollment in the club or service 6) Verify the permissions work correctly by turning off each one in turn and attempt to perform the action that should be denied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 16:15:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 14:15:42 +0000 Subject: [Koha-bugs] [Bug 7572] Add Clubs & Services Feature In-Reply-To: <bug-7572-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7572-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7572-70-kg3NjAgj0j@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 16:15:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 14:15:40 +0000 Subject: [Koha-bugs] [Bug 8449] Improve wording and styling for "cancelled holds" on Holds Awaiting Pickup screen In-Reply-To: <bug-8449-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8449-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8449-70-jBxN35DjYh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8449 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m QA Contact| |jonathan.druart at biblibre.co | |m --- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> --- String changes only. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 16:19:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 14:19:17 +0000 Subject: [Koha-bugs] [Bug 7572] Add Clubs & Services Feature In-Reply-To: <bug-7572-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7572-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7572-70-u7Mtl2R8PN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12349|0 |1 is obsolete| | --- Comment #26 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12350 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12350&action=edit Bug 7572 - Add Clubs & Services Feature This features adds the ability to create clubs and services which patrons may be enrolled in. It is particularly useful for tracking summer reading programs, book clubs and other such clubs. It includes 2 built-in service archetypes: Bestsellers Club : Batch generate a holds list which shuffles the holds queue when new items matching a given title or author are catalogued. New Items Weekly Mailing Lists : Create custom mailing lists to alert subscribers to new items in your library. This code has been in production for a number of years at the Crawford County Federated Library System. Test Plan: 1) Add clubs & services permissions for a librarian account. 2) Create a new archetype 3) Create a new club or service based on the archetype 4) Enroll a borrower in the club or service 5) Cancel the enrollment in the club or service 6) Verify the permissions work correctly by turning off each one in turn and attempt to perform the action that should be denied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 16:20:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 14:20:07 +0000 Subject: [Koha-bugs] [Bug 8659] Inactive funds in neworderempty not disabled in IE/Opera In-Reply-To: <bug-8659-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8659-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8659-70-qcQk49rrYq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8659 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #12 from Jonathan Druart <jonathan.druart at biblibre.com> --- QA Comments: No regression found with FF, so I marked it as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 16:20:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 14:20:15 +0000 Subject: [Koha-bugs] [Bug 8659] Inactive funds in neworderempty not disabled in IE/Opera In-Reply-To: <bug-8659-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8659-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8659-70-VzeKTxcxfi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8659 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 16:30:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 14:30:34 +0000 Subject: [Koha-bugs] [Bug 7572] Add Clubs & Services Feature In-Reply-To: <bug-7572-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7572-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7572-70-9B5xWkpiHG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12350|0 |1 is obsolete| | --- Comment #27 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12351 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12351&action=edit Bug 7572 - Add Clubs & Services Feature This features adds the ability to create clubs and services which patrons may be enrolled in. It is particularly useful for tracking summer reading programs, book clubs and other such clubs. It includes 2 built-in service archetypes: Bestsellers Club : Batch generate a holds list which shuffles the holds queue when new items matching a given title or author are catalogued. New Items Weekly Mailing Lists : Create custom mailing lists to alert subscribers to new items in your library. This code has been in production for a number of years at the Crawford County Federated Library System. Test Plan: 1) Add clubs & services permissions for a librarian account. 2) Create a new archetype 3) Create a new club or service based on the archetype 4) Enroll a borrower in the club or service 5) Cancel the enrollment in the club or service 6) Verify the permissions work correctly by turning off each one in turn and attempt to perform the action that should be denied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 16:33:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 14:33:02 +0000 Subject: [Koha-bugs] [Bug 5339] Parcel closing in acq In-Reply-To: <bug-5339-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5339-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5339-70-FFnNpdF2u0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339 --- Comment #82 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 12352 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12352&action=edit Bug 5339: ergonomic changes - "Finish receive" on parcel.pl now redirect to acqui/invoice.pl, allowing the librarian to modify invoice informations (freight, billing date, ...) and close invoice. - The librarian can now close (or reopen) the invoice and modify invoice informations in 1 operation (instead of 2) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 16:33:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 14:33:48 +0000 Subject: [Koha-bugs] [Bug 5339] Parcel closing in acq In-Reply-To: <bug-5339-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5339-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5339-70-UCAtBqP6Ao@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339 --- Comment #83 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 12353 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12353&action=edit Bug 5339: Unit tests for invoices related subroutines These tests use DBD::Mock to check if SQL queries are correctly built. Actually, we only check bound parameters. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 16:34:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 14:34:08 +0000 Subject: [Koha-bugs] [Bug 5339] Parcel closing in acq In-Reply-To: <bug-5339-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5339-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5339-70-QENfiyBHjf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12266|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 16:34:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 14:34:22 +0000 Subject: [Koha-bugs] [Bug 5339] Parcel closing in acq In-Reply-To: <bug-5339-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5339-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5339-70-eYjWc3YPIA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12267|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 16:35:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 14:35:02 +0000 Subject: [Koha-bugs] [Bug 5339] Parcel closing in acq In-Reply-To: <bug-5339-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5339-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5339-70-aA75GFNVCs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED --- Comment #84 from Julian Maurice <julian.maurice at biblibre.com> --- Obsoleted the two previous patches as they are in master. Switching status to needs signoff. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 16:35:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 14:35:11 +0000 Subject: [Koha-bugs] [Bug 5339] Parcel closing in acq In-Reply-To: <bug-5339-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5339-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5339-70-8Tu9q3Y72h@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 16:35:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 14:35:27 +0000 Subject: [Koha-bugs] [Bug 7572] Add Clubs & Services Feature In-Reply-To: <bug-7572-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7572-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7572-70-ObrD34SiTD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 --- Comment #28 from Kyle M Hall <kyle at bywatersolutions.com> --- > 1) Can you please add the new permisson for all languages? English is ok - > easier to add a translation than figuring out a missing permission. Done > 2) Some of the perl files have strict, but not warnings, can you add use > Modern::Perl? Done > 3) The Templates don't follow the capitalization rules. Examples: > Start Date > End Date > You Are Not Enrolled In Any Clubs Or Services Fixed > 4) This will not work for other languages, as noted in some of the earlier > comments: > $sth = $dbh->prepare("SELECT * FROM clubsAndServicesArchetypes WHERE title > LIKE 'Bestsellers Club' "); Fixed > 5) If I read the code correctly, this is another translation problem, adding > a hardcoded note to the hold: > + my $notes = "Automatic Reserve for Bestsellers Club", > Fixed > 6) I wonder about the error messages - from reading the code I am not > totally sure but I think they are also not translatable. > + <div>Reason: <strong>[% failureMessage %]</strong></div> Fixed > 7) Could you add documenation to the database tables? I was wondering about > the line: > + `casaId` int(11) NOT NULL default '0' COMMENT 'foreign key to > clubsAndServicesArchetypes', - not sure if COMMENT is a mysqlism. > > We had some discussion about following the standard in one of the IRC > meetings and agreed on using -- comment in the end. But I don't remember > exactly why. Fixed > 8) Another translation issue is the preset data you add in > kohastructure.sql. Also adding data to the tables is normally done by > separate sql files, while kohastructure is only creating the table structure > without any data. > > +-- Preset data for ClubsAndServicesArchetypes > +-- > + > +INSERT INTO `clubsAndServicesArchetypes`... Fixed > 9) There is a conflict marker in updatedatabase.pl and the version should be > set to be XXX. > +<<<<<<< HEAD > $DBversion = "3.09.00.005"; Removed > 10) There is some untranslatable JavaScript too. Example: > + alert("Title is a required field"); > + alert("Description is a required field"); Fixed > 11) There is a large block of code commented out. Maybe delete it, if it's > not needed? > +<!-- These messages are uneccessary because you can see if it was deleted > or created immediately... > Also some typos in there 'Archtype'. Removed > 12) It looks like the old calendar is being used? Not sure here. > + <img src="/intranet-tmpl/prog/en/lib/calendar/cal.gif" alt="Show > Calendar" border="0" id="CalendarStartDate" style="cursor: pointer;" /> Switched to the new calendar widget > 13) Ok, now I found something really big :( > > The doc states: > HTML::Template file mailinglist.tmpl > > Also: > +use HTML::Template::Pro; > > And then: > +++ b/misc/cronjobs/mailinglist/mailinglist.tmpl > > This needs to be redone to use TT. Done. Thanks for your good eyes! The original version of this feature was written in 2007 and Koha has moved quite a bit since then! I think this updated patch addresses all your concerns, and is definitely a big improvement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 16:42:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 14:42:24 +0000 Subject: [Koha-bugs] [Bug 7572] Add Clubs & Services Feature In-Reply-To: <bug-7572-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7572-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7572-70-gRSo9QDmx2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 --- Comment #29 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Kyle, thx for reworking your patch! I took a quick look at the last of the attached patches and found some more "use stricts" - could you check? Thx. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 16:44:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 14:44:41 +0000 Subject: [Koha-bugs] [Bug 7572] Add Clubs & Services Feature In-Reply-To: <bug-7572-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7572-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7572-70-BvniDRvnn1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 --- Comment #30 from Kyle M Hall <kyle at bywatersolutions.com> --- Will do. Just a note, access to the Clubs & Services module is via the Tools module. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 16:49:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 14:49:20 +0000 Subject: [Koha-bugs] [Bug 7572] Add Clubs & Services Feature In-Reply-To: <bug-7572-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7572-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7572-70-MxCziYjFGP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12351|0 |1 is obsolete| | --- Comment #31 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12354 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12354&action=edit Bug 7572 - Add Clubs & Services Feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 17:01:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 15:01:19 +0000 Subject: [Koha-bugs] [Bug 8117] Divide budget periods into two tabs In-Reply-To: <bug-8117-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8117-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8117-70-Vu37Yk7wlJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8117 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #20 from Paul Poulain <paul.poulain at biblibre.com> --- QA comment: this time it's OK ! passed QA A follow-up will be added though, because we understood why I had some javascript error and jonathan didn't. It's because I've plack + debug debug panel in plack adds a lot of <table> (without any id) thus, when you call $("table").dataTable(...) there's a javacscript error because datatable can't handle the plack <table> ! The solution has been to explicitely name the tables to dataTable (which is a good thing anyway) $("#activeperiodst,#inactiveperiodst").dataTable($.extend(true, {}, dataTablesDefaults, { -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 17:02:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 15:02:30 +0000 Subject: [Koha-bugs] [Bug 8117] Divide budget periods into two tabs In-Reply-To: <bug-8117-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8117-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8117-70-hBW22phVTp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8117 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 --- Comment #21 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 17:13:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 15:13:34 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6874-70-wgRCvRXYzy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10863|0 |1 is obsolete| | --- Comment #43 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 12355 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12355&action=edit Bug 6874: File upload in MARC Rebased on master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 17:13:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 15:13:50 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6874-70-AXuKCcxxLp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11098|0 |1 is obsolete| | --- Comment #44 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 12356 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12356&action=edit Bug 6874: Follow-up: fix filename encoding and sanitization Rebased on master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 17:14:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 15:14:05 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6874-70-bRgUQhOzrk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11634|0 |1 is obsolete| | --- Comment #45 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 12357 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12357&action=edit Bug 6874: Allow to reupload a file immediately after deletion Rebased on master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 17:14:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 15:14:14 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6874-70-9XQyYlqriH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #46 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 12358 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12358&action=edit Bug 6874: Change filename construction method. Use <SHA-1>_<filename>. SHA-1 to avoid name clash, filename to make it easier to find a file by its name, when not using Koha (direct filesystem access). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 17:14:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 15:14:43 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6874-70-s00ISEgYxb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 17:14:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 15:14:56 +0000 Subject: [Koha-bugs] [Bug 7421] UNIMARC authorities DOM indexing mode In-Reply-To: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7421-70-WOYno8j7su@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7421 --- Comment #11 from Paul Poulain <paul.poulain at biblibre.com> --- (In reply to comment #10) > It works for me, but I'm not sure to understand what's wrong with your > installation. Is it an update or a new installation? it was a fresh install -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 17:18:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 15:18:14 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6874-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6874-70-gMjSPcdTHt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #47 from Julian Maurice <julian.maurice at biblibre.com> --- Jared, I finally choose to use both SHA-1 and name for filename. So we have the advantages of both sides, I think. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 17:21:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 15:21:04 +0000 Subject: [Koha-bugs] [Bug 2060] Ability to import Authorities from Staff Client In-Reply-To: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2060-70-AbYrYyRmsV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2060 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12195|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 17:21:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 15:21:16 +0000 Subject: [Koha-bugs] [Bug 2060] Ability to import Authorities from Staff Client In-Reply-To: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2060-70-UCbKeTF8Ib@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2060 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12215|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 17:21:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 15:21:49 +0000 Subject: [Koha-bugs] [Bug 2060] Ability to import Authorities from Staff Client In-Reply-To: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2060-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2060-70-tsALQLJCeD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2060 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 --- Comment #43 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master This time, everything work afaics ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 17:38:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 15:38:24 +0000 Subject: [Koha-bugs] [Bug 8570] Add pagination to the Z39.50 results page In-Reply-To: <bug-8570-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8570-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8570-70-VaQcGZLbAO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8570 --- Comment #7 from Owen Leonard <oleonard at myacpl.org> --- (In reply to comment #6) > * Paul = would prefer no and ask for another patch, that could never be > submitted I get the impression that this implementation is good enough for the original sponsor and that a follow-up is unlikely. I signed off because I think getting this functionality into Koha is important, despite my reservations about the way it was done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 17:39:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 15:39:57 +0000 Subject: [Koha-bugs] [Bug 5356] Shipping billing address improvements In-Reply-To: <bug-5356-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5356-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5356-70-b18bFlfjVJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #25 from Paul Poulain <paul.poulain at biblibre.com> --- (In reply to comment #24) > Created attachment 11952 [details] > Bug 5356: Followup: Add basket billing and delivery place on export pdf > (layout3pages) > > Hi Paul, > This patch adds the basket billing place and delivery place in the generated > pdf. > But only for the layout3pages. Indeed, there are no space to add these > information. Sounds logicall not to have the information on layout2pages, as it's all basket mixed (sorted by publisher/title). So, passed QA ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 17:40:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 15:40:09 +0000 Subject: [Koha-bugs] [Bug 5356] Shipping billing address improvements In-Reply-To: <bug-5356-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5356-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5356-70-mpnmpqr9Ux@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 17:49:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 15:49:55 +0000 Subject: [Koha-bugs] [Bug 5356] Shipping billing address improvements In-Reply-To: <bug-5356-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5356-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5356-70-O01jLlgF3x@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 --- Comment #26 from Paul Poulain <paul.poulain at biblibre.com> --- Well, testing this feature & QAing the code one more time, a question arise: what is the "freedeliveryplace" done for ? * in aqbasketgroup, it was a TEXT, in this patch, for aqbasket it's a varchar(10), that is tiny for a free address ! * I can't see where I can file this freedeliveryplace field (not failing QA until i've an anwser to those questions) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 17:50:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 15:50:49 +0000 Subject: [Koha-bugs] [Bug 5356] Shipping billing address improvements In-Reply-To: <bug-5356-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5356-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5356-70-FXZAHjNJdT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 --- Comment #27 from Paul Poulain <paul.poulain at biblibre.com> --- PS: if you switch to a text field, please don't do in a follow-up. updatedatabase conflicts are very very common, and it's a pain to apply a follow-up that update updatedatabase ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 17:53:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 15:53:46 +0000 Subject: [Koha-bugs] [Bug 8606] Talking Tech broken by user-configurable slips feature In-Reply-To: <bug-8606-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8606-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8606-70-KaEVZLGZkk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8606 --- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12359 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12359&action=edit Bug 8606 - Talking Tech broken by user-configurable slips feature - QA Followup -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 17:54:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 15:54:56 +0000 Subject: [Koha-bugs] [Bug 8606] Talking Tech broken by user-configurable slips feature In-Reply-To: <bug-8606-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8606-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8606-70-gf7iJo7fsY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8606 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12359|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12360 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12360&action=edit Bug 8606 - Talking Tech broken by user-configurable slips feature - QA Followup -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 17:55:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 15:55:56 +0000 Subject: [Koha-bugs] [Bug 8606] Talking Tech broken by user-configurable slips feature In-Reply-To: <bug-8606-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8606-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8606-70-h1gDTwOwqS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8606 --- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to comment #4) > QA Comments: > No side effect possible. I don't tested the patch but it seems good. > > No blocker: > * C4/Letters.pm FAIL > forbidden patterns FAIL > The patch introduces a forbidden pattern: withespace character (156) > > But I don't understand why do you use the | operator. I think you wanted to > use the || operator and wrote > $branchcode ||= ''; You are correct. The smallest followup ever written has been attached ; ) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 18:03:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 16:03:49 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-3dmieNSujL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12120|0 |1 is obsolete| | Attachment #12128|0 |1 is obsolete| | Attachment #12192|0 |1 is obsolete| | Attachment #12246|0 |1 is obsolete| | --- Comment #56 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12361 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12361&action=edit Bug 8215 - Course Reserves Adds a course reserves system for academic libraries. The course reserves system allows libraries to create courses and put items on reserves for those courses. Each item with at least one reserve can have some of its attributes modified while it is on reserve for at least one active course. These attributes include item type, collection code, shelving location, and holding library. If there are no active courses with this item on reserve, it's attributes will revert to the original attributes it had before going on reserve. Signed-off-by: wajasu <matted-34813 at mypacks.net> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 18:07:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 16:07:59 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-MflsX54Gdo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #57 from Kyle M Hall <kyle at bywatersolutions.com> --- Here you go! Rebased, squashed, and tested. (In reply to comment #55) > OK, it could be OK this time. but as I pushed a lot of things recently, > there is a conflict in C4/Koha.pm that I'll let you fix. > Plus, the follow-ups on updatedatabase.pl won't apply nicely. > > So, the best option here is that you: > * squash all patches in one > * then rebase against master > * test everything is OK > * git bz attach rebased-squashed patch > > and i'll be able to test & hopefully push ! > > Note that this feature is not heavily nested in the rest of Koha. So I could > push it after the Feature Freeze, as there is only a side effect. ( But I > would also be OK to push before the FF if you rebase quickly ;-) ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 18:18:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 16:18:43 +0000 Subject: [Koha-bugs] [Bug 8570] Add pagination to the Z39.50 results page In-Reply-To: <bug-8570-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8570-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8570-70-SIpqsF5wVG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8570 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #8 from Marc V?ron <veron at veron.ch> --- Agree with Owen. Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 18:21:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 16:21:48 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8236-70-35FCLKVqHH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Koha Team Lyon 3 <koha at univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11958|0 |1 is obsolete| | --- Comment #12 from Koha Team Lyon 3 <koha at univ-lyon3.fr> --- Created attachment 12362 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12362&action=edit Block renewal for overdue documents I reworked entirely the initial patch, added some parts that were obviously missing (Detail circulation tab was forgotten had different behaviour from Checkout one) and tight all with a new syspref (RenewIfOverdue). As for the updatedatabase.pl part and specially the version number I doubt it would be correct, cause I don't know the way to set it, I just increment the last version number present in our updatedatabase.pl file. The syspref offers a triple choice when any of a patron's document is late : => allow renewal anyhow (if the document has renewable type of course) which is today the default action. => block only the overdue items => block all patron's checked out documents (the big punishment...). In the circulation interface, the renewal remains possible through the Override renewal button. the Renew all one is hidden if blocking options are choosen. In the patron's interfaces (Patron's file and the Webservice apis), the same logic is working. Beside the object of this patch, I also noted 2 things that would diserve to have a look : 1) the comments of the IsMemberBlocked routine announces a control on the fines status of the borrower, but the control is done on his restriction status. 2) In case of restriction, the patron's file is frozen (so renewal is not possible but through the webservice interface (RenewLoan in Services.pm) it is. The present patch will correct that last point if validated (an other story) but I think it should be corrected anyhow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 18:25:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 16:25:24 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8236-70-6WQ5rqbFK6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Koha Team Lyon 3 <koha at univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 18:30:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 16:30:39 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6679-70-YMQdlx7Rff@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #160 from Colin Campbell <colin.campbell at ptfs-europe.com> --- Created attachment 12363 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12363&action=edit Proposed patch to calm Jenkins -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 18:48:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 16:48:17 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6679-70-fcsrYx659E@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12363|0 |1 is obsolete| | --- Comment #161 from Paul Poulain <paul.poulain at biblibre.com> --- Comment on attachment 12363 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12363 Proposed patch to calm Jenkins This patch has been pushed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 18:48:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 16:48:43 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6679-70-I3orDLuBIa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 18:49:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 16:49:09 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6679-70-jbKp6W8eas@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #162 from Paul Poulain <paul.poulain at biblibre.com> --- patches are signed off, going to this status to have patches in QA team radar ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 18:51:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 16:51:09 +0000 Subject: [Koha-bugs] [Bug 8365] Renewal duration in issuingules In-Reply-To: <bug-8365-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8365-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8365-70-hyB2zffxaN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- How is the renewal date calculated if the renewals period is set to zero (as it will be when the feature is added on top of an existing installation) ? Shouldn't this feature accommodate renewal periods in hours or days? How can a library set a renewal period if their loan period is in hours? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 19:07:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 17:07:44 +0000 Subject: [Koha-bugs] [Bug 8718] Normal catalogue detail view in staff client doesn't show missing serials or subscription history note In-Reply-To: <bug-8718-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8718-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8718-70-VnAdNxWv9t@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8718 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11950|0 |1 is obsolete| | --- Comment #3 from David Cook <dcook at prosentient.com.au> --- Created attachment 12364 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12364&action=edit Bug 8718 - Normal catalogue detail view in staff client doesn't show missing serials or subscription history note Rebased following Bug 8717 changes to subscription->{notes} To Test: 1) In staff client, search for a bib record attached to a subscription 2) Click on the "Normal" tab, if not already selected 3) Click on "Subscriptions" next to "Description" and "Images" on the centre of the screen. 4) Open "Subscription Details" in a separate window 5) Edit the subscription to add "Note for staff" under the subscription history div on the right-side of the screen and/or 6) Go to Serial collection and mark an issue as "Missing" 7) Reload your bib record in the other window, and see the "Note for staff" pop up alongside a label "Missing: " followed by your missing issues. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 19:38:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 17:38:04 +0000 Subject: [Koha-bugs] [Bug 7421] UNIMARC authorities DOM indexing mode In-Reply-To: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7421-70-e1rGBfAe0v@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7421 --- Comment #12 from Fr?d?ric Demians <frederic at tamil.fr> --- > it was a fresh install I've redone a new installation, choosing UNIMARC, and DOM. And it works out of the box. I've chosen a complete UNIMARC framework? Have you chosen the alternative framework? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 21:21:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 19:21:01 +0000 Subject: [Koha-bugs] [Bug 8792] Babeltheque tab is useless In-Reply-To: <bug-8792-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8792-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8792-70-NXx0lwc4k5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8792 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12341|0 |1 is obsolete| | --- Comment #4 from Marc V?ron <veron at veron.ch> --- Created attachment 12365 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12365&action=edit [SIGNED-OFF] Babeltheque: Remove the unused tab on the opac detail page http://bugs.koha-community.org/show_bug.cgi?id=8792 Signed-off-by: Marc Veron <veron at veron.ch> Babeltheque tab is removed as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 21:21:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 19:21:21 +0000 Subject: [Koha-bugs] [Bug 8792] Babeltheque tab is useless In-Reply-To: <bug-8792-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8792-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8792-70-DQl3YpOPkq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8792 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 21:22:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 19:22:39 +0000 Subject: [Koha-bugs] [Bug 8415] Link Serial with Acquisition In-Reply-To: <bug-8415-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8415-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8415-70-mB7Zv3QTCH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8415 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12327|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 12366 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12366&action=edit Bug 8415: Follow up - Fixing some smaller issues 1) Changes the updatedatabase to be a bit more precise and always add the new field after claimed_date, like it is in kohastructure.sql. 2) Fixes capitalization rules for the new link to create a serial order. 3) Hides EAN search field when marcflavour is not UNIMARC. 4) Adds documentation for the new column in kohastructure.sql 5) Fixes some terms * Branch to Library * Search for Serial Routing Lists to Search for serial subscriptions 6) Deletes doubled up SearchSubscriptions from Search.pm * Change call to sub to use new signature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 22:03:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 20:03:41 +0000 Subject: [Koha-bugs] [Bug 8787] If OpacMaintenance is on the requested page is loaded In-Reply-To: <bug-8787-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8787-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8787-70-CeVel8P7UF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8787 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12330|0 |1 is obsolete| | --- Comment #2 from Marc V?ron <veron at veron.ch> --- Created attachment 12367 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12367&action=edit [SIGNED-OFF] But 8787: don't load the page if OpacMaintenance is ON If the syspref OpacMaintenance is ON, it is useless to loaded the requested page. To test: - switch on the syspref OpacMaintenace - check in your apache access log, zebra log, etc. the requested page is not loaded (i.e. on the opac-search.pl page) Signed-off-by: Marc Veron <veron at veron.ch> Checked by watching other_vhosts_access.log Works as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 22:04:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 20:04:08 +0000 Subject: [Koha-bugs] [Bug 8787] If OpacMaintenance is on the requested page is loaded In-Reply-To: <bug-8787-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8787-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8787-70-eaS0npwUOU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8787 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 23:28:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 21:28:30 +0000 Subject: [Koha-bugs] [Bug 8600] Remove search terms in advanced search In-Reply-To: <bug-8600-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8600-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8600-70-cTgWZbt43N@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8600 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #6 from Marc V?ron <veron at veron.ch> --- This is a nice enhancement I would like to see in the Opac. I agree with Katrin, liking +- buttons as well. Adding / removing options works well. However I propose to change the wording of "More options"/"Fewer options" Reason: If you remove all options with [-] and have only one left, "Fewer options" is kind of nonsense, because it means to restore the original (3) options, i.e. more, not fewer. Better wording would be something like "Manage options" (instead of "More optons") and "Default options" (instead of "Fewer options") If someone removes the last line with [+] , he/she can "recover" by switching back to "Default options". ("Fewer opions" would be misleading.) Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 19 23:37:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 21:37:16 +0000 Subject: [Koha-bugs] [Bug 8415] Link Serial with Acquisition In-Reply-To: <bug-8415-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8415-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8415-70-Z2NKup53sW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8415 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12366|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 12368 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12368&action=edit Bug 8415: Follow up - Fixing some smaller issues 1) Changes the updatedatabase to be a bit more precise and always add the new field after claimed_date, like it is in kohastructure.sql. 2) Fixes capitalization rules for the new link to create a serial order. 3) Hides EAN search field when marcflavour is not UNIMARC. 4) Adds documentation for the new column in kohastructure.sql 5) Fixes some terms * Branch to Library * Search for Serial Routing Lists to Search for serial subscriptions * Supplier to Vendor 6) Deletes doubled up SearchSubscriptions from Search.pm * Change call to sub to use new signature 7) Deletes "Show only renewed" checkbox and related code. This feature requires a database field reneweddate in subscription that is not available in master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 00:15:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 22:15:02 +0000 Subject: [Koha-bugs] [Bug 5339] Parcel closing in acq In-Reply-To: <bug-5339-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5339-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5339-70-WBcLSVvECO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339 --- Comment #85 from Chris Cormack <chris at bigballofwax.co.nz> --- We also need to fix the test in t/db_dependent/Acquisition.t not ok 9 - This order has a booksellerinvoicenumber field # Failed test 'This order has a booksellerinvoicenumber field' # at t/db_dependent/Acquisition.t line 82. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 00:23:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 19 Sep 2012 22:23:32 +0000 Subject: [Koha-bugs] [Bug 8794] New: edit as duplicate for authorities Message-ID: <bug-8794-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8794 Priority: P5 - low Change sponsored?: --- Bug ID: 8794 CC: m.de.rooy at rijksmuseum.nl Assignee: gmcharlt at gmail.com Summary: edit as duplicate for authorities Severity: enhancement Classification: Unclassified OS: All Reporter: nengard at gmail.com Hardware: All Status: NEW Version: master Component: Cataloging Product: Koha Sometimes you need to duplicate a personal name authority and turn it in to a subject heading (for biographies) - but there is no easy way to do this. We have 'edit as duplicate' for cataloging, but not authorities and should probably have it for both. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 07:14:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 05:14:40 +0000 Subject: [Koha-bugs] [Bug 8600] Remove search terms in advanced search In-Reply-To: <bug-8600-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8600-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8600-70-ucw9kmeUVf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8600 --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Marc, Hmm, I am not sure it works like this. You only see the +/- when you have the screen with "more" options. So if you accidently delete all your search fields and are left with only one, the fewer options will bring you back to 3 search fields, but you won't have +/- or the boolean pull downs available - so the screen will change and it will not be the same search form you have seen before. That will require switching back and forth. I think maybe the javascript needs to be changed to not allow deleting of the lsecond line or allow cloning of the first with adding boolean search options on this step. I know it's much harder to do, but I don't feel comfortable with the feature as it is now :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 09:09:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 07:09:57 +0000 Subject: [Koha-bugs] [Bug 8795] New: Just add the login branch In orderreveive.tt Message-ID: <bug-8795-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8795 Priority: P5 - low Change sponsored?: --- Bug ID: 8795 Assignee: koha-bugs at lists.koha-community.org Summary: Just add the login branch In orderreveive.tt Severity: enhancement Classification: Unclassified OS: All Reporter: christophe.croullebois at biblibre.com Hardware: All Status: NEW Version: master Component: Acquisitions Product: Koha The homebranch and holdingbranch ddl in item block are not default selected, they just show the first line. With this patch I just put the default choice as the login branch. To test : without patch the first line of the ddl is shown. With the patch the login branch is shown in homebranch and holdingbranch. thx for testing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 09:14:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 07:14:44 +0000 Subject: [Koha-bugs] [Bug 5339] Parcel closing in acq In-Reply-To: <bug-5339-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5339-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5339-70-RhcvAQScAp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339 --- Comment #86 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 12369 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12369&action=edit Bug 5339: Fix t/db_dependant/Acquisition.t replaced booksellerinvoicenumber by invoiceid -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 09:26:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 07:26:12 +0000 Subject: [Koha-bugs] [Bug 8795] Just add the login branch In orderreveive.tt In-Reply-To: <bug-8795-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8795-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8795-70-wTQNlQb7Bn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8795 Christophe Croullebois <christophe.croullebois at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |christophe.croullebois at bibl |ity.org |ibre.com --- Comment #1 from Christophe Croullebois <christophe.croullebois at biblibre.com> --- Created attachment 12370 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12370&action=edit proposed patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 09:27:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 07:27:37 +0000 Subject: [Koha-bugs] [Bug 8606] Talking Tech broken by user-configurable slips feature In-Reply-To: <bug-8606-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8606-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8606-70-6U9KzxsL47@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8606 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to comment #7) > You are correct. The smallest followup ever written has been attached ; ) Thank you Kyle. So I mark it as Passed QA. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 09:27:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 07:27:46 +0000 Subject: [Koha-bugs] [Bug 8606] Talking Tech broken by user-configurable slips feature In-Reply-To: <bug-8606-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8606-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8606-70-uMcrd1gRVH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8606 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 10:17:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 08:17:25 +0000 Subject: [Koha-bugs] [Bug 7351] ability to edit a range of holidays In-Reply-To: <bug-7351-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7351-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7351-70-nihyCDJN6J@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 Christophe Croullebois <christophe.croullebois at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 10:20:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 08:20:57 +0000 Subject: [Koha-bugs] [Bug 8692] Authorities search form does not correspond to current search query In-Reply-To: <bug-8692-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8692-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8692-70-bs5VcCNwEs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8692 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11845|0 |1 is obsolete| | --- Comment #4 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> --- Created attachment 12371 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12371&action=edit Proposed patch (rebased master) Rebased patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 10:36:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 08:36:45 +0000 Subject: [Koha-bugs] [Bug 8692] Authorities search form does not correspond to current search query In-Reply-To: <bug-8692-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8692-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8692-70-HtRC3NW4mG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8692 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 11:06:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 09:06:04 +0000 Subject: [Koha-bugs] [Bug 5339] Parcel closing in acq In-Reply-To: <bug-5339-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5339-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5339-70-3GXsuokYmS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #87 from Paul Poulain <paul.poulain at biblibre.com> --- small Follow-ups tested & pushed in one go -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 11:06:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 09:06:15 +0000 Subject: [Koha-bugs] [Bug 5339] Parcel closing in acq In-Reply-To: <bug-5339-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5339-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5339-70-FHc1XlKkYn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 11:06:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 09:06:37 +0000 Subject: [Koha-bugs] [Bug 5339] Parcel closing in acq In-Reply-To: <bug-5339-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5339-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5339-70-z4tEcQUM1Z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 11:20:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 09:20:54 +0000 Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in OPAC and staff client In-Reply-To: <bug-8377-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8377-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8377-70-JZZrQtZ1uX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 --- Comment #20 from Mirko Tietgen <mirko at abunchofthings.net> --- Created attachment 12372 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12372&action=edit Bug 8377 [ENH] Followup: Move perl module to C4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 11:32:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 09:32:24 +0000 Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in OPAC and staff client In-Reply-To: <bug-8377-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8377-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8377-70-Eq4lsgBtfX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11548|0 |1 is obsolete| | Attachment #12372|0 |1 is obsolete| | --- Comment #21 from Mirko Tietgen <mirko at abunchofthings.net> --- Created attachment 12373 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12373&action=edit Bug 8377 [ENH] Show HTML5 video/ audio for media files in OPAC and staff client This enhancement uses information from MARC field 856 to generate the appropriate HTML5 code to embed am media player for the file(s) in a tab in the OPAC and staff client detail view. This patch supports the HTML5 <audio> and <video> element. Additionally it gives basic support for the <track> element. This element is not supported very well by recent browsers. Please consider the patch working when you get working video or audio. Changes since last version: - failed QA: removed default view for media tab, changed tab name to "Play audio" resp. "Play video". - put most of the code in separate module and access it from OPAC and staff client now, so the feature works in both - had to change sysprefs: HTML5MediaEnabled can be 'none', 'opac', 'staff' or 'both' * Removed default entry for mp3 again to not imply it is widely supported or going to be by free software browsers. If you tested this before, you need to delete the old syspref entries from your database. There is an attachment to do this, use exactly like upgradedatabase.pl. Test plan - Import attached test data. [I chose media typ 'bk' because it's probably present on most systems. It's not appropriate for the data but that doesn't matter.] - Rebuild zebra -b -z - Go to Administration->System preferences->enhanced content->HTML5 Media and set HTML5MediaEnabled to an appropriate setting, save preferences. - Search the OPAC or staff client for 'bug 8377' - Get 4 results - Open detail pages for results. Observe working video (1-3) or audio (4) player on detail page. Squashed both patches together Bug 8377 [ENH] Followup: Move perl module to C4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 11:37:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 09:37:35 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6679-70-H3m4g9HBhu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10485|0 |1 is obsolete| | --- Comment #163 from Paul Poulain <paul.poulain at biblibre.com> --- Comment on attachment 10485 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10485 [FAILED-QA]Bug 6679 - fix 19 perlcritic violations from C4::Letters.pm This patch is now useless, the same goal has been achieved by a follow-up on bug 8063 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 11:39:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 09:39:57 +0000 Subject: [Koha-bugs] [Bug 8365] Renewal duration in issuingules In-Reply-To: <bug-8365-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8365-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8365-70-ToZexFbtgW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12054|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 12374 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12374&action=edit Bug 8365: Add a renewal duration in the issuing rules Renew an issue for a number of days (filled in the issuing rules). Test if rules work for any i[item]types and if there is no regression. - new column issuingrules.renewalperiod - remove all occurrences of an already removed syspref (globalDueDate) - remove an unused routine (Overdues::GetIssuingRules) How it works: - On existing installations, the issuingrules.renewalperiod = issuingrules.loanlength. So the behaviour is the same before and after this patch. - when you add a rule, you can choose a renewal period (the unit value is the issuingrules.unit). So you can have a renewal period in hours or days. - The default value for the renewal period is 21 days (same as loanlength) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 11:43:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 09:43:10 +0000 Subject: [Koha-bugs] [Bug 8365] Renewal duration in issuingules In-Reply-To: <bug-8365-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8365-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8365-70-zLaRFw8seI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 --- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to comment #2) Hello Owen, Thanks for your question. It permits me to improve this patch :) > How is the renewal date calculated if the renewals period is set to zero (as > it will be when the feature is added on top of an existing installation) ? A new query is added to the updatedatabase. It set the renewalperiod field with the issuelength value. > Shouldn't this feature accommodate renewal periods in hours or days? How can > a library set a renewal period if their loan period is in hours? Now it is possible, the renewalperiod unit is based on the unit value (days or hours) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 11:48:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 09:48:29 +0000 Subject: [Koha-bugs] [Bug 8441] Hide MODS export for UNIMARC In-Reply-To: <bug-8441-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8441-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8441-70-Q8Fegsyf7T@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8441 --- Comment #3 from Adrien SAURAT <adrien.saurat at biblibre.com> --- Created attachment 12375 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12375&action=edit proposed patch Indeed, thanks! I updated the file containing specific commands for the install in French. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 11:48:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 09:48:38 +0000 Subject: [Koha-bugs] [Bug 8441] Hide MODS export for UNIMARC In-Reply-To: <bug-8441-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8441-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8441-70-CJJBXY6Duz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8441 Adrien SAURAT <adrien.saurat at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 12:01:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 10:01:41 +0000 Subject: [Koha-bugs] [Bug 5356] Shipping billing address improvements In-Reply-To: <bug-5356-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5356-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5356-70-p5Xm2fjpuz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11120|0 |1 is obsolete| | --- Comment #28 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 12376 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12376&action=edit Bug 5356: delivery place and billing place centralised in basket management - adding 2 select option in basdketheader.tmpl (delivery and billing place) - adding 2 more fields in basket csv export Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Tested together with patches for bug 7302. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 12:02:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 10:02:37 +0000 Subject: [Koha-bugs] [Bug 5356] Shipping billing address improvements In-Reply-To: <bug-5356-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5356-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5356-70-6op6jdrcdU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11952|0 |1 is obsolete| | --- Comment #29 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 12377 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12377&action=edit Bug 5356: Followup: Add basket billing and delivery place on export pdf (layout3pages) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 12:02:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 10:02:45 +0000 Subject: [Koha-bugs] [Bug 7473] Non logged OPAC user can create a list In-Reply-To: <bug-7473-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7473-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7473-70-EeDYh7NWG8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7473 Adrien SAURAT <adrien.saurat at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Adrien SAURAT <adrien.saurat at biblibre.com> --- *** This bug has been marked as a duplicate of bug 6631 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 12:02:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 10:02:45 +0000 Subject: [Koha-bugs] [Bug 6631] Unrestricted creation of lists by anonymous users In-Reply-To: <bug-6631-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6631-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6631-70-vFDklFJoMW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6631 Adrien SAURAT <adrien.saurat at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |adrien.saurat at biblibre.com --- Comment #7 from Adrien SAURAT <adrien.saurat at biblibre.com> --- *** Bug 7473 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 12:03:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 10:03:33 +0000 Subject: [Koha-bugs] [Bug 5356] Shipping billing address improvements In-Reply-To: <bug-5356-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5356-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5356-70-ULhkphnpHw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 --- Comment #30 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to comment #26) > Well, testing this feature & QAing the code one more time, a question arise: > what is the "freedeliveryplace" done for ? > * in aqbasketgroup, it was a TEXT, in this patch, for aqbasket it's a > varchar(10), that is tiny for a free address ! > * I can't see where I can file this freedeliveryplace field > > (not failing QA until i've an anwser to those questions) Paul, In fact the aqbasket.freedeliveryplace is unused. So I removed it in the last patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 12:06:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 10:06:35 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6679-70-JYEB8FDA2u@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10494|0 |1 is obsolete| | --- Comment #164 from Paul Poulain <paul.poulain at biblibre.com> --- Comment on attachment 10494 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10494 Bug 6679 - [SIGNED-OFF]fix 12 perlcritic violations in C4/External/BakerTaylor.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 12:06:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 10:06:53 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6679-70-YdZkPkzA1x@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10495|0 |1 is obsolete| | --- Comment #165 from Paul Poulain <paul.poulain at biblibre.com> --- Comment on attachment 10495 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10495 Bug 6679 - [SIGNED-OFF] fix 12 perlcritic violations in C4/Auth_with_ldap.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 12:07:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 10:07:07 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6679-70-h7qQukBn14@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10496|0 |1 is obsolete| | --- Comment #166 from Paul Poulain <paul.poulain at biblibre.com> --- Comment on attachment 10496 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10496 Bug 6679 -[SIGNED-OFF] fix 12 perlcritic violations in C4/Context.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 12:07:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 10:07:22 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6679-70-DJQqRn7tbk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10497|0 |1 is obsolete| | --- Comment #167 from Paul Poulain <paul.poulain at biblibre.com> --- Comment on attachment 10497 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10497 Bug 6679 - [SIGNED-OFF]fixing 23 '"return" statement with explicit "undef"' violations in C4/Tags.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 12:07:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 10:07:58 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6679-70-zvj3f1gJdW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #168 from Paul Poulain <paul.poulain at biblibre.com> --- Comment on attachment 10517 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10517 Bug 6679 - [FAILED QA]fix 3 perlcritic violations in C4/ClassSortRoutine.pm This patch has NOT been pushed. After applying it, you get a Perl error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 12:08:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 10:08:13 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6679-70-Ww9edpA3Xm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10935|0 |1 is obsolete| | --- Comment #169 from Paul Poulain <paul.poulain at biblibre.com> --- Comment on attachment 10935 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10935 Bug 6679 - [SIGNED-OFF] fix 15 perlcritic violations in C4/ImportExportFramework.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 12:08:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 10:08:41 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6679-70-jI7EObEUUa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #170 from Paul Poulain <paul.poulain at biblibre.com> --- Comment on attachment 10936 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10936 Bug 6679 - [SIGNED-OFF] fix 11 perlcritic violations in C4/Dates.pm This patch has NOT been pushed. After applying it you get a perl error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 12:08:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 10:08:56 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6679-70-VTWILAp9IM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10938|0 |1 is obsolete| | --- Comment #171 from Paul Poulain <paul.poulain at biblibre.com> --- Comment on attachment 10938 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10938 Bug 6679 - [SIGNED-OFF] fix 9 perlcritic violations in C4/TmplTokenType.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 12:09:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 10:09:10 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6679-70-9u95zHJItC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10940|0 |1 is obsolete| | --- Comment #172 from Paul Poulain <paul.poulain at biblibre.com> --- Comment on attachment 10940 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10940 Bug 6679 - [SIGNED-OFF]?fix 9 perlcritic violations in C4/Koha.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 12:09:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 10:09:24 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6679-70-zJVFjKbiKV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10946|0 |1 is obsolete| | --- Comment #173 from Paul Poulain <paul.poulain at biblibre.com> --- Comment on attachment 10946 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10946 Bug 6679 - [SIGNED-OFF] fix 8 perlcritic violations in C4/Circulation.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 12:09:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 10:09:39 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6679-70-qFqL8fEQl7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10947|0 |1 is obsolete| | --- Comment #174 from Paul Poulain <paul.poulain at biblibre.com> --- Comment on attachment 10947 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10947 Bug 6679 - [SIGNED-OFF] fix 8 perlcritic violations in C4/Barcodes.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 12:09:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 10:09:55 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6679-70-k5bSBfp74c@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10948|0 |1 is obsolete| | --- Comment #175 from Paul Poulain <paul.poulain at biblibre.com> --- Comment on attachment 10948 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10948 Bug 6679 - [SIGNED-OFF] fix 7 perlcritic violations in C4/Biblio.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 12:10:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 10:10:12 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6679-70-Gw86QNWuX4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10950|0 |1 is obsolete| | --- Comment #176 from Paul Poulain <paul.poulain at biblibre.com> --- Comment on attachment 10950 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10950 Bug 6679 - [SIGNED-OFF] fix 6 perlcritic violations in C4/Barcodes/hbyymmincr.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 12:10:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 10:10:26 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6679-70-5CGkxHwlJE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10952|0 |1 is obsolete| | --- Comment #177 from Paul Poulain <paul.poulain at biblibre.com> --- Comment on attachment 10952 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10952 Bug 6679 - [SIGNED-OFF] fix 5 perlcritic violations in C4/Serials.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 12:11:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 10:11:02 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6679-70-ZnOfUpNipY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10953|0 |1 is obsolete| | --- Comment #178 from Paul Poulain <paul.poulain at biblibre.com> --- Comment on attachment 10953 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10953 Bug 6679 - [SIGNED-OFF] fix 4 perlcritic violations in C4/ShelfBrowser.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 12:11:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 10:11:19 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6679-70-AjJDojL4yn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10955|0 |1 is obsolete| | --- Comment #179 from Paul Poulain <paul.poulain at biblibre.com> --- Comment on attachment 10955 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10955 Bug 6679 - [SIGNED-OFF] fix 4 perlcritic violations in C4/Branch.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 12:11:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 10:11:32 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6679-70-ZJ9E82kqfS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10957|0 |1 is obsolete| | --- Comment #180 from Paul Poulain <paul.poulain at biblibre.com> --- Comment on attachment 10957 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10957 Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/SQLHelper.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 12:11:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 10:11:47 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6679-70-oLY1sn6CRi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10959|0 |1 is obsolete| | --- Comment #181 from Paul Poulain <paul.poulain at biblibre.com> --- Comment on attachment 10959 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10959 Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/Output.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 12:12:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 10:12:06 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6679-70-XscvE0Y9Kb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10960|0 |1 is obsolete| | --- Comment #182 from Paul Poulain <paul.poulain at biblibre.com> --- Comment on attachment 10960 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10960 Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/Message.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 12:12:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 10:12:22 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6679-70-SDN0NlDO6F@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10961|0 |1 is obsolete| | --- Comment #183 from Paul Poulain <paul.poulain at biblibre.com> --- Comment on attachment 10961 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10961 Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/Items.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 12:12:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 10:12:36 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6679-70-449oU2tV3I@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10963|0 |1 is obsolete| | --- Comment #184 from Paul Poulain <paul.poulain at biblibre.com> --- Comment on attachment 10963 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10963 Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Utils.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 12:12:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 10:12:50 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6679-70-F7JHsOQDmr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10964|0 |1 is obsolete| | --- Comment #185 from Paul Poulain <paul.poulain at biblibre.com> --- Comment on attachment 10964 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10964 Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/ItemCirculationAlertPreference.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 12:13:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 10:13:19 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6679-70-5XTRxG5RnZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10965|0 |1 is obsolete| | --- Comment #186 from Paul Poulain <paul.poulain at biblibre.com> --- Comment on attachment 10965 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10965 Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Installer/PerlModules.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 12:13:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 10:13:44 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6679-70-n2rhUI3KCf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10966|0 |1 is obsolete| | --- Comment #187 from Paul Poulain <paul.poulain at biblibre.com> --- Comment on attachment 10966 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10966 Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/BackgroundJob.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 12:19:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 10:19:19 +0000 Subject: [Koha-bugs] [Bug 8692] Authorities search form does not correspond to current search query In-Reply-To: <bug-8692-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8692-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8692-70-sQNgk7hI2R@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8692 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> --- QA Comments: Works as expected, nothing to say Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 12:21:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 10:21:04 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6679-70-SGLQoUVUW4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10981|0 |1 is obsolete| | --- Comment #188 from Paul Poulain <paul.poulain at biblibre.com> --- Comment on attachment 10981 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10981 Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/Auth.pm, and enabled warnings This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 12:21:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 10:21:19 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6679-70-0NHHodHZ7Y@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10980|0 |1 is obsolete| | --- Comment #189 from Paul Poulain <paul.poulain at biblibre.com> --- Comment on attachment 10980 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10980 Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Print.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 12:21:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 10:21:33 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6679-70-XLgXxU5yc5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10979|0 |1 is obsolete| | --- Comment #190 from Paul Poulain <paul.poulain at biblibre.com> --- Comment on attachment 10979 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10979 Bug 6679 - [SIGNED-OFF] fix 4 perlcritic violations in C4/Creators/PDF.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 12:21:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 10:21:49 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6679-70-nA7np6wF3D@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10976|0 |1 is obsolete| | --- Comment #191 from Paul Poulain <paul.poulain at biblibre.com> --- Comment on attachment 10976 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10976 Bug 6679 - [SIGNED-OFF] fix 4 perlcritic violations in C4/Installer.pm This patch has been pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 12:24:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 10:24:04 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6679-70-NswC3MqhNR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #192 from Paul Poulain <paul.poulain at biblibre.com> --- Attachment that are still here either: * does not apply anymore * badly break Koha (resulting in a Perl error) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 12:25:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 10:25:23 +0000 Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in OPAC and staff client In-Reply-To: <bug-8377-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8377-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8377-70-owii6ly41a@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12373|0 |1 is obsolete| | --- Comment #22 from Mirko Tietgen <mirko at abunchofthings.net> --- Created attachment 12378 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12378&action=edit Bug 8377 [ENH] Show HTML5 video/ audio for media files in OPAC and staff client This enhancement uses information from MARC field 856 to generate the appropriate HTML5 code to embed am media player for the file(s) in a tab in the OPAC and staff client detail view. This patch supports the HTML5 <audio> and <video> element. Additionally it gives basic support for the <track> element. This element is not supported very well by recent browsers. Please consider the patch working when you get working video or audio. Changes since last version: - failed QA: removed default view for media tab, changed tab name to "Play audio" resp. "Play video". - put most of the code in separate module and access it from OPAC and staff client now, so the feature works in both - had to change sysprefs: HTML5MediaEnabled can be 'none', 'opac', 'staff' or 'both' * Removed default entry for mp3 again to not imply it is widely supported or going to be by free software browsers. If you tested this before, you need to delete the old syspref entries from your database. There is an attachment to do this, use exactly like upgradedatabase.pl. Test plan - Import attached test data. [I chose media typ 'bk' because it's probably present on most systems. It's not appropriate for the data but that doesn't matter.] - Rebuild zebra -b -z - Go to Administration->System preferences->enhanced content->HTML5 Media and set HTML5MediaEnabled to an appropriate setting, save preferences. - Search the OPAC or staff client for 'bug 8377' - Get 4 results - Open detail pages for results. Observe working video (1-3) or audio (4) player on detail page. Squashed both patches together Bug 8377 [ENH] Followup: Move perl module to C4 Bug 8377 [ENH] Followup: fix call for moved module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 12:35:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 10:35:22 +0000 Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in OPAC and staff client In-Reply-To: <bug-8377-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8377-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8377-70-zR4tM4LhJw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #23 from Mirko Tietgen <mirko at abunchofthings.net> --- Hi Paul, thanks a lot for reviewing the patch. I have - rebased to master - moved HTML5Media.pm to C4 - changed references to C4::HTML5Media.pm in catalogue/detail.pl and opac/opac-detail.pl - set up a sandbox to verify everything is OK http://catalogue.test7.biblibre.com/cgi-bin/koha/opac-search.pl?q=8377 http://pro.test7.biblibre.com/cgi-bin/koha/catalogue/search.pl?q=8377 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 13:31:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 11:31:58 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6679-70-pS9MnwWTbR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10938|1 |0 is obsolete| | --- Comment #193 from Paul Poulain <paul.poulain at biblibre.com> --- Comment on attachment 10938 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10938 Bug 6679 - [SIGNED-OFF] fix 9 perlcritic violations in C4/TmplTokenType.pm I just reverted this patch, as it break translator (missed to test it when I tested patches..) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 13:43:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 11:43:38 +0000 Subject: [Koha-bugs] [Bug 8726] Did you mean? plugin for broader/narrower/related terms In-Reply-To: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8726-70-6WQZmUnGe9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12186|0 |1 is obsolete| | --- Comment #10 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12379 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12379&action=edit Bug 8726: ExplodedTerms suggestion plugin (functionality) When working with hierarchical subject headings, it is sometimes helpful to do a search for all records with a specific subject, plus broader/narrower/related subjects. This patch adds a suggestion plugin for these "exploded" subject searches to Koha. Note that this patch depends on both bug 8211 AND bug 8209. To test (NOTE: this test plan covers both 8211 and 8726): 1) Make sure you have a bunch of hierarchical subjects. I created geographical subjects for "Arizona," "United States," and "Phoenix," and linked them together using 551s, and made sure I had a half dozen records linking to each (but not all to all three). 2) Do a search for su-br:Arizona (or choose "Subject and broader terms" on the advanced search screen with "more options" displayed), and check that you get the records with the subject "Arizona" and the records with the subject "United States" 3) Do a search for su-na:Arizona (or choose "Subject and narrower terms" on the advanced search screen with "more options" displayed), and check that you get the records with the subject "Arizona" and the records with the subject "Phoenix" 4) Do a search for su-rl:Arizona (or choose "Subject and related terms" on the advanced search screen with "more options" displayed), and check that you get the records with the subject "Arizona," the records with the subject "United States," and the records with the subject "Phoenix" 5) Ensure that other searches still work (keyword, subject, ccl, whatever) 6) Use "Did you mean?" page in admin section to enable ExplodedTerms plugin 7) Do a keyword search on the OPAC, confirm that searching for exploded terms is suggested. 8) Do a subject search on the OPAC, confirm that searching for exploded terms is suggested. 9) Do a non-keyword, non-subject search on the OPAC, confirm that searching for exploded terms is NOT suggested. 10) Disable ExplodedTerms plugin and enable AuthorityFile plugin. 11) Do search on OPAC, confirm suggestions are made from authority file. 12) Sign off Signed-off-by: wajasu <matted-34813 at mypacks.net> Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com> Split into two patches. This patch includes only the functionality. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 13:43:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 11:43:51 +0000 Subject: [Koha-bugs] [Bug 8726] Did you mean? plugin for broader/narrower/related terms In-Reply-To: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8726-70-VtmfqPlW5S@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 --- Comment #11 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12380 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12380&action=edit Bug 8726: ExplodedTerms suggestion plugin (jQueryUI) When working with hierarchical subject headings, it is sometimes helpful to do a search for all records with a specific subject, plus broader/narrower/related subjects. This patch adds a suggestion plugin for these "exploded" subject searches to Koha. Note that this patch depends on both bug 8211 AND bug 8209. To test (NOTE: this test plan covers both 8211 and 8726): 1) Make sure you have a bunch of hierarchical subjects. I created geographical subjects for "Arizona," "United States," and "Phoenix," and linked them together using 551s, and made sure I had a half dozen records linking to each (but not all to all three). 2) Do a search for su-br:Arizona (or choose "Subject and broader terms" on the advanced search screen with "more options" displayed), and check that you get the records with the subject "Arizona" and the records with the subject "United States" 3) Do a search for su-na:Arizona (or choose "Subject and narrower terms" on the advanced search screen with "more options" displayed), and check that you get the records with the subject "Arizona" and the records with the subject "Phoenix" 4) Do a search for su-rl:Arizona (or choose "Subject and related terms" on the advanced search screen with "more options" displayed), and check that you get the records with the subject "Arizona," the records with the subject "United States," and the records with the subject "Phoenix" 5) Ensure that other searches still work (keyword, subject, ccl, whatever) 6) Use "Did you mean?" page in admin section to enable ExplodedTerms plugin 7) Do a keyword search on the OPAC, confirm that searching for exploded terms is suggested. 8) Do a subject search on the OPAC, confirm that searching for exploded terms is suggested. 9) Do a non-keyword, non-subject search on the OPAC, confirm that searching for exploded terms is NOT suggested. 10) Disable ExplodedTerms plugin and enable AuthorityFile plugin. 11) Do search on OPAC, confirm suggestions are made from authority file. 12) Sign off Signed-off-by: wajasu <matted-34813 at mypacks.net> Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com> Split into two patches. This patch includes only the jQueryUI upgrade -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 13:44:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 11:44:04 +0000 Subject: [Koha-bugs] [Bug 8726] Did you mean? plugin for broader/narrower/related terms In-Reply-To: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8726-70-upc17KtrKg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 13:44:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 11:44:06 +0000 Subject: [Koha-bugs] [Bug 8726] Did you mean? plugin for broader/narrower/related terms In-Reply-To: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8726-70-1aSBLuSiMf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 --- Comment #12 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12381 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12381&action=edit Bug 8726 follow-up: fix perlcritic issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 13:50:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 11:50:56 +0000 Subject: [Koha-bugs] [Bug 8726] Did you mean? plugin for broader/narrower/related terms In-Reply-To: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8726-70-OttwIiyWSC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12381|0 |1 is obsolete| | --- Comment #13 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12382 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12382&action=edit Bug 8726 follow-up: fix QA issues Fixes several perlcritic complaints, and some overflow in the configuration page. Also notes that Did You Mean is not yet enabled on the staff client. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 13:53:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 11:53:43 +0000 Subject: [Koha-bugs] [Bug 8726] Did you mean? plugin for broader/narrower/related terms In-Reply-To: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8726-70-HKWkEiwUPB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12382|0 |1 is obsolete| | --- Comment #14 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12383 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12383&action=edit Bug 8726 follow-up: fix QA issues Fixes several perlcritic complaints, and some overflow in the configuration page. Also notes that Did You Mean is not yet enabled on the staff client. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 13:54:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 11:54:34 +0000 Subject: [Koha-bugs] [Bug 8726] Did you mean? plugin for broader/narrower/related terms In-Reply-To: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8726-70-Z9ESRtW2KE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 --- Comment #15 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Apologies for the long delay (and the number of patches I just obsoleted). Fixing the perlcritic warnings was much harder than anticipated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 13:59:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 11:59:29 +0000 Subject: [Koha-bugs] [Bug 8796] New: patron cards not starting on designated card Message-ID: <bug-8796-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 Priority: P5 - low Change sponsored?: --- Bug ID: 8796 Assignee: cnighswonger at foundations.edu Summary: patron cards not starting on designated card Severity: major Classification: Unclassified OS: All Reporter: nengard at gmail.com Hardware: All Status: NEW Version: rel_3_8 Component: Label printing Product: Koha When I put a number in "Enter starting card number" I am expecting it to start printing cards in that position the way it does in the label creator. However it always starts in the first position. I have tested and confirmed this in 3.8.4 and Master (as of this morning). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 14:03:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 12:03:14 +0000 Subject: [Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag In-Reply-To: <bug-7642-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7642-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7642-70-OJOqZ4bz5M@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #33 from Jonathan Druart <jonathan.druart at biblibre.com> --- QA Comments: - Remove an unused routine (rectify_weights) - Simplify tag weight management - add UT not blocker: - add a tabulation character in C4/Tags.pm (but a lot of already exist) - useless "use Data::Dumper" in Tags.t Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 14:04:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 12:04:07 +0000 Subject: [Koha-bugs] [Bug 8794] edit as duplicate for authorities In-Reply-To: <bug-8794-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8794-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8794-70-Fxj1R1vceE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8794 --- Comment #1 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- This makes sense as a feature. For the non-MARC21 catalogers, I just wanted to clarify when Nicole says "turn it into a subject heading" she is referring to adding free-floating subdivisions to the name for precomposd headings, not actually changing the authority type. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 14:10:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 12:10:04 +0000 Subject: [Koha-bugs] [Bug 8692] Authorities search form does not correspond to current search query In-Reply-To: <bug-8692-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8692-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8692-70-m5eFjgDzH2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8692 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_10 --- Comment #6 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 14:21:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 12:21:49 +0000 Subject: [Koha-bugs] [Bug 8726] Did you mean? plugin for broader/narrower/related terms In-Reply-To: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8726-70-XoZN40EZIY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 --- Comment #16 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 12384 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12384&action=edit Bug 8726: Followup FIX save didyoumean syspref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 14:24:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 12:24:47 +0000 Subject: [Koha-bugs] [Bug 2629] Diacritics not being ignored when searching In-Reply-To: <bug-2629-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2629-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2629-70-5OW9n3oQ4p@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2629 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6996|0 |1 is obsolete| | --- Comment #40 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12385 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12385&action=edit Bug 2629 - Diacritics not being ignored when searching - Map ? to u -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 14:25:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 12:25:03 +0000 Subject: [Koha-bugs] [Bug 2629] Diacritics not being ignored when searching In-Reply-To: <bug-2629-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2629-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2629-70-1ewqV43LHu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2629 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |ASSIGNED CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 14:25:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 12:25:18 +0000 Subject: [Koha-bugs] [Bug 2629] Diacritics not being ignored when searching In-Reply-To: <bug-2629-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2629-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2629-70-TQpN4QpIek@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2629 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 14:29:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 12:29:34 +0000 Subject: [Koha-bugs] [Bug 8746] rebuild_zebra_sliced.sh don't work where Record length of 106041 is larger than the MARC spec allows In-Reply-To: <bug-8746-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8746-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8746-70-9SLNIaAXlo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8746 --- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 12386 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12386&action=edit Bug 8746: rebuild_zebra_sliced.sh now export/index records as MARCXML This avoid indexing failures due to "bad offset" or "bad length" error with ISO2709 format + minor improvements: - --length parameter is optional. If not given, it will execute the right sql query to find the number of records to index - new parameter --reset-index. If set, index is reset before indexing -- Exporting multiple records in the same ISO2709 file can cause problems. If one record is wrong (say a record is longer than 99999 bytes, for example), then all following records won't be parsed correctly. For example yaz-marcdump refuse to read records that follow a malformed record. This cause problems in rebuild_zebra_sliced.sh because yaz-marcdump is used to count the number of records contained in one file. So the workaround used here is to export in MARCXML. yaz-marcdump can't split MARCXML files so a piece of Perl code is used instead (I didn't succeed to achieve this job with POSIX tools) To test you can create a biblio record longer than 99999 bytes and try to index a range of biblionumbers that contain it. On master indexation of this record should fail and this should succeed with this patch. (Records longer than 99999 bytes seem to not alter indexation of following records. I've encountered this behaviour with badly encoded records) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 14:29:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 12:29:44 +0000 Subject: [Koha-bugs] [Bug 8746] rebuild_zebra_sliced.sh don't work where Record length of 106041 is larger than the MARC spec allows In-Reply-To: <bug-8746-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8746-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8746-70-JmuECQyOUZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8746 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 14:32:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 12:32:29 +0000 Subject: [Koha-bugs] [Bug 8726] Did you mean? plugin for broader/narrower/related terms In-Reply-To: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8726-70-I9KU25ewbI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Jonathan Druart <jonathan.druart at biblibre.com> --- Unit tests failed now :-/ Marked as Failed QA. Can't use string ("AuthorityFile") as an ARRAY ref while "strict refs" in use at /home/koha/Koha/SuggestionEngine.pm line 91. Can't use string ("ExplodedTerms") as an ARRAY ref while "strict refs" in use at /home/koha/Koha/SuggestionEngine.pm line 91. Can't use string ("ABCD::EFGH::IJKL") as an ARRAY ref while "strict refs" in use at /home/koha/Koha/SuggestionEngine.pm line 91. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 14:33:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 12:33:57 +0000 Subject: [Koha-bugs] [Bug 7684] inventory : datatable fix actions etc. In-Reply-To: <bug-7684-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7684-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7684-70-oVjMBr8b7Q@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Matthias Meusburger <matthias.meusburger at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11843|0 |1 is obsolete| | --- Comment #13 from Matthias Meusburger <matthias.meusburger at biblibre.com> --- Created attachment 12387 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12387&action=edit Bug 7684: multiple fixes for inventory * when a file was uploaded and the comparison with catalogue range requested, the comparison was wrong: the logic was wrong * items that were not supposed to be scanned (ie: supposed to be on another shelf) didn't had the author and title, it was hard to retrieve them on the shelved * some useful fields were missing, like homebranch, location, status * the CSV export contained all the item information. It should contain the same informations as the screen Behaviour now: * scan a list of barcode & select a range of location * if a barcode has been scanned and should not be (mis placed item), the information is displayed * if you choose "compare barcodes list to result option", the resulting list contains all items that have been scanned and those that were supposed to be. Any item not in both list appears with a specific message on the last column -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 14:34:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 12:34:47 +0000 Subject: [Koha-bugs] [Bug 7684] inventory : datatable fix actions etc. In-Reply-To: <bug-7684-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7684-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7684-70-SYwKP97BCb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Matthias Meusburger <matthias.meusburger at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #14 from Matthias Meusburger <matthias.meusburger at biblibre.com> --- This new patch removes the .tmpl file and adds the .tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 14:52:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 12:52:13 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6679-70-SIemUdWWZ3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10965|1 |0 is obsolete| | --- Comment #194 from Paul Poulain <paul.poulain at biblibre.com> --- Comment on attachment 10965 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10965 Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in C4/Installer/PerlModules.pm This patch has been reverted = jenkins complain: perl t/Installer_pm.t 1..4 ok 1 - use C4::Installer::PerlModules; ok 2 - The object isa C4::Installer::PerlModules ok 3 - returns numeric version not ok 4 - returns correct version # Failed test 'returns correct version' # at t/Installer_pm.t line 23. # Looks like you failed 1 test of 4. After reverting, t/Installer_pm.t is OK Maybe that's the test that must be upgraded, but until it's done, this patch is reverted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 15:00:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 13:00:24 +0000 Subject: [Koha-bugs] [Bug 8606] Talking Tech broken by user-configurable slips feature In-Reply-To: <bug-8606-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8606-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8606-70-VPHBHO5NK8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8606 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 Severity|enhancement |normal --- Comment #9 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master I thin it's more a bugfix than en ENH. Switching to "normal" severity, probably expected for 3.8 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 15:12:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 13:12:32 +0000 Subject: [Koha-bugs] [Bug 8262] Could not add or create List in koha 3.8.1 In-Reply-To: <bug-8262-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8262-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8262-70-H3m73dU1r7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8262 verolencinas <verolencinas at yahoo.com.ar> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |verolencinas at yahoo.com.ar Resolution|--- |FIXED --- Comment #2 from verolencinas <verolencinas at yahoo.com.ar> --- The problem is solved if you create the list logged in as a normal user (not kohaadmin). If you try to create a list logged in as administrator, you don't have a borrowernumber and koha can't create lists who don't belong to a user. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 15:19:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 13:19:21 +0000 Subject: [Koha-bugs] [Bug 7913] Automatically receive serial issues In-Reply-To: <bug-7913-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7913-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7913-70-VqycJb4wAV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7913 --- Comment #12 from Koha Team Lyon 3 <koha at univ-lyon3.fr> --- Created attachment 12388 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12388&action=edit Follow-up, hide multi receive button for subs with items Here it is. I also add add a button in edit page (it's just a redirection to serials-collection functionality) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 15:19:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 13:19:35 +0000 Subject: [Koha-bugs] [Bug 7913] Automatically receive serial issues In-Reply-To: <bug-7913-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7913-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7913-70-qW9r4AjBVK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7913 Koha Team Lyon 3 <koha at univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 15:32:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 13:32:39 +0000 Subject: [Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location. In-Reply-To: <bug-7720-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7720-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7720-70-vlnSy5ekrT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11092|0 |1 is obsolete| | --- Comment #41 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12389 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12389&action=edit Bug 7720 - Ambiguity in OPAC Details location. Currently, in opac-detail.pl, there exists a column named 'Location'. This column lists the name of the holding branch, and the item's location description. This can cause confusion to borrowers, as they may assume that the holding branch is the *owning* branch (homebranch) of an item. This could cause a situation where a borrower waits for an item to be returned to his or her library, only to find that the library never owned that item, and it was transferred back to it's homebranch. It could also lead a borrower to falsely assume that his or her home library does not own a copy of a particular item because the borrower does not see an his or her home library listed for any of the items on the record. In addition, even when the holding branch is different than the home branch, the item's shelving location is displayed, even though that branch may not use that location. This commit makes the item details table equivilent to the intranet details page by adding a "Home Library" column, which displays the item's home library, as well as the shelving location. If singleBranchMode is enabled, this column disappears and the "Location" column displays the shelving location only. This commit adds two new system preferences: OpacLocationBranchToDisplay, which defines whether to display the holding library, the home library, or both for the opac details page. OpacLocationBranchToDisplayShelving, which defines where the shelving location should be displayed, under the home library, the holding library, or both. http://bugs.koha-community.org/show_bug.cgi?id=7220 http://bugs.koha-community.org/show_bug.cgi?id=3556 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 15:35:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 13:35:23 +0000 Subject: [Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location. In-Reply-To: <bug-7720-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7720-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7720-70-MEKU4unPVT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #42 from Kyle M Hall <kyle at bywatersolutions.com> --- > - The column of item-level holds is not displayed. Even in cases where there > is an item-level hold the column is empty. I'm not sure what you are referring to here. Could you post an before/after screenshot? > - The patch violates capitalization guidelines (Bug 2780) ("Current > location" and "Home Library"). Fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 15:35:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 13:35:33 +0000 Subject: [Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location. In-Reply-To: <bug-7720-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7720-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7720-70-iLeRS19fHn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 15:40:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 13:40:09 +0000 Subject: [Koha-bugs] [Bug 8797] New: can't delete quote of the day Message-ID: <bug-8797-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8797 Priority: P5 - low Change sponsored?: --- Bug ID: 8797 Assignee: cnighswonger at foundations.edu Summary: can't delete quote of the day Severity: normal Classification: Unclassified OS: All Reporter: nengard at gmail.com Hardware: All Status: NEW Version: master Component: Tools Product: Koha I am documenting the QOTD feature and trying to delete a quote, but it's not letting me do it. I click on the quote id number and nothing happens - the row isn't highlighted or anything and so I can't delete. I'm on FF on Mac. If I click to add a new quote and don't enter any data then I can click on the ID column of the new empty quote and delete it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 15:45:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 13:45:35 +0000 Subject: [Koha-bugs] [Bug 8726] Did you mean? plugin for broader/narrower/related terms In-Reply-To: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8726-70-UjNiPmxdKZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12383|0 |1 is obsolete| | --- Comment #18 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12390 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12390&action=edit Bug 8726 follow-up: fix QA issues Fixes several perlcritic complaints, and some overflow in the configuration page. Also notes that Did You Mean is not yet enabled on the staff client. Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com> Sorry about the problematic last attempt at uploading. I missed a patch when squashing. It is now included. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 15:45:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 13:45:49 +0000 Subject: [Koha-bugs] [Bug 8726] Did you mean? plugin for broader/narrower/related terms In-Reply-To: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8726-70-BJ2WoQcfAM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 15:45:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 13:45:51 +0000 Subject: [Koha-bugs] [Bug 8726] Did you mean? plugin for broader/narrower/related terms In-Reply-To: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8726-70-s76DFcwWe8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12384|0 |1 is obsolete| | --- Comment #19 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12391 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12391&action=edit Bug 8726: Followup FIX save didyoumean syspref Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 15:47:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 13:47:40 +0000 Subject: [Koha-bugs] [Bug 8557] in orderreceive.tt and serials-edit.tt the use of a barcode scan send the form unexpectedly In-Reply-To: <bug-8557-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8557-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8557-70-aVXnQK6SxW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8557 Christophe Croullebois <christophe.croullebois at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |christophe.croullebois at bibl |ity.org |ibre.com --- Comment #1 from Christophe Croullebois <christophe.croullebois at biblibre.com> --- Created attachment 12392 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12392&action=edit proposed patch thx for testing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 16:03:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 14:03:04 +0000 Subject: [Koha-bugs] [Bug 8797] can't delete quote of the day In-Reply-To: <bug-8797-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8797-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8797-70-OLAOXchUFI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8797 --- Comment #1 from Nicole C. Engard <nengard at gmail.com> --- By the way, it does work on the import quotes screen - if I want to delete quotes from there they highlight when I click on the ID with no problem. Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 16:12:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 14:12:26 +0000 Subject: [Koha-bugs] [Bug 7471] z39.50 search propagation from empty results prepends kw, wrdl to search terms In-Reply-To: <bug-7471-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7471-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7471-70-oVUVGaPwCW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7471 Gaetan Boisson <gaetan.boisson at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |gaetan.boisson at biblibre.com Resolution|--- |DUPLICATE --- Comment #1 from Gaetan Boisson <gaetan.boisson at biblibre.com> --- *** This bug has been marked as a duplicate of bug 5645 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 16:12:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 14:12:26 +0000 Subject: [Koha-bugs] [Bug 5645] Z39.50 search from search results not parsing query correctly In-Reply-To: <bug-5645-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5645-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5645-70-EOT29smekt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5645 Gaetan Boisson <gaetan.boisson at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #1 from Gaetan Boisson <gaetan.boisson at biblibre.com> --- *** Bug 7471 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 16:13:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 14:13:17 +0000 Subject: [Koha-bugs] [Bug 8557] in orderreceive.tt and serials-edit.tt the use of a barcode scan send the form unexpectedly In-Reply-To: <bug-8557-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8557-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8557-70-iCzjgEAr5k@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8557 Christophe Croullebois <christophe.croullebois at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12392|0 |1 is obsolete| | --- Comment #2 from Christophe Croullebois <christophe.croullebois at biblibre.com> --- Created attachment 12393 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12393&action=edit proposed patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 16:14:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 14:14:21 +0000 Subject: [Koha-bugs] [Bug 5645] Z39.50 search from search results not parsing query correctly In-Reply-To: <bug-5645-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5645-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5645-70-i0JPEtvGju@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5645 Gaetan Boisson <gaetan.boisson at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gaetan.boisson at biblibre.com --- Comment #2 from Gaetan Boisson <gaetan.boisson at biblibre.com> --- Confirmed, still a bug. See Liz Rea's screenshot from bug 7471 : http://screencast.com/t/Zi2saYeF9sz -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 16:16:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 14:16:35 +0000 Subject: [Koha-bugs] [Bug 7595] Add branchcode to accountlines In-Reply-To: <bug-7595-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7595-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7595-70-d14LVxrAnt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8162|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12394 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12394&action=edit [SIGNED-OFF] Bug 7595 - Add branchcode to accountlines Adds a branchcode column to the accountlines table. For payments, this inserts the branchcode of the library where the payment was recorded. For manual invoices, it insert the branchcode of the library where the manual invoice was created. Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com> I tested with creating manual invoices, and paying partial fines, entire fine lines, and writing off fines. All actions record the branch where the action took place properly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 16:16:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 14:16:59 +0000 Subject: [Koha-bugs] [Bug 8557] in orderreceive.tt and serials-edit.tt the use of a barcode scan send the form unexpectedly In-Reply-To: <bug-8557-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8557-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8557-70-f1T3Qay6OW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8557 Christophe Croullebois <christophe.croullebois at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 16:17:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 14:17:10 +0000 Subject: [Koha-bugs] [Bug 7595] Add branchcode to accountlines In-Reply-To: <bug-7595-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7595-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7595-70-LaYulkWMp6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 --- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12395 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12395&action=edit Bug 7595 - Add branchcode to accountlines - Followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 16:20:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 14:20:43 +0000 Subject: [Koha-bugs] [Bug 8509] Allowing the Expected status even if another status has been saved In-Reply-To: <bug-8509-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8509-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8509-70-Bz6AhAwlo6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8509 --- Comment #1 from Adrien SAURAT <adrien.saurat at biblibre.com> --- Created attachment 12396 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12396&action=edit proposed patch TEST PLAN Receive serials. Change a serial from Expected to another status. Come back to the receive page. Before patch : the serial cannot be set to Expected anymore After patch : the Expected status still appear in the select box and can be used -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 16:20:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 14:20:54 +0000 Subject: [Koha-bugs] [Bug 8509] Allowing the Expected status even if another status has been saved In-Reply-To: <bug-8509-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8509-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8509-70-frxU22xRkl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8509 Adrien SAURAT <adrien.saurat at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 16:24:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 14:24:59 +0000 Subject: [Koha-bugs] [Bug 7595] Add branchcode to accountlines In-Reply-To: <bug-7595-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7595-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7595-70-VGsmOL7tYc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 16:42:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 14:42:19 +0000 Subject: [Koha-bugs] [Bug 8726] Did you mean? plugin for broader/narrower/related terms In-Reply-To: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8726-70-wFBqdgTw2l@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #20 from Jonathan Druart <jonathan.druart at biblibre.com> --- Now all seem good to me. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 17:08:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 15:08:43 +0000 Subject: [Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices In-Reply-To: <bug-6030-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6030-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6030-70-td4arav0us@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 wajasu <matted-34813 at mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12231|0 |1 is obsolete| | --- Comment #26 from wajasu <matted-34813 at mypacks.net> --- Created attachment 12397 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12397&action=edit SIGNED-OFF-Bug-6030-followup-Specify-biblio.title-as.patch restored single quotes around END_SQL to be double quotes and $date error is gone. wajasu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 17:56:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 15:56:44 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-EZrAu0P10P@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #58 from Paul Poulain <paul.poulain at biblibre.com> --- QA comment: * why is CourseReserve in Circulation tab ? Sounds strange to me (not a reason to fail QA) * Authorised_values = hardcoded ones are usually hardcoded on admin/authorised_values.pl. I think you can add safely DEPARTMENT and TERM. Even if there is no DEPARTMENT And TERM, they appear, and the user know they are here. Look here: foreach (qw(Asort1 Asort2 Bsort1 Bsort2 SUGGEST DAMAGED LOST REPORT_GROUP REPORT_SUBGROUP)) { (in admin/authorised_values.pl) * I've added a DEPARTMENT: "D?partement Sciences". On course.pl, I get a nasty: D?partement Lettres after saving my 1st course (the diacritic reencoded or something like that) I've added a diacritic to my TERM, and same problem: 2eme trimestre ????. other fields are OK. I've checked other authorised values (like in cataloguing, no encoding problem, it's specific to course.pl) * GRRR... you don't respect HTML4 coding guideline : "Add Reserves" should be "Add reserves". There are many many strings like that * Step 2 of course/add_items.pl, I'm not sure I understand why& when collection/itemtype/location/branch should change, and when it will. Some documentation (online help ?) welcomed ! * After adding a reserve to my course I see my branchname encoding broken as well: Unchanged (M?diath?que Cannet des Maures) * After adding a reserve to my course, I see that the itemtype is "Unchanged ()" the () make me think you don't handle the case where items.itype is empty, the itemtype is in biblioitems.itemtype (that's what I have in my database) * I use the ccsr theme for OPAC, and couldn't find where I could access opac-course.pl. I understood it's because you add a line to masthead.inc +[% IF ( UseCourseReserves ) %]<span class="pipe"> | </span><a href="/cgi-bin/koha/opac-course-reserves.pl">Course Reserves</a>[% END %] that is not in ccsr masthead.inc Please add it ! *Something I don't understand functionnally: I places a course reserve on an item that was on loan. When I check-in the document, nothing happens (ie: i'm not warned the item is for "course X" or something like that. Is it the expected behaviour ? Some functionnal explanations are worth... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 18:03:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 16:03:27 +0000 Subject: [Koha-bugs] [Bug 5356] Shipping billing address improvements In-Reply-To: <bug-5356-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5356-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5356-70-bzuomeBuyu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 --- Comment #31 from Paul Poulain <paul.poulain at biblibre.com> --- QA comment: I think this line is wrong: + basketgroupdeliveryplace => C4::Branch::GetBranchName( $basketgroup->{deliveryplace} ) || C4::Branch::GetBranchName( $basketgroup->{freedeliveryplace} ), C4::Branch::GetBranchName( $basketgroup->{freedeliveryplace} ) will never work, because freedeliveryplace is free, so not related to a branch code ! do we agree ? (found this problem when checking if freedeliveryplace had been removed from your patches ;-) ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 18:05:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 16:05:32 +0000 Subject: [Koha-bugs] [Bug 8687] Improvements in overdue_notices.pl In-Reply-To: <bug-8687-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8687-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8687-70-NWZnvpFy7j@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #7 from M. Tompsett <mtompset at hotmail.com> --- There are several scripts in the bin directory that use similar logic that trigger the last perlcritic error. My rough idea was to do a "push @INC" for the variable part, that way the require could just be the library name itself. Haven't tested it. Just a brain storming thought I had. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 18:29:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 16:29:49 +0000 Subject: [Koha-bugs] [Bug 5335] More granular VAT In-Reply-To: <bug-5335-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5335-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5335-70-o3dLsnIfIE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #46 from Paul Poulain <paul.poulain at biblibre.com> --- QA comment: * passes koha-qa.pl * a big patch, but not so much code. A lot is made of cleaning / change in indentation/... like - $line{booksellerid} = $booksellerid; + $line{booksellerid} = $booksellerid; * I'm not sure the following change - $biblionumber, $ordernumber, $quantityrec, $user, $unitprice, - $invoiceid, $replacement, undef, $datereceived, \@received_items); + $biblionumber, + $ordernumber, + $quantityrec, + $user, + $order->{unitprice}, + $order->{ecost}, + $invoiceno, + $order->{rrp}, + undef, + $datereceived, + \@received_items, + ); is very desirable, but I won't fail QA for that * I'm not sure that t/db_dependent/lib/KohaTest/* is used, so the (tiny) changes here are probably useless. Conclusion = Passed QA ! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 18:45:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 16:45:11 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7736-70-ywXKo1ft58@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Colin Campbell <colin.campbell at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10226|0 |1 is obsolete| | --- Comment #12 from Colin Campbell <colin.campbell at ptfs-europe.com> --- Created attachment 12398 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12398&action=edit Revised Patch This is a revised patch reflecting the EDI as currently running in production. It needs in addition an entry to the db upgrade script, however the location of the code is more standard than in the previous;y submitted patch, small changes have been incorporated and I've addressed some issues that would have triggered failures in critic tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 19:20:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 17:20:29 +0000 Subject: [Koha-bugs] [Bug 8233] New search engine layer - introduce solr without breaking anything else In-Reply-To: <bug-8233-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8233-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8233-70-kopuohXB45@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233 --- Comment #38 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Please sign so we can have .deb packages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 19:27:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 17:27:37 +0000 Subject: [Koha-bugs] [Bug 5333] Undefined value stops import from z39.50 In-Reply-To: <bug-5333-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5333-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5333-70-Zec1ZhZrDc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5333 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Still present on 3.8.x. This code should be removed and the related preferences too, until we have proper crosswalks to do this well. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 19:36:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 17:36:20 +0000 Subject: [Koha-bugs] [Bug 6398] Holidays cause date due to be improperly calculated In-Reply-To: <bug-6398-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6398-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6398-70-rP9oKpat0v@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6398 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED CC| |tomascohen at gmail.com Resolution|--- |DUPLICATE --- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- *** This bug has been marked as a duplicate of bug 8418 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 19:36:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 17:36:20 +0000 Subject: [Koha-bugs] [Bug 8418] Koha::Calendar is_holiday ignores all user data In-Reply-To: <bug-8418-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8418-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8418-70-nla64KsW3m@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8418 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org --- Comment #29 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- *** Bug 6398 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 19:40:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 17:40:35 +0000 Subject: [Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices In-Reply-To: <bug-6030-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6030-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6030-70-3fdPVy71c9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 wajasu <matted-34813 at mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply CC| |matted-34813 at mypacks.net --- Comment #27 from wajasu <matted-34813 at mypacks.net> --- The Bug 6030 follow-up needs to be adjusted so the patch will apply. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 20:07:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 18:07:26 +0000 Subject: [Koha-bugs] [Bug 8600] Remove search terms in advanced search In-Reply-To: <bug-8600-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8600-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8600-70-1FKmwi7nRw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8600 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11454|0 |1 is obsolete| | --- Comment #8 from Marc V?ron <veron at veron.ch> --- Created attachment 12399 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12399&action=edit Bug 8600 - Remove search terms in advanced search Enhanced version with better handling of [+] and [-] buttons. [+] adds new fields aftert current line [-] removes current line [-] is not visible if only one line left Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 20:20:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 18:20:15 +0000 Subject: [Koha-bugs] [Bug 8600] Remove search terms in advanced search In-Reply-To: <bug-8600-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8600-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8600-70-wHV2eXLG31@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8600 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 20:23:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 18:23:48 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-tABmMBxxki@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #59 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to comment #58) > QA comment: > * why is CourseReserve in Circulation tab ? Sounds strange to me (not a > reason to fail QA) I'm nor sure what you mean by this. Could you post a screen shot? > * Authorised_values = hardcoded ones are usually hardcoded on > admin/authorised_values.pl. I think you can add safely DEPARTMENT and TERM. > Even if there is no DEPARTMENT And TERM, they appear, and the user know they > are here. > Look here: > foreach (qw(Asort1 Asort2 Bsort1 Bsort2 SUGGEST DAMAGED LOST > REPORT_GROUP REPORT_SUBGROUP)) { > (in admin/authorised_values.pl) Will fix. > * I've added a DEPARTMENT: "D?partement Sciences". On course.pl, I get a > nasty: > D?partement Lettres after saving my 1st course (the diacritic reencoded or > something like that) I've added a diacritic to my TERM, and same problem: > 2eme trimestre ????. other fields are OK. I've checked other authorised > values (like in cataloguing, no encoding problem, it's specific to course.pl) I cannot really say. It must have something to due with the AuthorisedValues plugin. If I use Dumper from the template, I get this: $VAR1 = "D\x{e9}partement Sciences"; \x{e9} is indeed the code for ?. The select pulldown for TERM and DEPARTMENT on the course edit page look fine, but they use GetAuthorisedValues passed in as a template parameter, rather than the TT plugin. I have no idea what is going on here. > * GRRR... you don't respect HTML4 coding guideline : "Add Reserves" should > be "Add reserves". There are many many strings like that Sorry! I though I had caught all those. I've gone through the template again and I think I've probably fixed them all now. > * Step 2 of course/add_items.pl, I'm not sure I understand why& when > collection/itemtype/location/branch should change, and when it will. Some > documentation (online help ?) welcomed ! The idea is to be able to change those fields while the item is on reserve for at least one course. This is so we can change the circulation rules. For example, an item might have a loan period of 2 weeks, but if it is on reserve for an active course, it may change itemtypes and now have a loan period of 2 hours. > * After adding a reserve to my course I see my branchname encoding broken > as well: Unchanged (M?diath?que Cannet des Maures) Again, it seems to be related to the plugin, but I don't know how to fix it :( > * After adding a reserve to my course, I see that the itemtype is > "Unchanged ()" the () make me think you don't handle the case where > items.itype is empty, the itemtype is in biblioitems.itemtype (that's what I > have in my database) I don't think this feature can play well with bib-level itemtypes. If one record had 5 items and only 1 was on course reserve, it would change the itemtype for all 5! I think I could just hide the itemtype field in the case that itemtypes are set to bib-level, rather than item-level. > * I use the ccsr theme for OPAC, and couldn't find where I could access > opac-course.pl. I understood it's because you add a line to masthead.inc > +[% IF ( UseCourseReserves ) %]<span class="pipe"> | </span><a > href="/cgi-bin/koha/opac-course-reserves.pl">Course Reserves</a>[% END %] > that is not in ccsr masthead.inc > Please add it ! Will do! > *Something I don't understand functionnally: I places a course reserve on > an item that was on loan. When I check-in the document, nothing happens (ie: > i'm not warned the item is for "course X" or something like that. Is it the > expected behaviour ? Some functionnal explanations are worth... That is indeed expected behavior. The course reserves system was written based on a specification I was given. I will definitely work with Nicole to make sure it is fully documented in the manual. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 20:24:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 18:24:31 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-oXAxliuCBM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #60 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12400 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12400&action=edit Bug 8215 - Add Course Reserves - QA Followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 20:28:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 18:28:20 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-YagplIB8jQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 20:34:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 18:34:34 +0000 Subject: [Koha-bugs] [Bug 8680] Z39.50 searches for ISBN/ISSN problematic in the Acquistions Module In-Reply-To: <bug-8680-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8680-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8680-70-nU35pxIVd1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8680 --- Comment #1 from Joseph Alway <jbalway at gmail.com> --- Created attachment 12401 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12401&action=edit Z39.50 ISBN Search is problematic and there is a missing ISSN field. The changes made a duplicate fixes. Bug 8550 was for the Cataloguing module. Bug 8680 is for the Acquisitions module. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 20:35:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 18:35:40 +0000 Subject: [Koha-bugs] [Bug 8600] Remove search terms in advanced search In-Reply-To: <bug-8600-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8600-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8600-70-MbH0Eb9dDE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8600 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12399|0 |1 is obsolete| | --- Comment #9 from Marc V?ron <veron at veron.ch> --- Created attachment 12402 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12402&action=edit Bug 8600 - Remove search terms in advanced search Enhanced version with better handling of [+] and [-] buttons. [+] adds new fields aftert current line [-] removes current line [-] is not visible if only one line left Marc Rebased... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 20:36:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 18:36:04 +0000 Subject: [Koha-bugs] [Bug 8680] Z39.50 searches for ISBN/ISSN problematic in the Acquistions Module In-Reply-To: <bug-8680-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8680-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8680-70-G8hPeQxc5i@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8680 Joseph Alway <jbalway at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 21:51:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 19:51:09 +0000 Subject: [Koha-bugs] [Bug 8798] New: Add the use of DBIx::Class Message-ID: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 Priority: P5 - low Change sponsored?: --- Bug ID: 8798 Assignee: gmcharlt at gmail.com Summary: Add the use of DBIx::Class Severity: enhancement Classification: Unclassified OS: All Reporter: elliott at bywatersolutions.com Hardware: All Status: NEW Version: master Component: Database Product: Koha This bug will lay the foundation for using DBIx::Class. It will also include the class files from the automated class generator. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 21:51:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 19:51:56 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8798-70-GDUmWwuh3T@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 Elliott Davis <elliott at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Blocks| |5837 Assignee|gmcharlt at gmail.com |elliott at bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 21:51:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 19:51:56 +0000 Subject: [Koha-bugs] [Bug 5837] Change installer to use DBIx::Class::Schema::Versioned instead of updatedatabase.pl In-Reply-To: <bug-5837-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5837-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5837-70-ghe8KTtd33@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5837 Elliott Davis <elliott at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8798 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 23:14:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 21:14:18 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8798-70-Cu3a4S08hO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 --- Comment #1 from Elliott Davis <elliott at bywatersolutions.com> --- Created attachment 12403 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12403&action=edit Added base class files for all tables in koha using the DBIx::Class::Schema::Loader Added a (very basic) test file for C4::Context -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 23:17:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 21:17:14 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8798-70-HOJctP9CIU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 Elliott Davis <elliott at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #2 from Elliott Davis <elliott at bywatersolutions.com> --- This patch adds the Class files for the Koha Database and generated the Schema file for DBIx::Class. C4::Context has been modified to add a ->schema handle so that new code may take advantage of DBIx::Class. To Test: Install patch Make sure you can still connect to Koha Done! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 23:46:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 21:46:43 +0000 Subject: [Koha-bugs] [Bug 8687] Improvements in overdue_notices.pl In-Reply-To: <bug-8687-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8687-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8687-70-fX8vYdYRlY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687 --- Comment #8 from wajasu <matted-34813 at mypacks.net> --- Created attachment 12404 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12404&action=edit Bug-8667-cleaned-up-perlcritic-complaints-aligned-usage with POD doc fixed perlcritic, tested with email, -html, -html 'odue' i see: title;name;surname;address1;address2;zipcode;city;email;itemcount;itemsinfo;due_date;issue_date in my emails, and think that probably needs to get restricted to only csv requests. maybe 6030 will address that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 20 23:46:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 21:46:59 +0000 Subject: [Koha-bugs] [Bug 8687] Improvements in overdue_notices.pl In-Reply-To: <bug-8687-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8687-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8687-70-9gSB33KPra@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687 wajasu <matted-34813 at mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |matted-34813 at mypacks.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 00:58:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 20 Sep 2012 22:58:43 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8798-70-bGKUyfgmTN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 wajasu <matted-34813 at mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |matted-34813 at mypacks.net --- Comment #3 from wajasu <matted-34813 at mypacks.net> --- I need you to add the dependency to koha_perl_deps.pl. This way we can drive any workflow for derived artifacts (koha-common, etc) Also, possibly investigate updating any debian packages list. Note: We may want to let someone benchmark if it does load modules, on each request. I was thinking we would right a plack based repo service that we can call and keep DBIx out of apps/modules, but maybe that too much, we'll see. I'm excited about this. Bringing in an ORM. Got to get the ball rolling. wajasu koha at biblio:~/kohaclone$ prove t/Context.t t/Context.t .. 1/1 # Failed test 'use C4::Context;' # at t/Context.t line 9. # Tried to use 'C4::Context'. # Error: Base class package "DBIx::Class::Schema" is empty. # (Perhaps you need to 'use' the module which defines that package first, # or make that module available in @INC (@INC contains: /home/koha/kohaclone /etc/perl /usr/local/lib/perl/5.10.1 /usr/local/share/perl/5.10.1 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.10 /usr/share/perl/5.10 /usr/local/lib/site_perl .). # at /home/koha/kohaclone/Koha/Schema.pm line 9. # BEGIN failed--compilation aborted at /home/koha/kohaclone/Koha/Schema.pm line 9. # Compilation failed in require at /home/koha/kohaclone/C4/Context.pm line 102. # BEGIN failed--compilation aborted at /home/koha/kohaclone/C4/Context.pm line 102. # Compilation failed in require at (eval 6) line 2. # BEGIN failed--compilation aborted at (eval 6) line 2. # Looks like you failed 1 test of 1. t/Context.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests Test Summary Report ------------------- t/Context.t (Wstat: 256 Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 1 Files=1, Tests=1, 1 wallclock secs ( 0.02 usr 0.01 sys + 0.06 cusr 0.00 csys = 0.09 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 02:39:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 00:39:36 +0000 Subject: [Koha-bugs] [Bug 8799] New: Non-existing analytics field triggers error log Message-ID: <bug-8799-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8799 Priority: P5 - low Change sponsored?: --- Bug ID: 8799 Assignee: oleonard at myacpl.org Summary: Non-existing analytics field triggers error log Severity: minor Classification: Unclassified OS: All Reporter: mtompset at hotmail.com Hardware: All Status: NEW Version: unspecified Component: OPAC Product: Koha [Wed Sep 19 18:53:14 2012] [error] [client 192.168.100.2] [Wed Sep 19 18:53:14 2012] opac-search.pl: Use of uninitialized value in split at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 394. This is the end of a loop, which generally means the loop condition is the problem. my $analyticfield = '773'; if ($marcflavour eq 'MARC21' || $marcflavour eq 'NORMARC'){ $analyticfield = '773'; } elsif ($marcflavour eq 'UNIMARC') { $analyticfield = '461'; } foreach my $hostfield ( $record->field($analyticfield)) { I am positive that our records do not have any 773 fields. So a simple if (defined(...)) { ... } around the loop should solve the error log flooding, as analytic fields are not required, as far as I know. This applies to 3.6.x, 3.8.x, and master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 03:37:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 01:37:13 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8798-70-hyqhCt5KHh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 Elliott Davis <elliott at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12403|0 |1 is obsolete| | --- Comment #4 from Elliott Davis <elliott at bywatersolutions.com> --- Created attachment 12405 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12405&action=edit Added base class files for all tables in koha using the DBIx::Class::Schema::Loader Added a (very basic) test file for C4::Context Also added dependencies in required files. To Test: Install patch Make sure you can still connect to Koha Done! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 03:37:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 01:37:30 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8798-70-UFZAu9Uwd6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 Elliott Davis <elliott at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 07:31:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 05:31:14 +0000 Subject: [Koha-bugs] [Bug 8700] RESERVESLIP fields not being replaced correctly In-Reply-To: <bug-8700-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8700-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8700-70-Ee3fmBaM6r@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8700 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11877|0 |1 is obsolete| | --- Comment #4 from Marc V?ron <veron at veron.ch> --- Created attachment 12406 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12406&action=edit [SIGNED-OFF] Bug 8700 - RESERVESLIP fields not being replaced correctly The slip RESERVESLIP is not replacing fields correctly. C4::Reserves::ReserveSlip calls C4::Letters::GetPreparedLetter, and passes the $reserve hashref to it for each table except branches ( which is passed the branchcode ). The problem is, if you pass a hashref for a table, it uses that hashref for the replacing, rather than looking up the data from the database. Fixed by passing the correct keys for each of the tables requested. Signed-off-by: Marc Veron <veron at veron.ch> Tested following the test plan. Could reproduce the bug. After applying the patch slip printed as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 07:31:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 05:31:53 +0000 Subject: [Koha-bugs] [Bug 8700] RESERVESLIP fields not being replaced correctly In-Reply-To: <bug-8700-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8700-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8700-70-6Hn0Od5ntK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8700 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 09:02:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 07:02:13 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8798-70-bIeGDIuF8F@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 wajasu <matted-34813 at mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from wajasu <matted-34813 at mypacks.net> --- I tried again. I tried to apt-get libdbic-class-schema-loader-perl ^ x so i loaded it with an x instead. I also needed to change DBIC to DBIx in C4/Installer/PerlDependencies.pm I'll leave it to you to fix. So I can signoff tomorrow. After those i tried: koha at biblio:~/kohaclone$ prove t/Context.t t/Context.t .. 1/1 # Failed test 'use C4::Context;' # at t/Context.t line 9. # Tried to use 'C4::Context'. # Error: Undefined subroutine &DBIx::Class::Exception::blessed called at /usr/share/perl5/DBIx/Class/Exception.pm line 55. # Compilation failed in require at /home/koha/kohaclone/C4/Context.pm line 102. # BEGIN failed--compilation aborted at /home/koha/kohaclone/C4/Context.pm line 102. # Compilation failed in require at (eval 6) line 2. # BEGIN failed--compilation aborted at (eval 6) line 2. # Looks like you failed 1 test of 1. t/Context.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests I believe DBIx::Class::Exception is in DBIx::Class (which would have come as a dependency.) Maybe there is something else? a DBD... DBI... I was playing with carton/cpanfile and did a reverse engineer with just these: requires 'DBD::mysql', '4.022'; requires 'DBIx::Class::Schema::Loader', '0.07033'; so maybe we need? No its not those, I have them in my test VM. Maybe its a PERL5LIB or search path thing? testdb.pl - I used this in my host OS when I was getting familiar with DBIx. #!/usr/bin/perl use strict; use warnings; use Koha::Schema; my $schema = Koha::Schema->connect('DBI:mysql:database=koha;host=192.168.122.70','koha','koha'); get_biblios(); sub get_biblios { print "get_biblios:\n"; my $rs = $schema->resultset('Biblio')->search( ); while (my $biblio = $rs->next) { print $biblio->title . "\n"; } print "\n"; } } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 09:11:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 07:11:43 +0000 Subject: [Koha-bugs] [Bug 8799] Non-existing analytics field triggers error log In-Reply-To: <bug-8799-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8799-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8799-70-yo7xIYcMen@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8799 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from M. Tompsett <mtompset at hotmail.com> --- Though it may be valid, I believe I was confusing opac-detail and opac-search (as I have a list of bugs to confirm/check against 3.6.x and newer since they were triggered in our 3.6.3). Not going to fix, because don't know if that is really a problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 09:55:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 07:55:30 +0000 Subject: [Koha-bugs] [Bug 7674] tabs my holdings and others holdings. Buttons "Remove items Selected", "Modify items Selected" In-Reply-To: <bug-7674-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7674-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7674-70-C53YD3voRu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |julian.maurice at biblibre.com Assignee|gmcharlt at gmail.com |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 10:03:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 08:03:26 +0000 Subject: [Koha-bugs] [Bug 7777] Having only one text field for the serials search In-Reply-To: <bug-7777-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7777-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7777-70-YfgTXpU9RD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7777 Adrien SAURAT <adrien.saurat at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |WONTFIX --- Comment #1 from Adrien SAURAT <adrien.saurat at biblibre.com> --- Seeing that this search zone now has 3 fields (EAN added), I guess reducing from 2 to 1 was not the way to go. I close this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 10:29:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 08:29:34 +0000 Subject: [Koha-bugs] [Bug 5356] Shipping billing address improvements In-Reply-To: <bug-5356-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5356-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5356-70-IbR2m8RcHl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 --- Comment #32 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 12407 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12407&action=edit Bug 5356: Followup: remove useless code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 10:30:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 08:30:32 +0000 Subject: [Koha-bugs] [Bug 5356] Shipping billing address improvements In-Reply-To: <bug-5356-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5356-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5356-70-Gj1qo9JAi1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 --- Comment #33 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to comment #31) > QA comment: > I think this line is wrong: > + basketgroupdeliveryplace => C4::Branch::GetBranchName( > $basketgroup->{deliveryplace} ) || C4::Branch::GetBranchName( > $basketgroup->{freedeliveryplace} ), > do we agree ? Yes. I removed it in the last patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 10:32:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 08:32:18 +0000 Subject: [Koha-bugs] [Bug 8233] New search engine layer - introduce solr without breaking anything else In-Reply-To: <bug-8233-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8233-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8233-70-Qeca02Lujr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12290|0 |1 is obsolete| | --- Comment #39 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 12408 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12408&action=edit Bug 8233 - SolR-related /etc/ files break deb building Remove them using debian/rules when building .deb packages until we figure out what to do with them in a .deb install. To do this I ran the build script like this: sudo DEB_BUILD_OPTIONS=nocheck ./debian/build-git-snapshot -distribution precise -D precise -r ~/ubuntu -v 3.9.0-046~git -d Sponsored-by: Universidad Nacional de C?rdoba Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 10:33:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 08:33:24 +0000 Subject: [Koha-bugs] [Bug 8233] New search engine layer - introduce solr without breaking anything else In-Reply-To: <bug-8233-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8233-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8233-70-caM7yJDbxz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #40 from Jonathan Druart <jonathan.druart at biblibre.com> --- I didn't test but the code seems safe -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 10:35:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 08:35:46 +0000 Subject: [Koha-bugs] [Bug 8600] Remove search terms in advanced search In-Reply-To: <bug-8600-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8600-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8600-70-T1bewJWbbr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8600 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12402|0 |1 is obsolete| | --- Comment #10 from Mirko Tietgen <mirko at abunchofthings.net> --- Created attachment 12409 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12409&action=edit Bug 8600 - Remove search terms in advanced search Enhanced version with better handling of [+] and [-] buttons. [+] adds new fields aftert current line [-] removes current line [-] is not visible if only one line left Marc Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 10:39:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 08:39:45 +0000 Subject: [Koha-bugs] [Bug 8600] Remove search terms in advanced search In-Reply-To: <bug-8600-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8600-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8600-70-4RVz4J2qMy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8600 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mirko at abunchofthings.net --- Comment #11 from Mirko Tietgen <mirko at abunchofthings.net> --- I like the feature! Two things: - I would prefer the newly added fields to be empty, at the moment the contents (if any) of the field where you click [+] is duplicated. That does not make sense since you would most likely not want that in the duplicated field - Also I would like a more fancy look of the buttons at some point :) Anyway works for me as it is, signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 10:57:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 08:57:38 +0000 Subject: [Koha-bugs] [Bug 8600] Remove search terms in advanced search In-Reply-To: <bug-8600-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8600-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8600-70-ZLumAVxC06@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8600 --- Comment #12 from Mirko Tietgen <mirko at abunchofthings.net> --- More precisely, - it would make sense to me to duplicate the state of operator and search index of the row where I hit [+], but that does not happen, it will always be "and" and "Keyword" - it does not make much sense to me to clone the text field, which is done -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 10:57:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 08:57:49 +0000 Subject: [Koha-bugs] [Bug 7873] Title sort in OPAC basket doesn't work In-Reply-To: <bug-7873-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7873-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7873-70-Qy1wtxGyDc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7873 --- Comment #1 from Adrien SAURAT <adrien.saurat at biblibre.com> --- Created attachment 12410 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12410&action=edit proposed patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 10:57:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 08:57:57 +0000 Subject: [Koha-bugs] [Bug 7873] Title sort in OPAC basket doesn't work In-Reply-To: <bug-7873-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7873-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7873-70-5iu9tpm2G4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7873 Adrien SAURAT <adrien.saurat at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 11:03:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 09:03:40 +0000 Subject: [Koha-bugs] [Bug 8715] Receiving all serials for a year In-Reply-To: <bug-8715-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8715-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8715-70-e8iVj1ppcc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8715 --- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 12411 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12411&action=edit Bug 8715: Force the default sort order to desc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 11:47:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 09:47:18 +0000 Subject: [Koha-bugs] [Bug 7867] Same text for username/login in OPAC and intranet In-Reply-To: <bug-7867-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7867-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7867-70-MvBDTLd7hz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7867 --- Comment #1 from Adrien SAURAT <adrien.saurat at biblibre.com> --- Created attachment 12412 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12412&action=edit proposed patch TEST PLAN Appears on 2 pages : 1) Front page of the OPAC 2) opac-auth, which you can see for example on the page opac-user by clicking on "Log in to your account" on top-right when logged out. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 11:48:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 09:48:31 +0000 Subject: [Koha-bugs] [Bug 5335] More granular VAT In-Reply-To: <bug-5335-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5335-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5335-70-tTqpjPo4yR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 --- Comment #47 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master I made a very intensive testing of this patch, and could not find any problem either. 3 other signoffs... patch pushed ! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 11:48:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 09:48:58 +0000 Subject: [Koha-bugs] [Bug 7867] Same text for username/login in OPAC and intranet In-Reply-To: <bug-7867-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7867-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7867-70-7twcyjkEfb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7867 Adrien SAURAT <adrien.saurat at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 13:12:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 11:12:18 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8798-70-DqV2ekTViJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 Colin Campbell <colin.campbell at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell at ptfs-europe. | |com --- Comment #6 from Colin Campbell <colin.campbell at ptfs-europe.com> --- Can I suggest adding a small script containing the dbicdump command to recreate the schema files. That way anyone in the future who changes the db schema just needs to run this to update the files. Saves effort, confusion and ensures consistency. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 13:21:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 11:21:50 +0000 Subject: [Koha-bugs] [Bug 8600] Remove search terms in advanced search In-Reply-To: <bug-8600-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8600-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8600-70-hnWa16jEiF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8600 --- Comment #13 from Marc V?ron <veron at veron.ch> --- Mirko, The + button behaves as it did before (regarding the value and preserving the operator etc.). It simply makes a clone of the row. My aim was to get the [-] button working for having it in the next release and defer the + to a follow up. Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 13:48:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 11:48:10 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-MbKmh4JZqn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12400|0 |1 is obsolete| | --- Comment #61 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12413 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12413&action=edit Bug 8215 - Add Course Reserves - QA Followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 13:49:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 11:49:53 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-AVdJZ3mw7Q@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #62 from Kyle M Hall <kyle at bywatersolutions.com> --- Good news! I figured out how to fix the diacritic problem! This new followup should address all your concerns, except the bib-level itemtypes. I'll post another patch for that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 14:15:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 12:15:20 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-YJT5enVzfG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #63 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12414 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12414&action=edit Bug 8215 - Add Course Reserves - QA Followup - Hide itemtype modification for bib-level itemtypes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 14:18:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 12:18:03 +0000 Subject: [Koha-bugs] [Bug 7873] Title sort in OPAC basket doesn't work In-Reply-To: <bug-7873-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7873-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7873-70-H2TptrjvMr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7873 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12410|0 |1 is obsolete| | --- Comment #2 from Marc V?ron <veron at veron.ch> --- Created attachment 12415 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12415&action=edit [SIGNED-OFF] Bug 7873: fixes sort on Title in OPAC basket Signed-off-by: Marc Veron <veron at veron.ch> Reproduced wront title sort without patch. Sort works as expected with patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 14:18:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 12:18:39 +0000 Subject: [Koha-bugs] [Bug 7873] Title sort in OPAC basket doesn't work In-Reply-To: <bug-7873-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7873-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7873-70-9Q1wZJQICH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7873 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 14:23:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 12:23:10 +0000 Subject: [Koha-bugs] [Bug 8738] DateTime object being compared to a date string in circulation In-Reply-To: <bug-8738-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8738-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8738-70-beTVRCiSPi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8738 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to comment #4) > See a lot of errors in the log from circulation.pl, but not this one. Does > this only happen with a certain version or under certain circumstances? I must concur with Owen. I'm not seeing this error in master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 14:42:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 12:42:43 +0000 Subject: [Koha-bugs] [Bug 8800] New: SpecifyDueDate && useDaysMode=Datedue wrong behaviour Message-ID: <bug-8800-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 Priority: P5 - low Change sponsored?: --- Bug ID: 8800 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: SpecifyDueDate && useDaysMode=Datedue wrong behaviour Severity: normal Classification: Unclassified OS: All Reporter: tomascohen at gmail.com Hardware: All Status: NEW Version: master Component: Circulation Product: Koha What should happen when a librarian specifies a due date that matches a holiday and useDaysMode=Datedue (Calculate the due date using the calendar to push the due date to the next open day)? My guess is that the due date should be fixed to match the next open day. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 14:43:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 12:43:22 +0000 Subject: [Koha-bugs] [Bug 8790] Search result return "No results found" in both OPAC and Patron sides In-Reply-To: <bug-8790-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8790-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8790-70-j6crkk1KI8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8790 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- It sounds like you're having a problem with the way Zebra is set up. I recommend you take this issue to the Koha mailing list or to the Koha IRC channel (http://koha-community.org/get-involved/irc/). Things to note when asking for help: - what Koha version - what platform - how you installed koha - what errors are in Koha's error log -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 14:47:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 12:47:18 +0000 Subject: [Koha-bugs] [Bug 7674] tabs my holdings and others holdings. Buttons "Remove items Selected", "Modify items Selected" In-Reply-To: <bug-7674-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7674-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7674-70-x3ya03noAf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 --- Comment #3 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 12416 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12416&action=edit Bug 7674: Separate items in two tabs (opac/opac-detail.pl) Two tabs: "My holdings" / "Other holdings" "My holdings" tab contains items whose homebranch is the current branch. "Other holdings" tab contains all other items. If current branch is not set (connected with mysql user, or not logged in), the display is unchanged (1 tab "Holdings") -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 14:47:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 12:47:21 +0000 Subject: [Koha-bugs] [Bug 7674] tabs my holdings and others holdings. Buttons "Remove items Selected", "Modify items Selected" In-Reply-To: <bug-7674-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7674-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7674-70-zmZUxqtTro@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 --- Comment #4 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 12417 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12417&action=edit Bug 7674: Separate items in two tabs (catalogue/detail.pl) Two tabs: "My holdings" / "Other holdings" "My holdings" tab contains items whose homebranch is the current branch. "Other holdings" tab contains all other items. If current branch is not set (connected with mysql user), the display is unchanged (1 tab "Holdings") -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 14:47:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 12:47:24 +0000 Subject: [Koha-bugs] [Bug 7674] tabs my holdings and others holdings. Buttons "Remove items Selected", "Modify items Selected" In-Reply-To: <bug-7674-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7674-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7674-70-hsFqlwYR1a@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 --- Comment #5 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 12418 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12418&action=edit Bug 7674: Add menu entry to delete items in batch In catalogue/detail.pl you can now select "Delete items in batch" in "Edit" menu. You are redirected to batchMod.pl for chosing which items have to be deleted. You need to have 'tools.items_batchdel' permission to see this menu entry. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 14:47:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 12:47:49 +0000 Subject: [Koha-bugs] [Bug 7674] tabs my holdings and others holdings. Buttons "Remove items Selected", "Modify items Selected" In-Reply-To: <bug-7674-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7674-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7674-70-hjDoGdx0B4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 14:51:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 12:51:25 +0000 Subject: [Koha-bugs] [Bug 8382] It is not possible to cancel an order when receiving on a filtered page in parcel.pl In-Reply-To: <bug-8382-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8382-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8382-70-XazCu7HhC9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8382 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |kyle at bywatersolutions.com --- Comment #18 from Kyle M Hall <kyle at bywatersolutions.com> --- Applying: Bug 8382 [Follow-up] It is not possible to cancel an order when receiving on a filtered page in parcel.pl Bug 8382: Followup: FIX wrong comparaison Apply? [yn] y Applying: Bug 8382: Followup: FIX wrong comparaison error: patch failed: acqui/parcel.pl:79 error: acqui/parcel.pl: patch does not apply Patch failed at 0001 Bug 8382: Followup: FIX wrong comparaison -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 14:56:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 12:56:40 +0000 Subject: [Koha-bugs] [Bug 7674] tabs my holdings and others holdings. Buttons "Remove items Selected", "Modify items Selected" In-Reply-To: <bug-7674-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7674-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7674-70-AJQdZTx1Ai@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Owen Leonard <oleonard at myacpl.org> --- This sounds like it should be two bug reports: One for the separate holdings tabs, one for the batch operations. The one for the separate holdings tabs needs to be controlled by a system preference, one for the OPAC and one for the staff client. I would suggest that instead of "My holdings" the tab use the library name: "Athens holdings." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 14:56:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 12:56:42 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: <bug-8375-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8375-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8375-70-8wonhSiNjV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #18 from Kyle M Hall <kyle at bywatersolutions.com> --- I also agree HTML/CSS is far better in the long run than PDF. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 15:01:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 13:01:13 +0000 Subject: [Koha-bugs] [Bug 6037] Invalid markup, missing breadcrumbs on Keyword to MARC Mapping page In-Reply-To: <bug-6037-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6037-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6037-70-jL6628NxNi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6037 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12247|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12419 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12419&action=edit Bug 6037 [Follow-up] Invalid markup, missing breadcrumbs on Keyword to MARC Mapping page Extra </div> returned. Killing it again. After applying the patch the validator should only warn of invalid "autocomplete" attribute. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 15:01:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 13:01:23 +0000 Subject: [Koha-bugs] [Bug 6037] Invalid markup, missing breadcrumbs on Keyword to MARC Mapping page In-Reply-To: <bug-6037-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6037-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6037-70-sIh4ksn5r1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6037 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 15:02:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 13:02:21 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: <bug-5349-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5349-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5349-70-vQMIX4t0Pj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12236|0 |1 is obsolete| | --- Comment #36 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 12420 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12420&action=edit [SIGNED-OFF] Bug 5349: Order line transfers On basket.pl and parcel.pl there is a 'Transfer' link which allow you to transfer order lines from a basket to another. The link lead to a new page which allow you to search for a bookseller, then display this bookseller's baskets. Then you can pickup a basket and the transfer will be done. This add a message in new column aqorders.internalnotes which is displayed in basket.pl Signed-off-by: Marc Veron <veron at veron.ch> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 15:02:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 13:02:38 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: <bug-5349-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5349-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5349-70-Wmls8T5GHT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12237|0 |1 is obsolete| | --- Comment #37 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 12421 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12421&action=edit [SIGNED-OFF] Bug 5349 follow-up: run transferorder.pl in a popup Signed-off-by: Marc Veron <veron at veron.ch> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 15:02:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 13:02:47 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: <bug-5349-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5349-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5349-70-tOoT8hfVQs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12238|0 |1 is obsolete| | --- Comment #38 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 12422 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12422&action=edit Bug 5349: Fix a logical test in TransferOrder -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 15:03:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 13:03:09 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: <bug-5349-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5349-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5349-70-A8oWrGMj7P@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #39 from Julian Maurice <julian.maurice at biblibre.com> --- All patches rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 15:03:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 13:03:26 +0000 Subject: [Koha-bugs] [Bug 7409] Missing dependencies for Debian package In-Reply-To: <bug-7409-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7409-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7409-70-sPZqVvqjvh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7409 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12259|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12423 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12423&action=edit Bug 7409 : Adding missing dependency Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 15:03:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 13:03:38 +0000 Subject: [Koha-bugs] [Bug 7409] Missing dependencies for Debian package In-Reply-To: <bug-7409-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7409-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7409-70-bnEqMTcl0d@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7409 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12263|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12424 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12424&action=edit Bug 7409 : Missing dependency on DBD::Mock Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 15:03:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 13:03:47 +0000 Subject: [Koha-bugs] [Bug 7409] Missing dependencies for Debian package In-Reply-To: <bug-7409-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7409-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7409-70-sLfqa7MRZY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7409 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 15:06:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 13:06:05 +0000 Subject: [Koha-bugs] [Bug 8382] It is not possible to cancel an order when receiving on a filtered page in parcel.pl In-Reply-To: <bug-8382-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8382-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8382-70-df3OlYkuKs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8382 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12273|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart <jonathan.druart at biblibre.com> --- Comment on attachment 12273 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12273 Bug 8382: Followup: FIX wrong comparaison This patch seems useless now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 15:06:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 13:06:15 +0000 Subject: [Koha-bugs] [Bug 8382] It is not possible to cancel an order when receiving on a filtered page in parcel.pl In-Reply-To: <bug-8382-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8382-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8382-70-bwFmZroJlS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8382 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 15:08:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 13:08:45 +0000 Subject: [Koha-bugs] [Bug 5409] Call number is not show on Opac search result page. In-Reply-To: <bug-5409-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5409-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5409-70-x9RreWiLCb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11049|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12425 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12425&action=edit [SIGNED-OFF] Bug 5409 - Fix call number not shown on opac search result page Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 15:09:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 13:09:12 +0000 Subject: [Koha-bugs] [Bug 5409] Call number is not show on Opac search result page. In-Reply-To: <bug-5409-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5409-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5409-70-6QkyoSVJCf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11050|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12426 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12426&action=edit [SIGNED-OFF] Bug 5409 - Call number is not show on Opac search result page. Fixes Bug 5409, Set the syspref value to 1 if it is itemdetails and 0 if it is statuses, leaving it alone if it is already 1 or 0 and change the type of the syspref to YesNo. Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 15:11:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 13:11:04 +0000 Subject: [Koha-bugs] [Bug 5409] Call number is not show on Opac search result page. In-Reply-To: <bug-5409-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5409-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5409-70-l5XA1yND3K@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12300|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12427 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12427&action=edit [SIGNED-OFF] Bug 5409 - Call number is not show on Opac search result page - QA Followup Fixes Bug 5409, Modified the definition of 'OPACItemsResultsDisplay' in systempreferences and changed the code in opac-search.pl file for 'OPACItemsResultsDisplay'. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 15:11:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 13:11:19 +0000 Subject: [Koha-bugs] [Bug 5409] Call number is not show on Opac search result page. In-Reply-To: <bug-5409-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5409-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5409-70-HVjZxUSCvX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 15:13:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 13:13:25 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8798-70-5DFZEfk6VY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 --- Comment #7 from Elliott Davis <elliott at bywatersolutions.com> --- Sure Colin! Thanks for reminding me. Also Wajasu, You're right! I misspelled the package name. Must've had one too many beers after dinner. Note to self, never Drink with DBIx :p Thanks for testing. I'm also going to include my test file in the next patch so that you guys can use it to test further. (In reply to comment #6) > Can I suggest adding a small script containing the dbicdump command to > recreate the schema files. That way anyone in the future who changes the db > schema just needs to run this to update the files. Saves effort, confusion > and ensures consistency. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 15:19:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 13:19:54 +0000 Subject: [Koha-bugs] [Bug 8788] Viewing basket for acquisitions triggers error log entries. In-Reply-To: <bug-8788-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8788-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8788-70-mCpGnP01ya@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8788 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 15:22:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 13:22:58 +0000 Subject: [Koha-bugs] [Bug 8801] New: Offer to batch delete items of a biblio record Message-ID: <bug-8801-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8801 Priority: P5 - low Change sponsored?: --- Bug ID: 8801 CC: m.de.rooy at rijksmuseum.nl Assignee: gmcharlt at gmail.com Summary: Offer to batch delete items of a biblio record Severity: enhancement Classification: Unclassified OS: All Reporter: julian.maurice at biblibre.com Hardware: All Status: NEW Version: master Component: Cataloging Product: Koha Will add a link in 'Edit' menu to go directly to batch deletion of items. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 15:24:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 13:24:42 +0000 Subject: [Koha-bugs] [Bug 8801] Offer to batch delete items of a biblio record In-Reply-To: <bug-8801-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8801-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8801-70-Rnz4uL6XF5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8801 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |julian.maurice at biblibre.com --- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 12428 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12428&action=edit Bug 8801: Add menu entry to delete items in batch In catalogue/detail.pl you can now select "Delete items in batch" in "Edit" menu. You are redirected to batchMod.pl for chosing which items have to be deleted. You need to have 'tools.items_batchdel' permission to see this menu entry. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 15:25:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 13:25:11 +0000 Subject: [Koha-bugs] [Bug 7674] tabs my holdings and others holdings. Buttons "Remove items Selected", "Modify items Selected" In-Reply-To: <bug-7674-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7674-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7674-70-GCq5S6j8PX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 --- Comment #7 from Julian Maurice <julian.maurice at biblibre.com> --- New bug for the batch operation: Bug 8801 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 15:25:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 13:25:25 +0000 Subject: [Koha-bugs] [Bug 7674] tabs my holdings and others holdings. Buttons "Remove items Selected", "Modify items Selected" In-Reply-To: <bug-7674-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7674-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7674-70-Ujoya7s5RT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12418|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 15:30:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 13:30:56 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8798-70-sslDSmNtBW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 Elliott Davis <elliott at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12405|0 |1 is obsolete| | --- Comment #8 from Elliott Davis <elliott at bywatersolutions.com> --- Created attachment 12429 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12429&action=edit Added base class files for all tables in koha using the DBIx::Class::Schema::Loader Added a (very basic) test file for C4::Context Also added dependencies in required files. [Update]: changed dependencies fron dbic to dbix Added test files in the root directory (dummytest.pl) To Test: Install patch Make sure you can still connect to Koha you may optionally run dummytest.pl If you run this file you should get a DBIx dump of the borrowers table Done! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 15:31:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 13:31:09 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8798-70-bW2DPn9It4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 Elliott Davis <elliott at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 15:40:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 13:40:03 +0000 Subject: [Koha-bugs] [Bug 8741] crontab.example missing username, fails in some systems In-Reply-To: <bug-8741-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8741-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8741-70-XFI4NfC6WJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8741 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12071|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12430 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12430&action=edit [SIGNED-OFF] Bug 8741 - crontab.example missing username, fails in some systems Simple addition of the koha user to the sample cron file. Might help non-tech users to get things like incremental indexing to work. Sponsored-by: Universidad Nacional de C?rdoba Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 15:40:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 13:40:14 +0000 Subject: [Koha-bugs] [Bug 8741] crontab.example missing username, fails in some systems In-Reply-To: <bug-8741-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8741-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8741-70-gHTAnGcpnG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8741 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 15:44:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 13:44:08 +0000 Subject: [Koha-bugs] [Bug 7873] Title sort in OPAC basket doesn't work In-Reply-To: <bug-7873-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7873-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7873-70-3zlUTQygoz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7873 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12415|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12431 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12431&action=edit [SIGNED-OFF] Bug 7873: fixes sort on Title in OPAC basket Signed-off-by: Marc Veron <veron at veron.ch> Reproduced wront title sort without patch. Sort works as expected with patch. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 15:52:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 13:52:45 +0000 Subject: [Koha-bugs] [Bug 8234] Dates are not well sorted on Transfers to receive In-Reply-To: <bug-8234-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8234-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8234-70-TvINrRHstI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8234 --- Comment #3 from Adrien SAURAT <adrien.saurat at biblibre.com> --- Created attachment 12432 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12432&action=edit proposed patch TEST PLAN : 1) As dateformat (in sysprefs) you have to chose the metric system (dd/mm/yyyy). 2) Prepare several transfers from one library to another. 3) Change the dates of these tranfers (table "branchtransfers"), you especially have to create a possible confusion between days and months. 4) Display the "Transfers to receive page". The sort doesn't work properly as dates are treated like "MM/DD/YYYY" dates. Once the patch is applied, the metric system format is handled ok. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 15:52:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 13:52:58 +0000 Subject: [Koha-bugs] [Bug 8234] Dates are not well sorted on Transfers to receive In-Reply-To: <bug-8234-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8234-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8234-70-ZUjCYtcxOc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8234 Adrien SAURAT <adrien.saurat at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 16:03:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 14:03:10 +0000 Subject: [Koha-bugs] [Bug 7674] tabs my holdings and others holdings. Buttons "Remove items Selected", "Modify items Selected" In-Reply-To: <bug-7674-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7674-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7674-70-zuADznTTXp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12416|0 |1 is obsolete| | Attachment #12417|0 |1 is obsolete| | --- Comment #8 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 12433 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12433&action=edit Bug 7674: Separate items in two tabs on biblio detail page (staff+opac) Two tabs: "<branch> holdings" / "Other holdings" "<branch> holdings" tab contains items whose homebranch is the current branch. "Other holdings" tab contains all other items. If current branch is not set (connected with mysql user or not logged in (opac)), the display is unchanged (1 tab "Holdings") -- + Added two sysprefs SeparateHoldings and OpacSeparateHoldings (YesNo) + changed "My holdings" to "<branchname> holdings" Previous patches squashed into this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 16:03:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 14:03:16 +0000 Subject: [Koha-bugs] [Bug 7674] tabs my holdings and others holdings. Buttons "Remove items Selected", "Modify items Selected" In-Reply-To: <bug-7674-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7674-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7674-70-HYlxrwJthZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 16:16:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 14:16:09 +0000 Subject: [Koha-bugs] [Bug 8369] default_branch_circ_rule and default_circ_rules tables useless In-Reply-To: <bug-8369-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8369-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8369-70-IhXbKtzTEd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8369 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |kyle at bywatersolutions.com --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> --- The "Default checkout, hold and return policy for all libraries" and "Checkout limit by patron category for all libraries" rules do not appear to be working for me. I tried both with a limit of 1, and was able to check out 2 items to a patron with no warnings. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 16:27:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 14:27:08 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8798-70-WUdXlatoAl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> --- This is looking good. A couple comments though. dummytest.pl output looks good. I don't know if you meant to include this file though. t/Context.t gives me: DBIx::Class::Relationship::HasOne::might_have(): "might_have/has_one" must not be on columns with is_nullable set to true (Koha::Schema::Result::Borrower/cardnumber). This might indicate an incorrect use of those relationship helpers instead of belongs_to. at /home/koha/kohaclone/Koha/Schema/Result/Borrower.pm line 780 I'm not sure if this is really an issue or not, though. It seems like a problem with our schema, not with his patch. genDBIxFiles.sh works, but you have to modify the data in it. It would be nice if it would find the db info in the koha conf file. At the very least, it could ask for the database, username and password. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 16:28:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 14:28:23 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8798-70-LfgJiQOJhY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 --- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> --- > genDBIxFiles.sh works, but you have to modify the data in it. It would be > nice if it would find the db info in the koha conf file. At the very least, > it could ask for the database, username and password. Also, I'd move genDBIxFiles.sh to something like misc/devel instead of having it in the root directory. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 16:30:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 14:30:15 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8798-70-qjvItEWkNz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 --- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> --- > dummytest.pl output looks good. I don't know if you meant to include this > file though. Bad wording. What I meant to say is should this file be included in Koha? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 16:34:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 14:34:56 +0000 Subject: [Koha-bugs] [Bug 8523] Authority hierarchies only support UNIMARC In-Reply-To: <bug-8523-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8523-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8523-70-yfNyncqTzN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain at biblibre.com Version|master |rel_3_10 --- Comment #21 from Paul Poulain <paul.poulain at biblibre.com> --- QA comment: * passes koha-qa.pl * switch from something UNIMARC specific to MARC agnostic, plus introduce a more modern (& probably robust) way to handle/display hierarchies 2 small glitches, that are not worth failing QA but should be improved later: my authorities where 250$a Jardinage 250 $aJardinage$xL?gumes 550$5b$aJardinage 550$5h$aJardinage bio The hierarchy is: Jardinage + Jardinage l?gumes + Jardinage bio BUT, as the "Legumes" is in $x and we display only the $a in the hierarchy, we see: Jardinage + Jardinage + Jardinage bio It's not the most common case in UNIMARC, but it happens. * the authority-detail still show Broader term & Narrower term when the hierarchy is ON. Maybe we could remove them ? (see screenshot) Overall = passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 16:36:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 14:36:25 +0000 Subject: [Koha-bugs] [Bug 8523] Authority hierarchies only support UNIMARC In-Reply-To: <bug-8523-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8523-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8523-70-T2fmuEVKEF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #22 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master with some followup: * one for perlcritic C4/AuthoritiesMarc.pm * one for adding needed css for ccsr theme -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 16:48:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 14:48:23 +0000 Subject: [Koha-bugs] [Bug 7241] circulation action logs record biblionumber instead of item number In-Reply-To: <bug-7241-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7241-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7241-70-SXgkkEYlsj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7241 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12043|0 |1 is obsolete| | --- Comment #30 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12434 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12434&action=edit [SIGNED-OFF] Bug 7241: circulation action logs record biblionumber instead of item number Issue log and and circulation logs are incorrectly recording biblionumber instead of item number, creating incorrect logs. This patch corrects this, and modifies the action_logs table in two ways: - the timestamp is not updated anymore with UPDATES (but still automatically filled when INSERTing) - to partially correct the broken logs, the log history is filled with the first found item for each biblio Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 16:48:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 14:48:39 +0000 Subject: [Koha-bugs] [Bug 7241] circulation action logs record biblionumber instead of item number In-Reply-To: <bug-7241-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7241-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7241-70-fet9zoQY4g@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7241 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 16:52:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 14:52:15 +0000 Subject: [Koha-bugs] [Bug 459] No uninstall script In-Reply-To: <bug-459-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-459-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-459-70-BsxJaSWD08@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=459 --- Comment #2 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 12435 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12435&action=edit Untested uninstall script edited in Windows This bug caught my attention. Here is my initial, rough draft attempt. If anyone wishes to polish it up, test it, comment that it is missing something, that would be great. The measure of good software, in my books: installs easy, does what it says, and uninstalls easy. Hopefully, this script will work towards making the last point a reality. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 16:53:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 14:53:36 +0000 Subject: [Koha-bugs] [Bug 8441] Hide MODS export for UNIMARC In-Reply-To: <bug-8441-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8441-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8441-70-KLPeUD2VMP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8441 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12375|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12436 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12436&action=edit [SIGNED-OFF] Bug 8441: hides MODS export by default in French install Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 16:53:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 14:53:45 +0000 Subject: [Koha-bugs] [Bug 8441] Hide MODS export for UNIMARC In-Reply-To: <bug-8441-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8441-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8441-70-ZFce23cgbk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8441 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 16:57:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 14:57:43 +0000 Subject: [Koha-bugs] [Bug 8742] Example uses perl 5.8 in Makefile.PL In-Reply-To: <bug-8742-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8742-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8742-70-Nex5h8HlS7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8742 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12143|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12437 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12437&action=edit [SIGNED-OFF] Bug 8742 - Example uses perl 5.8 in Makefile.PL Changed hardcoded path for a programmatic one. Basing it on: grep /\/usr\/share\/perl\//, @INC; And doing a: push @version, ('/usr/share/perl/5.10') if !$version[0]; For a reasonable default otherwise. No more references to /usr/share/perl/5.8 hardcoded into the output. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 17:00:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 15:00:18 +0000 Subject: [Koha-bugs] [Bug 8742] Example uses perl 5.8 in Makefile.PL In-Reply-To: <bug-8742-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8742-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8742-70-jHNcz8n3G0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8742 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 17:33:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 15:33:48 +0000 Subject: [Koha-bugs] [Bug 8788] Viewing basket for acquisitions triggers error log entries. In-Reply-To: <bug-8788-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8788-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8788-70-Exb94yYmSx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8788 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from M. Tompsett <mtompset at hotmail.com> --- It would seem that bug 5335 has made this bug report irrelevant, except for the test case provided. If no errors occur, then all should be fine. I'm marking it as a duplicate of 5335, even though 5335 is far bigger in scope than this tiny change. It's side-effect cleaned up this problem. *** This bug has been marked as a duplicate of bug 5335 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 17:33:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 15:33:48 +0000 Subject: [Koha-bugs] [Bug 5335] More granular VAT In-Reply-To: <bug-5335-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5335-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5335-70-lBCt1Mg9p1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #48 from M. Tompsett <mtompset at hotmail.com> --- *** Bug 8788 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 17:55:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 15:55:55 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7736-70-JeccZQpXwF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Colin Campbell <colin.campbell at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12398|0 |1 is obsolete| | --- Comment #13 from Colin Campbell <colin.campbell at ptfs-europe.com> --- Created attachment 12438 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12438&action=edit Revised patch This revision add updatedatabase entries for the tables. It also avoids the hardcoded currency code. At the moment Koha does not enforce use of the standard codes so this is a bit kludgie at the moment, but in practice library Acquisition depts are usually using these -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 17:57:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 15:57:57 +0000 Subject: [Koha-bugs] [Bug 8802] New: Library group records - category type reverts to "searchdomain" when editing group record Message-ID: <bug-8802-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8802 Priority: P5 - low Change sponsored?: --- Bug ID: 8802 CC: gmcharlt at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: Library group records - category type reverts to "searchdomain" when editing group record Severity: enhancement Classification: Unclassified OS: All Reporter: elibris.helpdesk at gmail.com Hardware: All Status: NEW Version: unspecified Component: System Administration Product: Koha If you create a Library Group and select "properties" as the category type, the category type automatically reverts to "searchdomain" whenever you edit the group record. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 17:59:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 15:59:49 +0000 Subject: [Koha-bugs] [Bug 8802] Library group records - category type reverts to "searchdomain" when editing group record In-Reply-To: <bug-8802-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8802-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8802-70-jJClqnFYz4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8802 e-Libris Technologies <elibris.helpdesk at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P4 CC| |elibris.helpdesk at gmail.com Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 18:01:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 16:01:00 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8798-70-vo0pmCGKES@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 --- Comment #12 from Elliott Davis <elliott at bywatersolutions.com> --- Kyle you're probably right and I probably jumped the gun in my excitement to get this in. I'll paste the script here: #!/usr/bin/perl use strict; use warnings; use C4::Context; use Data::Dumper; my $schema = C4::Context->schema; print Dumper($schema->resultset("Borrower")); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 18:02:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 16:02:09 +0000 Subject: [Koha-bugs] [Bug 8803] New: modifying order quantity in neworderempty.pl has restriction that are implemented in javascript and can be bypassed with the enter key Message-ID: <bug-8803-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8803 Priority: P5 - low Change sponsored?: --- Bug ID: 8803 Assignee: koha-bugs at lists.koha-community.org Summary: modifying order quantity in neworderempty.pl has restriction that are implemented in javascript and can be bypassed with the enter key Severity: enhancement Classification: Unclassified OS: All Reporter: gaetan.boisson at biblibre.com Hardware: All Status: NEW Version: unspecified Component: Acquisitions Product: Koha To reproduce : - set up Koha so that you create items when placing the order - create an order in a basket - modify the quantity to add more items to this order - if you click save, you will have an error message - if you press enter, the modifications will be saved, but you won't have entered any details about the added items. Ideally, when modifying the order (and when your system is set up so that items get created when you place the order), we should see the same table that displays with items when creating the order, with links to delete them. Deleting an item here should also delete the item in the catalog (right now we are prompted to do this manually). Adding items here should happen in the same way as when creating a new line. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 18:02:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 16:02:39 +0000 Subject: [Koha-bugs] [Bug 8803] modifying order quantity in neworderempty.pl has restriction that are implemented in javascript and can be bypassed with the enter key In-Reply-To: <bug-8803-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8803-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8803-70-9nL9h077yF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8803 Gaetan Boisson <gaetan.boisson at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8359 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 18:02:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 16:02:39 +0000 Subject: [Koha-bugs] [Bug 8359] enter submits acq order In-Reply-To: <bug-8359-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8359-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8359-70-48uFQoeRVC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8359 Gaetan Boisson <gaetan.boisson at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8803 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 18:03:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 16:03:28 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8798-70-wAtbMLQIsd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 Elliott Davis <elliott at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12429|0 |1 is obsolete| | --- Comment #13 from Elliott Davis <elliott at bywatersolutions.com> --- Created attachment 12439 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12439&action=edit Added base class files for all tables in koha using the DBIx::Class::Schema::Loader Added a (very basic) test file for C4::Context Also added dependencies in required files. [Update]: changed dependencies fron dbic to dbix moved generation shell script to a perl script wtih arguments in misc/devel To Test: Install patch Make sure you can still connect to Koha you may optionally run the test script in comment 12 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798#c12 If you run this file you should get a DBIx dump of the borrowers table Done! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 18:06:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 16:06:42 +0000 Subject: [Koha-bugs] [Bug 8803] modifying order quantity in neworderempty.pl has restrictions implemented in javascript that can be bypassed with the enter key In-Reply-To: <bug-8803-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8803-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8803-70-8KfBdd6F9m@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8803 Gaetan Boisson <gaetan.boisson at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|modifying order quantity in |modifying order quantity in |neworderempty.pl has |neworderempty.pl has |restriction that are |restrictions implemented in |implemented in javascript |javascript that can be |and can be bypassed with |bypassed with the enter key |the enter key | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 18:10:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 16:10:51 +0000 Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix In-Reply-To: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5786-70-L2nTyHavfb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #61 from Paul Poulain <paul.poulain at biblibre.com> --- QA comment: * I've found some glitches with koha-qa.pl, i've fixed them. They were very minor. * After an intensive testing, I've found a tricky problem, that occurs only under some specific cases. Let me explain: Issuing rules are : default library (branchcode='*'), you say 'ShelfHolds = no' for a given library, a given itemtype, and any categorycode, you say 'yes' => only 'BOOKS' from 'Library A' can be reserved while on shelf. In this case, you will get a wrong result from your query: SELECT opacitemholds,categorycode,itemtype,branchcode FROM issuingrules WHERE (issuingrules.categorycode = ? OR issuingrules.categorycode = '*') AND (issuingrules.itemtype = ? OR issuingrules.itemtype = '*') AND (issuingrules.branchcode = ? OR issuingrules.branchcode = '*') ORDER BY issuingrules.categorycode desc, issuingrules.itemtype desc, issuingrules.branchcode desc It returns (I don't know why !) the branch='*' rule. This feature existed previously in biblibre/master, and got lost with some other features during 3.2/3.4 We made it a different way, here is the piece of code: # This configuration table defines the order of inheritance. We'll loop over it. my @attempts = ( [ "*", "*", "*" ], [ "*", $itemtype, "*" ], [ $categorycode, "*", "*" ], [ $categorycode, $itemtype, "*" ], [ "*", "*", $branchcode ], [ "*", $itemtype, $branchcode ], [ $categorycode, "*", $branchcode ], [ $categorycode, $itemtype, $branchcode ], ); # This complex query returns a nested hashref, so we can access a rule using : # my $rule = $$rules{$categorycode}{$itemtype}{$branchcode}; # this will be usefull in the inheritance computation code my $rules = $dbh->selectall_hashref( "SELECT * FROM issuingrules where branchcode IN ('*',?) and itemtype IN ('*', ?) and categorycode IN ('*',?)", [ "branchcode", "itemtype", "categorycode" ], undef, ( $branchcode, $itemtype, $categorycode ) ); # This block is for inheritance. It loops over rules returned by the # previous query. If a value is found in a more specific rule, it replaces # the old value from the more generic rule. my $oldrule; for my $attempt (@attempts) { if ( my $rule = $$rules{ @$attempt[2] }{ @$attempt[1] }{ @$attempt[0] } ) { if ($oldrule) { for ( keys %$oldrule ) { if ( defined $rule->{$_} ) { $oldrule->{$_} = $rule->{$_}; } } } else { $oldrule = $rule; } } } => we retrieve an array of all applicable rules, then we check each of them. the last one we find is the more precise and should be used ! (it's in "$oldrule", that is not a very good name I agree. It's the "appliedrule" in fact. Marking failed QA, will attach my follow-ups -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 18:11:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 16:11:32 +0000 Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix In-Reply-To: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5786-70-g4iCaltclZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 --- Comment #62 from Paul Poulain <paul.poulain at biblibre.com> --- Created attachment 12440 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12440&action=edit Bug 5786 follow-up HTML4 coding guideline, removing capitals -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 18:11:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 16:11:45 +0000 Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix In-Reply-To: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5786-70-o4Ms4tfGzG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 --- Comment #63 from Paul Poulain <paul.poulain at biblibre.com> --- Created attachment 12441 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12441&action=edit bug 5786 follow-up quiet perl -wc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 18:13:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 16:13:56 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8798-70-461Kx4fNnj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 --- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12442 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12442&action=edit Added base class files for all tables in koha using the DBIx::Class::Schema::Loader Added a (very basic) test file for C4::Context Also added dependencies in required files. [Update]: changed dependencies fron dbic to dbix moved generation shell script to a perl script wtih arguments in misc/devel To Test: Install patch Make sure you can still connect to Koha you may optionally run the test script in comment 12 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798#c12 If you run this file you should get a DBIx dump of the borrowers table Done! http://bugs.koha-community.org/show_bug.cgi?id=8798 Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 18:17:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 16:17:30 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8798-70-2yRXiOCkio@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 --- Comment #15 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12443 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12443&action=edit Bug 8798 - Add the use of DBIx::Class - Rename schema class updater updateDatabase.pl is a bit too close to updatedatabase.pl in installer and may cause some confusion. I would suggest update_dbix_class_files.pl as a unambiguous and descriptive name for this file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 18:17:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 16:17:48 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8798-70-fDcvLZ6FUU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12439|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 18:18:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 16:18:45 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8798-70-BQIAyKFoyc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 --- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> --- Excellent work! I can't wait to use this! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 18:33:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 16:33:26 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8798-70-AjMaTHN8be@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 --- Comment #17 from Colin Campbell <colin.campbell at ptfs-europe.com> --- Couple of minor anomalies, you're missing classes for labels_batches, labels_templates and labels_layouts They were added via updatedatabase but dont exist in kohastructure.sql You've got an ActionLogs class but if you recreate the schema it generates an ActionLog class (Standard behaviour the Loader generates a singular named class for plural tables) shouls ActionLogs.pm be removed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 18:44:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 16:44:10 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8798-70-b8yztxzndz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 --- Comment #18 from Elliott Davis <elliott at bywatersolutions.com> --- (In reply to comment #17) > Couple of minor anomalies, you're missing classes for labels_batches, > labels_templates and labels_layouts They were added via updatedatabase but > dont exist in kohastructure.sql So you're sayng they exist in the database because they were added by updatedatabase but not in kohastructure.sql? > > You've got an ActionLogs class but if you recreate the schema it generates > an ActionLog class (Standard behaviour the Loader generates a singular named > class for plural tables) shouls ActionLogs.pm be removed? Are you saying when you ran the generation script it gave you the singular form? I see the plural form in the Results file so I'm a bit confused as to how that slipped through as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 19:08:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 17:08:39 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8798-70-Yvxw11ITkp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 --- Comment #19 from Colin Campbell <colin.campbell at ptfs-europe.com> --- (In reply to comment #18) > (In reply to comment #17) > So you're sayng they exist in the database because they were added by > updatedatabase but not in kohastructure.sql? Yes I think so. I wondered if you were generating from a pristine db. (not really a prob for this patch) > > > > > You've got an ActionLogs class but if you recreate the schema it generates > > an ActionLog class (Standard behaviour the Loader generates a singular named > > class for plural tables) shouls ActionLogs.pm be removed? > > Are you saying when you ran the generation script it gave you the singular > form? I see the plural form in the Results file so I'm a bit confused as to > how that slipped through as well. Yes I get a ActionLog.pm which is what I would expect. Using your script or dbicdump. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 19:12:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 17:12:07 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8798-70-PURP3g5w4n@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 --- Comment #20 from Elliott Davis <elliott at bywatersolutions.com> --- (In reply to comment #19) > (In reply to comment #18) > > (In reply to comment #17) > > > So you're sayng they exist in the database because they were added by > > updatedatabase but not in kohastructure.sql? > Yes I think so. I wondered if you were generating from a pristine db. (not > really a prob for this patch) > > > > > > > > You've got an ActionLogs class but if you recreate the schema it generates > > > an ActionLog class (Standard behaviour the Loader generates a singular named > > > class for plural tables) shouls ActionLogs.pm be removed? > > > > Are you saying when you ran the generation script it gave you the singular > > form? I see the plural form in the Results file so I'm a bit confused as to > > how that slipped through as well. > Yes I get a ActionLog.pm which is what I would expect. Using your script or > dbicdump. It was from my development DB, I'm not sure if that qualifies as pristine ;) I wouldn't be opposed to a QAA or Paul re-running the gen script and pushing their results. This would probably resolve both of the aforementioned issues. The important thing in this patch is less the class files and more the code addition in C4::Context for the schema handler. Let me know if you'd like me to try and regen or if there is something we can get paul or a QAA to do. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 19:50:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 17:50:53 +0000 Subject: [Koha-bugs] [Bug 8800] SpecifyDueDate && useDaysMode=Datedue wrong behaviour In-Reply-To: <bug-8800-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8800-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8800-70-QuPdtsl1QL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 --- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 12444 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12444&action=edit Bug 8800 - useDaysMode=Datedue wrong behaviour useDaysMode=Datedue wasn't used as advertised in the docs. Added a next_open_day sub to Koha::Calendar and some tests for it. - AddIssue was fixed for the case $datedue was defined in circ/circulation.pl - CalcDateDue was modified to be consistent with the intended behaviour Regards To+ Sponsored-by: Universidad Nacional de C?rdoba -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 19:51:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 17:51:48 +0000 Subject: [Koha-bugs] [Bug 8800] SpecifyDueDate && useDaysMode=Datedue wrong behaviour In-Reply-To: <bug-8800-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8800-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8800-70-grAhs65YVr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 19:51:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 17:51:58 +0000 Subject: [Koha-bugs] [Bug 8800] SpecifyDueDate && useDaysMode=Datedue wrong behaviour In-Reply-To: <bug-8800-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8800-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8800-70-13joZChQGi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 19:57:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 17:57:27 +0000 Subject: [Koha-bugs] [Bug 8800] SpecifyDueDate && useDaysMode=Datedue wrong behaviour In-Reply-To: <bug-8800-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8800-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8800-70-jBjc8OiQmX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12444|0 |1 is obsolete| | --- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 12445 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12445&action=edit Bug 8800 - useDaysMode=Datedue wrong behaviour useDaysMode=Datedue wasn't used as advertised in the docs. Added a next_open_day sub to Koha::Calendar and some tests for it. - AddIssue was fixed for the case $datedue was defined in circ/circulation.pl - CalcDateDue was modified to be consistent with the intended behaviour Regards To+ Sponsored-by: Universidad Nacional de C?rdoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 20:07:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 18:07:04 +0000 Subject: [Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings In-Reply-To: <bug-7674-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7674-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7674-70-tr7qX9gPb7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_8 |master Summary|tabs my holdings and others |Separate tabs for my |holdings. Buttons "Remove |holdings and others |items Selected", "Modify |holdings |items Selected" | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 20:25:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 18:25:12 +0000 Subject: [Koha-bugs] [Bug 8800] SpecifyDueDate && useDaysMode=Datedue wrong behaviour In-Reply-To: <bug-8800-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8800-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8800-70-WTyeRc014v@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 --- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- This patch needs two sysprefs set like this: useDaysMode=Datedue SpecifyDueDate=1 Test plan: - On circulation specify a due date that matches a holiday, the due day should be automatically set to the next open day. - Checkout an item so that the due date (without taking the calendar into account) matches a holiday, the final due date should be set to the next open day. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 20:30:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 18:30:47 +0000 Subject: [Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings In-Reply-To: <bug-7674-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7674-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7674-70-d6TulNHwYq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 --- Comment #9 from Owen Leonard <oleonard at myacpl.org> --- Thanks for the improvements. I see another issue: Clicking a "browse shelf" link in the "other holdings" tab opens the shelf browser in the "<branch> holdings" tab. It would be easy enough to do something like this: [% PROCESS items_table items=otheritemloop tab="otherholdings" %] ...and modify the link to the shelf browser: <a href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% ITEM_RESULT.biblionumber %]&shelfbrowse_itemnumber=[% ITEM_RESULT.itemnumber %]#[% tab %]">Browse shelf</a> ...but I'm not sure how you get the shelf browser to appear under the correct tab. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 20:43:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 18:43:20 +0000 Subject: [Koha-bugs] [Bug 8800] SpecifyDueDate && useDaysMode=Datedue wrong behaviour In-Reply-To: <bug-8800-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8800-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8800-70-wej1jm723c@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12445|0 |1 is obsolete| | --- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 12446 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12446&action=edit Bug 8800 - useDaysMode=Datedue wrong behaviour Forgot to check availability of some variables. Fixed. Regards To+ Sponsored-by: Universidad Nacional de C?rdoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 20:45:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 18:45:05 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: <bug-5349-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5349-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5349-70-C80igIAjyP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net --- Comment #40 from Mirko Tietgen <mirko at abunchofthings.net> --- Does not apply, sorry :( Applying: Bug 5349: Order line transfers /home/pi/koha/.git/rebase-apply/patch:109: new blank line at EOF. + error: patch failed: installer/data/mysql/updatedatabase.pl:5966 error: installer/data/mysql/updatedatabase.pl: patch does not apply Patch failed at 0001 Bug 5349: Order line transfers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 20:50:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 18:50:39 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8798-70-mu6OhLAPYD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 --- Comment #21 from Colin Campbell <colin.campbell at ptfs-europe.com> --- (In reply to comment #20) > (In reply to comment #19) > > (In reply to comment #18) > > > (In reply to comment #17) > > > > > So you're sayng they exist in the database because they were added by > > > updatedatabase but not in kohastructure.sql? > > Yes I think so. I wondered if you were generating from a pristine db. (not > > really a prob for this patch) > > > > > > > > > > > You've got an ActionLogs class but if you recreate the schema it generates > > > > an ActionLog class (Standard behaviour the Loader generates a singular named > > > > class for plural tables) shouls ActionLogs.pm be removed? > > > > > > Are you saying when you ran the generation script it gave you the singular > > > form? I see the plural form in the Results file so I'm a bit confused as to > > > how that slipped through as well. > > Yes I get a ActionLog.pm which is what I would expect. Using your script or > > dbicdump. > > It was from my development DB, I'm not sure if that qualifies as pristine ;) > I wouldn't be opposed to a QAA or Paul re-running the gen script and pushing > their results. This would probably resolve both of the aforementioned > issues. The important thing in this patch is less the class files and more > the code addition in C4::Context for the schema handler. > > Let me know if you'd like me to try and regen or if there is something we > can get paul or a QAA to do. Just out of curiosity if you remove ActionLogs.pm and regenerate does it create ActionLog.pm or ActionLogs.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 20:52:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 18:52:17 +0000 Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in OPAC and staff client In-Reply-To: <bug-8377-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8377-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8377-70-PSOFs6E7GD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12378|0 |1 is obsolete| | --- Comment #24 from Mirko Tietgen <mirko at abunchofthings.net> --- Created attachment 12447 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12447&action=edit Bug 8377 [ENH] Show HTML5 video/ audio for media files in OPAC and staff client This enhancement uses information from MARC field 856 to generate the appropriate HTML5 code to embed am media player for the file(s) in a tab in the OPAC and staff client detail view. This patch supports the HTML5 <audio> and <video> element. Additionally it gives basic support for the <track> element. This element is not supported very well by recent browsers. Please consider the patch working when you get working video or audio. Changes since last version: - failed QA: removed default view for media tab, changed tab name to "Play audio" resp. "Play video". - put most of the code in separate module and access it from OPAC and staff client now, so the feature works in both - had to change sysprefs: HTML5MediaEnabled can be 'none', 'opac', 'staff' or 'both' * Removed default entry for mp3 again to not imply it is widely supported or going to be by free software browsers. If you tested this before, you need to delete the old syspref entries from your database. There is an attachment to do this, use exactly like upgradedatabase.pl. Test plan - Import attached test data. [I chose media typ 'bk' because it's probably present on most systems. It's not appropriate for the data but that doesn't matter.] - Rebuild zebra -b -z - Go to Administration->System preferences->enhanced content->HTML5 Media and set HTML5MediaEnabled to an appropriate setting, save preferences. - Search the OPAC or staff client for 'bug 8377' - Get 4 results - Open detail pages for results. Observe working video (1-3) or audio (4) player on detail page. Squashed both patches together Bug 8377 [ENH] Followup: Move perl module to C4 Bug 8377 [ENH] Followup: fix call for moved module Rebased to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 21:29:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 19:29:44 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8798-70-CBf5upRFsE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 --- Comment #22 from Elliott Davis <elliott at bywatersolutions.com> --- I still get ActionLogs.pm Strange -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 21:31:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 19:31:47 +0000 Subject: [Koha-bugs] [Bug 8800] SpecifyDueDate && useDaysMode=Datedue wrong behaviour In-Reply-To: <bug-8800-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8800-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8800-70-WKtkeVyRzw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12446|0 |1 is obsolete| | --- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 12448 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12448&action=edit useDaysMode='Calendar' should make date due be the next open day too. Sponsored-by: Universidad Nacional de C?rdoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 22:42:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 20:42:46 +0000 Subject: [Koha-bugs] [Bug 8800] SpecifyDueDate && useDaysMode=Datedue wrong behaviour In-Reply-To: <bug-8800-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8800-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8800-70-KgNkM246pz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 Elliott Davis <elliott at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12448|0 |1 is obsolete| | --- Comment #6 from Elliott Davis <elliott at bywatersolutions.com> --- Created attachment 12449 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12449&action=edit Bug 8800 - useDaysMode=Datedue wrong behaviour useDaysMode=Datedue wasn't used as advertised in the docs. Added a next_open_day sub to Koha::Calendar and some tests for it. - AddIssue was fixed for the case $datedue was defined in circ/circulation.pl - CalcDateDue was modified to be consistent with the intended behaviour Regards To+ Sponsored-by: Universidad Nacional de C?rdoba Signed-off-by: Elliott Davis <elliott at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 22:50:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 20:50:10 +0000 Subject: [Koha-bugs] [Bug 8804] New: Quiet errors in the log from Auth.pm Message-ID: <bug-8804-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8804 Priority: P5 - low Change sponsored?: --- Bug ID: 8804 Assignee: oleonard at myacpl.org Summary: Quiet errors in the log from Auth.pm Severity: normal Classification: Unclassified OS: All Reporter: oleonard at myacpl.org Hardware: All Status: ASSIGNED Version: master Component: Architecture, internals, and plumbing Product: Koha Use of uninitialized value $sessiontype in string eq at C4/Auth.pm line 705. Use of uninitialized value $opac_search_limit in pattern match (m//) at C4/Auth.pm line 384. Use of uninitialized value in pattern match (m//) at C4/Auth.pm line 384. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 22:52:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 20:52:32 +0000 Subject: [Koha-bugs] [Bug 8800] SpecifyDueDate && useDaysMode=Datedue wrong behaviour In-Reply-To: <bug-8800-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8800-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8800-70-RuzmhFMqIS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 23:02:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 21:02:29 +0000 Subject: [Koha-bugs] [Bug 8804] Quiet errors in the log from Auth.pm In-Reply-To: <bug-8804-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8804-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8804-70-KeNEoMPbD3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8804 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 12450 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12450&action=edit Bug 8804 - Quiet errors in the log from Auth.pm Found three cases where variables were being referenced which did not (in each case) exist. Adding checks for those variables' existence. Errors appeared when logged in and viewing a detail page in the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 21 23:02:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 21:02:51 +0000 Subject: [Koha-bugs] [Bug 8804] Quiet errors in the log from Auth.pm In-Reply-To: <bug-8804-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8804-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8804-70-7DNjhbHlA7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8804 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 22 01:54:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 21 Sep 2012 23:54:17 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8798-70-9SIxIhHPHC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 --- Comment #23 from wajasu <matted-34813 at mypacks.net> --- Investigated why I get the exception as described in comment #5. I was able to get the test to run with cpanm with a local::lib running on my hostOS(archlinux). I compared the DBIx::Class::Exception between my archlinux cpan install (possible metacpan), and my koha test debian VM. Undefined subroutine &DBIx::Class::Exception::blessed called at /usr/share/perl5/DBIx/Class/Exception.pm line 55 In that file the code is different: debian code with libdbix-class-schema-loader-perl: # Don't re-encapsulate exception objects of any kind die $msg if blessed($msg); my archlinux host cpanm local::lib has: # Don't re-encapsulate exception objects of any kind die $msg if ref($msg); koha at biblio:/usr/share/perl5/DBIx$ grep VER * DEBIAN SQUEEZE VM Class.pm:$VERSION = '0.08123'; <-- debian squeeze kohaclone/local/lib/perl5/DBIx$ grep VER * ARCHLINUX hostOS Class.pm:$VERSION = '0.08200'; The reason I am investigating this is if squeeze's package has an older .deb, it may break folks upgrading, just by installing the package and our upgraded code. Note: Also, my hostOS has a much newer perl 5.16.1. Maybe its my environment's fault, where I pull my deb packages: (OR do i need to do ann update in some way) Here is my /etc/apt/sources.list # deb cdrom:[Debian GNU/Linux 6.0.5 _Squeeze_ - Official amd64 NETINST Binary-1 20120512-20:40]/ squeeze main #deb cdrom:[Debian GNU/Linux 6.0.5 _Squeeze_ - Official amd64 NETINST Binary-1 20120512-20:40]/ squeeze main deb http://ftp.gtlib.gatech.edu/debian/ squeeze main deb-src http://ftp.gtlib.gatech.edu/debian/ squeeze main deb http://debian.koha-community.org/koha squeeze main deb http://security.debian.org/ squeeze/updates main deb-src http://security.debian.org/ squeeze/updates main # squeeze-updates, previously known as 'volatile' deb http://ftp.gtlib.gatech.edu/debian/ squeeze-updates main deb-src http://ftp.gtlib.gatech.edu/debian/ squeeze-updates main I'm documenting this for all future DBIx related deployment. Also, I had done a dbicdump on my archlinux with the newer version and it generated Koha::Schema::ActionLog.pm Maybe yours was generated with the debian pkg version. wajasu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 22 02:10:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Sep 2012 00:10:15 +0000 Subject: [Koha-bugs] [Bug 6617] table of contents not printing right if entered right In-Reply-To: <bug-6617-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6617-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6617-70-G0xu1tU1fA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6617 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 22 04:36:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Sep 2012 02:36:23 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8798-70-8fKOGdr1bn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 --- Comment #24 from Elliott Davis <elliott at bywatersolutions.com> --- Wajasu perhaps it is a package oddity. Colin what are you testing on? Should this prevent this from being signed off on? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 22 08:18:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Sep 2012 06:18:26 +0000 Subject: [Koha-bugs] [Bug 8304] composed authorities Rameau management In-Reply-To: <bug-8304-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8304-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8304-70-qgz3zEjmgI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 22 08:31:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Sep 2012 06:31:30 +0000 Subject: [Koha-bugs] [Bug 8302] Add accesssion number to the drop down list in OPAC Search. In-Reply-To: <bug-8302-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8302-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8302-70-9yVpNd7Lv1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8302 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8778 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 22 08:31:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Sep 2012 06:31:30 +0000 Subject: [Koha-bugs] [Bug 8778] Add "Phrase" Searching to OPAC Search In-Reply-To: <bug-8778-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8778-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8778-70-rHFTjU0Z5m@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8778 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8302 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 22 08:58:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Sep 2012 06:58:15 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8798-70-Y7YpXysNr3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 --- Comment #25 from wajasu <matted-34813 at mypacks.net> --- Better news. I got my fresh debian VM built. Here are may latest observations: In the VM: koha at biblio:~/kohaclone/local/lib/perl5/DBIx$ grep VER * Class.pm:$VERSION = '0.08200'; So my other VM must have been older (a month, and maybe grabbed an older version). koha at biblio:~/kohaclone$ prove t/Context.t t/Context.t .. DBIx::Class::Relationship::HasOne::might_have(): "might_have/has_one" must not be on columns with is_nullable set to true (Koha::Schema::Result::Borrower/cardnumber). This might indicate an incorrect use of those relationship helpers instead of belongs_to. at /home/koha/kohaclone/Koha/Schema/Result/Borrower.pm line 780 t/Context.t .. ok All tests successful. Files=1, Tests=1, 2 wallclock secs ( 0.04 usr 0.00 sys + 0.78 cusr 0.07 csys = 0.89 CPU) Result: PASS (Just guessed that you want DateTime when inflating. You might have not.) [Maybe you can note the exact dbicdump command line you used in the bug report, for future reference. I know they might want Versioned, but I know you have started tweaks, probably for cardnumber in borrower.] koha at biblio:~$ dbicdump -o dump_directory=./lib -o components='["InflateColumn::DateTime"]' -o debug=1 Koha::Schema 'DBI:mysql:database=koha;host=localhost' koha koha Dumping manual schema for Koha::Schema to directory ./lib ... Schema dump completed. I got ActionLogs.pm in my dump in this debian VM. koha at biblio:~/kohaclone$ prove t/Context.t t/Context.t .. DBIx::Class::Relationship::HasOne::might_have(): "might_have/has_one" must not be on columns with is_nullable set to true (Koha::Schema::Result::Borrower/cardnumber). This might indicate an incorrect use of those relationship helpers instead of belongs_to. at /home/koha/kohaclone/Koha/Schema/Result/Borrower.pm line 780 t/Context.t .. ok All tests successful. Files=1, Tests=1, 1 wallclock secs ( 0.03 usr 0.00 sys + 0.80 cusr 0.04 csys = 0.87 CPU) Result: PASS I also tested to see if DBIx tries to connect to the DB, by shutting down the mysql instance, and it made no difference. So you might want to get rid of the Borrower/cardnumber thing above. We can't have this spitting out junk everytime we use the context. Note: It does so for "perl Makefile.PL" or any thing that uses C4::Context. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 22 14:27:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Sep 2012 12:27:25 +0000 Subject: [Koha-bugs] [Bug 459] No uninstall script In-Reply-To: <bug-459-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-459-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-459-70-yeYP5Oh6Jd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=459 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12435|0 |1 is obsolete| | Status|NEW |In Discussion Assignee|mjr at software.coop |mtompset at hotmail.com --- Comment #3 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 12451 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12451&action=edit Revised partially tested, but still a bit buggy non-patch file Fine, I'll take the bug. I haven't patch-i-fied this yet. I've only run this on a packages installation. The koha zebra daemon removal part still needs some work. But once I'm happy with my testing on packages, I'll work on testing it on a git install. Then I'll go old-school with a tarball install. I probably need to add logic to exclude the git clone directory from deletion. Any other ideas or feedback? Feel free to test tweak and post a patch if you want. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 22 15:07:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Sep 2012 13:07:29 +0000 Subject: [Koha-bugs] [Bug 8793] Fix materialTypeCode/typeOf008 icons for NORMARC XSLT In-Reply-To: <bug-8793-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8793-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8793-70-6ev9WHsIDZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8793 Magnus Enger <magnus at enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove references to OPAC |Fix |icons from NORMARC staff |materialTypeCode/typeOf008 |XSLT |icons for NORMARC XSLT --- Comment #1 from Magnus Enger <magnus at enger.priv.no> --- Broadening the scope of this bug a bit, to cover more (closely related) problems. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 22 15:43:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Sep 2012 13:43:31 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7736-70-NuhcS6dXZi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Zeno Tajoli <tajoli at cilea.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tajoli at cilea.it --- Comment #14 from Zeno Tajoli <tajoli at cilea.it> --- Errors on apply the patch: error: patch failed: installer/data/mysql/sysprefs.sql:382 error: installer/data/mysql/sysprefs.sql: patch does not apply error: patch failed: installer/data/mysql/updatedatabase.pl:5966 error: installer/data/mysql/updatedatabase.pl: patch does not apply In fact the problem is trivial: those files (sysprefs.sql and updatedatabase.pl) are changing quite quickly those days -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 22 15:48:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Sep 2012 13:48:45 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7736-70-bSJGcGLZm0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #15 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- (In reply to comment #14) > Errors on apply the patch: > error: patch failed: installer/data/mysql/sysprefs.sql:382 > error: installer/data/mysql/sysprefs.sql: patch does not apply > error: patch failed: installer/data/mysql/updatedatabase.pl:5966 > error: installer/data/mysql/updatedatabase.pl: patch does not apply > > In fact the problem is trivial: those files (sysprefs.sql and > updatedatabase.pl) > are changing quite quickly those days If you use git am -3 you'll be able to resolve the conflict yourself. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 22 20:31:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Sep 2012 18:31:02 +0000 Subject: [Koha-bugs] [Bug 7243] Do not take rentals as fines In-Reply-To: <bug-7243-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7243-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7243-70-gyvGL4b4RO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11943|0 |1 is obsolete| | --- Comment #14 from Marc V?ron <veron at veron.ch> --- Created attachment 12452 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12452&action=edit bug_7243: Be selective when summing up charges for blocking issues Added RentalsInNoissueCharges and ManInvlsInNoissueCharges sys prefs Created C4::Members::cwGetMemberAccountBallance() * A wrapper for GetMemberAccountRecords that gives info on non-issue and other charges * Other charges are: 'Res' 'Rent' if RentalsInNoissueCharges is Mo authorised_values MANUAL_INV if ManInvlsInNoissueCharges is No C4::Members::GetMemberAccountRecords() changes: * Dropped input param $date, it is not used Use split charges in C4::Circulation::CanBookBeIssued() and C4::Members::patronflags(). That way only fines decide whether an item can be issued, and not other non-fine charges -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 22 20:34:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Sep 2012 18:34:29 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8798-70-E1ICetR719@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 Elliott Davis <elliott at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12442|0 |1 is obsolete| | --- Comment #26 from Elliott Davis <elliott at bywatersolutions.com> --- Created attachment 12453 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12453&action=edit Added base class files for all tables in koha using the DBIx::Class::Schema::Loader Added a (very basic) test file for C4::Context Also added dependencies in required files. [Update]: changed dependencies fron dbic to dbix moved generation shell script to a perl script wtih arguments in misc/devel To Test: Install patch Make sure you can still connect to Koha you may optionally run the test script in comment 12 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798#c12 If you run this file you should get a DBIx dump of the borrowers table Done! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 22 20:34:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Sep 2012 18:34:32 +0000 Subject: [Koha-bugs] [Bug 7243] Do not take rentals as fines In-Reply-To: <bug-7243-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7243-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7243-70-Y4oMXvbpmh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12452|0 |1 is obsolete| | --- Comment #15 from Marc V?ron <veron at veron.ch> --- Created attachment 12454 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12454&action=edit [SIGNED-OFF] bug_7243: Be selective when summing up charges for blocking issues Added RentalsInNoissueCharges and ManInvlsInNoissueCharges sys prefs Created C4::Members::cwGetMemberAccountBallance() * A wrapper for GetMemberAccountRecords that gives info on non-issue and other charges * Other charges are: 'Res' 'Rent' if RentalsInNoissueCharges is Mo authorised_values MANUAL_INV if ManInvlsInNoissueCharges is No C4::Members::GetMemberAccountRecords() changes: * Dropped input param $date, it is not used Use split charges in C4::Circulation::CanBookBeIssued() and C4::Members::patronflags(). That way only fines decide whether an item can be issued, and not other non-fine charges Signed-off-by: Marc Veron <veron at veron.ch> Rebased (updatedatabase.pl) ManInvInNoissueCharges and RentalsInNoissueCharges ar both included by default (= behaviour as before) All variants tested: Both included, none included, manual invoice included, rentals included. Works fine, blocks/does not blok as appropirate, messages appear as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 22 20:35:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Sep 2012 18:35:11 +0000 Subject: [Koha-bugs] [Bug 7243] Do not take rentals as fines In-Reply-To: <bug-7243-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7243-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7243-70-OQAxrGFzrb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 22 21:07:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Sep 2012 19:07:01 +0000 Subject: [Koha-bugs] [Bug 2601] Order fines by date and time In-Reply-To: <bug-2601-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2601-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2601-70-CDLfdyBMST@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2601 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #4 from Marc V?ron <veron at veron.ch> --- Accountlines primary key was added by Bug 7671. Is this bug still valid? Marc -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 22 23:01:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 22 Sep 2012 21:01:04 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8798-70-MdRI86w4hv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 --- Comment #27 from wajasu <matted-34813 at mypacks.net> --- i found a way to squelch the validation warning. in C4/Context.pm i put $ENV{'DBIC_DONT_VALIDATE_RELS'} = 1; # FIXME once the DBIx schema has its schema adjusted we should remove this If this is going out in whatever state its in, this will prevent us from seeing the warning all over the place, but we should write a bug noting this to track it as a possible outstanding issue. But we will loose this other lrelationship validations as well. When we write tests, we might just write a test for the schema for us to see those validation tests. See the source for reference. /usr/share/perl5/DBIx/Class/Relationship/HasOne.pm prove t/Context.t t/Context.t .. ok All tests successful. Files=1, Tests=1, 1 wallclock secs ( 0.03 usr 0.01 sys + 0.69 cusr 0.05 csys = 0.78 CPU) Result: PASS I ran dbicdump on my debian VM and it matches what Elliot got. ActionLogs.pm I ran it on my archlinux hostOS and it generates ActionLog.pm So maybe some transitive dependency for plural/stemming etc is newer on my, and Colin's environments. You might want to rename it to ActionLog to align with future behavior. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 23 10:47:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Sep 2012 08:47:06 +0000 Subject: [Koha-bugs] [Bug 8805] New: Add a biblio-zebra-indexdefs.xsl for NORMARC Message-ID: <bug-8805-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8805 Priority: P5 - low Change sponsored?: --- Bug ID: 8805 Assignee: magnus at enger.priv.no Summary: Add a biblio-zebra-indexdefs.xsl for NORMARC Severity: major Classification: Unclassified OS: All Reporter: magnus at enger.priv.no Hardware: All Status: ASSIGNED Version: master Component: Searching Product: Koha I just did a fresh install of master with NORMARC, and when I try to run rebuild_zebra.pl I get this error: 10:39:24-23/09 zebraidx(10578) [warn] /home/magnus/sites/koha-dev/etc/zebradb/biblios/etc/dom-config-marc.xml: stylesheet biblio-zebra-indexdefs.xsl not found in path /home/magnus/sites/koha-dev/etc/zebradb/biblios/etc:/home/magnus/sites/koha-dev/etc/zebradb/etc:/home/magnus/sites/koha-dev/etc/zebradb/marc_defs/normarc/biblios:/home/magnus/sites/koha-dev/etc/zebradb/lang_defs/nb:/home/magnus/sites/koha-dev/etc/zebradb/xsl 10:39:24-23/09 zebraidx(10578) [warn] /home/magnus/sites/koha-dev/etc/zebradb/biblios/etc/dom-config-marc.xml: stylesheet biblio-zebra-indexdefs.xsl not found in path /home/magnus/sites/koha-dev/etc/zebradb/biblios/etc:/home/magnus/sites/koha-dev/etc/zebradb/etc:/home/magnus/sites/koha-dev/etc/zebradb/marc_defs/normarc/biblios:/home/magnus/sites/koha-dev/etc/zebradb/lang_defs/nb:/home/magnus/sites/koha-dev/etc/zebradb/xsl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 23 10:47:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Sep 2012 08:47:49 +0000 Subject: [Koha-bugs] [Bug 8805] Add a biblio-zebra-indexdefs.xsl for NORMARC In-Reply-To: <bug-8805-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8805-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8805-70-YYHdYdT2yn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8805 Magnus Enger <magnus at enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7818 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 23 10:47:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Sep 2012 08:47:49 +0000 Subject: [Koha-bugs] [Bug 7818] support DOM mode for Zebra indexing of bibliographic records In-Reply-To: <bug-7818-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7818-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7818-70-xR1t5wuIAF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7818 Magnus Enger <magnus at enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8805 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 23 12:32:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Sep 2012 10:32:35 +0000 Subject: [Koha-bugs] [Bug 8793] Fix materialTypeCode/typeOf008 icons for NORMARC XSLT In-Reply-To: <bug-8793-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8793-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8793-70-cxpyaB0pxj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8793 --- Comment #2 from Magnus Enger <magnus at enger.priv.no> --- Created attachment 12455 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12455&action=edit Bug 8793 - Fix materialTypeCode/typeOf008 icons for NORMARC XSLT This patch fixes some issues with icons related to materialtypes in NORMARC: Remove references to opac-tmpl in the *intranet* NORMARC XSLT files. Add two new icons to koha-tmpl/intranet-tmpl/prog/img/famfamfam/ and koha-tmpl/opac-tmpl/lib/famfamfam/ GR.png - Graphical materials TD.png - Three dimentional objects Copy PR.png from koha-tmpl/intranet-tmpl/prog/img/famfamfam/ to koha-tmpl/opac-tmpl/lib/famfamfam/ Rename the XSLT variable materialTypeCode to typeOf008 for increased consistency between stylesheets. Make sure the XSLT uses icons that are actually available. To test: - No use testing all the different permutations of leader pos. 06 and 019b, I think. - Set marcflavour = NORMARC and turn on default XSLT for OPAC and Intranet, details and results. - Make sure you have a record with something relevant in leader position 6, like g for movies or c for music - Check that the icon turns up in results and details, in the OPAC and Intranet - Toggle DisplayOPACiconsXSLT and check that the results in the OPAC are as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 23 12:49:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Sep 2012 10:49:46 +0000 Subject: [Koha-bugs] [Bug 8624] famfamfam should be outside theme directory In-Reply-To: <bug-8624-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8624-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8624-70-pRgxtiWRWu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8624 Magnus Enger <magnus at enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8793 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 23 12:49:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Sep 2012 10:49:46 +0000 Subject: [Koha-bugs] [Bug 8793] Fix materialTypeCode/typeOf008 icons for NORMARC XSLT In-Reply-To: <bug-8793-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8793-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8793-70-8gTFMqtgDr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8793 Magnus Enger <magnus at enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Depends on| |8624 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 23 12:55:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Sep 2012 10:55:30 +0000 Subject: [Koha-bugs] [Bug 8662] Remove unused famfamfam icons In-Reply-To: <bug-8662-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8662-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8662-70-ArB03e5Opp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8662 Magnus Enger <magnus at enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no --- Comment #1 from Magnus Enger <magnus at enger.priv.no> --- NORMARC XSLT has been using some famfamfam icons from the big collection, but if the patch on bug 8793 gets pushed it will only use icons from koha-tmpl/opac-tmpl/lib/famfamfam/ and koha-tmpl/intranet-tmpl/prog/img/famfamfam/ (not from the silk/ dirs below these dirs). So no objections from the Norwegian jury! ;-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 23 12:55:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Sep 2012 10:55:37 +0000 Subject: [Koha-bugs] [Bug 8662] Remove unused famfamfam icons In-Reply-To: <bug-8662-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8662-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8662-70-SFDEC1D3tM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8662 Magnus Enger <magnus at enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8793 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 23 12:55:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Sep 2012 10:55:37 +0000 Subject: [Koha-bugs] [Bug 8793] Fix materialTypeCode/typeOf008 icons for NORMARC XSLT In-Reply-To: <bug-8793-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8793-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8793-70-NNQpPQjtGH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8793 Magnus Enger <magnus at enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8662 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 23 16:45:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Sep 2012 14:45:48 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: <bug-6813-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6813-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6813-70-3JTRD8hGJo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 --- Comment #18 from Marc V?ron <veron at veron.ch> --- Created attachment 12456 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12456&action=edit Bug 6813: Followup: Fix HTML4 coding, new wording, warning on empty search terms The aim of this followup is to fix issues from Comment #17: - HTML4 encoding UCfirst fixed - Warning regardig large databases - Added javascript with warning if search terms are empty - Removed not used fields from search form - Changed wording from "Duplicate search" (Google: 15'000) to "Find duplicates" (Google: 576'000) To Test: Create a an suggestion, order and catalog record for a certain title. Use the duplicate search tool available in the acquisitions menu (left navigation bar) to search and find the suggestion, order and catalog record matching the search term. Enter one or more of title, author and ISBN in the search criteria. Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 23 16:48:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Sep 2012 14:48:40 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: <bug-6813-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6813-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6813-70-sbEKrkEeRV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #19 from Marc V?ron <veron at veron.ch> --- I suppose the changes I made need a new signoff... Oh, and in my previous comment I mistaked with the wording, it is "Duplicate finder" (Google: 1'710'000) Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 23 18:19:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Sep 2012 16:19:38 +0000 Subject: [Koha-bugs] [Bug 7986] Export issues In-Reply-To: <bug-7986-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7986-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7986-70-oRe7fuTxqe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12296|0 |1 is obsolete| | --- Comment #37 from Marc V?ron <veron at veron.ch> --- Created attachment 12457 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12457&action=edit [SIGNED-OFF] Bug 7986: Followup: Hide the export link unless sysprefs are set If at least one of both sysprefs (ExportRemoveFields and ExportWithCsvProfile) is filled, the export link is displayed Signed-off-by: Marc Veron <veron at veron.ch> Tested with both sysprefs filled/not filled, patch behaves as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 23 18:20:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Sep 2012 16:20:42 +0000 Subject: [Koha-bugs] [Bug 7986] Export issues In-Reply-To: <bug-7986-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7986-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7986-70-uunoDBvctB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 23 18:49:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Sep 2012 16:49:47 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8236-70-24bv5uVwyx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #13 from Marc V?ron <veron at veron.ch> --- Patch does not apply, sorry: error: patch failed: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt:865 error: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt: patch does not apply error: patch failed: koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt:247 error: koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt: patch does not apply Regarding updatedatabase.pl: You can set the version to "XXXX", i.e.: $DBversion = "XXXX"; Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 23 20:40:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Sep 2012 18:40:29 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7736-70-qGALT3RIil@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Zeno Tajoli <tajoli at cilea.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #16 from Zeno Tajoli <tajoli at cilea.it> --- Hi to all. I can't sign-off the patch. In kohastructure.sql and updatedatabase.pl I see: CREATE TABLE IF NOT EXISTS edifact_messages ( key int(11) NOT NULL auto_increment, message_type text NOT NULL, date_sent date default NULL, provider int(11) default NULL, status text, basketno int(11) NOT NULL default '0', PRIMARY KEY (key) ) ENGINE=InnoDB DEFAULT CHARSET=utf8; The string key is a reserved word in Mysql 5.5, http://dev.mysql.com/doc/refman/5.5/en/reserved-words.html I don't know if it is better to use `key` or to use a different name -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 23 21:12:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Sep 2012 19:12:36 +0000 Subject: [Koha-bugs] [Bug 8804] Quiet errors in the log from Auth.pm In-Reply-To: <bug-8804-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8804-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8804-70-NXAL67IntN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8804 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12450|0 |1 is obsolete| | --- Comment #2 from Marc V?ron <veron at veron.ch> --- Created attachment 12458 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12458&action=edit [SIGNED-OFF] Bug 8804 - Quiet errors in the log from Auth.pm Found three cases where variables were being referenced which did not (in each case) exist. Adding checks for those variables' existence. Errors appeared when logged in and viewing a detail page in the OPAC. Signed-off-by: Marc Veron <veron at veron.ch> I could reproduce both errors with the staff client, not with the Opac. After applying the patch no more log entries regarding line 705 and line 384, so I sign off this patch. However I had one more similar log entry (with and without patch) that could be addressed in a follow up: mainpage.pl: Use of uninitialized value $pki_field in string eq at (...)/C4/Auth.pm line 736., referer: http://(...) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 23 21:13:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Sep 2012 19:13:24 +0000 Subject: [Koha-bugs] [Bug 8804] Quiet errors in the log from Auth.pm In-Reply-To: <bug-8804-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8804-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8804-70-mQuIL6dPo9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8804 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 23 21:28:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Sep 2012 19:28:26 +0000 Subject: [Koha-bugs] [Bug 8801] Offer to batch delete items of a biblio record In-Reply-To: <bug-8801-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8801-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8801-70-u1GN7YkoCK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8801 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12428|0 |1 is obsolete| | --- Comment #2 from Marc V?ron <veron at veron.ch> --- Created attachment 12459 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12459&action=edit [SIGNED-OFF] Bug 8801: Add menu entry to delete items in batch In catalogue/detail.pl you can now select "Delete items in batch" in "Edit" menu. You are redirected to batchMod.pl for chosing which items have to be deleted. You need to have 'tools.items_batchdel' permission to see this menu entry. Signed-off-by: Marc Veron <veron at veron.ch> Works as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 23 21:28:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Sep 2012 19:28:52 +0000 Subject: [Koha-bugs] [Bug 8801] Offer to batch delete items of a biblio record In-Reply-To: <bug-8801-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8801-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8801-70-olExRJ4oIh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8801 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 23 21:35:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Sep 2012 19:35:21 +0000 Subject: [Koha-bugs] [Bug 7867] Same text for username/login in OPAC and intranet In-Reply-To: <bug-7867-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7867-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7867-70-pYv4MlFYmM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7867 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12412|0 |1 is obsolete| | --- Comment #2 from Marc V?ron <veron at veron.ch> --- Created attachment 12460 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12460&action=edit [SIGNED-OFF] Bug 7867: "username" instead of "login" on OPAC Just for a consistent use of words. Signed-off-by: Marc Veron <veron at veron.ch> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 23 21:35:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 23 Sep 2012 19:35:42 +0000 Subject: [Koha-bugs] [Bug 7867] Same text for username/login in OPAC and intranet In-Reply-To: <bug-7867-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7867-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7867-70-TmLYxjKwXv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7867 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 02:34:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 00:34:14 +0000 Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix In-Reply-To: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5786-70-uOG9ZxfKNF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 --- Comment #64 from Srdjan Jankovic <srdjan at catalyst.net.nz> --- Hi Paul, Want me to do anything? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 07:32:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 05:32:21 +0000 Subject: [Koha-bugs] [Bug 8806] New: Debian packaging updates Message-ID: <bug-8806-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8806 Priority: P5 - low Change sponsored?: --- Bug ID: 8806 CC: robin at catalyst.net.nz Assignee: koha-bugs at lists.koha-community.org Summary: Debian packaging updates Severity: enhancement Classification: Unclassified OS: All Reporter: robin at catalyst.net.nz Hardware: All Status: NEW Version: rel_3_6 Component: Packaging Product: Koha This will get the code in git in line with what is actually built into packages. There will be separate patches for 3.6 and 3.8. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 07:33:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 05:33:37 +0000 Subject: [Koha-bugs] [Bug 8806] Debian packaging updates In-Reply-To: <bug-8806-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8806-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8806-70-7hhiyMOl0b@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8806 --- Comment #1 from Robin Sheat <robin at catalyst.net.nz> --- Created attachment 12461 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12461&action=edit Bug 8806 - [3.6.x] Update changelog for 3.6.5-3.6.9, dependencies. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 07:50:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 05:50:42 +0000 Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix In-Reply-To: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5786-70-16IdQOAwcR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 --- Comment #65 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Srdjan, it looks like Paul found a real problem with this - can you confirm and maybe fix it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 08:33:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 06:33:14 +0000 Subject: [Koha-bugs] [Bug 7409] Missing dependencies for Debian package In-Reply-To: <bug-7409-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7409-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7409-70-Wj7ORCdqd0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7409 Robin Sheat <robin at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #16 from Robin Sheat <robin at catalyst.net.nz> --- There's something wrong here. In particular, C4::Installer::PerlDependencies doesn't contain the required modules, and so they will not be included in the debian build. The debian control file is automatically generated, and shouldn't be edited by hand. I will add it to the dependencies file as part of 8806. I'll chance the status on this, as this patch really shouldn't go in in this form. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 08:45:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 06:45:24 +0000 Subject: [Koha-bugs] [Bug 7300] display suggestions from librarian library only by default In-Reply-To: <bug-7300-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7300-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7300-70-y8gsLLvuss@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7300 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #10 from Marc V?ron <veron at veron.ch> --- I agree with Katrin and Nicole that there should be a syspref. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 09:01:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 07:01:54 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: <bug-5349-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5349-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5349-70-DdQFsqGa8T@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12420|0 |1 is obsolete| | --- Comment #41 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 12462 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12462&action=edit [SIGNED-OFF] Bug 5349: Order line transfers Rebased on master. (conflicts on updatedatabase.pl) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 09:02:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 07:02:16 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: <bug-5349-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5349-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5349-70-Hmqiabp2PA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12421|0 |1 is obsolete| | --- Comment #42 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 12463 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12463&action=edit Bug 5349 follow-up: run transferorder.pl in a popup Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 09:02:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 07:02:35 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: <bug-5349-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5349-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5349-70-eBqt98vARy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12422|0 |1 is obsolete| | --- Comment #43 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 12464 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12464&action=edit Bug 5349: Fix a logical test in TransferOrder Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 09:03:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 07:03:07 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: <bug-5349-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5349-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5349-70-k2UIq4sCxQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12463|Bug 5349 follow-up: run |[SIGNED-OFF] Bug 5349 description|transferorder.pl in a popup |follow-up: run | |transferorder.pl in a popup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 09:11:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 07:11:11 +0000 Subject: [Koha-bugs] [Bug 8806] Debian packaging updates In-Reply-To: <bug-8806-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8806-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8806-70-QsLPHCeK58@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8806 --- Comment #2 from Robin Sheat <robin at catalyst.net.nz> --- Created attachment 12465 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12465&action=edit Bug 8806 - [3.8.x] Changelog updates, dependencies This adds dependencies that are required for tests to run, but weren't added to the dependencies file, and so causing issues with package builds. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 09:12:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 07:12:25 +0000 Subject: [Koha-bugs] [Bug 8806] Debian packaging updates In-Reply-To: <bug-8806-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8806-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8806-70-tZ0dNDBmzd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8806 Robin Sheat <robin at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |robin at catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 09:14:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 07:14:27 +0000 Subject: [Koha-bugs] [Bug 8806] Debian packaging updates In-Reply-To: <bug-8806-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8806-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8806-70-ogCOymXsBN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8806 --- Comment #3 from Robin Sheat <robin at catalyst.net.nz> --- I'd like the 3.8 version to have a bit more checking, it changes actual perl. The 3.6 version is fairly simple. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 09:15:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 07:15:02 +0000 Subject: [Koha-bugs] [Bug 7409] Missing dependencies for Debian package In-Reply-To: <bug-7409-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7409-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7409-70-6AjqGs6W1f@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7409 --- Comment #17 from Robin Sheat <robin at catalyst.net.nz> --- These changes have been included in bug 8806, things are best done there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 09:33:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 07:33:41 +0000 Subject: [Koha-bugs] [Bug 8415] Link Serial with Acquisition In-Reply-To: <bug-8415-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8415-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8415-70-KCGYQ8IJNy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8415 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- There are 2 known problems with those patches: 1) The functionality is incomplete as the part for the new order and item receive forms is still missing. I tried rebasing the patches from Biblibre, but the item management has changed so much I had problems to get it working. The approach on bug 8456 to solve this is a bit different, I noted my concerns on this bug and also linked to the commit I tried to rebase. 2) While testing I noted a few things with these patches: a) blocker: If you cancel a subscription order, you can't reorder it. The warning that is supposed to block double orders in a year will remain, there is no order link on the subscription search result list but only the warning. b) minor: the branch code in the result list should be the branch name, as it is in the filters on the left side. c) normal: the code should be using the date plugin. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 09:59:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 07:59:02 +0000 Subject: [Koha-bugs] [Bug 8262] Special kohaadmin cannot create lists In-Reply-To: <bug-8262-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8262-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8262-70-EWhVayDrNw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8262 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Version|rel_3_8 |master Component|Architecture, internals, |Virtual Shelves |and plumbing | Hardware|PC |All Assignee|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl Resolution|FIXED |--- Summary|Could not add or create |Special kohaadmin cannot |List in koha 3.8.1 |create lists Severity|enhancement |major OS|Linux |All --- Comment #3 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- I would like to reopen this report. verolencinas: What you say, is correct. But i would say that it is not a solution but a workaround. Koha should give a warning on screen here and not only produce a sql error in the logfile. I will submit a proposed patch soon to check the user and raise a warning in this situation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 10:01:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 08:01:47 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8798-70-wDXdYdFeXh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 --- Comment #28 from Colin Campbell <colin.campbell at ptfs-europe.com> --- (In reply to comment #24) > Wajasu perhaps it is a package oddity. Colin what are you testing on? > > Should this prevent this from being signed off on? No it shouldnt stop sign off. Looks like its a bug in debian's package. I was just trying to confirm the behaviour to see if theres a bug in loader. I'm testing on Fedora using perl 5.16.1/5.17.4 DBIx::Class::Schema::Loader 0.07033 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 10:54:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 08:54:49 +0000 Subject: [Koha-bugs] [Bug 8807] New: add Carton support to Koha Message-ID: <bug-8807-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8807 Priority: P5 - low Change sponsored?: --- Bug ID: 8807 Assignee: gmcharlt at gmail.com Summary: add Carton support to Koha Severity: normal Classification: Unclassified OS: All Reporter: mtj at kohaaloha.com Hardware: All Status: NEW Version: master Component: Installation and upgrade (command-line installer) Product: Koha using Carton, we can select specific versions of perl packages from CPAN -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 10:56:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 08:56:18 +0000 Subject: [Koha-bugs] [Bug 8807] add Carton support to Koha In-Reply-To: <bug-8807-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8807-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8807-70-hzX2Ghxd3Y@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8807 --- Comment #1 from Mason James <mtj at kohaaloha.com> --- here is more info on Carton http://www.slideshare.net/dagolden/cooking-perlwithchefpresentationfinal http://search.cpan.org/~miyagawa/carton-v0.9.4/lib/Carton/Doc/FAQ.pod -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 12:43:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 10:43:49 +0000 Subject: [Koha-bugs] [Bug 8738] DateTime object being compared to a date string in circulation In-Reply-To: <bug-8738-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8738-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8738-70-01olCkyjsk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8738 --- Comment #6 from MJ Ray (software.coop) <mjr at software.coop> --- Well, it's great that it works for you, but it's erroring for some libraries. I suspect this might only present itself on upgrades where the circulation history meets some combination of conditions, but I have met it three times on different servers at different libraries so far: one we installed, one we upgraded and one we only support after they met this. In theory, it looks like a type error to me. Can you see how that circ/circulation.pl line http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=circ/circulation.pl;h=f15d4cea94e67e74b6c87ccbef50d0c572b658d1;hb=HEAD#l469 isn't comparing a DateTime to a string, or explain why that isn't a bug? In the first comparison in that line: $it->{'issuedate'} is a DateTime returned by C4::Members::GetPendingIssues(...) since the addition of hourly loans. http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/Members.pm;h=b2f45b955bf3ff3ba57457ca6ec2130fb38021ec;hb=HEAD#l1039 $todaysdate is a string returned by C4::Dates->new->output('iso') http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/Dates.pm;h=4fd08aeb6c4e94a744652b321202d313cd531eb5;hb=HEAD#l184 At best, if this fix doesn't break your test copies in practice and you can't see a theoretical problem with it, could we include it, please? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 13:05:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 11:05:07 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7736-70-qLTGwROlFN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #17 from Paul Poulain <paul.poulain at biblibre.com> --- > I don't know if it is better to use `key` or to use a different name Using a keyword is always as field name a bad practise, so I would say use a different name ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 13:28:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 11:28:49 +0000 Subject: [Koha-bugs] [Bug 8808] New: authority cataloging missing duplicate and delete icons Message-ID: <bug-8808-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8808 Priority: P5 - low Change sponsored?: --- Bug ID: 8808 Assignee: oleonard at myacpl.org Summary: authority cataloging missing duplicate and delete icons Severity: minor Classification: Unclassified OS: All Reporter: nengard at gmail.com Hardware: All Status: NEW Version: master Component: Templates Product: Koha Created attachment 12466 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12466&action=edit plus and minus When editing an authority record it still has the plus and minus icons from the old cataloging interface. Instead it should have all the pretty little icons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 13:35:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 11:35:45 +0000 Subject: [Koha-bugs] [Bug 8809] New: Cascading Holds Message-ID: <bug-8809-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8809 Priority: P5 - low Change sponsored?: --- Bug ID: 8809 CC: gmcharlt at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: Cascading Holds Severity: enhancement Classification: Unclassified OS: All Reporter: nengard at gmail.com Hardware: All Status: NEW Version: master Component: Hold requests Depends on: 7710 Product: Koha It would be nice once we have the ability to place holds on multiple items attached to one title if the patron could define which item them want first. So if they place holds all of the items attached to a TV series on DVD for example. They want to be able to say I want Disc 1 before Disc 2 and so on. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 13:35:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 11:35:45 +0000 Subject: [Koha-bugs] [Bug 7710] multiple holds per title In-Reply-To: <bug-7710-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7710-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7710-70-n6gJ3aABKD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8809 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 13:37:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 11:37:43 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7736-70-WAS9khIIgF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Colin Campbell <colin.campbell at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12438|0 |1 is obsolete| | --- Comment #18 from Colin Campbell <colin.campbell at ptfs-europe.com> --- Created attachment 12467 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12467&action=edit Revised patch Revised the patch to not use mysql keyoword in messages table. updated interface to reflect that -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 13:38:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 11:38:45 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7736-70-v8i1E1a1Ic@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Colin Campbell <colin.campbell at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |colin.campbell at ptfs-europe. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 13:40:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 11:40:48 +0000 Subject: [Koha-bugs] [Bug 8738] DateTime object being compared to a date string in circulation In-Reply-To: <bug-8738-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8738-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8738-70-TnlQwvuxrb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8738 --- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> --- MJ, can you please provide us with a scenario that will produce the error you describe in comment 1? You tell us to prove this is not a bug. That seems a bit backwards, don't you think? I just want to be able to reproduce your error, and prove this patch fixes it with no new errors or bad behavior. Kyle (In reply to comment #6) > Well, it's great that it works for you, but it's erroring for some libraries. > > I suspect this might only present itself on upgrades where the circulation > history meets some combination of conditions, but I have met it three times > on different servers at different libraries so far: one we installed, one we > upgraded and one we only support after they met this. > > In theory, it looks like a type error to me. Can you see how that > circ/circulation.pl line > http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=circ/circulation. > pl;h=f15d4cea94e67e74b6c87ccbef50d0c572b658d1;hb=HEAD#l469 isn't comparing a > DateTime to a string, or explain why that isn't a bug? > > In the first comparison in that line: > > $it->{'issuedate'} is a DateTime returned by > C4::Members::GetPendingIssues(...) since the addition of hourly loans. > http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/Members.pm; > h=b2f45b955bf3ff3ba57457ca6ec2130fb38021ec;hb=HEAD#l1039 > > $todaysdate is a string returned by C4::Dates->new->output('iso') > http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/Dates.pm; > h=4fd08aeb6c4e94a744652b321202d313cd531eb5;hb=HEAD#l184 > > At best, if this fix doesn't break your test copies in practice and you > can't see a theoretical problem with it, could we include it, please? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 14:21:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 12:21:56 +0000 Subject: [Koha-bugs] [Bug 8807] add Carton support to Koha In-Reply-To: <bug-8807-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8807-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8807-70-hFs927IMAC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8807 --- Comment #2 from Mason James <mtj at kohaaloha.com> --- Created attachment 12468 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12468&action=edit Bug 8807 - add Carton support to Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 14:48:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 12:48:53 +0000 Subject: [Koha-bugs] [Bug 8810] New: Opac: Cart should display branchname instead of branchcode Message-ID: <bug-8810-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8810 Priority: P5 - low Change sponsored?: --- Bug ID: 8810 Assignee: oleonard at myacpl.org Summary: Opac: Cart should display branchname instead of branchcode Severity: normal Classification: Unclassified OS: All Reporter: veron at veron.ch Hardware: All Status: NEW Version: master Component: OPAC Product: Koha Created attachment 12469 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12469&action=edit Opac cart displays branchcode In Opac, the cart should display the banchname instead of the branchcode (see screenshot). Reasons: - Branchcode is an internal key. Patrons dont necessarily know their meaning. - The name of the branch can change and the original meaning of the branchcode could be lost (that happened to us and we need a solution asap). Since branchcode is used as database key as well it would be very difficult to change it in all the tables. B.T.W. something similar was made with Bug 3292 (regarding serials) Patch follows. Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 14:51:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 12:51:22 +0000 Subject: [Koha-bugs] [Bug 8807] add Carton support to Koha In-Reply-To: <bug-8807-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8807-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8807-70-b1dL2CmbRb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8807 --- Comment #3 from Mason James <mtj at kohaaloha.com> --- (In reply to comment #2) > Created attachment 12468 [details] > Bug 8807 - add Carton support to Koha patch created from master (bd1f62137de) steps used to create patch... 1/ install cpanm, (2 methods) $ sudo cpan App::cpanminus or... $ curl -L http://cpanmin.us | perl - --sudo App::cpanminus 2/ install carton $ sudo cpanm carton 3/ install needed perl modules (and create a carton.lock file) $ cd koha.git $ carton install -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 14:54:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 12:54:09 +0000 Subject: [Koha-bugs] [Bug 8443] Suggestions : publication year and copyright date In-Reply-To: <bug-8443-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8443-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8443-70-7kY3cEaA9M@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8443 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #11 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- CONFLICT (content): Merge conflict in C4/Acquisition.pm Seems trivial. But please correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 15:03:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 13:03:10 +0000 Subject: [Koha-bugs] [Bug 8810] Opac: Cart should display branchname instead of branchcode In-Reply-To: <bug-8810-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8810-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8810-70-pJqpjLJNjq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8810 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 15:08:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 13:08:33 +0000 Subject: [Koha-bugs] [Bug 8810] Opac: Cart should display branchname instead of branchcode In-Reply-To: <bug-8810-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8810-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8810-70-r2xq8PylYW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8810 --- Comment #1 from Marc V?ron <veron at veron.ch> --- Created attachment 12470 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12470&action=edit Bug 8810 - Opac: Cart should display branchname instead of branchcode In Opac, the cart should display the branchname instead of the branchcode. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 15:11:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 13:11:27 +0000 Subject: [Koha-bugs] [Bug 8810] Opac: Cart should display branchname instead of branchcode In-Reply-To: <bug-8810-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8810-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8810-70-ornSz4b3Jc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8810 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 Status|NEW |Needs Signoff CC| |marc at msys.ch, | |veron at veron.ch --- Comment #2 from Marc V?ron <veron at veron.ch> --- Set to "Needs Signoff". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 15:22:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 13:22:52 +0000 Subject: [Koha-bugs] [Bug 7300] display suggestions from librarian library only by default In-Reply-To: <bug-7300-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7300-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7300-70-6fMIJtMuBY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7300 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to comment #8) > I am a bit worried about this too - I even think it should be a pref, > because workflows in libraries are different and there might well be a > situation where someone in a central place takes care of managing > suggestions. > I think we need at least a follow-up. Yes, definitely make this a system-preference controlled behavior. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 15:23:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 13:23:44 +0000 Subject: [Koha-bugs] [Bug 8810] Opac: Cart should display branchname instead of branchcode In-Reply-To: <bug-8810-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8810-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8810-70-6JbNj5g9IU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8810 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12470|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 12471 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12471&action=edit [SIGNED-OFF] Bug 8810 - Opac: Cart should display branchname instead of branchcode In Opac, the cart should display the branchname instead of the branchcode. Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 15:59:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 13:59:31 +0000 Subject: [Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries In-Reply-To: <bug-8137-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8137-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8137-70-jElBQyviuN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Koha Team Lyon 3 <koha at univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr --- Comment #7 from Koha Team Lyon 3 <koha at univ-lyon3.fr> --- The Circcontrol had to take into account the table default_borrower_circ_rules. This table is filled with values added in smart-rules.pl when selected libraries is "all libraries". I'm not sure that we have to check circcontrol here cause the limit is true for all the libraries so you don't matter if it's the library of patrons or items. In Circulation.pm, we can read : "maxissueqty - maximum number of loans that a patron of the given category can have at the given branch. If the value is undef, no limit. This will first check for a specific branch and category match from branch_borrower_circ_rules. If no rule is found, it will then check default_branch_circ_rules (same branch, default category). If no rule is found, it will then check default_borrower_circ_rules (default branch, same category), then failing that, default_circ_rules default branch, default category)." The problem is in "if no rule is found". I think the level defined for all libraries must win on the level for each library. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 16:08:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 14:08:02 +0000 Subject: [Koha-bugs] [Bug 8810] Opac: Cart should display branchname instead of branchcode In-Reply-To: <bug-8810-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8810-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8810-70-KvFmmGLuNE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8810 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 16:12:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 14:12:10 +0000 Subject: [Koha-bugs] [Bug 8811] New: can't run report after saving Message-ID: <bug-8811-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8811 Priority: P5 - low Change sponsored?: --- Bug ID: 8811 Assignee: gmcharlt at gmail.com Summary: can't run report after saving Severity: major Classification: Unclassified OS: All Reporter: nengard at gmail.com Hardware: All Status: NEW Version: master Component: Reports Product: Koha Created attachment 12472 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12472&action=edit run report after saving After saving a new report, the link to run this report is gone, but the button remains (which is good), however if you click the button to run report it brings you to a blank screen that just has the 'New' button on it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 16:15:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 14:15:18 +0000 Subject: [Koha-bugs] [Bug 8810] Opac: Cart should display branchname instead of branchcode In-Reply-To: <bug-8810-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8810-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8810-70-oxmvJxlygV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8810 --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 12473 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12473&action=edit [SIGNED-OFF] Bug 8810 - Opac: Cart should display branchname instead of branchcode In Opac, the cart should display the branchname instead of the branchcode. Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 16:15:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 14:15:43 +0000 Subject: [Koha-bugs] [Bug 8810] Opac: Cart should display branchname instead of branchcode In-Reply-To: <bug-8810-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8810-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8810-70-EUWEiTnouH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8810 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12473|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 16:17:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 14:17:57 +0000 Subject: [Koha-bugs] [Bug 8811] can't run report after saving In-Reply-To: <bug-8811-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8811-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8811-70-LnSrVXvhyV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8811 --- Comment #1 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 12474 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12474&action=edit run report in 3.8.4 The link was there in 3.8.4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 16:35:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 14:35:56 +0000 Subject: [Koha-bugs] [Bug 8810] Opac: Cart should display branchname instead of branchcode In-Reply-To: <bug-8810-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8810-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8810-70-87WuCkeEOB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8810 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12469|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 16:39:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 14:39:20 +0000 Subject: [Koha-bugs] [Bug 8811] can't run report after saving In-Reply-To: <bug-8811-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8811-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8811-70-QpsnEkBoop@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8811 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7993 --- Comment #2 from Nicole C. Engard <nengard at gmail.com> --- From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 16:39:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 14:39:20 +0000 Subject: [Koha-bugs] [Bug 7993] saved report with hierarchies In-Reply-To: <bug-7993-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7993-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7993-70-s6fUPbozB6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7993 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8811 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 16:52:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 14:52:52 +0000 Subject: [Koha-bugs] [Bug 8811] can't run report after saving In-Reply-To: <bug-8811-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8811-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8811-70-W2WuKVpa7V@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8811 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 16:52:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 14:52:53 +0000 Subject: [Koha-bugs] [Bug 8811] can't run report after saving In-Reply-To: <bug-8811-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8811-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8811-70-qc0UQOqu6I@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8811 --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 12475 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12475&action=edit Bug 8811 - can't run report after saving The fix for Bug 7993 removed some lines from guided_reports.pl which passed a new report's name and id to the template after saving. For some reason this was removed, making it impossible to run or edit a new report immediately after saving. This patch adds back that part of the script which passes those variables to the template. Before this patch, after adding a new SQL report you would not see a "run this report" link. The "run this report" and "edit" buttons in the toolbar would not work. After applying the patch these should work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 16:53:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 14:53:16 +0000 Subject: [Koha-bugs] [Bug 8811] can't run report after saving In-Reply-To: <bug-8811-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8811-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8811-70-tJwPXFSxLf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8811 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 16:58:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 14:58:58 +0000 Subject: [Koha-bugs] [Bug 8811] can't run report after saving In-Reply-To: <bug-8811-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8811-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8811-70-ilpgLTzAjU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8811 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12475|0 |1 is obsolete| | --- Comment #4 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 12476 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12476&action=edit [SIGNED-OFF] Bug 8811 - can't run report after saving The fix for Bug 7993 removed some lines from guided_reports.pl which passed a new report's name and id to the template after saving. For some reason this was removed, making it impossible to run or edit a new report immediately after saving. This patch adds back that part of the script which passes those variables to the template. Before this patch, after adding a new SQL report you would not see a "run this report" link. The "run this report" and "edit" buttons in the toolbar would not work. After applying the patch these should work. Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com> Tested creating reports and was able to run them after saving. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 16:59:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 14:59:11 +0000 Subject: [Koha-bugs] [Bug 8811] can't run report after saving In-Reply-To: <bug-8811-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8811-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8811-70-0HOA7shhMw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8811 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 16:59:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 14:59:41 +0000 Subject: [Koha-bugs] [Bug 8443] Suggestions : publication year and copyright date In-Reply-To: <bug-8443-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8443-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8443-70-p3xpvU3nWo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8443 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 17:11:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 15:11:55 +0000 Subject: [Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings In-Reply-To: <bug-7674-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7674-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7674-70-a6o7JwFz2e@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 --- Comment #10 from delaye <stephane.delaye at biblibre.com> --- i have this message when i want to test in a sandbox omething went wrong ! Applying: Bug 7674: Separate items in two tabs on biblio detail page (staff+opac) Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql Auto-merging installer/data/mysql/updatedatabase.pl Failed to merge in the changes. Patch failed at 0001 Bug 7674: Separate items in two tabs on biblio detail page (staff+opac) When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Bug 7674 - Separate tabs for my holdings and others holdings Bug 7674: Separate items in two tabs on biblio detail page (staff+opac) Apply? [yn] Patch left in /tmp/Bug-7674-Separate-items-in-two-tabs-on-biblio-deta-iPrfAr.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 17:14:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 15:14:25 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8798-70-pUzigbKSqv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 Elliott Davis <elliott at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12453|0 |1 is obsolete| | --- Comment #29 from Elliott Davis <elliott at bywatersolutions.com> --- Created attachment 12477 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12477&action=edit Added base class files for all tables in koha using the DBIx::Class::Schema::Loader Added a (very basic) test file for C4::Context Also added dependencies in required files. [Update]: changed dependencies fron dbic to dbix moved generation shell script to a perl script wtih arguments in misc/devel To Test: Install patch Make sure you can still connect to Koha you may optionally run the test script in comment 12 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798#c12 If you run this file you should get a DBIx dump of the borrowers table Done! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 17:40:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 15:40:20 +0000 Subject: [Koha-bugs] [Bug 8699] item creation or managmenent sometime crashes when easyanalyticalrecords is on In-Reply-To: <bug-8699-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8699-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8699-70-fbfX19pnRD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8699 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |fridolyn.somers at biblibre.co | |m Resolution|--- |DUPLICATE --- Comment #1 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> --- *** This bug has been marked as a duplicate of bug 8503 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 17:40:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 15:40:20 +0000 Subject: [Koha-bugs] [Bug 8503] Software error n edit items with EasyAnalyticalRecords In-Reply-To: <bug-8503-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8503-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8503-70-TMa2nMhx4Z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8503 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gaetan.boisson at biblibre.com --- Comment #8 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> --- *** Bug 8699 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 17:40:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 15:40:22 +0000 Subject: [Koha-bugs] [Bug 7986] Export issues In-Reply-To: <bug-7986-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7986-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7986-70-82WYILCR5y@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #38 from Nicole C. Engard <nengard at gmail.com> --- I'm trying to document this feature, but see no examples at all in this thread on what the preferences are looking for as values. Is it a comma separated list? If so, what does it look like? 100a, 245a or 100$a, 952$8 ?? Please provide me with an example so I can add these preferences to the manual. Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 17:47:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 15:47:24 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8236-70-BKyhasrn5S@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 --- Comment #14 from Koha Team Lyon 3 <koha at univ-lyon3.fr> --- (In reply to comment #13) > Patch does not apply, sorry: > > error: patch failed: > koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt:865 > error: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt: patch > does not apply > error: patch failed: koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt:247 > error: koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt: patch does not apply > > Regarding updatedatabase.pl: You can set the version to "XXXX", i.e.: > > $DBversion = "XXXX"; > > Marc Oh yes, I realize I 've made my tests on our test base which is a 3.8 version. I guess it's the reason why it doesn't apply. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 18:01:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 16:01:48 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8798-70-omtNE2ZXMl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 --- Comment #30 from Elliott Davis <elliott at bywatersolutions.com> --- Created attachment 12478 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12478&action=edit Added base class files for all tables in koha using the DBIx::Class::Schema::Loader Added a (very basic) test file for C4::Context Also added dependencies in required files. [Update]: changed dependencies fron dbic to dbix moved generation shell script to a perl script wtih arguments in misc/devel To Test: Install patch Make sure you can still connect to Koha you may optionally run the test script in comment 12 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798#c12 If you run this file you should get a DBIx dump of the borrowers table Done! Ammeded Dep version -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 18:06:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 16:06:40 +0000 Subject: [Koha-bugs] [Bug 8812] New: Staff Client: Patron search should display branch name instead of branch code in results table Message-ID: <bug-8812-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8812 Priority: P5 - low Change sponsored?: --- Bug ID: 8812 CC: gmcharlt at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: Staff Client: Patron search should display branch name instead of branch code in results table Severity: normal Classification: Unclassified OS: All Reporter: veron at veron.ch Hardware: All Status: NEW Version: master Component: Staff Client Product: Koha Result list in patron search should display branchname instead of branchcode. Similar reason as with Bug 8810: The name of the branch can change and the original meaning of the branchcode could be lost (that happened to us and we need a solution asap). Since branchcode is used as database key as well it would be very difficult to change it in all the tables. Patch follows. Marc -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 18:07:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 16:07:25 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8798-70-YQ2HnDZfXM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 Elliott Davis <elliott at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12477|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 18:19:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 16:19:20 +0000 Subject: [Koha-bugs] [Bug 8812] Staff Client: Patron search should display branch name instead of branch code in results table In-Reply-To: <bug-8812-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8812-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8812-70-Gyqepzad4G@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8812 --- Comment #1 from Marc V?ron <veron at veron.ch> --- Created attachment 12479 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12479&action=edit Bug 8812 - Staff Client: Patron search should display branch name instead of branch code in results table Patch to display branchname instead of branch code. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 18:21:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 16:21:37 +0000 Subject: [Koha-bugs] [Bug 8812] Staff Client: Patron search should display branch name instead of branch code in results table In-Reply-To: <bug-8812-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8812-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8812-70-KMUUrfkKMM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8812 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |marc at msys.ch Assignee|koha-bugs at lists.koha-commun |veron at veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 18:40:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 16:40:06 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8798-70-hEIe7gVW97@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 wajasu <matted-34813 at mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12478|0 |1 is obsolete| | --- Comment #31 from wajasu <matted-34813 at mypacks.net> --- Created attachment 12480 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12480&action=edit SIGNED-OFF-Added-base-class-files-for-all-tables-in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 19:03:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 17:03:25 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8798-70-H1j60OUwYt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 wajasu <matted-34813 at mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12443|0 |1 is obsolete| | --- Comment #32 from wajasu <matted-34813 at mypacks.net> --- Created attachment 12481 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12481&action=edit SIGNED-OFF-Bug-8798-Add-the-use-of-DBIx-Class-Rename Test: koha at biblio:~/kohaclone$ prove t/Context.t t/Context.t .. ok All tests successful. Files=1, Tests=1, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.78 cusr 0.10 csys = 0.90 CPU) Result: PASS koha at biblio:~/kohaclone$ ./koha_perl_deps.pl -m -u and didn't see libdbix-class-schema-loader mentioned, as its aligned with official debian squeeze version 7000-1 package. Note: This patch only really gets DBIx into the environment. The functionality of the dbicdump generated classes is not tested here, but this patch enables a more gradual rollout of DBIx functionality. It would be worth noting in a comment, what the exact command line that was used to generate the Koha::Schema. and what version of libdbix-class-schema-loader that was used to generate the source. FYI: Typically one would not check in generated source, but generate it at build time, but DBIx uses a hash of the content in the source to determine if it has been changed. Once someone changes it, the dbicdump won't overwrite it anymore in future runs, unless configured to. Note: Someone may want to address if we would like to apply the DateTime component, to get dates inflated, if that is something worth doing across the board. Also, someone mentioning a desire to use "Versioned" classes, probably for the use of database migrations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 19:03:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 17:03:47 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8798-70-sf9WEKd0UY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 wajasu <matted-34813 at mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 19:25:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 17:25:00 +0000 Subject: [Koha-bugs] [Bug 8726] Did you mean? plugin for broader/narrower/related terms In-Reply-To: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8726-70-nXWLxpLdkc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 --- Comment #21 from Paul Poulain <paul.poulain at biblibre.com> --- Created attachment 12482 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12482&action=edit OPAC screenshot Question: I'm testing this feature, and see the following results on my screen. Is it what I should expect ? ( Note i'm using the cssr theme ) QA comment: you remove the DidYouMeanFromAuthorities from the sysprefs.sql, shouldn't we remove it during updatedatabase also ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 19:28:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 17:28:12 +0000 Subject: [Koha-bugs] [Bug 8726] Did you mean? plugin for broader/narrower/related terms In-Reply-To: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8726-70-ekrrTkhaoM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 --- Comment #22 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Comment on attachment 12482 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12482 OPAC screenshot It looks like the CSS is missing for the opac.css in the ccsr theme. I will do a follow-up. Other than that, yes, that is correct. The DidYouMeanFromAuthorities should probably be taken out of updatedatabase.pl as well. Shall I let you do that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 19:32:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 17:32:04 +0000 Subject: [Koha-bugs] [Bug 8726] Did you mean? plugin for broader/narrower/related terms In-Reply-To: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8726-70-Qr1DGzgEX7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 --- Comment #23 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12483 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12483&action=edit Bug 8726: add CSS to CCSR theme -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 20:39:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 18:39:23 +0000 Subject: [Koha-bugs] [Bug 8813] New: issue slip lists items as overdue that are not overdue Message-ID: <bug-8813-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8813 Priority: P5 - low Change sponsored?: --- Bug ID: 8813 Assignee: koha-bugs at lists.koha-community.org Summary: issue slip lists items as overdue that are not overdue Severity: enhancement Classification: Unclassified OS: All Reporter: melia at bywatersolutions.com Hardware: All Status: NEW Version: rel_3_8 Component: Notices Product: Koha Issue slip looks like this: <font face="verdana"><h3><<branches.branchname>></h3> <<today>><br /> <h4>Checked Out</h4> <checkedout> <p> <<biblio.title>> <br /> Barcode: <<items.barcode>><br /> Date due: <<issues.date_due>><br /> </p> </checkedout> <h4>Overdues</h4> <overdue> <p> <<biblio.title>> <br /> Barcode: <<items.barcode>><br /> Date due: <<issues.date_due>><br /> </p> </overdue> etc The "Overdues" section lists items that have a date_due = today's date. So it's listing items that are not yet overdue. The items show up as due today in Koha (correct), but the printed issue slip lists them as overdue (incorrect). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 20:56:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 18:56:28 +0000 Subject: [Koha-bugs] [Bug 8797] can't delete quote of the day In-Reply-To: <bug-8797-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8797-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8797-70-7o4OXw9twA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8797 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #2 from Marc V?ron <veron at veron.ch> --- 1) Add a new quote using "Add quote" button. 2) Try to select it for deleting (click on ID) -> the line should turn dark gray to indicate that it is selected, but it does not. 3) Try to select an other, pre existing quote --> Line turns dark gray, quote is deletable. 4) Reload page. Now, the new quote from step 1) is selectable/deletable as well. Reproduced several times ond two Koha installations (3.09.00.030 and 3.09.00.056) If this behaviour can not be fixed, documentation should state that a reload of the page is necessary to be able to delete a new quote. Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 21:33:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 19:33:28 +0000 Subject: [Koha-bugs] [Bug 5356] Shipping billing address improvements In-Reply-To: <bug-5356-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5356-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5356-70-X1TroWFJZG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 --- Comment #34 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed. a small follow-up will be required in the display of layout3pages (screenshot attached) When the library description is long, it goes to far on the right. We should put things on 2 lines (and/or reduce the font size) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 21:34:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 19:34:11 +0000 Subject: [Koha-bugs] [Bug 5356] Shipping billing address improvements In-Reply-To: <bug-5356-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5356-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5356-70-v3PnVm3nEJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 --- Comment #35 from Paul Poulain <paul.poulain at biblibre.com> --- Created attachment 12484 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12484&action=edit Screenshot of library name too far on the right -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 21:45:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 19:45:53 +0000 Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix In-Reply-To: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5786-70-BmBYJBPxqx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 --- Comment #66 from Paul Poulain <paul.poulain at biblibre.com> --- (In reply to comment #65) > Hi Srdjan, it looks like Paul found a real problem with this - can you > confirm and maybe fix it? agreed ;-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 22:06:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 20:06:06 +0000 Subject: [Koha-bugs] [Bug 8796] patron cards not starting on designated card In-Reply-To: <bug-8796-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8796-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8796-70-DibPiztbak@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 --- Comment #1 from Marc V?ron <veron at veron.ch> --- Created attachment 12485 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12485&action=edit Starting labels on positions 2 and 7 (on the label sheet) It took quite a while until I figured out what happens - it is simply a misunderstanding: The label position means the position where the first label is positioned on the printout sheet (and not the index of the first label to print). Ah, and this said: It only affects PDF printing, not CSV or XML export. See screenshots of PDF printouts attached (same batch, starting at the 2nd and at the 7th position). Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 22:06:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 20:06:17 +0000 Subject: [Koha-bugs] [Bug 8766] OPACBaseURL still called as OPACBaseurl in many files In-Reply-To: <bug-8766-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8766-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8766-70-gpvhgnTZeS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8766 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 22:06:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 20:06:19 +0000 Subject: [Koha-bugs] [Bug 8766] OPACBaseURL still called as OPACBaseurl in many files In-Reply-To: <bug-8766-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8766-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8766-70-JceyCw0jZz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8766 --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 12486 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12486&action=edit Bug 8766 - OPACBaseURL still called as OPACBaseurl in many files This patch fixes incorrect capitalization of the OPACBaseURL variable in three templates. The fix can be confirmed in opac-results.tt by inspecting the link attached to the RSS icon on the OPAC's search results screen. The same fix is included in opac-opensearch.tt and search/results.tt but I'm not sure how you confirm that this change fixes anything, if it does. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 22:25:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 20:25:33 +0000 Subject: [Koha-bugs] [Bug 8796] patron cards not starting on designated card In-Reply-To: <bug-8796-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8796-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8796-70-ALKzU8CDpB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 --- Comment #2 from Marc V?ron <veron at veron.ch> --- Created attachment 12487 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12487&action=edit Bug 8796 - patron cards not starting on designated card Better wording for the meaning of 'Position' to prevent mistakes on behaviour. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 22:26:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 20:26:38 +0000 Subject: [Koha-bugs] [Bug 8796] patron cards not starting on designated card In-Reply-To: <bug-8796-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8796-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8796-70-uv2gw8Is6r@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |veron at veron.ch Assignee|cnighswonger at foundations.ed |veron at veron.ch |u | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 22:46:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 20:46:46 +0000 Subject: [Koha-bugs] [Bug 8379] Encoding problem under Plack In-Reply-To: <bug-8379-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8379-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8379-70-3t8mwDEbkD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8379 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #5 from Paul Poulain <paul.poulain at biblibre.com> --- OK, i've found where the problem comes from = $dbh connection is closed by marc_subfield_structure.pl, and that's where the problem comes from. attaching a patch that fixes the problem. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 22:47:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 20:47:54 +0000 Subject: [Koha-bugs] [Bug 8771] Something wrong with databse update 3.09.00.044 In-Reply-To: <bug-8771-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8771-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8771-70-yXD8COt7eh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8771 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |veron at veron.ch Resolution|--- |FIXED --- Comment #2 from Marc V?ron <veron at veron.ch> --- Katrin, I have this kind of errors if with columns I added before while developing. Searched through updatedatabase.pl, there is only one place where colum ccode is added to table statistics (while updating to version '3.09.00.044') I propose to set this bug to Resolved. Please reset it to NEW if you do not agree :-) Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 22:48:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 20:48:48 +0000 Subject: [Koha-bugs] [Bug 8379] Encoding problem under Plack In-Reply-To: <bug-8379-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8379-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8379-70-AuBUiJRONo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8379 --- Comment #6 from Paul Poulain <paul.poulain at biblibre.com> --- Created attachment 12488 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12488&action=edit Bug 8379 don't close dbh don't close the DBH handler, because under plack this cause a lot of problem and in CGI mode, closing the dbh handler is useless -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 22:50:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 20:50:04 +0000 Subject: [Koha-bugs] [Bug 8379] Encoding problem under Plack In-Reply-To: <bug-8379-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8379-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8379-70-Y3T7ur1uOW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8379 --- Comment #7 from Paul Poulain <paul.poulain at biblibre.com> --- OK, i've found where the problem comes from = $dbh connection is closed by marc_subfield_structure.pl, and that's where the problem comes from. attaching a patch that fixes the problem. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 22:52:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 20:52:11 +0000 Subject: [Koha-bugs] [Bug 8379] Encoding problem under Plack In-Reply-To: <bug-8379-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8379-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8379-70-OSYfhvxCFy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8379 --- Comment #8 from Paul Poulain <paul.poulain at biblibre.com> --- how to test: * define a library and/or an itemtype with a diacritic in the name * before the patch = if you search/edit a marc subfield structure, you'll get diacritic badly broken. and a "mysql has gone away" in plack logs * after the patch = no more problem -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 22:54:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 20:54:38 +0000 Subject: [Koha-bugs] [Bug 8770] amount does not equal amountoutstanding on a fine with no payments or credits In-Reply-To: <bug-8770-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8770-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8770-70-fkOZ4ynm6i@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8770 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 22:56:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 20:56:36 +0000 Subject: [Koha-bugs] [Bug 8379] Encoding problem under Plack In-Reply-To: <bug-8379-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8379-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8379-70-Nbp7liazZU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8379 --- Comment #9 from Paul Poulain <paul.poulain at biblibre.com> --- Created attachment 12489 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12489&action=edit Bug 8379 removing another useless ->disconnect line and s/tab/spaces/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 22:57:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 20:57:41 +0000 Subject: [Koha-bugs] [Bug 8379] Encoding problem under Plack In-Reply-To: <bug-8379-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8379-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8379-70-L9GaChd6iG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8379 --- Comment #10 from Paul Poulain <paul.poulain at biblibre.com> --- I've grepped for disconnect, and found another one. There's no more, except in some misc/cronjob scripts. Plack is not concerned by those, so no need to fix anything -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 22:57:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 20:57:57 +0000 Subject: [Koha-bugs] [Bug 8379] Encoding problem under Plack In-Reply-To: <bug-8379-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8379-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8379-70-9Y9hcFelcc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8379 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high Severity|enhancement |critical -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 23:15:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 21:15:18 +0000 Subject: [Koha-bugs] [Bug 8707] tags always say approved In-Reply-To: <bug-8707-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8707-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8707-70-6YapHDDIPR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8707 --- Comment #2 from Marc V?ron <veron at veron.ch> --- Comment on attachment 11901 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11901 rejected and approved all say approved Workaround I: Check checkboxes next tags you want to approve again and use the "Approve" button at the bottom of the table. Workaround II: On the line of a rejected tag, click the "Reject" button. Thsi will activate the "Approved" button. Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 23:15:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 21:15:29 +0000 Subject: [Koha-bugs] [Bug 8707] tags always say approved In-Reply-To: <bug-8707-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8707-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8707-70-yXNKo1FOlg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8707 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Sep 24 23:19:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 21:19:09 +0000 Subject: [Koha-bugs] [Bug 8707] tags always say approved In-Reply-To: <bug-8707-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8707-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8707-70-F3GIb67KaJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8707 --- Comment #3 from Marc V?ron <veron at veron.ch> --- ...but with Workaround II the "Approved" button becomes active, but it does nothing... Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 00:03:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 22:03:47 +0000 Subject: [Koha-bugs] [Bug 8707] tags always say approved In-Reply-To: <bug-8707-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8707-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8707-70-qJWqsUt2IT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8707 --- Comment #4 from Marc V?ron <veron at veron.ch> --- ...and some more findings: The button I mentioned in Comment #3 only _seems_ to do nothing. As soon I reload the page or apply the filter again the status is changed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 00:50:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 22:50:00 +0000 Subject: [Koha-bugs] [Bug 8721] typo in AllowItemsOnHoldCheckout In-Reply-To: <bug-8721-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8721-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8721-70-QJD8fJ9h6U@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8721 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Chris Cormack <chris at bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 01:11:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 23:11:31 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6679-70-QhtC2uPDr4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #195 from Mason James <mtj at kohaaloha.com> --- Created attachment 12490 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12490&action=edit Bug 6679 - Fixing code so it passes basic Perl:::Critic tests opac/opac-search.pl: "require" statement with library name as string at line 36, column 9. Use a bareword instead. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 01:16:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 23:16:48 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6679-70-xP8ztG0K2u@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12490|0 |1 is obsolete| | --- Comment #196 from Mason James <mtj at kohaaloha.com> --- Created attachment 12491 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12491&action=edit Bug 6679 - Fixing code so it passes basic Perl:::Critic tests opac/opac-search.pl: "require" statement with library name as string at line 36, column 9. Use a bareword instead. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 01:22:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 23:22:35 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6679-70-xxqLgtF2VY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #197 from Mason James <mtj at kohaaloha.com> --- Created attachment 12492 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12492&action=edit Bug 6679 - Fixing code so it passes basic Perl:::Critic tests opac/ilsdi.pl: Stricture disabled at line 217, column 17. See page 429 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 01:36:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 23:36:01 +0000 Subject: [Koha-bugs] [Bug 8733] Adding critic reviews to book pages In-Reply-To: <bug-8733-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8733-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8733-70-vGORiFAQUc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8733 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 01:36:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 24 Sep 2012 23:36:03 +0000 Subject: [Koha-bugs] [Bug 8733] Adding critic reviews to book pages In-Reply-To: <bug-8733-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8733-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8733-70-xjbiWtvwqw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8733 --- Comment #6 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12493 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12493&action=edit Bug 8733: Add IDreamBooks.com enhanced content Adds the following enhanced content to the OPAC, all controlled by separate sysprefs: 1) A "Readometer" which summarizes reviews on the OPAC detail page 2) A tab with snippets of critical reviews on the OPAC detail page 3) A computed rating on the results page To test: Find a book that is listed on IDreamBooks.com (you may have to make sure that you have the first edition), and one that is not. Try each of IDreamBooksReadometer, IDreamBooksReviews, and IDreamBooksResults sysprefs, taking note of the content appearing (or not) as appropriate. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 02:53:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 00:53:07 +0000 Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix In-Reply-To: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5786-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5786-70-0KNbVTC2P4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 Srdjan Jankovic <srdjan at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #67 from Srdjan Jankovic <srdjan at catalyst.net.nz> --- That did not happen to me: Server version: 5.5.24-0ubuntu0.12.04.1 (Ubuntu) mysql> SELECT opacitemholds,categorycode,itemtype,branchcode FROM issuingrules WHERE -> (issuingrules.categorycode = 'Adult' OR issuingrules.categorycode = '*') -> AND -> (issuingrules.itemtype = 'AGN' OR issuingrules.itemtype = '*') -> AND -> (issuingrules.branchcode = 'N' OR issuingrules.branchcode = '*') -> ORDER BY -> issuingrules.categorycode desc, -> issuingrules.itemtype desc, -> issuingrules.branchcode desc; +---------------+--------------+----------+------------+ | opacitemholds | categorycode | itemtype | branchcode | +---------------+--------------+----------+------------+ | 1 | * | AGN | N | | 1 | * | * | * | +---------------+--------------+----------+------------+ 2 rows in set (0.00 sec) On a general note, we should have a centralised rule picker. I remember writing one some years ago, but it seems to have been lost. On an even more general note, issuingrules table is just so wrong. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 03:23:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 01:23:07 +0000 Subject: [Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC In-Reply-To: <bug-4173-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4173-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4173-70-4B9te2iz9M@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #24 from Chris Cormack <chris at bigballofwax.co.nz> --- Pushed to 3.8.x will be in 3.8.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 03:57:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 01:57:45 +0000 Subject: [Koha-bugs] [Bug 8629] update of statistics fields on fund selection in order creation/edition In-Reply-To: <bug-8629-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8629-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8629-70-lzFUDIYMZB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8629 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris at bigballofwax.co.nz> --- Pushed to 3.8.x will be in 3.8.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 03:58:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 01:58:24 +0000 Subject: [Koha-bugs] [Bug 8764] Template change "Authors" to "Additional authors" in OPAC In-Reply-To: <bug-8764-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8764-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8764-70-cRM1e118Dp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8764 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris at bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 04:06:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 02:06:08 +0000 Subject: [Koha-bugs] [Bug 8617] Problem with display of comments waiting for moderation in OPAC In-Reply-To: <bug-8617-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8617-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8617-70-psuZpkRU9F@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8617 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris at bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 08:41:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 06:41:54 +0000 Subject: [Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings In-Reply-To: <bug-7674-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7674-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7674-70-VGOA7hUjKY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from Julian Maurice <julian.maurice at biblibre.com> --- Marking as Failed QA for comment 9. Owen, how can I get this "browse shelf" link appearing ? When I made this patch I didn't notice it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 09:18:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 07:18:57 +0000 Subject: [Koha-bugs] [Bug 8771] Something wrong with databse update 3.09.00.044 In-Reply-To: <bug-8771-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8771-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8771-70-ld2f25argq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8771 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I am quite sure I never tested this specific development... but if noone else runs into this, it must be something in my database. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 09:36:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 07:36:08 +0000 Subject: [Koha-bugs] [Bug 4177] opaccloud missing from the system preferences interface In-Reply-To: <bug-4177-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4177-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4177-70-NH98igepEe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4177 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #2 from Marc V?ron <veron at veron.ch> --- I find the following in prog\en\modules\admin\preferences\opac.pref: # - # This system preference does not actually affect anything # - pref: OpacBrowser # choices: # yes: Show # no: "Don't show" # - a subject browser on the OPAC (generated using <code>misc/cronjobs/build_browser_and_cloud.pl</code>). # - # opac-tags_subject.pl is the only script affected by this, and it is not linked to by any other page # - pref: OpacCloud # choices: # - If ON, enables subject cloud on OPAC At an other place, OpacBrowser is re-implemented, the appropriate lines can be deleted here. Regarding OpacCloud: If I activate the syspref (restoring missing choices) and set the preference to "ON", I get an additional menu item and text as follows: --------------- Subject cloud Note: This feature only available to French catalogs where ISBD subjects have been populated, and an index built by separate script. --------------- I find additional references to OpacCloud in: admin\systempreferences.pl installer\data\mysql\sysprefs.sql installer\data\mysql\update22to30.pl C4\Auth.pm koha-tmpl\opac-tmpl\ccsr\en\includes\masthead.inc Questions remain: Is that feature still functional? Dead code? To be removed? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 09:37:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 07:37:37 +0000 Subject: [Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings In-Reply-To: <bug-7674-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7674-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7674-70-kS1fUyaqar@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Julian, there are system preferences to control the shelf browser and your items need to have callnumbers. I hope there is no UNIMARC/MARC21 problem involved here. Hope that helps! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 09:47:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 07:47:03 +0000 Subject: [Koha-bugs] [Bug 8443] Suggestions : publication year and copyright date In-Reply-To: <bug-8443-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8443-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8443-70-8AvmLQXPt5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8443 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11759|0 |1 is obsolete| | --- Comment #12 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> --- Created attachment 12494 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12494&action=edit Proposed patch (rebased master) Rebased patch. Only a little conflict in a comment line in C4/Acquisition.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 09:48:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 07:48:59 +0000 Subject: [Koha-bugs] [Bug 8443] Suggestions : publication year and copyright date In-Reply-To: <bug-8443-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8443-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8443-70-ksmhR2Aih9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8443 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 10:30:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 08:30:32 +0000 Subject: [Koha-bugs] [Bug 8379] Encoding problem under Plack In-Reply-To: <bug-8379-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8379-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8379-70-zKhEIHtzTv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8379 --- Comment #11 from Dobrica Pavlinusic <dpavlin at rot13.org> --- Created attachment 12495 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12495&action=edit Bug 8379 removing another useless ->disconnect line and s/tab/spaces/ Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 10:31:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 08:31:07 +0000 Subject: [Koha-bugs] [Bug 8379] Encoding problem under Plack In-Reply-To: <bug-8379-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8379-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8379-70-kvKjKMQg5R@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8379 Dobrica Pavlinusic <dpavlin at rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12488|0 |1 is obsolete| | Attachment #12489|0 |1 is obsolete| | --- Comment #12 from Dobrica Pavlinusic <dpavlin at rot13.org> --- Created attachment 12496 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12496&action=edit Bug 8379 don't close dbh don't close the DBH handler, because under plack this cause a lot of problem and in CGI mode, closing the dbh handler is useless -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 10:32:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 08:32:35 +0000 Subject: [Koha-bugs] [Bug 8379] Encoding problem under Plack In-Reply-To: <bug-8379-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8379-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8379-70-vIdi2HKw5A@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8379 Dobrica Pavlinusic <dpavlin at rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #13 from Dobrica Pavlinusic <dpavlin at rot13.org> --- This is great news, good work Paul! I attached signed-off patches in reverse order, but it shouldn't matter because they are independent. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 10:33:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 08:33:35 +0000 Subject: [Koha-bugs] [Bug 8379] Encoding problem under Plack In-Reply-To: <bug-8379-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8379-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8379-70-JAAYsqIj5o@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8379 Dobrica Pavlinusic <dpavlin at rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12496|0 |1 is obsolete| | --- Comment #14 from Dobrica Pavlinusic <dpavlin at rot13.org> --- Created attachment 12497 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12497&action=edit Bug 8379 don't close dbh don't close the DBH handler, because under plack this cause a lot of problem and in CGI mode, closing the dbh handler is useless Signed-off-by: Dobrica Pavlinusic <dpavlin at rot13.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 11:08:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 09:08:12 +0000 Subject: [Koha-bugs] [Bug 4177] opaccloud missing from the system preferences interface In-Reply-To: <bug-4177-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4177-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4177-70-6bn6iGoe1z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4177 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko at abunchofthings.net --- Comment #3 from Mirko Tietgen <mirko at abunchofthings.net> --- I have been using the Opaccloud before, it needed some fiddling but worked. It's been a while ago, have not looked into using it with 3.8 yet but was planning on using this eventually. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 12:08:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 10:08:02 +0000 Subject: [Koha-bugs] [Bug 4177] opaccloud missing from the system preferences interface In-Reply-To: <bug-4177-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4177-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4177-70-WhJPo7h97y@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4177 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- We got it working in the past too - I am against removing it. I think keeping it out of the standard feature set (system preferences) is ok for now. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 12:45:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 10:45:41 +0000 Subject: [Koha-bugs] [Bug 8738] DateTime object being compared to a date string in circulation In-Reply-To: <bug-8738-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8738-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8738-70-9B2Dsx1bFl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8738 --- Comment #8 from MJ Ray (software.coop) <mjr at software.coop> --- For completeness, here's the correct error message when the analytic items enh isn't installed: Software error: A DateTime object can only be compared to another DateTime object (DateTime=HASH(0xa2d8aa8), 2012-08-31). at /usr/share/koha/intranet/cgi-bin/circ/circulation.pl line 464 I think the scenario is as follows: a. install a post-hourly-loans koha-common (3.8.4 was where I met it) on Ubuntu 10.04 LTS; b. circulate some books. And no, I don't think it's "backwards" to study the code and question how that ever doesn't error! Looking into that key question further, I found the changelog for DateTime.pm suggests only versions >= 0.54 allow comparing a DateTime to a string, but koha-common doesn't require any version (interestingly C4::Installer::PerlDependencies::PERL_DEPS says 0.58, so there's arguably a bug there) and Ubuntu 10.04 LTS (which is on at least two of the servers I've seen this bug on) only has version 0.52. So there are two obvious fixes: 1. apply this patch; 2. add a libdatetime-perl version requirement to koha-common which effectively excludes Ubuntu 10.04 Long Term Support from them, or would need us to provide packages for it. (This seems like an old chestnut - racing ahead with adoption of new versions of dependencies without considering what is actually available on stable server distributions - with a new twist, in that koha-common's version requirements don't match what's in C4::Installer::PerlDepenencies.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 12:48:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 10:48:03 +0000 Subject: [Koha-bugs] [Bug 8780] Lower dependency version for DateTime::TimeZone In-Reply-To: <bug-8780-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8780-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8780-70-LHyqY0dEOY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8780 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com --- Comment #4 from Mason James <mtj at kohaaloha.com> --- > SIGNED-OFF-Bug-8780-Lower-dependency-version-for-DateTime-TimeZone based on the info from Colin and wajasu, im happy to pass QA on this nice spotting Mark :) $ koha-qa.pl -c 1 testing 1 commit(s) (applied to commit bd1f621) * 926840c Bug 8780 - Lower dependency version for DateTime::TimeZone C4/Installer/PerlDependencies.pm * C4/Installer/PerlDependencies.pm OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 12:48:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 10:48:17 +0000 Subject: [Koha-bugs] [Bug 8780] Lower dependency version for DateTime::TimeZone In-Reply-To: <bug-8780-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8780-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8780-70-r4Ron25ee6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8780 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 12:48:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 10:48:29 +0000 Subject: [Koha-bugs] [Bug 8780] Lower dependency version for DateTime::TimeZone In-Reply-To: <bug-8780-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8780-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8780-70-st7RslvCub@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8780 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 13:17:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 11:17:09 +0000 Subject: [Koha-bugs] [Bug 8702] System preferences search does not allow accented letters In-Reply-To: <bug-8702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8702-70-oI6JLTJuAn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8702 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com QA Contact| |mtj at kohaaloha.com --- Comment #8 from Mason James <mtj at kohaaloha.com> --- (In reply to comment #7) > Created attachment 12324 [details] > SIGNED-OFF-Bug-8702-System-preferences-search-accented-sysprefs patch looks good, passing QA? $ koha-qa.pl -c 1 testing 1 commit(s) (applied to commit bd1f621) * 30c1031 Bug 8702: System preferences search does not allow accented letters admin/preferences.pl koha-tmpl/intranet-tmpl/prog/en/includes/prefs-admin-search.inc koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt * admin/preferences.pl OK * koha-tmpl/intranet-tmpl/prog/en/includes/prefs-admin-search.inc OK * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 13:21:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 11:21:11 +0000 Subject: [Koha-bugs] [Bug 7643] Can't upload and import zipped file of patron images In-Reply-To: <bug-7643-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7643-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7643-70-MD8v3MDG14@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7643 Ivan Brown <I.Brown at littleover.derby.sch.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |I.Brown at littleover.derby.sc | |h.uk --- Comment #5 from Ivan Brown <I.Brown at littleover.derby.sch.uk> --- I think I have managed to fix this. In the new code: my $filesuffix; if ( $uploadfilename =~ m/(\..+)$/i ) { my $filesuffix = $1; } $filesuffix is being declared as local (with my) twice. If the second my is deleted, the upload works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 13:40:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 11:40:56 +0000 Subject: [Koha-bugs] [Bug 8814] New: tag cloud not showing different sizes Message-ID: <bug-8814-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8814 Priority: P5 - low Change sponsored?: --- Bug ID: 8814 Assignee: oleonard at myacpl.org Summary: tag cloud not showing different sizes Severity: major Classification: Unclassified OS: All Reporter: nengard at gmail.com Hardware: All Status: NEW Version: master Component: Templates Product: Koha Created attachment 12498 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12498&action=edit tag cloud 3.8.5 When you look at the tag cloud in master and 3.8.5 the tags are all the same size regardless of how often they're used. In 3.6 they were sized based on how often they were used. I'm using FF and Chrome on Mac if that matters. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 13:41:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 11:41:12 +0000 Subject: [Koha-bugs] [Bug 8814] tag cloud not showing different sizes In-Reply-To: <bug-8814-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8814-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8814-70-T6cmWgsCsw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8814 --- Comment #1 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 12499 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12499&action=edit tag cloud master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 13:43:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 11:43:36 +0000 Subject: [Koha-bugs] [Bug 8815] New: my tags not showing my tags Message-ID: <bug-8815-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8815 Priority: P5 - low Change sponsored?: --- Bug ID: 8815 Assignee: gmcharlt at gmail.com Summary: my tags not showing my tags Severity: major Classification: Unclassified OS: All Reporter: nengard at gmail.com Hardware: All Status: NEW Version: rel_3_8 Component: Tools Product: Koha Created attachment 12500 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12500&action=edit tag cloud When I look at the My Tags tab in 3.8.4 and .5 I only see one tag in the cloud, but more in my list of tags and there are 28 approved tags in the system. It does work properly in master though. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 13:45:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 11:45:05 +0000 Subject: [Koha-bugs] [Bug 8814] tag cloud not showing different sizes In-Reply-To: <bug-8814-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8814-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8814-70-tPORAa4zKO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8814 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- This is a side effect of bug 7642 - there is a patch waiting to be pushed that hopefully fixes it. *** This bug has been marked as a duplicate of bug 7642 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 13:45:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 11:45:05 +0000 Subject: [Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag In-Reply-To: <bug-7642-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7642-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7642-70-s79p3J59Zq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 --- Comment #34 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 8814 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 13:49:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 11:49:07 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8798-70-JsYDxM08as@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |mtj at kohaaloha.com --- Comment #33 from Mason James <mtj at kohaaloha.com> --- (In reply to comment #31) > Created attachment 12480 [details] > SIGNED-OFF-Added-base-class-files-for-all-tables-in failing this patch for new TAB chars in... C4/Context.pm C4/Installer/PerlDependencies.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 13:57:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 11:57:04 +0000 Subject: [Koha-bugs] [Bug 8733] Adding critic reviews to book pages In-Reply-To: <bug-8733-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8733-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8733-70-AxkwTYotDR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8733 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12493|0 |1 is obsolete| | --- Comment #7 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12501 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12501&action=edit Bug 8733: Add IDreamBooks.com enhanced content Adds the following enhanced content to the OPAC, all controlled by separate sysprefs: 1) A "Readometer" which summarizes reviews on the OPAC detail page 2) A tab with snippets of critical reviews on the OPAC detail page 3) A computed rating on the results page To test: Find a book that is listed on IDreamBooks.com (you may have to make sure that you have the first edition), and one that is not. Try each of IDreamBooksReadometer, IDreamBooksReviews, and IDreamBooksResults sysprefs, taking note of the content appearing (or not) as appropriate. Updated to add missing CSS to new theme. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 14:01:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 12:01:39 +0000 Subject: [Koha-bugs] [Bug 8816] New: add WARNING to debian/control file, to not manually edit Message-ID: <bug-8816-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8816 Priority: P5 - low Change sponsored?: --- Bug ID: 8816 CC: robin at catalyst.net.nz Assignee: koha-bugs at lists.koha-community.org Summary: add WARNING to debian/control file, to not manually edit Severity: normal Classification: Unclassified OS: All Reporter: mtj at kohaaloha.com Hardware: All Status: NEW Version: master Component: Packaging Product: Koha many people manually edit the debian/control file, not realising that it is auto-generated, (and their changes will be lost) a warning message in the file, would stop people making this mistake -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 14:02:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 12:02:46 +0000 Subject: [Koha-bugs] [Bug 4809] Lost & Paid For doesn't record payment In-Reply-To: <bug-4809-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4809-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4809-70-eWR4JXeVps@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4809 --- Comment #4 from Nicole C. Engard <nengard at gmail.com> --- This is still an issue in 3.8.x -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 14:04:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 12:04:38 +0000 Subject: [Koha-bugs] [Bug 7643] Can't upload and import zipped file of patron images In-Reply-To: <bug-7643-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7643-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7643-70-igdEabTGPI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7643 --- Comment #6 from Chris Nighswonger <cnighswonger at foundations.edu> --- (In reply to comment #5) > I think I have managed to fix this. > > In the new code: > > my $filesuffix; > if ( $uploadfilename =~ m/(\..+)$/i ) { > my $filesuffix = $1; > } > > $filesuffix is being declared as local (with my) twice. > > If the second my is deleted, the upload works. Good catch indeed! And here is the commit which broke it: http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=b5b71339f3e3dfd639609ecc4b6912435d29704b Maybe you would consider submitting a patch to fix this bug? In return, you'll get your name added to the list of those who make Koha what it is. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 14:06:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 12:06:31 +0000 Subject: [Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries In-Reply-To: <bug-8137-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8137-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8137-70-yjrYMd1AZ5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Koha Team Lyon 3 <koha at univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8371 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 14:06:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 12:06:31 +0000 Subject: [Koha-bugs] [Bug 8371] Add network level issuing rules In-Reply-To: <bug-8371-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8371-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8371-70-e2aWftB2Dl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8371 Koha Team Lyon 3 <koha at univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8137 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 14:16:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 12:16:01 +0000 Subject: [Koha-bugs] [Bug 8817] New: omnibus bug for warning messages Message-ID: <bug-8817-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8817 Priority: P5 - low Change sponsored?: --- Bug ID: 8817 Assignee: gmcharlt at gmail.com Summary: omnibus bug for warning messages Severity: normal Classification: Unclassified OS: All Reporter: mtj at kohaaloha.com Hardware: All Status: NEW Version: master Component: Architecture, internals, and plumbing Product: Koha an omnibus bug, to link bugs related to warning messages in logs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 14:34:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 12:34:04 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: <bug-6473-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6473-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6473-70-rEqVDiEMEa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #53 from Mason James <mtj at kohaaloha.com> --- Created attachment 12502 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12502&action=edit modified: git-bz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 14:49:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 12:49:55 +0000 Subject: [Koha-bugs] [Bug 8371] Add network level issuing rules In-Reply-To: <bug-8371-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8371-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8371-70-qECcJfuEv8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8371 Koha Team Lyon 3 <koha at univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 15:59:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 13:59:56 +0000 Subject: [Koha-bugs] [Bug 8366] Meaning of "All" in issuing rules In-Reply-To: <bug-8366-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8366-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8366-70-PkkjDvTx1M@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8366 Koha Team Lyon 3 <koha at univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr --- Comment #10 from Koha Team Lyon 3 <koha at univ-lyon3.fr> --- I'm not sure of the rule for itemtypes : I test in issuingrules : categorycode itemtype maxissueqty ETUL3 * 10 ETUL3 DVD 2 ETUL3 EXC 0 ETUL3 PRET 10 ETUL3 PRET3J 2 with this parameters, an ETUL3 Patron can check out 10 PRET + 2 DVD + 2 PRET3J : a total of 14 items. The line ETUL3 * 10 doesn't match. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 16:05:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 14:05:21 +0000 Subject: [Koha-bugs] [Bug 8818] New: Authority linker error on Z cataloging Message-ID: <bug-8818-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8818 Priority: P5 - low Change sponsored?: --- Bug ID: 8818 CC: jcamins at cpbibliography.com, m.de.rooy at rijksmuseum.nl Assignee: gmcharlt at gmail.com Summary: Authority linker error on Z cataloging Severity: critical Classification: Unclassified OS: All Reporter: nengard at gmail.com Hardware: All Status: NEW Version: master Component: Cataloging Product: Koha I was cataloging a new book today. I followed these steps: 1. Z39 search of LOC 2. Choose title 3. Add summary 520 4. Add url 856 5. Choose authority for author 100 6. Hit save I got this error: Software error: Can't locate object method "new" via package "C4::Linker::FirstMatch" (perhaps you forgot to load "C4::Linker::FirstMatch"?) at /home/nengard/kohaclone/C4/Biblio.pm line 503. For help, please send mail to the webmaster (webmaster at debian), giving this error message and the time and date of the error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 16:07:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 14:07:29 +0000 Subject: [Koha-bugs] [Bug 8818] Authority linker error on Z cataloging In-Reply-To: <bug-8818-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8818-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8818-70-PZzKIjPZC1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8818 --- Comment #1 from Nicole C. Engard <nengard at gmail.com> --- I tried again skipping steps 3-5 and still get the same error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 16:09:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 14:09:12 +0000 Subject: [Koha-bugs] [Bug 8818] Authority linker error on Z cataloging In-Reply-To: <bug-8818-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8818-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8818-70-T4exnajq0f@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8818 --- Comment #2 from Nicole C. Engard <nengard at gmail.com> --- Finally I changed my linker settings and just got a different error: Software error: Can't locate object method "new" via package "C4::Linker::Default" (perhaps you forgot to load "C4::Linker::Default"?) at /home/nengard/kohaclone/C4/Biblio.pm line 503. For help, please send mail to the webmaster (webmaster at debian), giving this error message and the time and date of the error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 17:16:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 15:16:50 +0000 Subject: [Koha-bugs] [Bug 7643] Can't upload and import zipped file of patron images In-Reply-To: <bug-7643-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7643-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7643-70-u65ZwJjYDF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7643 --- Comment #7 from Ivan Brown <I.Brown at littleover.derby.sch.uk> --- Created attachment 12503 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12503&action=edit proposed patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 17:46:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 15:46:39 +0000 Subject: [Koha-bugs] [Bug 7643] Can't upload and import zipped file of patron images In-Reply-To: <bug-7643-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7643-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7643-70-kSGEh2T3nt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7643 Chris Nighswonger <cnighswonger at foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #8 from Chris Nighswonger <cnighswonger at foundations.edu> --- Updating status -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 17:47:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 15:47:14 +0000 Subject: [Koha-bugs] [Bug 7643] Can't upload and import zipped file of patron images In-Reply-To: <bug-7643-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7643-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7643-70-Ijejsg57Ij@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7643 Chris Nighswonger <cnighswonger at foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger at foundations.ed |I.Brown at littleover.derby.sc |u |h.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 17:51:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 15:51:52 +0000 Subject: [Koha-bugs] [Bug 7412] Pre-filling items in cataloguing In-Reply-To: <bug-7412-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7412-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7412-70-3QA06gSHcV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 --- Comment #34 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 12504 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12504&action=edit Bug 7412: Follow up: Update preference to sentence This patch updates the preference question to a sentence to follow the standard set with previous preferences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 17:52:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 15:52:20 +0000 Subject: [Koha-bugs] [Bug 7412] Pre-filling items in cataloguing In-Reply-To: <bug-7412-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7412-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7412-70-Ov6SagBsDb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED --- Comment #35 from Nicole C. Engard <nengard at gmail.com> --- I have submitted a follow up to fix the preference to be a sentence like other preferences. Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 17:52:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 15:52:34 +0000 Subject: [Koha-bugs] [Bug 7412] Pre-filling items in cataloguing In-Reply-To: <bug-7412-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7412-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7412-70-PCSMEKJPMf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #36 from Nicole C. Engard <nengard at gmail.com> --- Follow up needs sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 19:55:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 17:55:27 +0000 Subject: [Koha-bugs] [Bug 8819] New: enter claim date manually Message-ID: <bug-8819-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8819 Priority: P5 - low Change sponsored?: --- Bug ID: 8819 Assignee: koha-bugs at lists.koha-community.org Summary: enter claim date manually Severity: enhancement Classification: Unclassified OS: All Reporter: nengard at gmail.com URL: cgi-bin/koha/serials/claims.pl Hardware: All Status: NEW Version: master Component: Acquisitions Product: Koha It would be nice if on the claims form for serials you could manually mark something claimed or enter a claim date. Most US vendors do not want an email as a claim, they have special web forms to fill out, but that doesn't mean that the library doesn't want to track when they claimed their issue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 20:23:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 18:23:38 +0000 Subject: [Koha-bugs] [Bug 8820] New: Don't show orders table if there are no orders Message-ID: <bug-8820-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8820 Priority: P5 - low Change sponsored?: --- Bug ID: 8820 Assignee: oleonard at myacpl.org Summary: Don't show orders table if there are no orders Severity: minor Classification: Unclassified OS: All Reporter: oleonard at myacpl.org Hardware: All Status: ASSIGNED Version: master Component: Acquisitions Product: Koha Rather than show the "Order Details" heading and a "Basket empty" message it would be simpler to hide the table altogether so that the focus could move to the "Add order to basket" form. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 20:34:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 18:34:22 +0000 Subject: [Koha-bugs] [Bug 8820] Don't show orders table if there are no orders In-Reply-To: <bug-8820-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8820-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8820-70-TksxR1OPvo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8820 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 20:34:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 18:34:24 +0000 Subject: [Koha-bugs] [Bug 8820] Don't show orders table if there are no orders In-Reply-To: <bug-8820-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8820-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8820-70-iKiRUGOoQt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8820 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 12505 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12505&action=edit Bug 8820 - Don't show orders table if there are no orders This page removes the "basket empty" message in favor of hiding the orders table altogether when a basket has no orders. This patch also moves the "Show all details" checkbox under the "Orders" heading to associate it more closely with the area it affects. Other textual changes: - Correcting capitalization according to coding guidelines - Correcting terminology (basket group instead of basketgroup) - Replacing the "Order Details" heading with the more succinct "Orders" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 20:37:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 18:37:50 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8798-70-anbdmJCsbR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 --- Comment #34 from Elliott Davis <elliott at bywatersolutions.com> --- Created attachment 12506 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12506&action=edit [Follow-up] Updated to remove tabs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 20:38:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 18:38:09 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8798-70-QWDg9cYVe1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 Elliott Davis <elliott at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 21:24:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 19:24:27 +0000 Subject: [Koha-bugs] [Bug 8821] New: Receive shipment page should hide inactive funds like new order form does Message-ID: <bug-8821-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8821 Priority: P5 - low Change sponsored?: --- Bug ID: 8821 Assignee: oleonard at myacpl.org Summary: Receive shipment page should hide inactive funds like new order form does Severity: normal Classification: Unclassified OS: All Reporter: oleonard at myacpl.org Hardware: All Status: ASSIGNED Version: master Component: Acquisitions Product: Koha When adding an order the option to select a fund is limited to active funds, with the option to show inactive ones. The receive shipment form has a similar option to choose a fund. It should be consistent with the other page, with the same default and options. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 21:32:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 19:32:36 +0000 Subject: [Koha-bugs] [Bug 5327] Omnibus for unit tests required for all C4 modules In-Reply-To: <bug-5327-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5327-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5327-70-fNVzF9IpxE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Unit tests required for all |Omnibus for unit tests |C4 modules |required for all C4 modules Severity|major |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 21:48:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 19:48:47 +0000 Subject: [Koha-bugs] [Bug 8821] Receive shipment page should hide inactive funds like new order form does In-Reply-To: <bug-8821-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8821-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8821-70-LyhqIwu3tf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8821 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 21:48:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 19:48:49 +0000 Subject: [Koha-bugs] [Bug 8821] Receive shipment page should hide inactive funds like new order form does In-Reply-To: <bug-8821-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8821-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8821-70-KdE584KX6i@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8821 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 12507 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12507&action=edit Bug 8821 - Receive shipment page should hide inactive funds like new order form This patch adapts the fund-handling code from neworderempty.pl in order to limit the display of funds by default to active ones, with the option to check a box to display all funds. To test, make sure you have both active and inactive funds. Start the process of receiving a shipment. The "fund" option in the receive shipment form should show only active funds. Checking the "show all" checkbox should allow you to choose from both active and inactive funds. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Sep 25 21:53:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 19:53:24 +0000 Subject: [Koha-bugs] [Bug 8822] New: public calendar Message-ID: <bug-8822-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8822 Priority: P5 - low Change sponsored?: --- Bug ID: 8822 Assignee: gmcharlt at gmail.com Summary: public calendar Severity: enhancement Classification: Unclassified OS: All Reporter: nengard at gmail.com Hardware: All Status: NEW Version: master Component: Tools Product: Koha It would be nice to have a way to make holidays (and hours eventually) on the calendar public. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 00:11:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 22:11:17 +0000 Subject: [Koha-bugs] [Bug 8770] amount does not equal amountoutstanding on a fine with no payments or credits In-Reply-To: <bug-8770-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8770-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8770-70-XieS9ADVLm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8770 --- Comment #7 from Jesse Maseto <jesse at bywatersolutions.com> --- Created attachment 12508 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12508&action=edit Fine error 1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 00:13:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 22:13:19 +0000 Subject: [Koha-bugs] [Bug 8770] amount does not equal amountoutstanding on a fine with no payments or credits In-Reply-To: <bug-8770-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8770-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8770-70-eT7aaxtwnl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8770 --- Comment #8 from Jesse Maseto <jesse at bywatersolutions.com> --- Created attachment 12509 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12509&action=edit fine error 2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 00:20:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 22:20:39 +0000 Subject: [Koha-bugs] [Bug 8770] amount does not equal amountoutstanding on a fine with no payments or credits In-Reply-To: <bug-8770-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8770-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8770-70-5qiDzrMcBd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8770 Jesse Maseto <jesse at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12508|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 00:20:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 22:20:52 +0000 Subject: [Koha-bugs] [Bug 8770] amount does not equal amountoutstanding on a fine with no payments or credits In-Reply-To: <bug-8770-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8770-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8770-70-IWGFkYCEOR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8770 Jesse Maseto <jesse at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12509|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 01:05:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 23:05:21 +0000 Subject: [Koha-bugs] [Bug 8823] New: CatalogModuleRelink Creates Multiple Links between Bib and Auth record ($9 RLIN) Message-ID: <bug-8823-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8823 Priority: P5 - low Change sponsored?: --- Bug ID: 8823 CC: m.de.rooy at rijksmuseum.nl Assignee: gmcharlt at gmail.com Summary: CatalogModuleRelink Creates Multiple Links between Bib and Auth record ($9 RLIN) Severity: normal Classification: Unclassified OS: All Reporter: joy at bywatersolutions.com Hardware: All Status: NEW Version: rel_3_8 Component: Cataloging Product: Koha Created attachment 12510 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12510&action=edit Screenshot of edit screen Following system preferences are set in Authorities tab: AutoCreateAuthorities --GENERATE BiblioAddsAuthorities --ALLOW dontmerge --DO UseAuthoritiesForTracings --DON'T Linker CatalogModuleRelink --DO LinkerKeepStale --DON'T LinkerModule --First Match LinkerOptions <blank> LinkerRelink --DO When editing a bibliographic record, (editing anything) Koha relinks the bib record to a machine generated auth record and retains the previous link. So, multiple $9 fields are created for every tag that links to an authority record. Part of MARCxml in biblioitems <datafield tag="100" ind1=" " ind2=" "> <subfield code="a">Einstein, Albert</subfield> <subfield code="d">1800-2010</subfield> <subfield code="9">260394</subfield> <subfield code="c">Numero Uno</subfield> <subfield code="9">260395</subfield> <subfield code="9">260399</subfield> <subfield code="9">260403</subfield> <subfield code="9">260407</subfield> <subfield code="9">260411</subfield> <subfield code="9">260415</subfield> </datafield> <datafield tag="650" ind1=" " ind2="0"> <subfield code="a">Relativity (Physics)</subfield> <subfield code="9">253848</subfield> <subfield code="9">260396</subfield> <subfield code="9">260400</subfield> <subfield code="9">260404</subfield> <subfield code="9">260408</subfield> <subfield code="9">260412</subfield> <subfield code="9">260416</subfield> </datafield> <datafield tag="700" ind1="1" ind2=" "> <subfield code="9">195045</subfield> <subfield code="a">Einstein, Albert,</subfield> <subfield code="d">1879-1955.</subfield> <subfield code="9">260397</subfield> <subfield code="9">260401</subfield> <subfield code="9">260405</subfield> <subfield code="9">260409</subfield> <subfield code="9">260413</subfield> <subfield code="9">260417</subfield> </datafield> <datafield tag="830" ind1=" " ind2="0"> <subfield code="a">Bonanza paperback.</subfield> <subfield code="9">253849</subfield> <subfield code="9">260398</subfield> <subfield code="9">260402</subfield> <subfield code="9">260406</subfield> <subfield code="9">260410</subfield> <subfield code="9">260414</subfield> <subfield code="9">260418</subfield> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 01:41:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 23:41:07 +0000 Subject: [Koha-bugs] [Bug 8818] Authority linker error on Z cataloging In-Reply-To: <bug-8818-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8818-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8818-70-U47SE7qMnF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8818 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 01:41:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 23:41:09 +0000 Subject: [Koha-bugs] [Bug 8818] Authority linker error on Z cataloging In-Reply-To: <bug-8818-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8818-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8818-70-QZVOIiFUlP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8818 --- Comment #3 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12511 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12511&action=edit Bug 8818: make sure we load modules before using them An eval { eval "require $module;" }; was replaced with eval { eval { require $module; }; }; which is a no-op, meaning that the linker was not getting loaded, and the catalog module was throwing up a big nasty error every time someone tried to save a record with a heading. This patch replaces the require with can_load from Module::Load::Conditional, which is PBP-friendly, and offers equivalent functionality. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 01:50:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 25 Sep 2012 23:50:14 +0000 Subject: [Koha-bugs] [Bug 8823] CatalogModuleRelink Creates Multiple Links between Bib and Auth record ($9 RLIN) In-Reply-To: <bug-8823-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8823-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8823-70-gqIIFOwlxT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8823 --- Comment #1 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Could you please provide a test plan for replicating this problem? I have my settings exactly the same as yours, and can edit and save to my heart's content without any extra $9s showing up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 02:29:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 00:29:42 +0000 Subject: [Koha-bugs] [Bug 8818] Authority linker error on Z cataloging In-Reply-To: <bug-8818-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8818-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8818-70-vISFWNANIE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8818 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12511|0 |1 is obsolete| | --- Comment #4 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 12512 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12512&action=edit [SIGNED-OFF] Bug 8818: make sure we load modules before using them An eval { eval "require $module;" }; was replaced with eval { eval { require $module; }; }; which is a no-op, meaning that the linker was not getting loaded, and the catalog module was throwing up a big nasty error every time someone tried to save a record with a heading. This patch replaces the require with can_load from Module::Load::Conditional, which is PBP-friendly, and offers equivalent functionality. Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 02:30:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 00:30:19 +0000 Subject: [Koha-bugs] [Bug 8818] Authority linker error on Z cataloging In-Reply-To: <bug-8818-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8818-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8818-70-1UidHHLFa5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8818 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 05:11:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 03:11:08 +0000 Subject: [Koha-bugs] [Bug 8824] New: use of windows 7, Firefox V15 and wireless level dns 10.58.2.X versus wired 192.168.x.x Message-ID: <bug-8824-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8824 Priority: P5 - low Change sponsored?: --- Bug ID: 8824 Assignee: oleonard at myacpl.org Summary: use of windows 7, Firefox V15 and wireless level dns 10.58.2.X versus wired 192.168.x.x Severity: enhancement Classification: Unclassified OS: All Reporter: hdowns at berkshire.rr.com Hardware: All Status: NEW Version: unspecified Component: Browser compatibility Product: Koha - Installing a new Windows PC, professional version at the Lanesborough MA library ran into an issue discussed on the IRC today 09/25/12. I could not connect on a wired solution but only on a wireless level of ip addressing aforementioned. Only after I disabled the wired level on 192.168.x.x, which I was able to connect to the Koha library at mass-cat site, I was able then to connect through either Firefox or Internet Explorer. This was issue both in Firefox and also Internet Explorer. Every other random site searched and browsed allowed full use. Other base info is that I installed Norton 360 on this PC, same security software on xp pc workstations and no problem for access there. I was able to ping the library catalog database from the cmd per IRC support chat. I did also make sure to allow the Firefox software app instead of leaving on auto, but that did not seem to matter. Any help or suggestions would be greatly appreciated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 07:16:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 05:16:50 +0000 Subject: [Koha-bugs] [Bug 8825] New: Need an interface to see items received in acquisition module Message-ID: <bug-8825-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8825 Priority: P5 - low Change sponsored?: --- Bug ID: 8825 Assignee: koha-bugs at lists.koha-community.org Summary: Need an interface to see items received in acquisition module Severity: enhancement Classification: Unclassified OS: All Reporter: vimal0212 at gmail.com Hardware: All Status: NEW Version: rel_3_10 Component: Acquisitions Product: Koha In default cataloguer have to search and find books received in acquisition module. Need an interface to see items received in acquisition module. It is helpful for librarians to see the list of items pushed from acquisition for cataloging section -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 09:42:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 07:42:31 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: <bug-6473-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6473-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6473-70-PsvHE1Uyh1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #54 from Mason James <mtj at kohaaloha.com> --- Created attachment 12513 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12513&action=edit git bz test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 09:46:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 07:46:24 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: <bug-6473-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6473-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6473-70-EUersBRFz4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #55 from Mason James <mtj at kohaaloha.com> --- Created attachment 12514 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12514&action=edit git bz test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 09:50:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 07:50:54 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: <bug-6473-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6473-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6473-70-K1BxFTUT93@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #56 from Mason James <mtj at kohaaloha.com> --- Created attachment 12515 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12515&action=edit git bz test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 09:51:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 07:51:21 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: <bug-6473-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6473-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6473-70-gF1HqtvfdN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #57 from Mason James <mtj at kohaaloha.com> --- Created attachment 12516 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12516&action=edit git bz test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 09:52:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 07:52:37 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: <bug-6473-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6473-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6473-70-WFOpwLQ4nZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #58 from Mason James <mtj at kohaaloha.com> --- Created attachment 12517 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12517&action=edit git bz test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 09:53:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 07:53:01 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: <bug-6473-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6473-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6473-70-YC4LF547bU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #59 from Mason James <mtj at kohaaloha.com> --- Created attachment 12518 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12518&action=edit git bz test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 09:54:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 07:54:24 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: <bug-6473-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6473-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6473-70-6eV270O2A4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #60 from Mason James <mtj at kohaaloha.com> --- Created attachment 12519 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12519&action=edit git bz test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 10:40:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 08:40:43 +0000 Subject: [Koha-bugs] [Bug 8826] New: Initialization of hash triggers error log entries. Message-ID: <bug-8826-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8826 Priority: P5 - low Change sponsored?: --- Bug ID: 8826 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: Initialization of hash triggers error log entries. Severity: enhancement Classification: Unclassified OS: All Reporter: mtompset at hotmail.com Hardware: All Status: NEW Version: unspecified Component: Circulation Product: Koha Bug 7851 initialized a hash incorrectly. our %renew_failed = {}; This attempts to create a hash of a single anonymous hash reference which generates the error: circulation.pl: Reference found where even-sized list expected at /usr/share/koha/intranet/cgi-bin/circ/circulation.pl line 97. As I do not know how my proposed change of: our %renew_failed = (); will work in a plack context, I would need someone to assist in testing that. I was thinking of reverting to no initialization, but based on my reading of bug 7851, that isn't an option. In the worst case scenario: our %renew_failed = ( "dummyplaceholderkey" => "dummyplaceholdervalue" ); should work. This only applies to 3.8.x and master, as 3.6.x still has an uninitialized value (which should not be problematic as far as I can tell). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 11:10:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 09:10:58 +0000 Subject: [Koha-bugs] [Bug 8784] Missing files in debian.packages list In-Reply-To: <bug-8784-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8784-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8784-70-sBYhMHDySG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8784 Zeno Tajoli <tajoli at cilea.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tajoli at cilea.it --- Comment #2 from Zeno Tajoli <tajoli at cilea.it> --- I see that the patch delete the package libmodern-perl-perl. Why ? I see this module used in: acqui/check_uniqueness.pl acqui/modordernotes.pl and in others scripts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 12:12:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 10:12:30 +0000 Subject: [Koha-bugs] [Bug 8784] Missing files in debian.packages list In-Reply-To: <bug-8784-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8784-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8784-70-vIpLuCF9Ot@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8784 --- Comment #3 from M. Tompsett <mtompset at hotmail.com> --- It did not delete it. It moved it. Made all the library listings in alphabetical order. See it is 2 lines over on the right? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 13:11:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 11:11:29 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8798-70-jugOYTPtt2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12480|0 |1 is obsolete| | --- Comment #35 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12520 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12520&action=edit [SIGNED-OFF] Bug 8798 - Add the use of DBIx::Class - Rename schema class updater updateDatabase.pl is a bit too close to updatedatabase.pl in installer and may cause some confusion. I would suggest update_dbix_class_files.pl as a unambiguous and descriptive name for this file. Signed-off-by: wajasu <matted-34813 at mypacks.net> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 13:15:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 11:15:33 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8798-70-kQ8aIRZorn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12480|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 13:16:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 11:16:19 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8798-70-USDlWT9AoP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12520|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 13:17:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 11:17:24 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8798-70-j6U2E44y1o@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12506|0 |1 is obsolete| | --- Comment #36 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12521 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12521&action=edit [SIGNED-OFF] Updated to remove tabs http://bugs.koha-community.org/show_bug.cgi?id=8798 Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 13:30:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 11:30:33 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7736-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7736-70-ckfWe5vVKx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #19 from Zeno Tajoli <tajoli at cilea.it> --- I find those problems in the patch: a)It doesn't create the dir misc/edi_files b)It doesn't create the file edi_quote_cron.pl (same function with a different name?) I find the test file, ptfs-europe-koha-community.CEQ, in an obsolete attach. I don't have an EDI vendor, only a FTP site so I strictly depend on the test "Instructions for setting up a test environment for the patch" to do tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 13:36:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 11:36:14 +0000 Subject: [Koha-bugs] [Bug 8738] DateTime object being compared to a date string in circulation In-Reply-To: <bug-8738-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8738-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8738-70-Rwklj5nBFK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8738 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12049|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12522 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12522&action=edit [SIGNED-OFF] circ/circulation.pl: force issuedate to a string to fix bug 8738 Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Installed DataTime version 0.53, verified the error occurs. Applied patch, verified patch removes the error. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 13:37:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 11:37:45 +0000 Subject: [Koha-bugs] [Bug 8824] use of windows 7, Firefox V15 and wireless level dns 10.58.2.X versus wired 192.168.x.x In-Reply-To: <bug-8824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8824-70-mdG0wB2DQZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8824 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- This is not a Koha issue. If you speak with your IT department, they may be able to resolve it. Alternatively, if you are receiving support from a Koha vendor, please contact them directly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 13:40:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 11:40:33 +0000 Subject: [Koha-bugs] [Bug 8738] DateTime object being compared to a date string in circulation In-Reply-To: <bug-8738-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8738-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8738-70-z5b0irw1N7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8738 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> --- Thanks for the extra info. I was able to recreate your error and verify the patch fixes it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 13:44:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 11:44:32 +0000 Subject: [Koha-bugs] [Bug 8037] Add holds and funds to items already received in parcel.pl In-Reply-To: <bug-8037-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8037-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8037-70-U5glyPwfHz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8037 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> --- Resetting to needs signoff. If anyone has an opinion on comments 4/5, please let me know. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 13:48:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 11:48:35 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: <bug-8352-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8352-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8352-70-KWba14iNml@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10766|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12523 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12523&action=edit Bug 8352 - Add automatic printing of 'hold to pull' notices Adds the ability to have a notice printed automatically after a hold has been placed. The system has the ability to define a separate printer for each branchcode, so each library can receive a printed notice for any holds placed, assuming they have set up the ability to print over the LAN, WAN, or Internet. Notices are printed to the pickup library. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 13:48:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 11:48:54 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: <bug-8352-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8352-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8352-70-qwGqw8YkYk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 13:49:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 11:49:50 +0000 Subject: [Koha-bugs] [Bug 7189] preference to control if returning lost items gives refund In-Reply-To: <bug-7189-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7189-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7189-70-tb04naTrls@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7189 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 14:20:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 12:20:49 +0000 Subject: [Koha-bugs] [Bug 3387] WITHDRAWN items shouldn't check in In-Reply-To: <bug-3387-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3387-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3387-70-N39BhH2kN8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3387 --- Comment #20 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12524 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12524&action=edit Bug 3387 - WITHDRAWN items shouldn't check in - QA Followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 14:21:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 12:21:41 +0000 Subject: [Koha-bugs] [Bug 3387] WITHDRAWN items shouldn't check in In-Reply-To: <bug-3387-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3387-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3387-70-07MhSmODaa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3387 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #21 from Kyle M Hall <kyle at bywatersolutions.com> --- Marking as Passed QA. If you feel this followup needs it's own sign-off, please reset the status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 14:46:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 12:46:23 +0000 Subject: [Koha-bugs] [Bug 8827] New: YUI CSS files no longer found on Yahoo servers Message-ID: <bug-8827-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8827 Priority: P5 - low Change sponsored?: --- Bug ID: 8827 Assignee: oleonard at myacpl.org Summary: YUI CSS files no longer found on Yahoo servers Severity: normal Classification: Unclassified OS: All Reporter: oleonard at myacpl.org Hardware: All Status: NEW Version: master Component: OPAC Product: Koha If you have your yuipath preference set to retrieve YUI files from Yahoo's servers, your OPAC layout will break because the CSS files are no longer at the old location. The short-term fix is to always retrieve YUI CSS from the local file system (as we do in the staff client). A longer-term fix is to remove the yuipath preference altogether (since it is a goal to eliminate YUI) or generalize it to include other assets like jQuery which can also be found on CDNs like Google's (see http://jquery.com/download/ for the currently available CDN links). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 14:51:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 12:51:13 +0000 Subject: [Koha-bugs] [Bug 8827] YUI CSS files no longer found on Yahoo servers In-Reply-To: <bug-8827-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8827-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8827-70-nVThLdTrmv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8827 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 14:57:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 12:57:52 +0000 Subject: [Koha-bugs] [Bug 8253] Fine doubling In-Reply-To: <bug-8253-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8253-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8253-70-LLKzOHXVSi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8253 --- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> --- I see. I cannot think of a way to resolve this. Any ideas? Kyle (In reply to comment #15) > This does not work for me. Instead of having the 2 duplicates kept, they are > now both removed by updatedatabase.pl. > > I think this comes from here: > > my $datetime = "$date 23:59"; > my $new_description = $old_description; > $new_description =~ s/$date/$datetime/g; > $dbh->do("UPDATE accountlines SET description = ? WHERE description = > ?", undef, $new_description, $old_description); > > In the above code, all descriptions are updated to have the new date format > with 23:59 > And then: > > my $query = " > SELECT * FROM accountlines > WHERE ( accounttype = 'FU' OR accounttype = 'F' ) > AND description like '%23:59%' > ORDER BY borrowernumber, itemnumber, accountno, description, > timestamp DESC > "; > > You select all lines with a description that contains '23:59'. So both lines > of my example are returned. > Finally for each line, other lines that have a different timestamp are > deleted. So both lines are deleted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 15:05:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 13:05:28 +0000 Subject: [Koha-bugs] [Bug 8827] YUI CSS files no longer found on Yahoo servers In-Reply-To: <bug-8827-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8827-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8827-70-54GY4YtdWI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8827 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 15:05:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 13:05:30 +0000 Subject: [Koha-bugs] [Bug 8827] YUI CSS files no longer found on Yahoo servers In-Reply-To: <bug-8827-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8827-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8827-70-iVf6CbtJzs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8827 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 12525 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12525&action=edit Bug 8827 - YUI CSS files no longer found on Yahoo servers This patch removes the [% yuipath %] variable from the link to the YUI CSS files in the OPAC and adds a hard-coded path to the local files. To test, set your yuipath system preference to "from Yahoo's servers," clear your browser cache, and view the OPAC. The style and layout should look the same as if your yuipath preference were set to "local." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 15:37:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 13:37:11 +0000 Subject: [Koha-bugs] [Bug 8827] YUI CSS files no longer found on Yahoo servers In-Reply-To: <bug-8827-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8827-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8827-70-TBDbNqSyix@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8827 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12525|0 |1 is obsolete| | --- Comment #2 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 12526 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12526&action=edit [SIGNED_OFF] Patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 15:37:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 13:37:35 +0000 Subject: [Koha-bugs] [Bug 8827] YUI CSS files no longer found on Yahoo servers In-Reply-To: <bug-8827-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8827-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8827-70-fCbOwEpdrw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8827 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |m.de.rooy at rijksmuseum.nl --- Comment #3 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Fixes broken display. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 15:40:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 13:40:30 +0000 Subject: [Koha-bugs] [Bug 8827] YUI CSS files no longer found on Yahoo servers In-Reply-To: <bug-8827-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8827-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8827-70-fjuUw4fJ3b@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8827 --- Comment #4 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Would it be an idea to add some text next to the pref, mentioning that css is always local and javascript comes from Yahoo, or something like that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 15:48:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 13:48:21 +0000 Subject: [Koha-bugs] [Bug 8800] SpecifyDueDate && useDaysMode=Datedue wrong behaviour In-Reply-To: <bug-8800-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8800-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8800-70-wcylm6hVs2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 --- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 12527 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12527&action=edit Bug 8800 - useDaysMode=Datedue wrong behaviour (3.8.x) useDaysMode=Datedue wasn't used as advertised in the docs. Added a next_open_day sub to Koha::Calendar and some tests for it. - AddIssue was fixed for the case $datedue was defined in circ/circulation.pl - CalcDateDue was modified to be consistent with the intended behaviour Regards To+ Sponsored-by: Universidad Nacional de C?rdoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 15:52:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 13:52:46 +0000 Subject: [Koha-bugs] [Bug 8770] amount does not equal amountoutstanding on a fine with no payments or credits In-Reply-To: <bug-8770-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8770-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8770-70-DIs8OtqiMi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8770 --- Comment #9 from Galen Charlton <gmcharlt at gmail.com> --- The content of attachment 12508 has been deleted by Galen Charlton <gmcharlt at gmail.com> without providing any reason. The token used to delete this attachment was generated at 2012-09-26 13:52:42 UTC. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 15:53:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 13:53:19 +0000 Subject: [Koha-bugs] [Bug 8770] amount does not equal amountoutstanding on a fine with no payments or credits In-Reply-To: <bug-8770-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8770-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8770-70-3SO7Lk3a1w@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8770 --- Comment #10 from Galen Charlton <gmcharlt at gmail.com> --- The content of attachment 12509 has been deleted by Galen Charlton <gmcharlt at gmail.com> who provided the following reason: inadvertantly included real patron data The token used to delete this attachment was generated at 2012-09-26 13:53:07 UTC. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 15:58:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 13:58:05 +0000 Subject: [Koha-bugs] [Bug 7751] Decrease loan period on items with a high number of holds In-Reply-To: <bug-7751-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7751-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7751-70-LvdG5LbIdM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 --- Comment #39 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 12528 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12528&action=edit [FOLLOW UP] Bug 7751: Decrease loan length with many holds This patch merges the three preferences in to one sentence to make it clear that they are all linked together and to eliminate confusion that can come by having them as individual preferences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 15:58:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 13:58:41 +0000 Subject: [Koha-bugs] [Bug 7751] Decrease loan period on items with a high number of holds In-Reply-To: <bug-7751-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7751-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7751-70-KWdG0vJOxB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED CC| |nengard at gmail.com --- Comment #40 from Nicole C. Engard <nengard at gmail.com> --- Submitting a follow up to clean up the preferences in to one sentence. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 15:59:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 13:59:00 +0000 Subject: [Koha-bugs] [Bug 7751] Decrease loan period on items with a high number of holds In-Reply-To: <bug-7751-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7751-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7751-70-2ddSlxP2xE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #41 from Nicole C. Engard <nengard at gmail.com> --- Follow up needs sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 16:01:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 14:01:05 +0000 Subject: [Koha-bugs] [Bug 7751] Decrease loan period on items with a high number of holds In-Reply-To: <bug-7751-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7751-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7751-70-ipZAtm69k3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12345|0 |1 is obsolete| | --- Comment #42 from Nicole C. Engard <nengard at gmail.com> --- Comment on attachment 12345 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12345 Supplemental tidy-up patch Obsoleted by the merging of the three preferences in to one sentence. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 16:05:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 14:05:49 +0000 Subject: [Koha-bugs] [Bug 8770] amount does not equal amountoutstanding on a fine with no payments or credits In-Reply-To: <bug-8770-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8770-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8770-70-JMOYXGSN2J@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8770 --- Comment #11 from Jesse Maseto <jesse at bywatersolutions.com> --- Created attachment 12529 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12529&action=edit Fines 1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 16:06:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 14:06:13 +0000 Subject: [Koha-bugs] [Bug 8770] amount does not equal amountoutstanding on a fine with no payments or credits In-Reply-To: <bug-8770-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8770-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8770-70-XSsPFoGJkC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8770 --- Comment #12 from Jesse Maseto <jesse at bywatersolutions.com> --- Created attachment 12530 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12530&action=edit Fines 2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 16:19:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 14:19:09 +0000 Subject: [Koha-bugs] [Bug 8828] New: Allow adding all results of a search to a list Message-ID: <bug-8828-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8828 Priority: P5 - low Change sponsored?: --- Bug ID: 8828 Assignee: gmcharlt at gmail.com Summary: Allow adding all results of a search to a list Severity: enhancement Classification: Unclassified OS: All Reporter: kyle at bywatersolutions.com Hardware: All Status: NEW Version: master Component: Searching Product: Koha Currently, if a librarian runs a search, he or she can only add the items on the current page to a list. If the librarian wants to add all the results from a given search to a list, that person must go through each page of results and add them to the cart via check all, then add to list. It would be helpful if a librarian could add all the results of a search to a list at once. This would be useful in particular for exporting or batch modifying records. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 16:40:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 14:40:03 +0000 Subject: [Koha-bugs] [Bug 8823] CatalogModuleRelink Creates Multiple Links between Bib and Auth record ($9 RLIN) In-Reply-To: <bug-8823-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8823-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8823-70-LmBpPHCy3q@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8823 --- Comment #2 from Joy Nelson <joy at bywatersolutions.com> --- Jared- Here is a screencast: http://screencast.com/t/gsopfG4y7M4 I have replicated it on 3.8.1 through 3.8.5 (In reply to comment #1) > Could you please provide a test plan for replicating this problem? I have my > settings exactly the same as yours, and can edit and save to my heart's > content without any extra $9s showing up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 16:49:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 14:49:02 +0000 Subject: [Koha-bugs] [Bug 8481] Items table is showing in opac-MARCdetail.pl but not in MARCdetail.pl In-Reply-To: <bug-8481-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8481-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8481-70-iYYn9SkQzG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8481 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |fridolyn.somers at biblibre.co |ity.org |m --- Comment #2 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> --- Created attachment 12531 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12531&action=edit Proposed patch Very small patch. As said, just items missing from MARC record. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 16:49:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 14:49:42 +0000 Subject: [Koha-bugs] [Bug 8390] Place hold button is missing from the MARC view page In-Reply-To: <bug-8390-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8390-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8390-70-Zg0gT4Czf8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8390 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m --- Comment #2 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> --- see bug 8481 patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 16:53:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 14:53:39 +0000 Subject: [Koha-bugs] [Bug 8829] New: can't import authorities Message-ID: <bug-8829-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8829 Priority: P5 - low Change sponsored?: --- Bug ID: 8829 CC: m.de.rooy at rijksmuseum.nl Assignee: gmcharlt at gmail.com Summary: can't import authorities Severity: critical Classification: Unclassified OS: All Reporter: nengard at gmail.com Hardware: All Status: NEW Version: master Component: Cataloging Product: Koha I cannot import authority files via the staff client, but can import bib records. ---------- FROM IRC: [10:45] <nengard> jcamins, i'm testing the authority import in master and it's frozen [10:45] <nengard> and the list of processes on my server doesn't show it running anymore [10:45] <nengard> it did work the first time I tested it ? last week I think [10:45] <jcamins> nengard: your javascript was out of date. Go to the manage MARC import screen. [10:45] <nengard> it's not there [10:46] <jcamins> And it's not running? [10:46] <jcamins> Weird. [10:46] <nengard> but the one I did on the 20th is there [10:46] <nengard> It is stuck at processing [10:46] <nengard> on the browser [10:46] <nengard> and the process is not running anymore on the server [10:46] <nengard> what has changed for me since the 20th is that I upgraded to mountain lion ? but don't think that's it [10:46] <jcamins> When I imported authorities yesterday it worked. [10:47] <nengard> hmmm [10:47] <jcamins> Actually, it was two days ago. [10:47] <jcamins> Monday. [10:47] * jcamins can eventually figure out what the calendar says. [10:48] <nengard> heh [10:48] <nengard> well i did pull down new updates to master yesterday [10:48] <nengard> so maybe something broke it yesterday [10:48] <jcamins> Right, but I didn't think there was anything new since Monday. [10:49] <nengard> here's what happens ? [10:49] <nengard> 1. browse for file [10:49] <nengard> 2. change type to authority [10:49] <nengard> 3. don't look for matches [10:49] <nengard> 4. click button [10:49] <nengard> server says : www-data 1915 0.0 3.3 109904 24300 ? R 10:43 0:00 /usr/bin/perl /home/nengard/kohaclone/tools/background-job-progress.pl [10:49] <nengard> 1 minute later that line is gone from the processes, but the browser still says it's processing [10:50] <nengard> same process with a bib record finishes in no time -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 16:54:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 14:54:11 +0000 Subject: [Koha-bugs] [Bug 8829] can't import authorities In-Reply-To: <bug-8829-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8829-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8829-70-96o3RyBSgO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8829 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jcamins at cpbibliography.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8818 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 16:54:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 14:54:11 +0000 Subject: [Koha-bugs] [Bug 8818] Authority linker error on Z cataloging In-Reply-To: <bug-8818-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8818-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8818-70-fR8nt7x5xs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8818 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8829 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 17:01:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 15:01:13 +0000 Subject: [Koha-bugs] [Bug 8828] Allow adding all results of a search to a list In-Reply-To: <bug-8828-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8828-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8828-70-ZgFuD8J3dj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8828 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- *** This bug has been marked as a duplicate of bug 7010 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 17:01:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 15:01:13 +0000 Subject: [Koha-bugs] [Bug 7010] Select all records from search In-Reply-To: <bug-7010-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7010-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7010-70-Wam5ufaQ5C@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7010 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- *** Bug 8828 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 17:21:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 15:21:37 +0000 Subject: [Koha-bugs] [Bug 8830] New: authority cataloging errors not helpful Message-ID: <bug-8830-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8830 Priority: P5 - low Change sponsored?: --- Bug ID: 8830 CC: jcamins at cpbibliography.com, m.de.rooy at rijksmuseum.nl Assignee: gmcharlt at gmail.com Summary: authority cataloging errors not helpful Severity: minor Classification: Unclassified OS: All Reporter: nengard at gmail.com Hardware: All Status: NEW Version: master Component: Cataloging Product: Koha Created attachment 12532 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12532&action=edit missing fields error See attached. When cataloging an authority record it pops up to tell you the fields you didn't fill in, but unlike in cataloging it doesn't give you field numbers, so I'm not really sure what fields I need to go back and find and fill in. This pop up should be like the one in cataloging that tells you the field numbers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 17:25:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 15:25:35 +0000 Subject: [Koha-bugs] [Bug 8519] Make koha-index-daemon run on startup In-Reply-To: <bug-8519-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8519-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8519-70-SVTSYsh2lu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8519 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|8774 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 17:25:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 15:25:35 +0000 Subject: [Koha-bugs] [Bug 8774] make a deb package of Koha::Contrib::Tamil::IndexerDaemon In-Reply-To: <bug-8774-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8774-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8774-70-KeCYhfCo77@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8774 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|8519 | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 18:44:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 16:44:56 +0000 Subject: [Koha-bugs] [Bug 8831] New: gstrate should say 'Tax rate' Message-ID: <bug-8831-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8831 Priority: P5 - low Change sponsored?: --- Bug ID: 8831 Assignee: nengard at gmail.com Summary: gstrate should say 'Tax rate' Severity: minor Classification: Unclassified OS: All Reporter: nengard at gmail.com URL: cgi-bin/koha/acqui/neworderempty.pl?booksellerid=1&bas ketno=34 Hardware: All Status: ASSIGNED Version: master Component: Acquisitions Product: Koha Created attachment 12533 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12533&action=edit gstrate GST was replaced with Tax everywhere, so this patch fixes the one last occurrence of that. Patch coming. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 18:46:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 16:46:08 +0000 Subject: [Koha-bugs] [Bug 8831] gstrate should say 'Tax rate' In-Reply-To: <bug-8831-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8831-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8831-70-S7wPjE6uNi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8831 --- Comment #1 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 12534 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12534&action=edit Bug 8831: relabel gstrate with Tax rate This patch changes gstrate to Tax rate to match the standard set on all other acq pages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 18:46:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 16:46:20 +0000 Subject: [Koha-bugs] [Bug 8831] gstrate should say 'Tax rate' In-Reply-To: <bug-8831-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8831-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8831-70-xLn3EkXqel@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8831 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 18:49:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 16:49:11 +0000 Subject: [Koha-bugs] [Bug 8820] Don't show orders table if there are no orders In-Reply-To: <bug-8820-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8820-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8820-70-MuLu3EJfTO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8820 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12505|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 12535 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12535&action=edit [SIGNED-OFF] Bug 8820 - Don't show orders table if there are no orders This page removes the "basket empty" message in favor of hiding the orders table altogether when a basket has no orders. This patch also moves the "Show all details" checkbox under the "Orders" heading to associate it more closely with the area it affects. Other textual changes: - Correcting capitalization according to coding guidelines - Correcting terminology (basket group instead of basketgroup) - Replacing the "Order Details" heading with the more succinct "Orders" Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 18:49:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 16:49:30 +0000 Subject: [Koha-bugs] [Bug 8820] Don't show orders table if there are no orders In-Reply-To: <bug-8820-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8820-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8820-70-96DhBxiZap@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8820 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 18:55:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 16:55:04 +0000 Subject: [Koha-bugs] [Bug 8832] New: can't enter a tax rate on vendor or when ordering Message-ID: <bug-8832-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8832 Priority: P5 - low Change sponsored?: --- Bug ID: 8832 Assignee: koha-bugs at lists.koha-community.org Summary: can't enter a tax rate on vendor or when ordering Severity: major Classification: Unclassified OS: All Reporter: nengard at gmail.com Hardware: All Status: NEW Version: master Component: Acquisitions Product: Koha Created attachment 12536 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12536&action=edit placing an order I can no longer enter a tax rate when adding a new vendor, editing a vendor or placing an order. It's always a pull down with 0% in it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 18:55:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 16:55:25 +0000 Subject: [Koha-bugs] [Bug 8832] can't enter a tax rate on vendor or when ordering In-Reply-To: <bug-8832-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8832-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8832-70-8HjkLQBLq9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8832 --- Comment #1 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 12537 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12537&action=edit editing a vendor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 18:57:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 16:57:08 +0000 Subject: [Koha-bugs] [Bug 8110] Add tests for Calendar modules In-Reply-To: <bug-8110-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8110-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8110-70-ahh1YJYTyq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110 --- Comment #47 from Paul Poulain <paul.poulain at biblibre.com> --- (In reply to comment #46) > QA comment : the 3rd patch adds some localized files: > .../mysql/fr-FR/2-Optionel/sample_holidays.sql | 4 ++++ > .../data/mysql/it-IT/optional/sample_holidays.sql | 4 ++++ > > why are they needed ? in fr-FR, there is no branch in the sample 'MPL' afaik > > PS: is it still a blocker ? I think no, the blocker was bug 8486, and it's > pushed now, this one is just the test suite PING ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 18:58:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 16:58:58 +0000 Subject: [Koha-bugs] [Bug 8780] Lower dependency version for DateTime::TimeZone In-Reply-To: <bug-8780-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8780-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8780-70-F5w9PW0qvF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8780 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|unspecified |rel_3_8 --- Comment #5 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 19:03:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 17:03:32 +0000 Subject: [Koha-bugs] [Bug 8824] use of windows 7, Firefox V15 and wireless level dns 10.58.2.X versus wired 192.168.x.x In-Reply-To: <bug-8824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8824-70-RSUA7J4ARw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8824 Harry A Downs Jr <hdowns at berkshire.rr.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|INVALID |--- --- Comment #2 from Harry A Downs Jr <hdowns at berkshire.rr.com> --- THe gentleman who answered this inquiry is either blind sided with arrogance for me even to bring up this inquiry as if he has seen this before or he can not be bothered. If a topic that is brand new is never seen by anyone, is all of those issues easily squelched due to the ineptness of the individual. What ever happenned to open-mindiness on topics and to note it might be just something that others might experience. I am the IT support person company handling this issue so discount your ability onto others whom you might think are lesser technologically or in your case less informed to be aware of other issues or options to a requested inquiry. I respect your answer regaridng it might not be the correct forum to address this but it does involve Koha and the other two apps. I wasstarting on anyone of these items to see if others experienced it or to make aware this can happn in the situation that I documented. If you beleive you ned to ban me because of a rebuttal, go right ahead, but I would rarher you take a moment and take the blinders off. Experience is a vitue and skills are the fruit of the experience, obviously you have not had enough of either. This has been a common theme in tech circles whom are not willingto take thetime necessary to embrace all possibilities and are thus cheating themselves for gaining knowledge. With over 35 years in this business, tech forums are becoming more direct not to respond or entertain any inquiry as to dispell harder inquiry that they cannot answer or whom are willing to answer. You might find this response addressed one week in Network World or other trade magazines as an embarrasement to your software comunity. Keep a better open mind next time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 19:09:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 17:09:05 +0000 Subject: [Koha-bugs] [Bug 8702] System preferences search does not allow accented letters In-Reply-To: <bug-8702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8702-70-7ktzG4atBr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8702 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 --- Comment #9 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 19:13:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 17:13:15 +0000 Subject: [Koha-bugs] [Bug 8659] Inactive funds in neworderempty not disabled in IE/Opera In-Reply-To: <bug-8659-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8659-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8659-70-wGG5hIpFSI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8659 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 --- Comment #13 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 19:35:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 17:35:27 +0000 Subject: [Koha-bugs] [Bug 3387] WITHDRAWN items shouldn't check in In-Reply-To: <bug-3387-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3387-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3387-70-yzMmPAUnI5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3387 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #22 from Paul Poulain <paul.poulain at biblibre.com> --- I find nothing wrong with this patch, but there's something I don't understand, functionnally speaking= * patron has a withdrawn item that is checked out * if no-one can't check-in the book, how will we "clean" the patron record ? the patron will have this book checked in forever, even once it has been paid. isn't this a dead-end ? Explanation welcomed before I push the patch ;-) (+ I thought withdrawn status was for items withdrawn by the library -because they are broken for example-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 19:41:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 17:41:02 +0000 Subject: [Koha-bugs] [Bug 8821] Receive shipment page should hide inactive funds like new order form does In-Reply-To: <bug-8821-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8821-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8821-70-Ni2sl1zLBn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8821 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Forgot about the changes which had been pending to neworderempty.pl in Bug 8659. I need to integrate those into this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 19:44:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 17:44:59 +0000 Subject: [Koha-bugs] [Bug 8824] use of windows 7, Firefox V15 and wireless level dns 10.58.2.X versus wired 192.168.x.x In-Reply-To: <bug-8824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8824-70-S8dUSxxwu6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8824 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #3 from Mason James <mtj at kohaaloha.com> --- (In reply to comment #0) > - Installing a new Windows PC, professional version at the Lanesborough MA > library ran into an issue discussed on the IRC today 09/25/12. I could not > connect on a wired solution but only on a wireless level of ip addressing > aforementioned. Only after I disabled the wired level on 192.168.x.x, which > I was able to connect to the Koha library at mass-cat site, I was able then > to connect through either Firefox or Internet Explorer. This was issue both > in Firefox and also Internet Explorer. Every other random site searched and > browsed allowed full use. Other base info is that I installed Norton 360 on > this PC, same security software on xp pc workstations and no problem for > access there. I was able to ping the library catalog database from the cmd > per IRC support chat. I did also make sure to allow the Firefox software app > instead of leaving on auto, but that did not seem to matter. Any help or > suggestions would be greatly appreciated. sounds like you got a local network problem :/ works perfectly for me... $ curl -IL http://masscat.bywatersolutions.com HTTP/1.1 200 OK Date: Wed, 26 Sep 2012 17:45:06 GMT Server: Apache/2.2.16 (Debian) Content-Type: text/html; charset=UTF-8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 20:50:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 18:50:14 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8798-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8798-70-9Rx81ADQQz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 wajasu <matted-34813 at mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12521|0 |1 is obsolete| | --- Comment #37 from wajasu <matted-34813 at mypacks.net> --- Created attachment 12538 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12538&action=edit 0003-SIGNED-OFF-Bug8798-Updated-to-remove-tabs Regnerated 0003-SIGNED-OFF-Bug8798-Updated-to-remove-tabs to apply. Ran perlcritic on C4/Context.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 21:27:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 19:27:05 +0000 Subject: [Koha-bugs] [Bug 8700] RESERVESLIP fields not being replaced correctly In-Reply-To: <bug-8700-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8700-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8700-70-M2fjteUlYA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8700 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #5 from David Cook <dcook at prosentient.com.au> --- I just want to add kudos for Kyle and Marc. I just had the same issue come up, so it's nice to see that someone has already taken care of it :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 21:32:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 19:32:44 +0000 Subject: [Koha-bugs] [Bug 8833] New: items with no checkouts has no results Message-ID: <bug-8833-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8833 Priority: P5 - low Change sponsored?: --- Bug ID: 8833 Assignee: gmcharlt at gmail.com Summary: items with no checkouts has no results Severity: critical Classification: Unclassified OS: All Reporter: nengard at gmail.com Hardware: All Status: NEW Version: rel_3_8 Component: Reports Product: Koha The items with no checkouts canned reports has no results in it in both master and 3.8. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 22:00:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 20:00:09 +0000 Subject: [Koha-bugs] [Bug 3417] Items with no checkouts report won't output to a file In-Reply-To: <bug-3417-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3417-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3417-70-B2DJfiXKeO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3417 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- *** Bug 3946 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 22:00:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 20:00:09 +0000 Subject: [Koha-bugs] [Bug 3946] can't export Items with no checkouts In-Reply-To: <bug-3946-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3946-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3946-70-bWY0SHvOpn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3946 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- *** This bug has been marked as a duplicate of bug 3417 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 22:37:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 20:37:53 +0000 Subject: [Koha-bugs] [Bug 8829] can't import authorities In-Reply-To: <bug-8829-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8829-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8829-70-ZdZbOE0LNa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8829 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 22:37:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 20:37:55 +0000 Subject: [Koha-bugs] [Bug 8829] can't import authorities In-Reply-To: <bug-8829-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8829-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8829-70-ED1EywLwqz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8829 --- Comment #1 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12539 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12539&action=edit Bug 8829: Fix authority importing A subroutine was not being imported by C4::ImportBatch (ironic, no?) so this patch makes the call fully-qualified. This patch also cleans up two warnings in C4::Auth that are raised when logged in as the database user. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 23:33:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 21:33:49 +0000 Subject: [Koha-bugs] [Bug 8782] Close a suscription In-Reply-To: <bug-8782-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8782-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8782-70-p1t6jinz5u@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8782 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #4 from David Cook <dcook at prosentient.com.au> --- I'm glad to see this enhancement! This issue came up with a client back when I first started using Koha, so it's nice to see a fix for what was one of my first issues! The patch seems rather large though, so I'm not completely sure how to even start testing to see if it breaks anything. Knowing Jonathan's work, I'm sure that the patch does what it describes (yay), but what's the best way of testing if it breaks something else? Unit tests? Are the following tests enough? prove t/ prove t/db_dependent prove xt/ prove xt/author Thoughts? I'd like to start testing and signing off on larger patches, but I want to make sure that I'm doing a thorough enough job. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 23:39:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 21:39:11 +0000 Subject: [Koha-bugs] [Bug 8823] CatalogModuleRelink Creates Multiple Links between Bib and Auth record ($9 RLIN) In-Reply-To: <bug-8823-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8823-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8823-70-mG1HpBAog6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8823 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Sep 26 23:39:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 21:39:13 +0000 Subject: [Koha-bugs] [Bug 8823] CatalogModuleRelink Creates Multiple Links between Bib and Auth record ($9 RLIN) In-Reply-To: <bug-8823-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8823-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8823-70-USXkRFG9vm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8823 --- Comment #3 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12540 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12540&action=edit Bug 8823: CatalogModuleRelink Creates Multiple Links between Bib and Auth record On 3.8.x, it was possible for multiple automatically generated authorities to be linked to a single heading. This patch deletes previous links from headings prior to linking them to automatically-generated headings. This patch also corrects a potential problem wherein multiple authorities might be generated if a record is edited repeatedly in quick succession. The latter problem exists on Master and 3.6.x as well, and the code that corrects the multiple linkages is equally applicable if seemingly unnecessary. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 00:44:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 22:44:58 +0000 Subject: [Koha-bugs] [Bug 5377] Database fields too small for multiple ISBN and ISSN In-Reply-To: <bug-5377-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5377-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5377-70-SspXHGg3CV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5377 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au Version|rel_3_4 |master --- Comment #3 from David Cook <dcook at prosentient.com.au> --- I would like to breathe some life back into this bug. I've noticed that the detail pages of the catalogue in the OPAC and the staff client go straight to the MARC to get the ISBNs, but the database field is still used in areas like the "Receipt Summary" in acquisitions after receiving new items. While it may be trivial, multiple isbns are getting cut off, so that they do not display properly. The easiest solution would be to lengthen like Fridolyn has suggested. However, I think I understand Galen's suggestion to make a different table instead to work with multiple values. After all, it's not good practice to be putting multiple values in a single field, right? That said, a new table might be overkill, because ISBN might be the only field in biblioitems that contains multiple values. I'm not 100% sure on this one, as I just took a quick look glance through some sample data. Thoughts? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 00:45:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 22:45:18 +0000 Subject: [Koha-bugs] [Bug 6011] 7xx fields should optionally link on standard (ISBN/ISSN/etc.) numbers In-Reply-To: <bug-6011-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6011-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6011-70-x4defc7zwI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6011 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 00:45:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 26 Sep 2012 22:45:33 +0000 Subject: [Koha-bugs] [Bug 6011] 7xx fields should optionally link on standard (ISBN/ISSN/etc.) numbers In-Reply-To: <bug-6011-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6011-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6011-70-jZPkU4deHJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6011 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|dcook at prosentient.com.au | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 03:39:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 01:39:21 +0000 Subject: [Koha-bugs] [Bug 8829] can't import authorities In-Reply-To: <bug-8829-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8829-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8829-70-AazVV409Os@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8829 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12539|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 12541 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12541&action=edit [SIGNED-OFF] Bug 8829: Fix authority importing A subroutine was not being imported by C4::ImportBatch (ironic, no?) so this patch makes the call fully-qualified. This patch also cleans up two warnings in C4::Auth that are raised when logged in as the database user. Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 03:40:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 01:40:13 +0000 Subject: [Koha-bugs] [Bug 8829] can't import authorities In-Reply-To: <bug-8829-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8829-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8829-70-7nsprkEgnc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8829 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 06:54:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 04:54:09 +0000 Subject: [Koha-bugs] [Bug 8113] Item return fails using SIP2 In-Reply-To: <bug-8113-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8113-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8113-70-D8xlXrJYvV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8113 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #5 from M. Tompsett <mtompset at hotmail.com> --- That should be C4::Items->GetItemnumberFromBarcode not C4::Items::GetItemnumberFromBarcode The latter expects a GetItemnumberFromBarcode.pm file, whereas the former expects a function inside of C4::Items. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 06:58:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 04:58:42 +0000 Subject: [Koha-bugs] [Bug 8113] Item return fails using SIP2 In-Reply-To: <bug-8113-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8113-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8113-70-c2R8zQ4GBy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8113 --- Comment #6 from Chris Cormack <chris at bigballofwax.co.nz> --- (In reply to comment #5) > That should be C4::Items->GetItemnumberFromBarcode not > C4::Items::GetItemnumberFromBarcode > > The latter expects a GetItemnumberFromBarcode.pm file, whereas the former > expects a function inside of C4::Items. Not true. C4::Items::GetItemnumberFromBarcode() calls the GetItemnumberFromBarcode subroutine in C4/Items.pm If you notice Ron's other comment, it is now the same error further in the file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 08:08:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 06:08:47 +0000 Subject: [Koha-bugs] [Bug 8834] New: Call to C4::Context::preference fails to pass $self in Circulation.pm Message-ID: <bug-8834-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8834 Priority: P5 - low Change sponsored?: --- Bug ID: 8834 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: Call to C4::Context::preference fails to pass $self in Circulation.pm Severity: enhancement Classification: Unclassified OS: All Reporter: mtompset at hotmail.com Hardware: All Status: NEW Version: rel_3_8 Component: Circulation Product: Koha Currently line reads: my $circcontrol = C4::Context::preference('CircControl'); This fails to pass $self, which means the line: my $var = lc(shift); # The system preference to return which is in C4::Context.pm (sub preference) triggers the following error log entry: [Thu Sep 27 12:23:16 2012] [error] [client 192.168.100.2] [Thu Sep 27 12:23:16 2012] renewscript.pl: Use of uninitialized value in lc at /usr/share/koha/lib/C4/Context.pm line 529. This of course was particularly confusing because the problem is neither in renewscript.pl or Context.pm, but rather Circulation.pm. This error happens to be in 'sub _debar_user_on_return', which may mean it may or may not affect other user debarred on return bugs. That wasn't what I'm testing for in this bug. This does not exist in 3.6.x. This was discovered in 3.8.5. This exists in 3.8.x and master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 08:33:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 06:33:37 +0000 Subject: [Koha-bugs] [Bug 8834] Call to C4::Context::preference fails to pass $self in Circulation.pm In-Reply-To: <bug-8834-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8834-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8834-70-G6G89fIr3J@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8834 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |mtompset at hotmail.com |ity.org | --- Comment #1 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 12542 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12542&action=edit Change :: to -> to correctly call C4::Context->preference Test ------ 1) Login in to staff client. 2) In search area, click 'Search Patrons' tab. 3) In search area text box, type a library name 4) Press Enter or Click the 'Submit' button 5) On the Left click the 'Check out' tab. 6) There should now be a list of checked out items. Check one of the 'Check In' checkboxes. Hopefully you have multiple items. 7) Add a Renewal Date. 8) Click the 'Renew or Return checked items' button. 9) check the intranet error log file. There should be something like: [Thu Sep 27 12:34:22 2012] [error] [client 192.168.100.2] [Thu Sep 27 12:34:22 2012] renewscript.pl: Use of uninitialized value in lc at /usr/share/koha/lib/C4/Context.pm line 529. 10) Apply patch 11) Check another one of the 'Check In' checkboxes. 12) Add a Renewal Date. 13) Click the 'Renew or Return checked items' button. 14) check the intranet error log file. The error should not appear. See also bug 8251, as if you have applied that patch before this one, it will not likely apply. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 08:36:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 06:36:12 +0000 Subject: [Koha-bugs] [Bug 8834] Call to C4::Context::preference fails to pass $self in Circulation.pm In-Reply-To: <bug-8834-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8834-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8834-70-yYV19gdXKR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8834 --- Comment #2 from M. Tompsett <mtompset at hotmail.com> --- Actually, if it bug 8251 has already been pushed, the patch should apply fine. I just did this up from the latest master, and tested applying against the latest 3.8.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 08:57:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 06:57:50 +0000 Subject: [Koha-bugs] [Bug 8251] Patrons are systematically debarred at checkin In-Reply-To: <bug-8251-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8251-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8251-70-hDoEFaYsr9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8251 --- Comment #45 from Magnus Enger <magnus at enger.priv.no> --- Just checked that the problem is no longer present in 3.8.5. Yay! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 09:00:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 07:00:51 +0000 Subject: [Koha-bugs] [Bug 8378] <fine> syntax not working on overdues anymore In-Reply-To: <bug-8378-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8378-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8378-70-LAMOQVxkWo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8378 Magnus Enger <magnus at enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED CC| |magnus at enger.priv.no --- Comment #14 from Magnus Enger <magnus at enger.priv.no> --- Looks like this should be "needs signoff" for the 3.8.x patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 09:01:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 07:01:02 +0000 Subject: [Koha-bugs] [Bug 8378] <fine> syntax not working on overdues anymore In-Reply-To: <bug-8378-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8378-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8378-70-g4EGtqpbFk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8378 Magnus Enger <magnus at enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 09:02:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 07:02:24 +0000 Subject: [Koha-bugs] [Bug 8378] <fine> syntax not working on overdues anymore In-Reply-To: <bug-8378-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8378-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8378-70-ZeE65Jywti@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8378 Magnus Enger <magnus at enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11906|0 |1 is obsolete| | --- Comment #15 from Magnus Enger <magnus at enger.priv.no> --- Comment on attachment 11906 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11906 Bug 8378 - <fine> syntax not working on overdues anymore This patch has been pushed. Marking it as obsolete to avoid confusion with the 3.8.x patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 09:21:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 07:21:15 +0000 Subject: [Koha-bugs] [Bug 8835] New: Two indexes on biblioitems.issn Message-ID: <bug-8835-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8835 Priority: P5 - low Change sponsored?: --- Bug ID: 8835 Assignee: gmcharlt at gmail.com Summary: Two indexes on biblioitems.issn Severity: minor Classification: Unclassified OS: All Reporter: fridolyn.somers at biblibre.com Hardware: All Status: NEW Version: master Component: Database Product: Koha In update database script : 3.01.00.006 adds an index called 'issn' on biblioitems.issn. 3.01.00.093 also adds an index on biblioitems.issn, called 'issn_idx'. In kohastructure, only 'issn' index exists for biblioitems. So udpate 3.01.00.093 is useless. Can it be removed ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 09:31:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 07:31:14 +0000 Subject: [Koha-bugs] [Bug 5335] More granular VAT In-Reply-To: <bug-5335-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5335-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5335-70-y6y6Hl0qYi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8832 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 09:31:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 07:31:14 +0000 Subject: [Koha-bugs] [Bug 8832] can't enter a tax rate on vendor or when ordering In-Reply-To: <bug-8832-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8832-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8832-70-Xh7Cmtspry@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8832 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Depends on| |5335 --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Nicole, I am quite sure this is a problem introduced by bug 5335: - my $default_gst_rate = (C4::Context->preference('gist') * 100) || '0.0'; + # get option values from gist syspref + my @gst_values = map { + option => $_ + }, split( '\|', C4::Context->preference("gist") ); It seems it expects a | separated list of values now for the gist system preference. I think this maybe slipped in by accident as 5335 doesn't seem to include a database update of any sort. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 09:32:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 07:32:10 +0000 Subject: [Koha-bugs] [Bug 8832] can't enter a tax rate on vendor or when ordering In-Reply-To: <bug-8832-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8832-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8832-70-O77H15tWo5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8832 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Updating severity - this is a bad bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 09:36:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 07:36:41 +0000 Subject: [Koha-bugs] [Bug 8832] can't enter a tax rate on vendor or when ordering In-Reply-To: <bug-8832-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8832-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8832-70-EI3dgVWKJC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8832 --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Ok, seems I am not fully awake yet, there is an updatedatebase in 5335, but it doesn't touch systempreferences. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 09:39:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 07:39:16 +0000 Subject: [Koha-bugs] [Bug 8832] can't enter a tax rate on vendor or when ordering In-Reply-To: <bug-8832-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8832-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8832-70-XvW1RVzqJi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8832 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #5 from M. Tompsett <mtompset at hotmail.com> --- Yes, but the gist system preference is actually a character field, which I thought was bizarre when I was looking around there. Have you attempted to put 0|12|13|4|string into gist, nengard? -- By the way, that (because of string) should also trigger errors (if you select string), because we have no field validation on system preferences, as far as I know. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 09:43:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 07:43:31 +0000 Subject: [Koha-bugs] [Bug 8581] Authority display doesn't like GND records In-Reply-To: <bug-8581-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8581-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8581-70-B5QNrGok4H@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8581 --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Jared, can you take a look at this please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 09:45:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 07:45:11 +0000 Subject: [Koha-bugs] [Bug 8832] can't enter a tax rate on vendor or when ordering In-Reply-To: <bug-8832-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8832-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8832-70-78niDSUwaI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8832 --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- It still seems like an undocumented change of behaviour that maybe belongs to a different development. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 09:59:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 07:59:54 +0000 Subject: [Koha-bugs] [Bug 8826] Initialization of hash triggers error log entries. In-Reply-To: <bug-8826-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8826-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8826-70-Or9KbaMjnn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8826 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |mtompset at hotmail.com |ity.org | --- Comment #1 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 12543 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12543&action=edit Changed {} to () in initialization of variable. This is the master version of the patch. 3.8.x needs a different patch. Test ----- 1) Login in to staff client 2) Click 'Circulation' (doesn't matter which one) 3) Click the 'Check Out' link below the Circulation title, and above the 'Check In' link. 4) Check the intranet error log. There should be an error like: [Thu Sep 27 14:51:06 2012] [error] [client 192.168.100.2] [Thu Sep 27 14:51:06 2012] circulation.pl: Reference found where even-sized list expected at /usr/share/koha/intranet/cgi-bin/circ/circulation.pl line 97. 5) Apply patch 6) repeat steps 1-3, and recheck for an error. There shouldn't be one. FURTHER TEST ------------- Do this on a plakified setup. I have not tested this case, but it is likely important as bug 7851 changed this single line in the first place. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 10:01:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 08:01:39 +0000 Subject: [Koha-bugs] [Bug 8826] Initialization of hash triggers error log entries. In-Reply-To: <bug-8826-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8826-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8826-70-f3BJaQZYvY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8826 --- Comment #2 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 12544 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12544&action=edit Changed {} to () in initialization of variable. (3.8.x) Changes between 3.8.x and master require a separate patch to apply cleanly. The test plan should be the same as master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 10:03:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 08:03:47 +0000 Subject: [Koha-bugs] [Bug 4381] systempreference hide_marc = ON results in erroneous behaviour of repeatable fields and subfields In-Reply-To: <bug-4381-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4381-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4381-70-4DXpNaKV1B@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4381 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED CC| |fridolyn.somers at biblibre.co | |m Resolution|WONTFIX |--- -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 10:04:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 08:04:06 +0000 Subject: [Koha-bugs] [Bug 4381] systempreference hide_marc = ON results in erroneous behaviour of repeatable fields and subfields In-Reply-To: <bug-4381-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4381-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4381-70-iX0OImJnwf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4381 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_0 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 10:26:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 08:26:54 +0000 Subject: [Koha-bugs] [Bug 4381] systempreference hide_marc = ON results in erroneous behaviour of repeatable fields and subfields In-Reply-To: <bug-4381-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4381-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4381-70-Py6XvBfVs6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4381 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff Assignee|gmcharlt at gmail.com |fridolyn.somers at biblibre.co | |m --- Comment #1 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> --- Created attachment 12545 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12545&action=edit Proposed patch Simple patch. Even with hide_marc, inficators are input in biblio and authorities cataloguing. They are just hidden type. So cloning javascript method must always take care of indicators. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 10:30:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 08:30:58 +0000 Subject: [Koha-bugs] [Bug 4381] systempreference hide_marc = ON results in erroneous behaviour of repeatable fields and subfields In-Reply-To: <bug-4381-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4381-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4381-70-jIbUMaCIzr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4381 --- Comment #2 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> --- Test plan : ----------- Set hide_marc syspref to 'don't display'. Edit a bibio/authority record with a repeatable field. For example : 606 a APPLE 606 a BANANA Save the record. In MARC you get : 606 a APPLE a BANANA With patch, record is well saved. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 10:33:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 08:33:37 +0000 Subject: [Koha-bugs] [Bug 7455] Authority subfields are cloned in the wrong field In-Reply-To: <bug-7455-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7455-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7455-70-bvFRpskJ6c@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=4381 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 10:33:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 08:33:38 +0000 Subject: [Koha-bugs] [Bug 4381] systempreference hide_marc = ON results in erroneous behaviour of repeatable fields and subfields In-Reply-To: <bug-4381-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4381-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4381-70-DBwuuZ4Ift@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4381 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7455 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 10:37:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 08:37:09 +0000 Subject: [Koha-bugs] [Bug 7455] Authority subfields are cloned in the wrong field In-Reply-To: <bug-7455-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7455-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7455-70-sPo1ngnnK9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7455 --- Comment #34 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> --- Created attachment 12546 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12546&action=edit Proposed patch (follow-up 3) follow-up 3 : A small correction made in Bug 4381 must be integrated since it concerns field cloning. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 11:03:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 09:03:26 +0000 Subject: [Koha-bugs] [Bug 4381] systempreference hide_marc = ON results in erroneous behaviour of repeatable fields and subfields In-Reply-To: <bug-4381-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4381-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4381-70-pkRX5uchsO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4381 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 11:46:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 09:46:35 +0000 Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title with borrower's age without using categories In-Reply-To: <bug-7621-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7621-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7621-70-xglCs9VzwL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 --- Comment #69 from Marc V?ron <veron at veron.ch> --- Created attachment 12547 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12547&action=edit Screenshots regarding usage PDF added to show how to use the Age restriction feature (on request of http://irc.koha-community.org/irclog/koha/2012-09-26#i_1088535) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 12:20:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 10:20:28 +0000 Subject: [Koha-bugs] [Bug 8777] Quiet errors in circulation.pl In-Reply-To: <bug-8777-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8777-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8777-70-uXTSEmGmVW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8777 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #1 from M. Tompsett <mtompset at hotmail.com> --- Good thing I went looking for a duplicate. borrowernumber is a bit more of a problem, as it is harder to trace the logic as to whether it should be q{} or 0. Though, I think 0 would result in different behaviour than undefined in some cases. Any thoughts on this? Regarding line 97, see bug 8826. -- I had put that already up, because some of these patches don't require specialized testing for plakified situations. findborrower, barcode, and print can all be fixed with a || q{} This should deal with line 161, 173 if ( $barcode eq '' and defined($query->param('charges')) and $query->param('charges') eq 'yes' ) { should fix 166 Haven't encountered 364, but I suppose: if ( defined($num_res->{'found'}) and $num_res->{'found'} eq 'W' ) { Haven't encountered 382, but that would be an uglier check. Haven't encountered 388, but I think a ! =~ \S would be in there somehow. (!defined($it->{'author'}) or $it->{'author'} eq '') and $it->{'author'} = ' '; I believe solves 461. if ( (defined ($it->{'issuedate'}) and $it->{'issuedate'} gt $todaysdate) or (defined ($it->{'lastreneweddate'}) and $it->{'lastreneweddate'} gt $todaysdate )) { should fix 464 Regarding the $address, I was thinking: my $address = q{}; $address .= $borrower->{'streetnumber'} if $borrower->{'streetnumber'}; $address .= ' ' if $address and $borrower->{'streettype'}; $address .= $roadttype_hashref->{$borrower->{'streettype'}} if $borrower->{'streettype'}; $address .= ' ' if $address and $borrower->{'address'}; $address .= $borrower->{'address'} if $borrower->{'address'}; But I'm sure there is an optimization somehow. This addresses 644. I haven't generated a patch for any of this yet, since I wouldn't want to step on any toes. Though, your thoughts regarding borrowernumber would be helpful. I did confirm that sth->execute(undef variable) generates 0 just like sth->execute(empty variable) for a "SELECT COUNT(*) ..." as a result of looking through these error log entries. These errors overlap into 3.8.x as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 13:54:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 11:54:02 +0000 Subject: [Koha-bugs] [Bug 8832] can't enter a tax rate on vendor or when ordering In-Reply-To: <bug-8832-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8832-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8832-70-XuR8AKF7Gq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8832 --- Comment #7 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 12548 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12548&action=edit preference values Okay, this seems a bit silly to me, but most US libraries don't charge tax. I followed the preference instructions and entered data like in the picture (12%|6%|7%|5%) but then it appears way wrong in the pull down. So the preference needs to be updated. Also, what happens to those who have a tax rate already on a vendor but not in the preference and upgrade? More importantly what happens to those who had 0 in the gist? That used to hide all of the tax fields from acq making it easier for those who don't use tax rates .... I think that this change in the preference was not thought out and I unfortunately missed it and didn't complain before now. Nicole -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 13:54:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 11:54:20 +0000 Subject: [Koha-bugs] [Bug 8832] can't enter a tax rate on vendor or when ordering In-Reply-To: <bug-8832-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8832-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8832-70-os2sgcjNhb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8832 --- Comment #8 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 12549 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12549&action=edit pull down after entering values in preference -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 13:56:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 11:56:47 +0000 Subject: [Koha-bugs] [Bug 5335] More granular VAT In-Reply-To: <bug-5335-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5335-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5335-70-mbvUpG5PV1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 --- Comment #49 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Paul, can you please take a look at 8832? We found a bigger problem that was introduced by this feature. Thx! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 14:06:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 12:06:22 +0000 Subject: [Koha-bugs] [Bug 5335] More granular VAT In-Reply-To: <bug-5335-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5335-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5335-70-RBbJtbuBzV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #50 from Nicole C. Engard <nengard at gmail.com> --- Due to bug 8832 we think this patch needs to be reverted and thought out a bit more for the worldwide community. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 14:09:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 12:09:39 +0000 Subject: [Koha-bugs] [Bug 7441] search results showing wrong branch? In-Reply-To: <bug-7441-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7441-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7441-70-bPCoAz31El@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9701|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12550 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12550&action=edit Bug 7441 - search results showing wrong branch - Part 3 - Control display of branch via system preference -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 14:11:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 12:11:04 +0000 Subject: [Koha-bugs] [Bug 5335] More granular VAT In-Reply-To: <bug-5335-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5335-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5335-70-0DMb8GYmNu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #51 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to comment #50) > Due to bug 8832 we think this patch needs to be reverted and thought out a > bit more for the worldwide community. Agreed. Nobody realized what ramifications this patch would cause. We need to revert it until an upgrade patch can be found and added. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 14:29:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 12:29:30 +0000 Subject: [Koha-bugs] [Bug 8209] "Did you mean?" suggestions based on authorities In-Reply-To: <bug-8209-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8209-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8209-70-q9gG6sXQp6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8209 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #20 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- The follow-up is a bugfix, not an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 14:32:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 12:32:54 +0000 Subject: [Koha-bugs] [Bug 8581] Authority display doesn't like GND records In-Reply-To: <bug-8581-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8581-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8581-70-Y0cdupebhP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8581 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #7 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Setting back to "Passed QA" as the patch applies fine on current master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 14:44:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 12:44:07 +0000 Subject: [Koha-bugs] [Bug 8209] "Did you mean?" suggestions based on authorities In-Reply-To: <bug-8209-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8209-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8209-70-B7ddMtvcJJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8209 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #21 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to comment #20) > The follow-up is a bugfix, not an enhancement. Latest followup fixes a display problem. Label was a hash ref instead of a name. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 14:56:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 12:56:52 +0000 Subject: [Koha-bugs] [Bug 7441] search results showing wrong branch? In-Reply-To: <bug-7441-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7441-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7441-70-WI8IVzgTNL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12550|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12551 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12551&action=edit Bug 7441 - search results showing wrong branch - Part 3 - Control display of branch via system preference -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 14:57:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 12:57:49 +0000 Subject: [Koha-bugs] [Bug 7441] search results showing wrong branch? In-Reply-To: <bug-7441-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7441-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7441-70-G6khixfzeG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 --- Comment #18 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12552 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12552&action=edit Bug 7441 - search results showing wrong branch - Part 1 - Add holdingbranch to xml -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 14:59:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 12:59:25 +0000 Subject: [Koha-bugs] [Bug 8832] can't enter a tax rate on vendor or when ordering In-Reply-To: <bug-8832-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8832-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8832-70-zvMFGC3bGr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8832 --- Comment #9 from M. Tompsett <mtompset at hotmail.com> --- Actually, perhaps the list should be parsed for %'s and then not multiply by 100. So that way you could have 12% or 0.12 to generate the same result. ;) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 15:00:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 13:00:52 +0000 Subject: [Koha-bugs] [Bug 7441] search results showing wrong branch? In-Reply-To: <bug-7441-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7441-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7441-70-qwyjrw3Dnc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8656|0 |1 is obsolete| | Attachment #8657|0 |1 is obsolete| | Attachment #12551|0 |1 is obsolete| | Attachment #12552|0 |1 is obsolete| | --- Comment #19 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12553 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12553&action=edit Bug 7441 - search results showing wrong branch When you search in the OPAC it shows you the HOME branch on the location in XSLT, but if you click through to the detail page it shows you the HOLDING branch in the holdings table which is very confusing to patrons. Fixed by adding a system preference to choose whether to display the holding branch or the home branch on the XSLT OPAC search results page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 15:03:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 13:03:37 +0000 Subject: [Koha-bugs] [Bug 7441] search results showing wrong branch? In-Reply-To: <bug-7441-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7441-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7441-70-gngTQ0LUCL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff CC| |kyle at bywatersolutions.com --- Comment #20 from Kyle M Hall <kyle at bywatersolutions.com> --- I think I've got everything taken care of now. This new patch is a squashed version of the previous three patches, along with a fixed version of the xslt file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 15:12:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 13:12:58 +0000 Subject: [Koha-bugs] [Bug 8623] Javascript libraries should be outside theme directories In-Reply-To: <bug-8623-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8623-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8623-70-xDqHI2hgv7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8623 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 15:13:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 13:13:01 +0000 Subject: [Koha-bugs] [Bug 8623] Javascript libraries should be outside theme directories In-Reply-To: <bug-8623-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8623-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8623-70-WipnmoNaxB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8623 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12289|0 |1 is obsolete| | --- Comment #14 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12554 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12554&action=edit Bug 8623 - Fix YUI path for OPAC in debian/rules After the changes to YUI path the build process is broken. For testing this I had to set the build process to ommit the tests as there are some db_dependent test being called (which failed). To do this I ran the build script like this: sudo DEB_BUILD_OPTIONS=nocheck ./debian/build-git-snapshot -distribution precise -D precise -r ~/ubuntu -v 3.9.0-046~git -d Note: Even when this is fixed, there are still issues with some files missing dh_install: etc/koha/searchengine/solr/config.yaml exists in debian/tmp but is not installed to anywhere dh_install: etc/koha/searchengine/solr/indexes.yaml exists in debian/tmp but is not installed to anywhere dh_install: etc/koha/solr/indexes.yaml exists in debian/tmp but is not installed to anywhere dh_install: missing files, aborting make: *** [binary] Error 2 dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit status 2 Sponsored-by: Universidad Nacional de C?rdoba Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com> Please note that debian/rules *must* use tabs. If you have a git hook that automatically replaces tabs with spaces, please undo those changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 15:13:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 13:13:19 +0000 Subject: [Koha-bugs] [Bug 8623] Javascript libraries should be outside theme directories In-Reply-To: <bug-8623-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8623-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8623-70-dwDPzHGkUK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8623 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 15:13:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 13:13:20 +0000 Subject: [Koha-bugs] [Bug 8623] Javascript libraries should be outside theme directories In-Reply-To: <bug-8623-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8623-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8623-70-aGglFtplLF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8623 --- Comment #15 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12555 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12555&action=edit Bug 8623 follow-up: make sure CCSR theme loads YUI -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 15:15:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 13:15:26 +0000 Subject: [Koha-bugs] [Bug 8623] Javascript libraries should be outside theme directories In-Reply-To: <bug-8623-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8623-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8623-70-134Db3T20Z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8623 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #16 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Follow-ups fix bugs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 15:37:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 13:37:59 +0000 Subject: [Koha-bugs] [Bug 8633] Translate script hardcoded to prog template In-Reply-To: <bug-8633-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8633-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8633-70-zb0uteHGRV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8633 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 15:38:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 13:38:02 +0000 Subject: [Koha-bugs] [Bug 8633] Translate script hardcoded to prog template In-Reply-To: <bug-8633-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8633-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8633-70-ZcgaIn0KpK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8633 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12342|0 |1 is obsolete| | --- Comment #6 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12556 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12556&action=edit Bug 8633 Manage OPAC alternate templates Modify /misc/translator/translate script in order to manage properly alternate OPAC templates. To test it with new 'ccsr' template: - Create the .po file: ./translate create fr-FR Result: existing .po files are not modified. A new fr-FR-opac-ccsr.po file is available. - Install all templates : ./translate install fr-FR Result: A new koha-tmpl/opac-tmpl/ccsr/fr-FR directory contains translated templates. - Update .po files: ./translate update fr-FR Result: fr-FR .po files are update, include fr-FR-opac-ccsr.po Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 15:41:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 13:41:37 +0000 Subject: [Koha-bugs] [Bug 3387] WITHDRAWN items shouldn't check in In-Reply-To: <bug-3387-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3387-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3387-70-8QCpQPzalC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3387 --- Comment #23 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to comment #22) > I find nothing wrong with this patch, but there's something I don't > understand, functionnally speaking= > * patron has a withdrawn item that is checked out > * if no-one can't check-in the book, how will we "clean" the patron record > ? the patron will have this book checked in forever, even once it has been > paid. > > isn't this a dead-end ? > > Explanation welcomed before I push the patch ;-) > > (+ I thought withdrawn status was for items withdrawn by the library > -because they are broken for example-) That is correct. An item should never be withdrawn if it is currently checked out to a patron, so that situation should never occur. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 15:45:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 13:45:18 +0000 Subject: [Koha-bugs] [Bug 8110] Add tests for Calendar modules In-Reply-To: <bug-8110-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8110-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8110-70-GCoHmCAX58@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|blocker |normal --- Comment #48 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to comment #46) > QA comment : the 3rd patch adds some localized files: > .../mysql/fr-FR/2-Optionel/sample_holidays.sql | 4 ++++ > .../data/mysql/it-IT/optional/sample_holidays.sql | 4 ++++ > > why are they needed ? in fr-FR, there is no branch in the sample 'MPL' afaik > > PS: is it still a blocker ? I think no, the blocker was bug 8486, and it's > pushed now, this one is just the test suite Perhaps we should add MPL as a sample branch for fr-FR? It seems like the easiest solution. I would agree, this is no longer a blocker, but should still be a priority, as it is a unit test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 15:48:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 13:48:37 +0000 Subject: [Koha-bugs] [Bug 8110] Add tests for Calendar modules In-Reply-To: <bug-8110-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8110-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8110-70-frKeQJe1a7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110 --- Comment #49 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- The sample holidays have by themselves a +1 for addition, but its outside the scope of this bug. We need some defaults to test db_dependent stuff, and they were just added to other languages. Maybe those patches should be in another bug and let this ones be pushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 15:50:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 13:50:34 +0000 Subject: [Koha-bugs] [Bug 3387] WITHDRAWN items shouldn't check in In-Reply-To: <bug-3387-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3387-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3387-70-hsucM1ncsS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3387 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #24 from Nicole C. Engard <nengard at gmail.com> --- Withdrawn means that you're removing it from your collection - also referred to as Weeding. This should only happen with items that are not checked out (as Kyle said). Worst case if you accidentally mark something withdrawn and it's still checked out you can always just edit the item and remove the withdrawn status before checking the item back in. Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 15:54:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 13:54:02 +0000 Subject: [Koha-bugs] [Bug 3387] WITHDRAWN items shouldn't check in In-Reply-To: <bug-3387-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3387-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3387-70-V8ZhwFdQac@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3387 --- Comment #25 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Paul, > That is correct. An item should never be withdrawn if it is currently > checked out to a patron, so that situation should never occur. To add to what Kyle said, the only situation where it does occur is when a library wants to continue checking items out to a specific user when withdrawing them. The workflow is unnecessary in Koha, of course, but see quote 123. I think this is a good change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 15:56:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 13:56:30 +0000 Subject: [Koha-bugs] [Bug 8110] Add tests for Calendar modules In-Reply-To: <bug-8110-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8110-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8110-70-cya6hcAoN3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110 --- Comment #50 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to comment #49) > The sample holidays have by themselves a +1 for addition, but its outside > the scope of this bug. We need some defaults to test db_dependent stuff, and > they were just added to other languages. Maybe those patches should be in > another bug and let this ones be pushed. That would be fine by me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 16:11:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 14:11:12 +0000 Subject: [Koha-bugs] [Bug 8831] gstrate should say 'Tax rate' In-Reply-To: <bug-8831-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8831-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8831-70-nzWm3ooALH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8831 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12534|0 |1 is obsolete| | --- Comment #2 from Marc V?ron <veron at veron.ch> --- Created attachment 12557 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12557&action=edit [SIGNED-OFF] Bug 8831: relabel gstrate with Tax rate This patch changes gstrate to Tax rate to match the standard set on all other acq pages. Signed-off-by: Marc Veron <veron at veron.ch> Small text change. Label displays as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 16:24:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 14:24:06 +0000 Subject: [Koha-bugs] [Bug 8832] can't enter a tax rate on vendor or when ordering In-Reply-To: <bug-8832-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8832-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8832-70-QAVazmktSt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8832 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #10 from Paul Poulain <paul.poulain at biblibre.com> --- (In reply to comment #9) > Actually, perhaps the list should be parsed for %'s and then not multiply by > 100. So that way you could have 12% or 0.12 to generate the same result. ;) you're right here: it's written on the syspref description: "Enter in Numeric form 0.12 for 12%. First is default. If you want more than 1 value, please separate with |" (In reply to comment #6) > It still seems like an undocumented change of behaviour that maybe belongs > to a different development. Katrin, I don't know what you mean here: the main purpose of bug 5335 was to have tax rate at order line level, instead of bookseller level. In France, books have a 5.5% VAT, while CD/DVD have a 19.6%. That was a big pain for libraries. The only problem I see here is that, if you have no tax rates defined, you just have '0'. Maybe a follow-up could display, if the syspref is empty "No tax rate entered, go to syspref gist to define possible tax rate" Also note that, now, the bookseller tax rate is just the *default* one. When you enter an order line, you can always choose between all taxes listed in the syspref. > Also, what happens to those who have a tax > rate already on a vendor but not in the preference and upgrade? If you have already a tax that is one of the tax in the syspref, nothing specific. If you have a tax rate that is not in the syspref, then you'll be in trouble when ordering, because you'll just get the "0" Updating the gist syspref is something you *must* do when upgrading. We could do a follow-up that does something like: UPDATE syspref value= join '|', @{SELECT distinct gist FROM aqbooksellers} (ie = put in the syspref all the distinct values that exist in the booksellers tax rates) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 16:26:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 14:26:35 +0000 Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title with borrower's age without using categories In-Reply-To: <bug-7621-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7621-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7621-70-zORwPV2uKu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 --- Comment #70 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 12558 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12558&action=edit Bug 7621: Follow up to clarify preference language This patch changes strings only, not functionality. It will clarify the meaning of the AgeRestrictionMarker preference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 16:27:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 14:27:01 +0000 Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title with borrower's age without using categories In-Reply-To: <bug-7621-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7621-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7621-70-LhpalCGTNt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 16:27:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 14:27:19 +0000 Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title with borrower's age without using categories In-Reply-To: <bug-7621-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7621-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7621-70-wVlJAMU6FJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #71 from Nicole C. Engard <nengard at gmail.com> --- Follow up needs sign off. Original is already in master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 16:29:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 14:29:47 +0000 Subject: [Koha-bugs] [Bug 8836] New: Resurrect Rotating Collections Message-ID: <bug-8836-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 Priority: P5 - low Change sponsored?: --- Bug ID: 8836 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: Resurrect Rotating Collections Severity: enhancement Classification: Unclassified OS: All Reporter: kyle at bywatersolutions.com Hardware: All Status: NEW Version: master Component: Circulation Product: Koha I think it's time to bring back the Rotating Collections feature. The security issue related to it was fixed, but the feature was never re-enabled. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 16:30:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 14:30:25 +0000 Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title with borrower's age without using categories In-Reply-To: <bug-7621-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7621-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7621-70-c4fzgoXoy0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12558|0 |1 is obsolete| | --- Comment #72 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 12559 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12559&action=edit Bug 7621: Follow up to clarify preference language This patch changes strings only, not functionality. It will clarify the meaning of the AgeRestrictionMarker preference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 16:31:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 14:31:00 +0000 Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title with borrower's age without using categories In-Reply-To: <bug-7621-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7621-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7621-70-Fr0LPxgoSE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 --- Comment #73 from Nicole C. Engard <nengard at gmail.com> --- My last patch had typos. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 16:36:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 14:36:36 +0000 Subject: [Koha-bugs] [Bug 8836] Resurrect Rotating Collections In-Reply-To: <bug-8836-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8836-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8836-70-gZbsJG8NbY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 Magnus Enger <magnus at enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no --- Comment #1 from Magnus Enger <magnus at enger.priv.no> --- Some relevant links: Initial commit adding the feature in January 2010: http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=f650aad34b00da6fd44d974b04975b2987cdaaef Fixed: Bug 6653 - [security] Rotating collections pages can be accessed without being logged in See relevant comments at the bottom here: http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=circ/returns.pl;hb=HEAD#l615 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 16:40:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 14:40:10 +0000 Subject: [Koha-bugs] [Bug 8836] Resurrect Rotating Collections In-Reply-To: <bug-8836-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8836-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8836-70-FL39BSoZ4i@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12560 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12560&action=edit Bug 8836 - Resurrect Rotating Collections -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 16:40:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 14:40:24 +0000 Subject: [Koha-bugs] [Bug 8836] Resurrect Rotating Collections In-Reply-To: <bug-8836-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8836-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8836-70-c0GPgzp8NI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 16:40:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 14:40:31 +0000 Subject: [Koha-bugs] [Bug 8836] Resurrect Rotating Collections In-Reply-To: <bug-8836-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8836-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8836-70-CjcYuQvSje@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 16:52:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 14:52:00 +0000 Subject: [Koha-bugs] [Bug 3387] WITHDRAWN items shouldn't check in In-Reply-To: <bug-3387-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3387-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3387-70-I8bKMJr0ZS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3387 --- Comment #26 from Paul Poulain <paul.poulain at biblibre.com> --- (In reply to comment #24) > Withdrawn means that you're removing it from your collection - also referred > to as Weeding. This should only happen with items that are not checked out > (as Kyle said). Worst case if you accidentally mark something withdrawn and > it's still checked out you can always just edit the item and remove the > withdrawn status before checking the item back in. > > Nicole In this case, shouldn't we instead just update the behaviour and set back to enable check-in of a withdrawn book ? Wasn't the initial report wrong when mcoalwell was saying we should not enable check-in of lost items ? (IE: no need of a new syspref) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 16:53:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 14:53:28 +0000 Subject: [Koha-bugs] [Bug 3387] WITHDRAWN items shouldn't check in In-Reply-To: <bug-3387-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3387-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3387-70-u8pawK5Cua@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3387 --- Comment #27 from Mickey Coalwell <mcoalwell at nekls.org> --- Kyle, Nicole and Jared, I'm sorry, I disagree with you concerning the meaning/purpose of WITHDRAWN. It is not exclusively for weeded items, nor for items that are not checked out. If you will go back to the first post in this bug, you'll see I described the situation where one of our libraries uses WITHDRAWN quite legitimately as a means of preventing LOST materials over x months overdue to be checked in and credited once a replacement fee has been applied. This is a policy decision made by the library that items unreturned after x months will not be accepted. Paul's point is correct. A patron who ays for a WITHDRAWN item will indeed display it on their account "forever," -- and that is the library's intent. Does that make sense? I think we all agree that nothing needs to be done in terms of the fix's current functionality, however. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 16:57:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 14:57:06 +0000 Subject: [Koha-bugs] [Bug 8837] New: Dewey cn_sort inaccurate Message-ID: <bug-8837-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8837 Priority: P5 - low Change sponsored?: --- Bug ID: 8837 CC: m.de.rooy at rijksmuseum.nl Assignee: gmcharlt at gmail.com Summary: Dewey cn_sort inaccurate Severity: normal Classification: Unclassified OS: All Reporter: joy at bywatersolutions.com Hardware: All Status: NEW Version: rel_3_8 Component: Cataloging Product: Koha The items.cn_sort value created by the Dewey.pm does not create accurate sorting (cn_sort) values. Example 1: Three similar callnumbers do not sort the same way . Suggested fix is to replace / with spaces. (note: if any token[$i] consists of only one space when sort routine progresses it should be disregarded/removed) +--------------------------+--------------------------------+ | itemcallnumber | cn_sort | +--------------------------+--------------------------------+ | 971/P23w/v.1-2/pt.8 | 971P23WV_000000000000000_12PT_ | | 971.01/P23w/v.1-2/pt.6-7 | 971_000000000000000_01P23WV_12 | | 971.01/P23w/v.1-2/pt.7 | 971_01P23WV_12PT_7000000000000 | +--------------------------+--------------------------------+ That would improve the cn_sort values: Manually replaced '/' with spaces in items.itemcallnumber to illustrate that process. +--------------------------+--------------------------------+ | itemcallnumber | cn_sort | +--------------------------+--------------------------------+ | 971.01 P23w v.1-2 pt.6-7 | 971_010000000000000_P23W_V_12_ | | 971.01 P23w v.1-2 pt.7 | 971_010000000000000_P23W_V_12_ | | 971 P23w v.1-2 pt.8 | 971_P23W_V_12_PT_8000000000000 | +--------------------------+--------------------------------+ However, the sort routine will adjust the second 'token' it finds that is all digit. In the above case it is in the last callnumber (the 8) which is padded. A better option would be to only adjust the only adjust the second 'token' if it is the second token. Further if there are two token and the second token is not $token[2] then pad the first token with _zeros An ideal result would be: +--------------------------+--------------------------------+ | itemcallnumber | cn_sort | +--------------------------+--------------------------------+ | 971 P23w v.1-2 pt.8 | 971_000000000000000_P23W_V_12_ | | 971.01 P23w v.1-2 pt.6-7 | 971_010000000000000_P23W_V_12_ | | 971.01 P23w v.1-2 pt.7 | 971_010000000000000_P23W_V_12_ | +--------------------------+--------------------------------+ note: 30 character limit does chop the rest of the cn_sort. Without an update to the database, this will be 'collateral damage'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 17:06:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 15:06:40 +0000 Subject: [Koha-bugs] [Bug 8838] New: Digest option for HOLD FILLED notice? Message-ID: <bug-8838-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8838 Priority: P5 - low Change sponsored?: --- Bug ID: 8838 Assignee: koha-bugs at lists.koha-community.org Summary: Digest option for HOLD FILLED notice? Severity: enhancement Classification: Unclassified OS: All Reporter: mcoalwell at nekls.org Hardware: All Status: NEW Version: rel_3_6 Component: Notices Product: Koha Is there a way to set Koha to only send one email to a patron when they have several items on hold instead of one email for each item? We've had a couple of patrons ask and 12 emails put a patron over her email inbox quota. Thanks, Erica Voell Bonner Springs City Library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 17:12:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 15:12:12 +0000 Subject: [Koha-bugs] [Bug 3387] WITHDRAWN items shouldn't check in In-Reply-To: <bug-3387-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3387-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3387-70-aIhYDUl2gJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3387 --- Comment #28 from Kyle M Hall <kyle at bywatersolutions.com> --- > In this case, shouldn't we instead just update the behaviour and set back to > enable check-in of a withdrawn book ? What everyone wants is to *not* allow checking in of withdrawn books. > Wasn't the initial report wrong when mcoalwell was saying we should not > enable check-in of lost items ? > (IE: no need of a new syspref) I cannot speak to what mcoalwell meant, but I can say that the consensus is that the correct behavior is to disallow checking in or withdrawn items. That includes me, Nicole and Jared. Mickey, while disagreeing on one point with us, is also agreeing that withdrawn items should not be returnable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 17:12:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 15:12:40 +0000 Subject: [Koha-bugs] [Bug 6716] Database Documentation In-Reply-To: <bug-6716-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6716-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6716-70-ux6FkRJfV3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6716 --- Comment #132 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 12561 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12561&action=edit Bug 6716: Update biblioitems tables This patch documents the cn_sort and agerestriction fields in the biblioitems and deletedbiblioitems tables. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 17:18:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 15:18:04 +0000 Subject: [Koha-bugs] [Bug 8831] gstrate should say 'Tax rate' In-Reply-To: <bug-8831-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8831-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8831-70-tDzom6GW3y@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8831 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 17:24:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 15:24:45 +0000 Subject: [Koha-bugs] [Bug 8839] New: Independant Branches - Checkout to patron belonging to another branch Message-ID: <bug-8839-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8839 Priority: P5 - low Change sponsored?: --- Bug ID: 8839 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: Independant Branches - Checkout to patron belonging to another branch Severity: enhancement Classification: Unclassified OS: All Reporter: kyle at bywatersolutions.com Hardware: All Status: NEW Version: master Component: Circulation Product: Koha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 17:27:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 15:27:24 +0000 Subject: [Koha-bugs] [Bug 8839] Independant Branches - Checkout to patron belonging to another branch In-Reply-To: <bug-8839-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8839-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8839-70-F8n53NMdgH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8839 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Some libraries want to use the IndependantBranches feature to prevent libraries from editing each other's patron records while still allowing any library to issue items to another library's patrons. It appears that this behavior may have been standard in some previous versions of Koha, but is currently not. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 17:29:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 15:29:26 +0000 Subject: [Koha-bugs] [Bug 8839] Independant Branches - Checkout to patron belonging to another branch In-Reply-To: <bug-8839-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8839-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8839-70-NBkMbChvhy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8839 --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12562 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12562&action=edit Bug 8839 - Independant Branches - Checkout to patron belonging to another branch Adds the new system preference IndependantBranchesPreventIssuing to control whether IndependantBranches stops one branch from viewing the patron record or issuing items to a patron from a different library. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 17:29:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 15:29:57 +0000 Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title with borrower's age without using categories In-Reply-To: <bug-7621-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7621-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7621-70-ZDijLo5FHj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12559|0 |1 is obsolete| | --- Comment #74 from Marc V?ron <veron at veron.ch> --- Created attachment 12563 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12563&action=edit [SIGNED-OFF] Bug 7621: Follow up to clarify preference language This patch changes strings only, not functionality. It will clarify the meaning of the AgeRestrictionMarker preference. Signed-off-by: Marc Veron <veron at veron.ch> Better wording of preference instructions. No code echange involved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 17:30:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 15:30:01 +0000 Subject: [Koha-bugs] [Bug 8839] Independant Branches - Checkout to patron belonging to another branch In-Reply-To: <bug-8839-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8839-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8839-70-F5XPTx9j7U@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8839 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 17:36:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 15:36:02 +0000 Subject: [Koha-bugs] [Bug 8839] Independant Branches - Checkout to patron belonging to another branch In-Reply-To: <bug-8839-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8839-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8839-70-LV5sW7E5nv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8839 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 17:37:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 15:37:23 +0000 Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title with borrower's age without using categories In-Reply-To: <bug-7621-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7621-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7621-70-Nex8BEnRqS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 18:01:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 16:01:25 +0000 Subject: [Koha-bugs] [Bug 8686] author search in staff missing checkboxes and menu In-Reply-To: <bug-8686-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8686-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8686-70-oIM9WsVQC9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8686 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|INVALID |--- --- Comment #3 from Nicole C. Engard <nengard at gmail.com> --- Okay it's happening again. cgi-bin/koha/catalogue/search.pl?q=au:"Tepper, Sheri S." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 18:01:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 16:01:45 +0000 Subject: [Koha-bugs] [Bug 8686] author search in staff missing checkboxes and menu In-Reply-To: <bug-8686-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8686-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8686-70-14vRNj9ut7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8686 --- Comment #4 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 12564 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12564&action=edit no check boxes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 18:04:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 16:04:56 +0000 Subject: [Koha-bugs] [Bug 8686] author search in staff missing checkboxes and menu In-Reply-To: <bug-8686-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8686-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8686-70-1K12znxGcq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8686 --- Comment #5 from Nicole C. Engard <nengard at gmail.com> --- That link by the way came from me clicking an author name on a bib record - not by searching for an author via the search screen. If I search from the search box it shows the checkboxes. But the URL is different. cgi-bin/koha/catalogue/search.pl?idx=au%2Cphr&q=tepper%2C+sheri+s.&op=and&idx=kw&op=and&idx=kw&sort_by=relevance So the problem is with the author link on bib records in the staff client. Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 18:06:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 16:06:20 +0000 Subject: [Koha-bugs] [Bug 8686] author search in staff missing checkboxes and menu In-Reply-To: <bug-8686-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8686-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8686-70-RqAUche2Pz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8686 --- Comment #6 from Nicole C. Engard <nengard at gmail.com> --- Also if you click the author name on a bib record on the search results you get the same result. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 18:17:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 16:17:33 +0000 Subject: [Koha-bugs] [Bug 8840] New: ubuntu-pkg-check.sh script doesn't work on non englush setups Message-ID: <bug-8840-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 Priority: P5 - low Change sponsored?: --- Bug ID: 8840 Assignee: gmcharlt at gmail.com Summary: ubuntu-pkg-check.sh script doesn't work on non englush setups Severity: normal Classification: Unclassified OS: All Reporter: tomascohen at gmail.com Hardware: All Status: NEW Version: master Component: Command-line Utilities Product: Koha The script queries for the 'Installed:' string, which only appears on english setups. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 18:19:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 16:19:07 +0000 Subject: [Koha-bugs] [Bug 8840] ubuntu-pkg-check.sh script doesn't work on non-english setups In-Reply-To: <bug-8840-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8840-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8840-70-6vCEm6fzPc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Summary|ubuntu-pkg-check.sh script |ubuntu-pkg-check.sh script |doesn't work on non englush |doesn't work on non-english |setups |setups -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 18:33:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 16:33:07 +0000 Subject: [Koha-bugs] [Bug 8262] Special kohaadmin cannot create lists In-Reply-To: <bug-8262-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8262-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8262-70-1EAMRxjax5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8262 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #4 from Marc V?ron <veron at veron.ch> --- Marcel, Your patch would address Paul P.'s comment to following bug: Bug 8641 - Add information warning about log-in as root user to About->System information (Pushed to Master) See: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8641#c4 Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 18:34:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 16:34:24 +0000 Subject: [Koha-bugs] [Bug 8641] Add information warning about log-in as root user to About->System information In-Reply-To: <bug-8641-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8641-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8641-70-wdDnCqDiy9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8641 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8262 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 18:34:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 16:34:24 +0000 Subject: [Koha-bugs] [Bug 8262] Special kohaadmin cannot create lists In-Reply-To: <bug-8262-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8262-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8262-70-RbyBz4H4O4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8262 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8641 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 19:54:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 17:54:37 +0000 Subject: [Koha-bugs] [Bug 8523] Authority hierarchies only support UNIMARC In-Reply-To: <bug-8523-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8523-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8523-70-97acpE5e5V@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8523 --- Comment #23 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 12565 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12565&action=edit looks different I'm trying to document this feature and have an authority with 500s on it (and I have the authorities for those 500s) but I'm not seeing anything but the one heading. Can you please give me an example of what to enter (a link to a LOC authority is fine) to see this in action on my system in Marc21? Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 20:05:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 18:05:03 +0000 Subject: [Koha-bugs] [Bug 8840] ubuntu-pkg-check.sh script doesn't work on non-english setups In-Reply-To: <bug-8840-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8840-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8840-70-tgkf6B68zq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 --- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 12566 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12566&action=edit Bug 8840 - ubuntu-pkg-check.sh script doesn't work on non englush setups Using dpkg -s to query for installed packages works in languages other than english. Added some switches (and checks for them) too. Sponsored-by: Universidad Nacional de C?rdoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Sep 27 20:13:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 27 Sep 2012 18:13:15 +0000 Subject: [Koha-bugs] [Bug 8840] ubuntu-pkg-check.sh script doesn't work on non-english setups In-Reply-To: <bug-8840-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8840-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8840-70-EksBaMZAs4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 08:02:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 06:02:54 +0000 Subject: [Koha-bugs] [Bug 8058] Circulation empty barcode field redirect to pay fines screen if borrower has outstanding fines In-Reply-To: <bug-8058-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8058-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8058-70-qRBp97DdI2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058 Chris Hall <chrish at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10531|0 |1 is obsolete| | --- Comment #15 from Chris Hall <chrish at catalyst.net.nz> --- Created attachment 12567 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12567&action=edit Fixed error in redirecting when user had positive balance Sorry for the delay in getting this up here. I have fixed the issue Marc pointed out regarding, redirecting if the user had a positive balance. I will look in to your comments about QuickAutoPrintQuickSlip as I agree that behaviour shouldn't change. Which of these is preferable for QuickAutoPrintQuickSlip: - add in 2), so have 3 options - remove option 3 and add option 2 back in, so only have options 1) and 2) ~ Chris Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 08:03:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 06:03:51 +0000 Subject: [Koha-bugs] [Bug 8058] Circulation empty barcode field redirect to pay fines screen if borrower has outstanding fines In-Reply-To: <bug-8058-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8058-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8058-70-tZGx3WdUZU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058 Chris Hall <chrish at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 09:32:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 07:32:44 +0000 Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8015-70-Z6gLKgdqTd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #16 from delaye <stephane.delaye at biblibre.com> --- i want test the new patch in a sandbox but i have this message Applying: Bug 8015 - Add MARC Modifications Templates Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/ImportBatch.pm CONFLICT (content): Merge conflict in C4/ImportBatch.pm Auto-merging C4/Koha.pm Auto-merging installer/data/mysql/en/mandatory/userpermissions.sql Auto-merging installer/data/mysql/kohastructure.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/stage-marc-import.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt Auto-merging tools/stage-marc-import.pl CONFLICT (content): Merge conflict in tools/stage-marc-import.pl Failed to merge in the changes. Patch failed at 0001 Bug 8015 - Add MARC Modifications Templates When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Bug 8015 - Add MARC Modifications Templates Bug 8015 - Add MARC Modifications Templates Apply? [yn] Patch left in /tmp/Bug-8015---Add-MARC-Modifications-Templates-42bN43.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 10:36:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 08:36:29 +0000 Subject: [Koha-bugs] [Bug 8058] Circulation empty barcode field redirect to pay fines screen if borrower has outstanding fines In-Reply-To: <bug-8058-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8058-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8058-70-s73cUzRxoa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058 --- Comment #16 from Marc V?ron <veron at veron.ch> --- Chris, I think we should have an additional option for CircAutoPrintQuickSlip: - Open a print quick slip window and clear the screen ---- The overall behaviour triggered by hitting an empty barcode field would be: Use case 1): Patron has no outstanding fines - Independent of Case CircPayFinesRedirect: - Case CircAutoPrintQuickSlip = Clear the screen => Clear the screen - Case CircAutoPrintQuickSlip = Open a print quick slip window => Print, when print is done go back to the borrowers screen (as is) - Case Open a print quick slip window and clear the screen => Print, when print is done go back to the borrowers screen and clear it Use case 2): Patron has outstanding fines - Case CircPayFinesRedirect is off - do the same as above - Case CircPayFinesRedirect is on - Case CircAutoPrintQuickSlip = Clear the screen => Open the pay fines screen. (When done go back to the borrowers screen.) - Case CircAutoPrintQuickSlip = Open a print quick slip window => Print. Open the pay fines screen. (When done go back to the borrowers screen.) - Case Open a print quick slip window and clear the screen => Print. Open the pay fines screen. (When done go back to the borrowers screen.) What do you think about? Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 12:01:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 10:01:03 +0000 Subject: [Koha-bugs] [Bug 3387] WITHDRAWN items shouldn't check in In-Reply-To: <bug-3387-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3387-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3387-70-LmFJTW1Qd0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3387 --- Comment #29 from Paul Poulain <paul.poulain at biblibre.com> --- (In reply to comment #27) > Does that make sense? I think we all agree that nothing needs to be done in > terms of the fix's current functionality, however. (In reply to comment #28) > What everyone wants is to *not* allow checking in of withdrawn books. mmm... Sorry guys, but I don't understand: if the behaviour we want it NOT allowing checkin-g of withdrawn items is this patch needed ? ( because it adds a syspref to enable check-in of withdrawn items) /me really confused... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 12:17:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 10:17:03 +0000 Subject: [Koha-bugs] [Bug 8449] Improve wording and styling for "cancelled holds" on Holds Awaiting Pickup screen In-Reply-To: <bug-8449-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8449-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8449-70-ZsBlCb71YL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8449 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #6 from Paul Poulain <paul.poulain at biblibre.com> --- Question: Owen, you replace: - <p>This hold placed <snip> at the library : <b> [% branchname %] </b>, Please transfer this hold. by + Please retain this item and check it in to process the hold. IE: you loose the information of the branch you must transfer it to. Was it intended ? Woudln't it be better to have + <h2>This item is on hold for pick-up at another library ([% branchname %])</h2> or something like that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 12:47:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 10:47:14 +0000 Subject: [Koha-bugs] [Bug 8841] New: Duedates set by Returnbeforeexpiry lack HH:MM Message-ID: <bug-8841-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8841 Priority: P5 - low Change sponsored?: --- Bug ID: 8841 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: Duedates set by Returnbeforeexpiry lack HH:MM Severity: enhancement Classification: Unclassified OS: All Reporter: colin.campbell at ptfs-europe.com Hardware: All Status: NEW Version: master Component: Circulation Product: Koha The 'Return before expiry' syspref sets the issue duedate to the patrons expiry date. It is setting the HH:MM element to 00:00 as the expiry date lacks a time element. It should set it to the end of the patron's expiration date -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 13:45:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 11:45:49 +0000 Subject: [Koha-bugs] [Bug 8841] Duedates set by Returnbeforeexpiry lack HH:MM In-Reply-To: <bug-8841-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8841-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8841-70-eiHhm8Y8bs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8841 Colin Campbell <colin.campbell at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |colin.campbell at ptfs-europe. |ity.org |com --- Comment #1 from Colin Campbell <colin.campbell at ptfs-europe.com> --- Created attachment 12568 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12568&action=edit Proposed Patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 14:08:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 12:08:20 +0000 Subject: [Koha-bugs] [Bug 8838] Digest option for HOLD FILLED notice? In-Reply-To: <bug-8838-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8838-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8838-70-S5iNR21OqI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8838 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|rel_3_6 |master --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Mickey, there is currently no way to do a digest for hold notices. I think the idea is to let patrons know as fast as possible about holds being ready for pickup. I am not sure how a digest could work here. Maybe by circulation session? Summarize hold notices for a certain amount of time? I am not sure how hard it would be to implement something like this. I am resetting the version to master, because this is an enhancement request for a future version. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 14:18:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 12:18:57 +0000 Subject: [Koha-bugs] [Bug 8832] can't enter a tax rate on vendor or when ordering In-Reply-To: <bug-8832-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8832-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8832-70-YdJ4TMxdlX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8832 --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Paul, sorry for being confusing. I think there are different things to think about here: 1) If the system preference is empty, the tax information and configuration fields should be hidden from display. There are libraries which don't want to use the feature and it worked like this before - so it's a regression for them. 2) We need a good update path for libraries. If we require now a list of values the update has to take care of that and prefill the list. From Nicole's description with the pull down I think that at the moment if you update your vendor the tax value will be lost if the value is not in the gist system preference. I didn't really test the feature yet, so this is mostly based on looking at the code and on the descriptions from others. Hope I am not too far off. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 14:23:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 12:23:44 +0000 Subject: [Koha-bugs] [Bug 3387] WITHDRAWN items shouldn't check in In-Reply-To: <bug-3387-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3387-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3387-70-5oxxOSakcy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3387 --- Comment #30 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to comment #29) > (In reply to comment #27) > > Does that make sense? I think we all agree that nothing needs to be done in > > terms of the fix's current functionality, however. > > (In reply to comment #28) > > What everyone wants is to *not* allow checking in of withdrawn books. > > mmm... Sorry guys, but I don't understand: if the behaviour we want it NOT > allowing checkin-g of withdrawn items is this patch needed ? ( because it > adds a syspref to enable check-in of withdrawn items) > > /me really confused... I added the system preference so we can leave the default behavior unchanged, as is common practice. I can add a followup to remove the choice if you wish. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 14:28:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 12:28:37 +0000 Subject: [Koha-bugs] [Bug 8832] can't enter a tax rate on vendor or when ordering In-Reply-To: <bug-8832-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8832-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8832-70-u6w6t3s9LY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8832 --- Comment #12 from Paul Poulain <paul.poulain at biblibre.com> --- (In reply to comment #11) > 1) If the system preference is empty, the tax information and configuration > fields should be hidden from display. There are libraries which don't want > to use the feature and it worked like this before - so it's a regression for > them. OK, I hesitated between "display that the syspref is empty" or "ignore the gst". I think that libraries that want a gst will complain that there's none ( ;-) ) so OK with hiding the gst for libraries that have the syspref empty. follow-up easy to do. Will do it quickly (Jonathan is afk for 2 more week) > 2) We need a good update path for libraries. If we require now a list of > values the update has to take care of that and prefill the list. From > Nicole's description with the pull down I think that at the moment if you > update your vendor the tax value will be lost if the value is not in the > gist system preference. yes, that's why i'm proposing to fill it automatically with all distinct values that exist in aqbooksellers before the update. > I didn't really test the feature yet, so this is mostly based on looking at > the code and on the descriptions from others. Hope I am not too far off. not too far, and agreeing with my proposal, so it's fine ;-) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 14:35:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 12:35:36 +0000 Subject: [Koha-bugs] [Bug 8832] can't enter a tax rate on vendor or when ordering In-Reply-To: <bug-8832-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8832-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8832-70-RJcFJGSPQe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8832 --- Comment #13 from Nicole C. Engard <nengard at gmail.com> --- (In reply to comment #12) >so OK with hiding the gst for libraries that have the syspref empty. +1, also if the pref is 0 (as mine was) it should either hide the tax fields or it should be changed to empty. At one point 0 was the default we were supposed to have in there to hide the tax fields. > yes, that's why i'm proposing to fill it automatically with all distinct > values that exist in aqbooksellers before the update. That would be a nice option, that way people don't lose the settings they have in place already. Nicole -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 14:40:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 12:40:22 +0000 Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8015-70-OJioZI1vPJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10089|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12569 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12569&action=edit Bug 8015 - Add MARC Modifications Templates The MARC Modification Templates system gives Koha users the power to make alterations to MARC records automatically while staging MARC records for import. This tool is useful for altering MARC records from various venders work with your MARC framework. The system essentially allows one to create a basic script using actions to Copy, Move, Add, Update and Delete fields. Each action can also have an optional condition to check the value or existance of another field. The Copy & Move actions also support Regular Expressions, which can be used to automatically modify field values during the copy/move. An example would be to strip out the '$' character in field 020$c. Furthermore, the value for an update can include variables that change each time the template is used. Currently, the system supports two variables, __BRANCHCODE__ which is replaced with the branchcode of the library currently using the template, and __CURRENTDATE__ which is replaced with the current date in ISO format ( YYYY-MM-DD ). At its simplist, it can perform functions such as: Copy field 092$a to 952$c At its most complex it can run actions like: Copy field 020$c to 020$c using RegEx s/\$// if 020$c equals RegEx m/^\$/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 14:40:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 12:40:47 +0000 Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8015-70-mIfAUjBmAC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11608|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12570 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12570&action=edit [SIGNED-OFF] Bug 8015: Followup: FIX cp and mv if subfields don't exist. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 14:41:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 12:41:05 +0000 Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8015-70-54p2B5eRpM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12288|0 |1 is obsolete| | --- Comment #19 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12571 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12571&action=edit [SIGNED-OFF] Bug 8015: Followup: On move, we cant delete existing fields Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 14:41:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 12:41:14 +0000 Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8015-70-HO0P7mFNL6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #20 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12572 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12572&action=edit Bug 8015 - Add MARC Modifications Templates - Followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 14:41:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 12:41:51 +0000 Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8015-70-BS7aNeVH84@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #21 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to comment #16) > i want test the new patch in a sandbox but i have this message The patches needed a rebase. You should be able to test it now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 14:45:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 12:45:18 +0000 Subject: [Koha-bugs] [Bug 8796] patron cards not starting on designated card In-Reply-To: <bug-8796-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8796-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8796-70-5mOUFgVSWM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12573 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12573&action=edit [SIGNED-OFF] Bug 8796 - patron cards not starting on designated card Better wording for the meaning of 'Position' to prevent mistakes on behaviour. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 14:45:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 12:45:33 +0000 Subject: [Koha-bugs] [Bug 8796] patron cards not starting on designated card In-Reply-To: <bug-8796-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8796-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8796-70-P7uQ2UHnp9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12487|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 14:45:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 12:45:38 +0000 Subject: [Koha-bugs] [Bug 8796] patron cards not starting on designated card In-Reply-To: <bug-8796-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8796-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8796-70-GfT7R9hE4H@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 14:55:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 12:55:40 +0000 Subject: [Koha-bugs] [Bug 8623] Javascript libraries should be outside theme directories In-Reply-To: <bug-8623-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8623-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8623-70-dtKgWmzSab@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8623 --- Comment #17 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12574 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12574&action=edit [SIGNED-OFF] Bug 8623 - Fix YUI path for OPAC in debian/rules After the changes to YUI path the build process is broken. For testing this I had to set the build process to ommit the tests as there are some db_dependent test being called (which failed). To do this I ran the build script like this: sudo DEB_BUILD_OPTIONS=nocheck ./debian/build-git-snapshot -distribution precise -D precise -r ~/ubuntu -v 3.9.0-046~git -d Note: Even when this is fixed, there are still issues with some files missing dh_install: etc/koha/searchengine/solr/config.yaml exists in debian/tmp but is not installed to anywhere dh_install: etc/koha/searchengine/solr/indexes.yaml exists in debian/tmp but is not installed to anywhere dh_install: etc/koha/solr/indexes.yaml exists in debian/tmp but is not installed to anywhere dh_install: missing files, aborting make: *** [binary] Error 2 dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit status 2 Sponsored-by: Universidad Nacional de C?rdoba Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com> Please note that debian/rules *must* use tabs. If you have a git hook that automatically replaces tabs with spaces, please undo those changes. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 14:56:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 12:56:00 +0000 Subject: [Koha-bugs] [Bug 8623] Javascript libraries should be outside theme directories In-Reply-To: <bug-8623-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8623-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8623-70-dsu685BcfF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8623 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12554|0 |1 is obsolete| | Attachment #12555|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12575 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12575&action=edit [SIGNED-OFF] Bug 8623 follow-up: make sure CCSR theme loads YUI Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 14:56:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 12:56:11 +0000 Subject: [Koha-bugs] [Bug 8623] Javascript libraries should be outside theme directories In-Reply-To: <bug-8623-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8623-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8623-70-ryPJmUQXHa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8623 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 14:57:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 12:57:07 +0000 Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8015-70-4XRfRrWpuS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #22 from delaye <stephane.delaye at biblibre.com> --- After apply the patch in a sand box i have this message Software error: Can't locate Koha/MarcModificationTemplates.pm in @INC (@INC contains: /home/koha/src /etc/perl /usr/local/lib/perl/5.10.1 /usr/local/share/perl/5.10.1 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.10 /usr/share/perl/5.10 /usr/local/lib/site_perl .) at /home/koha/src/C4/ImportBatch.pm line 29. BEGIN failed--compilation aborted at /home/koha/src/C4/ImportBatch.pm line 29. Compilation failed in require at /home/koha/src/tools/stage-marc-import.pl line 40. BEGIN failed--compilation aborted at /home/koha/src/tools/stage-marc-import.pl line 40. from the url .../cgi-bin/koha/tools/stage-marc-import.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 14:57:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 12:57:58 +0000 Subject: [Koha-bugs] [Bug 8481] Items table is showing in opac-MARCdetail.pl but not in MARCdetail.pl In-Reply-To: <bug-8481-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8481-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8481-70-LfwMy9hBgC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8481 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12531|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12576 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12576&action=edit [SIGNED-OFF] Bug 8481: Items table is showing in opac-MARCdetail.pl but not in MARCdetail.pl Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 14:58:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 12:58:13 +0000 Subject: [Koha-bugs] [Bug 8481] Items table is showing in opac-MARCdetail.pl but not in MARCdetail.pl In-Reply-To: <bug-8481-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8481-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8481-70-j1NfeBjSYU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8481 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 15:00:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 13:00:42 +0000 Subject: [Koha-bugs] [Bug 7643] Can't upload and import zipped file of patron images In-Reply-To: <bug-7643-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7643-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7643-70-PpMe0ByhuY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7643 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12503|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12577 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12577&action=edit [SIGNED-OFF] Bug 7643 - Can't upload and import zipped file of patron images Fixed problem with re-declaration of $filesuffix Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 15:00:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 13:00:51 +0000 Subject: [Koha-bugs] [Bug 7643] Can't upload and import zipped file of patron images In-Reply-To: <bug-7643-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7643-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7643-70-2OZcQpEFyD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7643 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 15:01:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 13:01:40 +0000 Subject: [Koha-bugs] [Bug 7351] ability to edit a range of holidays In-Reply-To: <bug-7351-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7351-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7351-70-nZdTqgyuaU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 --- Comment #47 from Paul Poulain <paul.poulain at biblibre.com> --- Works like a charm. However, i've discovered some problems under plack, i'll open another bug for that. Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 15:04:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 13:04:56 +0000 Subject: [Koha-bugs] [Bug 8841] Duedates set by Returnbeforeexpiry lack HH:MM In-Reply-To: <bug-8841-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8841-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8841-70-X6NtQbIzYc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8841 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12568|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12578 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12578&action=edit [SIGNED-OFF] Bug 8841 Duedate should be set to end of expiry day When reducing duedate to patron's expiry date it should be set to end of that day not 00:00 take account of the fact that the borrower expiry date will have no hours/minutes Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 15:06:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 13:06:08 +0000 Subject: [Koha-bugs] [Bug 8042] Batch numbers aren't committed as used until an item is added In-Reply-To: <bug-8042-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8042-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8042-70-UBvKvqJSzY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8042 e-Libris Technologies <elibris.helpdesk at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |elibris.helpdesk at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 15:09:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 13:09:02 +0000 Subject: [Koha-bugs] [Bug 8766] OPACBaseURL still called as OPACBaseurl in many files In-Reply-To: <bug-8766-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8766-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8766-70-pMzRaFNe5S@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8766 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12486|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12579 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12579&action=edit [SIGNED-OFF] Bug 8766 - OPACBaseURL still called as OPACBaseurl in many files This patch fixes incorrect capitalization of the OPACBaseURL variable in three templates. The fix can be confirmed in opac-results.tt by inspecting the link attached to the RSS icon on the OPAC's search results screen. The same fix is included in opac-opensearch.tt and search/results.tt but I'm not sure how you confirm that this change fixes anything, if it does. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 15:11:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 13:11:12 +0000 Subject: [Koha-bugs] [Bug 8812] Staff Client: Patron search should display branch name instead of branch code in results table In-Reply-To: <bug-8812-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8812-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8812-70-abYjv5s8lY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8812 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.poulain at biblibre.com --- Comment #2 from Paul Poulain <paul.poulain at biblibre.com> --- Patch tested with a sandbox, by Delaye Stephane <stephane.delaye at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 15:11:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 13:11:25 +0000 Subject: [Koha-bugs] [Bug 8812] Staff Client: Patron search should display branch name instead of branch code in results table In-Reply-To: <bug-8812-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8812-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8812-70-n9r5kBAeSo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8812 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12479|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 15:11:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 13:11:30 +0000 Subject: [Koha-bugs] [Bug 8812] Staff Client: Patron search should display branch name instead of branch code in results table In-Reply-To: <bug-8812-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8812-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8812-70-uxzoZWDdxF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8812 --- Comment #3 from Paul Poulain <paul.poulain at biblibre.com> --- Created attachment 12580 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12580&action=edit Bug 8812 - Staff Client: Patron search should display branch name instead of branch code in results table Patch to display branchname instead of branch code. Signed-off-by: Delaye Stephane <stephane.delaye at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 15:12:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 13:12:34 +0000 Subject: [Koha-bugs] [Bug 8766] OPACBaseURL still called as OPACBaseurl in many files In-Reply-To: <bug-8766-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8766-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8766-70-xXQxzss5yE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8766 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle at bywatersolutions.com --- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> --- OPACBaseURL is set by get_template_and_user so having a script in the opac directory set it as well is superfluous, but not harmful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 15:13:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 13:13:34 +0000 Subject: [Koha-bugs] [Bug 8841] Duedates set by Returnbeforeexpiry lack HH:MM In-Reply-To: <bug-8841-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8841-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8841-70-GUk6uHE5ze@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8841 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 15:13:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 13:13:58 +0000 Subject: [Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off In-Reply-To: <bug-8462-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8462-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8462-70-ETmJQD2M85@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |nengard at gmail.com --- Comment #7 from Nicole C. Engard <nengard at gmail.com> --- I would like to sign off on this because this is confusing. But the patch doesn't apply: Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 8462: OpacHiddenItems and hidelostitems hide items, but query result count is off Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Search.pm CONFLICT (content): Merge conflict in C4/Search.pm Failed to merge in the changes. Patch failed at 0001 Bug 8462: OpacHiddenItems and hidelostitems hide items, but query result count is off When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". nengard at kohavm:~/kohaclone$ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 15:15:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 13:15:25 +0000 Subject: [Koha-bugs] [Bug 8842] New: Plack and tools/holidays.pl Message-ID: <bug-8842-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8842 Priority: P5 - low Change sponsored?: --- Bug ID: 8842 CC: dpavlin at rot13.org Assignee: christophe.croullebois at biblibre.com Summary: Plack and tools/holidays.pl Severity: critical Classification: Unclassified OS: All Reporter: paul.poulain at biblibre.com Hardware: All Status: ASSIGNED Version: master Component: Architecture, internals, and plumbing Product: Koha Saving holidays (at least a range) does not work when you're using Plack. In the logs you see: Variable "$newoperation" is not available at /home/paul/koha.dev/koha-community/tools/newHolidays.pl line 86. Variable "$branchcode" is not available at /home/paul/koha.dev/koha-community/tools/newHolidays.pl line 86. Variable "$weekday" is not available at /home/paul/koha.dev/koha-community/tools/newHolidays.pl line 86. Variable "$day" is not available at /home/paul/koha.dev/koha-community/tools/newHolidays.pl line 86. Variable "$month" is not available at /home/paul/koha.dev/koha-community/tools/newHolidays.pl line 86. Variable "$year" is not available at /home/paul/koha.dev/koha-community/tools/newHolidays.pl line 86. Variable "$title" is not available at /home/paul/koha.dev/koha-community/tools/newHolidays.pl line 86. Variable "$description" is not available at /home/paul/koha.dev/koha-community/tools/newHolidays.pl line 86. Variable "@holiday_list" is not available at /home/paul/koha.dev/koha-community/tools/newHolidays.pl line 117. Use of uninitialized value $sessiontype in string eq at /home/paul/koha.dev/koha-community/C4/Auth.pm line 705. It means there is a sub that uses a variable that is global. When you use Plack, your script is "wrapped" into a larger sub. So all global variable become local and the $newoperation are no more available. The probable solution is to replace ($newoperation, $branchcode, $weekday, $day, $month, $year, $title, $description) = @_; by my ($newoperation, $branchcode, $weekday, $day, $month, $year, $title, $description) = @_; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 15:18:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 13:18:57 +0000 Subject: [Koha-bugs] [Bug 8826] Initialization of hash triggers error log entries. In-Reply-To: <bug-8826-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8826-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8826-70-K5lrbWjwhs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8826 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12543|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12581 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12581&action=edit Bug 8826 - Initialization of hash triggers error log entries. Changed: our %renew_failed = {}; To: our %renew_failed = (); This prevents an error log about Reference found where even-sized list expected. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 15:19:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 13:19:41 +0000 Subject: [Koha-bugs] [Bug 8826] Initialization of hash triggers error log entries. In-Reply-To: <bug-8826-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8826-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8826-70-bSujcZ7Wvp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8826 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12581|Bug 8826 - Initialization |[SIGNED-OFF] Bug 8826 - description|of hash triggers error log |Initialization of hash |entries. |triggers error log entries. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 15:20:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 13:20:23 +0000 Subject: [Koha-bugs] [Bug 8826] Initialization of hash triggers error log entries. In-Reply-To: <bug-8826-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8826-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8826-70-HjL5s451pu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8826 --- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12582 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12582&action=edit Bug 8826 - Initialization of hash triggers error log entries - Followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 15:21:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 13:21:29 +0000 Subject: [Koha-bugs] [Bug 8826] Initialization of hash triggers error log entries. In-Reply-To: <bug-8826-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8826-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8826-70-zOL71AgT5p@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8826 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 15:27:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 13:27:24 +0000 Subject: [Koha-bugs] [Bug 8733] Adding critic reviews to book pages In-Reply-To: <bug-8733-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8733-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8733-70-3dE303718b@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8733 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12501|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12583 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12583&action=edit [SIGNED-OFF] Bug 8733: Add IDreamBooks.com enhanced content Adds the following enhanced content to the OPAC, all controlled by separate sysprefs: 1) A "Readometer" which summarizes reviews on the OPAC detail page 2) A tab with snippets of critical reviews on the OPAC detail page 3) A computed rating on the results page To test: Find a book that is listed on IDreamBooks.com (you may have to make sure that you have the first edition), and one that is not. Try each of IDreamBooksReadometer, IDreamBooksReviews, and IDreamBooksResults sysprefs, taking note of the content appearing (or not) as appropriate. Updated to add missing CSS to new theme. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 15:27:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 13:27:56 +0000 Subject: [Koha-bugs] [Bug 8733] Adding critic reviews to book pages In-Reply-To: <bug-8733-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8733-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8733-70-3msPN6EI1b@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8733 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle at bywatersolutions.com --- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> --- Followed the test plan, everything looks good! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 15:28:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 13:28:11 +0000 Subject: [Koha-bugs] [Bug 8812] Staff Client: Patron search should display branch name instead of branch code in results table In-Reply-To: <bug-8812-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8812-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8812-70-UAnEVzV4js@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8812 --- Comment #4 from Paul Poulain <paul.poulain at biblibre.com> --- Patch tested with a sandbox, by Delaye Stephane <stephane.delaye at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 15:28:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 13:28:24 +0000 Subject: [Koha-bugs] [Bug 8812] Staff Client: Patron search should display branch name instead of branch code in results table In-Reply-To: <bug-8812-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8812-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8812-70-SbBem8vVA0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8812 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12580|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 15:28:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 13:28:28 +0000 Subject: [Koha-bugs] [Bug 8812] Staff Client: Patron search should display branch name instead of branch code in results table In-Reply-To: <bug-8812-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8812-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8812-70-9hqPORYsk1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8812 --- Comment #5 from Paul Poulain <paul.poulain at biblibre.com> --- Created attachment 12584 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12584&action=edit Bug 8812 - Staff Client: Patron search should display branch name instead of branch code in results table Patch to display branchname instead of branch code. Signed-off-by: Delaye Stephane <stephane.delaye at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 15:31:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 13:31:42 +0000 Subject: [Koha-bugs] [Bug 8718] Normal catalogue detail view in staff client doesn't show missing serials or subscription history note In-Reply-To: <bug-8718-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8718-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8718-70-xn2JP5Plqk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8718 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12364|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12585 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12585&action=edit Bug 8718 - Normal catalogue detail view in staff client doesn't show missing serials or subscription history note Adds librariannote (staff subscription history note) and missing list to the normal catalogue detail view in staff client. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 15:32:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 13:32:10 +0000 Subject: [Koha-bugs] [Bug 8718] Normal catalogue detail view in staff client doesn't show missing serials or subscription history note In-Reply-To: <bug-8718-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8718-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8718-70-S6AWtL6xYg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8718 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12585|Bug 8718 - Normal catalogue |[SIGNED-OFF] Bug 8718 - description|detail view in staff client |Normal catalogue detail |doesn't show missing |view in staff client |serials or subscription |doesn't show missing |history note |serials or subscription | |history note -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 15:32:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 13:32:17 +0000 Subject: [Koha-bugs] [Bug 8718] Normal catalogue detail view in staff client doesn't show missing serials or subscription history note In-Reply-To: <bug-8718-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8718-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8718-70-EETLUBcAUJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8718 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 15:35:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 13:35:10 +0000 Subject: [Koha-bugs] [Bug 5858] Default frameworks missing many MARC21 tags In-Reply-To: <bug-5858-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5858-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5858-70-qwB55A049Y@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 15:35:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 13:35:53 +0000 Subject: [Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off In-Reply-To: <bug-8462-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8462-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8462-70-4UvgENWBfc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12042|0 |1 is obsolete| | --- Comment #8 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> --- Created attachment 12586 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12586&action=edit Proposed patch (rebased master) Patch rebased. The impacted lines had been rewritten. No change in behavior. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 15:36:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 13:36:32 +0000 Subject: [Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off In-Reply-To: <bug-8462-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8462-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8462-70-d61MEHRNz0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 15:41:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 13:41:42 +0000 Subject: [Koha-bugs] [Bug 8777] Quiet errors in circulation.pl In-Reply-To: <bug-8777-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8777-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8777-70-LEpSqLcYwI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8777 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- (In reply to comment #1) > I haven't generated a patch for any of this yet, since I wouldn't want to > step on any toes. I started working on this but got nowhere. I'm unassigning myself, so if you have something to submit please do. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 15:43:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 13:43:25 +0000 Subject: [Koha-bugs] [Bug 7441] search results showing wrong branch? In-Reply-To: <bug-7441-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7441-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7441-70-T5hcHHcUzp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 delaye <stephane.delaye at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stephane.delaye at biblibre.co | |m --- Comment #21 from delaye <stephane.delaye at biblibre.com> --- I have the value 'default' in the preference systeme OPACXSLTResultsDisplay I have the value 'holdingbranch' in the in the preference systeme OPACResultsBranchXSLT but in the opac results the homebranch is display instead of the holdingbranch Is this the right test?... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 15:44:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 13:44:02 +0000 Subject: [Koha-bugs] [Bug 8733] Adding critic reviews to book pages In-Reply-To: <bug-8733-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8733-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8733-70-7Lu2JF1aa8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8733 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12583|0 |1 is obsolete| | --- Comment #10 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 12587 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12587&action=edit [SIGNED-OFF] Bug 8733: Add IDreamBooks.com enhanced content Adds the following enhanced content to the OPAC, all controlled by separate sysprefs: 1) A "Readometer" which summarizes reviews on the OPAC detail page 2) A tab with snippets of critical reviews on the OPAC detail page 3) A computed rating on the results page To test: Find a book that is listed on IDreamBooks.com (you may have to make sure that you have the first edition), and one that is not. Try each of IDreamBooksReadometer, IDreamBooksReviews, and IDreamBooksResults sysprefs, taking note of the content appearing (or not) as appropriate. Updated to add missing CSS to new theme. Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com> all tests pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 15:47:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 13:47:02 +0000 Subject: [Koha-bugs] [Bug 8733] Adding critic reviews to book pages In-Reply-To: <bug-8733-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8733-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8733-70-uK29yZ1GcF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8733 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12587|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12588 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12588&action=edit Bug 8733: Add IDreamBooks.com enhanced content Adds the following enhanced content to the OPAC, all controlled by separate sysprefs: 1) A "Readometer" which summarizes reviews on the OPAC detail page 2) A tab with snippets of critical reviews on the OPAC detail page 3) A computed rating on the results page To test: Find a book that is listed on IDreamBooks.com (you may have to make sure that you have the first edition), and one that is not. Try each of IDreamBooksReadometer, IDreamBooksReviews, and IDreamBooksResults sysprefs, taking note of the content appearing (or not) as appropriate. Updated to add missing CSS to new theme. Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com> all tests pass. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 15:49:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 13:49:07 +0000 Subject: [Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch. In-Reply-To: <bug-8438-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8438-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8438-70-abvpDhljRr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #5 from Nicole C. Engard <nengard at gmail.com> --- I too am worried about this changing the current behavior. When the change was made to the purchase suggestions by limiting to one branch it confused a lot of our users and isn't really the desired behavior for them either. So I say either a preference or some way to make it less confusing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 15:50:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 13:50:15 +0000 Subject: [Koha-bugs] [Bug 8733] Adding critic reviews to book pages In-Reply-To: <bug-8733-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8733-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8733-70-TvPpRUXAbi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8733 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12588|Bug 8733: Add |[SIGNED-OFF] Bug 8733: Add description|IDreamBooks.com enhanced |IDreamBooks.com enhanced |content |content -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 15:53:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 13:53:13 +0000 Subject: [Koha-bugs] [Bug 7483] A more detailed breadcrumb for authority management In-Reply-To: <bug-7483-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7483-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7483-70-suzdVv5Ufs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7483 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12306|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 12589 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12589&action=edit Bug 7483: fixes on breadcrumbs in Authority administration Better breadcrumbs for the following pages: - auth_tag_structure.pl - auth_subfields_structure.pl Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 15:53:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 13:53:26 +0000 Subject: [Koha-bugs] [Bug 7483] A more detailed breadcrumb for authority management In-Reply-To: <bug-7483-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7483-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7483-70-5emZCp1ZVd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7483 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 15:59:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 13:59:28 +0000 Subject: [Koha-bugs] [Bug 7913] Automatically receive serial issues In-Reply-To: <bug-7913-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7913-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7913-70-pQrx98w9oI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7913 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #13 from Paul Poulain <paul.poulain at biblibre.com> --- Sorry, but the follow-up does not apply : Applying: Follow-up, hide multi button for subs with item fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Follow-up, hide multi button for subs with item When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 15:59:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 13:59:30 +0000 Subject: [Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off In-Reply-To: <bug-8462-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8462-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8462-70-QunqbNXfz0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12586|0 |1 is obsolete| | --- Comment #9 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 12590 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12590&action=edit [SIGNED-OFF] Bug 8462: OpacHiddenItems and hidelostitems hide items, but query result count is off Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com> Works as described and solves the problem for now. I'd say we need a way to make it work by hiding bib records if no items are available as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 15:59:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 13:59:59 +0000 Subject: [Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off In-Reply-To: <bug-8462-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8462-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8462-70-XCD2F0uOYG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #10 from Nicole C. Engard <nengard at gmail.com> --- I think this works to avoid confusion for now and we should come up with a way to hide bib records later on. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 16:08:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 14:08:54 +0000 Subject: [Koha-bugs] [Bug 8042] Batch numbers aren't committed as used until an item is added In-Reply-To: <bug-8042-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8042-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8042-70-V2Ua8sNez3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8042 --- Comment #1 from e-Libris Technologies <elibris.helpdesk at gmail.com> --- Until this problem is fixed one workaround is to click the Add Item button as soon as the very first barcode has been scanned. This way Koha will assign a new batch number. The rest of the barcodes can then be scanned. It's not a perfect solution but should reduce the chances of barcodes from multiple libraries ending up in the same batch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 16:18:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 14:18:02 +0000 Subject: [Koha-bugs] [Bug 8218] Add a script to sanitize entity where "&" character was wrongly replaced with "& " In-Reply-To: <bug-8218-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8218-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8218-70-zr1hoc7lZs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8218 Christophe Croullebois <christophe.croullebois at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10588|0 |1 is obsolete| | Attachment #10589|0 |1 is obsolete| | Attachment #11744|0 |1 is obsolete| | Assignee|alex.arnaud at biblibre.com |christophe.croullebois at bibl | |ibre.com --- Comment #8 from Christophe Croullebois <christophe.croullebois at biblibre.com> --- Created attachment 12591 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12591&action=edit this patch is finalised Two subs written by Alex Arnaud in C4/Charset.pm, SanitizeEntity and entity_clean I had created two scripts for Biblibre, one to be used in cron, it reindexes all transformed records. Sophie Meynieux brought together the two scripts, she has created a batch mode, usefull but without the reindexing So I have rewrited it and I have integrated "Fixing copyright headers and license and description" written by Chris Cormack and "Followup: Perltidy and QA FIX" written by Jonathan Druart Thx to all -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 16:27:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 14:27:39 +0000 Subject: [Koha-bugs] [Bug 7986] Export issues In-Reply-To: <bug-7986-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7986-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7986-70-tjFzc6YaTr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 --- Comment #39 from Nicole C. Engard <nengard at gmail.com> --- I also don't know what to put in the ExportWithCsvProfile preference ... tips for the manual are needed before I can document these. Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 16:47:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 14:47:48 +0000 Subject: [Koha-bugs] [Bug 8843] New: Cannot export bibliographic records by call number Message-ID: <bug-8843-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8843 Priority: P5 - low Change sponsored?: --- Bug ID: 8843 Assignee: oleonard at myacpl.org Summary: Cannot export bibliographic records by call number Severity: normal Classification: Unclassified OS: All Reporter: oleonard at myacpl.org Hardware: All Status: ASSIGNED Version: master Component: Tools Product: Koha The logic is wrong when building the query: if ($start_callnumber) { $sql_query .= " AND itemcallnumber <= ? "; push @sql_params, $start_callnumber; } if ($end_callnumber) { $sql_query .= " AND itemcallnumber >= ? "; push @sql_params, $end_callnumber; } The query must include items with call numbers *greater than* the starting call number and *less than* the ending call number, not vice versa. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 16:52:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 14:52:38 +0000 Subject: [Koha-bugs] [Bug 8843] Cannot export bibliographic records by call number In-Reply-To: <bug-8843-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8843-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8843-70-DaW0AWpzF0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8843 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 16:52:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 14:52:40 +0000 Subject: [Koha-bugs] [Bug 8843] Cannot export bibliographic records by call number In-Reply-To: <bug-8843-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8843-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8843-70-2SdP57TxEr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8843 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 12592 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12592&action=edit Bug 8843 - Cannot export bibliographic records by call number When building the query for exports by call number the script has the logic reversed. It tries to select records with call numbers less than the starting call number and greater than the ending call number. This should be reversed. To test, test an export in an unpatched system. An export by call number will return an empty file. After applying the patch an export by call number should give valid results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 16:59:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 14:59:53 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-ZiV6NFvxEs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #64 from Paul Poulain <paul.poulain at biblibre.com> --- Another question: once an item has been placed for a course reserve, it should not be possible to check it out, isn't it ? Or at least, the librarian should be warned ! That's not the case: * I placed barcode=1 on a course reserve. * I checked on catalogue/detail.pl that the item was reserved * I tried to check-out the item, and got no warning or anything Imo: we should have a syspref deciding if a check-out for an item placed on reserve result in a warning or it forbidden. (In reply to comment #59) > > *Something I don't understand functionally: I places a course reserve on > > an item that was on loan. When I check-in the document, nothing happens (ie: > > I'm not warned the item is for "course X" or something like that. Is it the > > expected behavior ? Some functional explanations are worth... > > That is indeed expected behavior. The course reserves system was written > based on a specification I was given. I will definitely work with Nicole to > make sure it is fully documented in the manual. Definitely, I need the complete specifications! because I think I'm missing something about the expected behavior. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 17:02:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 15:02:01 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-TXbIQKZ9Ug@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #65 from Paul Poulain <paul.poulain at biblibre.com> --- Created attachment 12593 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12593&action=edit Bug 8215 follow-up encoding for branches & itemtypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 17:23:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 15:23:07 +0000 Subject: [Koha-bugs] [Bug 8726] Did you mean? plugin for broader/narrower/related terms In-Reply-To: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8726-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8726-70-5kWimTFuEk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8726 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_10 --- Comment #24 from Paul Poulain <paul.poulain at biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 17:36:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 15:36:42 +0000 Subject: [Koha-bugs] [Bug 8686] author search in staff missing checkboxes and menu In-Reply-To: <bug-8686-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8686-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8686-70-CYLAreu7QP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8686 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW --- Comment #7 from Owen Leonard <oleonard at myacpl.org> --- (In reply to comment #3) > cgi-bin/koha/catalogue/search.pl?q=au:"Tepper, Sheri S." I still can't reproduce this on my system. I can on ByWater's demo, and I notice that removing the quotes from that URL fixes the problem. Now I'm guessing I can't reproduce the error because I have a different search configuration? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 17:42:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 15:42:49 +0000 Subject: [Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag In-Reply-To: <bug-7642-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7642-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7642-70-9CttpRvgdb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 --- Comment #35 from Paul Poulain <paul.poulain at biblibre.com> --- Some comments: * the patch does not apply anymore Applying: Bug 7642 - fix the lost display of tag sizes Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/prog/en/css/opac.css CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/prog/en/css/opac.css Auto-merging C4/Tags.pm CONFLICT (content): Merge conflict in C4/Tags.pm Failed to merge in the changes. Patch failed at 0001 Bug 7642 - fix the lost display of tag sizes When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Patch left in /tmp/SIGNED-OFF-Bug-7642---fix-the-lost-display-of-tag--OPHe1P.patch * you should add the css to ccsr theme * this patch is attached to 7642, but it's not really a follow-up of the previous part, shouldn't it be another bug number ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 17:46:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 15:46:51 +0000 Subject: [Koha-bugs] [Bug 2244] RFID Cataloguing and Circulation In-Reply-To: <bug-2244-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2244-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2244-70-BKPWBkqbGL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2244 Fr?d?ric Demians <frederic at tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 18:06:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 16:06:06 +0000 Subject: [Koha-bugs] [Bug 8840] ubuntu-pkg-check.sh script doesn't work on non-english setups In-Reply-To: <bug-8840-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8840-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8840-70-1tFbrZBkeb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12566|0 |1 is obsolete| | --- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 12594 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12594&action=edit Bug 8840 - ubuntu-pkg-check.sh script doesn't work on non english setups Using dpkg to query for installed packages works in languages other than english. Added some switches to conveniently display the needed apt-get command for installing Koha's dependencies: -r | --report Report the status of Koha's dependencies -ic | --install-command Display the install command for the missing dependencies -h | --help Display this help message Regards To+ Sponsored-by: Universidad Nacional de C?rdoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 18:24:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 16:24:16 +0000 Subject: [Koha-bugs] [Bug 3387] WITHDRAWN items shouldn't check in In-Reply-To: <bug-3387-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3387-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3387-70-ikPl8XkXUd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3387 --- Comment #31 from Mickey Coalwell <mcoalwell at nekls.org> --- Kyle, you wrote, "I can add a followup to remove the choice if you wish." Please don't do that! The whole point of this work was to allow an alternative to the default behavior, which was to allow checkin of WITHDRAWN items. My libraries don't want that to occur. Therefore, this syspref works for me. Removing the choice would invalidate the option. Paul, my understanding is that with this syspref Koha users now have the choice of either allowing or not allowing checkin for WITHDRAWN items. That is what I was hoping to get from this. I hope I'm following everyone's reasoning correctly here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 18:30:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 16:30:21 +0000 Subject: [Koha-bugs] [Bug 8525] Highlight matches on details page In-Reply-To: <bug-8525-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8525-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8525-70-ZcTX7GphLL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8525 --- Comment #8 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 12595 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12595&action=edit Follow up: Bug 8525: Update preference description The feature in bug 8525 added highlighting to the detail pages in the opac. This patch updates the preference to note this change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 18:30:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 16:30:35 +0000 Subject: [Koha-bugs] [Bug 8525] Highlight matches on details page In-Reply-To: <bug-8525-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8525-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8525-70-17sq9UI0Xb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8525 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 18:30:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 16:30:50 +0000 Subject: [Koha-bugs] [Bug 8525] Highlight matches on details page In-Reply-To: <bug-8525-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8525-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8525-70-9d2cKpJuvU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8525 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #9 from Nicole C. Engard <nengard at gmail.com> --- Follow up needs sign off please. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 18:35:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 16:35:57 +0000 Subject: [Koha-bugs] [Bug 8686] author search in staff missing checkboxes and menu In-Reply-To: <bug-8686-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8686-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8686-70-4vCSdpX3VT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8686 --- Comment #8 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 12596 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12596&action=edit search settings I am doing this on my own install, so here are my settings for searching -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 18:40:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 16:40:38 +0000 Subject: [Koha-bugs] [Bug 8843] Cannot export bibliographic records by call number In-Reply-To: <bug-8843-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8843-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8843-70-lBcVsJ9oSp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8843 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12592|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 12597 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12597&action=edit [SIGNED-OFF] Bug 8843 - Cannot export bibliographic records by call number When building the query for exports by call number the script has the logic reversed. It tries to select records with call numbers less than the starting call number and greater than the ending call number. This should be reversed. To test, test an export in an unpatched system. An export by call number will return an empty file. After applying the patch an export by call number should give valid results. Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com> Works as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 18:40:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 16:40:53 +0000 Subject: [Koha-bugs] [Bug 8843] Cannot export bibliographic records by call number In-Reply-To: <bug-8843-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8843-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8843-70-8PdTKt7Uh0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8843 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 18:41:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 16:41:38 +0000 Subject: [Koha-bugs] [Bug 8844] New: UNIMARC_sync_date_created_with_marc_biblio.pl creates a modification log Message-ID: <bug-8844-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8844 Priority: P5 - low Change sponsored?: --- Bug ID: 8844 Assignee: gmcharlt at gmail.com Summary: UNIMARC_sync_date_created_with_marc_biblio.pl creates a modification log Severity: normal Classification: Unclassified OS: All Reporter: fridolyn.somers at biblibre.com Hardware: All Status: NEW Version: master Component: Command-line Utilities Product: Koha When using UNIMARC_sync_date_created_with_marc_biblio.pl script with CataloguingLog on, you get a modification log on all catalog. Script should not call ModBiblio() when dates are already synchronized. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 18:48:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 16:48:17 +0000 Subject: [Koha-bugs] [Bug 8844] UNIMARC_sync_date_created_with_marc_biblio.pl creates a modification log In-Reply-To: <bug-8844-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8844-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8844-70-H3EULjb3xy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8844 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |fridolyn.somers at biblibre.co | |m --- Comment #1 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> --- Created attachment 12598 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12598&action=edit Proposed patch Proposed patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 18:54:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 16:54:40 +0000 Subject: [Koha-bugs] [Bug 8686] author search in staff missing checkboxes and menu In-Reply-To: <bug-8686-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8686-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8686-70-Bfz980id8v@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8686 --- Comment #9 from Owen Leonard <oleonard at myacpl.org> --- It looks to me like this is a JavaScript problem because a variable being passed to JavaScript isn't properly escaped (hence the difference bewteen <"Tepper, Sheri S."> and <Tepper, Sheri S.>. Tracing the variable back leads me to Search.pm, line 2770: for my $field (qw/ lccn isbn issn title author dewey subject /) { my $encvalue = URI::Escape::uri_escape_utf8($bibrec->{$field}); push @$array, { name=>$field, value=>$bibrec->{$field}, encvalue=>$encvalue } if defined $bibrec->{$field}; } I think $encvalue is different on systems which show the error. My copy of URI::Escape is version 3.31, but ByWater's demo reports 3.30. Could that version difference be the source of the different outcomes? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 18:58:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 16:58:33 +0000 Subject: [Koha-bugs] [Bug 8824] use of windows 7, Firefox V15 and wireless level dns 10.58.2.X versus wired 192.168.x.x In-Reply-To: <bug-8824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8824-70-q9SQ3NDGD9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8824 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |INVALID --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- I agree that this problem doesn't sound like an issue with Koha itself, hence doesn't require a bug report. Bug reports describe issues which can be resolved by correcting code. This issue sounds like a support issue. Support issues can be taken up with your support company (recommended) or on the Koha mailing list (http://koha-community.org/support/koha-mailing-lists/). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 18:58:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 16:58:57 +0000 Subject: [Koha-bugs] [Bug 8777] Quiet errors in circulation.pl In-Reply-To: <bug-8777-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8777-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8777-70-XQPKlDHyVX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8777 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 19:03:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 17:03:06 +0000 Subject: [Koha-bugs] [Bug 8844] UNIMARC_sync_date_created_with_marc_biblio.pl creates a modification log In-Reply-To: <bug-8844-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8844-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8844-70-YD5m2Il3KG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8844 --- Comment #2 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> --- Script now does not call ModBiblio() when dates are already synchronized. And many more : + help usage with -h + verbose option to print several infos (count biblios, which biblio has been modified, ...) + manages DEBUG env var to print even more + 'where' option to limit process to some biblios (usefull to test and to run incremental modifications) + 099$c and 099$d are default values but you can specify what fields you use for date created and date last modified (works with control fields < 010) + test mode : if 'run' option is missing, script still shows which biblio would have been modified -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 19:17:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 17:17:53 +0000 Subject: [Koha-bugs] [Bug 8840] ubuntu-pkg-check.sh fix and extend functionality In-Reply-To: <bug-8840-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8840-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8840-70-iJR2jzZyRI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ubuntu-pkg-check.sh script |ubuntu-pkg-check.sh fix and |doesn't work on non-english |extend functionality |setups | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 19:34:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 17:34:18 +0000 Subject: [Koha-bugs] [Bug 8686] author search in staff missing checkboxes and menu In-Reply-To: <bug-8686-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8686-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8686-70-Nux872LfyY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8686 --- Comment #10 from Nicole C. Engard <nengard at gmail.com> --- Owen, I'm not using ByWater's demo ... I'm using my own local install of Master ... so I don't know what's up with the demo site (it's not on the most recent version of master) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 19:37:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 17:37:41 +0000 Subject: [Koha-bugs] [Bug 8840] ubuntu-pkg-check.sh fix and extend functionality In-Reply-To: <bug-8840-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8840-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8840-70-qRnIET67ln@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12594|0 |1 is obsolete| | --- Comment #3 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 12599 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12599&action=edit Replaced ubuntu-pkg-check.sh with one that works properly. Test ------ Prove The Problem ================= 1) Fresh install of Ubuntu 12.04 (Spanish) 2) ./install_misc/ubuntu-pkg-check.sh -- This is to get the base output to compare. 3) sudo apt-get install libyaml-perl 4) ./install_misc/ubuntu-pkg-check.sh -- Identical output, even though we installed a dependency! 5) apply patch 6) ./install_misc/ubuntu-packages.sh -r -- Should be one line difference now! 5) Fresh install of Ubuntu 12.04 (English) 6) ./install_misc/ubuntu-pkg-check.sh -- Indentical to first output, no dependencies installed yet. 7) sudo apt-get install libyaml-perl 8) ./install_misc/ubuntu-pkg-check.sh -- It should match the one line difference output. 9) apply patch 10) ./install_misc/ubuntu-packages.sh -r -- It should match the one line difference output. Test New Features (Help) ======================== 11) ./install_misc/ubuntu-packages.sh -h 12) echo $? -- It should give a nice help screen. And the echo result of 0. 13) ./install_misc/ubuntu-packages.sh 14) echo $? -- It should give a nice help screen. And the echo result of 1 -- based you gave incorrect parameters. 15) ./install_misc/ubuntu-packages.sh -badparm 16) echo $? -- It should give a nice help screen. And the echo result of 1 -- based you gave incorrect parameters. Test New Features (Sudo apt-get command output) =============================================== 17) ./install_misc/ubuntu-packages.sh -ic -- It should output an appropriate sudo apt-get command to install the dependencies. 18) Cut and paste the command, then press enter! -- install everything! 19) ./install_misc/ubuntu-packages.sh -ic -- It should say it thinks everything is installed, and tell you to run a koha_perl_deps.pl -m -u. -- Yes, koha_perl_deps.pl may list outstanding items. That's a different bug report to come. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 19:47:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 17:47:10 +0000 Subject: [Koha-bugs] [Bug 8845] New: Bug 7544 - Add ability search patrons by date of birth Message-ID: <bug-8845-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 Priority: P5 - low Change sponsored?: --- Bug ID: 8845 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: Bug 7544 - Add ability search patrons by date of birth Severity: enhancement Classification: Unclassified OS: All Reporter: kyle at bywatersolutions.com Hardware: All Status: NEW Version: master Component: Patrons Product: Koha Some librarians would like to be able to search for patrons by date of birth. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 19:47:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 17:47:18 +0000 Subject: [Koha-bugs] [Bug 8845] Add ability search patrons by date of birth In-Reply-To: <bug-8845-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8845-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8845-70-a1GlRZfvGH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Bug 7544 - Add ability |Add ability search patrons |search patrons by date of |by date of birth |birth | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 19:47:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 17:47:30 +0000 Subject: [Koha-bugs] [Bug 8800] SpecifyDueDate && useDaysMode=Datedue wrong behaviour In-Reply-To: <bug-8800-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8800-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8800-70-PeXPskbLcy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8800 Federico Rinaudo <frinaudo at infocpt.com.ar> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12527|0 |1 is obsolete| | --- Comment #8 from Federico Rinaudo <frinaudo at infocpt.com.ar> --- Created attachment 12600 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12600&action=edit Bug 8800 - useDaysMode=Datedue wrong behaviour (3.8.x) useDaysMode=Datedue wasn't used as advertised in the docs. Added a next_open_day sub to Koha::Calendar and some tests for it. - AddIssue was fixed for the case $datedue was defined in circ/circulation.pl - CalcDateDue was modified to be consistent with the intended behaviour Regards To+ Sponsored-by: Universidad Nacional de C?rdoba Signed-off-by: Federico Rinaudo <frinaudo at infocpt.com.ar> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 19:48:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 17:48:27 +0000 Subject: [Koha-bugs] [Bug 8845] Add ability search patrons by date of birth In-Reply-To: <bug-8845-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8845-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8845-70-HhetcF9Gj5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 12601 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12601&action=edit Bug 8845 - Add ability search patrons by date of birth Adds the ability to search by dates of birth in iso format. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 19:48:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 17:48:47 +0000 Subject: [Koha-bugs] [Bug 8845] Add ability search patrons by date of birth In-Reply-To: <bug-8845-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8845-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8845-70-fISssCtDJx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 20:08:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 18:08:00 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: <bug-6934-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6934-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6934-70-gEY1miyWFB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Maxime Pelletier <pelletiermaxime at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9419|0 |1 is obsolete| | --- Comment #18 from Maxime Pelletier <pelletiermaxime at gmail.com> --- Created attachment 12602 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12602&action=edit New patch rebased on 3.8.5 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 20:08:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 18:08:47 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: <bug-6934-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6934-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6934-70-8XYXbnqgq2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Maxime Pelletier <pelletiermaxime at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 20:24:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 18:24:52 +0000 Subject: [Koha-bugs] [Bug 7300] display suggestions from librarian library only by default In-Reply-To: <bug-7300-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7300-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7300-70-LpOIweX6sW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7300 Christopher <cbrannon at cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #12 from Christopher <cbrannon at cdalibrary.org> --- I agree that this should be a preference. I also think this preference should make the counter reflect an accurate number. If you are switched to branch moderation, you should only see a count for your branch, rather than the count for all requests. Christopher Brannon Coeur d'Alene Public Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 23:02:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 21:02:46 +0000 Subject: [Koha-bugs] [Bug 8702] System preferences search does not allow accented letters In-Reply-To: <bug-8702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8702-70-Xdm3fCBkzC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8702 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #10 from Chris Cormack <chris at bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Sep 28 23:20:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 21:20:49 +0000 Subject: [Koha-bugs] [Bug 8659] Inactive funds in neworderempty not disabled in IE/Opera In-Reply-To: <bug-8659-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8659-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8659-70-ixzEEVnEAI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8659 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #14 from Chris Cormack <chris at bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 01:19:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 23:19:16 +0000 Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in OPAC and staff client In-Reply-To: <bug-8377-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8377-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8377-70-YbdnSc7B4Q@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12447|0 |1 is obsolete| | --- Comment #25 from Mirko Tietgen <mirko at abunchofthings.net> --- Created attachment 12603 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12603&action=edit Bug 8377 [ENH] Show HTML5 video/ audio for media files in OPAC and staff client This enhancement uses information from MARC field 856 to generate the appropriate HTML5 code to embed am media player for the file(s) in a tab in the OPAC and staff client detail view. This patch supports the HTML5 <audio> and <video> element. Additionally it gives basic support for the <track> element. This element is not supported very well by recent browsers. Please consider the patch working when you get working video or audio. Rebased to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 01:38:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 23:38:43 +0000 Subject: [Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag In-Reply-To: <bug-7642-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7642-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7642-70-AEcHt7kQzd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 --- Comment #36 from Robin Sheat <robin at catalyst.net.nz> --- Created attachment 12604 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12604&action=edit Bug 7642 - fix the lost display of tag sizes This fixes the display of different sized words for differently popular tags. It is a bit of a refactor of that part of the system, moving logic to more sensible places (and removing an unused method on the way.) Note that it isn't an attempt to reproduce what was there previously, just to do something similar, and in an easier to change fashion. Sponsored-By: New Zealand Educational Institute Signed-off-by: Marc Veron <veron at veron.ch> Works as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 01:40:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 23:40:01 +0000 Subject: [Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag In-Reply-To: <bug-7642-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7642-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7642-70-Z7nEfbahdV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 --- Comment #37 from Robin Sheat <robin at catalyst.net.nz> --- Rebased against master, added CSS to ccsr theme, fixed Jonathan's QA comments. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 01:41:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 28 Sep 2012 23:41:08 +0000 Subject: [Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag In-Reply-To: <bug-7642-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7642-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7642-70-3cbBax3EuZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 --- Comment #38 from Robin Sheat <robin at catalyst.net.nz> --- Oh, it probably could have got its own bug number, but I thought it was going to be a simple followup when I started it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 06:33:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2012 04:33:16 +0000 Subject: [Koha-bugs] [Bug 8525] Highlight matches on details page In-Reply-To: <bug-8525-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8525-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8525-70-BSxlhZpr9I@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8525 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12595|0 |1 is obsolete| | --- Comment #10 from Mirko Tietgen <mirko at abunchofthings.net> --- Created attachment 12605 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12605&action=edit Follow up: Bug 8525: Update preference description The feature in bug 8525 added highlighting to the detail pages in the opac. This patch updates the preference to note this change. Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 06:34:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2012 04:34:35 +0000 Subject: [Koha-bugs] [Bug 8525] Highlight matches on details page In-Reply-To: <bug-8525-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8525-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8525-70-IdnX2GKbky@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8525 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mirko at abunchofthings.net --- Comment #11 from Mirko Tietgen <mirko at abunchofthings.net> --- Tiny followup for preference description signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 06:38:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2012 04:38:12 +0000 Subject: [Koha-bugs] [Bug 8840] ubuntu-pkg-check.sh fix and extend functionality In-Reply-To: <bug-8840-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8840-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8840-70-rDpGS9shR0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 --- Comment #4 from M. Tompsett <mtompset at hotmail.com> --- Revised/Clarified Test Plan --------------------------- Prove The Problem ================= 1) Fresh install of Ubuntu 12.04 (Spanish) 2) ./install_misc/ubuntu-pkg-check.sh -- This is to get the base output to compare. -- a whole bunch of library name = none. 3) sudo apt-get install libyaml-perl 4) ./install_misc/ubuntu-pkg-check.sh -- Identical output, even though we installed a dependency! 5) apply patch 6) ./install_misc/ubuntu-packages.sh -r -- libyaml-perl should show the correct version number. 7) Fresh install of Ubuntu 12.04 (English) 8) ./install_misc/ubuntu-pkg-check.sh -- Indentical to first output, no dependencies installed yet. 9) sudo apt-get install libyaml-perl 10) ./install_misc/ubuntu-pkg-check.sh -- libyaml-perl should show the correct version number. 11) apply patch 12) ./install_misc/ubuntu-packages.sh -r -- libyaml-perl should show the correct version number. Test New Features (Help) ======================== 13) ./install_misc/ubuntu-packages.sh -h 14) echo $? -- It should give a nice help screen. And the echo result of 0. 15) ./install_misc/ubuntu-packages.sh 16) echo $? -- It should give a nice help screen. And the echo result of 1 -- based you gave incorrect parameters. 17) ./install_misc/ubuntu-packages.sh -badparm 18) echo $? -- It should give a nice help screen. And the echo result of 1 -- based you gave incorrect parameters. Test New Features (Sudo apt-get command output) =============================================== 19) ./install_misc/ubuntu-packages.sh -ic -- It should output an appropriate sudo apt-get command to install the dependencies. 20) Cut and paste the command, then press enter! -- install everything! 21) ./install_misc/ubuntu-packages.sh -ic -- It should say it thinks everything is installed, and tell you to run a koha_perl_deps.pl -m -u. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 14:58:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2012 12:58:18 +0000 Subject: [Koha-bugs] [Bug 459] No uninstall script In-Reply-To: <bug-459-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-459-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-459-70-UzafJuhL28@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=459 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12451|0 |1 is obsolete| | --- Comment #4 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 12606 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12606&action=edit Revised untested non-patch file - Prevent package uninstalls now I was told that anything that even attempted a packages uninstall would not pass QA, so no packages processing (except detection) is done. MJ Ray's security rant made me revisit sections of this to remove as many sudo's as possible. Not all have been removed. The Ubuntu instructions create an /etc/cron.d/koha cronjob using sudo. Should all git and tarball installs use user crontab files and not /etc/cron.d /etc/cron.hourly or /etc/cron.daily? Feedback needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 15:27:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2012 13:27:43 +0000 Subject: [Koha-bugs] [Bug 8846] New: t/SuggestionEngine_ExplodedTerms.t sneakily uses database Message-ID: <bug-8846-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8846 Priority: P5 - low Change sponsored?: --- Bug ID: 8846 Assignee: jcamins at cpbibliography.com Summary: t/SuggestionEngine_ExplodedTerms.t sneakily uses database Severity: normal Classification: Unclassified OS: All Reporter: jcamins at cpbibliography.com Hardware: All Status: NEW Version: master Component: Test Suite Product: Koha Even though there is no need for anything stored in the database for the test, C4::Templates requires the database. The solution is to mock all database-using routines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 15:30:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2012 13:30:25 +0000 Subject: [Koha-bugs] [Bug 8846] t/SuggestionEngine_ExplodedTerms.t sneakily uses database In-Reply-To: <bug-8846-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8846-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8846-70-eWqbVYkerb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8846 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 15:30:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2012 13:30:26 +0000 Subject: [Koha-bugs] [Bug 8846] t/SuggestionEngine_ExplodedTerms.t sneakily uses database In-Reply-To: <bug-8846-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8846-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8846-70-RoVSX8LzoL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8846 --- Comment #1 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 12607 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12607&action=edit Bug 8846: Exploded Terms test sneakily uses database Even though there is no need for anything stored in the database for the test, C4::Templates requires the database. The solution is to mock all database-using routines. To test: 1) Stop MySQL 2) Run test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 18:20:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2012 16:20:29 +0000 Subject: [Koha-bugs] [Bug 8568] Fix some errors in docs for scripts provided by the Debian packages In-Reply-To: <bug-8568-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8568-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8568-70-CLTrtOsZak@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8568 --- Comment #1 from Magnus Enger <magnus at enger.priv.no> --- 4. koha-run-backups does not have a man page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 18:53:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2012 16:53:51 +0000 Subject: [Koha-bugs] [Bug 8845] Add ability search patrons by date of birth In-Reply-To: <bug-8845-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8845-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8845-70-z8NRK6F8tu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12601|0 |1 is obsolete| | --- Comment #2 from Marc V?ron <veron at veron.ch> --- Created attachment 12608 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12608&action=edit Bug 8845 - Add ability search patrons by date of birth Adds the ability to search by dates of birth in iso format. Signed-off-by: Marc Veron <veron at veron.ch> Searched with following formats: YYYYMMDD , YYYY-MM-DD , YYYY.MM.DD All searches are OK -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 18:54:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2012 16:54:19 +0000 Subject: [Koha-bugs] [Bug 8845] Add ability search patrons by date of birth In-Reply-To: <bug-8845-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8845-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8845-70-l8eSPWvN0w@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 19:12:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2012 17:12:48 +0000 Subject: [Koha-bugs] [Bug 8680] Z39.50 searches for ISBN/ISSN problematic in the Acquistions Module In-Reply-To: <bug-8680-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8680-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8680-70-e0c3YV8FgT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8680 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12401|0 |1 is obsolete| | --- Comment #2 from Marc V?ron <veron at veron.ch> --- Created attachment 12609 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12609&action=edit [SIGNED-OFF] Bug 8680 Z39.50 ISBN Search is problematic and there is a missing ISSN field. The changes here are duplicate fixes. The cataloguing directory had the same bugs as the acqui directory. The bugs in the cataloguing files of the same name were fixed in Bug 8550. The bugs in the acqui files had not been fixed. This will fix Bug 8680 which is in the Acquisitions Module. Changes to the z3950_search.pl file: Rather than treating ISBN and ISSN as the same, this patch breaks them out into separate parts of the query, as well as changing the truncation attribute to enable right truncation (the correct behavior for the ISBN field in MARC21, and valid behavior in UNIMARC). Changes to the z3950_search.tt file: Sometime in 2009 or so, the ISSN field was removed from the Z39.50 search page, and the ISBN field replaced with a combined ISBN/ISSN field. Since this breaks ISBN search for most Z39.50 targets (due to the differing treatment of ISBN vs. ISSN), this is a bug not a feature. Signed-off-by: Marc Veron <veron at veron.ch> Works as expected. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Sep 29 19:13:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 29 Sep 2012 17:13:21 +0000 Subject: [Koha-bugs] [Bug 8680] Z39.50 searches for ISBN/ISSN problematic in the Acquistions Module In-Reply-To: <bug-8680-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8680-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8680-70-KWwOXclpfi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8680 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 02:59:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2012 00:59:27 +0000 Subject: [Koha-bugs] [Bug 8840] ubuntu-pkg-check.sh fix and extend functionality In-Reply-To: <bug-8840-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8840-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8840-70-ijyCri8JeW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12599|0 |1 is obsolete| | --- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 12610 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12610&action=edit Bug 8840 - ubuntu-pkg-check.sh fix and extend functionality First, reworked it into a newer script with parameters: ubuntu-packages.sh -r This will generate output identical to the old script, except that it is fixed for non-english setups. ubuntu-packages.sh -h This adds a brief help, which all scripts should have. ubuntu-packages.sh -ic This helps handle a multi-arch problem by printing out a relevant command for installing missing dependencies. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 05:41:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2012 03:41:06 +0000 Subject: [Koha-bugs] [Bug 8840] ubuntu-pkg-check.sh fix and extend functionality In-Reply-To: <bug-8840-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8840-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8840-70-3GvIxfyFCd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 --- Comment #6 from M. Tompsett <mtompset at hotmail.com> --- I just noticed a minor typo in the comments. "dor" instead of "dot". I'll let you fix it, Tom?s. And don't forget to set the status to "Needs Signoff" when you do. I don't think either of us should sign it off, since we both worked on this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 10:02:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2012 08:02:01 +0000 Subject: [Koha-bugs] [Bug 8568] Fix some errors in docs for scripts provided by the Debian packages In-Reply-To: <bug-8568-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8568-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8568-70-KRKnGO9bXQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8568 --- Comment #2 from Magnus Enger <magnus at enger.priv.no> --- Created attachment 12611 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12611&action=edit Bug 8568 - Fix some errors in docs for scripts provided by the Debian packages 1. Create a page for koha-run-backups 2. Fix the synopsis for koha-foreach 3. Add koha-create and koha-run-backups to koha-common To test - Convert the changed xml files to man pages with $ xsltproc /usr/share/xml/docbook/stylesheet/docbook-xsl/manpages/docbook.xsl koha-x.xml - View generated pages with e.g. $ man -l koha-x.8" (Replace x with the names of the changed files) - Check that the changes make sense -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 10:03:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2012 08:03:48 +0000 Subject: [Koha-bugs] [Bug 8568] Fix some errors in docs for scripts provided by the Debian packages In-Reply-To: <bug-8568-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8568-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8568-70-m9lyuWB5Ai@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8568 Magnus Enger <magnus at enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #3 from Magnus Enger <magnus at enger.priv.no> --- I could not recreate issue 2 above, with the missing man page for koha-remove, so the attached patch is for issues 1, 3 and 4. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 10:05:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2012 08:05:34 +0000 Subject: [Koha-bugs] [Bug 4877] Create and update the manual pages for the koha-* scripts. In-Reply-To: <bug-4877-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4877-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4877-70-Z6qIgy9Wou@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4877 Magnus Enger <magnus at enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED --- Comment #40 from Magnus Enger <magnus at enger.priv.no> --- (In reply to comment #39) > The manual pages work in current master, but I can't find a manual page for > koha-run-backups, so I'm resetting the status of this bug. This is addressed by my patch for Bug 8568, so I'm marking this one as RESOLVED FIXED. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 10:05:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2012 08:05:36 +0000 Subject: [Koha-bugs] [Bug 2509] create Debian package In-Reply-To: <bug-2509-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2509-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2509-70-7fXKfWj4Rh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2509 Bug 2509 depends on bug 4877, which changed state. Bug 4877 Summary: Create and update the manual pages for the koha-* scripts. http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4877 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 10:07:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2012 08:07:11 +0000 Subject: [Koha-bugs] [Bug 8568] Fix some errors in docs for scripts provided by the Debian packages In-Reply-To: <bug-8568-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8568-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8568-70-6u6Rx07pl9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8568 Robin Sheat <robin at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 10:41:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2012 08:41:35 +0000 Subject: [Koha-bugs] [Bug 2505] enable Perl warnings in all modules and scripts In-Reply-To: <bug-2505-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2505-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2505-70-QVfrGFPH7x@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2505 Marc V?ron <veron at veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 12:48:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2012 10:48:30 +0000 Subject: [Koha-bugs] [Bug 8847] New: Cataloguing doesn't work after installing ru-RU translation Message-ID: <bug-8847-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8847 Priority: P5 - low Change sponsored?: --- Bug ID: 8847 Assignee: gmcharlt at gmail.com Summary: Cataloguing doesn't work after installing ru-RU translation Severity: normal Classification: Unclassified OS: Linux Reporter: mopo at front.ru Hardware: PC Status: NEW Version: rel_3_8 Component: Database Product: Koha Created attachment 12612 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12612&action=edit No cataloguing tool in staff client After installing new Koha 3.8.5 several days ago and installing its translation in russian (ru-RU) several errors are received on the last step of web-installation when I create a koha instance. They look like this: library_item_types.sql ERROR 1701 (42000) at line 1: Cannot truncate a table referenced in a foreign key constraint (`koha_test`.`branch_item_rules`, CONSTRAINT `branch_item_rules_ibfk_1` FOREIGN KEY (`itemtype`) REFERENCES `koha_test`.`itemtypes` (`itemtype`)) patron_atributes.sql ERROR 1701 (42000) at line 1: Cannot truncate a table referenced in a foreign key constraint (`koha_test`.`borrower_attributes`, CONSTRAINT `borrower_attributes_ibfk_2` FOREIGN KEY (`code`) REFERENCES `koha_test`.`borrower_attribute_types` (`code`)) patron_categories.sql ERROR 1701 (42000) at line 1: Cannot truncate a table referenced in a foreign key constraint (`koha_test`.`borrowers`, CONSTRAINT `borrowers_ibfk_1` FOREIGN KEY (`categorycode`) REFERENCES `koha_test`.`categories` (`categorycode`)) print_labels.sql ERROR 1146 (42S02) at line 2: Table 'koha_test.labels_templates' doesn't exist sample_news.sql sample_notices.sql ERROR 1701 (42000) at line 1: Cannot truncate a table referenced in a foreign key constraint (`koha_test`.`message_transports`, CONSTRAINT `message_transports_ibfk_3` FOREIGN KEY (`letter_module`, `letter_code`, `branchcode`) REFERENCES `koha_test`.`letter` (`module`, `code`, `branchco) sample_user_suggestions.sql unimarc_authorities_CO_general.sql unimarc_authorities_NP_general.sql unimarc_authorities_SAUTTIT_general.sql unimarc_authorities_SAUT_general.sql unimarc_authorities_SCO_general.sql unimarc_authorities_SNC_general.sql unimarc_authorities_SNG_general.sql unimarc_authorities_STU_general.sql unimarc_authorities_TU_general.sql unimarc_default_matching_rules.sql z39-50servers_collection.sql class_sources.sql message_transport_types.sql ERROR 1701 (42000) at line 1: Cannot truncate a table referenced in a foreign key constraint (`koha_test`.`message_queue`, CONSTRAINT `messageq_ibfk_2` FOREIGN KEY (`message_transport_type`) REFERENCES `koha_test`.`message_transport_types` (`message_transport_type`)) permissions_and_user_flags.sql ERROR 1701 (42000) at line 1: Cannot truncate a table referenced in a foreign key constraint (`koha_test`.`permissions`, CONSTRAINT `permissions_ibfk_1` FOREIGN KEY (`module_bit`) REFERENCES `koha_test`.`userflags` (`bit`)) sample_notices.sql sample_notices_message_attributes.sql ERROR 1701 (42000) at line 1: Cannot truncate a table referenced in a foreign key constraint (`koha_test`.`message_transports`, CONSTRAINT `message_transports_ibfk_1` FOREIGN KEY (`message_attribute_id`) REFERENCES `koha_test`.`message_attributes` (`message_attribute_id`)) sample_notices_message_transports.sql ERROR 1452 (23000) at line 3: Cannot add or update a child row: a foreign key constraint fails (`koha_test`.`message_transports`, CONSTRAINT `message_transports_ibfk_1` FOREIGN KEY (`message_attribute_id`) REFERENCES `message_attributes` (`message_attribute_id`) ON DELETE CASCADE ON UPDA) stopwords.sql subtag_registry.sql system_preferences_full_optimal_for_install_only.sql system_preferences_optimal_values_insert_only.sql unimarc_authorities_DEFAULT_general.sql unimarc_bibliographic_DEFAULT_general.sql unimarc_bibliographic_DEFAULT_local_995.sql But if I chose english as the language of installation all works fine and no errors appear. After this when I log in staff client I realize that there is no "Cataloguing" button and there is nothing on the "Tools" page. I had a previous installation of Koha on other machine, I dumped the database from there and tried to create a new instance using that dump. There was a message about new version of the database, but no errors occured. The instance has been created and the cataloguing tool works as it should work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 12:49:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2012 10:49:55 +0000 Subject: [Koha-bugs] [Bug 8847] Cataloguing doesn't work after installing ru-RU translation In-Reply-To: <bug-8847-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8847-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8847-70-gXvAOnSZSJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8847 Dmitry <mopo at front.ru> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr Component|Database |translate.koha-community.or | |g Assignee|gmcharlt at gmail.com |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 15:29:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2012 13:29:24 +0000 Subject: [Koha-bugs] [Bug 8847] Cataloguing doesn't work after installing ru-RU translation In-Reply-To: <bug-8847-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8847-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8847-70-EaNAzwdLWF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8847 Dmitry <mopo at front.ru> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mopo at front.ru -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 17:44:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2012 15:44:05 +0000 Subject: [Koha-bugs] [Bug 8840] ubuntu-pkg-check.sh fix and extend functionality In-Reply-To: <bug-8840-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8840-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8840-70-4WcPO4lwTj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12610|0 |1 is obsolete| | --- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 12613 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12613&action=edit Bug 8840 - ubuntu-pkg-check.sh fix and extend functionality Fixed a problem with package queries. First, reworked it into a newer script with parameters: ubuntu-packages.sh -r This will generate output identical to the old script, except that it is fixed for non-english setups. ubuntu-packages.sh -h This adds a brief help, which all scripts should have. ubuntu-packages.sh -ic This helps handle a multi-arch problem by printing out a relevant command for installing missing dependencies. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 17:44:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2012 15:44:32 +0000 Subject: [Koha-bugs] [Bug 8840] ubuntu-pkg-check.sh fix and extend functionality In-Reply-To: <bug-8840-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8840-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8840-70-zgnE11CjOD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 17:51:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2012 15:51:39 +0000 Subject: [Koha-bugs] [Bug 8402] replace 'install_misc/debian.packages' file with 'koha-debian-deps.pl' script In-Reply-To: <bug-8402-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8402-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8402-70-7TnJTlOSGw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8402 --- Comment #2 from M. Tompsett <mtompset at hotmail.com> --- While thinking over the problem of Test::MockModule and DBD::Mock not being installed, I was chatting with "eythian" on the IRC channel. It turns out that that debian/update-control scripts uses the list-deps script which works it magic back to PerlDependencies.pm $ cd debian $ grep ": lib" control | wc -l 1 $ grep "^ lib" control | wc -l 85 $ cd ../install_misc $ grep "^\s*lib" debian.packages | wc -l 102 $ cd ../C4/Installer $ less PerlDependencies.pm # I visually inspected to make sure everything was a tuple $ grep "min_ver" PerlDependencies.pm | wc -l 106 Now here's one possible reason for the difference: two libraries (blah::foo::bar and blah::foo) are in the same package (libblah-foo-perl). Useful commands that came to mind: $ grep "^ '" PerlDependencies.pm | cut -f2 -d"'" | sort > ~/PerlDepsPerl.txt $ grep "^ '" PerlDependencies.pm | cut -f2 -d"'" | sort | sed -e "s#::#-#g" | tr "[:upper:]" "[:lower:]" | perl -e "@data=<STDIN>; for \$line (@data) { chomp \$line; print \"lib\$line-perl\\n\"; }" > ~/PerlDepsLib.txt $ grep "^ '" PerlDependencies.pm | cut -f2 -d"'" | sort | sed -e "s#::#\/#g" | perl -e "@data=<STDIN>; for \$line (@data) { chomp \$line; print \"\$line.pm\\n\"; }" > ~/PerlDepsPath.txt $ cd $ for i in `cat PerlDepsPath.txt`; do echo $i; apt-file search -x "^/usr/((lib|share)/perl5|(lib|share)/perl/[0-9.]+)/$i\$"; done My thoughts are that install_misc/debian.packages could easily be built with a little bit of extra scripting, when the debian/control file is generated. Though, I still need to understand how the |'s are handled in the control file, as they are listed as two lines in the sample for loop above. This beginning to wade into the bowels of debian packaging stuffs also may have demonstrated that I need to tweak that check_deps.sh script some -- choose the non-xpm version of GD. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 21:49:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2012 19:49:37 +0000 Subject: [Koha-bugs] [Bug 8732] Add a systempreference to allow users to choose to display an icon based on the marc control fields, or based on the koha biblio level itemtype In-Reply-To: <bug-8732-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8732-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8732-70-zBEolx1Rtd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #5 from Chris Cormack <chris at bigballofwax.co.nz> --- Reworking, changing the name of the syspref and extending to do the intranet as well as the OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 21:50:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2012 19:50:06 +0000 Subject: [Koha-bugs] [Bug 8732] Add a systempreference to allow users to choose to display an icon based on the marc control fields, or based on the koha biblio level itemtype In-Reply-To: <bug-8732-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8732-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8732-70-uxwrv7wgB0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12047|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 23:59:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2012 21:59:27 +0000 Subject: [Koha-bugs] [Bug 8732] Add a systempreference to allow users to choose to display an icon based on the marc control fields, or based on the koha biblio level itemtype In-Reply-To: <bug-8732-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8732-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8732-70-If58tdLW0R@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 --- Comment #6 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 12614 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12614&action=edit Bug 8732: Allowing biblio level itemtypes to display instead of MARC ones If you switch BiblioItemtypeImage to Koha, you will see the Koha itemtypes, if it is Control you will get the ones generated from the MARC control fields. Squashed commit of the following: commit a36d5fdbfc484639ae7939f14e0363fda79b9323 Author: Chris Cormack <chrisc at catalyst.net.nz> Date: Mon Oct 1 10:56:47 2012 +1300 WR96747, Bug 8732 Finishing staff side commit feff903c77ffc0fcec9459ecffab6c2ee5b1349d Author: Chris Cormack <chrisc at catalyst.net.nz> Date: Mon Oct 1 09:47:07 2012 +1300 Bug 8732 : Now working for staff side too commit 641be286401cf1be54fddb3cc58a53566d80dcca Author: Chris Cormack <chrisc at catalyst.net.nz> Date: Mon Oct 1 09:10:27 2012 +1300 Bug 8732 - generalising syspref Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> commit c4ce95c12a773d84e6f8d0b05664649e170799d8 Author: Chris Cormack <chrisc at catalyst.net.nz> Date: Wed Sep 12 09:19:31 2012 +1200 Bug 8732 : Showing the images on the OPAC detail page commit 105acad0f76628536840577fa96fb0839f9f3e2f Author: Chris Cormack <chrisc at catalyst.net.nz> Date: Thu Sep 6 14:19:37 2012 +1200 Bug 8732 : Allowing biblio level itemtypes to display instead of MARC ones If you switch OpacResultsItemtypeImage to Koha, you will see the Koha itemtypes, if it is Control you will get the ones generated from the MARC control fields. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Sep 30 23:59:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 30 Sep 2012 21:59:38 +0000 Subject: [Koha-bugs] [Bug 8732] Add a systempreference to allow users to choose to display an icon based on the marc control fields, or based on the koha biblio level itemtype In-Reply-To: <bug-8732-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8732-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8732-70-JdaK1FrrHV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.