[Koha-bugs] [Bug 7412] Pre-filling items in cataloguing

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
            Version|master                      |rel_3_10

--- Comment #33 from Paul Poulain <paul.poulain at biblibre.com> ---
(In reply to comment #25)
> Why do you need two new prefs?
> 
> -> Maybe one would have been enough. On the other hand, with two sysprefs,
> you can enable/disable the feature and keep your settings.
Well, I agree with Marcel that one syspref would have been enough = if you want
to disable the feature for a short time, just copy/paste it somewhere. However,
I won't reject your patch for that, because it is 9 months old, it would not be
fair.

> Since we also have default values in framework, we have Add & Duplicate,
> what exacly make this feature so needed?
> 
> -> This feature keeps track of what to prefill from one session to another
> (both in time and user: if the user disconnects and reconnects, the values
> are still prefilled. If a user disconnects and another user logs in, the
> values are still prefilled.). Add & Duplicate does not.

During my tests, I discovered that the cookie last only for the session. Is it
one of my specific FF setup ?
The cookie is created using:
+                my $itemcookie = $input->cookie(
+                    -name => 'LastCreatedItem',
+                    # We uri_escape the whole freezed structure so we're sure
we won't have any encoding problems
+                    -value   => uri_escape_utf8( freeze( $record ) ),
+                    -expires => ''
+                );
isn't it meaning "session" ?
However, I'm OK with a duration of a browser session (I even think I prefer
that to a forever lasting prefill), so ...

... patch pushed

-- 
You are receiving this mail because:
You are watching all bug changes.