[Koha-bugs] [Bug 8089] Use Koha::Cache everywhere

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paul.poulain at biblibre.com

--- Comment #15 from Paul Poulain <paul.poulain at biblibre.com> ---
(In reply to comment #14)
> QA Comment:
> Code looks good to me.
> Just thinking: Instead of hardcoding cache times here and there in some
> variety, could we intelligently configure them in a pref or so ? :)
> 
> Passed QA

I agree it could be configured manually. But I think we need more than one
caching time.
Some informations have a long duration (like branches, that almost never
change)
Some informations should have a shorter duration.

And anyway, I think we will quickly need a way to clear all cachings.
We have 2 options for that:
 * reload cache everywhere we have cache, when a value is updated
 * provide a "clear cache" in admin-home.pl, where the syslibrarian can reload
everything when there is a value changed

The 1st option is better, the 2nd is easier.

For sysprefs caching = chris_c said (and he's right) that caching is not a
matter of speed but of load. Caching sysprefs just one by one is maybe more
expensive than not caching (will do some tests to get number). I think we'd
better load *all* the sysprefs in the cache at once -in just one cache object-.
It may be a little bit costly for the 1st page, but faster for the next ones.

What do you guys think of this idea ?

(delaying push of this patch a little bit, I want to test it deeply. Will push
other more easier-to-test patches before)

-- 
You are receiving this mail because:
You are watching all bug changes.