[Koha-bugs] [Bug 8034] Enable server print queue selection

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8034

--- Comment #13 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to comment #12)

> Can you please shed some light on how to run those tests.

Hum... no :) I don't know either !
It seems these tests are not still used currently.
from irc :
 Joubu: Does someone know if unit tests in t/db_dependent/lib/KohaTest are
still used ?
 rangi: no they aren't
 rangi: but if they could be made to work again, they would be
 rangi: you can never have too many tests

Some feedback about your patch:
1/ The syspref UsePrintQueues already exists and the updatedatabase will raise
an error. I think the insert is useless.

2/ A link is missing in the left menu in the administration module (under
Additional parameters)

3/ The edit action does not work (in my logs: use of uninitialized value
$data[0] in concatenation (.) or string at /home/koha/C4/Printer.pm line 95)

4/ It would be possible to remote one click. Indeed after adding a printer we
have to click on a useless 'ok' button. Can we redirect directly on the printer
list page ?

5/ When I edit a library, the printer is not selected by default

6/ In header.inc it would be better to hide the '-' caracter if there is no
printer defined for the current library.

7/ It would be great to automatically select (on the fly) the printer attached
to the library we select (on the selectbranchprinter page)

-- 
You are receiving this mail because:
You are watching all bug changes.