[Koha-bugs] [Bug 7067] allow patron self registration via the opac

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067

--- Comment #45 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to comment #41)
> A point for discussion: I think the registration confirmation messages
> should come from the email address of the library the user chose as their
> home library. The counter-argument is that the user may not have chosen the
> correct library, but I don't see that as much of a problem since either way
> the reply would be coming from an email address which wasn't their library's.

I suppose a followup for that would not be too much trouble.

> The big issue I'm still seeing: New records are saved with NULL expiration
> date and NULL registration date. Will the delete_expired_opac_registrations
> cron job work with a NULL dateenrolled?

This should be fixed in the current version of the patch.

> Some small issues:
> 
> - I think a note about pending patron modifications should appear on 
>   the patrons page (members/members-home.pl) in addition to the staff
>   client home page, just as pending tag/comment/suggestions also show
>   as pending on the Tools page.

I'll take a look and add a followup for that.

> 
> - Bug 8593 added unique IDs to the other "pending" notes. This patch
>   should include one for the line it adds.

I'll have to look into that.

> - members/members-update.pl needs a descriptive page title and page
>   header. If there are no pending operations it should display a message
>   saying so rather than an empty table.

I suppose we can do that, but if there are no pending operations, the link for
the page disappears, so it is assumed no one will visit it when there are no
pending operations.

> - The table markup on members/members-update.pl is missing a </tr>,
>   causing validation errors.

I'll look at it.

> - I think the random-character verification field should be styled like 
>   other required fields

Good idea.

> - Since the datepicker widget doesn't make it easy to pick a date far in
>   the past (as are birthdays for some of us), I don't think the field 
>   should be read-only.

I suppose we can do that. I'm a bit iffy about that one though.

> - I think opac-memberentry-update-submitted.tt should include the user
>   sidebar menu.

I'll see what I can do about that.

> - I see an error in the log when submitting the registration form in 
>   the OPAC: 
> 
> substr outside of string at
> /home/oleonard/kohaclone/opac/opac-memberentry.pl line 239

I'll take a look at that too.

> If PatronSelfRegistrationExpireTemporaryAccountsDelay is set to "0" does
> that mean never? If so the description should say so.

That is correct. I'll have to add it to the description.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.