[Koha-bugs] [Bug 8597] New theme for the OPAC with a mobile view

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597

--- Comment #54 from Jared Camins-Esakov <jcamins at cpbibliography.com> ---
(In reply to comment #51)
> Even if I discard the QOTD thing, that is minor, there's something that is
> annoying me with this patch, I'll try to share what.
> My main question = why does it add a new template, and not just the mobile
> stuff ? Activating the mobile support means activating ccsr template AND
> updating opaccolorstylesheet sysprefs.
> 
> wouldn't the 1st patch + 
> +<meta name="viewport"
> content="width=device-width,initial-scale=1.0,maximum-scale=1.0,minimum-
> scale=1.0,user-scalable=no">
> +<link rel="stylesheet" type="text/css" media="screen and (max-width:700px)"
> href="[% themelang %]/css/mobile.css" />
> + a prog/css/mobile.css (+ a few other markup changes probably)
> have achieved the same result ?

Not without changing the prog display greatly. Personally, I like the ccsr
theme a lot better than prog, but it does change things rather a lot. The
initial patch changed prog, and I was not comfortable with it because it
*forced* everyone to change their layout, breaking any and all custom CSS, and
probably a lot of jQuery. Anyone who doesn't like the ccsr theme can just keep
using prog. With the changes introduced in this and other patches, maintaining
multiple sets of templates will not be too difficult.
+1 for pushing

-- 
You are receiving this mail because:
You are watching all bug changes.