[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Sep 14 15:30:28 CEST 2012


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

--- Comment #159 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to comment #158)
> Created attachment 12224 [details]
> Proposed patch
> 
> This patch fixes two instances that cause Jemkins builds to fail

Why don't you just remove the "undef" word ?
I think
if ($@) {
    return;
}
is less readable as
return if $@;

Don't you think ?
I can provide a new patch but I don't want to go against what you want.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list