[Koha-bugs] [Bug 8377] Show HTML5 video/ audio for media files in OPAC and staff client

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |paul.poulain at biblibre.com

--- Comment #19 from Paul Poulain <paul.poulain at biblibre.com> ---
QA comment:
This patch has one problem that must be solved before being pushed :
 the Koha:: namespace must contain OO code only, the Koha/HTML5Media.pm is not
OO

I also think that this file (an OO version) should be in a subdirectory, but
I've nothing to propose for now.

I've checked that the HTML5Media.pm passes perlcritic

2 options to earn passed QA :
 * rewritte HTML5Media.pm for an OO version
 * move it to C4/

failing QA for now.

note I haven't tested it, and it also not apply cleanly anymore:
CONFLICT (content): Merge conflict in opac/opac-detail.pl
Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
CONFLICT (content): Merge conflict in
koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/enhanced_content.pref
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging installer/data/mysql/sysprefs.sql
CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql
Auto-merging catalogue/detail.pl

-- 
You are receiving this mail because:
You are watching all bug changes.