[Koha-bugs] [Bug 8559] conflicting item statuses

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8559

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #8 from Owen Leonard <oleonard at myacpl.org> ---
I think this patch represents the best possible solution given the way we
handle holds right now. I wish we didn't have to force the hold to be an
item-level hold, but it's a limitation of how we store hold information.

I would ask for two changes:

1. Make "revert" the default option. That is the less "destructive" of the two.
2. Change the markup of the radio buttons to allow clicking on the text:

<p>
    <label for="cancelreserve">Cancel hold</label>
    <input type="radio" checked="checked" value="cancel" name="cancelreserve"
id="cancelreserve" /><br />
    <label for="revertreserve">Revert waiting status</label>
    <input type="radio" value="revert" name="cancelreserve" id="revertreserve"
/>
</p>

The label must match the id of the input field. Note that the input name and
the input id do not have to match.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.