[Koha-bugs] [Bug 7751] Decrease loan period on items with a high number of holds

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
            Version|master                      |rel_3_10

--- Comment #31 from Paul Poulain <paul.poulain at biblibre.com> ---
Patch pushed to master

There was a conflict in C4/Circulation.pm, with bug 6151 (AllowToReturnBranch
syspref that added a sub that was at the same place) and 7621 (Age Restriction)
I fixed the conflict, tested circulation was working well.

I was surprised to see no updatedatabase.pl, when I realised it was not needed
: if they are not defined, there is no value, the feature is not enabled.
Entering values in preference.pl create them (I've checked)
Colin = was it intended or a mistake with a nice effect ?


Isn't there a typo in the syspref description:
 "A loan should be reduced by decreaseLoanHighHoldsDuration when holds have
been places (if decreaseLoanHighHolds is enables)"

shouldn't it be "have been placed" and "is enabled" ? (as Colin is english
native, I feel less authoritative on this as he is ;-) )

(not enought to reject the patch though, so it's pushed ;-) )

-- 
You are receiving this mail because:
You are watching all bug changes.