[Koha-bugs] [Bug 7572] Add Clubs & Services Feature

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #24 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Kyle, 

I have read through the code and there are some issues with this patch:

1) Can you please add the new permisson for all languages? English is ok -
easier to add a translation than figuring out a missing permission.

2) Some of the perl files have strict, but not warnings, can you add use
Modern::Perl?

3) The Templates don't follow the capitalization rules. Examples:
Start Date
End Date
You Are Not Enrolled In Any Clubs Or Services

4) This will not work for other languages, as noted in some of the earlier
comments:
$sth = $dbh->prepare("SELECT * FROM clubsAndServicesArchetypes WHERE title LIKE
'Bestsellers Club' ");

Also:
+# This script utilizes the 'New Items E-mail List' archetype
+# from the ClubsAndServices.pm module.
+# If you do not have this archtype, create an archetype of that name

5) If I read the code correctly, this is another translation problem, adding a
hardcoded note to the hold:
+      my $notes = "Automatic Reserve for Bestsellers Club",

6) I wonder about the error messages - from reading the code I am not totally
sure but I think they are also not translatable.
+              <div>Reason: <strong>[% failureMessage %]</strong></div>

7) Could you add documenation to the database tables? I was wondering about the
line:
+  `casaId` int(11) NOT NULL default '0' COMMENT 'foreign key to
clubsAndServicesArchetypes', - not sure if COMMENT is a mysqlism. 

We had some discussion about following the standard in one of the IRC meetings
and agreed on using -- comment in the end. But I don't remember exactly why.

8) Another translation issue is the preset data you add in kohastructure.sql.
Also adding data to the tables is normally done by separate sql files, while
kohastructure is only creating the table structure without any data.

+-- Preset data for ClubsAndServicesArchetypes
+--
+
+INSERT INTO `clubsAndServicesArchetypes`...

9) There is a conflict marker in updatedatabase.pl and the version should be
set to be XXX.
+<<<<<<< HEAD
 $DBversion = "3.09.00.005";

10) There is some untranslatable JavaScript too. Example:
+    alert("Title is a required field");
+    alert("Description is a required field");

11) There is a large block of code commented out. Maybe delete it, if it's not
needed?
+<!-- These messages are uneccessary because you can see if it was deleted or
created immediately...
Also some typos in there 'Archtype'.

12) It looks like the old calendar is being used? Not sure here.
+        <img src="/intranet-tmpl/prog/en/lib/calendar/cal.gif" alt="Show
Calendar"  border="0" id="CalendarStartDate" style="cursor: pointer;" />

13) Ok, now I found something really big :(

The doc states:
HTML::Template file mailinglist.tmpl 

Also:
+use HTML::Template::Pro;

And then:
+++ b/misc/cronjobs/mailinglist/mailinglist.tmpl

This needs to be redone to use TT.

-- 
You are receiving this mail because:
You are watching all bug changes.