[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10965|1                           |0
        is obsolete|                            |

--- Comment #194 from Paul Poulain <paul.poulain at biblibre.com> ---
Comment on attachment 10965
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10965
Bug 6679 - [SIGNED-OFF] fix 2 perlcritic violations in
C4/Installer/PerlModules.pm

This patch has been reverted = jenkins complain:
perl t/Installer_pm.t 
1..4
ok 1 - use C4::Installer::PerlModules;
ok 2 - The object isa C4::Installer::PerlModules
ok 3 - returns numeric version
not ok 4 - returns correct version
#   Failed test 'returns correct version'
#   at t/Installer_pm.t line 23.
# Looks like you failed 1 test of 4.

After reverting, t/Installer_pm.t is OK

Maybe that's the test that must be upgraded, but until it's done, this patch is
reverted

-- 
You are receiving this mail because:
You are watching all bug changes.