[Koha-bugs] [Bug 8215] Add Course Reserves

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA

--- Comment #58 from Paul Poulain <paul.poulain at biblibre.com> ---
QA comment:
 * why is CourseReserve in Circulation tab ? Sounds strange to me (not a reason
to fail QA)
 * Authorised_values = hardcoded ones are usually hardcoded on
admin/authorised_values.pl. I think you can add safely DEPARTMENT and TERM.
Even if there is no DEPARTMENT And TERM, they appear, and the user know they
are here.
Look here:
    foreach (qw(Asort1 Asort2 Bsort1 Bsort2 SUGGEST DAMAGED LOST REPORT_GROUP
REPORT_SUBGROUP)) {
(in admin/authorised_values.pl)

 * I've added a DEPARTMENT: "Département Sciences". On course.pl, I get a
nasty:
D�partement Lettres after saving my 1st course (the diacritic reencoded or
something like that) I've added a diacritic to my TERM, and same problem: 2eme
trimestre ����. other fields are OK. I've checked other authorised values (like
in cataloguing, no encoding problem, it's specific to course.pl)

 * GRRR... you don't respect HTML4 coding guideline : "Add Reserves" should be
"Add reserves". There are many many strings like that

 * Step 2 of course/add_items.pl, I'm not sure I understand why& when
collection/itemtype/location/branch should change, and when it will. Some
documentation (online help ?) welcomed !

 * After adding a reserve to my course I see my branchname encoding broken as
well:  Unchanged (M�diath�que Cannet des Maures)

 * After adding a reserve to my course, I see that the itemtype is "Unchanged
()" the () make me think you don't handle the case where items.itype is empty,
the itemtype is in biblioitems.itemtype (that's what I have in my database)

 * I use the ccsr theme for OPAC, and couldn't find where I could access
opac-course.pl. I understood it's because you add a line to masthead.inc
+[% IF ( UseCourseReserves ) %]<span class="pipe"> | </span><a
href="/cgi-bin/koha/opac-course-reserves.pl">Course Reserves</a>[% END %]
that is not in ccsr masthead.inc
 Please add it !

 *Something I don't understand functionnally: I places a course reserve on an
item that was on loan. When I check-in the document, nothing happens (ie: i'm
not warned the item is for "course X" or something like that. Is it the
expected behaviour ? Some functionnal explanations are worth...

-- 
You are receiving this mail because:
You are watching all bug changes.