[Koha-bugs] [Bug 5335] More granular VAT

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #46 from Paul Poulain <paul.poulain at biblibre.com> ---
QA comment:
 * passes koha-qa.pl
 * a big patch, but not so much code. A lot is made of cleaning / change in
indentation/... like
-        $line{booksellerid}   = $booksellerid;
+        $line{booksellerid} = $booksellerid;

 * I'm not sure the following change
-            $biblionumber, $ordernumber, $quantityrec, $user, $unitprice,
-            $invoiceid, $replacement, undef, $datereceived, \@received_items);
+            $biblionumber,
+            $ordernumber,
+            $quantityrec,
+            $user,
+            $order->{unitprice},
+            $order->{ecost},
+            $invoiceno,
+            $order->{rrp},
+            undef,
+            $datereceived,
+            \@received_items,
+        );
 is very desirable, but I won't fail QA for that

* I'm not sure that t/db_dependent/lib/KohaTest/* is used, so the (tiny)
changes here are probably useless.

Conclusion = Passed QA !

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.