[Koha-bugs] [Bug 8215] Add Course Reserves

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215

--- Comment #59 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to comment #58)
> QA comment:
>  * why is CourseReserve in Circulation tab ? Sounds strange to me (not a
> reason to fail QA)

I'm nor sure what you mean by this. Could you post a screen shot?

>  * Authorised_values = hardcoded ones are usually hardcoded on
> admin/authorised_values.pl. I think you can add safely DEPARTMENT and TERM.
> Even if there is no DEPARTMENT And TERM, they appear, and the user know they
> are here.
> Look here:
>     foreach (qw(Asort1 Asort2 Bsort1 Bsort2 SUGGEST DAMAGED LOST
> REPORT_GROUP REPORT_SUBGROUP)) {
> (in admin/authorised_values.pl)

Will fix.

>  * I've added a DEPARTMENT: "Département Sciences". On course.pl, I get a
> nasty:
> D�partement Lettres after saving my 1st course (the diacritic reencoded or
> something like that) I've added a diacritic to my TERM, and same problem:
> 2eme trimestre ����. other fields are OK. I've checked other authorised
> values (like in cataloguing, no encoding problem, it's specific to course.pl)

I cannot really say. It must have something to due with the AuthorisedValues
plugin. If I use Dumper from the template, I get this:

$VAR1 = "D\x{e9}partement Sciences";

\x{e9} is indeed the code for é. The select pulldown for TERM and DEPARTMENT on
the course edit page look fine, but they use GetAuthorisedValues passed in as a
template parameter, rather than the TT plugin.

I have no idea what is going on here.

>  * GRRR... you don't respect HTML4 coding guideline : "Add Reserves" should
> be "Add reserves". There are many many strings like that

Sorry! I though I had caught all those. I've gone through the template again
and I think I've probably fixed them all now.

>  * Step 2 of course/add_items.pl, I'm not sure I understand why& when
> collection/itemtype/location/branch should change, and when it will. Some
> documentation (online help ?) welcomed !

The idea is to be able to change those fields while the item is on reserve for
at least one course. This is so we can change the circulation rules. For
example, an item might have a loan period of 2 weeks, but if it is on reserve
for an active course, it may change itemtypes and now have a loan period of 2
hours.

>  * After adding a reserve to my course I see my branchname encoding broken
> as well:  Unchanged (M�diath�que Cannet des Maures)

Again, it seems to be related to the plugin, but I don't know how to fix it :(

>  * After adding a reserve to my course, I see that the itemtype is
> "Unchanged ()" the () make me think you don't handle the case where
> items.itype is empty, the itemtype is in biblioitems.itemtype (that's what I
> have in my database)

I don't think this feature can play well with bib-level itemtypes. If one
record had 5 items and only 1 was on course reserve, it would change the
itemtype for all 5! I think I could just hide the itemtype field in the case
that itemtypes are set to bib-level, rather than item-level.

>  * I use the ccsr theme for OPAC, and couldn't find where I could access
> opac-course.pl. I understood it's because you add a line to masthead.inc
> +[% IF ( UseCourseReserves ) %]<span class="pipe"> | </span><a
> href="/cgi-bin/koha/opac-course-reserves.pl">Course Reserves</a>[% END %]
> that is not in ccsr masthead.inc
>  Please add it !

Will do!

>  *Something I don't understand functionnally: I places a course reserve on
> an item that was on loan. When I check-in the document, nothing happens (ie:
> i'm not warned the item is for "course X" or something like that. Is it the
> expected behaviour ? Some functionnal explanations are worth...

That is indeed expected behavior. The course reserves system was written based
on a specification I was given. I will definitely work with Nicole to make sure
it is fully documented in the manual.

-- 
You are receiving this mail because:
You are watching all bug changes.