[Koha-bugs] [Bug 8700] RESERVESLIP fields not being replaced correctly

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Sep 21 07:31:14 CEST 2012


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8700

Marc Véron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #11877|0                           |1
        is obsolete|                            |

--- Comment #4 from Marc Véron <veron at veron.ch> ---
Created attachment 12406
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12406&action=edit
[SIGNED-OFF] Bug 8700 - RESERVESLIP fields not being replaced correctly

The slip RESERVESLIP is not replacing fields correctly.
C4::Reserves::ReserveSlip calls C4::Letters::GetPreparedLetter,
and passes the $reserve hashref to it for each table except branches
( which is passed the branchcode ). The problem is, if you pass a
hashref for a table, it uses that hashref for the replacing, rather
than looking up the data from the database.

Fixed by passing the correct keys for each of the tables requested.

Signed-off-by: Marc Veron <veron at veron.ch>

Tested following the test plan.
Could reproduce the bug.
After applying the patch slip printed as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list