[Koha-bugs] [Bug 8798] Add the use of DBIx::Class

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle at bywatersolutions.com

--- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> ---
This is looking good. A couple comments though.

dummytest.pl output looks good. I don't know if you meant to include this file
though.

t/Context.t gives me:

DBIx::Class::Relationship::HasOne::might_have(): "might_have/has_one" must not
be on columns with is_nullable set to true
(Koha::Schema::Result::Borrower/cardnumber). This might indicate an incorrect
use of those relationship helpers instead of belongs_to. at
/home/koha/kohaclone/Koha/Schema/Result/Borrower.pm line 780

I'm not sure if this is really an issue or not, though. It seems like a problem
with our schema, not with his patch.

genDBIxFiles.sh works, but you have to modify the data in it. It would be nice
if it would find the db info in the koha conf file. At the very least, it could
ask for the database, username and password.

-- 
You are receiving this mail because:
You are watching all bug changes.