[Koha-bugs] [Bug 8798] Add the use of DBIx::Class

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798

--- Comment #21 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
(In reply to comment #20)
> (In reply to comment #19)
> > (In reply to comment #18)
> > > (In reply to comment #17)
> > 
> > > So you're sayng they exist in the database because they were added by
> > > updatedatabase but not in kohastructure.sql?
> > Yes I think so. I wondered if you were generating from a pristine db. (not
> > really a prob for this patch)  
> > > 
> > > > 
> > > > You've got an ActionLogs class but if you recreate the schema it generates
> > > > an ActionLog class (Standard behaviour the Loader generates a singular named
> > > > class for plural tables) shouls ActionLogs.pm be removed?
> > > 
> > > Are you saying when you ran the generation script it gave you the singular
> > > form?  I see the plural form in the Results file so I'm a bit confused as to
> > > how that slipped through as well.
> > Yes I get a ActionLog.pm which is what I would expect. Using your script or
> > dbicdump.
> 
> It was from my development DB, I'm not sure if that qualifies as pristine ;)
> I wouldn't be opposed to a QAA or Paul re-running the gen script and pushing
> their results.  This would probably resolve both of the aforementioned
> issues.  The important thing in this patch is less the class files and more
> the code addition in C4::Context for the schema handler.
> 
> Let me know if you'd like me to try and regen or if there is something we
> can get paul or a QAA to do.

Just out of curiosity if you remove ActionLogs.pm and regenerate does it create
ActionLog.pm or ActionLogs.pm

-- 
You are receiving this mail because:
You are watching all bug changes.