[Koha-bugs] [Bug 8832] can't enter a tax rate on vendor or when ordering

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8832

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paul.poulain at biblibre.com

--- Comment #10 from Paul Poulain <paul.poulain at biblibre.com> ---
(In reply to comment #9)
> Actually, perhaps the list should be parsed for %'s and then not multiply by
> 100. So that way you could have 12% or 0.12 to generate the same result. ;)

you're right here: it's written on the syspref description:
"Enter in Numeric form 0.12 for 12%. First is default. If you want more than 1
value, please separate with |"

(In reply to comment #6)
> It still seems like an undocumented change of behaviour that maybe belongs
> to a different development.

Katrin, I don't know what you mean here: the main purpose of bug 5335 was to
have tax rate at order line level, instead of bookseller level. In France,
books have a 5.5% VAT, while CD/DVD have a 19.6%. That was a big pain for
libraries.

The only problem I see here is that, if you have no tax rates defined, you just
have '0'.
Maybe a follow-up could display, if the syspref is empty "No tax rate entered,
go to syspref gist to define possible tax rate"

Also note that, now, the bookseller tax rate is just the *default* one. When
you enter an order line, you can always choose between all taxes listed in the
syspref.

> Also, what happens to those who have a tax
> rate already on a vendor but not in the preference and upgrade?
If you have already a tax that is one of the tax in the syspref, nothing
specific.
If you have a tax rate that is not in the syspref, then you'll be in trouble
when ordering, because you'll just get the "0"

Updating the gist syspref is something you *must* do when upgrading.
We could do a follow-up that does something like:
UPDATE syspref value= join '|', @{SELECT distinct gist FROM aqbooksellers}
(ie = put in the syspref all the distinct values that exist in the booksellers
tax rates)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.