[Koha-bugs] [Bug 7593] merging bib records loses connection to order line

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #19 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Jonathan,

In fact I think the problem described in bug 7593 is still present in master.
My VM was probably corrupted when I tested during Hackfest.

You still need to apply BZ 9780 to test this patch. BZ 9780 is signed off but
did not yet pass QA. If 7595 is more needed than 9780, I can copy the function
GetOrdersByBiblionumber in 7595.

If I suppress the line 
+ $myorder->{'biblioitemnumber'} = $tobiblio; #maybe useless
the biblioitemnumber of the suppressed record will still be present in
aqorders.biblioitemnumber, and that is not clean.

I thought the simpliest thing to do was to copy the biblionumber of the record
we keep in aqorders.biblionumber and aqorders.biblioitemnumber, because I
assumed biblionumber and biblioitemnumber were always the same.

But maybe I am wrong, so I used Acquisition::GetBiblioItemByBiblioNumber to get
the biblioitemnumber of $tobiblio record.
I am not sure I did it in a "perlish" way.
Could you take a look at my followup please?

-- 
You are receiving this mail because:
You are watching all bug changes.