[Koha-bugs] [Bug 9588] weighted search query with index

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Apr 5 11:22:15 CEST 2013


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9588

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off
   Patch complexity|Trivial patch               |Medium patch

--- Comment #8 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA Comment:
I am marking this one as Medium patch. It is certainly not trivial because of
the side effects in Search.pm. 

I have tested quite a lot of searches and have still some doubts. But IMO the
balance for pushing this patch goes to the positive side.

This patch makes that the results for a search like Title=art are different
than for Title=art* (QueryWeightFields enabled). That is very welcome!
With stemming on, there will be no difference between Title=art and Title=art*,
but the other three possibilities with Fuzzy/Stemming have all different
results now.

My only problem is that the number of hits for Title=art can now exceed the
hits for Title=art*. We cannot be proud of that ;) In a small testdb with Fuzzy
and Stemming, I now have 237 for art and always 222 for art*. This is a very
funny side-effect of this patch, although the cause of this difference is that
QueryWeightFields is ignored when detecting truncation somewhere else in
Search.pm. 

At the end I do not feel that this patch should be blamed for this bug. It
repairs Fuzzy and Stemming for index searches, but just makes visible that the
code for truncation kills the other options in a very specific context, the
index search where the user adds truncation manually. We can wonder how many
people will search that way in comparison to the number of people using an
index field without truncation. That makes the balance go to push for me..

I will mark this as Passed QA, but will send a message to QA team and RM to
allow them to give another opinion as well.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list