[Koha-bugs] [Bug 10052] New: Make intranetstylesheet and intranetcolorstylesheet behave exactly like their opac counterparts

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10052

            Bug ID: 10052
           Summary: Make intranetstylesheet and intranetcolorstylesheet
                    behave exactly like their opac counterparts
    Classification: Unclassified
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: minor
          Priority: P5 - low
         Component: Staff Client
          Assignee: m.de.rooy at rijksmuseum.nl
          Reporter: m.de.rooy at rijksmuseum.nl
                CC: gmcharlt at gmail.com

This is actually a followup on bug 8263: Make OPAC stylesheet preferences more
consistent.
The changes for intranet smaller.

Pref intranetstylesheet may be blank: meaning use staff-global.css (no change)
if it contains a full http or https prefixed string, use that (no change)
if it contains a root symbol / at the start, just follow the pref (no change)
if it contains something else, it should be interpreted as relative and
prefixed with [themelanguage]/css (this is NEW behavior and just like OPAC)

Pref intranetcolorstylesheet now is always prefixed with theme/css.
For consistency with opac and intranetstylesheet, we should add the above logic
for an absolute path (root symbol) or http(s) prefixed path.
This means that we add new behavior: allow css for colors outside the themedir
and even remote.

Does this change need a db revision?
If intranetstylesheet now contains say $relpath (not blank and not starting
with http or root symbol), and we must assume that it worked :), we cannot
simply prefix it with theme. What to do?
Most safe approach is: prefix $relpath with / here.
So: Yes, we do need a db rev for this unusual case.
There is no change needed for the intranetcolorstylesheet.

This report changes include doc-head-close.inc, and updates the descriptions
for the prefs in staff_client.pref, with a dbrev in updatedatabase.pl.

-- 
You are receiving this mail because:
You are watching all bug changes.