[Koha-bugs] [Bug 8562] RandomizeHoldsQueueWeight ignored if StaticHoldsQueueWeight is empty.

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8562

Kyle M Hall <kyle.m.hall at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff
                 CC|                            |kyle.m.hall at gmail.com

--- Comment #14 from Kyle M Hall <kyle.m.hall at gmail.com> ---
> I do not think that this is correct. The branches are shuffled regardless of
> the value of RandomizeHoldsQueueWeight. Perhaps better would be:
> @branches_to_use ||= keys %{GetBranches()}; # (or the correct version of
> that statement, since I didn't test my suggestion)
> right after the definition of @branches_to_use?

The justification for this is that it is extremely unlikely that a library
would want to fill holds from libraries in alphabetical order in the case that
the library has not populated StaticHoldsQueueWeight. Do you believe this is an
unreasonable assumption?

-- 
You are receiving this mail because:
You are watching all bug changes.