[Koha-bugs] [Bug 10041] Provide a koha-translate script to aid package users on installing translations

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Apr 15 17:31:29 CEST 2013


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10041

--- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to comment #2)
> Testing.
> 
> 1) -i|u|r without lang code dies with (shift: can't shift that many)
>    perhaps check if langcode and die with a graceful message.
>    Unless you try to mimic what translate script do without lang code,
>    install/update/remove all langs.

Ok, fixed.

> 2) List all. There are 2 files with "opac" in name (prog|ccsr), 
>    so you report twice.
>    Perhaps using $(ls $PO_DIR *-i-opac-t-prog-v-3006000.po)?

I did't notice because the current packages don't ship the ccsr theme. Fixed.

> 3) Install. Could test if all lang files are present? (staf|opac|ccsr|pref)
>    only to report any missing, and then proceed (translate script will 
>    complain anyway).

Added the -c|--check switches. The check is performed on update and install
commands, and prevents from running if some .PO file is missing.

> 4) Remove ok. Sysprefs language and opaclanguages could reference
>    a removed lang but I think it's harmless.

Oh, at least I wrote an 'rm -rf' command that does not fail! 

> 5) Update. The message if you try to install again a lang is misleading.
>    update option in 'misc/translator/translate' script is not to
>    update translated files but to update translation files (PO).
>    So, if your update is to re-install, do so (install) silently. 
>    Or change the message to reflect what you are really doing
>    and allow a re-install.
>    Or remove update option.

As I'm focusing on the end user (non-techie) the idea is that new .PO are
provided and they can use the script to update the templates. So, different
semantics from the 'translate' command. Fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.


More information about the Koha-bugs mailing list