[Koha-bugs] [Bug 8264] local cover images not working in IE8

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Apr 19 16:03:38 CEST 2013


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8264

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #17431|0                           |1
        is obsolete|                            |

--- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 17553
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17553&action=edit
Bug 8264 - local cover images not working in IE8 [ prog ]

Edmund, rather than myself, was the author of this patch, so I'm not entirely
sure about his code choices, but...it looks like IE must process images
differently than other browsers.

It seems to me that the images are not appearing in IE, because they're being
regarded as incomplete or having 0/NULL natural width.

This patch simply introduces a try/catch hack where it tries to add the image
and remove any "no-image" elements even when the image is considered
incomplete/width of 0/NULL. It won't do this if it catches any errors, although
I'm not sure that any errors would be caught with this set up anyway...

It's certainly not the ideal solution, but it's a solution.

To Test:

Before applying the patch:
1) Use IE and FF/Chrome/other browser to view a record with local images
attached
2) Note that the local images appear in FF/Chrome/other, but not in IE

Apply patch.

After applying the patch:
1) Repeat step 1 from above
2) Note that the local images now appear in all browsers as they should.

--

As I mentioned before, this seems like a real suboptimal solution. Any ideas on
why IE might be considering local images to be incomplete or having 0/NULL
natural width?

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list