[Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information.

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Comment on attachment 17598
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17598
Ability to link directly from an item in the Staff client to budget information

Review of attachment 17598:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10013&attachment=17598)
-----------------------------------------------------------------

Hi Amit,

I found a couple of problems with this patch - I have noted them using the
splinter review below. Please take a look at the coding guidelines in the wiki
(http://wiki.koha-community.org/wiki/Coding_Guidelines).

Also, I am not sure about the workflow here. Can you perhaps explain the use
case for the link to the budget?

::: C4/Acquisition.pm
@@ +75,1 @@
>  

Capitalization seems a bit off here.
Also, unit tests are mandatory for every new sub in the C4 and Koha namespaces.

::: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
@@ +370,4 @@
>                  [% IF ( SpineLabelShowPrintOnBibDetails ) %]<th>Spine label</th>[% END %]
>                  [% IF ( hostrecords ) %]<th>Host records</th>[% END %]
>                  [% IF ( analyze ) %]<th>Used in</th><th></th>[% END %]
> +                [% IF ( itemdata_booksellerid ) %]<th>Budget Information</th>[% END %]

Wrong capitalization.

@@ +523,5 @@
>                          <td><a href="/cgi-bin/koha/cataloguing/addbiblio.pl?hostbiblionumber=[% item.biblionumber %]&hostitemnumber=[% item.itemnumber %]">Create analytics</a></td>
> +                    [% END %] 
> +                    [% IF ( itemdata_booksellerid ) %]
> +                        <td><a href="/cgi-bin/koha/admin/aqbudgets.pl?budget_period_id=[% item.budget_period_id %]" >[% item.budget_name %]</a></td>
> +                    [% END %]    

I am not sure this is the right place for this information. If I read the code
correctly, this will appear in the holdings table on the detail page. All other
acq related information is shown on the holdings tab.

-- 
You are receiving this mail because:
You are watching all bug changes.